On 8 December 2015 at 16:19, Michael S. Tsirkin <m...@redhat.com> wrote: > On Tue, Dec 08, 2015 at 04:54:57PM +0100, Greg Kurz wrote: >> Since commit 4652f1640e029e1f2433fa77ba6af285 "virtio-9p: add savevm >> handlers", >> if the user hot-unplugs a quiescent 9p device and live migrates, the source >> QEMU crashes before migration completetion... This happens because virtio-9p >> devices have a realize handler which calls virtio_init() and >> register_savevm(). >> Both calls store pointers to the device internals, that get dereferenced >> during >> migration even if the device got unplugged. >> >> This patch simply adds an unrealize handler to perform minimal cleanup and >> avoid the crash. Hot unplug of non-quiescent 9p devices is still not >> supported >> in QEMU, and not supported by linux guests either. >> >> Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> > > Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
Applied to master, thanks. (I wrapped the lines in the commit message which were a bit too long; wrap at 75 chars or so is recommended so that when you read the commit via 'git log' on an 80 column terminal they still fit.) thanks -- PMM
