Bandan Das writes:
> Markus Armbruster writes:
>
>> Bandan Das writes:
>>
>>> There's no indication of any sort that i440fx doesn't support
>>> "iommu=on"
>>>
>>> Reviewed-by: Eric Blake
>>> Signed-off-by: Bandan Das
>>> ---
>>> hw/pci-host/piix.c | 5 +
>>> 1 file changed, 5 insertions(
Marc-André Lureau writes:
> nack, this isn't enough to silence the warning, as vhost-user-test
> uses -machine accel=tcg
Pity.
> On Mon, Nov 16, 2015 at 6:23 PM, wrote:
>> From: Marc-André Lureau
>>
>> vhost-user-test prints a warning. A test should not need to run on
>> hugetlbfs, let's si
From: Markus Armbruster
Union tag values can't clash with member names in generated C anymore
since commit e4ba22b, but QAPISchemaObjectTypeVariants.check() still
asserts they don't. Drop it.
Signed-off-by: Markus Armbruster
Message-Id: <1446559499-26984-1-git-send-email-arm...@redhat.com>
Sig
From: Markus Armbruster
This hunk
@@ -964,6 +965,7 @@ class QAPISchemaObjectType(QAPISchemaType):
members = []
seen = {}
for m in members:
+assert c_name(m.name) not in seen
seen[m.name] = m
for m in sel
From: Markus Armbruster
Reduce the ugly flat union / simple union conditional by doing just
the essential work here, namely setting self.tag_member.
Move the rest to callers.
Signed-off-by: Markus Armbruster
Message-Id: <1446559499-26984-7-git-send-email-arm...@redhat.com>
[rebase to earlier ch
From: Markus Armbruster
QAPISchemaObjectTypeMember.check() currently does four things:
1. Compute self.type
2. Accumulate members in all_members
Only one caller cares: QAPISchemaObjectType.check() uses it to
compute self.members. The other callers pass a throw-away
accumulator.
3. A
From: Markus Armbruster
QAPISchemaObjectTypeVariants.check() parameter members and
QAPISchemaObjectTypeVariant.check() parameter seen are no longer used,
drop them.
Signed-off-by: Markus Armbruster
Message-Id: <1446559499-26984-3-git-send-email-arm...@redhat.com>
[rebase to earlier changes that
Simplify gen_struct_fields() back to a single iteration over a
list of fields (like it was prior to commit f87ab7f9), by moving
the generated comments to gen_object(). Then, inline
gen_struct_field() into its only caller.
Signed-off-by: Eric Blake
---
v12: no change
v11: no change
v10: no chang
Now that branches are in a separate C namespace, we can remove
the restrictions in the parser that claim a branch name would
collide with QMP, and delete the negative tests that are no
longer problematic. A separate patch can then add positive
tests to qapi-schema-test to test that any corner case
We were previously creating all unions with an empty list for
local_members. However, it will make it easier to unify struct
and union generation if we include the generated tag member in
local_members. That way, we can have a common code pattern:
visit the base (if any), visit the local members
From: Markus Armbruster
We can use seen.values() instead if we make it an OrderedDict.
Signed-off-by: Markus Armbruster
Message-Id: <1446559499-26984-5-git-send-email-arm...@redhat.com>
Signed-off-by: Eric Blake
---
v12: no change
v11: no change
v10: redo closer to Markus' original proposal
v
These two methods are now close enough that we can finally merge
them, relying on the fact that simple unions now provide a
reasonable local_members. Change gen_struct() to gen_object()
that handles all forms of QAPISchemaObjectType, and rename and
shrink gen_union() to gen_variants() to handle th
Detect attempts to declare two object members that would result
in the same C member name, by keying the 'seen' dictionary off
of the C name rather than the qapi name. It also requires passing
info through the check_clash() methods.
This addresses a TODO and fixes the previously-broken
args-name-
From: Markus Armbruster
While there, stick in a TODO change key of seen from QAPI name to C
name. Can't do it right away, because it would fail the assertion for
tests/qapi-schema/args-has-clash.json.
Signed-off-by: Markus Armbruster
Message-Id: <1446559499-26984-6-git-send-email-arm...@redhat
Checking that a given QAPISchemaObjectTypeVariant.name is a
member of the corresponding QAPISchemaEnumType of the owning
QAPISchemaObjectTypeVariants.tag_member ensures that there are
no collisions in the generated C union for those tag values
(since the enum itself should have no collisions).
How
No pending prerequisites; based on qemu.git master
Also available as a tag at this location:
git fetch git://repo.or.cz/qemu/ericb.git qapi-cleanupv12d
and will soon be part of my branch with the rest of the v5 series, at:
http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/qapi
v12 notes:
Dela
Consolidate two common sequences of clash detection into a
new QAPISchemaObjectType.check_clash() helper method.
No change to generated code.
Signed-off-by: Eric Blake
---
v12: no change
v11: don't lose isinstance check, and don't hide type.check()
inside check_clash()
v10: rebase on new Varian
Now that we no longer collide with an implicit _MAX enum member,
we no longer need to reject it in the ad hoc parser, and can
remove several tests that are no longer needed.
Signed-off-by: Eric Blake
---
v12: new patch
---
scripts/qapi.py| 8 +++-
tests/Makefile
The qapi enum ErrorClass is unusual that it uses 'CamelCase' names,
contrary to our documented convention of preferring 'lower-case'.
However, this enum is entrenched in the API; we cannot change
what strings QMP outputs. Meanwhile, we want to simplify how
c_enum_const() is used to generate enum c
Future commits will migrate semantic checking away from parsing
and over to the various QAPISchema*.check() methods. But to
report an error message about an incorrect semantic use of a
member of an object type, it helps to know which type, command,
or event owns the member. In particular, when a
Now that alternates no longer use an implicit tag, we can
inline _make_implicit_tag() into its one caller of
_def_union_type().
No change to generated code.
Suggested-by: Markus Armbruster
Signed-off-by: Eric Blake
---
v12: new patch
---
scripts/qapi.py | 9 +++--
1 file changed, 3 insert
Right now, our ad hoc parser ensures that we cannot have a
flat union that introduces any members that would clash with
non-variant members inherited from the union's base type (see
flat-union-clash-member.json). We want ObjectType.check() to
make the same check, so we can later reduce some of the
The QMP input visitor allows integral values to be assigned by
promotion to a QTYPE_QFLOAT. However, when parsing an alternate,
we did not take this into account, such that an alternate that
accepts 'number' and some other type, but not 'int', would reject
integral values.
With this patch, we now
Commit cbc95538 removed unused start_handle() and end_handle(),
but forgot to remove their declarations.
Signed-off-by: Eric Blake
---
v12 (no v10-11): Split off obvious piece from v9 26/27
v9: no change
v8: no change
v7: no change
v6: no change
---
include/qapi/visitor.h | 3 ---
1 file change
We already documented that qapi names should match specific
patterns (such as starting with a letter unless it was an enum
value or a downstream extension). Tighten that from a suggestion
into a hard requirement, which frees up names beginning with a
single underscore for qapi internal usage. Als
What's more meta than using qapi to define qapi? :)
Convert QType into a full-fledged[*] builtin qapi enum type, so
that a subsequent patch can then use it as the discriminator
type of qapi alternate types. Fortunately, the judicious use of
'prefix' in the qapi definition avoids churn to the spel
The method c_name() is supposed to do two different actions: munge
'-' into '_', and add a 'q_' prefix to ticklish names. But it did
these steps out of order, making it possible to submit input that
is not ticklish until after munging, where the output then lacked
the desired prefix.
The failure
For less code, reflect the determined boolean value of an optional
visit back to the caller instead of making the caller read the
boolean after the fact.
The resulting generated code has the following diff:
|-visit_optional(v, &has_fdset_id, "fdset-id");
|-if (has_fdset_id) {
|+if (vi
No need to keep two separate enums, where editing one is likely
to forget the other. Now that we can specify a qapi enum prefix,
we don't even have to change the bulk of the uses.
get_event_by_name() could perhaps be replaced by qapi_enum_parse(),
but I left that for another day.
CC: Kevin Wolf
Our qapi conventions document that '.' should only be used in
the prefix of downstream names. BlkdebugEvent was a lone
exception to this. Changing this is not backwards compatible
to the 'blockdev-add' QMP command; however, that command is
not yet fully stable. It can also be argued that the tes
The CpuInfo struct is used only by the 'query-cpus' output
command, so we are free to modify it by adding fields (clients
are already supposed to ignore unknown output fields), or by
changing optional members to mandatory, while still keeping
QMP wire compatibility with older versions of qemu.
Whe
When munging enum values, the fact that we were passing the entire
prefix + value through camel_to_upper() meant that enum values
spelled with CamelCase could be turned into CAMEL_CASE. However,
this provides a potential collision (both OneTwo and One-Two would
munge into ONE_TWO) for enum types,
None of the visitor callbacks would set an error when testing
if an optional field was present; make this part of the interface
contract by eliminating the errp argument.
The resulting generated code has a nice diff:
|-visit_optional(v, &has_fdset_id, "fdset-id", &err);
|-if (err) {
|-
The QObject hierarchy is small enough, and unlikely to grow further
(since we only use it to map to JSON and already cover all JSON
types), that we can simplify things by not tracking a separate
vtable, but just inline all two elements of the vtable QType
directly into QObject. We can drop qnull_d
Now that we guarantee the user doesn't have any enum values
beginning with a single underscore, we can use that for our
own purposes. Renaming ENUM_MAX to ENUM__MAX makes it obvious
that the sentinel is generated.
This patch was mostly generated by applying a temporary patch:
|diff --git a/scrip
From: Marc-André Lureau
vhost-user-test prints a warning. A test should not need to run on
hugetlbfs, let's silence the warning under qtest. The
condition can't check on qtest_enabled() since vhost-user-test actually
doesn't use qtest accel. However, qtest_driver() can be used, if
qtest_init() is
In general, designing user interfaces that rely on case
distinction is poor practice. Another benefit of enforcing
a restriction against case-insensitive clashes is that we
no longer have to worry about the situation of enum values
that could be distinguished by case if mapped by c_name(),
but whi
Add positive tests to qapi-schema-test for things that were
made possible by recent patches but which caused compile errors
due to collisions prior to that point. The focus is mainly on
collisions due to names we have reserved for qapi, even though
it is unlikely that anyone will want to abuse the
The name QType is more in line with our conventions for qapi
types, and matches the fact that each enum member has a prefix
of QTYPE_.
Signed-off-by: Eric Blake
---
v12: new patch split off of 21/28
---
block/qapi.c | 4 ++--
include/hw/qdev-core.h | 2 +-
include/qapi/qmp/qob
Previously, working with alternates required two lookup arrays
and some indirection: for type Foo, we created Foo_qtypes[]
which maps each qtype to a value of the generated FooKind enum,
then look up that value in FooKind_lookup[] like we do for other
union types.
This has a couple of subtle bugs.
On 11/18/15 00:41, Alex Williamson wrote:
> For quirks that support the full PCIe extended config space, limit the
> quirk to only the size of config space available through vfio. This
> allows host systems with broken MMCONFIG regions to still make use of
> these quirks without generating bad add
On 11/17/2015 06:43 PM, Paolo Bonzini wrote:
Hi Richard, it would be nice to have these patches---or at least the
XSAVE support---in 2.6. I also have a PKRU implementation for TCG, but
currently I'm only implementing RDPKRU/WRPKRU because I would like to
build the XSAVE support on top of your pa
Eric Blake writes:
> Right now, our ad hoc parser ensures that we cannot have a
> flat union that introduces any members that would clash with
> non-variant members inherited from the union's base type (see
> flat-union-clash-member.json). We want ObjectType.check() to
Recommend not to abbrevia
On Tue, Nov 17, 2015 at 12:06:55PM -0700, Eric Blake wrote:
> On 11/17/2015 10:59 AM, Daniel P. Berrange wrote:
> > Suggested in
> >
> > https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg03298.html
> >
> > The config.status script is auto-generated by configure upon
> > completion. The i
On Tue, Nov 17, 2015 at 03:22:04PM -0700, Eric Blake wrote:
> On 11/17/2015 10:00 AM, Daniel P. Berrange wrote:
> > The socket_listen method accepts a QAPI SocketAddress object
> > which it then turns into QemuOpts before calling the
> > inet_listen_opts/unix_listen_opts helper methods. By
> > conv
Eric Blake writes:
> *** WARNING: THE ATTACHED DOCUMENT(S) CONTAIN MACROS ***
> *** MACROS MAY CONTAIN MALICIOUS CODE ***
> *** Open only if you can verify and trust the sender ***
> *** Please contact info...@redhat.com if you have questions or concerns **
Looks like infosec crapped over your c
On Tue, Nov 17, 2015 at 03:40:58PM -0700, Eric Blake wrote:
> On 11/17/2015 10:00 AM, Daniel P. Berrange wrote:
> > The socket_connect method accepts a QAPI SocketAddress object
> > which it then turns into QemuOpts before calling the
> > inet_connect_opts/unix_connect_opts helper methods. By
> > c
On 18/11/2015 10:43, Richard Henderson wrote:
>> 1) pester Intel some more so that they disclose the format of the SMM
>> state save area;
>
> They have done so, and relatively well. Section 34.4.1.1 of the
> software developer's manual (I'm looking at 325462-055, June 2015).
Relatively well u
Eric Blake writes:
> *** WARNING: THE ATTACHED DOCUMENT(S) CONTAIN MACROS ***
> *** MACROS MAY CONTAIN MALICIOUS CODE ***
> *** Open only if you can verify and trust the sender ***
> *** Please contact info...@redhat.com if you have questions or concerns **
Another one.
> The method c_name() is
On Wed, Nov 18, 2015 at 11:08:58AM +0100, Markus Armbruster wrote:
> Eric Blake writes:
>
> > *** WARNING: THE ATTACHED DOCUMENT(S) CONTAIN MACROS ***
> > *** MACROS MAY CONTAIN MALICIOUS CODE ***
> > *** Open only if you can verify and trust the sender ***
> > *** Please contact info...@redhat.c
Eric Blake writes:
> No need to keep two separate enums, where editing one is likely
> to forget the other. Now that we can specify a qapi enum prefix,
> we don't even have to change the bulk of the uses.
>
> get_event_by_name() could perhaps be replaced by qapi_enum_parse(),
> but I left that f
The config.status script is auto-generated by configure upon
completion. The intention is that config.status can be later
invoked by the developer to re-detect the same environment
that configure originally used. The current config.status
script, however, only contains a record of the command line
On 17/11/2015 12:41, Fam Zheng wrote:
> +/* Wait for I/O to this cluster (from a previous iteration) to be
> + * done.*/
> +while (test_bit(next_chunk, s->in_flight_bitmap)) {
> +trace_mirror_yield_in_flight(s, next_sector, s->in_flight);
> +s->wait
On Wed, Nov 18, 2015 at 06:45:39PM +1100, Alexey Kardashevskiy wrote:
> On 11/09/2015 07:47 PM, David Gibson wrote:
> >On Mon, Nov 09, 2015 at 05:47:17PM +1100, Alexey Kardashevskiy wrote:
> >>Section B.6.2.1 Root Node Properties of PAPR specification defines
> >>a set of properties which shall be
zhanghailiang wrote:
> For migration destination, sometimes we need to know its state,
> and it is also useful for tracing migration incoming process.
>
> Here we add a new member 'state' for MigrationIncomingState,
> and also use migrate_set_state() to modify its value.
> We fix the first paramet
Eric Blake wrote:
> Now that we guarantee the user doesn't have any enum values
> beginning with a single underscore, we can use that for our
> own purposes. Renaming ENUM_MAX to ENUM__MAX makes it obvious
> that the sentinel is generated.
>
> This patch was mostly generated by applying a tempora
"Denis V. Lunev" wrote:
for 2.9? You really plane very well in advance? O:-)
As you asked for review from migration side
> with test
> while /bin/true ; do
> virsh snapshot-create rhel7
> sleep 10
> virsh snapshot-delete rhel7 --current
> done
> with enable
"Denis V. Lunev" wrote:
> The patch enforces proper locking for this operation.
>
> Signed-off-by: Denis V. Lunev
> Reviewed-by: Greg Kurz
> Reviewed-by: Stefan Hajnoczi
> Reviewed-by: Fam Zheng
> CC: Juan Quintela
> CC: Kevin Wolf
Reviewed-by: Juan Quintela
"Denis V. Lunev" wrote:
> this will make code better in the next patch
>
> Signed-off-by: Denis V. Lunev
> Reviewed-by: Stefan Hajnoczi
> Reviewed-by: Fam Zheng
> CC: Juan Quintela
> CC: Kevin Wolf
Reviewed-by: Juan Quintela
"Denis V. Lunev" wrote:
> to delete snapshots from all loaded block drivers.
>
> The patch also ensures proper locking.
>
> Signed-off-by: Denis V. Lunev
> Reviewed-by: Stefan Hajnoczi
> Reviewed-by: Fam Zheng
> CC: Juan Quintela
> CC: Kevin Wolf
Reviewed-by: Juan Quintela
I will still sug
"Denis V. Lunev" wrote:
> to switch to snapshot on all loaded block drivers.
>
> The patch also ensures proper locking.
>
> Signed-off-by: Denis V. Lunev
> Reviewed-by: Greg Kurz
> Reviewed-by: Stefan Hajnoczi
> Reviewed-by: Fam Zheng
> CC: Juan Quintela
> CC: Kevin Wolf
Reviewed-by: Juan Q
"Denis V. Lunev" wrote:
> We should check that all inserted and not read-only images support
> snapshotting. This could be made using already invented helper
> bdrv_all_can_snapshot().
>
> Signed-off-by: Denis V. Lunev
Reviewed-by: Juan Quintela
"Denis V. Lunev" wrote:
> There is no much sense to do the check and write warning.
>
> Signed-off-by: Denis V. Lunev
> Reviewed-by: Stefan Hajnoczi
> Reviewed-by: Fam Zheng
> CC: Juan Quintela
Reviewed-by: Juan Quintela
On 11/18/2015 01:56 PM, Juan Quintela wrote:
"Denis V. Lunev" wrote:
for 2.9? You really plane very well in advance? O:-)
ha-ha :)
wrong character replaced. I have planned to switch v8 to v9
but typed 9 instead of 5 2 symbols before...
Den
"Denis V. Lunev" wrote:
> to check that snapshot is available for all loaded block drivers.
> The check bs != bs1 in hmp_info_snapshots is an optimization. The check
> for availability of this snapshot will return always true as the list
> of snapshots was collected from that image.
>
> The patch
"Denis V. Lunev" wrote:
> to create snapshot for all loaded block drivers.
>
> The patch also ensures proper locking.
>
> Signed-off-by: Denis V. Lunev
> Reviewed-by: Stefan Hajnoczi
> Reviewed-by: Fam Zheng
> CC: Juan Quintela
> CC: Kevin Wolf
Reviewed-by: Juan Quintela
"Denis V. Lunev" wrote:
> The patch also ensures proper locking for the operation.
>
> Signed-off-by: Denis V. Lunev
> Reviewed-by: Stefan Hajnoczi
> Reviewed-by: Fam Zheng
> CC: Juan Quintela
> CC: Kevin Wolf
Reviewed-by: Juan Quintela
"Denis V. Lunev" wrote:
> State deletion can be performed on running VM which reduces VM downtime
> This approach looks a bit more natural.
>
> Signed-off-by: Denis V. Lunev
> Reviewed-by: Stefan Hajnoczi
> Reviewed-by: Fam Zheng
> CC: Juan Quintela
Reviewed-by: Juan Quintela
On 13/11/2015 18:57, Peter Crosthwaite wrote:
> On Fri, Nov 13, 2015 at 9:53 AM, Paolo Bonzini wrote:
>> These are the people that I think have been touching it lately
>> or reviewing patches.
>>
>> Signed-off-by: Paolo Bonzini
>
>
>> ---
>> MAINTAINERS | 17 +
>> 1 file chan
On 04/11/2015 22:21, Eduardo Habkost wrote:
> Quickly hacked test case for memory instructions (clflush, mfence,
> sfence, lfence, clflushopt, clwb, pcommit), that simply checks for #UD
> exceptions.
>
> This was useful to test TCG handling of those instructions.
>
> The "fake clwb" part will p
"Denis V. Lunev" wrote:
> basically all bdrv_* operations must be called under aio_context_acquire
> except ones with bdrv_all prefix.
>
> Signed-off-by: Denis V. Lunev
> Reviewed-by: Stefan Hajnoczi
> Reviewed-by: Fam Zheng
> CC: Juan Quintela
> CC: Kevin Wolf
I will preffer that migration
On 14/11/2015 00:25, Matt Gingell wrote:
> +#define APIC_DELIVERY_MODE_SHIFT 8;
> +#define APIC_POLARITY_SHIFT 14;
> +#define APIC_TRIG_MODE_SHIFT 15;
> +
Stray semicolons, fixed and queued for QEMU 2.6.
Paolo
"Denis V. Lunev" wrote:
Hi
Kevin, Stefan
> with test
> while /bin/true ; do
> virsh snapshot-create rhel7
> sleep 10
> virsh snapshot-delete rhel7 --current
> done
> with enabled iothreads on a running VM leads to a lot of troubles: hangs,
> asserts, errors.
>
>
"Denis V. Lunev" wrote:
> This would be useful in the next step when QMP version of this call will
> be introduced.
>
> Signed-off-by: Denis V. Lunev
> CC: Juan Quintela
> CC: Amit Shah
> CC: Markus Armbruster
> CC: Eric Blake
Reviewed-by: Juan Quintela
Markus Armbruster wrote:
> "Denis V. Lunev" writes:
>
>> Signed-off-by: Denis V. Lunev
>> CC: Juan Quintela
>> CC: Amit Shah
>> CC: Markus Armbruster
>> CC: Eric Blake
>> ---
>> migration/savevm.c | 5 +
>> qapi-schema.json | 13 +
>> qmp-commands.hx| 25 +
Markus Armbruster wrote:
> "Denis V. Lunev" writes:
>
>> Signed-off-by: Denis V. Lunev
>> CC: Juan Quintela
>> CC: Amit Shah
>> CC: Markus Armbruster
>> CC: Eric Blake
>> ---
>> migration/savevm.c | 27 ++-
>> qapi-schema.json | 13 +
>> qmp-commands.hx
"Denis V. Lunev" wrote:
> Signed-off-by: Denis V. Lunev
> CC: Juan Quintela
> CC: Amit Shah
> CC: Markus Armbruster
> CC: Eric Blake
I agree with the changes, move them to hmp.c as Markus suggests.
"Denis V. Lunev" wrote:
> Signed-off-by: Denis V. Lunev
> CC: Juan Quintela
> CC: Amit Shah
> CC: Markus Armbruster
> CC: Eric Blake
> ---
> migration/savevm.c | 5 +
> qapi-schema.json | 13 +
> qmp-commands.hx| 23 +++
> 3 files changed, 41 insert
Some feratures (such as ctrl vq) are supported
by qemu without need to communicate with the
backend.
Drop them from the feature mask so we set them
unconditionally.
Reported-by: Victor Kaplansky
Signed-off-by: Michael S. Tsirkin
---
Changes since v1:
re-add VIRTIO_NET_F_GUEST_ANNOUNCE, add
From: "Dr. David Alan Gilbert"
Hi,
These are 3 migration fixes that fix things I messed up.
Only the 1st one (set last_sent_block) fixes a problem, the other
two fix coverity findings.
Dave
Dr. David Alan Gilbert (3):
Set last_sent_block
migration: Dead assignment of current_time
Unneed
From: "Dr. David Alan Gilbert"
In a82d593b61054b3dea43 I accidentally removed the setting of
last_sent_block, put it back.
Symptoms:
Multithreaded compression only uses one thread.
Migration is a bit less efficient since it won't use 'cont' flags.
Signed-off-by: Dr. David Alan Gilbert
Fix
From: "Dr. David Alan Gilbert"
I set current_time before the postcopy test but never use it;
(I think this was from the original version where it was time based).
Spotted by coverity, CID 1339208
Signed-off-by: Dr. David Alan Gilbert
---
migration/migration.c | 1 -
1 file changed, 1 deletion(
From: "Dr. David Alan Gilbert"
The check is unneccesary, we read the value at the start of the
thread, use it, and never change it. The value is checked to be
non-NULL before thread creation.
Spotted by coverity, CID 1339211
Signed-off-by: Dr. David Alan Gilbert
---
migration/migration.c | 2
Eric Blake writes:
> We already documented that qapi names should match specific
> patterns (such as starting with a letter unless it was an enum
> value or a downstream extension). Tighten that from a suggestion
> into a hard requirement, which frees up names beginning with a
> single underscor
"Dr. David Alan Gilbert (git)" wrote:
> From: "Dr. David Alan Gilbert"
>
> In a82d593b61054b3dea43 I accidentally removed the setting of
> last_sent_block, put it back.
>
> Symptoms:
> Multithreaded compression only uses one thread.
> Migration is a bit less efficient since it won't use 'con
"Dr. David Alan Gilbert (git)" wrote:
> From: "Dr. David Alan Gilbert"
>
> The check is unneccesary, we read the value at the start of the
> thread, use it, and never change it. The value is checked to be
> non-NULL before thread creation.
>
> Spotted by coverity, CID 1339211
>
> Signed-off-by:
"Dr. David Alan Gilbert (git)" wrote:
> From: "Dr. David Alan Gilbert"
>
> I set current_time before the postcopy test but never use it;
> (I think this was from the original version where it was time based).
> Spotted by coverity, CID 1339208
>
> Signed-off-by: Dr. David Alan Gilbert
Reviewed-
Am 18.11.2015 um 11:30 hat Markus Armbruster geschrieben:
> Eric Blake writes:
>
> > No need to keep two separate enums, where editing one is likely
> > to forget the other. Now that we can specify a qapi enum prefix,
> > we don't even have to change the bulk of the uses.
> >
> > get_event_by_na
On 17 November 2015 at 19:11, Eduardo Habkost wrote:
> The following changes since commit 9be060f5278dc0d732ebfcf2bf0a293f88b833eb:
>
> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request'
> into staging (2015-11-17 11:33:38 +)
>
> are available in the git repository at:
Hi
Please, send any topic that you are interested in covering.
At the end of Monday I will send an email with the agenda or the
cancellation of the call, so hurry up.
After discussions on the QEMU Summit, we are going to have always open a
KVM call where you can add topics.
Call details:
By
On 11/11/2015 01:27, Benjamin Herrenschmidt wrote:
> if (bridge_dev->flags & (1 << PCI_BRIDGE_DEV_F_SHPC_REQ)) {
> +/* SHCP gets upset if we try to use slot 0 */
> +br->sec_bus.devfn_min = PCI_FUNC_MAX;
> dev->config[PCI_INTERRUPT_PIN] = 0x1;
> memory_region
On 11/11/2015 01:27, Benjamin Herrenschmidt wrote:
> This allows a bus class to tell whether a given bus has room for
> any new device. max_dev isn't sufficient as the rules can depend
> on some arguments or can differ between instances of a bus. This
> will be used by PCI in subsequent patches
>
On 11/11/2015 01:27, Benjamin Herrenschmidt wrote:
> This adds a devfn_max field to PCIBus and adds a pci_can_add_device()
> function which, if no "addr" (aka devfn) is specified, will tell whether
> there is any slot free between devfn_min and devfn_max.
>
> This will be used by some PCI root c
On 18/11/2015 13:31, Paolo Bonzini wrote:
>
>
> On 11/11/2015 01:27, Benjamin Herrenschmidt wrote:
>> if (bridge_dev->flags & (1 << PCI_BRIDGE_DEV_F_SHPC_REQ)) {
>> +/* SHCP gets upset if we try to use slot 0 */
>> +br->sec_bus.devfn_min = PCI_FUNC_MAX;
>> dev->confi
On 17 November 2015 at 20:12, John Snow wrote:
> The following changes since commit c27e9014d56fa4880e7d741275d887c3a5949997:
>
> Merge remote-tracking branch 'remotes/kraxel/tags/pull-vnc-20151116-1' into
> staging (2015-11-17 12:34:07 +)
>
> are available in the git repository at:
>
> h
On 17/11/2015 23:14, Rob Herring wrote:
> On Mon, Nov 16, 2015 at 2:38 AM, Paolo Bonzini wrote:
>>
>>
>> On 15/11/2015 03:07, Rob Herring wrote:
>>> We generally don't want DT docs to depend on other kernel documentation.
>>
>> DT docs do not contain a copy of the data sheets, either. There is no
Eric Blake writes:
> Now that we guarantee the user doesn't have any enum values
> beginning with a single underscore, we can use that for our
> own purposes. Renaming ENUM_MAX to ENUM__MAX makes it obvious
> that the sentinel is generated.
The ENUM__MAX are mildly ugly. If we cared, we could
On 17/11/15 17:13, James Hogan wrote:
> Commit 01f728857941 ("target-mips: Status.UX/SX/KX enable 32-bit address
> wrapping") added a new hflag MIPS_HFLAG_AWRAP, which indicates that
> 64-bit addressing is disallowed in the current mode, so hflag users
> don't need to worry about the complexities o
On 17 November 2015 at 23:06, Michael Roth wrote:
> The following changes since commit c27e9014d56fa4880e7d741275d887c3a5949997:
>
> Merge remote-tracking branch 'remotes/kraxel/tags/pull-vnc-20151116-1' into
> staging (2015-11-17 12:34:07 +)
>
> are available in the git repository at:
>
>
Eric Blake writes:
> When munging enum values, the fact that we were passing the entire
> prefix + value through camel_to_upper() meant that enum values
> spelled with CamelCase could be turned into CAMEL_CASE. However,
> this provides a potential collision (both OneTwo and One-Two would
> munge
1 - 100 of 317 matches
Mail list logo
