Re: [Qemu-devel] [PATCH] build: qemu-ga: add 'qemu-ga' build target for w32

2015-11-16 Thread Michael Roth
Quoting Stefan Weil (2015-11-15 02:13:36) > Am 09.09.2015 um 11:42 schrieb Paolo Bonzini: > > > > On 08/09/2015 17:47, Michael Roth wrote: > >> Currently POSIX builds rely on 'qemu-ga' target to do qga-only > >> distributable build. On w32, as with most standalone binary targets, > >> we rely on 'q

Re: [Qemu-devel] [Qemu-block] [PATCH] block: make 'stats-intervals' a list of integers

2015-11-16 Thread Stefan Hajnoczi
On Fri, Nov 13, 2015 at 11:50:03AM +0100, Alberto Garcia wrote: > On Fri 13 Nov 2015 11:15:52 AM CET, Stefan Hajnoczi > wrote: > > blockdev.c: In function ‘blockdev_init’: > > blockdev.c:636:17: error: ‘length’ may be used uninitialized in this > > function [-Werror=maybe-uninitialized] > >

[Qemu-devel] [PATCH v2] virtio-blk: Fix double completion for werror=stop

2015-11-16 Thread Fam Zheng
When a request R is absorbed by request M, it is appended to the "mr_next" queue led by M, and is completed together with the completion of M, in virtio_blk_rw_complete. With error policy equals stop, if M has an I/O error, now R also gets prepended to the per device DMA restart queue, which will

Re: [Qemu-devel] [PATCH v4 00/17] Add an IPMI device to QEMU

2015-11-16 Thread Benjamin Herrenschmidt
On Thu, 2015-11-12 at 13:02 -0600, miny...@acm.org wrote: > This is a long delayed patch set, but I think I have things reworked > to make Igor happy with the way ACPI and SMBIOS work.  This is more > consistent with the way most other things work, anyway.  It did > require adding stubs for systems

Re: [Qemu-devel] [PATCH] iotests: fix race in 030

2015-11-16 Thread Fam Zheng
On Wed, 11/11 15:27, John Snow wrote: > the stop_test case tests that we can resume a block-stream > command after it has stopped/paused due to error. We cannot > always reliably query it before it finishes after resume, though, > so make this a conditional. > > The important thing is that we are

Re: [Qemu-devel] [PATCH COLO-Frame v10 13/38] COLO: Load PVM's dirty pages into SVM's RAM cache temporarily

2015-11-16 Thread zhanghailiang
On 2015/11/13 23:39, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: We should not load PVM's state directly into SVM, because there maybe some errors happen when SVM is receving data, which will break SVM. We need to ensure receving all data before load th

Re: [Qemu-devel] [Qemu-block] [PATCH V5] block/nfs: add support for setting debug level

2015-11-16 Thread Stefan Hajnoczi
On Fri, Nov 13, 2015 at 01:19:55PM -0500, Jeff Cody wrote: > On Fri, Nov 13, 2015 at 05:45:09PM +0800, Stefan Hajnoczi wrote: > > On Mon, Nov 09, 2015 at 08:09:33AM +0100, Peter Lieven wrote: > > > recent libnfs versions support logging debug messages. Add > > > support for it in qemu through an UR

Re: [Qemu-devel] [Qemu-block] [PATCH] docs: update bitmaps.md

2015-11-16 Thread Stefan Hajnoczi
On Tue, Nov 10, 2015 at 06:00:17PM -0500, John Snow wrote: > Include new error handling scenarios for 2.5. > > Signed-off-by: John Snow > --- > docs/bitmaps.md | 157 > > 1 file changed, 157 insertions(+) Thanks, applied to my block tree

[Qemu-devel] [PATCH v2 1/1] block: make 'stats-interval' an array of ints instead of a string

2015-11-16 Thread Alberto Garcia
This is the natural JSON representation and prevents us from having to decode the list manually. Signed-off-by: Alberto Garcia --- blockdev.c | 91 +++--- qapi/block-core.json | 7 ++-- tests/qemu-iotests/136 | 2 +- 3 files changed, 61

Re: [Qemu-devel] [Qemu-ppc] [PATCH 05/77] ppc: Update SPR definitions

2015-11-16 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:18AM +1100, Benjamin Herrenschmidt wrote: > Add definitions for additional SPR numbers and SPR bit definitions > that will be relevant for subsequent improvements to POWER8 emulation > > Also fix the definition of LPIDR which was incorrect (and is different > for serv

Re: [Qemu-devel] [PATCH V4 0/6] ide: avoid main-loop hang on CDROM/NFS failure

2015-11-16 Thread Fam Zheng
On Fri, 11/13 17:44, John Snow wrote: > > > On 11/12/2015 11:30 AM, Peter Lieven wrote: > > This series aims at avoiding a hanging main-loop if a vserver has a > > CDROM image mounted from a NFS share and that NFS share goes down. > > Typical situation is that users mount an CDROM ISO to install

Re: [Qemu-devel] [PATCH v4 6/7] qom: replace object property list with GHashTable

2015-11-16 Thread Andreas Färber
Am 16.11.2015 um 09:16 schrieb Christian Borntraeger: > On 11/16/2015 08:13 AM, Pavel Fedin wrote: > (process:4102): GLib-CRITICAL **: g_hash_table_iter_next: assertion > 'ri->version == ri->hash_table->version' failed > > (process:4102): GLib-CRITICAL **: g_hash_table_iter_next: as

[Qemu-devel] [PATCH for-2.5 v2 0/1] block: make 'stats-interval' an array of ints instead of a string

2015-11-16 Thread Alberto Garcia
Second version of the patch, following all suggestions by Stefan. v2: - The code that parses the intervals has been moved to a separate function - Due to the previous change, the loop has been modified a bit and the original 'length' variable no longer exists. - interval_dict and interval_list

Re: [Qemu-devel] [PATCH] scsi: remove scsi_req_free prototype

2015-11-16 Thread Fam Zheng
On Thu, 11/12 22:26, Hervé Poussineau wrote: > Function has been deleted in ad2d30f79d3b0812f02c741be2189796b788d6d7. > > Signed-off-by: Hervé Poussineau > --- > include/hw/scsi/scsi.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h > inde

Re: [Qemu-devel] [Qemu-ppc] [PATCH 16/77] ppc: Get out of emulation on SMT "OR" ops

2015-11-16 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:29AM +1100, Benjamin Herrenschmidt wrote: > Otherwise tight loops at smt_low for example, which OPAL does, > eat so much CPU that we can't boot a kernel anymore. With that, > I can boot 8 CPUs just fine with powernv. > > Signed-off-by: Benjamin Herrenschmidt Reviewe

Re: [Qemu-devel] [PATCH 05/10] snapshot: create bdrv_all_find_snapshot helper

2015-11-16 Thread Denis V. Lunev
On 11/16/2015 12:31 PM, Stefan Hajnoczi wrote: On Tue, Nov 10, 2015 at 05:25:30PM +0300, Denis V. Lunev wrote: +int bdrv_all_find_snapshot(const char *name, bool read_only, + BlockDriverState **first_bad_bs) +{ +QEMUSnapshotInfo sn; +int err = 0; +BlockDrive

Re: [Qemu-devel] [PATCH] vhost-user: update spec description

2015-11-16 Thread Victor Kaplansky
On Sun, Nov 15, 2015 at 09:29:59PM +0200, Michael S. Tsirkin wrote: > Clarify logging setup to make sure all clients comply in a way that is > future-proof. Document how rings are started/stopped. > > Signed-off-by: Michael S. Tsirkin > --- > docs/specs/vhost-user.txt | 62 > ++

Re: [Qemu-devel] [PATCH v4 6/7] qom: replace object property list with GHashTable

2015-11-16 Thread Pavel Fedin
Hello! > >> (process:4102): GLib-CRITICAL **: g_hash_table_iter_next: assertion > >> 'ri->version == ri->hash_table->version' failed > >> > >> (process:4102): GLib-CRITICAL **: g_hash_table_iter_next: assertion > >> 'ri->version == ri->hash_table->version' failed > >> > >> (process:4102): GLib-CR

Re: [Qemu-devel] [PATCH v4 6/7] qom: replace object property list with GHashTable

2015-11-16 Thread Paolo Bonzini
On 16/11/2015 10:48, Andreas Färber wrote: > > > Thanks! sclp_init() seems to violate several QOM design principles in > > > that it uses object_new() during TypeInfo::instance_init() > > > > There's nothing wrong with that. It's wrong however to use > > qdev_set_parent_bus in instance_init. T

[Qemu-devel] [PATCH V2 1/3] target-i386: add pkeys support for cpuid handling

2015-11-16 Thread Huaitong Han
This patch adds pkeys support for cpuid handling. Signed-off-by: Huaitong Han diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 4d1b085..2ff73ee 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -264,6 +264,17 @@ static const char *cpuid_7_0_ebx_feature_name[] = { NULL, NULL,

Re: [Qemu-devel] [PATCH] vhost: Fix aborting if KVM does not support eventfds

2015-11-16 Thread Michael S. Tsirkin
On Mon, Nov 16, 2015 at 10:02:07AM +0300, Pavel Fedin wrote: > Hello! > > > > If you happen to have a stock kernel of old version, like 3.x, and you > > > attempt to enable vhost by setting vhost=on, qemu aborts with error: > > > > > > kvm_mem_ioeventfd_add: error adding ioeventfd: Function not i

Re: [Qemu-devel] [PATCH V2 0/4] hw/pcie: Multi-root support for Q35

2015-11-16 Thread Marcel Apfelbaum
On 11/16/2015 11:56 AM, Paolo Bonzini wrote: On 16/11/2015 10:52, Marcel Apfelbaum wrote: On 11/16/2015 10:40 AM, Paolo Bonzini wrote: On 15/11/2015 16:39, Marcel Apfelbaum wrote: Addressed Gerd Hoffmann comments: - Added x-enable-internal-bridge compat property to keep the PCI

Re: [Qemu-devel] [PATCH v4 6/7] qom: replace object property list with GHashTable

2015-11-16 Thread Andreas Färber
Am 16.11.2015 um 09:53 schrieb Paolo Bonzini: > On 13/11/2015 22:25, Andreas Färber wrote: >> Thanks! sclp_init() seems to violate several QOM design principles in >> that it uses object_new() during TypeInfo::instance_init() > > There's nothing wrong with that. It's wrong however to use > qdev_s

Re: [Qemu-devel] [PATCH v4 6/7] qom: replace object property list with GHashTable

2015-11-16 Thread Christian Borntraeger
On 11/16/2015 08:13 AM, Pavel Fedin wrote: > Hello! > (process:4102): GLib-CRITICAL **: g_hash_table_iter_next: assertion 'ri->version == ri->hash_table->version' failed (process:4102): GLib-CRITICAL **: g_hash_table_iter_next: assertion 'ri->version == ri->hash_table->ve

Re: [Qemu-devel] [PATCH v4 4/4] devicetree: update documentation for fw_cfg ARM bindings

2015-11-16 Thread Paolo Bonzini
On 15/11/2015 03:07, Rob Herring wrote: > We generally don't want DT docs to depend on other kernel documentation. DT docs do not contain a copy of the data sheets, either. There is no reason to say how to use the device (and even then, only doing so partially) in the DT docs. Paolo

[Qemu-devel] [PATCH v3 0/8] Add system_powerdown support on ARM for ACPI and DT

2015-11-16 Thread shannon . zhao
From: Shannon Zhao ACPI SPEC 5.0 defines GPIO-signaled ACPI Events for Hardware-reduced platforms(like ARM). It uses GPIO pin to trigger an event to the guest. For QEMU, here we add PL061 GPIO controller and use PIN 3 for system_powerdown, reserving PIN 0, 1, 2 for PCI hotplug, CPU hotplug and me

Re: [Qemu-devel] [PULL 25/57] Add wrappers and handlers for sending/receiving the postcopy-ram migration messages.

2015-11-16 Thread Dr. David Alan Gilbert
* Stefan Weil (s...@weilnetz.de) wrote: > Am 10.11.2015 um 15:25 schrieb Juan Quintela: > > From: "Dr. David Alan Gilbert" > > > > The state of the postcopy process is managed via a series of messages; > >* Add wrappers and handlers for sending/receiving these messages > >* Add state varia

Re: [Qemu-devel] [PATCH V2 0/4] hw/pcie: Multi-root support for Q35

2015-11-16 Thread Paolo Bonzini
On 15/11/2015 16:39, Marcel Apfelbaum wrote: > Addressed Gerd Hoffmann comments: > - Added x-enable-internal-bridge compat property to keep the PCI >bridge for older machine to avoid breaking migration. This will break PXB command lines written for "-M pc" in QEMU <= 2.5. Technically there

Re: [Qemu-devel] [Qemu-block] [PATCH] block: make 'stats-intervals' a list of integers

2015-11-16 Thread Alberto Garcia
On Mon 16 Nov 2015 04:46:44 AM CET, Stefan Hajnoczi wrote: >> early_err: >> qemu_opts_del(opts); >> +QDECREF(interval_dict); >> +QDECREF(interval_list); > > There is a codepath that reaches here without initializing interval_dict > or interval_list: > > qemu_opts_absorb_qdict(opts,

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-16 Thread Aravinda Prasad
On Monday 16 November 2015 01:22 PM, Thomas Huth wrote: > On 12/11/15 19:49, Aravinda Prasad wrote: >> >> On Thursday 12 November 2015 03:10 PM, Thomas Huth wrote: > ... >>> Also LoPAPR talks about 'subsequent processors report "fatal error >>> previously reported"', so maybe the other processors

[Qemu-devel] [PATCH v2 09/19] exec.c: Use cpu_get_phys_page_attrs_debug

2015-11-16 Thread Peter Maydell
Use cpu_get_phys_page_attrs_debug() when doing virtual-to-physical conversions in debug related code, so that we can obtain the right address space index and thus select the correct AddressSpace, rather than always using cpu->as. Signed-off-by: Peter Maydell --- exec.c | 18 +- 1

Re: [Qemu-devel] [PATCH v4 6/7] qom: replace object property list with GHashTable

2015-11-16 Thread Paolo Bonzini
On 13/11/2015 22:25, Andreas Färber wrote: > Thanks! sclp_init() seems to violate several QOM design principles in > that it uses object_new() during TypeInfo::instance_init() There's nothing wrong with that. It's wrong however to use qdev_set_parent_bus in instance_init. That should be moved

Re: [Qemu-devel] [PATCH V2 0/4] hw/pcie: Multi-root support for Q35

2015-11-16 Thread Marcel Apfelbaum
On 11/16/2015 12:03 PM, Paolo Bonzini wrote: On 16/11/2015 11:02, Marcel Apfelbaum wrote: Actually the command line would work. The devices will be placed on the root bus instead of the pci bridge bus. The trick here is that we name the bus the devices will be attached to by the pxb id. - Wh

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-16 Thread Thomas Huth
On 16/11/15 04:50, Paul Mackerras wrote: > On Thu, Nov 12, 2015 at 09:09:59AM +0100, Thomas Huth wrote: >> >> Shouldn't you also check MSR_ME here first and enter checkstop when >> machine checks are disabled? > > MSR_ME is a hypervisor resource and is not able to be controlled by HV > KVM guests,

[Qemu-devel] [PATCH 2/3] scsi-disk: Add 'alua_state' property

2015-11-16 Thread Hannes Reinecke
To support asymmetric logical unit access (ALUA) we need to store the ALUA state in the device structure. Signed-off-by: Hannes Reinecke --- hw/scsi/scsi-bus.c | 15 +++ hw/scsi/scsi-disk.c| 72 ++ include/block/scsi.h | 13 ++

[Qemu-devel] [PULL 00/03] seccomp branch queue

2015-11-16 Thread Eduardo Otubo
The following changes since commit 8337c6cbc37c6b2184f41bab3eaff47d5e68012a: Update version for v2.5.0-rc0 release (2015-11-13 17:10:36 +) are available in the git repository at: git://github.com/otubo/qemu.git tags/pull-seccomp-20151116 for you to fetch changes up to

Re: [Qemu-devel] [PATCH V2 0/4] hw/pcie: Multi-root support for Q35

2015-11-16 Thread Paolo Bonzini
On 16/11/2015 11:10, Marcel Apfelbaum wrote: >> What would you lose? Hotplug? > > Without the bridge? Yes. However the user can add it manually the > pci-bridge and have it anyway. Ok, I guess that's more or less acceptable. It's still ugly however, to the point that I wonder if we should ren

Re: [Qemu-devel] [PATCH V2 0/4] hw/pcie: Multi-root support for Q35

2015-11-16 Thread Paolo Bonzini
On 16/11/2015 10:52, Marcel Apfelbaum wrote: > On 11/16/2015 10:40 AM, Paolo Bonzini wrote: >> >> >> On 15/11/2015 16:39, Marcel Apfelbaum wrote: >>> Addressed Gerd Hoffmann comments: >>> - Added x-enable-internal-bridge compat property to keep the PCI >>> bridge for older machine to avoi

[Qemu-devel] [PATCH V2 2/4] hw/acpi: merge pxb adjacent memory/IO ranges

2015-11-16 Thread Marcel Apfelbaum
Since the PXB has no longer a built-in PCI bridge, the ACPI will include IO/MEM ranges per device. Try to merge adjacent resources to reduce the ACPI tables length. Signed-off-by: Marcel Apfelbaum --- hw/i386/acpi-build.c | 123 +++ 1 file changed,

Re: [Qemu-devel] [Qemu-ppc] [PATCH 13/77] ppc: tlbie, tlbia and tlbisync are HV only

2015-11-16 Thread Benjamin Herrenschmidt
On Mon, 2015-11-16 at 16:34 +1100, David Gibson wrote: > On Wed, Nov 11, 2015 at 11:27:26AM +1100, Benjamin Herrenschmidt > wrote: > > Not that anything remotely recent supports tlbia but ... > > > > Signed-off-by: Benjamin Herrenschmidt > > --- > >  target-ppc/translate.c | 6 +++--- > >  1 file

[Qemu-devel] [PATCH v2] vhost-user: update spec description

2015-11-16 Thread Michael S. Tsirkin
Clarify logging setup to make sure all clients comply in a way that is future-proof. Document how rings are started/stopped. Signed-off-by: Michael S. Tsirkin --- Changes from v1: document recommended behaviour upon RESET_OWNER. docs/specs/vhost-user.txt | 64 ++

Re: [Qemu-devel] [PULL 42/57] Page request: Consume pages off the post-copy queue

2015-11-16 Thread Andreas Färber
Am 12.11.2015 um 14:36 schrieb Markus Armbruster: > Peter Maydell writes: > >> [...] it's usually painful to get a >> backtrace out of this kind of qtest, because it's clearly starting >> a whole pile of QEMUs and there's no way I know of to say "only >> run a few of these tests, not the whole hu

[Qemu-devel] [PATCH V2 3/4] hw/pc: query both q35 and i440fx bus

2015-11-16 Thread Marcel Apfelbaum
Look for pxb devices on both i386 machines. Signed-off-by: Marcel Apfelbaum --- hw/i386/acpi-build.c | 3 +-- hw/i386/pc.c | 2 +- hw/pci-host/q35.c| 8 include/hw/i386/pc.h | 9 + 4 files changed, 19 insertions(+), 3 deletions(-) diff --git a/hw/i386/acpi-build.c b

Re: [Qemu-devel] [PATCH V2 0/4] hw/pcie: Multi-root support for Q35

2015-11-16 Thread Marcel Apfelbaum
On 11/16/2015 12:37 PM, Michael S. Tsirkin wrote: On Mon, Nov 16, 2015 at 12:34:11PM +0200, Marcel Apfelbaum wrote: On 11/16/2015 12:11 PM, Paolo Bonzini wrote: On 16/11/2015 11:10, Marcel Apfelbaum wrote: What would you lose? Hotplug? Without the bridge? Yes. However the user can add it

Re: [Qemu-devel] [PATCH V2 0/4] hw/pcie: Multi-root support for Q35

2015-11-16 Thread Marcel Apfelbaum
On 11/16/2015 12:59 PM, Michael S. Tsirkin wrote: On Mon, Nov 16, 2015 at 12:39:45PM +0200, Marcel Apfelbaum wrote: On 11/16/2015 12:37 PM, Michael S. Tsirkin wrote: On Mon, Nov 16, 2015 at 12:34:11PM +0200, Marcel Apfelbaum wrote: On 11/16/2015 12:11 PM, Paolo Bonzini wrote: On 16/11/2015

Re: [Qemu-devel] [PATCH v4 6/7] qom: replace object property list with GHashTable

2015-11-16 Thread Daniel P. Berrange
On Fri, Nov 13, 2015 at 10:00:58PM +0100, Christian Borntraeger wrote: > On 11/13/2015 07:14 PM, Andreas Färber wrote: > > Am 13.10.2015 um 14:37 schrieb Daniel P. Berrange: > >> From: Pavel Fedin > >> > >> ARM GICv3 systems with large number of CPUs create lots of IRQ pins. Since > >> every pin i

Re: [Qemu-devel] Bug with GDB from commit ca3e40e

2015-11-16 Thread Marc Marí
On Mon, 16 Nov 2015 08:45:09 +0200 "Michael S. Tsirkin" wrote: > On Mon, Nov 16, 2015 at 02:04:41AM +0100, Marc Marí wrote: > > Hi > > > > I was trying to debug some stuff in the bootloader and the > > optionrom, and I found a bug with QEMU and GDB. In commit ca3e40e > > (a pull request from Mic

Re: [Qemu-devel] block/vpc: Fix vhd extra sectors issue

2015-11-16 Thread Peter Lieven
Am 16.11.2015 um 13:22 schrieb Jeff Cody: On Mon, Nov 16, 2015 at 10:17:11AM +0100, Kevin Wolf wrote: Am 13.11.2015 um 16:32 hat Lucian Petrut geschrieben: At the moment, qemu-img extends new image virtual sizes based on the CHS algorithm provided by the VHD specs in order to ensure that the di

Re: [Qemu-devel] [PATCH v4 2/2] target-i386: add support to migrate vcpu's TSC rate

2015-11-16 Thread Eduardo Habkost
On Mon, Nov 16, 2015 at 04:04:08PM +0800, Haozhong Zhang wrote: > This patch enables migrating vcpu's TSC rate. If KVM on the destination > machine supports TSC scaling, guest programs will observe a consistent > TSC rate across the migration. > > If TSC scaling is not supported on the destination

[Qemu-devel] [PATCH 0/3] SCSI ALUA support

2015-11-16 Thread Hannes Reinecke
Hi all, here's a patchset to implement ALUA support for SCSI disks. With it we can easily simulate a multipath setup: -drive ,if=none,id=disk1 \ -device scsi-disk,wwn=,port_group=1,port_index=1,alua_state=0 -drive ,if=none,id=disk2 \ -device scsi-disk,wwn=,port_group=2,port_index=1,alua_state=2

[Qemu-devel] [PATCH v3 4/8] hw/acpi/aml-build: Add GPIO Connection Descriptor

2015-11-16 Thread shannon . zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Tested-by: Wei Huang --- hw/acpi/aml-build.c | 61 + include/hw/acpi/aml-build.h | 20 +++ 2 files changed, 81 insertions(+) diff --git a/hw/acpi/aml-bui

[Qemu-devel] [PATCH 1/3] scsi-disk: Add 'port_group' property

2015-11-16 Thread Hannes Reinecke
Each SCSI target port can have a 'target port group' identifier. This identifier is used for management software to group individual I_T_L nexus together eg when assembling a multipath topology. Signed-off-by: Hannes Reinecke --- hw/scsi/scsi-disk.c | 12 1 file changed, 12 insertio

[Qemu-devel] [PATCH v3 8/8] hw/arm/virt: Add gpio-keys node for Poweroff using DT

2015-11-16 Thread shannon . zhao
From: Shannon Zhao Add a gpio-keys node. This is used for Poweroff for the systems which use DT not ACPI. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Tested-by: Wei Huang --- hw/arm/virt.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm

Re: [Qemu-devel] block/vpc: Fix vhd extra sectors issue

2015-11-16 Thread Jeff Cody
On Mon, Nov 16, 2015 at 10:17:11AM +0100, Kevin Wolf wrote: > Am 13.11.2015 um 16:32 hat Lucian Petrut geschrieben: > > > > At the moment, qemu-img extends new image virtual sizes based > > on the CHS algorithm provided by the VHD specs in order to > > ensure that the disk geometry (and payload as

[Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2015-11-16 Thread Denis V. Lunev
Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Amit Shah CC: Markus Armbruster CC: Eric Blake --- migration/savevm.c | 5 + qapi-schema.json | 13 + qmp-commands.hx| 25 + 3 files changed, 43 insertions(+) diff --git a/migration/savevm.c b/

[Qemu-devel] [PATCH v2] vhost-user: print original request on error

2015-11-16 Thread Michael S. Tsirkin
When we get an unexpected response, print out the original request. Helps debug protocol errors tremendously. Signed-off-by: Michael S. Tsirkin --- Changes from v1: add missing . hw/virtio/vhost-user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/vhost-user

[Qemu-devel] [PATCH v2 01/19] exec.c: Don't set cpu->as until cpu_address_space_init

2015-11-16 Thread Peter Maydell
Rather than setting cpu->as unconditionally in cpu_exec_init (and then having target-i386 override this later), don't set it until the first call to cpu_address_space_init. This requires us to initialise the address space for both TCG and KVM (KVM doesn't need the AS listener but it does require c

Re: [Qemu-devel] [PATCH v2] target-arm: Clean up DISAS_UPDATE usage in AArch32 translation code

2015-11-16 Thread Peter Maydell
On 15 November 2015 at 20:30, Sergey Fedorov wrote: > On 14.11.2015 22:45, Peter Maydell wrote: >> On 13 November 2015 at 21:13, Sergey Fedorov wrote: >>> Thank you a lot for your explanation! It was really helpful for >>> understanding the code :) One thing I wasn't sure of was whether this >>>

[Qemu-devel] [PATCH 5/5] qmp: create QMP implementation of loadvm command

2015-11-16 Thread Denis V. Lunev
Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Amit Shah CC: Markus Armbruster CC: Eric Blake --- migration/savevm.c | 5 + qapi-schema.json | 13 + qmp-commands.hx| 23 +++ 3 files changed, 41 insertions(+) diff --git a/migration/savevm.c b/mi

[Qemu-devel] [PATCH] qom: add a test case for complex property finalization

2015-11-16 Thread Daniel P. Berrange
QDev has some quite complex object child/link relationships which place some requirements on the object_property_del_all method to consider that properties can be modified while being iterated over. This extends the QOM property test case to replicate the QDev like structure and expose any potenti

[Qemu-devel] [PATCH v3 3/8] hw/arm/virt-acpi-build: Add power button device in ACPI DSDT table

2015-11-16 Thread shannon . zhao
From: Shannon Zhao Add power button device in ACPI DSDT table. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Wei Huang Tested-by: Wei Huang --- hw/arm/virt-acpi-build.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/arm/virt-acpi-build.c b/hw/ar

[Qemu-devel] [PATCH v2 03/19] exec-all.h: Document tlb_set_page_with_attrs, tlb_set_page

2015-11-16 Thread Peter Maydell
Add documentation comments for tlb_set_page_with_attrs() and tlb_set_page(). Signed-off-by: Peter Maydell --- include/exec/exec-all.h | 34 +++--- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index 9b

[Qemu-devel] [PATCH v2 11/19] memory: Add address_space_init_shareable()

2015-11-16 Thread Peter Maydell
From: Peter Crosthwaite This will either create a new AS or return a pointer to an already existing equivalent one, if we have already created an AS for the specified root memory region. The motivation is to reuse address spaces as much as possible. It's going to be quite common that bus masters

Re: [Qemu-devel] [PATCH v4 4/4] devicetree: update documentation for fw_cfg ARM bindings

2015-11-16 Thread Gabriel L. Somlo
On Mon, Nov 16, 2015 at 09:38:18AM +0100, Paolo Bonzini wrote: > On 15/11/2015 03:07, Rob Herring wrote: > > We generally don't want DT docs to depend on other kernel documentation. > > DT docs do not contain a copy of the data sheets, either. There is no > reason to say how to use the device (an

Re: [Qemu-devel] [Qemu-block] [PATCH] block: make 'stats-intervals' a list of integers

2015-11-16 Thread Stefan Hajnoczi
On Wed, Nov 11, 2015 at 03:17:12PM +0200, Alberto Garcia wrote: > @@ -583,32 +592,48 @@ static BlockBackend *blockdev_init(const char *file, > QDict *bs_opts, > > block_acct_init(blk_get_stats(blk), account_invalid, account_failed); > > -if (stats_intervals) { > -c

Re: [Qemu-devel] [PATCH 0/3] fix clang negative signed bit shift warning

2015-11-16 Thread Peter Maydell
On 10 November 2015 at 15:57, Stefan Hajnoczi wrote: > LLVM's clang 3.7.0 compile warns about bit shifting negative numbers because > the result is undefined. This series includes 3 small fixes to appease clang. > > Stefan Hajnoczi (3): > monitor: avoid clang shifting negative signed warning >

[Qemu-devel] [PATCH V2 0/4] hw/pcie: Multi-root support for Q35

2015-11-16 Thread Marcel Apfelbaum
The PXB host bridge provides a way to have multiple PCI hierarchies (PCI root buses). This series is porting the PXB device to Q35 machines by: - removing the internal pci-bridge - make the PXB bus PCIe for Q35, while it remains PCI for i440fx. This approach works because the Root Complexes are

Re: [Qemu-devel] [PULL 25/57] Add wrappers and handlers for sending/receiving the postcopy-ram migration messages.

2015-11-16 Thread Dr. David Alan Gilbert
* Stefan Weil (s...@weilnetz.de) wrote: > Am 16.11.2015 um 11:07 schrieb Dr. David Alan Gilbert: > > * Stefan Weil (s...@weilnetz.de) wrote: > >> Am 10.11.2015 um 15:25 schrieb Juan Quintela: > >>> From: "Dr. David Alan Gilbert" > >>> > >>> The state of the postcopy process is managed via a series

[Qemu-devel] [PATCH V2 1/4] hw/pxb: remove the built-in pci bridge

2015-11-16 Thread Marcel Apfelbaum
As part of porting the pxb device to Q35 remove the internal pci-2-pci bridge. The only way to hot-pug devices on the extra PCI root buses is by adding a pci-2-pci to the pxb before the firmware assign the IO/mem resources. Keep the internal bridge for existing machines. Signed-off-by: Marcel Apf

Re: [Qemu-devel] [PATCH v11 22/28] qapi: Simplify visiting of alternate types

2015-11-16 Thread Markus Armbruster
Eric Blake writes: > On 11/10/2015 11:51 PM, Eric Blake wrote: >> Previously, working with alternates required two lookup arrays >> and some indirection: for type Foo, we created Foo_qtypes[] >> which maps each qtype to a value of the generated FooKind enum, >> then look up that value in FooKind_

[Qemu-devel] [PATCH v2 08/19] exec.c: Add cpu_get_address_space()

2015-11-16 Thread Peter Maydell
Add a function to return the AddressSpace for a CPU based on its numerical index. (Callers outside exec.c don't have access to the CPUAddressSpace struct so can't just fish it out of the CPUState struct directly.) Signed-off-by: Peter Maydell --- exec.c | 6 ++ include/exec/

[Qemu-devel] [PATCH V2 4/4] hw/pxb: add support for PCIe

2015-11-16 Thread Marcel Apfelbaum
The PXB internal bus type is created in conformance with the primary root bus (bus 0). Signed-off-by: Marcel Apfelbaum --- hw/pci-bridge/pci_expander_bridge.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-

Re: [Qemu-devel] [Qemu-ppc] [PATCH 06/77] ppc: Add macros to register hypervisor mode SPRs

2015-11-16 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:19AM +1100, Benjamin Herrenschmidt wrote: > The current set of spr_register_* macros only take the user and > supervisor function pointers. To make the transition easy, we > don't change that but we add "_hv" variants that can be used to > register all 3 sets. > > To

[Qemu-devel] [PATCH] vhost-user: start/stop all rings

2015-11-16 Thread Michael S. Tsirkin
We are currently only sending VRING_ENABLE message for the first ring, that's wrong: we must start/stop them all. Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost-user.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio

[Qemu-devel] [PATCH v2 00/19] Add support for multiple address spaces per CPU and use it for ARM TrustZone

2015-11-16 Thread Peter Maydell
This patch series adds support to QEMU's core exec/memory code for CPUs which have more than one address space, and uses it for ARM TrustZone. In particular, a TZ CPU will have two physical address spaces (Secure and Non-secure), and the patchset allows a board model to create these both separately

[Qemu-devel] [PATCH for-2.5?] hw/ppc/ppc405_boards: Fix infinite recursion by converting taihu_cpld from old_mmio

2015-11-16 Thread Peter Maydell
The taihu_cpld_writel() function had an obvious typo that meant that if it was ever called it would go into an infinite recursion. Newer versions of clang will detect and warn about this: hw/ppc/ppc405_boards.c:481:1: warning: all paths through this function will call itself [-Winfinite-recursio

[Qemu-devel] [PATCH 07/10] snapshot: create bdrv_all_create_snapshot helper

2015-11-16 Thread Denis V. Lunev
to create snapshot for all loaded block drivers. The patch also ensures proper locking. Signed-off-by: Denis V. Lunev Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi CC: Juan Quintela CC: Kevin Wolf --- block/snapshot.c | 26 ++ include/block/snapshot.h |

Re: [Qemu-devel] Bug with GDB from commit ca3e40e

2015-11-16 Thread Michael S. Tsirkin
On Mon, Nov 16, 2015 at 02:04:41AM +0100, Marc Marí wrote: > Hi > > I was trying to debug some stuff in the bootloader and the optionrom, > and I found a bug with QEMU and GDB. In commit ca3e40e (a pull request > from Michael), I get this: > > x86_64-softmmu/qemu-system-x86_64 --enable-kvm \ >

[Qemu-devel] [PATCH for-2.5] makefile: fix w32 install target for qemu-ga

2015-11-16 Thread Michael Roth
fafcaf1 added a 'qemu-ga' install target on w32, which can be used in place of the existing qemu-ga.exe target to also handle dealing with other components such as DLLs for VSS/fsfreeze and generating an MSI package if appropriate configure options are present. As part of that, qemu-ga$(EXESUF) wa

Re: [Qemu-devel] [PATCH 0/3] fix clang negative signed bit shift warning

2015-11-16 Thread Peter Maydell
On 16 November 2015 at 14:23, Peter Maydell wrote: > My clang-3.7 build (it's part of fbinfer) also complains about: > > /Users/pm215/src/qemu/hw/audio/fmopl.c:1085:39: warning: shifting a > negative signed value is undefined [-Wshift-negative-value] > data = Limit( outd[0] , OPL_M

[Qemu-devel] [PATCH 05/10] snapshot: create bdrv_all_find_snapshot helper

2015-11-16 Thread Denis V. Lunev
to check that snapshot is available for all loaded block drivers. The ability to switch to snapshot is verified separately using bdrv_all_can_snapshot. The patch also ensures proper locking. Signed-off-by: Denis V. Lunev Reviewed-by: Fam Zheng CC: Juan Quintela CC: Stefan Hajnoczi CC: Kevin W

[Qemu-devel] [PATCH 08/10] migration: reorder processing in hmp_savevm

2015-11-16 Thread Denis V. Lunev
State deletion can be performed on running VM which reduces VM downtime This approach looks a bit more natural. Signed-off-by: Denis V. Lunev Reviewed-by: Fam Zheng CC: Juan Quintela --- migration/savevm.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/m

[Qemu-devel] [PATCH 06/10] migration: drop find_vmstate_bs check in hmp_delvm

2015-11-16 Thread Denis V. Lunev
There is no much sense to do the check and write warning. Signed-off-by: Denis V. Lunev Reviewed-by: Fam Zheng CC: Juan Quintela --- migration/savevm.c | 5 - 1 file changed, 5 deletions(-) diff --git a/migration/savevm.c b/migration/savevm.c index a391b3a..68af80e 100644 --- a/migration/

[Qemu-devel] [PATCH] vhost-user: update spec description

2015-11-16 Thread Michael S. Tsirkin
Clarify logging setup to make sure all clients comply in a way that is future-proof. Document how rings are started/stopped. Signed-off-by: Michael S. Tsirkin --- docs/specs/vhost-user.txt | 62 --- 1 file changed, 53 insertions(+), 9 deletions(-) di

[Qemu-devel] [PATCH v4 2/2] target-i386: add support to migrate vcpu's TSC rate

2015-11-16 Thread Haozhong Zhang
This patch enables migrating vcpu's TSC rate. If KVM on the destination machine supports TSC scaling, guest programs will observe a consistent TSC rate across the migration. If TSC scaling is not supported on the destination machine, the migration will not be aborted and QEMU on the destination wi

[Qemu-devel] [PATCH for 2.5 v8 0/10] dataplane snapshot fixes

2015-11-16 Thread Denis V. Lunev
with test while /bin/true ; do virsh snapshot-create rhel7 sleep 10 virsh snapshot-delete rhel7 --current done with enabled iothreads on a running VM leads to a lot of troubles: hangs, asserts, errors. Anyway, I think that the construction like assert(aio_contex

[Qemu-devel] [PATCH 0/5] QMP wrappers for VM snapshot operations

2015-11-16 Thread Denis V. Lunev
EFI based VM with pflash storage for NVRAM could not be snapshoted as libvirt configures storage as 'raw' and writable. OK, this is a libvirt problem. Another problem is that libvirt can not detect this failure at all as it uses HMP for this operation. This create snapshot/delete snapshot sequence

Re: [Qemu-devel] [PATCH 1/1] vhost-user: modify SET_LOG_BASE only if VHOST_USER_PROTOCOL_F_LOG_SHMFD is set

2015-11-16 Thread Michael S. Tsirkin
On Mon, Nov 16, 2015 at 05:14:37PM +0100, Thibaut Collet wrote: > Fixes: 2b8819c6eee5 ("vhost-user: modify SET_LOG_BASE to pass mmap size and > offset") > > For compatibility with old vhost backend content of the SET_LOG_BASE message > can not be modified. Hmm that's true. Interesting. But this o

Re: [Qemu-devel] [PATCH COLO-Frame v10 02/38] migration: Introduce capability 'x-colo' to migration

2015-11-16 Thread zhanghailiang
On 2015/11/14 0:01, Eric Blake wrote: On 11/03/2015 04:56 AM, zhanghailiang wrote: We add helper function colo_supported() to indicate whether colo is supported or not, with which we use to control whether or not showing 'x-colo' string to users, they can use qmp command 'query-migrate-capabilit

Re: [Qemu-devel] [PATCH v2] target-arm: Clean up DISAS_UPDATE usage in AArch32 translation code

2015-11-16 Thread Sergey Fedorov
On 14.11.2015 22:45, Peter Maydell wrote: > On 13 November 2015 at 21:13, Sergey Fedorov wrote: >> On 10.11.2015 15:15, Peter Maydell wrote: >>> So the way the 32-bit code works for singlestep is complicated >>> because of the need to handle the conditional instructions, >>> which means you get a

Re: [Qemu-devel] [PATCH v4 2/2] target-i386: add support to migrate vcpu's TSC rate

2015-11-16 Thread Eduardo Habkost
On Mon, Nov 16, 2015 at 10:30:08PM +0800, Haozhong Zhang wrote: > On 11/16/15 11:43, Eduardo Habkost wrote: > > On Mon, Nov 16, 2015 at 04:04:08PM +0800, Haozhong Zhang wrote: > > > This patch enables migrating vcpu's TSC rate. If KVM on the destination > > > machine supports TSC scaling, guest pro

Re: [Qemu-devel] [PATCH V5] block/nfs: add support for setting debug level

2015-11-16 Thread John Snow
On 11/15/2015 10:25 PM, Stefan Hajnoczi wrote: > On Fri, Nov 13, 2015 at 10:52:49AM +0100, Peter Lieven wrote: >> Am 13.11.2015 um 10:45 schrieb Stefan Hajnoczi: >>> On Mon, Nov 09, 2015 at 08:09:33AM +0100, Peter Lieven wrote: recent libnfs versions support logging debug messages. Add

[Qemu-devel] [PATCH V2 3/3] target-i386: add pkeys support for vm migration

2015-11-16 Thread Huaitong Han
This patch adds pkeys support for vm migration. Signed-off-by: Huaitong Han diff --git a/target-i386/machine.c b/target-i386/machine.c index a0df64b..1b190c7 100644 --- a/target-i386/machine.c +++ b/target-i386/machine.c @@ -725,6 +725,26 @@ static const VMStateDescription vmstate_xss = {

[Qemu-devel] [PATCH 1/1] vhost-user: modify SET_LOG_BASE only if VHOST_USER_PROTOCOL_F_LOG_SHMFD is set

2015-11-16 Thread Thibaut Collet
Fixes: 2b8819c6eee5 ("vhost-user: modify SET_LOG_BASE to pass mmap size and offset") For compatibility with old vhost backend content of the SET_LOG_BASE message can not be modified. The SET_LOG_BASE message payload is modified only if the VHOST_USER_PROTOCOL_F_LOG_SHMFD protocol feature has been

Re: [Qemu-devel] [PATCH COLO-Frame v10 14/38] COLO: Load VMState into qsb before restore it

2015-11-16 Thread zhanghailiang
On 2015/11/14 0:02, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: We should not destroy the state of SVM (Secondary VM) until we receive the whole state from the PVM (Primary VM), in case the primary fails in the middle of sending the state, so, here we c

Re: [Qemu-devel] [PATCH COLO-Frame v10 15/38] ram/COLO: Record pages received from PVM by re-using migration dirty bitmap

2015-11-16 Thread zhanghailiang
On 2015/11/14 0:19, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: We need to record the address of the dirty pages that received from PVM, It will help flushing pages that cached into SVM. Signed-off-by: zhanghailiang --- v10: - New patch split from v9's

Re: [Qemu-devel] [PATCH for 2.5 v7 0/10] dataplane snapshot fixes

2015-11-16 Thread Stefan Hajnoczi
On Tue, Nov 10, 2015 at 05:25:25PM +0300, Denis V. Lunev wrote: > with test > while /bin/true ; do > virsh snapshot-create rhel7 > sleep 10 > virsh snapshot-delete rhel7 --current > done > with enabled iothreads on a running VM leads to a lot of troubles: hangs, > as

Re: [Qemu-devel] QEMU versus Facebook's Infer static analysis tool

2015-11-16 Thread Paolo Bonzini
On 14/11/2015 22:53, Peter Maydell wrote: > That's a shame, because it would have been nice to include another > kind of static analysis in what we run on QEMU (especially since > the coverity tests are "only runs every so often when we do a build"), > and the ability to do incremental analysis w

Re: [Qemu-devel] [QEMU PATCH] target-i386: Disable rdtscp on Opteron_G* CPU models

2015-11-16 Thread Paolo Bonzini
On 13/11/2015 20:07, Eduardo Habkost wrote: > KVM can't virtualize rdtscp on AMD CPUs yet, so there's no point > in enabling it by default on AMD CPU models, as all we are > getting are confused users because of the "host doesn't support > requested feature" warnings. > > Disable rdtscp on Opter

Re: [Qemu-devel] [PATCH v3 1/3] target-i386: add a subsection for migrating vcpu's TSC rate

2015-11-16 Thread Haozhong Zhang
On 11/13/15 13:21, Eduardo Habkost wrote: > On Fri, Nov 13, 2015 at 10:23:54AM +0800, Haozhong Zhang wrote: > > On 11/11/15 22:27, Haozhong Zhang wrote: > > > On 11/11/15 12:16, Eduardo Habkost wrote: > > [...] > > > > > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > > > > > index 2f8f396..858e

  1   2   3   4   >