EFI based VM with pflash storage for NVRAM could not be snapshoted as libvirt configures storage as 'raw' and writable. OK, this is a libvirt problem.
Another problem is that libvirt can not detect this failure at all as it uses HMP for this operation. This create snapshot/delete snapshot sequence passes silently. The patchset adds QMP wrappers for the purpose. At the moment I have placed 2.6 version into QAPI. Though (if you feel appropriate) I can change it to 2.5 :) This is up to you to decide. Please note, this patchset is made on top of [PATCH for 2.5 v8 0/10] dataplane snapshot fixes Signed-off-by: "Denis V. Lunev" <d...@openvz.org> CC: Juan Quintela <quint...@redhat.com> CC: Amit Shah <amit.s...@redhat.com> CC: Markus Armbruster <arm...@redhat.com> CC: Eric Blake <ebl...@redhat.com> Denis V. Lunev (5): migration: split hmp_savevm to do_savevm and hmp_savevm wrapper qmp: create qmp_savevm command qmp: create qmp_delvm command migration: improve error reporting for hmp_loadvm qmp: create QMP implementation of loadvm command include/sysemu/sysemu.h | 2 +- migration/savevm.c | 100 +++++++++++++++++++++++++++++++----------------- monitor.c | 7 +++- qapi-schema.json | 39 +++++++++++++++++++ qmp-commands.hx | 71 ++++++++++++++++++++++++++++++++++ vl.c | 5 ++- 6 files changed, 185 insertions(+), 39 deletions(-) -- 2.5.0
