Re: [Qemu-devel] [PATCH 3/4] block/gluster: using new qapi schema

2015-11-13 Thread Markus Armbruster
Prasanna Kumar Kalever writes: > this patch adds GlusterConf to qapi/block-core.json > > Signed-off-by: Prasanna Kumar Kalever > --- > block/gluster.c | 104 > +-- > qapi/block-core.json | 60 +++-- > 2 files changed

Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring

2015-11-13 Thread Gerd Hoffmann
Hi, > Maybe I am missing something but what if the watch on dir was > added by qemu _after_ the file (say file1) was copied to it. > Then, the kernel would generate events for file2, file3 and so on but > never a CREATE event for file1. Isn't that a possibility ? Yes. > So, what I mean > by th

Re: [Qemu-devel] [PATCH v2 1/2] virtio-net: use the backend cross-endian capabilities

2015-11-13 Thread Greg Kurz
On Thu, 12 Nov 2015 18:52:55 +0100 Cornelia Huck wrote: > On Mon, 09 Nov 2015 18:41:33 +0100 > Greg Kurz wrote: > > > When running a fully emulated device in cross-endian conditions, including > > a virtio 1.0 device offered to a big endian guest, we need to fix the vnet > > headers. This is cu

Re: [Qemu-devel] [PATCH 1/3] virtio: move cross-endian helper to vhost

2015-11-13 Thread Greg Kurz
On Thu, 12 Nov 2015 19:00:54 +0100 Cornelia Huck wrote: > On Mon, 09 Nov 2015 18:58:16 +0100 > Greg Kurz wrote: > > > If target is bi-endian (ppc64, arm), the virtio_legacy_is_cross_endian() > > indeed returns the runtime state of the virtio device. However, it returns > > false unconditionally

Re: [Qemu-devel] safety of migration_bitmap_extend

2015-11-13 Thread Li Zhijian
On 11/12/2015 04:33 PM, Wen Congyang wrote: >Imagine that migration_dirty_pages is slightly too small and we enter ram_save_iterate; >ram_save_iterate now sends*all* it's pages, it decrements migration_dirty_pages for >every page sent. At the end of ram_save_iterate, migration_dirty_pages wo

Re: [Qemu-devel] [PATCH for-2.5 v2] input: Document why x-input-send-event is still experimental

2015-11-13 Thread Markus Armbruster
Gerd Hoffmann writes: > On Do, 2015-11-12 at 11:50 -0700, Eric Blake wrote: >> The x-input-send-event command was introduced in 2.2 with mention >> that it is experimental, but now that several releases have elapsed >> without any changes, it would be nice to document why that was done >> and sho

Re: [Qemu-devel] [PATCH 1/4] hw/pxb: remove the built-in pci bridge

2015-11-13 Thread Gerd Hoffmann
On Do, 2015-11-12 at 17:11 +0200, Marcel Apfelbaum wrote: > As part of porting the pxb device to Q35 remove the internal pci-2-pci > bridge. The only way to hot-pug devices on the extra PCI root buses > is by adding a pci-2-pci to the pxb before the firmware assign the > IO/mem resources. I think

Re: [Qemu-devel] [PATCH v4 17/17] ipmi: Add a force off function

2015-11-13 Thread Daniel P. Berrange
On Thu, Nov 12, 2015 at 01:02:33PM -0600, miny...@acm.org wrote: > From: Corey Minyard > > Allow the IPMI interface to request a forced power off. > > Signed-off-by: Corey Minyard > --- > hw/ipmi/ipmi_bmc_extern.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/hw/ipmi/ipmi_bmc_

Re: [Qemu-devel] [PATCH 1/4] hw/pxb: remove the built-in pci bridge

2015-11-13 Thread Marcel Apfelbaum
On 11/13/2015 11:13 AM, Gerd Hoffmann wrote: On Do, 2015-11-12 at 17:11 +0200, Marcel Apfelbaum wrote: As part of porting the pxb device to Q35 remove the internal pci-2-pci bridge. The only way to hot-pug devices on the extra PCI root buses is by adding a pci-2-pci to the pxb before the firmwar

[Qemu-devel] [PATCH] vhost: Fix aborting if KVM does not support eventfds

2015-11-13 Thread Pavel Fedin
If you happen to have a stock kernel of old version, like 3.x, and you attempt to enable vhost by setting vhost=on, qemu aborts with error: kvm_mem_ioeventfd_add: error adding ioeventfd: Function not implemented This patch adds capability check, so that vhost gets disabled instead. A warning is d

Re: [Qemu-devel] [Qemu-block] [PATCH v6 0/4] qapi: child add/delete support

2015-11-13 Thread Stefan Hajnoczi
On Fri, Oct 30, 2015 at 02:11:30PM +0800, Wen Congyang wrote: > Ping... Tips for faster code review: It helps to mention the specific person you are expecting review from when the CC list is long. For example, "Kevin: ping". Keeping the CC list short can result in faster code review than a long

Re: [Qemu-devel] [PATCH 3/3] virtio: optimize virtio_access_is_big_endian() for little-endian targets

2015-11-13 Thread Greg Kurz
On Thu, 12 Nov 2015 19:08:59 +0100 Cornelia Huck wrote: > On Mon, 09 Nov 2015 18:58:34 +0100 > Greg Kurz wrote: > > > When adding cross-endian support, we introduced the TARGET_IS_BIENDIAN macro > > and the virtio_access_is_big_endian() helper to have a branchless fast path > > in the virtio me

Re: [Qemu-devel] [v2 1/2] cutils: add avx2 instruction optimization

2015-11-13 Thread Paolo Bonzini
> > ... define buffer_find_nonzero_offset_inner ... > > ... define can_use_buffer_find_nonzero_offset_inner ... > > > #if defined CONFIG_HAVE_GNU_IFUNC && defined CONFIG_HAVE_AVX2 ... > > define buffer_find_nonzero_offset_avx2 ... > > ... define can_use_buffer_find_nonzero_offset_avx2 ... > > ...

Re: [Qemu-devel] [PATCH] nand: fix address overflow

2015-11-13 Thread Paolo Bonzini
> > On 10/11/2015 14:25, Rabin Vincent wrote: > >> The shifts of the address mask and value shift beyond 32 bits when there > >> are 5 address cycles. > >> > >> Signed-off-by: Rabin Vincent > >> --- > >> hw/block/nand.c |4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> d

Re: [Qemu-devel] 回复: qemu-2.2 using trace event

2015-11-13 Thread Stefan Hajnoczi
On Wed, Nov 11, 2015 at 05:18:56PM +0800, 浩樊啊 wrote: > Hi, I can use trace-event now , but i still don't know what the second list > stands for? > is it a execution time of a function? If you are using the "simple" trace backend then the second column contains the time delta (in microseconds) sin

[Qemu-devel] [PATCH] virtio-blk: Fix double completion for werror=stop

2015-11-13 Thread Fam Zheng
When a request R is absorbed by request M, it is appended to the "mr_next" queue led by M, and is completed together with the completion of M, in virtio_blk_rw_complete. With error policy equals stop, if M has an I/O error, now R also gets prepended to the per device DMA restart queue, which will

Re: [Qemu-devel] anybody using MMIO tracing?

2015-11-13 Thread Stefan Hajnoczi
On Fri, Nov 06, 2015 at 09:47:45AM -0800, Hollis Blanchard wrote: > By the way, docs/tracing.txt says: > >The "simple" backend currently does not capture string arguments, it >simply >records the char* pointer value instead of the string that is >pointed to. > > This seems no long

Re: [Qemu-devel] [PATCH] vfio: Fix handling VFIO_IOMMU_GET_INFO results

2015-11-13 Thread Pavel Fedin
Hello! > > If we fix qemu, it will automatically start working with all > > available kernels which are there in the wild. If we fix kernel, older > > versions will still not work, however they can. > > That's why i think that we should adapt qemu to what already exists. > > But, well, you are

Re: [Qemu-devel] [Qemu-block] [PATCH v6 0/4] qapi: child add/delete support

2015-11-13 Thread Wen Congyang
On 11/13/2015 05:28 PM, Stefan Hajnoczi wrote: > On Fri, Oct 30, 2015 at 02:11:30PM +0800, Wen Congyang wrote: >> Ping... > > Tips for faster code review: > > It helps to mention the specific person you are expecting review from > when the CC list is long. For example, "Kevin: ping". Do you mea

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.5] mac_dbdma: always initialize channel field in DBDMA_channel

2015-11-13 Thread Hervé Poussineau
Le 13/11/2015 05:09, Programmingkid a écrit : On Nov 12, 2015, at 11:04 PM, qemu-ppc-requ...@nongnu.org wrote: Message: 3 Date: Thu, 12 Nov 2015 22:24:08 +0100 From: Herv? Poussineau To: qemu-devel@nongnu.org Cc: "open list:Old World" , Herv? Poussineau Subject: [Qemu-ppc] [PATCH for

Re: [Qemu-devel] [PATCH V5] block/nfs: add support for setting debug level

2015-11-13 Thread Stefan Hajnoczi
On Mon, Nov 09, 2015 at 08:09:33AM +0100, Peter Lieven wrote: > recent libnfs versions support logging debug messages. Add > support for it in qemu through an URL parameter. > > Example: > qemu -cdrom nfs://127.0.0.1/iso/my.iso?debug=2 > > Signed-off-by: Peter Lieven > --- > v4->v5: add a comme

Re: [Qemu-devel] [PATCH V5] block/nfs: add support for setting debug level

2015-11-13 Thread Peter Lieven
Am 13.11.2015 um 10:45 schrieb Stefan Hajnoczi: > On Mon, Nov 09, 2015 at 08:09:33AM +0100, Peter Lieven wrote: >> recent libnfs versions support logging debug messages. Add >> support for it in qemu through an URL parameter. >> >> Example: >> qemu -cdrom nfs://127.0.0.1/iso/my.iso?debug=2 >> >> S

Re: [Qemu-devel] [PATCH 09/12] vl: Replace DT_NOGRAPHIC with MachineState field

2015-11-13 Thread Paolo Bonzini
> > Can you add a QOM property too, so that "-machine graphics=yes|no" can > > be used? > > I can, but I would like to clarify the expected semantics. With > the -machine option, we would have: > > * -display, which affects only the display UI. > * -nographic, which affects: > * The display UI;

Re: [Qemu-devel] [Qemu-block] [PATCH v6 0/4] qapi: child add/delete support

2015-11-13 Thread Stefan Hajnoczi
On Fri, Nov 13, 2015 at 5:37 PM, Wen Congyang wrote: > On 11/13/2015 05:28 PM, Stefan Hajnoczi wrote: >> On Fri, Oct 30, 2015 at 02:11:30PM +0800, Wen Congyang wrote: >>> Ping... >> >> Tips for faster code review: >> >> It helps to mention the specific person you are expecting review from >> when

Re: [Qemu-devel] [Qemu-block] [PATCH] block: make 'stats-intervals' a list of integers

2015-11-13 Thread Stefan Hajnoczi
On Wed, Nov 11, 2015 at 03:17:12PM +0200, Alberto Garcia wrote: > This is the natural JSON representation and prevents us from having to > decode the list manually. > > Signed-off-by: Alberto Garcia > --- > blockdev.c | 64 > ++ > qapi

Re: [Qemu-devel] [Qemu-block] [PATCH v4] virtio-blk: trivial code optimization

2015-11-13 Thread Stefan Hajnoczi
On Wed, Nov 11, 2015 at 09:59:26AM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > 1. avoid possible superflous checking > 2. make code more robustness > > Signed-off-by: Gonglei > --- > v4: address possible integer underover [Stefan] >please review again, thanks > --- > hw/bloc

Re: [Qemu-devel] [PATCH 2/2] trace: show MemoryRegion name, not address

2015-11-13 Thread Stefan Hajnoczi
On Wed, Nov 11, 2015 at 05:09:58PM -0800, Hollis Blanchard wrote: > Recording the MemoryRegion pointers isn't helpful, especially since no trace > data allows us to correlate those pointers to devices. Instead, record the > MemoryRegion name. > > Signed-off-by: Hollis Blanchard > --- > memory.c

Re: [Qemu-devel] which machinetypes have an integrated/implied IDE controller?

2015-11-13 Thread Paolo Bonzini
A quick "git grep -l ahci" says that in addition to q35, three ARM boards have an AHCI controller: highbank, cubieboard (also known as allwinner-a10) and xilinx-zynq-a9 (also known as xlnx-zynqmp). Everything else that has IDE really means parallel ATA. In practice the only difference between the

Re: [Qemu-devel] [PATCH v4 0/5] handle vhost reset/start/stop correctly

2015-11-13 Thread Michael S. Tsirkin
On Fri, Nov 13, 2015 at 10:03:29AM +0800, Yuanhan Liu wrote: > On Thu, Nov 12, 2015 at 04:44:19PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 12, 2015 at 10:08:15PM +0800, Yuanhan Liu wrote: > > > On Thu, Nov 12, 2015 at 03:33:41PM +0200, Michael S. Tsirkin wrote: > > > > On Wed, Nov 11, 2015

Re: [Qemu-devel] [PATCH] tests: Ignore test-blockjob-txn

2015-11-13 Thread Stefan Hajnoczi
On Thu, Nov 12, 2015 at 11:33:48AM -0700, Eric Blake wrote: > Commit 6c6f312d added a new test, but did not mark it for > exclusion in .gitignore. > > Signed-off-by: Eric Blake > --- > > Yeah, I know this affects only non-VPATH builds, which we don't > recommend, but we might as well be consiste

Re: [Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child

2015-11-13 Thread Wen Congyang
On 11/10/2015 09:40 AM, Wen Congyang wrote: > On 11/10/2015 12:04 AM, Kevin Wolf wrote: >> Am 16.10.2015 um 10:57 hat Wen Congyang geschrieben: >>> +## >>> +# @ChangeOperation: >>> +# >>> +# An enumeration of block device change operation. >>> +# >>> +# @add: Add a new block driver state to a exist

Re: [Qemu-devel] [PULL v3 00/15] Tracing patches

2015-11-13 Thread Peter Maydell
On 13 November 2015 at 07:58, Stefan Hajnoczi wrote: > v3: > * Include "exec/log.h" from translate-a64.c [Peter] > > v2: > * Add missing log.py file [Peter] > > The following changes since commit 74fcbd22d20a2fbc1a47a7b00cce5bf98fd7be5f: > > hw/misc: Add support for ADC controller in Xilinx Zy

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.5] mac_dbdma: always initialize channel field in DBDMA_channel

2015-11-13 Thread Thomas Huth
On 13/11/15 10:45, Hervé Poussineau wrote: > Le 13/11/2015 05:09, Programmingkid a écrit : >> >> On Nov 12, 2015, at 11:04 PM, qemu-ppc-requ...@nongnu.org wrote: >> >>> Message: 3 >>> Date: Thu, 12 Nov 2015 22:24:08 +0100 >>> From: Herv? Poussineau >>> To: qemu-devel@nongnu.org >>> Cc: "open list:

[Qemu-devel] [PATCH] configure: sanity check the glib library that pkg-config finds

2015-11-13 Thread Daniel P. Berrange
Developers on 64-bit machines will often try to perform a 32-bit build of QEMU by running ./configure --extra-cflags="-m32" Unfortunately if PKG_CONFIG_LIBDIR is not set to point to the location of the 32-bit pkg-config files, then configure will silently pick up the 64-bit pkg-config files and

Re: [Qemu-devel] [PULL v3 00/15] Tracing patches

2015-11-13 Thread Stefan Hajnoczi
On Fri, Nov 13, 2015 at 6:30 PM, Peter Maydell wrote: > On 13 November 2015 at 07:58, Stefan Hajnoczi wrote: >> v3: >> * Include "exec/log.h" from translate-a64.c [Peter] >> >> v2: >> * Add missing log.py file [Peter] >> >> The following changes since commit 74fcbd22d20a2fbc1a47a7b00cce5bf98fd7

Re: [Qemu-devel] [PATCH] virtio-blk: Fix double completion for werror=stop

2015-11-13 Thread Laurent Vivier
On 13/11/2015 10:32, Fam Zheng wrote: > When a request R is absorbed by request M, it is appended to the > "mr_next" queue led by M, and is completed together with the completion > of M, in virtio_blk_rw_complete. > > With error policy equals stop, if M has an I/O error, now R also gets > prepen

Re: [Qemu-devel] [Qemu-block] [PATCH] block: make 'stats-intervals' a list of integers

2015-11-13 Thread Alberto Garcia
On Fri 13 Nov 2015 11:15:52 AM CET, Stefan Hajnoczi wrote: > blockdev.c: In function ‘blockdev_init’: > blockdev.c:636:17: error: ‘length’ may be used uninitialized in this function > [-Werror=maybe-uninitialized] > block_acct_add_interval(blk_get_stats(blk), length); >

Re: [Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child

2015-11-13 Thread Kevin Wolf
Am 13.11.2015 um 11:25 hat Wen Congyang geschrieben: > On 11/10/2015 09:40 AM, Wen Congyang wrote: > > On 11/10/2015 12:04 AM, Kevin Wolf wrote: > >> Am 16.10.2015 um 10:57 hat Wen Congyang geschrieben: > >>> +## > >>> +# @ChangeOperation: > >>> +# > >>> +# An enumeration of block device change ope

Re: [Qemu-devel] [PATCH] nand: fix address overflow

2015-11-13 Thread Kevin Wolf
Am 13.11.2015 um 10:32 hat Paolo Bonzini geschrieben: > > > On 10/11/2015 14:25, Rabin Vincent wrote: > > >> The shifts of the address mask and value shift beyond 32 bits when there > > >> are 5 address cycles. > > >> > > >> Signed-off-by: Rabin Vincent > > >> --- > > >> hw/block/nand.c |4 ++

[Qemu-devel] [PATCH QEMU 2/2] xen: fix usage of xc_domain_create in domain builder

2015-11-13 Thread Roger Pau Monne
Due to the addition of HVMlite and the requirement to always provide a valid xc_domain_configuration_t, xc_domain_create now always takes an arch domain config, which can be NULL in order to mimic previous behaviour. Signed-off-by: Roger Pau Monné --- Cc: Stefano Stabellini Cc: qemu-devel@nongnu

Re: [Qemu-devel] [PATCH QEMU 2/2] xen: fix usage of xc_domain_create in domain builder

2015-11-13 Thread Stefano Stabellini
On Fri, 13 Nov 2015, Roger Pau Monne wrote: > Due to the addition of HVMlite and the requirement to always provide a valid > xc_domain_configuration_t, xc_domain_create now always takes an arch domain > config, which can be NULL in order to mimic previous behaviour. > > Signed-off-by: Roger Pau Mo

Re: [Qemu-devel] [PATCH V4 0/6] ide: avoid main-loop hang on CDROM/NFS failure

2015-11-13 Thread Mark Cave-Ayland
On 12/11/15 16:30, Peter Lieven wrote: > This series aims at avoiding a hanging main-loop if a vserver has a > CDROM image mounted from a NFS share and that NFS share goes down. > Typical situation is that users mount an CDROM ISO to install something > and then forget to eject that CDROM afterwar

Re: [Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child

2015-11-13 Thread Wen Congyang
On 11/13/2015 06:53 PM, Kevin Wolf wrote: > Am 13.11.2015 um 11:25 hat Wen Congyang geschrieben: >> On 11/10/2015 09:40 AM, Wen Congyang wrote: >>> On 11/10/2015 12:04 AM, Kevin Wolf wrote: Am 16.10.2015 um 10:57 hat Wen Congyang geschrieben: > +## > +# @ChangeOperation: > +# >

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.5] mac_dbdma: always initialize channel field in DBDMA_channel

2015-11-13 Thread Mark Cave-Ayland
On 13/11/15 09:45, Hervé Poussineau wrote: > Le 13/11/2015 05:09, Programmingkid a écrit : >> >> On Nov 12, 2015, at 11:04 PM, qemu-ppc-requ...@nongnu.org wrote: >> >>> Message: 3 >>> Date: Thu, 12 Nov 2015 22:24:08 +0100 >>> From: Herv? Poussineau >>> To: qemu-devel@nongnu.org >>> Cc: "open list

Re: [Qemu-devel] [OpenBIOS] CUDA has problems with Mac OS 10.4

2015-11-13 Thread Mark Cave-Ayland
On 12/11/15 00:42, Programmingkid wrote: > On Nov 11, 2015, at 6:05 PM, Mark Cave-Ayland wrote: > >> On 11/11/15 21:32, Andreas Tobler wrote: >> >>> On 11.11.15 19:55, Programmingkid wrote: On Nov 11, 2015, at 12:54 PM, Mark Cave-Ayland wrote: > On 11/11/15 15:15, Programmingki

Re: [Qemu-devel] [PULL v3 00/15] Tracing patches

2015-11-13 Thread Peter Maydell
On 13 November 2015 at 10:30, Peter Maydell wrote: > I also now get a handful of extra warnings in the 'make check' output: > > /aarch64/qom/xilinx-zynq-a9: OK > /aarch64/qom/xlnx-ep108: > WARNING: RAM size 800 is small for EP108OK > /aarch64/qom/v

[Qemu-devel] [PATCH v2] configure: sanity check the glib library that pkg-config finds

2015-11-13 Thread Daniel P. Berrange
Developers on 64-bit machines will often try to perform a 32-bit build of QEMU by running ./configure --extra-cflags="-m32" Unfortunately if PKG_CONFIG_LIBDIR is not set to point to the location of the 32-bit pkg-config files, then configure will silently pick up the 64-bit pkg-config files and

Re: [Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child

2015-11-13 Thread Kevin Wolf
Am 13.11.2015 um 12:19 hat Wen Congyang geschrieben: > On 11/13/2015 06:53 PM, Kevin Wolf wrote: > > Am 13.11.2015 um 11:25 hat Wen Congyang geschrieben: > >> On 11/10/2015 09:40 AM, Wen Congyang wrote: > >>> On 11/10/2015 12:04 AM, Kevin Wolf wrote: > Am 16.10.2015 um 10:57 hat Wen Congyang g

Re: [Qemu-devel] [PATCH 09/12] vl: Replace DT_NOGRAPHIC with MachineState field

2015-11-13 Thread Peter Maydell
On 12 November 2015 at 09:48, Paolo Bonzini wrote: > > > On 11/11/2015 20:09, Eduardo Habkost wrote: >> All DisplayType values are just UI options that don't affect any >> hardware emulation code, except for DT_NOGRAPHIC. Replace >> DT_NOGRAPHIC with DT_NONE plus a new MachineState.nographic >> fi

Re: [Qemu-devel] [PULL v3 00/15] Tracing patches

2015-11-13 Thread Paolo Bonzini
On 13/11/2015 11:30, Peter Maydell wrote: > I also now get a handful of extra warnings in the 'make check' output: > > /aarch64/qom/xilinx-zynq-a9: OK > /aarch64/qom/xlnx-ep108: > WARNING: RAM size 800 is small for EP108OK > /aarch64/qom/vexpress

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.5] mac_dbdma: always initialize channel field in DBDMA_channel

2015-11-13 Thread Hervé Poussineau
Le 13/11/2015 11:40, Thomas Huth a écrit : On 13/11/15 10:45, Hervé Poussineau wrote: Le 13/11/2015 05:09, Programmingkid a écrit : On Nov 12, 2015, at 11:04 PM, qemu-ppc-requ...@nongnu.org wrote: Message: 3 Date: Thu, 12 Nov 2015 22:24:08 +0100 From: Herv? Poussineau To: qemu-devel@nongnu.

[Qemu-devel] [PATCH QEMU v2 2/2] xen: fix usage of xc_domain_create in domain builder

2015-11-13 Thread Roger Pau Monne
Due to the addition of HVMlite and the requirement to always provide a valid xc_domain_configuration_t, xc_domain_create now always takes an arch domain config, which can be NULL in order to mimic previous behaviour. Add a small stub called xen_domain_create that encapsulates the correct call to x

Re: [Qemu-devel] [PATCH 09/12] vl: Replace DT_NOGRAPHIC with MachineState field

2015-11-13 Thread Markus Armbruster
Paolo Bonzini writes: >> > Can you add a QOM property too, so that "-machine graphics=yes|no" can >> > be used? >> >> I can, but I would like to clarify the expected semantics. With >> the -machine option, we would have: >> >> * -display, which affects only the display UI. >> * -nographic, whic

Re: [Qemu-devel] [POC]colo-proxy in qemu

2015-11-13 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > > > On 11/10/2015 06:54 PM, Dr. David Alan Gilbert wrote: > >* Tkid (zhangchen.f...@cn.fujitsu.com) wrote: > >>(3)SN Qemu COLO-Proxy recieve SVM's packets and forward to PN Qemu > >>COLO-Proxy. > >What protocol are you using for the data car

Re: [Qemu-devel] [PATCH v2 3/4] usb-mtp: Add support for inotify based file monitoring

2015-11-13 Thread Gerd Hoffmann
Hi, > +switch (mask) { > +case IN_CREATE: > +if (event->mask & IN_ISDIR) { > +/* > + * Add the watchpoint first so we > + * don't miss events in this subdir > + */ > +

Re: [Qemu-devel] [PATCH v2] configure: sanity check the glib library that pkg-config finds

2015-11-13 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > Developers on 64-bit machines will often try to perform a > 32-bit build of QEMU by running > > ./configure --extra-cflags="-m32" > > Unfortunately if PKG_CONFIG_LIBDIR is not set to point to > the location of the 32-bit pkg-config files, then

[Qemu-devel] [PATCH] net: convert qemu_log to error_report

2015-11-13 Thread Paolo Bonzini
Ensure that the error is printed with the proper timestamp. Signed-off-by: Paolo Bonzini --- net/dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dump.c b/net/dump.c index dd0555f..ab71ffc 100644 --- a/net/dump.c +++ b/net/dump.c @@ -84,7 +84,7 @@ static ssize_t dum

[Qemu-devel] [PATCH for-2.5] block: Call external_snapshot_clean after blockdev-snapshot

2015-11-13 Thread Alberto Garcia
Otherwise the AioContext will never be released. Signed-off-by: Alberto Garcia --- blockdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/blockdev.c b/blockdev.c index fc85128..4dcc510 100644 --- a/blockdev.c +++ b/blockdev.c @@ -2070,6 +2070,7 @@ static const BlkActionOps actions[] = {

Re: [Qemu-devel] [PATCH v2] configure: sanity check the glib library that pkg-config finds

2015-11-13 Thread Gerd Hoffmann
On Fr, 2015-11-13 at 11:31 +, Daniel P. Berrange wrote: > Developers on 64-bit machines will often try to perform a > 32-bit build of QEMU by running > > ./configure --extra-cflags="-m32" > > Unfortunately if PKG_CONFIG_LIBDIR is not set to point to > the location of the 32-bit pkg-config f

Re: [Qemu-devel] [PATCH v2] configure: sanity check the glib library that pkg-config finds

2015-11-13 Thread Peter Maydell
On 13 November 2015 at 11:31, Daniel P. Berrange wrote: > Developers on 64-bit machines will often try to perform a > 32-bit build of QEMU by running > > ./configure --extra-cflags="-m32" > > Unfortunately if PKG_CONFIG_LIBDIR is not set to point to > the location of the 32-bit pkg-config files,

Re: [Qemu-devel] [PATCH 09/12] vl: Replace DT_NOGRAPHIC with MachineState field

2015-11-13 Thread Paolo Bonzini
On 13/11/2015 12:49, Peter Maydell wrote: > On 12 November 2015 at 09:48, Paolo Bonzini wrote: >> >> >> On 11/11/2015 20:09, Eduardo Habkost wrote: >>> All DisplayType values are just UI options that don't affect any >>> hardware emulation code, except for DT_NOGRAPHIC. Replace >>> DT_NOGRAPHIC

Re: [Qemu-devel] which machinetypes have an integrated/implied IDE controller?

2015-11-13 Thread Markus Armbruster
Laine Stump writes: > For a long time, libvirt assumed by default that all types of virtual > machines had an integrated IDE controller named "ide" that wasn't > specified on the qemu commandline. Since that caused problems > specifically for the Q35 machine type (which has an *ahci* controller >

Re: [Qemu-devel] [PATCH] virtio-blk: Fix double completion for werror=stop

2015-11-13 Thread Paolo Bonzini
On 13/11/2015 10:32, Fam Zheng wrote: > When a request R is absorbed by request M, it is appended to the > "mr_next" queue led by M, and is completed together with the completion > of M, in virtio_blk_rw_complete. > > With error policy equals stop, if M has an I/O error, now R also gets > prepen

Re: [Qemu-devel] [PATCH v4 17/17] ipmi: Add a force off function

2015-11-13 Thread Corey Minyard
On 11/13/2015 03:15 AM, Daniel P. Berrange wrote: > On Thu, Nov 12, 2015 at 01:02:33PM -0600, miny...@acm.org wrote: >> From: Corey Minyard >> >> Allow the IPMI interface to request a forced power off. >> >> Signed-off-by: Corey Minyard >> --- >> hw/ipmi/ipmi_bmc_extern.c | 5 + >> 1 file ch

Re: [Qemu-devel] [PATCH v4 17/17] ipmi: Add a force off function

2015-11-13 Thread Paolo Bonzini
On 13/11/2015 14:22, Corey Minyard wrote: > On 11/13/2015 03:15 AM, Daniel P. Berrange wrote: >> On Thu, Nov 12, 2015 at 01:02:33PM -0600, miny...@acm.org wrote: >>> From: Corey Minyard >>> >>> Allow the IPMI interface to request a forced power off. >>> >>> Signed-off-by: Corey Minyard >>> ---

Re: [Qemu-devel] [PATCH v4 17/17] ipmi: Add a force off function

2015-11-13 Thread Corey Minyard
On 11/13/2015 07:23 AM, Paolo Bonzini wrote: > > On 13/11/2015 14:22, Corey Minyard wrote: >> On 11/13/2015 03:15 AM, Daniel P. Berrange wrote: >>> On Thu, Nov 12, 2015 at 01:02:33PM -0600, miny...@acm.org wrote: From: Corey Minyard Allow the IPMI interface to request a forced power

Re: [Qemu-devel] [PATCH QEMU v2 2/2] xen: fix usage of xc_domain_create in domain builder

2015-11-13 Thread Stefano Stabellini
On Fri, 13 Nov 2015, Roger Pau Monne wrote: > Due to the addition of HVMlite and the requirement to always provide a valid > xc_domain_configuration_t, xc_domain_create now always takes an arch domain > config, which can be NULL in order to mimic previous behaviour. > > Add a small stub called xen

Re: [Qemu-devel] [PATCH QEMU v2 2/2] xen: fix usage of xc_domain_create in domain builder

2015-11-13 Thread Ian Campbell
On Fri, 2015-11-13 at 13:46 +, Stefano Stabellini wrote: > On Fri, 13 Nov 2015, Roger Pau Monne wrote: > > Due to the addition of HVMlite and the requirement to always provide a > > valid > > xc_domain_configuration_t, xc_domain_create now always takes an arch > > domain > > config, which can b

Re: [Qemu-devel] [PATCH v4 17/17] ipmi: Add a force off function

2015-11-13 Thread Daniel P. Berrange
On Fri, Nov 13, 2015 at 02:23:35PM +0100, Paolo Bonzini wrote: > > > On 13/11/2015 14:22, Corey Minyard wrote: > > On 11/13/2015 03:15 AM, Daniel P. Berrange wrote: > >> On Thu, Nov 12, 2015 at 01:02:33PM -0600, miny...@acm.org wrote: > >>> From: Corey Minyard > >>> > >>> Allow the IPMI interfac

Re: [Qemu-devel] [PATCH 2/2] trace: show MemoryRegion name, not address

2015-11-13 Thread Paolo Bonzini
On 13/11/2015 11:23, Stefan Hajnoczi wrote: >> > tmp = mr->ops->old_mmio.read[ctz32(size)](mr->opaque, addr); >> > -trace_memory_region_ops_read(mr, addr, tmp, size); >> > +trace_memory_region_ops_read(mr->name, addr, tmp, size); > mr->name may be NULL. There is a memory_region_name

Re: [Qemu-devel] [PATCH v2] configure: sanity check the glib library that pkg-config finds

2015-11-13 Thread Daniel P. Berrange
On Fri, Nov 13, 2015 at 01:01:52PM +, Peter Maydell wrote: > On 13 November 2015 at 11:31, Daniel P. Berrange wrote: > > Developers on 64-bit machines will often try to perform a > > 32-bit build of QEMU by running > > > > ./configure --extra-cflags="-m32" > > > > Unfortunately if PKG_CONFIG

[Qemu-devel] [PATCH] nand: fix flash erase when oob is in memory

2015-11-13 Thread Ricard Wanderlof
For the "main area on file, oob in memory" case, fix the shifts so that we erase the correct number of pages. Signed-off-by: Ricard Wanderlöf --- hw/block/nand.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nand.c b/hw/block/nand.c index a68266f..f0e3413 10064

[Qemu-devel] [PATCH] nand: fix flash erase when oob is in memory

2015-11-13 Thread Ricard Wanderlof
For the "main area on file, oob in memory" case, fix the shifts so that we erase the correct number of pages. Signed-off-by: Ricard Wanderlöf --- hw/block/nand.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nand.c b/hw/block/nand.c index a68266f..f0e3413 10064

Re: [Qemu-devel] [PATCH 3/3] virtio: optimize virtio_access_is_big_endian() for little-endian targets

2015-11-13 Thread Cornelia Huck
On Fri, 13 Nov 2015 10:28:31 +0100 Greg Kurz wrote: > On Thu, 12 Nov 2015 19:08:59 +0100 > Cornelia Huck wrote: > > > On Mon, 09 Nov 2015 18:58:34 +0100 > > Greg Kurz wrote: > > > > > When adding cross-endian support, we introduced the TARGET_IS_BIENDIAN > > > macro > > > and the virtio_acce

Re: [Qemu-devel] [PATCH v2 1/2] virtio-net: use the backend cross-endian capabilities

2015-11-13 Thread Cornelia Huck
On Fri, 13 Nov 2015 09:26:26 +0100 Greg Kurz wrote: > On Thu, 12 Nov 2015 18:52:55 +0100 > Cornelia Huck wrote: > > > On Mon, 09 Nov 2015 18:41:33 +0100 > > Greg Kurz wrote: > > > +static bool virtio_net_needs_hdr_swap(VirtIONet *n) > > > +{ > > > +/* virtio_needs_swap() is constant for f

Re: [Qemu-devel] [PATCH] net: convert qemu_log to error_report

2015-11-13 Thread Eric Blake
On 11/13/2015 05:58 AM, Paolo Bonzini wrote: > Ensure that the error is printed with the proper timestamp. > > Signed-off-by: Paolo Bonzini > --- > net/dump.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake > > diff --git a/net/dump.c b/net/dump.c > index dd05

Re: [Qemu-devel] [PATCH v2 1/2] virtio-net: use the backend cross-endian capabilities

2015-11-13 Thread Greg Kurz
On Fri, 13 Nov 2015 15:46:06 +0100 Cornelia Huck wrote: > On Fri, 13 Nov 2015 09:26:26 +0100 > Greg Kurz wrote: > > > On Thu, 12 Nov 2015 18:52:55 +0100 > > Cornelia Huck wrote: > > > > > On Mon, 09 Nov 2015 18:41:33 +0100 > > > Greg Kurz wrote: > > > > > +static bool virtio_net_needs_hdr_s

Re: [Qemu-devel] [PATCH] tests: Ignore test-blockjob-txn

2015-11-13 Thread Eric Blake
On 11/13/2015 03:26 AM, Stefan Hajnoczi wrote: > On Thu, Nov 12, 2015 at 11:33:48AM -0700, Eric Blake wrote: >> Commit 6c6f312d added a new test, but did not mark it for >> exclusion in .gitignore. >> >> Signed-off-by: Eric Blake >> --- >> >> Yeah, I know this affects only non-VPATH builds, which

Re: [Qemu-devel] Problems with VM after kernel commit b18d5431acc7a2fd22767925f3a6f597aa4bd29e

2015-11-13 Thread Paolo Bonzini
On 13/11/2015 15:55, Wolfgang Link wrote: > Hi, > > We have problems with a HP ProLiant DL380 Gen9 and Vm's with large > amount of memory, grater then 30GB. > > The problem is that the vm need about 10 sec to start to boot. > and when it comes to syncing the cpu clock, it takes a long time to >

Re: [Qemu-devel] Problems with VM after kernel commit b18d5431acc7a2fd22767925f3a6f597aa4bd29e

2015-11-13 Thread Wolfgang Link
Thanks you for the quick reply and the good news. Wolfgang On 11/13/2015 04:01 PM, Paolo Bonzini wrote: On 13/11/2015 15:55, Wolfgang Link wrote: Hi, We have problems with a HP ProLiant DL380 Gen9 and Vm's with large amount of memory, grater then 30GB. The problem is that the vm need about 1

Re: [Qemu-devel] Problems with VM after kernel commit b18d5431acc7a2fd22767925f3a6f597aa4bd29e

2015-11-13 Thread Paolo Bonzini
On 13/11/2015 16:03, Wolfgang Link wrote: > Thanks you for the quick reply and the good news. BTW, for kernel issues please use k...@vger.kernel.org :) Paolo > Wolfgang > On 11/13/2015 04:01 PM, Paolo Bonzini wrote: >> >> On 13/11/2015 15:55, Wolfgang Link wrote: >>> Hi, >>> >>> We have proble

[Qemu-devel] Problems with VM after kernel commit b18d5431acc7a2fd22767925f3a6f597aa4bd29e

2015-11-13 Thread Wolfgang Link
Hi, We have problems with a HP ProLiant DL380 Gen9 and Vm's with large amount of memory, grater then 30GB. The problem is that the vm need about 10 sec to start to boot. and when it comes to syncing the cpu clock, it takes a long time to finish this task. What also occurs is the vcpus need at

Re: [Qemu-devel] [PATCH 09/12] vl: Replace DT_NOGRAPHIC with MachineState field

2015-11-13 Thread Eduardo Habkost
On Fri, Nov 13, 2015 at 11:49:33AM +, Peter Maydell wrote: > On 12 November 2015 at 09:48, Paolo Bonzini wrote: > > > > > > On 11/11/2015 20:09, Eduardo Habkost wrote: > >> All DisplayType values are just UI options that don't affect any > >> hardware emulation code, except for DT_NOGRAPHIC. R

Re: [Qemu-devel] [PATCH] nand: fix flash erase when oob is in memory

2015-11-13 Thread Ricard Wanderlof
On Fri, 13 Nov 2015, Ricard Wanderlof wrote: > For the "main area on file, oob in memory" case, fix the shifts so that > we erase the correct number of pages. > ... Sorry about the duplicate post. Initially used the wrong email address when subscribing so when I subscribed with the correct on

Re: [Qemu-devel] [PATCH v3 1/3] target-i386: add a subsection for migrating vcpu's TSC rate

2015-11-13 Thread Eduardo Habkost
On Fri, Nov 13, 2015 at 10:23:54AM +0800, Haozhong Zhang wrote: > On 11/11/15 22:27, Haozhong Zhang wrote: > > On 11/11/15 12:16, Eduardo Habkost wrote: > [...] > > > > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > > > > index 2f8f396..858ed69 100644 > > > > --- a/hw/i386/pc_q35.c > > > > +++

Re: [Qemu-devel] [PATCH 3/3] virtio: optimize virtio_access_is_big_endian() for little-endian targets

2015-11-13 Thread Greg Kurz
On Fri, 13 Nov 2015 15:42:53 +0100 Cornelia Huck wrote: > On Fri, 13 Nov 2015 10:28:31 +0100 > Greg Kurz wrote: > > > On Thu, 12 Nov 2015 19:08:59 +0100 > > Cornelia Huck wrote: > > > > > On Mon, 09 Nov 2015 18:58:34 +0100 > > > Greg Kurz wrote: > > > > > > > When adding cross-endian suppor

[Qemu-devel] block/vpc: Fix vhd extra sectors issue

2015-11-13 Thread Lucian Petrut
At the moment, qemu-img extends new image virtual sizes based on the CHS algorithm provided by the VHD specs in order to ensure that the disk geometry (and payload as seen by some guests which use the CHS value) can fit in the requested disk. This patch drops this behavior, as it breaks compatibi

Re: [Qemu-devel] [PATCH 1/3] monitor: avoid clang shifting negative signed warning

2015-11-13 Thread Eduardo Habkost
On Tue, Nov 10, 2015 at 03:57:33PM +, Stefan Hajnoczi wrote: > clang 3.7.0 on x86_64 warns about the following: > > target-i386/monitor.c:38:22: warning: shifting a negative signed value is > undefined [-Wshift-negative-value] > addr |= -1LL << 48; > ^ > > Sign

Re: [Qemu-devel] [PATCH COLO-Frame v10 13/38] COLO: Load PVM's dirty pages into SVM's RAM cache temporarily

2015-11-13 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > We should not load PVM's state directly into SVM, because there maybe some > errors happen when SVM is receving data, which will break SVM. > > We need to ensure receving all data before load the state into SVM. We use > an extra memory to

Re: [Qemu-devel] [PATCH v4 0/5] handle vhost reset/start/stop correctly

2015-11-13 Thread Yuanhan Liu
On Fri, Nov 13, 2015 at 12:24:52PM +0200, Michael S. Tsirkin wrote: > On Fri, Nov 13, 2015 at 10:03:29AM +0800, Yuanhan Liu wrote: > > On Thu, Nov 12, 2015 at 04:44:19PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 12, 2015 at 10:08:15PM +0800, Yuanhan Liu wrote: > > > > On Thu, Nov 12, 2015

Re: [Qemu-devel] [PATCH v2 1/7] vl: Add DT_COCOA DisplayType value

2015-11-13 Thread Andreas Färber
Am 12.11.2015 um 20:02 schrieb Eduardo Habkost: > Instead of reusing DT_SDL for Cocoa, use DT_COCOA to indicate > that a Cocoa display was requested. > > configure already ensures CONFIG_COCOA and CONFIG_SDL are never > set at the same time. The only case where DT_SDL is used outside > a #ifdef CO

Re: [Qemu-devel] [PATCH COLO-Frame v10 14/38] COLO: Load VMState into qsb before restore it

2015-11-13 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > We should not destroy the state of SVM (Secondary VM) until we receive the > whole > state from the PVM (Primary VM), in case the primary fails in the middle of > sending > the state, so, here we cache the device state in Secondary before

Re: [Qemu-devel] [PATCH COLO-Frame v10 02/38] migration: Introduce capability 'x-colo' to migration

2015-11-13 Thread Eric Blake
On 11/03/2015 04:56 AM, zhanghailiang wrote: > We add helper function colo_supported() to indicate whether > colo is supported or not, with which we use to control whether or not > showing 'x-colo' string to users, they can use qmp command > 'query-migrate-capabilities' or hmp command 'info migrate

Re: [Qemu-devel] [PATCH for-2.5] mac_dbdma: always initialize channel field in DBDMA_channel

2015-11-13 Thread Mark Cave-Ayland
On 12/11/15 21:24, Hervé Poussineau wrote: > dbdma_from_ch() uses channel field to return the right DBDMA object. > Previous code was working if guest OS was only using registered DMA channels. > However, it lead to QEMU crashes if guest OS was using unregistered DMA > channels. > > Signed-off-b

Re: [Qemu-devel] [PATCH COLO-Frame v10 15/38] ram/COLO: Record pages received from PVM by re-using migration dirty bitmap

2015-11-13 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > We need to record the address of the dirty pages that received from PVM, > It will help flushing pages that cached into SVM. > > Signed-off-by: zhanghailiang > --- > v10: > - New patch split from v9's patch 13 > - Rebase to master to use '

Re: [Qemu-devel] [PATCH COLO-Frame v10 16/38] COLO: Flush PVM's cached RAM into SVM's memory

2015-11-13 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > During the time of VM's running, PVM may dirty some pages, we will transfer > PVM's dirty pages to SVM and store them into SVM's RAM cache at next > checkpoint > time. So, the content of SVM's RAM cache will always be some with PVM's memory

Re: [Qemu-devel] [PATCH COLO-Frame v10 05/38] migration: Integrate COLO checkpoint process into migration

2015-11-13 Thread Eric Blake
On 11/03/2015 04:56 AM, zhanghailiang wrote: > Add a migrate state: MIGRATION_STATUS_COLO, enter this migration state > after the first live migration successfully finished. > > We reuse migration thread, so if colo is enabled by user, migration thread > will > go into the process of colo. > > S

Re: [Qemu-devel] [PATCH] net: convert qemu_log to error_report

2015-11-13 Thread Thomas Huth
On 13/11/15 13:58, Paolo Bonzini wrote: > Ensure that the error is printed with the proper timestamp. > > Signed-off-by: Paolo Bonzini > --- > net/dump.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/dump.c b/net/dump.c > index dd0555f..ab71ffc 100644 > --- a/net/

Re: [Qemu-devel] [PATCH COLO-Frame v10 09/38] COLO: Implement colo checkpoint protocol

2015-11-13 Thread Eric Blake
On 11/03/2015 04:56 AM, zhanghailiang wrote: > We need communications protocol of user-defined to control the checkpoint > process. > > The new checkpoint request is started by Primary VM, and the interactive > process > like below: > Checkpoint synchronizing points, > >P

[Qemu-devel] [PATCH QEMU v3 2/2] xen: fix usage of xc_domain_create in domain builder

2015-11-13 Thread Roger Pau Monne
Due to the addition of HVMlite and the requirement to always provide a valid xc_domain_configuration_t, xc_domain_create now always takes an arch domain config, which can be NULL in order to mimic previous behaviour. Add a small stub called xen_domain_create that encapsulates the correct call to x

  1   2   >