On Wed, Nov 11, 2015 at 05:09:58PM -0800, Hollis Blanchard wrote: > Recording the MemoryRegion pointers isn't helpful, especially since no trace > data allows us to correlate those pointers to devices. Instead, record the > MemoryRegion name. > > Signed-off-by: Hollis Blanchard <hollis_blanch...@mentor.com> > --- > memory.c | 12 ++++++------ > trace-events | 4 ++-- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/memory.c b/memory.c > index c435c88..9bd4c31 100644 > --- a/memory.c > +++ b/memory.c > @@ -381,7 +381,7 @@ static MemTxResult > memory_region_oldmmio_read_accessor(MemoryRegion *mr, > uint64_t tmp; > > tmp = mr->ops->old_mmio.read[ctz32(size)](mr->opaque, addr); > - trace_memory_region_ops_read(mr, addr, tmp, size); > + trace_memory_region_ops_read(mr->name, addr, tmp, size);
mr->name may be NULL. There is a memory_region_name() function that always produces a real string. Perhaps it's best to use it.
signature.asc
Description: PGP signature
