Re: [Qemu-devel] [PATCH] i.MX: add support for lower and upper interrupt in GPIO.

2015-10-28 Thread Jean-Christophe DUBOIS
Le 27/10/2015 23:41, Peter Crosthwaite a écrit : On Tue, Oct 27, 2015 at 3:32 PM, Jean-Christophe Dubois mailto:j...@tribudubois.net>> wrote: The i.MX6 GPIO device supports 2 interrupts instead of one. * 1 for the lower 16 GPIOs. * 1 for the upper 16 GPIOs. i.MX31 and i.MX2

[Qemu-devel] [PULL v2 11/14] glib: add compatibility interface for g_hash_table_add()

2015-10-28 Thread Markus Armbruster
The next commit will use it. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- include/glib-compat.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/glib-compat.h b/include/glib-compat.h index fb25f43..6d13b5f 100644 --- a/include/glib-compat.h +++ b/include/glib-c

[Qemu-devel] [PULL v2 05/14] qlist: Make conversion from QObject * accept null

2015-10-28 Thread Markus Armbruster
qobject_to_qlist() crashes on null, which is a trap for the unwary. Return null instead. Signed-off-by: Markus Armbruster Message-Id: <1444918537-18107-6-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- qobject/qlist.c | 3 +-- 1 file changed, 1 insert

[Qemu-devel] [PULL v2 01/14] qobject: Drop QObject_HEAD

2015-10-28 Thread Markus Armbruster
QObject_HEAD is a macro expanding into the common part of structs that are sub-types of QObject. It's always been just QObject base, and unlikely to change. Drop the macro, because the code is clearer with out it. Signed-off-by: Markus Armbruster Message-Id: <1444918537-18107-2-git-send-email-a

[Qemu-devel] [PULL v2 02/14] qbool: Make conversion from QObject * accept null

2015-10-28 Thread Markus Armbruster
qobject_to_qbool() crashes on null, which is a trap for the unwary. Return null instead, and simplify a few callers. Signed-off-by: Markus Armbruster Message-Id: <1444918537-18107-3-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- qapi/qmp-input-visito

[Qemu-devel] [PULL v2 00/14] QMP and QObject patches

2015-10-28 Thread Markus Armbruster
The following changes since commit 7e038b94e74e1c2d1b3598e2e4b0b5c8b79a7278: Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into staging (2015-10-27 10:10:46 +) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2015-10-28

[Qemu-devel] [PULL v2 09/14] monitor: Switch from timer_new() to timer_new_ns()

2015-10-28 Thread Markus Armbruster
We don't actually care for the scale, so we can just as well use the simpler interface. Signed-off-by: Markus Armbruster Message-Id: <1444921716-9511-4-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake --- monitor.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --gi

[Qemu-devel] [PULL v2 04/14] qfloat qint: Make conversion from QObject * accept null

2015-10-28 Thread Markus Armbruster
qobject_to_qfloat() and qobject_to_qint() crash on null, which is a trap for the unwary. Return null instead, and simplify a few callers. Signed-off-by: Markus Armbruster Message-Id: <1444918537-18107-5-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino ---

[Qemu-devel] [PULL v2 08/14] monitor: Simplify event throttling

2015-10-28 Thread Markus Armbruster
The event throttling state machine is hard to understand. I'm not sure it's entirely correct. Rewrite it in a more straightforward manner: State 1: No event sent recently (less than evconf->rate ns ago) Invariant: evstate->timer is not pending, evstate->qdict is null On event: send eve

[Qemu-devel] [PULL v2 03/14] qdict: Make conversion from QObject * accept null

2015-10-28 Thread Markus Armbruster
qobject_to_qdict() crashes on null, which is a trap for the unwary. Return null instead, and simplify a few callers. Signed-off-by: Markus Armbruster Message-Id: <1444918537-18107-4-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- qga/main.c | 11

[Qemu-devel] [PULL v2 10/14] monitor: Split MonitorQAPIEventConf off MonitorQAPIEventState

2015-10-28 Thread Markus Armbruster
In preparation of turning monitor_qapi_event_state[] into a hash table for finer grained throttling. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <1444921716-9511-5-git-send-email-arm...@redhat.com> --- monitor.c | 80 ++---

[Qemu-devel] [PULL v2 12/14] monitor: Turn monitor_qapi_event_state[] into a hash table

2015-10-28 Thread Markus Armbruster
In preparation of finer grained throttling. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <1444921716-9511-6-git-send-email-arm...@redhat.com> --- monitor.c | 55 ++- 1 file changed, 38 insertions(+), 17 deletions(-) di

[Qemu-devel] [PULL v2 14/14] docs: Document QMP event rate limiting

2015-10-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <1444921716-9511-8-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake --- docs/qmp-events.txt | 12 docs/qmp-spec.txt | 5 + 2 files changed, 17 insertions(+) diff --git a/docs/qmp-events.txt b/docs/qmp-events.txt index d92

[Qemu-devel] [PULL v2 13/14] monitor: Throttle event VSERPORT_CHANGE separately by "id"

2015-10-28 Thread Markus Armbruster
VSERPORT_CHANGE is emitted when the guest opens or closes a virtio-serial port. The event's member "id" identifies the port. When several events arrive quickly, throttling drops all but the last of them. Because of that, a QMP client must assume that *any* port may have changed state when it rec

[Qemu-devel] [PULL v2 06/14] qstring: Make conversion from QObject * accept null

2015-10-28 Thread Markus Armbruster
qobject_to_qstring() crashes on null, which is a trap for the unwary. Return null instead, and simplify a few callers. Signed-off-by: Markus Armbruster Message-Id: <1444918537-18107-7-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- qapi/qmp-input-visi

[Qemu-devel] [PULL v2 07/14] monitor: Reduce casting of QAPI event QDict

2015-10-28 Thread Markus Armbruster
Make the variables holding the event QDict instead of QObject. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <1444921716-9511-2-git-send-email-arm...@redhat.com> --- monitor.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-)

Re: [Qemu-devel] [PATCH v2] ui/opengl: Reduce build required libraries for opengl

2015-10-28 Thread Gerd Hoffmann
On Di, 2015-10-27 at 02:45 +0900, OGAWA Hirofumi wrote: > We now use epoxy to load opengl libraries. This means we don't need to > link opengl libraries directly if interfaces handled by epoxy. With > this, we just need epoxy headers and epoxy's *.so to build. > > Tested with epoxy-1.3.1. > > - s

Re: [Qemu-devel] simple qmp core dump

2015-10-28 Thread Markus Armbruster
Markus Armbruster writes: > Eric Blake writes: > >> Just noticed this core dump (I was actually trying to exceed the 1024 >> hard-baked limit in qmp-input-visitor.c which tries to set an Error >> object, but it looks like that limit was unreachable due to this earlier >> assertion): >> >> $ prin

Re: [Qemu-devel] [PATCH v2] i386/acpi: add _HID to processor objects

2015-10-28 Thread Matthias Lange
On 10/23/2015 03:08 PM, Igor Mammedov wrote: > On Thu, 22 Oct 2015 22:03:24 +0200 > Matthias Lange wrote: > >> This patch appends "ACPI0007" as the HID to each processor object. >> >> Until commit 20843d processor objects used to have a _HID. According >> to the ACPI spec this is not required but

Re: [Qemu-devel] [RFC PATCH v1] spapr: Memory hot-unplug support

2015-10-28 Thread Bharata B Rao
On Tue, Oct 27, 2015 at 02:52:13PM -0500, Nathan Fontenot wrote: > On 10/26/2015 04:53 AM, Bharata B Rao wrote: > > Add support to hot remove pc-dimm memory devices. > > > > TODO: In response to memory hot removal operation on a DIMM device, > > guest kernel might refuse to offline a few LMBs that

Re: [Qemu-devel] [PATCH 0/1] Test the reopening of overlay_bs in 'block-commit'

2015-10-28 Thread Kevin Wolf
Am 27.10.2015 um 17:43 hat Alberto Garcia geschrieben: > Hi, looks like we have a bug in the bdrv_reopen() code. > > It turns out that 'block-commit' fails if the 'top' node is not the > active layer or its immediate backing file, and none of our test cases > has detected that. I'm attaching one t

[Qemu-devel] [Bug 1508405] Re: qemu 2.4.0 with --enable-kvm hangs, takes 100% CPU

2015-10-28 Thread cptG
Duh, I should've actually taken a closer look at the commit I found... another workaround for the problem is: qemu-system-x86_64 --enable-kvm -machine smm=off though the commit message seems to state that the default is off for kvm - so that's where the bug is? -- You received this bug notific

Re: [Qemu-devel] [PATCH 4/9] iscsi: Emulate commands in iscsi_aio_ioctl as iscsi_ioctl

2015-10-28 Thread Kevin Wolf
Am 26.10.2015 um 07:24 hat Fam Zheng geschrieben: > iscsi_ioctl emulates SG_GET_VERSION_NUM and SG_GET_SCSI_ID. Now that > bdrv_ioctl() will be emulated with .bdrv_aio_ioctl, replicate the logic > into iscsi_aio_ioctl to make them consistent. > > Signed-off-by: Fam Zheng > --- > block/iscsi.c |

[Qemu-devel] [PATCH v2] backends/hostmem-file: Allow to specify full pathname for backing file

2015-10-28 Thread Pavel Fedin
This allows to explicitly specify file name to use with the backend. This is important when using it together with ivshmem in order to make it backed by hugetlbfs. By default filename is autogenerated using mkstemp(), and the file is unlink()ed after creation, effectively making it anonymous. This

Re: [Qemu-devel] [PATCH 3/9] block: Track discard requests

2015-10-28 Thread Kevin Wolf
Am 26.10.2015 um 07:24 hat Fam Zheng geschrieben: > Both bdrv_discard and bdrv_aio_discard will call into bdrv_co_discard, > so add tracked_request_begin/end calls around the loop. > > Signed-off-by: Fam Zheng > --- > block/io.c | 14 ++ > 1 file changed, 10 insertions(+), 4 deletion

Re: [Qemu-devel] [PATCH] migration: Introduce migration_in_completion()

2015-10-28 Thread Juan Quintela
Pavel Fedin wrote: > Hello! > >> Applied, thanks. > > Thank you. > >> I wonder who it has never been needed before. BTW, what is ITS? > > ITS is Interrupt Translation Service. It is used by ARM64 > architecture. In a short, it is a special hardware which performs > table-based lookup of MSI ID

Re: [Qemu-devel] [PATCH 4/5] migration: add missed aio_context_acquire into hmp_savevm/hmp_delvm

2015-10-28 Thread Juan Quintela
"Denis V. Lunev" wrote: > aio_context should be locked in the similar way as was done in QMP > snapshot creation in the other case there are a lot of possible > troubles if native AIO mode is enabled for disk. > > - the command can hang (HMP thread) with missed wakeup (the operation is > actuall

Re: [Qemu-devel] [PATCH 8/9] block: Introduce BlockDriver.bdrv_drain callback

2015-10-28 Thread Kevin Wolf
Am 26.10.2015 um 07:24 hat Fam Zheng geschrieben: > Drivers can have internal request sources that generate IO, like the > need_check_timer in QED. Since we want quiesced periods that contain > nested event loops in block layer, we need to have a way to disable such > event sources. > > Block driv

Re: [Qemu-devel] [PATCH 0/9] block: Fixes for bdrv_drain

2015-10-28 Thread Kevin Wolf
Am 26.10.2015 um 07:24 hat Fam Zheng geschrieben: > Previously bdrv_drain and bdrv_drain_all don't handle ioctl, flush and discard > requests (which are fundamentally the same as read and write requests that > change disk state). Forgetting such requests leaves us in risk of violating > the invari

Re: [Qemu-devel] [PATCH] migration: Introduce migration_in_completion()

2015-10-28 Thread Pavel Fedin
Hello! > Power people have a similar problem with its hashed page tables, they > integrated their own save_live implementation because they are too big > for the last stage. You can look there for inspiration. Hm, i'll take a look... > How big are we talking here? Tables are normally large

Re: [Qemu-devel] [PATCH v8 41/54] postcopy_ram.c: place_page and helpers

2015-10-28 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > postcopy_place_page (etc) provide a way for postcopy to place a page > into guests memory atomically (using the copy ioctl on the ufd). > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: Amit Shah Reviewed-by: Ju

Re: [Qemu-devel] [PATCH v8 09/54] Add QEMU_MADV_NOHUGEPAGE

2015-10-28 Thread Amit Shah
On (Tue) 29 Sep 2015 [09:37:33], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add QEMU_MADV_NOHUGEPAGE as an OS-independent version of > MADV_NOHUGEPAGE. > > We include sys/mman.h before making the test to ensure > that we pick up the system defines. > > Signed-off-b

Re: [Qemu-devel] [PATCH v8 10/54] migration/ram.c: Use RAMBlock rather than MemoryRegion

2015-10-28 Thread Amit Shah
On (Tue) 29 Sep 2015 [09:37:34], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > RAM migration mainly works on RAMBlocks but in a few places > uses data from MemoryRegions to access the same information that's > already held in RAMBlocks; clean it up just to avoid the > M

Re: [Qemu-devel] [PATCH 4/5] migration: add missed aio_context_acquire into hmp_savevm/hmp_delvm

2015-10-28 Thread Denis V. Lunev
On 10/28/2015 01:11 PM, Juan Quintela wrote: "Denis V. Lunev" wrote: aio_context should be locked in the similar way as was done in QMP snapshot creation in the other case there are a lot of possible troubles if native AIO mode is enabled for disk. - the command can hang (HMP thread) with miss

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-10-28 Thread Laszlo Ersek
On 10/28/15 02:12, Gabriel L. Somlo wrote: > On Tue, Oct 27, 2015 at 01:43:39PM +0100, Laszlo Ersek wrote: >> On 10/27/15 12:11, Gerd Hoffmann wrote: >>> Hi, >>> > My hypothesis (which I guess I'm volunteering to verify, unless we > end up rejecting this immediately as a bad idea, for som

[Qemu-devel] [PATCH] block: Consider all child nodes in bdrv_requests_pending()

2015-10-28 Thread Kevin Wolf
The function manually recursed into bs->file and bs->backing to check whether there were any requests pending, but it ignored other children. There's no need to special case file and backing here, so just replace these two explicit recursions by a loop recursing for all child nodes. Reported-by:

Re: [Qemu-devel] [PATCH v8 42/54] Postcopy: Use helpers to map pages during migration

2015-10-28 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > In postcopy, the destination guest is running at the same time > as it's receiving pages; as we receive new pages we must put > them into the guests address space atomically to avoid a running > CPU accessing a partially w

Re: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

2015-10-28 Thread Stefan Hajnoczi
On Mon, Oct 26, 2015 at 01:24:00PM +0100, Gerd Hoffmann wrote: > > So this change would make real-time audio feel laggy. > > That is secondary if the sound quality is bad due to constant overruns > and underruns ... This is like sweeping network performance problems under the rug by increasing qu

Re: [Qemu-devel] [PATCH v8 44/54] Don't iterate on precopy-only devices during postcopy

2015-10-28 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > During the postcopy phase we must not call the iterate method on > precopy-only devices, since they may have done some cleanup during > the _complete call at the end of the precopy phase. > > Signed-off-by: Dr. David Alan

Re: [Qemu-devel] [PATCH v8 26/54] Modify save_live_pending for postcopy

2015-10-28 Thread Amit Shah
On (Tue) 29 Sep 2015 [09:37:50], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Modify save_live_pending to return separate postcopiable and > non-postcopiable counts. > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: Juan Quintela Reviewed-by: Amit Shah (I

Re: [Qemu-devel] [PATCH v2] target-arm: Extract some external ARM CPU API

2015-10-28 Thread Pavel Fedin
Hello! > Ok, so decided. I will convert my code, test the build and send a small > patch for this soon, > perhaps today. arm_gicv3_kvm.o is already in obj-y, and arm_gicv3_common.o does not use any of those definitions. So, nothing to move, there will be no patch. So far, we have only this

Re: [Qemu-devel] [PATCH v8 28/54] migrate_start_postcopy: Command to trigger transition to postcopy

2015-10-28 Thread Amit Shah
On (Tue) 29 Sep 2015 [09:37:52], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Once postcopy is enabled (with migrate_set_capability), the migration > will still start on precopy mode. To cause a transition into postcopy > the: > > migrate_start_postcopy > > comman

Re: [Qemu-devel] [PATCH v8 30/54] Avoid sending vmdescription during postcopy

2015-10-28 Thread Amit Shah
On (Tue) 29 Sep 2015 [09:37:54], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > VMDescription is normally sent at the end, after all > of the devices; however that's not the end for postcopy, > so just don't send it when in postcopy. > > Signed-off-by: Dr. David Alan Gi

Re: [Qemu-devel] [PATCH 0/1] Test the reopening of overlay_bs in 'block-commit'

2015-10-28 Thread Alberto Garcia
On Wed 28 Oct 2015 10:33:01 AM CET, Kevin Wolf wrote: > I've applied your test case to my working branch so I won't forget > about this. Maybe I should really try to get the series into 2.5 then. Note that 2.4 is also affected by this. I guess for that version we can simply swap the order of the

Re: [Qemu-devel] [PATCH V10 RESEND 0/3]Move sdhci.h to include/hw/sd

2015-10-28 Thread Stefan Hajnoczi
On Thu, Oct 08, 2015 at 06:51:00PM +0530, Sai Pavan Boddu wrote: > Move sdhci.h splitting it into common and internal. > Create a new directory for sd in include/hw/. > Correct paths of sd.h in at every instance of #include. > Add sdhci to xlnx-zynqmp SOC. > > Sai Pavan Boddu (3): > sd.h: Move s

Re: [Qemu-devel] [PATCH v8 45/54] Host page!=target page: Cleanup bitmaps

2015-10-28 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Prior to the start of postcopy, ensure that everything that will > be transferred later is a whole host-page in size. > > This is accomplished by discarding partially transferred host pages > and marking any that are parti

Re: [Qemu-devel] [PATCH 3/4] ide: add support for cancelable read requests

2015-10-28 Thread Stefan Hajnoczi
On Tue, Oct 27, 2015 at 11:58:55AM +0100, Peter Lieven wrote: > Am 26.10.2015 um 11:39 schrieb Stefan Hajnoczi: > >On Mon, Oct 12, 2015 at 02:27:24PM +0200, Peter Lieven wrote: > >>+BlockAIOCB *ide_readv_cancelable(IDEState *s, int64_t sector_num, > >>+ QEMUIOVector

Re: [Qemu-devel] [PATCH v8 46/54] postcopy: Check order of received target pages

2015-10-28 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Ensure that target pages received within a host page are in order. > This shouldn't trigger, but in the cases where the sender goes > wrong and sends stuff out of order it produces a corruption that's > really nasty to deb

Re: [Qemu-devel] [PATCH V2 0/4] ide: avoid main-loop hang on CDROM/NFS failure

2015-10-28 Thread Stefan Hajnoczi
On Mon, Oct 26, 2015 at 11:56:26AM +0100, Peter Lieven wrote: > Am 26.10.2015 um 11:42 schrieb Stefan Hajnoczi: > >On Mon, Oct 12, 2015 at 02:27:21PM +0200, Peter Lieven wrote: > >>This series aims at avoiding a hanging main-loop if a vserver has a > >>CDROM image mounted from a NFS share and that

Re: [Qemu-devel] [PATCH v8 47/54] Round up RAMBlock sizes to host page sizes

2015-10-28 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > RAMBlocks that are not a multiple of host pages in length > cause problems for postcopy (I've seen an ACPI table on aarch64 > be 5k in length - i.e. 5x target-page), so round RAMBlock sizes > up to a host-page. > > This po

Re: [Qemu-devel] [PATCH v2] target-arm: Extract some external ARM CPU API

2015-10-28 Thread Shlomo Pongratz
-Original Message- From: Pavel Fedin [mailto:p.fe...@samsung.com] Sent: 2015年10月28日 19:13 To: 'Peter Crosthwaite'; 'Paolo Bonzini' Cc: 'Peter Maydell'; 'Shlomo Pongratz'; 'QEMU Developers'; Shlomo Pongratz Subject: RE: [Qemu-devel] [PATCH v2] target-arm: Extract some external ARM CPU AP

Re: [Qemu-devel] [PATCH] migration: Introduce migration_in_completion()

2015-10-28 Thread Pavel Fedin
Hello! > Power people have a similar problem with its hashed page tables, they > integrated their own save_live implementation because they are too big > for the last stage. You can look there for inspiration. I examined their code. Interesting, and, indeed, it opens up a way for decreasing d

Re: [Qemu-devel] [PATCH 1/6] virtio: introduce virtio_map

2015-10-28 Thread Stefan Hajnoczi
On Tue, Oct 27, 2015 at 08:34:32PM +0200, Michael S. Tsirkin wrote: > On Tue, Oct 27, 2015 at 04:19:54PM +, Stefan Hajnoczi wrote: > > On Tue, Oct 27, 2015 at 10:47:56AM +0200, Michael S. Tsirkin wrote: > > > This will still fail if there's no space left in the sg, but luckily max > > > queue s

Re: [Qemu-devel] [PATCH v8 34/54] postcopy: ram_enable_notify to switch on userfault

2015-10-28 Thread Amit Shah
On (Tue) 29 Sep 2015 [09:37:58], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Mark the area of RAM as 'userfault' > Start up a fault-thread to handle any userfaults we might receive > from it (to be filled in later) > > Signed-off-by: Dr. David Alan Gilbert > Reviewe

Re: [Qemu-devel] [PATCH] fixup! virtio: introduce virtio_map

2015-10-28 Thread Stefan Hajnoczi
On Tue, Oct 27, 2015 at 11:00:36PM +0200, Michael S. Tsirkin wrote: > Stefan noticed that we must use memmove, not memcpy, > as arguments overlap. > > Signed-off-by: Michael S. Tsirkin > --- > hw/virtio/virtio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Stefan Haj

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Consider all child nodes in bdrv_requests_pending()

2015-10-28 Thread Alberto Garcia
On Wed 28 Oct 2015 11:46:51 AM CET, Kevin Wolf wrote: > The function manually recursed into bs->file and bs->backing to check > whether there were any requests pending, but it ignored other children. > > There's no need to special case file and backing here, so just replace > these two explicit rec

Re: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

2015-10-28 Thread Gerd Hoffmann
Hi, > Is the problem the host sound API, QEMU's audio/mixing infrastructure, > or guest responsiveness? Didn't check in deep this time, but usually none of the above. Latency problems *anywhere* in qemu can cause this, because the latency spikes cause the guest not being scheduled for too long

Re: [Qemu-devel] [PATCH for-2.5 v1 3/4] arm: highbank: Implement PSCI and dummy monitor

2015-10-28 Thread Peter Maydell
On 27 October 2015 at 20:29, Rob Herring wrote: > Thanks for doing this. I'm not a big fan of how the machine code for > boot code is embedded into C in qemu, but that's a separate issue. FWIW, I'm becoming increasingly unhappy with the approach too... it was straightforward when it was four asm

Re: [Qemu-devel] [PATCH 1/6] virtio: introduce virtio_map

2015-10-28 Thread Igor Mammedov
On Tue, 27 Oct 2015 10:47:56 +0200 "Michael S. Tsirkin" wrote: > virtio_map_sg currently fails if one of the entries it's mapping is > contigious in GPA but not HVA address space. Introduce virtio_map which > handles this by splitting sg entries. > > This new API generally turns out to be a goo

Re: [Qemu-devel] [PATCH 0/6] virtio: handle non contigious s/g entries

2015-10-28 Thread Igor Mammedov
On Tue, 27 Oct 2015 13:51:20 +0200 "Michael S. Tsirkin" wrote: > On Tue, Oct 27, 2015 at 10:47:54AM +0200, Michael S. Tsirkin wrote: > > TL;DR: > > This fixes virtio in a way transparent to guest. > > We should now be able to revert commits aa8580cd and df0acded19ec which > > worked > > around i

Re: [Qemu-devel] [PATCH 0/1] Test the reopening of overlay_bs in 'block-commit'

2015-10-28 Thread Kevin Wolf
Am 28.10.2015 um 12:20 hat Alberto Garcia geschrieben: > On Wed 28 Oct 2015 10:33:01 AM CET, Kevin Wolf wrote: > > > I've applied your test case to my working branch so I won't forget > > about this. Maybe I should really try to get the series into 2.5 then. > > Note that 2.4 is also affected by

[Qemu-devel] [RFC PATCH v3] tests/vhost-user-bridge: add vhost-user bridge application

2015-10-28 Thread Victor Kaplansky
The test existing in QEMU for vhost-user feature is good for testing the management protocol, but does not allow actual traffic. This patch proposes Vhost-User Bridge application, which can serve the QEMU community as a comprehensive test by running real internet traffic by means of vhost-user inte

Re: [Qemu-devel] [PATCH 2/6] virtio: switch to virtio_map

2015-10-28 Thread Igor Mammedov
On Tue, 27 Oct 2015 10:47:58 +0200 "Michael S. Tsirkin" wrote: > Drop use of the deprecated virtio_map_sg in virtio core. > > Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov > --- > hw/virtio/virtio.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw

Re: [Qemu-devel] [PATCH 3/6] virtio-blk: convert to virtqueue_map

2015-10-28 Thread Igor Mammedov
On Tue, 27 Oct 2015 10:48:01 +0200 "Michael S. Tsirkin" wrote: > Drop deprecated use of virtqueue_map_sg. > > Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov > --- > hw/block/virtio-blk.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/hw/block/virt

Re: [Qemu-devel] [PATCH 5/6] virtio-scsi: convert to virtqueue_map

2015-10-28 Thread Igor Mammedov
On Tue, 27 Oct 2015 10:48:06 +0200 "Michael S. Tsirkin" wrote: > Note: virtqueue_map already validates input > so virtio-scsi does not have to. > > Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov > --- > hw/scsi/virtio-scsi.c | 16 ++-- > 1 file changed, 2 insertions

Re: [Qemu-devel] [PATCH 6/6] virtio: drop virtqueue_map_sg

2015-10-28 Thread Igor Mammedov
On Tue, 27 Oct 2015 10:48:08 +0200 "Michael S. Tsirkin" wrote: > Deprecated in favor of virtqueue_map. > > Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov > --- > include/hw/virtio/virtio.h | 2 -- > hw/virtio/virtio.c | 7 --- > 2 files changed, 9 deletions(-) > >

Re: [Qemu-devel] [PATCH 4/6] virtio-serial: convert to virtio_map

2015-10-28 Thread Igor Mammedov
On Tue, 27 Oct 2015 10:48:03 +0200 "Michael S. Tsirkin" wrote: > This also fixes a minor bug: > -virtqueue_map_sg(port->elem.out_sg, port->elem.out_addr, > - port->elem.out_num, 1); > is wrong: out_sg is not written so should not be marked dirty. >

Re: [Qemu-devel] [PATCH v8 41/54] postcopy_ram.c: place_page and helpers

2015-10-28 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > postcopy_place_page (etc) provide a way for postcopy to place a page > > into guests memory atomically (using the copy ioctl on the ufd). > > > > Signed-off-by: Dr. Davi

Re: [Qemu-devel] [PATCH 1/6] virtio: introduce virtio_map

2015-10-28 Thread Igor Mammedov
On Tue, 27 Oct 2015 10:47:56 +0200 "Michael S. Tsirkin" wrote: > virtio_map_sg currently fails if one of the entries it's mapping is > contigious in GPA but not HVA address space. Introduce virtio_map which > handles this by splitting sg entries. > > This new API generally turns out to be a goo

[Qemu-devel] [PATCH 0/2] Fix the reopening of images in 'block-commit'

2015-10-28 Thread Alberto Garcia
This series fixes a bug in the 'block-commit' operation under the following scenario: [A] <- [B] <- [C] <- [D] If we do block-commit top=B base=A, the contents of [B] will be written into [A] resulting in this chain: [A] <- [C] <- [D] In order to perform this operation, [A] must be reopen

[Qemu-devel] [PATCH 1/2] commit: reopen overlay_bs before base

2015-10-28 Thread Alberto Garcia
'block-commit' needs write access to two different nodes of the chain: - 'base', because that's where the data is written to. - the overlay of 'top', because it needs to update the backing file string to point to 'base' after the operation. Both images have to be opened in read-write mode, and

[Qemu-devel] [PATCH 2/2] qemu-iotests: Test the reopening of overlay_bs in 'block-commit'

2015-10-28 Thread Alberto Garcia
The 'block-commit' command needs the overlay image of 'top' to be opened in read-write mode in order to update the backing file string. If 'top' is not the active layer or its backing file then its overlay needs to be reopened during the block job. This is a test case for that scenario. Signed-of

[Qemu-devel] qemu-2.2 using trace event

2015-10-28 Thread ??????
Hi,here is my problem 1 ./configure --enable-trace-backends=simple make make install echo virtio_notity > /tmp/events echo virtio_queue_notify >> /tmp/events 2 I use a xml file run a virtual machine 3 qemu-system_x86_64 -trace events=/tmp/events 4 ./scripts/simpletrace.py trace

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Consider all child nodes in bdrv_requests_pending()

2015-10-28 Thread Jeff Cody
On Wed, Oct 28, 2015 at 11:46:51AM +0100, Kevin Wolf wrote: > The function manually recursed into bs->file and bs->backing to check > whether there were any requests pending, but it ignored other children. > > There's no need to special case file and backing here, so just replace > these two expli

Re: [Qemu-devel] [PATCH 06/17] qcow: add a 'keyid' parameter to qcow options

2015-10-28 Thread Eric Blake
On 10/19/2015 09:09 AM, Daniel P. Berrange wrote: > Add a 'keyid' parameter that refers to the ID of a > QCryptoSecret instance that provides the encryption key. > eg > > $QEMU \ > -object secret,id=sec0,filename=/home/berrange/encrypted.pw \ > -drive file=/home/berrange/encrypted.qcow,ke

Re: [Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with error_report()

2015-10-28 Thread Andrew Jones
On Tue, Oct 27, 2015 at 08:36:07PM +0100, Laszlo Ersek wrote: > On 10/27/15 20:25, Eduardo Habkost wrote: > > On Tue, Oct 27, 2015 at 08:30:38AM +0100, Andrew Jones wrote: > >> In addition to Markus' and Eric's comments, I think we should > >> > >> 1. make sure the first word's case is correct. Low

Re: [Qemu-devel] [PATCH 07/17] qcow2: add a 'keyid' parameter to qcow2 options

2015-10-28 Thread Eric Blake
On 10/19/2015 05:29 PM, Eric Blake wrote: > On 10/19/2015 09:09 AM, Daniel P. Berrange wrote: >> Add a 'keyid' parameter that refers to the ID of a >> QCryptoSecret instance that provides the encryption key. >> >> $QEMU \ >> -object secret,id=sec0,filename=/home/berrange/encrypted.pw \ >> -

Re: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

2015-10-28 Thread Programmingkid
On Oct 28, 2015, at 6:58 AM, Stefan Hajnoczi wrote: > On Mon, Oct 26, 2015 at 01:24:00PM +0100, Gerd Hoffmann wrote: >>> So this change would make real-time audio feel laggy. >> >> That is secondary if the sound quality is bad due to constant overruns >> and underruns ... > > This is like sweep

Re: [Qemu-devel] [PULL v2 00/27] target-arm queue

2015-10-28 Thread Peter Maydell
On 27 October 2015 at 16:07, Peter Maydell wrote: > Version 2, with a fix for a 32-bit build failure squashed in. > > thanks > -- PMM > > > > The following changes since commit 7e038b94e74e1c2d1b3598e2e4b0b5c8b79a7278: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' int

Re: [Qemu-devel] [PATCH v8 51/54] Postcopy: Mark nohugepage before discard

2015-10-28 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Prior to servicing userfault requests we must ensure we've not got > huge pages in the area that might include non-transferred memory, > since a hugepage could incorrectly mark the whole huge page as present. > > We mark t

[Qemu-devel] [PULL 2/2] target-i386: Enable "check" mode by default

2015-10-28 Thread Eduardo Habkost
Current default behavior of QEMU is to silently disable features that are not supported by the host when a CPU model is requested in the command-line. This means that in addition to risking breaking guest ABI by default, we are silent about it. I would like to enable "enforce" by default, but this

[Qemu-devel] [PULL 1/2] target-i386: Don't left shift negative constant

2015-10-28 Thread Eduardo Habkost
Left shift of negative values is undefined behavior. Detected by clang: qemu/target-i386/translate.c:2423:26: runtime error: left shift of negative value -8 This changes the code to reverse the sign after the left shift. Signed-off-by: Eduardo Habkost --- target-i386/translate.c | 2 +- 1

[Qemu-devel] [PULL 0/2] target-i386: Finally enable "check" mode by default

2015-10-28 Thread Eduardo Habkost
We now have fixed the issues that caused unnecessary warnings in TCG mode and on "make check", and I am applying the check-mode patch again. The following changes since commit 7e038b94e74e1c2d1b3598e2e4b0b5c8b79a7278: Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into s

[Qemu-devel] [PATCH v5 18/33] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region

2015-10-28 Thread Xiao Guangrong
Curretly, the memory region of backed memory is directly mapped to guest's address space, however, it is not true for nvdimm device This patch let dimm device realize this fact and use DIMMDeviceClass->get_memory_region method to get the mapped memory region Signed-off-by: Xiao Guangrong --- hw

[Qemu-devel] [PATCH v5 21/33] nvdimm: implement NVDIMM device abstract

2015-10-28 Thread Xiao Guangrong
Introduce "nvdimm" device which is based on dimm device type 128K memory region which is the minimum namespace label size required by NVDIMM Namespace Spec locates at the end of backend memory device is reserved for label data We can use "-m 1G,maxmem=100G,slots=10 -object memory-backend-file, id

[Qemu-devel] [PATCH v5 09/33] exec: allow file_ram_alloc to work on file

2015-10-28 Thread Xiao Guangrong
Currently, file_ram_alloc() only works on directory - it creates a file under @path and do mmap on it This patch tries to allow it to work on file directly, if @path is a directory it works as before, otherwise it treats @path as the target file then directly allocate memory from it Signed-off-by

[Qemu-devel] [PATCH v5 01/33] acpi: add aml_derefof

2015-10-28 Thread Xiao Guangrong
Implement DeRefOf term which is used by NVDIMM _DSM method in later patch Reviewed-by: Igor Mammedov Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-bu

[Qemu-devel] [PATCH v5 06/33] acpi: add aml_method_serialized

2015-10-28 Thread Xiao Guangrong
It avoid explicit Mutex and will be used by NVDIMM ACPI Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 26 -- include/hw/acpi/aml-build.h | 1 + 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c ind

[Qemu-devel] [PATCH v5 30/33] nvdimm acpi: support Set Namespace Label Data function

2015-10-28 Thread Xiao Guangrong
Function 6 is used to set Namespace Label Data Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 41 + 1 file changed, 41 insertions(+) diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index 5b621ed..5e72ca8 100644 --- a/hw/acpi/nvdimm.c +++ b/hw/acpi/

[Qemu-devel] [PATCH v5 05/33] acpi: add aml_object_type

2015-10-28 Thread Xiao Guangrong
Implement ObjectType which is used by NVDIMM _DSM method in later patch Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index efc06ab..9f792ab 1

[Qemu-devel] [PATCH v5 19/33] dimm: keep the state of the whole backend memory

2015-10-28 Thread Xiao Guangrong
QEMU keeps the state of memory of dimm device during live migration, however, it is not enough for nvdimm device as its memory does not contain its label data, so that we should protect the whole backend memory instead Signed-off-by: Xiao Guangrong --- hw/mem/dimm.c | 14 -- 1 file c

[Qemu-devel] [PATCH v5 26/33] nvdimm acpi: save arg3 for NVDIMM device _DSM method

2015-10-28 Thread Xiao Guangrong
Check if the input Arg3 is valid then store it into dsm_in if needed Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index 8412be3..69de4f6 100644 --- a/hw/acpi/

[Qemu-devel] [PATCH v5 16/33] pc-dimm: rename pc-dimm.c and pc-dimm.h

2015-10-28 Thread Xiao Guangrong
Rename: pc-dimm.c => dimm.c pc-dimm.h => dimm.h It prepares the work which abstracts dimm device type for both pc-dimm and nvdimm Signed-off-by: Xiao Guangrong --- hw/Makefile.objs | 2 +- hw/acpi/ich9.c | 2 +- hw/acpi/memory_hotplug.c

[Qemu-devel] [PATCH v5 14/33] pc-dimm: drop the prefix of pc-dimm

2015-10-28 Thread Xiao Guangrong
This patch is generated by this script: find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type f \ | xargs sed -i "s/PC_DIMM/DIMM/g" find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type f \ | xargs sed -i "s/PCDIMM/DIMM/g" find ./ -name "*.[ch]" -o -name "*.json

[Qemu-devel] [PATCH v5 08/33] exec: allow memory to be allocated from any kind of path

2015-10-28 Thread Xiao Guangrong
Currently file_ram_alloc() is designed for hugetlbfs, however, the memory of nvdimm can come from either raw pmem device eg, /dev/pmem, or the file locates at DAX enabled filesystem So this patch let it work on any kind of path Signed-off-by: Xiao Guangrong --- exec.c | 56 +

[Qemu-devel] [PATCH v5 17/33] dimm: abstract dimm device from pc-dimm

2015-10-28 Thread Xiao Guangrong
A base device, dimm, is abstracted from pc-dimm, so that we can build nvdimm device based on dimm in the later patch Signed-off-by: Xiao Guangrong --- default-configs/i386-softmmu.mak | 1 + default-configs/ppc64-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 + hw/mem/Makefile.

Re: [Qemu-devel] [PATCH v4 17/33] dimm: abstract dimm device from pc-dimm

2015-10-28 Thread Xiao Guangrong
On 10/24/2015 11:20 AM, Bharata B Rao wrote: CONFIG_ACPI_X86_ICH=y +CONFIG_DIMM=y Same change needs to be done in default-configs/ppc64-softmmu.mak too. I have fixed it in v5 which cat be found at: http://marc.info/?l=kvm&m=144604272221080&w=2 Bharata, thank you very much for your re

[Qemu-devel] [PATCH v5 11/33] hostmem-file: use whole file size if possible

2015-10-28 Thread Xiao Guangrong
Use the whole file size if @size is not specified which is useful if we want to directly pass a file to guest Signed-off-by: Xiao Guangrong --- backends/hostmem-file.c | 48 1 file changed, 44 insertions(+), 4 deletions(-) diff --git a/backends/h

[Qemu-devel] [PATCH v5 13/33] pc-dimm: make pc_existing_dimms_capacity static and rename it

2015-10-28 Thread Xiao Guangrong
pc_existing_dimms_capacity() can be static since it is not used out of pc-dimm.c and drop the pc_ prefix to prepare the work which abstracts dimm device type from pc-dimm Signed-off-by: Xiao Guangrong --- hw/mem/pc-dimm.c | 73 include/hw/

[Qemu-devel] [PATCH v5 00/33] implement vNVDIMM

2015-10-28 Thread Xiao Guangrong
This patchset can be found at: https://github.com/xiaogr/qemu.git nvdimm-v5 It is based on pci branch on Michael's tree and the top commit is: commit 04040096 (tests: re-enable vhost-user-test). Changelog in v5: - changes from Michael's comments: 1) prefix nvdimm_ to everything in NVDIMM

  1   2   3   4   >