Eric Blake writes:
> On 10/26/2015 11:07 AM, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>>> We have two issues with our qapi union layout:
>>> 1) Even though the QMP wire format spells the tag 'type', the
>>> C code spells it 'kind', requiring some hacks in the generator.
>>> 2) The C st
Hello!
> adding new user-visible states
> has a tendency to break existing clients that aren't prepared for
> unexpected states (although technically such bugs are in the client - in
> the past, libvirt used to be one such client, although we've tried to
> fix it to gracefully ignore unknown stat
On Tue, Oct 27, 2015 at 02:10:52PM +0800, Yang Hongyang wrote:
> commit e0d03b8ceb52 converted VNC startup to use SocketAddress,
> the interface socket_listen don't have a port_offset param, so
> we need to add the port offset (5900) to both 'port' and 'to' opts.
> currently only 'port' is added by
On Mon, Oct 26, 2015 at 03:13:43PM -0200, Eduardo Habkost wrote:
> This replaces most fprintf(stderr) calls on vl.c with error_report().
>
> The trailing newlines, "qemu:" and "error:" message prefixes were
> removed.
>
> The only remaining fprintf(stderr) calls are the ones at
> qemu_kill_report
On Mon, 26 Oct 2015 21:42:05 +0300
Andrey Korolyov wrote:
> > How about following comment:
> > /* Linux guests expect 512/64/128Mb alignment for PAE/x32/x64 arch
> > * respectively. Windows works fine with 2Mb. To make sure that
> > * memory hotplug would work with above flavors of Linux set
>
On Fri, 23 Oct 2015 14:55:26 +0200
Igor Mammedov wrote:
> currently acpi_memory_plug_cb() sets is_inserting for
> cold- and hot-plugged DIMMs as result ASL MHPD.MSCN()
> method issues device check even for every coldplugged
> DIMM. There isn't much harm in it but if we try to
> unplug such DIMM,
Eric Blake writes:
> A previous patch (commit 1e6c1616) made it possible to
> directly cast from a qapi flat union type to its base type.
> However, it requires the use of a C cast, which turns off
> compiler type-safety checks. Add inline type-safe wrappers
> named qapi_FOO_base() for any union
Eric Blake writes:
> Rather than storing a base class as a pointer to a box, just
> store the fields of that base class in the same order, so that
> a child struct can be directly cast to its parent. This gives
> less malloc overhead, less pointer dereferencing, and even less
> generated code.
Eric Blake writes:
> Now that we have separated union tag values from colliding with
> non-variant C names, by naming the union 'u', we should reserve
> this name for our use. Note that we want to forbid 'u' even in
> a struct with no variants, because it is possible for a future
> qemu release
On Mon, Oct 26, 2015 at 02:24:32PM +0100, Igor Mammedov wrote:
> Yep it's workaround but it works around QEMU's broken virtio
> implementation in a simple way without need for guest side changes.
>
> Without foreseeable virtio fix it makes memory hotplug unusable and even
> more so if there were a
Eric Blake writes:
> We have two issues with our qapi union layout:
> 1) Even though the QMP wire format spells the tag 'type', the
> C code spells it 'kind', requiring some hacks in the generator.
> 2) The C struct uses an anonymous union, which places all tag
> values in the same namespace as a
Eric Blake writes:
> No pending prerequisites (applies to current master)
>
> Also available as a tag at this location:
> git fetch git://repo.or.cz/qemu/ericb.git qapi-cleanupv11b
>
> and I plan to eventually forcefully update my branch with the rest
> of the v5 series, at:
> http://repo.or.cz/q
virtio_map_sg currently fails if one of the entries it's mapping is
contigious in GPA but not HVA address space. Introduce virtio_map which
handles this by splitting sg entries.
This new API generally turns out to be a good idea since it's harder to
misuse: at least in one case the existing one w
TL;DR:
This fixes virtio in a way transparent to guest.
We should now be able to revert commits aa8580cd and df0acded19ec which worked
around it in a way that's not transparent.
-
commit aa8580cd "pc: memhp: force gaps between DIMM's GPA"
introduced gaps in GPA space to work around a bug in v
Note: virtqueue_map already validates input
so virtio-scsi does not have to.
Signed-off-by: Michael S. Tsirkin
---
hw/scsi/virtio-scsi.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
index 1c33f14..33bd25a 1006
Drop deprecated use of virtqueue_map_sg.
Signed-off-by: Michael S. Tsirkin
---
hw/block/virtio-blk.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 8beb26b..3e230de 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virt
This also fixes a minor bug:
-virtqueue_map_sg(port->elem.out_sg, port->elem.out_addr,
- port->elem.out_num, 1);
is wrong: out_sg is not written so should not be marked dirty.
Signed-off-by: Michael S. Tsirkin
---
hw/char/virtio-serial-bus.c | 5 +-
Drop use of the deprecated virtio_map_sg in virtio core.
Signed-off-by: Michael S. Tsirkin
---
hw/virtio/virtio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index a6878c0..84e2320 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/v
Deprecated in favor of virtqueue_map.
Signed-off-by: Michael S. Tsirkin
---
include/hw/virtio/virtio.h | 2 --
hw/virtio/virtio.c | 7 ---
2 files changed, 9 deletions(-)
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index 9d9abb4..205fadf 100644
--- a/include
On Tue, 27 Oct 2015 10:31:21 +0200
"Michael S. Tsirkin" wrote:
> On Mon, Oct 26, 2015 at 02:24:32PM +0100, Igor Mammedov wrote:
> > Yep it's workaround but it works around QEMU's broken virtio
> > implementation in a simple way without need for guest side changes.
> >
> > Without foreseeable vir
On Tue, Oct 27, 2015 at 10:47:54AM +0200, Michael S. Tsirkin wrote:
> TL;DR:
> This fixes virtio in a way transparent to guest.
> We should now be able to revert commits aa8580cd and df0acded19ec which worked
> around it in a way that's not transparent.
Note: I'm clean out of time so this is compi
On Tue, Oct 27, 2015 at 09:48:37AM +0100, Igor Mammedov wrote:
> On Tue, 27 Oct 2015 10:31:21 +0200
> "Michael S. Tsirkin" wrote:
>
> > On Mon, Oct 26, 2015 at 02:24:32PM +0100, Igor Mammedov wrote:
> > > Yep it's workaround but it works around QEMU's broken virtio
> > > implementation in a simpl
On Tue, Oct 27, 2015 at 08:42:31AM +0100, Igor Mammedov wrote:
> On Fri, 23 Oct 2015 14:55:26 +0200
> Igor Mammedov wrote:
>
> > currently acpi_memory_plug_cb() sets is_inserting for
> > cold- and hot-plugged DIMMs as result ASL MHPD.MSCN()
> > method issues device check even for every coldplugge
On Mon 26 Oct 2015 09:39:05 PM CET, Max Reitz wrote:
> +void blk_remove_bs(BlockBackend *blk)
> +{
> +blk_update_root_state(blk);
> +
> +blk->bs->blk = NULL;
> +bdrv_unref(blk->bs);
> +blk->bs = NULL;
> +}
I cannot think of any example out of the blue but I wonder if removing
the
On Mon, Oct 26, 2015 at 04:33:18PM -0200, Eduardo Habkost wrote:
> On Mon, Oct 26, 2015 at 09:42:05AM +0100, Igor Mammedov wrote:
> > commit aa8580cd "pc: memhp: force gaps between DIMM's GPA"
> > regressed memory hot-unplug for linux guests triggering
> > following BUGON
> > =
> > kernel BUG
On Tue, 27 Oct 2015 10:53:08 +0200
"Michael S. Tsirkin" wrote:
> On Tue, Oct 27, 2015 at 09:48:37AM +0100, Igor Mammedov wrote:
> > On Tue, 27 Oct 2015 10:31:21 +0200
> > "Michael S. Tsirkin" wrote:
> >
> > > On Mon, Oct 26, 2015 at 02:24:32PM +0100, Igor Mammedov wrote:
> > > > Yep it's workar
qobject_to_qfloat() and qobject_to_qint() crash on null, which is a
trap for the unwary. Return null instead, and simplify a few callers.
Signed-off-by: Markus Armbruster
Message-Id: <1444918537-18107-5-git-send-email-arm...@redhat.com>
Reviewed-by: Eric Blake
Reviewed-by: Luiz Capitulino
---
qobject_to_qbool() crashes on null, which is a trap for the unwary.
Return null instead, and simplify a few callers.
Signed-off-by: Markus Armbruster
Message-Id: <1444918537-18107-3-git-send-email-arm...@redhat.com>
Reviewed-by: Eric Blake
Reviewed-by: Luiz Capitulino
---
qapi/qmp-input-visito
We don't actually care for the scale, so we can just as well use the
simpler interface.
Signed-off-by: Markus Armbruster
Message-Id: <1444921716-9511-4-git-send-email-arm...@redhat.com>
Reviewed-by: Eric Blake
---
monitor.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --gi
On Mon 26 Oct 2015 09:39:06 PM CET, Max Reitz wrote:
> When inserting a BDS tree into a BB, we will need to add the root BDS to
> this list. Since we will want to do that in the blockdev-insert-medium
> implementation in blockdev.c, we will need access to it there.
>
> This patch is not exactly ele
qobject_to_qlist() crashes on null, which is a trap for the unwary.
Return null instead.
Signed-off-by: Markus Armbruster
Message-Id: <1444918537-18107-6-git-send-email-arm...@redhat.com>
Reviewed-by: Eric Blake
Reviewed-by: Luiz Capitulino
---
qobject/qlist.c | 3 +--
1 file changed, 1 insert
Signed-off-by: Markus Armbruster
Message-Id: <1444921716-9511-8-git-send-email-arm...@redhat.com>
Reviewed-by: Eric Blake
---
docs/qmp-events.txt | 12
docs/qmp-spec.txt | 5 +
2 files changed, 17 insertions(+)
diff --git a/docs/qmp-events.txt b/docs/qmp-events.txt
index d92
The following changes since commit 9666248a85fd889bfb6118f769e9c73039b998ed:
Merge remote-tracking branch 'remotes/sstabellini/tags/xen-2015-10-26' into
staging (2015-10-26 13:13:38 +)
are available in the git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2015-10-27
In preparation of turning monitor_qapi_event_state[] into a hash table
for finer grained throttling.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <1444921716-9511-5-git-send-email-arm...@redhat.com>
---
monitor.c | 80 ++---
QObject_HEAD is a macro expanding into the common part of structs that
are sub-types of QObject. It's always been just QObject base, and
unlikely to change. Drop the macro, because the code is clearer with
out it.
Signed-off-by: Markus Armbruster
Message-Id: <1444918537-18107-2-git-send-email-a
VSERPORT_CHANGE is emitted when the guest opens or closes a
virtio-serial port. The event's member "id" identifies the port.
When several events arrive quickly, throttling drops all but the last
of them. Because of that, a QMP client must assume that *any* port
may have changed state when it rec
qobject_to_qdict() crashes on null, which is a trap for the unwary.
Return null instead, and simplify a few callers.
Signed-off-by: Markus Armbruster
Message-Id: <1444918537-18107-4-git-send-email-arm...@redhat.com>
Reviewed-by: Eric Blake
Reviewed-by: Luiz Capitulino
---
qga/main.c | 11
Make the variables holding the event QDict instead of QObject.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <1444921716-9511-2-git-send-email-arm...@redhat.com>
---
monitor.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
The event throttling state machine is hard to understand. I'm not
sure it's entirely correct. Rewrite it in a more straightforward
manner:
State 1: No event sent recently (less than evconf->rate ns ago)
Invariant: evstate->timer is not pending, evstate->qdict is null
On event: send eve
qobject_to_qstring() crashes on null, which is a trap for the unwary.
Return null instead, and simplify a few callers.
Signed-off-by: Markus Armbruster
Message-Id: <1444918537-18107-7-git-send-email-arm...@redhat.com>
Reviewed-by: Eric Blake
Reviewed-by: Luiz Capitulino
---
qapi/qmp-input-visi
In preparation of finer grained throttling.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <1444921716-9511-6-git-send-email-arm...@redhat.com>
---
monitor.c | 55 ++-
1 file changed, 38 insertions(+), 17 deletions(-)
di
On 27/10/2015 03:04, Fam Zheng wrote:
> > My plan is for
> > 2.6 to have fine-grained critical sections (patches written, will repost
> > during 2.5 hard freeze), 2.7 (unlikely 2.6) to have fine-grained locks,
> > and 2.8 or 2.9 to have multiqueue.
>
> You're talking about virtio-scsi, right? Wh
Ccing the maintainers.
El 23/10/15 a les 17.53, Ed Maste ha escrit:
> Acked-by: Roger Pau Monné
> Signed-off-by: Ed Maste
> ---
> As an aside this was reviewed on FreeBSD's Phabricator here:
> https://reviews.freebsd.org/D3969
>
> Resend with Signed-off-by.
>
> net/tap-bsd.c | 38
Am 19.10.2015 um 20:49 hat Max Reitz geschrieben:
> That field is now only used during initialization of BlockDriverStates
> (opening images) and for error or warning messages. Performance is not
> that much of an issue here, so we can drop the field and replace its use
> by a call to bdrv_filename
hello Michael,
there is still a long story with many personal understanding below,
hope to get directions. If all my understanding are right, I think maybe
I could say: finally I understand your implementation:)
On 10/26/2015 08:14 PM, Michael S. Tsirkin wrote:
On Mon, Oct 26, 2015 at 07:
Am 19.10.2015 um 20:49 hat Max Reitz geschrieben:
> After drive-mirror replacing a Quorum child, the filename of the Quorum
> BDS should reflect the change. This patch replaces the existing test for
> whether the operation did actually exchange the BDS (which simply tested
> whether the new BDS exi
On Tue, Oct 27, 2015 at 05:39:01PM +0800, Cao jin wrote:
> >>>static
> >>>bool pcie_has_upstream_port(PCIDevice *dev)
> >>>{
> >>> PCIDevice *parent_dev = pci_bridge_get_device(pci_dev->bus);
> >>>
> >>> /*
> >>> * Device associated with an upstream port.
> >>> * As there are seve
Andrew Jones writes:
> On Mon, Oct 26, 2015 at 03:13:43PM -0200, Eduardo Habkost wrote:
>> This replaces most fprintf(stderr) calls on vl.c with error_report().
>>
>> The trailing newlines, "qemu:" and "error:" message prefixes were
>> removed.
>>
>> The only remaining fprintf(stderr) calls are
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1481750
Title:
qemu-system-ppc hangs when running -M ppce500 -bios u-boot.e500
Status in QEMU:
Hi; it's been suggested to me that it would be helpful to have a
qemu-arm mailing list, along the lines of the existing qemu-ppc
and qemu-block lists. The idea would be to get people to cc the
list with their ARM related patches, so it would mostly act as
a way for people to filter their mail to se
On 25/10/2015 22:38, Peter Crosthwaite wrote:
On Thu, Oct 22, 2015 at 2:21 AM, Christian Pinto
wrote:
Hello Peter,
On 07/10/2015 17:48, Peter Crosthwaite wrote:
On Mon, Oct 5, 2015 at 8:50 AM, Christian Pinto
wrote:
Hello Peter,
thanks for your comments
On 01/10/2015 18:26, Peter Cro
Hi Michael
Thanks for your quick response
On 10/27/2015 05:47 PM, Michael S. Tsirkin wrote:
On Tue, Oct 27, 2015 at 05:39:01PM +0800, Cao jin wrote:
static
bool pcie_has_upstream_port(PCIDevice *dev)
{
PCIDevice *parent_dev = pci_bridge_get_device(pci_dev->bus);
/*
* Device
Le 27/10/2015 04:09, Laurent Vivier a écrit :
>
>
> Le 26/10/2015 15:40, Peter Maydell a écrit :
>> On 6 October 2015 at 18:11, Laurent Vivier wrote:
>>> This is obsolete, but if we want to use dhcp with some distros (like debian
>>> ppc 8.2 jessie), we need it.
>>>
>>> At the bind level, we a
On Tue, Oct 27, 2015 at 10:15:32AM +, Peter Maydell wrote:
> Hi; it's been suggested to me that it would be helpful to have a
> qemu-arm mailing list, along the lines of the existing qemu-ppc
> and qemu-block lists. The idea would be to get people to cc the
> list with their ARM related patches
Am 27.10.2015 um 00:45 hat John Snow geschrieben:
> cvtnum() returns int64_t: we should not be storing this
> result inside of an int.
>
> In a few cases, we need an extra sprinkling of error handling
> where we expect to pass this number on towards a function that
> expects something smaller than
Am 26.10.2015 um 11:39 schrieb Stefan Hajnoczi:
On Mon, Oct 12, 2015 at 02:27:24PM +0200, Peter Lieven wrote:
this patch adds a new aio readv compatible function which copies
all data through a bounce buffer. The benefit is that these requests
can be flagged as canceled to avoid guest memory cor
This allows to signal migration notifiers that the migration has entered
final phase. The condition is set after vm_stop_force_state().
This will be necessary for ITS live migration on ARM, which will have to
dump its state into guest RAM at this point.
Signed-off-by: Pavel Fedin
---
include/mi
On Tue, Oct 27, 2015 at 10:15:32AM +, Peter Maydell wrote:
> Hi; it's been suggested to me that it would be helpful to have a
> qemu-arm mailing list, along the lines of the existing qemu-ppc
> and qemu-block lists. The idea would be to get people to cc the
> list with their ARM related patches
Am 27.10.2015 um 00:45 hat John Snow geschrieben:
> Reported-by: Max Reitz
> Signed-off-by: John Snow
> Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
On 27 October 2015 at 06:08, Jason Wang wrote:
> The following changes since commit 9666248a85fd889bfb6118f769e9c73039b998ed:
>
> Merge remote-tracking branch 'remotes/sstabellini/tags/xen-2015-10-26' into
> staging (2015-10-26 13:13:38 +)
>
> are available in the git repository at:
>
> h
Am 27.10.2015 um 03:26 hat Eric Blake geschrieben:
> On 10/26/2015 05:45 PM, John Snow wrote:
> > Reported-by: Max Reitz
> > Signed-off-by: John Snow
> > Reviewed-by: Eric Blake
> > ---
> > qemu-io-cmds.c | 53 ++---
> > 1 file changed, 34 inserti
Hello!
> The idea would be to get people to cc the
> list with their ARM related patches, so it would mostly act as
> a way for people to filter their mail to separate the ARM stuff
> out from the qemu-devel firehose.
I also vote for it. The main qemu-devel traffic is quite high, and not
every
Hello!
> > I can further test cases to do more coverage of object proprty handling
> > wrt to classes, if you want me to.
>
> No, if that is sorted out now, I'll drop v2 and need to review v4.
How is it? Any problems / advancements? Could i help somehow?
Kind regards,
Pavel Fedin
Expert Engin
On 27 October 2015 at 11:07, Pavel Fedin wrote:
>> (Everything should still be cc'd to qemu-devel as well.)
>
> I would drop this requirement, except for stuff which could touch
> core functionality (qom, qobject).
This is a standard requirement for all our sub-mailing lists --
not everybody is
Am 27.10.2015 um 00:45 hat John Snow geschrieben:
> Make sure there's not trailing garbage, e.g.
> "64k-whatever-i-want-here"
>
> Reported-by: Max Reitz
> Signed-off-by: John Snow
> Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
On 27 October 2015 at 10:47, Laurent Vivier wrote:
> And for the socketcall part, we need the tswap16():
>
> for instance,
>
> int a = htons(0x0003);
>
> On a LE host:
>
> a = 0x0300
>
> On a BE host:
>
> a = 0x0003
>
> If the guest is BE, it will put in memory:
>
> 0x00 0x
Hi,
> > My hypothesis (which I guess I'm volunteering to verify, unless we
> > end up rejecting this immediately as a bad idea, for some reason that
> > I have missed), is that current functionality wouldn't change, given
> > the way existing callbacks work right now, and that we could run the
>
On 27 October 2015 at 11:35, Peter Maydell wrote:
> Still thinking about the other part of your patch, because
> "does this start with 'eth'" is not very pretty...
...can we use the TargetFdTrans machinery from your signalfd
patch to associate custom sockaddr conversion functions with
a file desc
On Mon, Oct 26, 2015 at 07:19:23PM +0200, Victor Kaplansky wrote:
> The test existing in QEMU for vhost-user feature is good for
> testing the management protocol, but does not allow actual
> traffic. This patch proposes Vhost-User Bridge application, which
> can serve the QEMU community as a compr
Le 27/10/2015 12:39, Peter Maydell a écrit :
> On 27 October 2015 at 11:35, Peter Maydell wrote:
>> Still thinking about the other part of your patch, because
>> "does this start with 'eth'" is not very pretty...
I agree with you, but I didn't find better.
> ...can we use the TargetFdTrans mac
On Tue, Oct 27, 2015 at 10:47:54AM +0200, Michael S. Tsirkin wrote:
> TL;DR:
> This fixes virtio in a way transparent to guest.
> We should now be able to revert commits aa8580cd and df0acded19ec which worked
> around it in a way that's not transparent.
I didn't check dataplane BTW. Igor? Stefan?
On 27 October 2015 at 03:09, Laurent Vivier wrote:
> Le 26/10/2015 15:40, Peter Maydell a écrit :
>> This confuses me. The packet(7) manpage suggests there are two flavours
>> of packet socket:
>> (1) legacy AF_INET + SOCK_PACKET
>> (2) new style AF_PACKET + SOCK_RAW / SOCK_DGRAM
>>
>> but this
On 27 October 2015 at 11:49, Laurent Vivier wrote:
>
>
> Le 27/10/2015 12:39, Peter Maydell a écrit :
>> On 27 October 2015 at 11:35, Peter Maydell wrote:
>>> Still thinking about the other part of your patch, because
>>> "does this start with 'eth'" is not very pretty...
>
> I agree with you, bu
Le 27/10/2015 12:35, Peter Maydell a écrit :
> On 27 October 2015 at 10:47, Laurent Vivier wrote:
>> And for the socketcall part, we need the tswap16():
>>
>> for instance,
>>
>> int a = htons(0x0003);
>>
>> On a LE host:
>>
>> a = 0x0300
>>
>> On a BE host:
>>
>> a = 0x0003
Le 27/10/2015 12:50, Peter Maydell a écrit :
> On 27 October 2015 at 03:09, Laurent Vivier wrote:
>> Le 26/10/2015 15:40, Peter Maydell a écrit :
>>> This confuses me. The packet(7) manpage suggests there are two flavours
>>> of packet socket:
>>> (1) legacy AF_INET + SOCK_PACKET
>>> (2) new s
Le 27/10/2015 12:52, Peter Maydell a écrit :
> On 27 October 2015 at 11:49, Laurent Vivier wrote:
>>
>>
>> Le 27/10/2015 12:39, Peter Maydell a écrit :
>>> On 27 October 2015 at 11:35, Peter Maydell wrote:
Still thinking about the other part of your patch, because
"does this start wit
Hello!
> > include/hw/cpu/arm.h | 308
> > +++
>
> I think this would be hw/arm/cpu.h
Sorry for split-reply, forgot to look at this...
include/hw/arm is for board classes, isn't it?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics
On Tue, 27 Oct 2015 10:47:54 +0200
"Michael S. Tsirkin" wrote:
> TL;DR:
> This fixes virtio in a way transparent to guest.
> We should now be able to revert commits aa8580cd and df0acded19ec which worked
> around it in a way that's not transparent.
(...)
> Michael S. Tsirkin (6):
> virtio: in
Hello!
> We have plenty of precedent in tree for interrupt controllers being
> compiled as arch-specific for reasons such as this. Can we just
> promote GIC to an obj-y (much the same way the KVM GIC or V7MNVIC are
> promoted)? You should them have access to cpu.h and the CP interface.
Huh, ind
HI
Does anyone hit this issue? It seems that the addr 880037071240
isn't correct.
addr 3700711c len 0001 is_write 1
addr 880037071240 len 0010 is_write 0
addr 38599000 len 1000 is_write 0
addr 3700711c len 0001 is_wri
On 25 October 2015 at 23:13, Peter Crosthwaite
wrote:
> Firstly, enable monitor mode and PSCI, both are which are features of
> this board.
>
> In addition to PSCI, this board also uses SMC for cache maintainence
> ops. This means we need a secure monitor to catch these and nop them.
> Use the ARM
On 27/10/2015 13:11, Pavel Fedin wrote:
> +if ((backend->policy != MPOL_DEFAULT) || (errno != ENOSYS)) {
Can you remove parentheses around conditions?
Paolo
> +error_setg_errno(errp, errno,
> "cannot bind memory to host NUMA nodes");
>
---
This will fix the issue reported by Cornelia.
hw/virtio/virtio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index be32145..ed1f274 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -449,7 +449,7 @@ int virtqueue_avail
On 25 October 2015 at 23:13, Peter Crosthwaite
wrote:
> These comment start immediately after the current longest name in the
> list. Tab them out to the next tab stop to give a little breathing room
> and prepare for FIXUP_BOARD_SETUP which will require more indent.
>
> Signed-off-by: Peter Crost
On Tue, 27 Oct 2015 20:13:15 +0800
Zhi Yong Wu wrote:
> HI
>
> Does anyone hit this issue? It seems that the addr 880037071240
> isn't correct.
>
> addr 3700711c len 0001 is_write 1
> addr 880037071240 len 0010 is_write 0
> addr 38599000 len 0
On 25 October 2015 at 23:13, Peter Crosthwaite
wrote:
> Add an API for boards to inject their own preboot software (or
> firmware) seqeuence.
>
> The software then returns to bootloader via the link register. This
> allows boards to do their own little bits of firmware setup without
> needed to re
On 25 October 2015 at 23:13, Peter Crosthwaite
wrote:
> Add a Linux-specific pre-boot routine that matches the device
> specific bootloaders behaviour. This is needed for modern Linux that
> expects the ARM PLL in SLCR to be a more even value (not 26).
>
> Cc: Alistair Francis
> Signed-off-by: Pe
Currently hostmem backend fails if CONFIG_NUMA is enabled for the qemu
(default), but NUMA is not supported by the kernel. This makes it
impossible to use ivshmem in such configurations.
This patch fixes the problem by ignoring ENOSYS error if policy is set to
MPOL_DEFAULT. This way the code behav
HI
Does anyone hit this issue? It seems that the addr 880037071240
isn't correct.
addr 3700711c len 0001 is_write 1
addr 880037071240 len 0010 is_write 0
addr 38599000 len 1000 is_write 0
addr 3700711c len 0001 is_wri
On 10/27/15 12:11, Gerd Hoffmann wrote:
> Hi,
>
>>> My hypothesis (which I guess I'm volunteering to verify, unless we
>>> end up rejecting this immediately as a bad idea, for some reason that
>>> I have missed), is that current functionality wouldn't change, given
>>> the way existing callbacks
In case user want to cancel the hot-add operation, should roll back,
device_del the added function that still don`t work.
Signed-off-by: Cao jin
---
hw/pci/pcie.c | 23 ++-
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 6e28
Support multi-function hot-add of PCIe device via device_add, just ensure
function 0 is added last. While allow user to cancel the hot-add operation
via device_del.
changelog v6:
1. reimplement pci_get_function_0() using mst`s suggestion code
2. modify pcie_cap_slot_hot_unplug_request_cb(), becaus
On Tue, 27 Oct 2015 14:30:05 +0200
"Michael S. Tsirkin" wrote:
> ---
>
> This will fix the issue reported by Cornelia.
>
> hw/virtio/virtio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
> index be32145..ed1f274 100644
> ---
Enable PCIe device multi-function hot-add, just ensure function 0 is added
last, then driver will got the notification to scan the slot.
Signed-off-by: Cao jin
---
hw/pci/pci.c | 40 +++-
hw/pci/pci_host.c| 13 +++--
hw/pci/pcie.c|
Sorry, guys, i forgot to add "v2" and simply sent the mail. Log is:
v1 => v2:
- Removed unnecessary parenthesis
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
> -Original Message-
> From: qemu-devel-bounces+p.fedin=samsung@nongnu.org [mailto:qem
Currently hostmem backend fails if CONFIG_NUMA is enabled for the qemu
(default), but NUMA is not supported by the kernel. This makes it
impossible to use ivshmem in such configurations.
This patch fixes the problem by ignoring ENOSYS error if policy is set to
MPOL_DEFAULT. This way the code behav
This patch adds a way to specify multiple volfile servers to the gluster
block backend of QEMU with tcp|rdma transport types and their port numbers.
Problem:
Currenly VM Image on gluster volume is specified like this:
file=gluster[+tcp]://host[:port]/testvol/a.img
Assuming we have three hosts i
On 27 October 2015 at 09:21, Markus Armbruster wrote:
> The following changes since commit 9666248a85fd889bfb6118f769e9c73039b998ed:
>
> Merge remote-tracking branch 'remotes/sstabellini/tags/xen-2015-10-26' into
> staging (2015-10-26 13:13:38 +)
>
> are available in the git repository at:
From: "Dr. David Alan Gilbert"
A new gdb commands are added:
qemu handlers
That dumps an AioContext list (by default qemu_aio_context)
possibly including a backtrace for cases it knows about
(with the verbose option). Intended to help find why something
is hanging waiting
On 10/27/2015 01:08 AM, Pavel Fedin wrote:
> Hello!
>
>> adding new user-visible states
>> has a tendency to break existing clients that aren't prepared for
>> unexpected states (although technically such bugs are in the client - in
>> the past, libvirt used to be one such client, although we've
1 - 100 of 284 matches
Mail list logo
