Re: [Qemu-devel] [PATCH COLO-Frame v9 10/32] COLO: Add a new RunState RUN_STATE_COLO

On 2015/10/21 20:18, Eric Blake wrote: On 09/02/2015 02:22 AM, zhanghailiang wrote: Guest will enter this state when paused to save/restore VM state under colo checkpoint. Cc: Eric Blake Cc: Markus Armbruster Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Signed-off-by: Gonglei Rev

Re: [Qemu-devel] [PATCH v9 3/3] block/gluster: add support for multiple gluster servers

On Wed, Oct 21, 2015 at 19:04:11 +0530, Prasanna Kumar Kalever wrote: ... > --- > block/gluster.c | 420 > +-- > qapi/block-core.json | 62 +++- > 2 files changed, 433 insertions(+), 49 deletions(-) > > diff --git a/block/gluster.c b/bl

Re: [Qemu-devel] [PATCH COLO-Frame v9 09/32] COLO: Implement colo checkpoint protocol

On 2015/10/21 20:17, Eric Blake wrote: On 09/02/2015 02:22 AM, zhanghailiang wrote: We need communications protocol of user-defined to control the checkpoint process. The new checkpoint request is started by Primary VM, and the interactive process like below: Checkpoint synchronizing points,

Re: [Qemu-devel] [PATCH 2/6] e1000: Trivial implementation of various MAC registers

On 10/21/2015 05:13 PM, Leonid Bloch wrote: > Hi Jason, thanks for the review! > > On Tue, Oct 20, 2015 at 8:40 AM, Jason Wang wrote: >> >> >> On 10/18/2015 03:53 PM, Leonid Bloch wrote: >>> These registers appear in Intel's specs, but were not implemented. >>> These registers are now implemente

Re: [Qemu-devel] [PATCH 4/6] e1000: Fixing the received/transmitted octets' counters

On 10/21/2015 08:20 PM, Leonid Bloch wrote: > On Tue, Oct 20, 2015 at 9:16 AM, Jason Wang wrote: >> > >> > >> > On 10/18/2015 03:53 PM, Leonid Bloch wrote: >>> >> Previously, the lower parts of these counters (TORL, TOTL) were >>> >> resetting after reaching their maximal values, and since the c

Re: [Qemu-devel] [PATCH 0/6] e1000: Various fixes and registers' implementation

On 10/21/2015 09:32 PM, Leonid Bloch wrote: > Hi Jason, thanks again for reviewing, > > On Tue, Oct 20, 2015 at 9:37 AM, Jason Wang > wrote: > > > > > > On 10/18/2015 03:53 PM, Leonid Bloch wrote: > >> This series fixes several issues with incorrect packet/octet > cou

Re: [Qemu-devel] DO_UPCAST confusion

Hi, > > state = DO_UPCAST(InternalSnapshotState, common, common); > > I much prefer the name container_of() (which is a bit more obvious that > it is finding the container or derived type that embeds the parent > type), but if we have to keep the ugly name, could we at least clean up > the

[Qemu-devel] [PATCH qemu 1/2] ppc: Add mmu_model defines for arch 2.03 and 2.07

From: Benjamin Herrenschmidt This removes unused POWERPC_MMU_2_06a/POWERPC_MMU_2_06d. This replaces POWERPC_MMU_64B with POWERPC_MMU_2_03 for POWER5+ to be more explicit about the version of the PowerISA supported. This defines POWERPC_MMU_2_07 and uses it for the POWER8 CPU family. This will n

[Qemu-devel] [PATCH qemu 0/2] ppc: Add "ibm,pa-features"

This adds an "ibm,pa-features" property. Please comment. Thanks. Benjamin Herrenschmidt (2): ppc: Add mmu_model defines for arch 2.03 and 2.07 ppc/spapr: Add "ibm,pa-features" property to the device-tree hw/ppc/spapr.c | 31 +++ target-ppc/cpu.h

[Qemu-devel] [PATCH qemu 2/2] ppc/spapr: Add "ibm, pa-features" property to the device-tree

From: Benjamin Herrenschmidt LoPAPR defines a "ibm,pa-features" per-CPU device tree property which describes extended features of the Processor Architecture. This adds the property to the device tree. At the moment this is the copy of what pHyp advertises except "I=1 (cache inhibited) Large Page

Re: [Qemu-devel] [PATCH qemu v4] monitor/target-ppc: Define target_get_monitor_def

On 10/02/2015 04:16 PM, Alexey Kardashevskiy wrote: At the moment get_monitor_def() returns only registers from statically defined monitor_defs array. However there is a lot of BOOK3S SPRs which are not in the list and cannot be printed from the monitor. This adds a new target platform hook - ta

Re: [Qemu-devel] [PATCH RFC V5 8/9] target-arm/cpu64 GICv3 system instructions support

Hello! > -Original Message- > From: Shlomo Pongratz [mailto:shlomopongr...@gmail.com] > Sent: Tuesday, October 20, 2015 8:22 PM > To: qemu-devel@nongnu.org > Cc: p.fe...@samsung.com; peter.mayd...@linaro.org; eric.au...@linaro.org; > shannon.z...@linaro.org; imamm...@redhat.com; ash...@br

Re: [Qemu-devel] [PATCH 00/40] Patch Round-up for stable 2.4.1, freeze on 2015-10-29

I'm afraid 2d0583f qmp: Fix device-list-properties not to crash for abstract device 2874c65 qdev: Protect device-list-properties against broken devices 55b4efb Revert "qdev: Use qdev_get_device_class() for -device ,help" unmask a bunch of device model bugs, so you need to pick their f

[Qemu-devel] [PATCH v6 1/4] pci: Make use of the devfn property when registering new devices

Without this, the devfn argument to pci_create_*() does not affect the assigned devfn. Needed to support (VF_STRIDE,VF_OFFSET) values other than (1,1) for SR/IOV. Reviewed-by: Marcel Apfelbaum Signed-off-by: Knut Omang --- hw/pci/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[Qemu-devel] [PATCH v6 3/4] pcie: Add some SR/IOV API documentation in docs/pcie_sriov.txt

Add a small intro + minimal documentation for how to implement SR/IOV support for an emulated device. Signed-off-by: Knut Omang --- docs/pcie_sriov.txt | 115 1 file changed, 115 insertions(+) create mode 100644 docs/pcie_sriov.txt diff --gi

[Qemu-devel] [PATCH v6 0/4] pcie: Add support for Single Root I/O Virtualization

This patch set implements generic support for SR/IOV as an extension to the core PCIe functionality, similar to the way other capabilities such as AER is implemented. There is no implementation of any device that provides SR/IOV support included, but I have implemented a test example which can be

[Qemu-devel] [PATCH v6 4/4] pcie: A few minor fixes (type+code simplify)

- Fix comment typo in pcie_cap_slot_write_config - Simplify code in pcie_cap_slot_hot_unplug_request_cb. Signed-off-by: Knut Omang --- hw/pci/pcie.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 774b9ed..ba49c0f 100644 --- a/hw/pci

[Qemu-devel] [PATCH v6 2/4] pcie: Add support for Single Root I/O Virtualization (SR/IOV)

This patch provides the building blocks for creating an SR/IOV PCIe Extended Capability header and register/unregister SR/IOV Virtual Functions. Signed-off-by: Knut Omang --- hw/pci/Makefile.objs| 2 +- hw/pci/pci.c| 95 +++ hw/pci/pcie.c |

Re: [Qemu-devel] [PATCH] pc: allow raising low memory via max-ram-below-4g option

On Thu, 22 Oct 2015 08:49:00 +0200 Gerd Hoffmann wrote: > This patch extends the functionality of the max-ram-below-4g option > to also allow increasing lowmem. While being at it also rework the > lowmem calculation logic and add a longish comment describing how it > works and what the compatibi

[Qemu-devel] [PATCH v3 04/21] util: Infrastructure for computing recent averages

This module computes the average of a set of values within a time window, keeping also track of the minimum and maximum values. In order to produce more accurate results it works internally by creating two time windows of the same period, offsetted by half of that period. Values are accounted on b

[Qemu-devel] [PATCH v3 06/21] block: Add statistics for failed and invalid I/O operations

This patch adds the block_acct_failed() and block_acct_invalid() functions to allow keeping track of failed and invalid I/O operations. The number of failed and invalid operations is exposed in BlockDeviceStats. We don't keep track of the time spent on invalid operations because they are cancelle

[Qemu-devel] [PATCH v3 01/21] xen_disk: Account for flush operations

Currently both BLKIF_OP_WRITE and BLKIF_OP_FLUSH_DISKCACHE are being accounted as write operations. Signed-off-by: Alberto Garcia Reviewed-by: Stefan Hajnoczi --- hw/block/xen_disk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c

[Qemu-devel] [PATCH v3 02/21] ide: Account for write operations correctly

Signed-off-by: Alberto Garcia Reviewed-by: Stefan Hajnoczi --- hw/ide/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 317406d..b559f1b 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -895,7 +895,7 @@ static void ide_sector_write(ID

[Qemu-devel] [PATCH v3 07/21] block: Allow configuring whether to account failed and invalid ops

This patch adds two options, "stats-account-invalid" and "stats-account-failed", that can be used to decide whether invalid and failed I/O operations must be used when collecting statistics for latency and last access time. Signed-off-by: Alberto Garcia Reviewed-by: Stefan Hajnoczi --- block/ac

[Qemu-devel] [PATCH v3 03/21] block: define 'clock_type' for the accounting code

Its value is still QEMU_CLOCK_REALTIME, but having it in a variable will allow us to change its value easily in the future when running in qtest mode. Signed-off-by: Alberto Garcia Reviewed-by: Stefan Hajnoczi --- block/accounting.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) d

[Qemu-devel] [PATCH v3 09/21] block: Add average I/O queue depth to BlockDeviceTimedStats

This patch adds two new fields to BlockDeviceTimedStats that track the average number of pending read and write requests for a block device. The values are calculated for the period of time defined for that interval. Signed-off-by: Alberto Garcia --- block/accounting.c | 12 ++

[Qemu-devel] [PATCH v3 21/21] block: Update copyright of the accounting code

Signed-off-by: Alberto Garcia --- block/accounting.c | 1 + include/block/accounting.h | 1 + 2 files changed, 2 insertions(+) diff --git a/block/accounting.c b/block/accounting.c index 05a5c5f..185025e 100644 --- a/block/accounting.c +++ b/block/accounting.c @@ -2,6 +2,7 @@ * QEMU Sys

[Qemu-devel] [PATCH v3 00/21] Extended I/O accounting

Here's a new version of the extended I/O accounting patches. This one is rebased on top of the current master, has a few minor documentation fixes and drops the 'supports_stats' field completely. Regards, Berto v3: - Rebased on top of the current master and on Max's BlockBackend series v7 - p

[Qemu-devel] [PATCH v3 19/21] macio: Account for failed operations

Signed-off-by: Alberto Garcia --- hw/ide/macio.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/ide/macio.c b/hw/ide/macio.c index 66ac2ba..176e331 100644 --- a/hw/ide/macio.c +++ b/hw/ide/macio.c @@ -286,7 +286,11 @@ static void pmac_ide_atapi_transfer_cb(vo

[Qemu-devel] [PATCH v3 08/21] block: Compute minimum, maximum and average I/O latencies

This patch keeps track of the minimum, maximum and average latencies of I/O operations during a certain interval of time. The values are exposed in the BlockDeviceTimedStats structure. An option to define the intervals to collect these statistics will be added in a separate patch. Signed-off-by:

[Qemu-devel] [PATCH v3 15/21] virtio-blk: Account for failed and invalid operations

Signed-off-by: Alberto Garcia --- hw/block/virtio-blk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 8beb26b..aea9728 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio-blk.c @@ -76,7 +76,7 @@ static int virtio_bl

[Qemu-devel] [PATCH v3 11/21] qemu-io: Account for failed, invalid and flush operations

Signed-off-by: Alberto Garcia --- qemu-io-cmds.c | 9 + 1 file changed, 9 insertions(+) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index 6e5d1e4..0cac623 100644 --- a/qemu-io-cmds.c +++ b/qemu-io-cmds.c @@ -1364,6 +1364,7 @@ static void aio_write_done(void *opaque, int ret) if (

[Qemu-devel] [PATCH v3 05/21] block: Add idle_time_ns to BlockDeviceStats

This patch adds the new field 'idle_time_ns' to the BlockDeviceStats structure, indicating the time that has passed since the previous I/O operation. It also adds the block_acct_idle_time_ns() call, to ensure that all references to the clock type used for accounting are in the same place. This wil

[Qemu-devel] [PATCH v3 12/21] block: Use QEMU_CLOCK_VIRTUAL for the accounting code in qtest mode

This patch switches to QEMU_CLOCK_VIRTUAL for the accounting code in qtest mode, and makes the latency of the operation constant. This way we can perform tests on the accounting code with reproducible results. Signed-off-by: Alberto Garcia --- block/accounting.c | 14 ++ 1 file chang

[Qemu-devel] [PATCH v3 18/21] ide: Account for failed and invalid operations

Signed-off-by: Alberto Garcia --- hw/ide/core.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index b559f1b..dd7e9c5 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -574,7 +574,6 @@ static void ide_sector_read_cb(void *opaque, int r

[Qemu-devel] [PATCH v3 16/21] xen_disk: Account for failed and invalid operations

Signed-off-by: Alberto Garcia --- hw/block/xen_disk.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c index 4869518..02eda6e 100644 --- a/hw/block/xen_disk.c +++ b/hw/block/xen_disk.c @@ -537,7 +537,11 @@ static

[Qemu-devel] [PATCH 0/2] Fix werror=enospc for qcow2 on iscsi

When qcow2 is created on iscsi target with a virtual size greater than physical capacity of the LUN, over time it's possible that guest fills too much data and at that point, new clusters in qcow2 will be allocated beyond the end of disk. werror=enospc is useful for that purpose to allocate more d

[Qemu-devel] [PATCH v3 14/21] nvme: Account for failed and invalid operations

Signed-off-by: Alberto Garcia --- hw/block/nvme.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 5da41b2..169e4fa 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -201,10 +201,11 @@ static void nvme_rw_cb(void *opaque,

[Qemu-devel] [PATCH v3 20/21] scsi-disk: Account for failed operations

Signed-off-by: Alberto Garcia --- hw/scsi/scsi-disk.c | 46 +++--- 1 file changed, 31 insertions(+), 15 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index bada9a7..20a31a7 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@

[Qemu-devel] [PATCH v3 17/21] atapi: Account for failed and invalid operations

Signed-off-by: Alberto Garcia --- hw/ide/atapi.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index 747f466..cf0b78e 100644 --- a/hw/ide/atapi.c +++ b/hw/ide/atapi.c @@ -108,27 +108,30 @@ static void cd_data_

[Qemu-devel] [PATCH 1/2] iscsi: Translate scsi sense into error code

Previously we return -EIO blindly when anything goes wrong. Add a helper function to parse sense fields and try to make the return code more meaningful. Signed-off-by: Fam Zheng --- block/iscsi.c | 56 +++- 1 file changed, 55 insertions(+), 1 d

[Qemu-devel] [PATCH v3 10/21] block: New option to define the intervals for collecting I/O statistics

The BlockAcctStats structure contains a list of BlockAcctTimedStats. Each one of these collects statistics about the minimum, maximum and average latencies of all I/O operations in a certain interval of time. This patch adds a new "stats-intervals" option that allows defining these intervals. Sig

[Qemu-devel] [PATCH 2/2] qcow2: Translate -ERANGE to -ENOSPC

This will make the default werror (=enospc) work better when qcow2 is created on top of iscsi or other block devices. Signed-off-by: Fam Zheng --- block/qcow2.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index bacc4f2..8edf0fe 100644 --- a/block/qcow2

[Qemu-devel] [PATCH v3 13/21] iotests: Add test for the block device statistics

Signed-off-by: Alberto Garcia --- tests/qemu-iotests/136 | 349 + tests/qemu-iotests/136.out | 5 + tests/qemu-iotests/group | 1 + 3 files changed, 355 insertions(+) create mode 100644 tests/qemu-iotests/136 create mode 100644 tests/qemu-io

Re: [Qemu-devel] [PATCH RFC V5 8/9] target-arm/cpu64 GICv3 system instructions support

Hi On Thursday, October 22, 2015, Pavel Fedin wrote: > Hello! > > > -Original Message- > > From: Shlomo Pongratz [mailto:shlomopongr...@gmail.com ] > > Sent: Tuesday, October 20, 2015 8:22 PM > > To: qemu-devel@nongnu.org > > Cc: p.fe...@samsung.com ; peter.mayd...@linaro.org > ; eric.

Re: [Qemu-devel] [PATCH v6 0/4] pcie: Add support for Single Root I/O Virtualization

Michael, I just realized that this now went out without Reviewed-by: Marcel Apfelbaum to patches 2-4, Sorry about that - can you add it for me? Thanks, Knut On Thu, 2015-10-22 at 10:01 +0200, Knut Omang wrote: > This patch set implements generic support for SR/IOV as an extension > to the

Re: [Qemu-devel] [PATCH 1/2] iscsi: Translate scsi sense into error code

Am 22.10.2015 um 10:17 schrieb Fam Zheng: Previously we return -EIO blindly when anything goes wrong. Add a helper function to parse sense fields and try to make the return code more meaningful. Signed-off-by: Fam Zheng --- block/iscsi.c | 56 ++

Re: [Qemu-devel] [PATCH 0/2] Fix werror=enospc for qcow2 on iscsi

Am 22.10.2015 um 10:17 schrieb Fam Zheng: When qcow2 is created on iscsi target with a virtual size greater than physical capacity of the LUN, over time it's possible that guest fills too much data and at that point, new clusters in qcow2 will be allocated beyond the end of disk. Why would you

Re: [Qemu-devel] [PATCH v9 06/17] qapi-visit: Remove redundant functions for flat union base

Eric Blake writes: > On 10/21/2015 11:36 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> The code for visiting the base class of a child struct created >>> visit_type_Base_fields() which covers all fields of Base; while >>> the code for visiting the base class of a flat union created

Re: [Qemu-devel] [PATCH RFC V5 8/9] target-arm/cpu64 GICv3 system instructions support

Hello! > I've implemented the registers accessed by Linux driver in > drivers/irqchip/irq-gic-v3.c > If this register is used only with KVM e.g. virt/kvm/arm/vgic-v3.c than it is > out of my mandate. It has nothing to do with KVM. EFI is a firmware, which originates from Intel, but now adopt

Re: [Qemu-devel] [PATCH] hw/isa/lpc_ich9: inject the SMI on the VCPU that is writing to APM_CNT

On 21/10/2015 20:36, Jordan Justen wrote: > On 2015-10-20 11:14:00, Laszlo Ersek wrote: > > Commit 4d00636e97b7 ("ich9: Add the lpc chip", Nov 14 2012) added the > > ich9_apm_ctrl_changed() ioport write callback function such that it would > > inject the SMI, in response to a write to the APM_CNT

Re: [Qemu-devel] [PATCH 0/2] Fix werror=enospc for qcow2 on iscsi

On 22/10/2015 10:17, Fam Zheng wrote: > When qcow2 is created on iscsi target with a virtual size greater than > physical > capacity of the LUN, over time it's possible that guest fills too much data > and > at that point, new clusters in qcow2 will be allocated beyond the end of disk. > > wer

Re: [Qemu-devel] [PATCH 1/2] iscsi: Translate scsi sense into error code

On 22/10/2015 10:31, Peter Lieven wrote: > > +switch (sense->key) { > +case SCSI_SENSE_NO_SENSE: > +return 0; > +break; > +case SCSI_SENSE_NOT_READY: > +return -EBUSY; > +break; > +case SCSI_SENSE_DATA_PROTECTION: > +return -EACCES; Probab

Re: [Qemu-devel] [PATCH RFC V5 8/9] target-arm/cpu64 GICv3 system instructions support

Hi On Thursday, October 22, 2015, Pavel Fedin wrote: > Hello! > > > I've implemented the registers accessed by Linux driver in > drivers/irqchip/irq-gic-v3.c > > If this register is used only with KVM e.g. virt/kvm/arm/vgic-v3.c than > it is out of my mandate. > > It has nothing to do with KVM

[Qemu-devel] [PATCH] migration: Add state records for migration incoming

For migration destination, sometimes we need to know its state, and it is also useful for tracing migration incoming process. Here we add a new member 'state' for MigrationIncomingState, and also use migrate_set_state() to modify its value. We fix the first parameter of migrate_set_state(), and ma

Re: [Qemu-devel] [PATCH v6 2/4] pcie: Add support for Single Root I/O Virtualization (SR/IOV)

On 10/22/2015 11:51 AM, Dotan Barak wrote: I have minor comments, to use the new helper functions. Hi Dotan, I think is a good idea, however we can do it as a simple patch on top of it if no other issues will be found. Thanks, Marcel Thanks Dotan -Original Message- From: Knut Oma

Re: [Qemu-devel] [PATCH] throttle: Remove throttle_group_lock/unlock()

Am 21.10.2015 um 20:36 hat Alberto Garcia geschrieben: > The group throttling code was always meant to handle its locking > internally. However, bdrv_swap() was touching the ThrottleGroup > structure directly and therefore needed an API for that. > > Now that bdrv_swap() no longer exists there's n

Re: [Qemu-devel] [PATCH 0/2] Fix werror=enospc for qcow2 on iscsi

Am 22.10.2015 um 10:45 hat Paolo Bonzini geschrieben: > On 22/10/2015 10:17, Fam Zheng wrote: > > When qcow2 is created on iscsi target with a virtual size greater than > > physical > > capacity of the LUN, over time it's possible that guest fills too much data > > and > > at that point, new clus

Re: [Qemu-devel] [PATCH COLO-Frame v9 00/32] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

Hi Dave, Thanks for feedback, i have recorded this problem, maybe we can optimize this calling in the future. Thanks, zhanghailiang On 2015/10/21 22:10, Dr. David Alan Gilbert wrote: Hi, Not something I found on this set; but on your older set, where you have the experimental 'live' ram tra

Re: [Qemu-devel] [PATCH 1/2] iscsi: Translate scsi sense into error code

Am 22.10.2015 um 10:17 hat Fam Zheng geschrieben: > Previously we return -EIO blindly when anything goes wrong. Add a helper > function to parse sense fields and try to make the return code more > meaningful. > > Signed-off-by: Fam Zheng > --- > block/iscsi.c | 56 +++

Re: [Qemu-devel] [PATCH 1/2] iscsi: Translate scsi sense into error code

Am 22.10.2015 um 10:45 schrieb Paolo Bonzini: On 22/10/2015 10:31, Peter Lieven wrote: +switch (sense->key) { +case SCSI_SENSE_NO_SENSE: +return 0; +break; Isn't it dangerous to return 0 (no error) if the status is != SCSI_STATUS_GOOD? Peter

Re: [Qemu-devel] [PATCH qemu v4] monitor/target-ppc: Define target_get_monitor_def

On Thu, Oct 22, 2015 at 06:31:56PM +1100, Alexey Kardashevskiy wrote: > On 10/02/2015 04:16 PM, Alexey Kardashevskiy wrote: > >At the moment get_monitor_def() returns only registers from statically > >defined monitor_defs array. However there is a lot of BOOK3S SPRs > >which are not in the list and

Re: [Qemu-devel] [RFC PATCH 0/8] Towards an Heterogeneous QEMU

Hello Peter, On 07/10/2015 17:48, Peter Crosthwaite wrote: On Mon, Oct 5, 2015 at 8:50 AM, Christian Pinto wrote: Hello Peter, thanks for your comments On 01/10/2015 18:26, Peter Crosthwaite wrote: On Tue, Sep 29, 2015 at 6:57 AM, Christian Pinto wrote: Hi all, This RFC patch-series int

Re: [Qemu-devel] [PATCH v2 03/16] sockets: allow port to be NULL when listening on IP address

On Wed, Oct 21, 2015 at 07:52:58PM +0200, Knut Omang wrote: > On Mon, 2015-10-12 at 12:14 +0100, Daniel P. Berrange wrote: > > If the port in the SocketAddress struct is NULL, it can allow > > the kernel to automatically select a free port. This is useful > > in particular in unit tests to avoid a

Re: [Qemu-devel] [PATCH] hw/isa/lpc_ich9: inject the SMI on the VCPU that is writing to APM_CNT

On 10/22/15 10:40, Paolo Bonzini wrote: > > > On 21/10/2015 20:36, Jordan Justen wrote: >> On 2015-10-20 11:14:00, Laszlo Ersek wrote: >>> Commit 4d00636e97b7 ("ich9: Add the lpc chip", Nov 14 2012) added the >>> ich9_apm_ctrl_changed() ioport write callback function such that it would >>> inject

Re: [Qemu-devel] [PATCH 1/2] iscsi: Translate scsi sense into error code

On Thu, 10/22 10:45, Paolo Bonzini wrote: > > > On 22/10/2015 10:31, Peter Lieven wrote: > > > > +switch (sense->key) { > > +case SCSI_SENSE_NO_SENSE: > > +return 0; > > +break; > > +case SCSI_SENSE_NOT_READY: > > +return -EBUSY; > > +break; > > +c

Re: [Qemu-devel] [PATCH] hw/isa/lpc_ich9: inject the SMI on the VCPU that is writing to APM_CNT

On 22/10/2015 11:50, Laszlo Ersek wrote: > ... With the "relaxed" method configured in OVMF, the above change would > make no difference as long as the BSP executes the firmware -- which is > guaranteed before ExitBootServices() --, but it still makes a difference > if later a runtime service is

Re: [Qemu-devel] [PATCH 1/2] iscsi: Translate scsi sense into error code

On 22/10/2015 11:51, Fam Zheng wrote: > > > > > > +switch (sense->key) { > > > +case SCSI_SENSE_NO_SENSE: > > > +return 0; > > > +break; > > > +case SCSI_SENSE_NOT_READY: > > > +return -EBUSY; > > > +break; > > > +case SCSI_SENSE_DATA_PROTECTION: >

Re: [Qemu-devel] DO_UPCAST confusion

On 21 October 2015 at 23:49, Eric Blake wrote: > I much prefer the name container_of() (which is a bit more obvious that > it is finding the container or derived type that embeds the parent > type), but if we have to keep the ugly name, could we at least clean up > the comment to make sense, and f

Re: [Qemu-devel] [PATCH v2 03/16] sockets: allow port to be NULL when listening on IP address

On 22 October 2015 at 10:43, Daniel P. Berrange wrote: > For reasons I don't understand, it appears that even string > fields which are marked as optional get a 'has_XXX' flag, > to distinguish betweeen a NULL string and an unset string. > I struggle to imagine why we need this. It makes sense for

Re: [Qemu-devel] [PATCH RFC V5 8/9] target-arm/cpu64 GICv3 system instructions support

Hello! >> It has nothing to do with KVM. EFI is a firmware, which originates from >> Intel, but now adopted by ARM64 architecture too. You can also run >> it under qemu, if you want to make kind of "full" machine. And it writes >> some value to BPR1, which is indeed ignored by Linux kernel. >

Re: [Qemu-devel] [PATCH 0/2] Fix werror=enospc for qcow2 on iscsi

On Thu, 10/22 10:32, Peter Lieven wrote: > Am 22.10.2015 um 10:17 schrieb Fam Zheng: > >When qcow2 is created on iscsi target with a virtual size greater than > >physical > >capacity of the LUN, over time it's possible that guest fills too much data > >and > >at that point, new clusters in qcow2

Re: [Qemu-devel] [PULL v1 0/4] Misc fixes for crypto code module

On Wed, Oct 21, 2015 at 09:21:05PM +0100, Peter Maydell wrote: > On 21 October 2015 at 11:47, Daniel P. Berrange wrote: > > The following changes since commit ee9dfed242610ecb91418270fd46b875ed56e201: > > > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-input-20151020-1' > > into stag

Re: [Qemu-devel] [PULL 00/04] seccomp branch queue

On Fri, Oct 16, 2015 at 05=12=18PM +0100, Peter Maydell wrote: > On 15 October 2015 at 08:57, Eduardo Otubo > wrote: > > The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10: > > > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-10-12' > > into staging

Re: [Qemu-devel] [PULL 0/5] xtensa queue 2015-10-21

On 21 October 2015 at 19:43, Max Filippov wrote: > Hi Peter, > > please pull my current queue for xtensa. > > The following changes since commit 8bfaa25fce2c22060a17501980943538801056de: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20151021-v2' into > staging (2015-10-21 15:07:42

Re: [Qemu-devel] [PATCH v6 09/12] block: Add "drained begin/end" for internal snapshot

Am 22.10.2015 um 08:32 hat Fam Zheng geschrieben: > This ensures the atomicity of the transaction by avoiding processing of > external requests such as those from ioeventfd. > > state->bs is assigned right after bdrv_drained_begin. Because it was > used as the flag for deletion or not in abort, no

[Qemu-devel] [PULL v2 2/4] crypto: don't let builtin aes crash if no IV is provided

If no IV is provided, then use a default IV of all-zeros instead of crashing. This gives parity with gcrypt and nettle backends. Signed-off-by: Daniel P. Berrange --- crypto/cipher-builtin.c| 14 +- tests/test-crypto-cipher.c | 30 ++ 2 files changed,

[Qemu-devel] [PULL v2 0/4] Misc fixes for crypto code module

fixes-pull-20151022-1 for you to fetch changes up to ae0f478a32b2f3beb84343a5f6b07fa3fabb0811: configure: avoid polluting global CFLAGS with tasn1 flags (2015-10-22 11:12:19 +0100) Merge qcrypto-fixes

[Qemu-devel] [PULL v2 3/4] crypto: add sanity checking of plaintext/ciphertext length

When encrypting/decrypting data, the plaintext/ciphertext buffers are required to be a multiple of the cipher block size. If this is not done, nettle will abort and gcrypt will report an error. To get consistent behaviour add explicit checks upfront for the buffer sizes. Signed-off-by: Daniel P. B

[Qemu-devel] [PULL v2 4/4] configure: avoid polluting global CFLAGS with tasn1 flags

The previous commit commit 9a2fd4347c40321f5cbb4ab4220e759fcbf87d03 Author: Daniel P. Berrange Date: Mon Apr 13 14:01:39 2015 +0100 crypto: add sanity checking of TLS x509 credentials defined new variables $TEST_LIBS and $TEST_CFLAGS and used them in tests/Makefile to augment $LIBS

[Qemu-devel] [PULL v2 1/4] crypto: allow use of nettle/gcrypt to be selected explicitly

Currently the choice of whether to use nettle or gcrypt is made based on what gnutls is linked to. There are times when it is desirable to be able to force build against a specific library. For example, if testing changes to QEMU's crypto code all 3 possible backends need to be checked regardless o

Re: [Qemu-devel] [PATCH] seccomp: loosen library version dependency

On Mon, Oct 19, 2015 at 02=58=51PM -0600, dann frazier wrote: > Drop the libseccomp required version back to 2.1.0, restoring the ability > to build w/ --enable-seccomp on Ubuntu 14.04. > > Commit 4cc47f8b3cc4f32586ba2f7fce1dc267da774a69 tightened the dependency > on libseccomp from version 2.1.0

[Qemu-devel] [PATCH] qapi-schema: mark InetSocketAddress as mandatory again

Revert the qapi-schema.json change done in: commit 0983f5e6af76d5df8c6346cbdfff9d8305fb6da0 Author: Daniel P. Berrange Date: Tue Sep 1 14:46:50 2015 +0100 sockets: allow port to be NULL when listening on IP address Switching "port" from mandatory to optional causes the QAPI code gen

[Qemu-devel] Reminder: we're now in softfreeze

[Apologies for the huge cc list, which is basically "everybody I have accepted a pullreq from this release cycle.] Just a reminder that we're now in softfreeze (ie "no new big features, start the process of cutting down towards only bugfixes going into master"). Hardfreeze will be on the 12th Nove

Re: [Qemu-devel] [PATCH 0/3] Add 'blockdev-del' command

Am 20.10.2015 um 17:02 hat Alberto Garcia geschrieben: > On Mon 19 Oct 2015 05:04:50 PM CEST, Kevin Wolf wrote: > >> > So we seem to have two criteria to distinguish BDSes: > >> > > >> > 1. Does/Doesn't have a BlockBackend on top. > >> >In the future, multiple BlockBackends are possible, too.

Re: [Qemu-devel] [PATCH RFC V5 8/9] target-arm/cpu64 GICv3 system instructions support

Hi, On Thursday, October 22, 2015, Pavel Fedin wrote: > Hello! > > >> It has nothing to do with KVM. EFI is a firmware, which originates from > Intel, but now adopted by ARM64 architecture too. You can also run > >> it under qemu, if you want to make kind of "full" machine. And it > writes some

Re: [Qemu-devel] [PATCH v6 11/12] qed: Implement .bdrv_drain

Am 22.10.2015 um 08:32 hat Fam Zheng geschrieben: > The "need_check_timer" is used to clear the "NEED_CHECK" flag in the > image header after a grace period once metadata update has finished. In > compliance to the bdrv_drain semantics we should make sure it remains > deleted once .bdrv_drain is ca

Re: [Qemu-devel] [PULL v2 0/4] Misc fixes for crypto code module

ble in the git repository at: > > https://github.com/berrange/qemu.git tags/qcrypto-fixes-pull-20151022-1 > > for you to fetch changes up to ae0f478a32b2f3beb84343a5f6b07fa3fabb0811: > > configure: avoid polluting global CFLAGS

Re: [Qemu-devel] [PULL 00/10] collected tcg patches

Hi. I'm going to hold off on processing this pull for a few days in the hope that the gcc compile farm's ppc64be box is working again... thanks -- PMM On 21 October 2015 at 22:42, Richard Henderson wrote: > Backend patches for ppc64 and mipsr6, plus the nochain patch > that's been dangling for a

Re: [Qemu-devel] [PATCH v6 09/12] block: Add "drained begin/end" for internal snapshot

On Thu, Oct 22, 2015 at 12:18:11PM +0200, Kevin Wolf wrote: > Am 22.10.2015 um 08:32 hat Fam Zheng geschrieben: > > This ensures the atomicity of the transaction by avoiding processing of > > external requests such as those from ioeventfd. > > > > state->bs is assigned right after bdrv_drained_beg

Re: [Qemu-devel] [PATCH QEMU-XEN v4 9/9] xen: make it possible to build without the Xen PV domain builder

On Wed, 2015-10-21 at 16:23 +0100, Ian Campbell wrote: > [...] > v4: Fixed all checkpatch errors. > Disabled by default. I botched this and it is no longer possible to turn it on. (I wonder if anyone would have noticed in practice...) > @@ -2113,6 +2117,15 @@ if test "$xen_pci_passthrough" !=

Re: [Qemu-devel] [PATCH 0/3] Add 'blockdev-del' command

On Thu 22 Oct 2015 12:38:24 PM CEST, Kevin Wolf wrote: >> >> > I haven't thought about it enough yet, but it seems to me that we >> >> > can't do the BDS/BB aliasing with blockdev-del, but need to interpret >> >> > node-name as BDS and id as BB. Perhaps we also shouldn't use a single >> >> > 'devi

Re: [Qemu-devel] [PATCH 0/3] Add 'blockdev-del' command

Am 22.10.2015 um 13:08 hat Alberto Garcia geschrieben: > >> I'm currently thinking about d), which tries to maintain the symmetry > >> with blockdev-add: > >> > >> - blockdev-del would have two parameters, 'id' and 'node-name', and only > >> one of them can be set, so you must choose whether you

Re: [Qemu-devel] [PATCH 0/3] Add 'blockdev-del' command

On Thu 22 Oct 2015 01:25:05 PM CEST, Kevin Wolf wrote: >> But there's this case that is not so obvious. It involves the new >> 'blockdev-snapshot' command I'm working on: >> >> - blockdev-add id=drive0 node-name=node0 file=hd0.qcow2 >> - qemu-img create -f qcow2 -b hd0.qcow2 overlay0.qcow2 >>

Re: [Qemu-devel] [PULL 04/38] tests: re-enable vhost-user-test

On Wed, Oct 21, 2015 at 01:26:36PM +0300, Michael S. Tsirkin wrote: > From: Marc-André Lureau > > Commit 7fe34ca9c2e actually disabled vhost-user-test altogether, > since CONFIG_VHOST_NET is a per-target config variable. > > tests/vhost-user-test is already x86/64 softmmu specific test, in order

Re: [Qemu-devel] [PULL 00/38] vhost, pc, virtio features, fixes, cleanups

On Wed, Oct 21, 2015 at 03:06:57PM +0100, Peter Maydell wrote: > On 21 October 2015 at 11:26, Michael S. Tsirkin wrote: > > The following changes since commit 6d57410a79d51d92673c54f26624b44f27fa6214: > > > > Merge remote-tracking branch > > 'remotes/pmaydell/tags/pull-target-arm-20151016' into

Re: [Qemu-devel] [PATCH 0/3] Add 'blockdev-del' command

Am 22.10.2015 um 13:31 hat Alberto Garcia geschrieben: > On Thu 22 Oct 2015 01:25:05 PM CEST, Kevin Wolf wrote: > >> But there's this case that is not so obvious. It involves the new > >> 'blockdev-snapshot' command I'm working on: > >> > >> - blockdev-add id=drive0 node-name=node0 file=hd0.qcow

Re: [Qemu-devel] [PATCH] i386/acpi: add _HID to processor nodes

On Thu, Oct 22, 2015 at 12:38:11PM +0200, Matthias Lange wrote: > Processor nodes created via the acpi/aml framework currently don't > feature a _HID string. This patch appends "ACPI0007" as the _HID > string to each processor node. > > Signed-off-by: Matthias Lange Indeed, it does that. But w

Re: [Qemu-devel] QEMU patch to allow VM introspection via libvmi

Valerio Aimale writes: > On 10/21/15 4:54 AM, Markus Armbruster wrote: >> Valerio Aimale writes: >> >>> On 10/19/15 1:52 AM, Markus Armbruster wrote: Valerio Aimale writes: > On 10/16/15 2:15 AM, Markus Armbruster wrote: >> vale...@aimale.com writes: >> >>> All- >>

[Qemu-devel] [PATCH] exec: avoid unnecessary cacheline bounce on ram_list.mru_block

Whenever the MRU cache hits for the list of RAM blocks, qemu_get_ram_block does an unnecessary write that causes a processor cache line to bounce from one core to another. This causes a performance hit. Reported-by: Emilio G. Cota Signed-off-by: Paolo Bonzini --- exec.c | 2 +- 1 file changed,

  1   2   3   4   >