On Wed, Oct 21, 2015 at 09:21:05PM +0100, Peter Maydell wrote: > On 21 October 2015 at 11:47, Daniel P. Berrange <berra...@redhat.com> wrote: > > The following changes since commit ee9dfed242610ecb91418270fd46b875ed56e201: > > > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-input-20151020-1' > > into staging (2015-10-20 12:56:45 +0100) > > > > are available in the git repository at: > > > > https://github.com/berrange/qemu.git tags/qcrypto-fixes-pull-20151021-1 > > > > for you to fetch changes up to 635b2807565e0724e4aed73f8ca54f14df051499: > > > > configure: avoid polluting global CFLAGS with tasn1 flags (2015-10-21 > > 11:42:42 +0100) > > > > ---------------------------------------------------------------- > > Merge qcrypto-fixes 2015/10/21 > > > > ---------------------------------------------------------------- > > Hi. I'm afraid this fails to build on w32: > > /home/petmay01/linaro/qemu-for-merges/crypto/init.c:30:20: error: > gcrypt.h: No such file or directory > /home/petmay01/linaro/qemu-for-merges/crypto/init.c:108: error: > variable ‘qcrypto_gcrypt_thread_impl’ has initializer but incomplete > type > /home/petmay01/linaro/qemu-for-merges/crypto/init.c:109: error: > ‘GCRY_THREAD_OPTION_PTHREAD’ undeclared here (not in a function) > /home/petmay01/linaro/qemu-for-merges/crypto/init.c:109: error: > ‘GCRY_THREAD_OPTION_VERSION’ undeclared here (not in a function) > > (and then a large pile of other errors that you'd expect from > failing to find gcrypt.h.)
Oh, fun, a pre-existing bug in configure, which we now trigger more often. We look for 'libgcrypt-config' in $PATH, but don't bother to check whether the one we found is for native builds or cross builds. I'll fix configure to run 'libgcrypt-config --host' to make sure we match the cross prefix. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
