Re: [Qemu-devel] [PATCH v4 0/7] qom: more efficient object property handling

2015-10-14 Thread Pavel Fedin
Hello! > This series introduces a concept of object property iterators > to QOM so callers are insulated from the specific data structures > used for storing properties against objects/classes. It then > converts Object to use a GHashTable for storing properties. > Finally it introduces ObjectCla

[Qemu-devel] [PATCH v7 1/1] block/gluster: add support for multiple gluster backup volfile servers

2015-10-14 Thread Prasanna Kumar Kalever
This patch adds a way to specify multiple volfile servers to the gluster block backend of QEMU with tcp|rdma transport types and their port numbers. Problem: Currenly VM Image on gluster volume is specified like this: file=gluster[+tcp]://host[:port]/testvol/a.img Assuming we have three hosts i

Re: [Qemu-devel] [PATCH v8 15/18] qapi: Move duplicate member checks to schema check()

2015-10-14 Thread Markus Armbruster
Eric Blake writes: > On 10/13/2015 02:17 PM, Eric Blake wrote: > > I can take PATCH 01-09,12 into my tree right away, with PATCH 07's two > redundant is_implicit() methods dropped, and PATCH 12's comment touched > up. Okay. >>> >>> Done & pushed to http://repo.or.cz/qemu/arm

Re: [Qemu-devel] [PATCH v8 08/18] qapi: Lazy creation of array types

2015-10-14 Thread Markus Armbruster
Eric Blake writes: > Commit ac88219a had several TODO markers about whether we needed > to automatically create the corresponding array type alongside > any other type. It turns out that most of the time, we don't! > > As part of lazy creation of array types, this patch now assigns > an 'info' t

Re: [Qemu-devel] [PATCH v8 15/18] qapi: Move duplicate member checks to schema check()

2015-10-14 Thread Markus Armbruster
Markus Armbruster writes: > Eric Blake writes: > >> On 10/13/2015 11:13 AM, Markus Armbruster wrote: >> > > I've come to the conclusion that we should get rid of the self-inflicted > pain before we attempt to detect all collisions. Then that sounds like I should try harder

[Qemu-devel] [PATCH v2 2/3] hw/pci: Introduce msi_device_id()

2015-10-14 Thread Pavel Fedin
For GICv3 ITS implementation we are going to use IDs in KVM IRQ routing code. This patch introduces reusable convenient way to obtain it from the device pointer. Since device ID is an architecture-specific thing, the function can be overridden on per-architecture basis. Default stub just returns 0

[Qemu-devel] [PATCH v2 3/3] kvm: Pass PCI device pointer to MSI routing functions

2015-10-14 Thread Pavel Fedin
In-kernel ITS emulation on ARM64 will require to supply device IDs. These IDs can now be retrieved from the device pointer using new msi_device_id() function. This patch adds pci_dev pointer to KVM GSI routing functions and makes callers passing it. x86 architecture does not use device IDs, but h

[Qemu-devel] [PATCH v2 0/3] Make KVM/MSI code device-ID-aware

2015-10-14 Thread Pavel Fedin
On ARM architecture ITS (Interrupt Translation Service), additionally to normal MSI data, uses also side-band device IDs. This series prepares the infrastructure to handling them. This small series is actually an extraction from vITS support RFC (https://lists.gnu.org/archive/html/qemu-devel/2015-

[Qemu-devel] [PATCH v2 1/3] kvm: Make KVM_CAP_SIGNAL_MSI globally available

2015-10-14 Thread Pavel Fedin
This capability is useful to determine whether we can use KVM ITS emulation on ARM Signed-off-by: Pavel Fedin --- include/sysemu/kvm.h | 9 + kvm-all.c| 10 +- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h

Re: [Qemu-devel] [PATCH] gdbstub: Fix buffer overflows in gdb_handle_packet()

2015-10-14 Thread Kevin Wolf
Am 14.10.2015 um 08:53 hat P J P geschrieben: > +-- On Tue, 13 Oct 2015, Kevin Wolf wrote --+ > | diff --git a/gdbstub.c b/gdbstub.c > | index d2c95b5..9c29aa0 100644 > | --- a/gdbstub.c > | +++ b/gdbstub.c > | @@ -956,6 +956,13 @@ static int gdb_handle_packet(GDBState *s, const char > *line_buf)

Re: [Qemu-devel] [PATCH] util/qemu-config: fix missing machine command line options

2015-10-14 Thread Cornelia Huck
On Tue, 13 Oct 2015 16:46:29 +0300 Marcel Apfelbaum wrote: > On 10/13/2015 02:51 PM, Cornelia Huck wrote: > > On Mon, 12 Oct 2015 18:42:04 +0300 > > Marcel Apfelbaum wrote: > > > >> On 10/12/2015 06:36 PM, Tony Krowiak wrote: > >>> Commit 0a7cf217 ("util/qemu-config: fix regression of > >>> qmp_

Re: [Qemu-devel] [PATCH v2 0/3] Make KVM/MSI code device-ID-aware

2015-10-14 Thread Michael S. Tsirkin
On Wed, Oct 14, 2015 at 10:53:14AM +0300, Pavel Fedin wrote: > On ARM architecture ITS (Interrupt Translation Service), additionally to > normal MSI data, uses also side-band device IDs. This series prepares the > infrastructure to handling them. > > This small series is actually an extraction fro

Re: [Qemu-devel] [RFC] Block device size rounding

2015-10-14 Thread Kevin Wolf
Am 13.10.2015 um 17:51 hat John Snow geschrieben: > > > On 10/13/2015 11:30 AM, Peter Crosthwaite wrote: > > On Tue, Oct 13, 2015 at 2:14 AM, Kevin Wolf wrote: > >> Am 12.10.2015 um 20:26 hat John Snow geschrieben: > >>> > >>> > >>> On 10/12/2015 02:09 PM, Peter Crosthwaite wrote: > On Mon,

Re: [Qemu-devel] [PATCH v4 3/5] acpi: pc: add fw_cfg device node to ssdt

2015-10-14 Thread Igor Mammedov
On Tue, 13 Oct 2015 16:10:03 -0300 Eduardo Habkost wrote: > On Sat, Oct 10, 2015 at 12:00:16AM -0400, Gabriel L. Somlo wrote: > > On Thu, Oct 01, 2015 at 01:33:50PM +0200, Igor Mammedov wrote: > > > On Thu, 1 Oct 2015 10:27:15 +0200 > > > Laszlo Ersek wrote: > > > > > > > On 10/01/15 09:02, Igo

Re: [Qemu-devel] [PATCH v2 0/3] Make KVM/MSI code device-ID-aware

2015-10-14 Thread Pavel Fedin
Hello! > I'm confused by pci changes. It's all arm specific stuff leaking > out to pci core. But... How else would you implement it? I tried to do this as abstract as possible. Just pass device pointer to functions which will use it. Or, would you like to override all these functions for ARM

Re: [Qemu-devel] [PATCH] libseccomp: add cacheflush to whitelist

2015-10-14 Thread Eduardo Otubo
On Tue, Sep 29, 2015 at 11=39=46AM +0200, Eduardo Otubo wrote: > On Thu, Sep 24, 2015 at 03=50=04PM +0200, Andrew Jones wrote: > > On Thu, Sep 24, 2015 at 11:31:19AM +0200, Eduardo Otubo wrote: > > > On Wed, Jul 01, 2015 at 09=12=33AM -0400, Andrew Jones wrote: > > > > cacheflush is an arm-specific

Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint

2015-10-14 Thread Sergey Fedorov
On 14.10.2015 01:10, Richard Henderson wrote: > Some targets already had this within their logic, but make sure > it's present for all targets. > > Signed-off-by: Richard Henderson Reported-by: Sergey Fedorov Thanks, Sergey > --- > target-alpha/translate.c | 3 +++ > target-cris/translat

Re: [Qemu-devel] [PATCH] gdbstub: Fix buffer overflows in gdb_handle_packet()

2015-10-14 Thread P J P
+-- On Wed, 14 Oct 2015, Kevin Wolf wrote --+ | > Ie host gdb(1) user would need to | > supply len/2 value to read/write 'len' bytes. | | That's just how the gdb protocol works. Binary data is transferred as a | string of hex digits, with every byte being represented by two digits. | The request

[Qemu-devel] [PATCH] net: don't set native endianness

2015-10-14 Thread Michael S. Tsirkin
commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991 vhost-net: tell tap backend about the vnet endianness makes vhost net always try to set LE - even if that matches the native endian-ness. This makes it fail on older kernels on x86 without TUNSETVNETLE support. To fix, make qemu_set_vnet_le/qemu

Re: [Qemu-devel] [PATCH] net: don't set native endianness

2015-10-14 Thread Marcel Apfelbaum
On 10/14/2015 12:26 PM, Michael S. Tsirkin wrote: commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991 vhost-net: tell tap backend about the vnet endianness makes vhost net always try to set LE - even if that matches the native endian-ness. This makes it fail on older kernels on x86 without TUNS

Re: [Qemu-devel] [PATCH v2] target-arm: Add MDCR_EL2

2015-10-14 Thread Sergey Fedorov
On 13.10.2015 20:27, Peter Maydell wrote: > On 9 October 2015 at 10:43, Sergey Fedorov wrote: >> Signed-off-by: Sergey Fedorov >> --- >> >> Changes in v2: >> * Reset value is simply made zero >> >> target-arm/cpu.h| 1 + >> target-arm/helper.c | 11 +++ >> 2 files changed, 12 inser

[Qemu-devel] [PULL 00/04] seccomp branch queue

2015-10-14 Thread Eduardo Otubo
The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-10-12' into staging (2015-10-13 10:42:06 +0100) are available in the git repository at: git://github.com/otubo/qemu.git tags/pull-seccom

[Qemu-devel] [PULL 02/04] configure: arm/aarch64: allow enable-seccomp

2015-10-14 Thread Eduardo Otubo
From: Andrew Jones This is a revert of ae6e8ef11e6cb, but with a bit of refactoring, and also specifically adding arm/aarch64, rather than all architectures. Currently, libseccomp code appears to also support mips, ppc, and s390. We could therefore allow qemu to enable seccomp for those platforms

[Qemu-devel] [PULL 04/04] Add syscalls for -runas and -chroot to the seccomp sandbox

2015-10-14 Thread Eduardo Otubo
From: Namsun Ch'o The seccomp sandbox doesn't whitelist setuid, setgid, or setgroups, which are needed for -runas to work. It also doesn't whitelist chroot, which is needed for the -chroot option. Unfortunately, QEMU enables seccomp before it drops privileges or chroots, so without these whitelis

[Qemu-devel] [PULL 03/04] Add argument filters to the seccomp sandbox

2015-10-14 Thread Eduardo Otubo
From: Namsun Ch'o Here's the v3 patch. I applied it and compiled QEMU, and it worked fine. Changes so far: v1 - Created argument filters for the madvise, shmget, and shmctl syscalls. v1 -> v2 - Added 5 new madvise flags which were present in the source code but not in the strace which I gen

[Qemu-devel] [PULL 01/04] libseccomp: add cacheflush to whitelist

2015-10-14 Thread Eduardo Otubo
From: Andrew Jones cacheflush is an arm-specific syscall that qemu built for arm uses. Add it to the whitelist. Signed-off-by: Andrew Jones Acked-by: Eduardo Otubo --- qemu-seccomp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qemu-seccomp.c b/qemu-seccomp.c index f9

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-14 Thread Kevin Wolf
[ CC qemu-block ] Am 13.10.2015 um 19:10 hat Stefano Stabellini geschrieben: > On Tue, 13 Oct 2015, John Snow wrote: > > On 10/13/2015 11:55 AM, Fabio Fantoni wrote: > > > I added ahci disk support in libxl and using it for week seems that was > > > ok, after a reply of Stefano Stabellini seems th

Re: [Qemu-devel] [PATCH v2 0/3] Make KVM/MSI code device-ID-aware

2015-10-14 Thread Michael S. Tsirkin
On Wed, Oct 14, 2015 at 11:46:02AM +0300, Pavel Fedin wrote: > Hello! > > > I'm confused by pci changes. It's all arm specific stuff leaking > > out to pci core. > > But... How else would you implement it? I tried to do this as abstract as > possible. Just pass device pointer to functions whi

Re: [Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default

2015-10-14 Thread Cornelia Huck
On Wed, 15 Jul 2015 16:45:52 +0200 Paolo Bonzini wrote: > On 15/07/2015 16:28, Michael S. Tsirkin wrote: > > On Wed, Jul 15, 2015 at 04:18:49PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 15/07/2015 16:14, Michael S. Tsirkin wrote: > >>> On Wed, Jul 15, 2015 at 02:47:24PM +0200, Paolo Bonzini

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-14 Thread Stefano Stabellini
On Wed, 14 Oct 2015, Kevin Wolf wrote: > [ CC qemu-block ] > > Am 13.10.2015 um 19:10 hat Stefano Stabellini geschrieben: > > On Tue, 13 Oct 2015, John Snow wrote: > > > On 10/13/2015 11:55 AM, Fabio Fantoni wrote: > > > > I added ahci disk support in libxl and using it for week seems that was > >

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-14 Thread Fabio Fantoni
Il 14/10/2015 11:47, Kevin Wolf ha scritto: [ CC qemu-block ] Am 13.10.2015 um 19:10 hat Stefano Stabellini geschrieben: On Tue, 13 Oct 2015, John Snow wrote: On 10/13/2015 11:55 AM, Fabio Fantoni wrote: I added ahci disk support in libxl and using it for week seems that was ok, after a rep

Re: [Qemu-devel] [PATCH v4 1/3] pci: Make use of the devfn property when registering new devices

2015-10-14 Thread Knut Omang
On Thu, 2015-09-17 at 15:41 +0300, Marcel Apfelbaum wrote: > On 09/17/2015 03:12 PM, Knut Omang wrote: > > On Thu, 2015-09-17 at 14:11 +0300, Marcel Apfelbaum wrote: > > > On 09/12/2015 03:36 PM, Knut Omang wrote: > > > > Without this, the devfn argument to pci_create_*() > > > > does not affect th

Re: [Qemu-devel] [Xen-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-14 Thread Ian Campbell
On Wed, 2015-10-14 at 12:06 +0100, Stefano Stabellini wrote: > > Can't you just teach SeaBIOS how to deal with your PV disks and then > > only add that to your VM and forget about IDE/AHCI? I mean, that's how > > it's done for virtio-blk, and it doesn't involve any insanities like > > ripping out n

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-14 Thread Kevin Wolf
Am 14.10.2015 um 13:06 hat Stefano Stabellini geschrieben: > On Wed, 14 Oct 2015, Kevin Wolf wrote: > > [ CC qemu-block ] > > > > Am 13.10.2015 um 19:10 hat Stefano Stabellini geschrieben: > > > On Tue, 13 Oct 2015, John Snow wrote: > > > > On 10/13/2015 11:55 AM, Fabio Fantoni wrote: > > > > > I

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-14 Thread Stefano Stabellini
On Wed, 14 Oct 2015, Kevin Wolf wrote: > Am 14.10.2015 um 13:06 hat Stefano Stabellini geschrieben: > > On Wed, 14 Oct 2015, Kevin Wolf wrote: > > > [ CC qemu-block ] > > > > > > Am 13.10.2015 um 19:10 hat Stefano Stabellini geschrieben: > > > > On Tue, 13 Oct 2015, John Snow wrote: > > > > > On 1

Re: [Qemu-devel] [PATCH v2 0/3] Make KVM/MSI code device-ID-aware

2015-10-14 Thread Pavel Fedin
Hello! > OK, so we could rename stream id to requester id. That at least would > make sense at the pci level, and would make it unique per hierarchy. Yes, we can, i'm fine with the rename. Additionally, "requester ID" is the official term used in GICv3 architecture manual. When i implemented i

[Qemu-devel] [PATCH 2/9] s390x/virtio-ccw: fix 2.4 virtio compat

2015-10-14 Thread Cornelia Huck
Commit 542571d5 ("virtio-ccw: enable virtio-1") missed some virtio devices for the 2.4 compat handling. Add them. Fixes: 542571d5 ("virtio-ccw: enable virtio-1") Signed-off-by: Cornelia Huck Reviewed-by: Christian Borntraeger --- hw/s390x/s390-virtio-ccw.c | 12 1 file changed, 12

[Qemu-devel] [PATCH 8/9] s390x: reset crypto only on clear reset and QEMU reset

2015-10-14 Thread Cornelia Huck
From: David Hildenbrand Initializing VM crypto in initial cpu reset has multiple problems 1. We call the exact same function #VCPU times, although one time is enough 2. On SIGP initial cpu reset, we exchange the wrapping key while other VCPUs are running. Bad! 3. It is simply wrong. According

[Qemu-devel] [PATCH 4/9] s390x: flagify mcic values

2015-10-14 Thread Cornelia Huck
Instead of using magic values when building the machine check interruption code, add some defines as by chapter 11-14 in the PoP. This should make it easier to catch problems like the missing vector register validity bit ("s390x/kvm: Fix vector validity bit in device machine checks"), and less has

[Qemu-devel] [PATCH 7/9] s390x: machine reset function with new ipl cpu handling

2015-10-14 Thread Cornelia Huck
From: David Hildenbrand Current implementation depends on the order of resets getting triggered. If a cpu reset is triggered after the ipl device reset, the CPU is stopped and the VM will not run. In fact, that hinders us from converting the ipl device into a TYPE_DEVICE. Let's change that by ma

[Qemu-devel] [PATCH 1/9] util/qemu-config: fix missing machine command line options

2015-10-14 Thread Cornelia Huck
From: Tony Krowiak Commit 0a7cf217 ("util/qemu-config: fix regression of qmp_query_command_line_options") aimed to restore parsing of global machine options, but missed two: "aes-key-wrap" and "dea-key-wrap" (which were present in the initial version of that patch). Let's add them to the machine_

[Qemu-devel] [PATCH 9/9] s390x/cmma: clean up cmma reset

2015-10-14 Thread Cornelia Huck
From: David Hildenbrand The cmma reset is per VM, so we don't need a cpu object. We can directly make use of kvm_state, as it is already available when the reset is called. By moving the cmma reset in our machine reset function, we can avoid a manual reset handler. Acked-by: Christian Borntraege

[Qemu-devel] [PATCH 0/9] Next set of s390x patches

2015-10-14 Thread Cornelia Huck
More s390x patches. The first ones are fixes: A regression, missed compat and a missed part of the SIMD support. The others contain optimizations and cleanup. Christian Borntraeger (1): s390x/kvm: Fix vector validity bit in device machine checks Cornelia Huck (2): s390x/virtio-ccw: fix 2.4 vi

[Qemu-devel] [PATCH 6/9] s390x/ipl: we always have an ipl device

2015-10-14 Thread Cornelia Huck
From: David Hildenbrand Both s390 machines unconditionally create an ipl device, so no need to handle the missing case. Now we can also change s390_ipl_update_diag308() to return void. Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger Signed-off-by: David Hildenbrand Signed-off-by:

[Qemu-devel] [PATCH 3/9] s390x/kvm: Fix vector validity bit in device machine checks

2015-10-14 Thread Cornelia Huck
From: Christian Borntraeger Device hotplugs trigger a crw machine check. All machine checks have validity bits for certain register types. With vector support we also have to claim that vector registers are valid. This is a band-aid suitable for stable. Long term we should create the full mcic v

[Qemu-devel] [PATCH 5/9] s390x: unify device reset during subsystem_reset()

2015-10-14 Thread Cornelia Huck
From: David Hildenbrand We have to manually reset several devices that are not on a bus: Let's collect them in an array. Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger Signed-off-by: David Hildenbrand Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw.c | 31 +

Re: [Qemu-devel] [PATCH v2 0/3] Make KVM/MSI code device-ID-aware

2015-10-14 Thread Michael S. Tsirkin
On Wed, Oct 14, 2015 at 02:49:14PM +0300, Pavel Fedin wrote: > Hello! > > > OK, so we could rename stream id to requester id. That at least would > > make sense at the pci level, and would make it unique per hierarchy. > > Yes, we can, i'm fine with the rename. Additionally, "requester ID" is t

[Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

2015-10-14 Thread Amit Shah
We were announcing the dest host's IP as our new IP a bit too soon -- if there were errors detected after this announcement was done, the migration is failed and the VM could continue running on the src host -- causing problems later. Move around the qemu_announce_self() call so it's done just bef

Re: [Qemu-devel] [PATCH] target-arm: Use common CPU cycle infrastructure

2015-10-14 Thread Christopher Covington
On 10/13/2015 04:53 PM, Peter Maydell wrote: > On 24 September 2015 at 20:43, Christopher Covington > wrote: >> cpu_get_ticks() provides a common interface across targets for >> calculating CPU cycles. Using this fixes PMCCNTR reads when -icount >> is specified (previously a non-increasing value

Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

2015-10-14 Thread Michael S. Tsirkin
On Wed, Oct 14, 2015 at 05:37:19PM +0530, Amit Shah wrote: > We were announcing the dest host's IP as our new IP a bit too soon -- if > there were errors detected after this announcement was done, the > migration is failed and the VM could continue running on the src host -- > causing problems late

Re: [Qemu-devel] [PATCH v4 3/3] pcie: Add support for Single Root I/O Virtualization (SR/IOV)

2015-10-14 Thread Knut Omang
On Thu, 2015-09-17 at 16:10 +0200, Knut Omang wrote: > On Thu, 2015-09-17 at 14:49 +0300, Marcel Apfelbaum wrote: > > On 09/12/2015 03:36 PM, Knut Omang wrote: > > > This patch provides the building blocks for creating an SR/IOV > > > PCIe Extended Capability header and register/unregister > > > SR

Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

2015-10-14 Thread Dr. David Alan Gilbert
* Amit Shah (amit.s...@redhat.com) wrote: > We were announcing the dest host's IP as our new IP a bit too soon -- if > there were errors detected after this announcement was done, the > migration is failed and the VM could continue running on the src host -- > causing problems later. > > Move arou

Re: [Qemu-devel] [PATCH] libseccomp: add cacheflush to whitelist

2015-10-14 Thread Andrew Jones
On Wed, Oct 14, 2015 at 11:03:37AM +0200, Eduardo Otubo wrote: > On Tue, Sep 29, 2015 at 11=39=46AM +0200, Eduardo Otubo wrote: > > On Thu, Sep 24, 2015 at 03=50=04PM +0200, Andrew Jones wrote: > > > On Thu, Sep 24, 2015 at 11:31:19AM +0200, Eduardo Otubo wrote: > > > > On Wed, Jul 01, 2015 at 09=1

Re: [Qemu-devel] [PATCH v3 3/9] target-arm: Add support for S2 page-table protection bits

2015-10-14 Thread Alex Bennée
Peter Maydell writes: > On 7 October 2015 at 17:19, Alex Bennée wrote: >> >> Edgar E. Iglesias writes: >> >>> From: "Edgar E. Iglesias" >>> >>> Signed-off-by: Edgar E. Iglesias >>> --- >>> target-arm/helper.c | 41 + >>> 1 file changed, 37 insertions(

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-14 Thread Paul Durrant
> -Original Message- > From: Fabio Fantoni [mailto:fabio.fant...@m2r.biz] > Sent: 14 October 2015 12:12 > To: Kevin Wolf; Stefano Stabellini > Cc: John Snow; Anthony Perard; qemu-devel@nongnu.org; xen- > de...@lists.xen.org; qemu-bl...@nongnu.org; Paul Durrant > Subject: Re: [Qemu-devel] Qu

Re: [Qemu-devel] [PATCH v8 08/18] qapi: Lazy creation of array types

2015-10-14 Thread Eric Blake
On 10/14/2015 01:15 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Commit ac88219a had several TODO markers about whether we needed >> to automatically create the corresponding array type alongside >> any other type. It turns out that most of the time, we don't! >> >> As part of lazy cre

[Qemu-devel] [PATCH v3 2/3] hw/pci: Introduce msi_requester_id()

2015-10-14 Thread Pavel Fedin
For GICv3 ITS implementation we are going to use requester IDs in KVM IRQ routing code. This patch introduces reusable convenient way to obtain this ID from the device pointer. Since requester ID is an architecture-specific thing, the function can be overridden on per-architecture basis. Default s

Re: [Qemu-devel] [PATCH v8 15/18] qapi: Move duplicate member checks to schema check()

2015-10-14 Thread Eric Blake
On 10/14/2015 01:32 AM, Markus Armbruster wrote: >> Done & pushed to http://repo.or.cz/qemu/armbru.git branch qapi-next. > > Redone & pushed. > > Summary of tweaks: > * PATCH 01-06.5: unchanged > * PATCH 07: your fixup to drop is_implicit() squashed in > * PATCH 08: array info plumbing moved to

[Qemu-devel] [PATCH v3 3/3] kvm: Pass PCI device pointer to MSI routing functions

2015-10-14 Thread Pavel Fedin
In-kernel ITS emulation on ARM64 will require to supply requester IDs. These IDs can now be retrieved from the device pointer using new msi_requester_id() function. This patch adds pci_dev pointer to KVM GSI routing functions and makes callers passing it. x86 architecture does not use requester I

[Qemu-devel] [PATCH v3 0/3] Make KVM/MSI code device-ID-aware

2015-10-14 Thread Pavel Fedin
On ARM architecture ITS (Interrupt Translation Service), additionally to normal MSI data, uses also side-band device IDs. This series prepares the infrastructure to handling them. This small series is actually an extraction from vITS support RFC (https://lists.gnu.org/archive/html/qemu-devel/2015-

Re: [Qemu-devel] [PATCH v3 5/9] target-arm: Add ARMMMUFaultInfo

2015-10-14 Thread Alex Bennée
Edgar E. Iglesias writes: > On Wed, Oct 07, 2015 at 05:24:27PM +0100, Alex Bennée wrote: >> >> Edgar E. Iglesias writes: >> >> > From: "Edgar E. Iglesias" >> > >> > Introduce ARMMMUFaultInfo to propagate MMU Fault information >> > across the MMU translation code path. This is in preparation

[Qemu-devel] [PATCH v3 1/3] kvm: Make KVM_CAP_SIGNAL_MSI globally available

2015-10-14 Thread Pavel Fedin
This capability is useful to determine whether we can use KVM ITS emulation on ARM Signed-off-by: Pavel Fedin --- include/sysemu/kvm.h | 9 + kvm-all.c| 10 +- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h

Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

2015-10-14 Thread Amit Shah
On (Wed) 14 Oct 2015 [13:38:30], Dr. David Alan Gilbert wrote: > * Amit Shah (amit.s...@redhat.com) wrote: > > We were announcing the dest host's IP as our new IP a bit too soon -- if > > there were errors detected after this announcement was done, the > > migration is failed and the VM could conti

[Qemu-devel] [PATCH 3/3] block: use bdrv_lookup_bs() over blk_by_name() for BDS only results

2015-10-14 Thread Jeff Cody
To find a BlockDriverState interface, it can be done via blk_by_name(), bdrv_find_node(), and bdrv_lookup_bs(). The latter can take the place of the other two, in the instances where we are only concerned with the BlockDriverState. In much of the usage of blk_by_name(), we can simplify the code b

[Qemu-devel] [PATCH 0/3] Prefer bdrv_lookup_bs() to find BDS nodes

2015-10-14 Thread Jeff Cody
This series is on top of Alberto's "Add 'blockdev-snapshot' command" series BlockBackend devices and BlockDriverState node-names occupy the same namespace. In addition, there are two methods that can be used in different circumstances to look up a BlockDriverState: blk_by_name() and bdrv_find_nod

[Qemu-devel] [PATCH 2/3] block: make bdrv_find_node() static

2015-10-14 Thread Jeff Cody
This patch does two things: it moves bdrv_find_node() up before the first usage in block.c, and it makes the function static so that it is only internal to block.c. Signed-off-by: Jeff Cody --- block.c | 30 +++--- include/block/block.h | 1 - 2 files chang

[Qemu-devel] [PATCH 1/3] block: Use bdrv_lookup_bs() instead of bdrv_find_node()

2015-10-14 Thread Jeff Cody
This is a precursor to making bdrv_find_node() static, and internal to block.c To find a BlockDriverState interface, it can be done via blk_by_name(), bdrv_find_node(), and bdrv_lookup_bs(). The latter can take the place of the other two, in the instances where we are only concerned with the Bloc

Re: [Qemu-devel] [RFC PATCH] qapi: Rename simple union's generated tag member to type

2015-10-14 Thread Eric Blake
On 10/08/2015 06:26 AM, Markus Armbruster wrote: > Struct and union type members are generally named alike in QMP and C, > except for a simple union's implicit tag member, which is "type" in > QMP, and "kind" in C. Can't change QMP, so rename it in C. > > Since the implicit enumeration type is st

Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

2015-10-14 Thread Juan Quintela
Amit Shah wrote: > We were announcing the dest host's IP as our new IP a bit too soon -- if > there were errors detected after this announcement was done, the > migration is failed and the VM could continue running on the src host -- > causing problems later. > > Move around the qemu_announce_self

Re: [Qemu-devel] [PATCH v8 15/18] qapi: Move duplicate member checks to schema check()

2015-10-14 Thread Markus Armbruster
Eric Blake writes: > On 10/14/2015 01:32 AM, Markus Armbruster wrote: > >>> Done & pushed to http://repo.or.cz/qemu/armbru.git branch qapi-next. >> >> Redone & pushed. >> >> Summary of tweaks: >> * PATCH 01-06.5: unchanged >> * PATCH 07: your fixup to drop is_implicit() squashed in >> * PATCH 0

Re: [Qemu-devel] [PATCH v6 24/39] blockdev: Do not create BDS for empty drive

2015-10-14 Thread Kevin Wolf
Am 12.10.2015 um 22:00 hat Max Reitz geschrieben: > Do not use "rudimentary" BDSs for empty drives any longer (for > freshly created drives). > > After a follow-up patch, empty drives will generally use a NULL BDS, not > only the freshly created drives. > > Signed-off-by: Max Reitz > --- > bloc

Re: [Qemu-devel] [PATCH] libseccomp: add cacheflush to whitelist

2015-10-14 Thread Markus Armbruster
Andrew Jones writes: > On Wed, Oct 14, 2015 at 11:03:37AM +0200, Eduardo Otubo wrote: >> On Tue, Sep 29, 2015 at 11=39=46AM +0200, Eduardo Otubo wrote: >> > On Thu, Sep 24, 2015 at 03=50=04PM +0200, Andrew Jones wrote: >> > > On Thu, Sep 24, 2015 at 11:31:19AM +0200, Eduardo Otubo wrote: >> > > >

[Qemu-devel] [RFC 0/3] improve/fix -curses mode

2015-10-14 Thread OGAWA Hirofumi
Hi, This patchset is to improve/fix -curses mode. But this patchset is tested only on linux, so RFC. (BTW, tested with xterm/gnome-terminal on linux) ui/curses: Fix monitor color with -curses when 256 colors ui/curses: Support line graphics chars on -curses mode ui/curses: Fix pageup/

[Qemu-devel] [PATCH 3/3] ui/curses: Fix pageup/pagedown on -curses

2015-10-14 Thread OGAWA Hirofumi
Current KEY_NPAGE/KEY_PPAGE handling is broken on -curses. Those uses "GREY", but "KEY_MASK" masked out "GREY". To fix, we have to use correct mask value - SCANCODE_KEYMASK. Then, this adds support of "shift + pageup/pagedown". With this, -curses mode can use scroll-up/down as usual like other di

[Qemu-devel] [PATCH 1/3] ui/curses: Fix monitor color with -curses when 256 colors

2015-10-14 Thread OGAWA Hirofumi
If TERM=xterm-256color, COLOR_PAIRS==256 and monitor passes chtype like 0x74xx. Then, the code uses uninitialized color pair. As result, monitor uses black for both of fg and bg color, i.e. terminal is filled by black. To fix, this initialize above than 64 with default color (fg=white,bg=black).

[Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode

2015-10-14 Thread OGAWA Hirofumi
This converts vga code to curses code in console_write_bh(). With this changes, we can see line graphics (for example, dialog uses) correctly. Signed-off-by: OGAWA Hirofumi --- include/ui/console.h | 11 ++- ui/curses.c | 42 ++ 2 fi

Re: [Qemu-devel] [PATCH v3 2/3] hw/pci: Introduce msi_requester_id()

2015-10-14 Thread Michael S. Tsirkin
On Wed, Oct 14, 2015 at 03:59:58PM +0300, Pavel Fedin wrote: > For GICv3 ITS implementation we are going to use requester IDs in KVM IRQ > routing code. This patch introduces reusable convenient way to obtain this > ID from the device pointer. > > Since requester ID is an architecture-specific thi

Re: [Qemu-devel] [RFC] scsi-disk: add -device scsi-disk, slow=on property

2015-10-14 Thread Stefan Hajnoczi
On Tue, Oct 13, 2015 at 05:31:27PM +0300, Denis V. Lunev wrote: > On 10/13/2015 05:10 PM, Stefan Hajnoczi wrote: > >The 'slow' bool property simulates an 8 second delay in responding to > >simple SCSI commands that do not transfer data. > > > >This means non-READ/WRITE commands will take 8 seconds

Re: [Qemu-devel] [PATCH v3 27/32] nvdimm: support DSM_CMD_IMPLEMENTED function

2015-10-14 Thread Stefan Hajnoczi
On Sun, Oct 11, 2015 at 11:52:59AM +0800, Xiao Guangrong wrote: > static void dsm_write(void *opaque, hwaddr addr, >uint64_t val, unsigned size) > { > +NVDIMMState *state = opaque; > +MemoryRegion *dsm_ram_mr; > +dsm_in *in; > +dsm_out *out; > +uint32_t

Re: [Qemu-devel] [PATCH] Revert "blockdev: add note that block_job_cb() must be thread-safe"

2015-10-14 Thread Stefan Hajnoczi
On Tue, Oct 13, 2015 at 06:16:15PM +0800, Fam Zheng wrote: > This reverts commit 723c5d93c51bdb3adbc238ce90195c0864aa6cd5. > > block_job_cb is called by block_job_completed, which is always called in > a main loop bottom half in existing block jobs. So we don't need to > worry about thread-safety

Re: [Qemu-devel] [PATCH] net: don't set native endianness

2015-10-14 Thread Greg Kurz
On Wed, 14 Oct 2015 12:26:58 +0300 "Michael S. Tsirkin" wrote: > commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991 > vhost-net: tell tap backend about the vnet endianness > makes vhost net always try to set LE - even if that matches the > native endian-ness. > > This makes it fail on older ker

Re: [Qemu-devel] [PULL 14/15] vhost-user-test: use tmpfs by default

2015-10-14 Thread Marc-André Lureau
Hi On Tue, Oct 6, 2015 at 1:17 AM, Michael S. Tsirkin wrote: > On Mon, Oct 05, 2015 at 11:39:39PM +0100, Peter Maydell wrote: >> On 2 October 2015 at 14:45, Michael S. Tsirkin wrote: >> > Most people don't run make check by default, so they skip vhost-user >> > unit tests. Solve this by using t

[Qemu-devel] [Bug 1465935] Please test proposed package

2015-10-14 Thread Chris J Arges
Hello Li, or anyone else affected, Accepted qemu into vivid-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/qemu/1:2.2+dfsg- 5expubuntu9.6 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://w

[Qemu-devel] [Bug 1465935] Re: kvm_irqchip_commit_routes: Assertion `ret == 0' failed

2015-10-14 Thread Chris J Arges
Hello Li, or anyone else affected, Accepted qemu into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/qemu/2.0.0+dfsg- 2ubuntu1.20 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wi

Re: [Qemu-devel] [PATCH] net: don't set native endianness

2015-10-14 Thread Michael S. Tsirkin
On Wed, Oct 14, 2015 at 03:54:32PM +0200, Greg Kurz wrote: > On Wed, 14 Oct 2015 12:26:58 +0300 > "Michael S. Tsirkin" wrote: > > > commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991 > > vhost-net: tell tap backend about the vnet endianness > > makes vhost net always try to set LE - even if that

Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode

2015-10-14 Thread Eric Blake
[meta-comment] On 10/14/2015 05:37 AM, OGAWA Hirofumi wrote: > This converts vga code to curses code in console_write_bh(). > You sent your message with deep threading, with each message a reply to the previous, resulting in: 0/3 + 1/3 + 2/3 + 3/3 and when someone replies, a mail client

Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

2015-10-14 Thread Michael S. Tsirkin
On Wed, Oct 14, 2015 at 03:21:15PM +0200, Juan Quintela wrote: > Amit Shah wrote: > > We were announcing the dest host's IP as our new IP a bit too soon -- if > > there were errors detected after this announcement was done, the > > migration is failed and the VM could continue running on the src h

Re: [Qemu-devel] [Qemu-block] [PATCH v10 02/10] Backup: clear all bitmap when doing block checkpoint

2015-10-14 Thread Stefan Hajnoczi
On Tue, Oct 13, 2015 at 05:13:14PM +0800, Wen Congyang wrote: > On 10/12/2015 09:45 PM, Stefan Hajnoczi wrote: > > On Fri, Sep 25, 2015 at 02:17:30PM +0800, Wen Congyang wrote: > >> Signed-off-by: Wen Congyang > >> Signed-off-by: zhanghailiang > >> Signed-off-by: Gonglei > >> Reviewed-by: Jeff C

Re: [Qemu-devel] [PATCH v3 27/32] nvdimm: support DSM_CMD_IMPLEMENTED function

2015-10-14 Thread Stefan Hajnoczi
On Sun, Oct 11, 2015 at 11:52:59AM +0800, Xiao Guangrong wrote: > +out->len = sizeof(out->status); out->len is uint16_t, it needs cpu_to_le16(). There may be other instances in this patch series.

Re: [Qemu-devel] [PATCH v4] fw_cfg: insert string blobs via qemu cmdline

2015-10-14 Thread Laszlo Ersek
Paolo, On 09/29/15 18:29, Gabriel L. Somlo wrote: > Allow users to provide custom fw_cfg blobs with ascii string > payloads specified directly on the qemu command line. > > Suggested-by: Jordan Justen > Suggested-by: Laszlo Ersek > Signed-off-by: Gabriel Somlo > Reviewd-by: Laszlo Ersek > ---

Re: [Qemu-devel] [Qemu-block] [PATCH v10 08/10] Implement new driver for block replication

2015-10-14 Thread Stefan Hajnoczi
On Tue, Oct 13, 2015 at 05:08:17PM +0800, Wen Congyang wrote: > On 10/13/2015 12:27 AM, Stefan Hajnoczi wrote: > > On Fri, Sep 25, 2015 at 02:17:36PM +0800, Wen Congyang wrote: > >> +/* start backup job now */ > >> +bdrv_op_unblock(s->hidden_disk, BLOCK_OP_TYPE_BACKUP_TARGET, > >> +

Re: [Qemu-devel] [PATCH v3 27/32] nvdimm: support DSM_CMD_IMPLEMENTED function

2015-10-14 Thread Xiao Guangrong
On 10/14/2015 05:40 PM, Stefan Hajnoczi wrote: On Sun, Oct 11, 2015 at 11:52:59AM +0800, Xiao Guangrong wrote: static void dsm_write(void *opaque, hwaddr addr, uint64_t val, unsigned size) { +NVDIMMState *state = opaque; +MemoryRegion *dsm_ram_mr; +dsm_i

Re: [Qemu-devel] [PATCH] libseccomp: add cacheflush to whitelist

2015-10-14 Thread Eduardo Otubo
On Wed, Oct 14, 2015 at 03=25=00PM +0200, Markus Armbruster wrote: > Andrew Jones writes: > > > On Wed, Oct 14, 2015 at 11:03:37AM +0200, Eduardo Otubo wrote: > >> On Tue, Sep 29, 2015 at 11=39=46AM +0200, Eduardo Otubo wrote: > >> > On Thu, Sep 24, 2015 at 03=50=04PM +0200, Andrew Jones wrote: >

Re: [Qemu-devel] [PATCH v3 27/32] nvdimm: support DSM_CMD_IMPLEMENTED function

2015-10-14 Thread Xiao Guangrong
On 10/14/2015 05:41 PM, Stefan Hajnoczi wrote: On Sun, Oct 11, 2015 at 11:52:59AM +0800, Xiao Guangrong wrote: +out->len = sizeof(out->status); out->len is uint16_t, it needs cpu_to_le16(). There may be other instances in this patch series. out->len is internally used only which is i

Re: [Qemu-devel] [PATCH] net: don't set native endianness

2015-10-14 Thread Greg Kurz
On Wed, 14 Oct 2015 17:02:28 +0300 "Michael S. Tsirkin" wrote: > On Wed, Oct 14, 2015 at 03:54:32PM +0200, Greg Kurz wrote: > > On Wed, 14 Oct 2015 12:26:58 +0300 > > "Michael S. Tsirkin" wrote: > > > > > commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991 > > > vhost-net: tell tap backend abou

Re: [Qemu-devel] [PATCH v6 23/39] block: Prepare for NULL BDS

2015-10-14 Thread Max Reitz
On 13.10.2015 17:37, Kevin Wolf wrote: > Am 12.10.2015 um 22:00 hat Max Reitz geschrieben: >> blk_bs() will not necessarily return a non-NULL value any more (unless >> blk_is_available() is true or it can be assumed to otherwise, e.g. >> because it is called immediately after a successful blk_new_w

[Qemu-devel] [PATCH v4 0/3] Make KVM/MSI code device-ID-aware

2015-10-14 Thread Pavel Fedin
On ARM architecture ITS (Interrupt Translation Service), additionally to normal MSI data, uses also side-band device IDs. This series prepares the infrastructure to handling them. This small series is actually an extraction from vITS support RFC (https://lists.gnu.org/archive/html/qemu-devel/2015-

[Qemu-devel] [PATCH v4 2/3] hw/pci: Introduce pci_requester_id()

2015-10-14 Thread Pavel Fedin
For GICv3 ITS implementation we are going to use requester IDs in KVM IRQ routing code. This patch introduces reusable convenient way to obtain this ID from the device pointer. Since requester ID is an architecture-specific thing, the function can be overridden on per-architecture basis. Default s

[Qemu-devel] [PULL v4 00/52] Ivshmem patches

2015-10-14 Thread Marc-André Lureau
The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-10-12' into staging (2015-10-13 10:42:06 +0100) are available in the git repository at: https://github.com/elmarco/qemu tags/ivshmem-pull-request for

[Qemu-devel] [PATCH v4 3/3] kvm: Pass PCI device pointer to MSI routing functions

2015-10-14 Thread Pavel Fedin
In-kernel ITS emulation on ARM64 will require to supply requester IDs. These IDs can now be retrieved from the device pointer using new pci_requester_id() function. This patch adds pci_dev pointer to KVM GSI routing functions and makes callers passing it. x86 architecture does not use requester I

  1   2   3   >