Markus Armbruster <arm...@redhat.com> writes:
> Eric Blake <ebl...@redhat.com> writes:
>
>> On 10/13/2015 11:13 AM, Markus Armbruster wrote:
>>
>>>>>
>>>>> I've come to the conclusion that we should get rid of the self-inflicted
>>>>> pain before we attempt to detect all collisions.
>>>>
>>>> Then that sounds like I should try harder to get the kind/type naming,
>>>> the boxed base naming, and even the anonymous union naming all hoisted
>>>> into this subset, and spin a v9?
>>>
>>> I can take PATCH 01-09,12 into my tree right away, with PATCH 07's two
>>> redundant is_implicit() methods dropped, and PATCH 12's comment touched
>>> up.
>>
>> Okay.
>
> Done & pushed to http://repo.or.cz/qemu/armbru.git branch qapi-next.
Redone & pushed.
Summary of tweaks:
* PATCH 01-06.5: unchanged
* PATCH 07: your fixup to drop is_implicit() squashed in
* PATCH 08: array info plumbing moved to PATCH 12
* PATCH 09: trivially rebased
* PATCH 12: revert your fixup, so we get the move we want, adjust commit
message accordingly, supply missing QAPISchemaArrayType.is_implicit()
The end result is the same except for
diff --git a/scripts/qapi.py b/scripts/qapi.py
index dad381d..8a12b91 100644
--- a/scripts/qapi.py
+++ b/scripts/qapi.py
@@ -939,6 +939,9 @@ class QAPISchemaArrayType(QAPISchemaType):
self.element_type = schema.lookup_type(self._element_type_name)
assert self.element_type
+ def is_implicit(self):
+ return True
+
def json_type(self):
return 'array'
[...]
