On 7 October 2015 at 14:05, Andreas Färber wrote:
> my "make test" patch (which Peter keeps refusing to apply for two
> releases now)
For what it's worth, I am not currently aware of a patch from
you that I am refusing to apply. There's a lot of traffic on
the list, and it's very easy for things
On Wed, Sep 30, 2015 at 2:15 PM, Peter Crosthwaite
wrote:
> On Tue, Sep 29, 2015 at 4:03 PM, Alistair Francis
> wrote:
>> Connect the Xilinx SPI device to the ZynqMP model.
>>
>> Signed-off-by: Alistair Francis
>> ---
>>
>> hw/arm/xlnx-zynqmp.c | 46
>> +
On 07/10/2015 14:31, Andreas Färber wrote:
> It is non-technical and called plagiarism.
I don't think the text
g_strdup_printf("-device ivshmem,shm=%s,size=1M",
(yes, even the final argument differs between your version and
Marc-André) counts as plagiarism.
> The common denominator is that
On 7 October 2015 at 17:19, Alex Bennée wrote:
>
> Edgar E. Iglesias writes:
>
>> From: "Edgar E. Iglesias"
>>
>> Signed-off-by: Edgar E. Iglesias
>> ---
>> target-arm/helper.c | 41 +
>> 1 file changed, 37 insertions(+), 4 deletions(-)
>>
>> diff --git
On 7 October 2015 at 17:32, Nutan Shinde wrote:
> Signed-off-by: Nutan Shinde
> ---
> hw/audio/adlib.c | 9 ++---
> hw/audio/es1370.c | 17 ++---
> hw/audio/gus.c| 9 ++---
> hw/audio/sb16.c | 15 +--
> 4 files changed, 15 insertions(+), 35 deletions(-)
>
On Wed, Oct 7, 2015 at 2:34 PM, Alistair Francis
wrote:
> Connect the sst25wf080 SPI flash to the EP108 board.
>
> Signed-off-by: Alistair Francis
> ---
> V2:
> - Use sst25wf080 instead of m25p80
>
> hw/arm/xlnx-ep108.c | 20
> 1 file changed, 20 insertions(+)
>
> diff --gi
On 10/08/2015 08:13 AM, Peter Maydell wrote:
On 7 October 2015 at 10:57, Richard Henderson wrote:
On 10/02/2015 12:29 AM, Peter Maydell wrote:
+cpu->cpu_ases = g_new0(CPUAddressSpace, 1);
+cpu->cpu_ases[0].cpu = cpu;
+cpu->cpu_ases[0].as = as;
+cpu->cpu_ases[0].tcg_as_listener
Commit d88f5fd and friends first introduced the various test-qmp-*
tests in 2011, with duplicated hand-rolled TestStruct machinery,
to make sure the qapi visitor interface was tested. Later, commit
4f193e3 in 2013 added a .json file for further testing use by the
files, but without consolidating a
Pending prerequisite: Markus' qapi-next branch (which has my
subset A patches):
git://repo.or.cz/qemu/armbru.git qapi-next
http://thread.gmane.org/gmane.comp.emulators.qemu/365827/focus=366351
as well as my subset B patches (currently at v7):
http://article.gmane.org/gmane.comp.emulators.qemu/36681
qapi-schema-test was already testing that we could have a
command returning int, but burned a command name in the whitelist.
Merge the redundant positive test returns-int, and pick a name
that reduces the whitelist size.
Signed-off-by: Eric Blake
---
v6: new patch; could be hoisted earlier along
Prepare to simplify alternate layout by creating a dedicated
subclass for the generated tag type. QMP does not transmit
the tag name, so we can name it whatever we want in C. But
since the tag is closely tied to a qtype_code, this commit
renames the tag from 'kind' to 'type', so the next commit c
Our generated list visitors have the same problem as has been
mentioned elsewhere (see commit 2f52e20): they allocate data
even on failure. An upcoming patch will correct things to
provide saner guarantees, but first we need to expose the
behavior in the testsuite to ensure we aren't introducing an
Make valgrind happy with the current state of the tests, so that
it is easier to see if future patches introduce new memory problems
without being drowned in noise. Many of the leaks were due to
calling a second init without tearing down the data from an earlier
visit. But since teardown is alrea
Previously, working with alternates required two enums, and
some indirection: for type Foo, we created Foo_qtypes[] which
maps each qtype to a member of FooKind_lookup[], then use
FooKind_lookup[] like we do for other union types.
This has a subtle bug: since the values of FooKind_lookup
start at
Sorting the values of an enum makes it easier to look up whether
a particular value is present by binary rather than linear search
(probably most visible with QKeyCode, which has grown over
several releases). Additionally, QMP clients need not know which
C value is associated with an enum name, so
As of commit 8c3f8e77, we test compilation of forward references
for a struct base type (UserDefOne), flat union base type
(UserDefUnionBase), and flat union branch type
(UserDefFlatUnion2). The only remaining forward reference being
tested for parsing in flat-union-reverse-define was a forward
enu
Rather than just asserting that we can parse an empty enum,
let's also make sure we can compile it, by including it in
qapi-schema-test.
Signed-off-by: Eric Blake
---
v6: new patch; could be hoisted earlier alongside subset B v7 3/14
---
tests/Makefile | 1 -
tests/qapi
For the sake of humans reading introspection output, it is nice
to have the name of implicit array types be recognizable as
arrays of the underlying type. However, while this patch allows
humans to skip from a command with return type "[123]" straight
to the definition of type "123" without having
Our testsuite had no coverage of empty arrays, nor of what
happens when the input does not match the expected type.
Useful to have, especially if we start changing the visitor
contracts.
Signed-off-by: Eric Blake
---
v6: new patch
---
tests/test-qmp-input-visitor.c | 51
By using &error_abort, we can avoid a local err variable in
situations where we expect success.
By moving err into data, we can let test teardown take care
of cleaning up any collected error (and allowing for fewer
lines of code between repeated tests where init runs teardown
on our behalf).
Sign
On 10/07/2015 10:12 PM, Alberto Garcia wrote:
> On Tue 22 Sep 2015 09:44:20 AM CEST, Wen Congyang wrote:
>
>> +++ b/block/quorum.c
>> @@ -66,6 +66,9 @@ typedef struct QuorumVotes {
>> typedef struct BDRVQuorumState {
>> BlockDriverState **bs; /* children BlockDriverStates */
>> int num_
On 10/08/2015 02:33 AM, Max Reitz wrote:
> On 22.09.2015 09:44, Wen Congyang wrote:
>> In some cases, we want to take a quorum child offline, and take
>> another child online.
>>
>> Signed-off-by: Wen Congyang
>> Signed-off-by: zhanghailiang
>> Signed-off-by: Gonglei
>> Reviewed-by: Eric Blake
Commit cbc95538 removed unused start_handle() and end_handle(),
but forgot got remove their declarations.
Commit 4e27e819 introduced optional visitor callbacks for all
sorts of int types, but except for type_uint64 and type_size,
none of them have ever been supplied (the generic implementation
bas
On 10/07/2015 09:35 PM, Alberto Garcia wrote:
> On Tue 22 Sep 2015 09:44:19 AM CEST, Wen Congyang
> wrote:
>> In some cases, we want to take a quorum child offline, and take
>> another child online.
>>
>> Signed-off-by: Wen Congyang
>> Signed-off-by: zhanghailiang
>> Signed-off-by: Gonglei
>>
The QMP input visitor allows integral values to be assigned by
promotion to a QTYPE_QFLOAT. However, when parsing an alternate,
we did not take this into account, such that an alternate that
accepts 'number' but not 'int' would reject integral values.
With this patch, we now have the following de
None of the visitor callbacks would set an error when testing
if an optional field was present; make this part of the interface
contract by eliminating the errp argument. Then, for less code,
reflect the determined boolean value back to the caller instead
of making the caller read the boolean afte
On 10/08/2015 03:00 AM, Dr. David Alan Gilbert wrote:
> * Wen Congyang (we...@cn.fujitsu.com) wrote:
>> In some cases, we want to take a quorum child offline, and take
>> another child online.
>
> Hi,
> Have you checked the output of 'info block' after adding/deleting a child?
> I'm using one of
On Sat, Oct 03, 2015 at 07:33:16PM +0300, Michael S. Tsirkin wrote:
> On Fri, Oct 02, 2015 at 06:18:51PM +0200, Paolo Bonzini wrote:
> >
> >
> > On 24/09/2015 15:20, Michael S. Tsirkin wrote:
> > > From: Yuanhan Liu
> > >
> > > Quote from Michael:
> > >
> > > We really should rename VHOST_
Hello,
On Sun, Oct 4, 2015 at 12:38 AM, Edgar E. Iglesias
wrote:
> From: "Edgar E. Iglesias"
>
> Signed-off-by: Edgar E. Iglesias
> ---
> target-arm/cpu.h| 1 +
> target-arm/helper.c | 12
> 2 files changed, 13 insertions(+)
>
> diff --git a/target-arm/cpu.h b/target-arm/cpu.
Max Reitz writes:
> On 22.09.2015 09:44, Wen Congyang wrote:
>> The new QMP command name is x-blockdev-child-add, and x-blockdev-child-del.
>> It justs for adding/removing quorum's child now, and don't support all
>> kinds of children,
>
> It does support all kinds of children for quorum, doesn't
On 2015/10/3 0:02, Eric Blake wrote:
On 09/02/2015 02:22 AM, zhanghailiang wrote:
We add helper function colo_supported() to indicate whether
colo is supported or not, with which we use to control whether or not
showing 'colo' string to users, they can use qmp command
'query-migrate-capabilities
On 2015/10/3 2:45, Dr. David Alan Gilbert wrote:
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
We can know if VM in destination should go into COLO mode by refer to
the info that been migrated from PVM.
We skip this section if colo is not enabled (i.e.
migrate_set_capability colo off)
201 - 232 of 232 matches
Mail list logo
