Re: [Qemu-devel] [Qemu-block] [PATCH] throttle: test that snapshots move the throttling configuration

2015-09-21 Thread Alberto Garcia
On Fri 18 Sep 2015 05:54:36 PM CEST, Max Reitz wrote: >> create mode 100644 tests/qemu-iotests/096 >> create mode 100644 tests/qemu-iotests/096.out > > Looks good, I'd just like to throw in that 096 is in use by my > looks-dead-but-actually-is-not and > only-waiting-for-the-blockbackend-and-med

Re: [Qemu-devel] [PATCH v18 00/21] Deterministic replay core

2015-09-21 Thread Pavel Dovgaluk
Hi! Paolo, have you reviewed these patches? Pavel Dovgalyuk > -Original Message- > From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispras.ru] > Sent: Thursday, September 17, 2015 7:23 PM > To: qemu-devel@nongnu.org > Cc: edgar.igles...@xilinx.com; peter.mayd...@linaro.org; > igor.rubi...@g

Re: [Qemu-devel] [PATCH v4 09/22] vhost: use a function for each call

2015-09-21 Thread Thibaut Collet
On Sat, Sep 19, 2015 at 12:12 PM, wrote: > From: Marc-André Lureau > > Replace the generic vhost_call() by specific functions for each > function call to help with type safety and changing arguments. > > Signed-off-by: Marc-André Lureau > --- > hw/net/vhost_net.c| 12 +- > hw/

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-09-21 Thread Peter Lieven
Am 07.09.2015 um 21:14 schrieb Paolo Bonzini: On 07/09/2015 21:11, Peter Lieven wrote: It helps, but I have a small issue when my backport of the patch is applied. I launch qemu witch a cmdline like this to probe for enforcable CPU types. echo quit | qemu -enable-kvm -monitor stdio -nodefault

Re: [Qemu-devel] [PATCH v5 14/38] block: Remove wr_highest_sector from BlockAcctStats

2015-09-21 Thread Kevin Wolf
Am 18.09.2015 um 18:59 hat Eric Blake geschrieben: > On 09/18/2015 09:22 AM, Max Reitz wrote: > > BlockAcctStats contains statistics about the data transferred from and > > to the device; wr_highest_sector does not fit in with the rest. > > > > Furthermore, those statistics are supposed to be spec

Re: [Qemu-devel] [PATCH v4] ppc/spapr: Implement H_RANDOM hypercall in QEMU

2015-09-21 Thread Greg Kurz
On Mon, 21 Sep 2015 12:10:00 +1000 David Gibson wrote: > On Fri, Sep 18, 2015 at 11:05:52AM +0200, Greg Kurz wrote: > > On Thu, 17 Sep 2015 10:49:41 +0200 > > Thomas Huth wrote: > > > > > The PAPR interface defines a hypercall to pass high-quality > > > hardware generated random numbers to gues

[Qemu-devel] [PULL 04/26] qapi: New QAPISchemaVisitor

2015-09-21 Thread Markus Armbruster
The visitor will help keeping the code generation code simple and reasonably separated from QAPISchema details. Signed-off-by: Markus Armbruster Message-Id: <1442401589-24189-5-git-send-email-arm...@redhat.com> Reviewed-by: Daniel P. Berrange Reviewed-by: Eric Blake --- scripts/qapi.py | 64 ++

[Qemu-devel] [PULL 01/26] qapi: Rename class QAPISchema to QAPISchemaParser

2015-09-21 Thread Markus Armbruster
I want to name a new class QAPISchema. While there, make it a new-style class. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange Message-Id: <1442401589-24189-2-git-send-email-arm...@redhat.com> --- scripts/qapi.py | 8 1 file changed, 4 inserti

[Qemu-devel] [PULL 03/26] qapi: QAPISchema code generation helper methods

2015-09-21 Thread Markus Armbruster
New methods c_name(), c_type(), c_null(), json_type(), alternate_qtype(). Signed-off-by: Markus Armbruster Message-Id: <1442401589-24189-4-git-send-email-arm...@redhat.com> Reviewed-by: Daniel P. Berrange Reviewed-by: Eric Blake --- scripts/qapi.py | 94

[Qemu-devel] [PULL 00/26] qapi: QMP introspection

2015-09-21 Thread Markus Armbruster
The following changes since commit 18640989a9f5e4d2e84b566c52ff1fccfa0dbf4a: Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-peter' into staging (2015-09-19 15:59:52 +0100) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2015-09-21

[Qemu-devel] [PULL 12/26] qapi: Replace dirty is_c_ptr() by method c_null()

2015-09-21 Thread Markus Armbruster
is_c_ptr() looks whether the end of the C text for the type looks like a pointer. Works, but is fragile. We now have a better tool: use QAPISchemaType method c_null(). The initializers for non-pointers become prettier: 0, false or the enumeration constant with the value 0 instead of {0}. Signed

[Qemu-devel] [PULL 08/26] qapi-commands: Convert to QAPISchemaVisitor

2015-09-21 Thread Markus Armbruster
Output unchanged apart from reordering and white-space. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <1442401589-24189-9-git-send-email-arm...@redhat.com> Reviewed-by: Daniel P. Berrange --- scripts/qapi-commands.py | 159 +++

[Qemu-devel] [PULL 09/26] qapi: De-duplicate enum code generation

2015-09-21 Thread Markus Armbruster
Duplicated in commit 21cd70d. Yes, we can't import qapi-types, but that's no excuse. Move the helpers from qapi-types.py to qapi.py, and replace the duplicates in qapi-event.py. The generated event enumeration type's lookup table becomes const-correct (see commit 2e4450f), and uses explicit inde

[Qemu-devel] [PULL 05/26] tests/qapi-schema: Convert test harness to QAPISchemaVisitor

2015-09-21 Thread Markus Armbruster
The old code prints the result of parsing (list of expression dictionaries), and partial results of semantic analysis (list of enum dictionaries, list of struct dictionaries). The new code prints a trace of a schema visit, i.e. what the back-ends are going to use. Built-in and array types are omi

[Qemu-devel] [PULL 14/26] qapi-visit: Rearrange code a bit

2015-09-21 Thread Markus Armbruster
Move gen_visit_decl() to a better place. Inline generate_visit_struct_body(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange Message-Id: <1442401589-24189-15-git-send-email-arm...@redhat.com> --- scripts/qapi-visit.py | 50

[Qemu-devel] [PULL 10/26] qapi-event: Eliminate global variable event_enum_value

2015-09-21 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange Message-Id: <1442401589-24189-11-git-send-email-arm...@redhat.com> --- scripts/qapi-event.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/qapi-event.py b/scripts/qapi-event.

[Qemu-devel] [PULL 11/26] qapi-event: Convert to QAPISchemaVisitor, fixing data with base

2015-09-21 Thread Markus Armbruster
Fixes events whose data is struct with base to include the struct's base members. Test case is qapi-schema-test.json's event __org.qemu_x-command: { 'event': '__ORG.QEMU_X-EVENT', 'data': '__org.qemu_x-Struct' } { 'struct': '__org.qemu_x-Struct', 'base': '__org.qemu_x-Base', 'data'

[Qemu-devel] [PULL 26/26] qapi-introspect: Hide type names

2015-09-21 Thread Markus Armbruster
To eliminate the temptation for clients to look up types by name (which are not ABI), replace all type names by meaningless strings. Reduces output of query-schema by 13 out of 85KiB. As a debugging aid, provide option -u to suppress the hiding. Signed-off-by: Markus Armbruster Reviewed-by: Eri

[Qemu-devel] [PULL 20/26] qapi: Make output visitor return qnull() instead of NULL

2015-09-21 Thread Markus Armbruster
Before commit 1d10b44, it crashed. Since then, it returns NULL, with a FIXME comment. The FIXME is valid: code that assumes QObject * can't be null exists. I'm not aware of a way to feed this problematic return value to code that actually chokes on null in the current code, but the next few comm

[Qemu-devel] [PULL 23/26] qapi-schema: Fix up misleading specification of netdev_add

2015-09-21 Thread Markus Armbruster
It doesn't take a 'props' argument, let alone one in the format "NAME=VALUE,..." The bogus arguments specification doesn't matter due to 'gen': false. Clean it up to be incomplete rather than wrong, and document the incompleteness. While there, improve netdev_add usage example in the manual: add

[Qemu-devel] [PULL 02/26] qapi: New QAPISchema intermediate reperesentation

2015-09-21 Thread Markus Armbruster
The QAPI code generators work with a syntax tree (nested dictionaries) plus a few symbol tables (also dictionaries) on the side. They have clearly outgrown these simple data structures. There's lots of rummaging around in dictionaries, and information is recomputed on the fly. For the work I'm g

[Qemu-devel] [PULL 15/26] qapi-commands: Rearrange code

2015-09-21 Thread Markus Armbruster
Rename gen_marshal_input() to gen_marshal(), because the generated function marshals both arguments and results. Rename gen_visitor_input_containers_decl() to gen_marshal_vars(), and move the other variable declarations there, too. Rename gen_visitor_input_block() to gen_marshal_input_visit(), an

[Qemu-devel] [PULL 25/26] qapi: New QMP command query-qmp-schema for QMP introspection

2015-09-21 Thread Markus Armbruster
qapi/introspect.json defines the introspection schema. It's designed for QMP introspection, but should do for similar uses, such as QGA. The introspection schema does not reflect all the rules and restrictions that apply to QAPI schemata. A valid QAPI schema has an introspection value conforming

[Qemu-devel] [PULL 06/26] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions

2015-09-21 Thread Markus Armbruster
Fixes flat unions to get the base's base members. Test case is from commit 2fc0043, in qapi-schema-test.json: { 'union': 'UserDefFlatUnion', 'base': 'UserDefUnionBase', 'discriminator': 'enum1', 'data': { 'value1' : 'UserDefA', 'value2' : 'UserDefB',

[Qemu-devel] [PULL 13/26] qapi: Clean up after recent conversions to QAPISchemaVisitor

2015-09-21 Thread Markus Armbruster
Generate just 'FOO' instead of 'struct FOO' when possible. Drop helper functions that are now unused. Make pep8 and pylint reasonably happy. Rename generate_FOO() functions to gen_FOO() for consistency. Use more consistent and sensible variable names. Consistently use c_ for mapping keys when

[Qemu-devel] [PULL 18/26] qapi-commands: De-duplicate output marshaling functions

2015-09-21 Thread Markus Armbruster
gen_marshal_output() uses its parameter name only for name of the generated function. Name it after the type being marshaled instead of its caller, and drop duplicates. Saves 7 copies of qmp_marshal_output_int() in qemu-ga, and one copy of qmp_marshal_output_str() in qemu-system-*. Signed-off-by

[Qemu-devel] [PULL 17/26] qapi: De-duplicate parameter list generation

2015-09-21 Thread Markus Armbruster
Generated qapi-event.[ch] lose line breaks. No change otherwise. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange Message-Id: <1442401589-24189-18-git-send-email-arm...@redhat.com> --- scripts/qapi-commands.py | 11 ++- scripts/qapi-event.py

[Qemu-devel] [PULL 16/26] qapi: Rename qmp_marshal_input_FOO() to qmp_marshal_FOO()

2015-09-21 Thread Markus Armbruster
These functions marshal both input and output. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange Message-Id: <1442401589-24189-17-git-send-email-arm...@redhat.com> --- docs/qapi-code-gen.txt| 4 +- docs/writing-qmp-commands.txt | 8 +- monitor

[Qemu-devel] [PULL 22/26] qom: Don't use 'gen': false for qom-get, qom-set, object-add

2015-09-21 Thread Markus Armbruster
With the previous commit, the generated marshalers just work, and save us a bit of handwritten code. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange Message-Id: <1442401589-24189-23-git-send-email-arm...@redhat.com> --- include/monitor/monitor.h | 3 --

[Qemu-devel] [PULL 19/26] qapi: Improve built-in type documentation

2015-09-21 Thread Markus Armbruster
Clarify how they map to JSON. Add how they map to C. Fix the reference to StringInputVisitor. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange Message-Id: <1442401589-24189-20-git-send-email-arm...@redhat.com> --- docs/qapi-code-gen.txt | 29 ++

[Qemu-devel] [PULL 24/26] qapi: Pseudo-type '**' is now unused, drop it

2015-09-21 Thread Markus Armbruster
'gen': false needs to stay for now, because netdev_add is still using it. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange Message-Id: <1442401589-24189-25-git-send-email-arm...@redhat.com> --- docs/qapi-code-gen.txt| 18 ++---

[Qemu-devel] [PULL 07/26] qapi-visit: Convert to QAPISchemaVisitor, fixing bugs

2015-09-21 Thread Markus Armbruster
Fixes flat unions to visit the base's base members (the previous commit merely added them to the struct). Same test case. Patch's effect on visit_type_UserDefFlatUnion(): static void visit_type_UserDefFlatUnion_fields(Visitor *m, UserDefFlatUnion **obj, Error **errp) { Error

[Qemu-devel] [PULL 21/26] qapi: Introduce a first class 'any' type

2015-09-21 Thread Markus Armbruster
It's first class, because unlike '**', it actually works, i.e. doesn't require 'gen': false. '**' will go away next. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange --- docs/qapi-code-gen.txt | 1 + include/qapi/visitor-imp

Re: [Qemu-devel] [PATCH 2/6] hw/s390x/css: Use type_init() instead of machine_init()

2015-09-21 Thread Christian Borntraeger
Am 19.09.2015 um 17:36 schrieb Andreas Färber: > Here, machine_init() is being misused to initialize global variables. > Being all local, it's safe to use the slightly earlier type_init(). > > This prepares for dropping machine_init(). > > Signed-off-by: Andreas Färber Acked-by: Christian Bornt

Re: [Qemu-devel] [PATCH] virtio-9p: migrate virtio subsections

2015-09-21 Thread Greg Kurz
On Sat, 19 Sep 2015 15:34:02 +0530 "Aneesh Kumar K.V" wrote: > Greg Kurz writes: > > > In a cross-endian setup, the virtio-9p device has state in @device_endian. > > It > > must be migrated. > > > > Signed-off-by: Greg Kurz > > With 9p mounted, we don't support qemu migration. We have > migr

Re: [Qemu-devel] [PATCH v4] ppc/spapr: Implement H_RANDOM hypercall in QEMU

2015-09-21 Thread Thomas Huth
On 21/09/15 10:01, Greg Kurz wrote: > On Mon, 21 Sep 2015 12:10:00 +1000 > David Gibson wrote: > >> On Fri, Sep 18, 2015 at 11:05:52AM +0200, Greg Kurz wrote: >>> On Thu, 17 Sep 2015 10:49:41 +0200 >>> Thomas Huth wrote: >>> The PAPR interface defines a hypercall to pass high-quality h

Re: [Qemu-devel] [PATCH 5/7] qdev: Protect device-list-properties against broken devices

2015-09-21 Thread David Hildenbrand
> Am 18.09.2015 um 14:00 schrieb Markus Armbruster: > > Several devices don't survive object_unref(object_new(T)): they crash > > or hang during cleanup, or they leave dangling pointers behind. > > > > This breaks at least device-list-properties, because > > qmp_device_list_properties() needs to c

Re: [Qemu-devel] [PATCH v4] ppc/spapr: Implement H_RANDOM hypercall in QEMU

2015-09-21 Thread Greg Kurz
On Mon, 21 Sep 2015 10:26:52 +0200 Thomas Huth wrote: > On 21/09/15 10:01, Greg Kurz wrote: > > On Mon, 21 Sep 2015 12:10:00 +1000 > > David Gibson wrote: > > > >> On Fri, Sep 18, 2015 at 11:05:52AM +0200, Greg Kurz wrote: > >>> On Thu, 17 Sep 2015 10:49:41 +0200 > >>> Thomas Huth wrote: > >>>

Re: [Qemu-devel] [PATCH v4 07/22] vhost: alloc shareable log

2015-09-21 Thread Michael S. Tsirkin
On Sat, Sep 19, 2015 at 12:11:58PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > If the backend is of type VHOST_BACKEND_TYPE_USER, allocate > shareable memory. Next patch will only allocate when the backend > has the required feature. > > Note: vhost_log_get() can use

Re: [Qemu-devel] [PATCH v4 12/22] vhost: only use shared log if in use by backend

2015-09-21 Thread Michael S. Tsirkin
On Sat, Sep 19, 2015 at 12:12:03PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Do not allocate a shared log if the backend doesn't support it. > > Signed-off-by: Marc-André Lureau If not there, we probably want to block live migration, correct? > --- > hw/virtio/v

Re: [Qemu-devel] [PATCH PULL v3 08/11] crypto: add sanity checking of TLS x509 credentials

2015-09-21 Thread Daniel P. Berrange
On Sat, Sep 19, 2015 at 09:47:01PM -0700, Peter Crosthwaite wrote: > On Tue, Sep 15, 2015 at 7:36 AM, Daniel P. Berrange > wrote: > > If the administrator incorrectly sets up their x509 certificates, > > the errors seen at runtime during connection attempts are very > > obscure and difficult to d

Re: [Qemu-devel] [PATCH V4 0/2] Move sdhci.h to include/hw/sd

2015-09-21 Thread Sai Pavan Boddu
Ping Thanks, Sai Pavan > -Original Message- > From: Sai Pavan Boddu [mailto:sai.pavan.bo...@xilinx.com] > Sent: Monday, September 14, 2015 2:57 PM > To: qemu-devel@nongnu.org; stefa...@gmail.com; > crosthwaitepe...@gmail.com; peter.mayd...@linaro.org > Cc: Alistair Francis; Edgar Iglesias

Re: [Qemu-devel] [PATCH v4 11/22] vhost-user: send log shm fd along with log_base

2015-09-21 Thread Michael S. Tsirkin
On Sat, Sep 19, 2015 at 12:12:02PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Send the shm for the dirty pages logging if the backend supports > VHOST_USER_PROTOCOL_F_LOG_SHMFD. > > Signed-off-by: Marc-André Lureau > --- > hw/virtio/vhost-backend.c | 3 ++-

Re: [Qemu-devel] [PATCH v4 09/22] vhost: use a function for each call

2015-09-21 Thread Michael S. Tsirkin
On Mon, Sep 21, 2015 at 09:33:04AM +0200, Thibaut Collet wrote: > > +static int vhost_reset_owner(struct vhost_dev *dev) > > +{ > > +VhostUserMsg msg = { > > +.request = VHOST_USER_RESET_OWNER, > > +.flags = VHOST_USER_VERSION, > > +}; > > + > > +vhost_user_write(dev, &m

Re: [Qemu-devel] [PATCH v4 09/22] vhost: use a function for each call

2015-09-21 Thread Michael S. Tsirkin
On Sat, Sep 19, 2015 at 12:12:00PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Replace the generic vhost_call() by specific functions for each > function call to help with type safety and changing arguments. > > Signed-off-by: Marc-André Lureau OK but I would rather

[Qemu-devel] [PULL 0/1] spice: surface switch fast path requires same format too.

2015-09-21 Thread Gerd Hoffmann
in the git repository at: git://anongit.freedesktop.org/spice/qemu tags/pull-spice-20150921-1 for you to fetch changes up to b2af43cc379e1d4c30d92af257bedebf0e3f618a: spice: surface switch fast path requires same format too. (2015-09-21 09:5

[Qemu-devel] [PULL 1/1] spice: surface switch fast path requires same format too.

2015-09-21 Thread Gerd Hoffmann
Commit "555e72f spice: rework mirror allocation, add no-resize fast path" adds a fast path for surface switches which does't go through the full primary surface destroy and re-recreation in case the new surface is identical to the old one (page-flip). It checks the size only though, but the format

Re: [Qemu-devel] [PATCH] hmp-commands-info.hx: fix drops hmp "info pci"

2015-09-21 Thread Paolo Bonzini
On 21/09/2015 07:58, Markus Armbruster wrote: > Pavel Butsykin writes: > >> On 18.09.2015 19:26, Eric Blake wrote: >>> On 09/18/2015 10:06 AM, Pavel Butsykin wrote: The hmp command "info pci" accidentally lost when moving from monitor.c Signed-off-by: Pavel Butsykin --- >>>

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-09-21 Thread Paolo Bonzini
On 21/09/2015 09:40, Peter Lieven wrote: >>> >>> >>> My backport (Linux only and without tests etc.) of the original fix >>> is here: >>> https://github.com/plieven/qemu/commit/0ddcdc62a85f705017df16421d769e82b70f9b37 >>> >> Could you be missing edec47c? > > Indeed this one fixed the deadlock wi

[Qemu-devel] Ping: [PATCH v2 0/2] PCI-e device multi-function hot-add support

2015-09-21 Thread Cao jin
On 09/16/2015 10:02 AM, Cao jin wrote: Support PCI-e device hot-add multi-function via device_add, just ensure add the function 0 is added last. While allow user to roll back in the middle via device_del, in case user regret. According to Alex`s comment, v2 has following update: 1. patch 1/2 r

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-09-21 Thread Peter Lieven
Am 21.09.2015 um 11:41 schrieb Paolo Bonzini: On 21/09/2015 09:40, Peter Lieven wrote: My backport (Linux only and without tests etc.) of the original fix is here: https://github.com/plieven/qemu/commit/0ddcdc62a85f705017df16421d769e82b70f9b37 Could you be missing edec47c? Indeed this one f

Re: [Qemu-devel] [PATCH] spapr: generate DT node names

2015-09-21 Thread Thomas Huth
On 19/09/15 00:06, Laurent Vivier wrote: > When DT node names for PCI devices are generated by SLOF, > they are generated according to the type of the device > (for instance, ethernet for virtio-net-pci device). > > Node name for hotplugged devices is generated by QEMU. > This patch adds the mecha

Re: [Qemu-devel] RFC: virtio-peer shared memory based peer communication device

2015-09-21 Thread Jan Kiszka
On 2015-09-18 23:11, Paolo Bonzini wrote: > On 18/09/2015 18:29, Claudio Fontana wrote: >> >> this is a first RFC for virtio-peer 0.1, which is still very much a work in >> progress: >> >> https://github.com/hw-claudio/virtio-peer/wiki >> >> It is also available as PDF there, but the text is repro

[Qemu-devel] [PATCH v3 0/9] hmp command IO- and Local APIC dump state

2015-09-21 Thread Denis V. Lunev
Added the hmp command to query IO- and Local APIC registers state, it can be very useful to identify problems related to the emulation devices. (qemu) info lapic dumping local APIC state for CPU 0 LVT0 0x00010700 active-hi edge masked ExtINT (vec 0) LVT1 0x0400 a

[Qemu-devel] [PATCH 9/9] hmp: implemented io apic dump state for TCG

2015-09-21 Thread Denis V. Lunev
From: Pavel Butsykin Added support emulator for the hmp command "info ioapic" Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Andreas Färber --- hw/intc/ioapic.c | 12 include/hw/i386/pc.h | 1 + target-i386/monitor.c | 2 ++ 3 files ch

[Qemu-devel] [PATCH 5/9] monitor: make monitor_fprintf and mon_get_cpu externally visible

2015-09-21 Thread Denis V. Lunev
From: Pavel Butsykin monitor_fprintf and mon_get_cpu will be used in the target-specific monitor, so it is advisable to make it external. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Andreas Färber --- disas.c | 10 -- includ

[Qemu-devel] [PATCH 3/9] apic_internal.h: added more constants

2015-09-21 Thread Denis V. Lunev
From: Pavel Butsykin These constants are needed for optimal access to bit fields local apic registers without magic numbers. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Andreas Färber --- include/hw/i386/apic_internal.h | 58

[Qemu-devel] [PATCH 4/9] apic_internal.h: fix formatting and drop unused consts

2015-09-21 Thread Denis V. Lunev
From: Pavel Butsykin Fix formatting of local apic definitions and drop unused constant APIC_INPUT_POLARITY, APIC_SEND_PENDING. Magic numbers in shifts are replaced with constants defined just above. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Andreas Färb

[Qemu-devel] [PATCH 1/9] apic_internal.h: make some apic_get_* functions externally visible

2015-09-21 Thread Denis V. Lunev
From: Pavel Butsykin Move apic_get_bit(), apic_set_bit() to apic_internal.h, make the apic_get_ppr symbol external. It's necessary to work with isr, tmr, irr and ppr outside hw/intc/apic.c Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Andreas Färber --- h

[Qemu-devel] [PATCH 2/9] apic_internal.h: rename ESR_ILLEGAL_ADDRESS to APIC_ESR_ILLEGAL_ADDRESS

2015-09-21 Thread Denis V. Lunev
From: Pavel Butsykin Added prefix APIC_ for determining the constant of a particular subsystem, improve the overall readability and match other constant names. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Andreas Färber --- hw/intc/apic.c

[Qemu-devel] [PATCH 8/9] hmp: added io apic dump state

2015-09-21 Thread Denis V. Lunev
From: Pavel Butsykin Added the hmp command to query io apic state, may be usefull after guest crashes to understand IRQ routing in guest. Implementation is only for kvm here. The dump will look like (qemu) info ioapic ioapic id=0x00 sel=0x2e (redir[15]) pin 0 0x0001 dest=0 vec=0 a

[Qemu-devel] [PATCH 7/9] ioapic_internal.h: added more constants

2015-09-21 Thread Denis V. Lunev
From: Pavel Butsykin Added the masks for easy access to fields of the redirection table entry Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Andreas Färber --- include/hw/i386/ioapic_internal.h | 5 + 1 file changed, 5 insertions(+) diff --git a/incl

[Qemu-devel] [PATCH 6/9] hmp: added local apic dump state

2015-09-21 Thread Denis V. Lunev
From: Pavel Butsykin Added the hmp command to query local apic registers state, may be usefull after guest crashes to understand IRQ routing in guest. (qemu) info lapic dumping local APIC state for CPU 0 LVT0 0x00010700 active-hi edge masked ExtINT (vec 0) LVT1 0x0

Re: [Qemu-devel] [FIRST-PATCH] updated the negation STREQ to STRNEQ

2015-09-21 Thread Michal Privoznik
[You've got the wrong list. This is a libvirt patch and as such it should have been sent to the libvir-l...@redhat.com] On 19.09.2015 16:59, Lasya wrote: > Hi, > This is my first patch in QEMU. I have solved a bite-sized bug. I have > updated the !STREQ with STRNEQ in the following files. Thanks.

Re: [Qemu-devel] [FIRST-PATCH] updated the negation STREQ to STRNEQ

2015-09-21 Thread Michal Privoznik
On 21.09.2015 13:05, Michal Privoznik wrote: > [You've got the wrong list. This is a libvirt patch and as such it > should have been sent to the libvir-l...@redhat.com] > > On 19.09.2015 16:59, Lasya wrote: >> Hi, >> This is my first patch in QEMU. I have solved a bite-sized bug. I have >> update

[Qemu-devel] [PATCH v3 1/1] block/gluster: add support for multiple gluster backup volfile servers

2015-09-21 Thread Prasanna Kumar Kalever
This patch adds a way to specify multiple backup volfile servers to the gluster block backend of QEMU with tcp|rdma transport types and their port numbers. Problem: Currenly VM Image on gluster volume is specified like this: file=gluster[+tcp]://server1[:port]/testvol/a.img Assuming we have hav

[Qemu-devel] [PATCH] pc: memhotplug: rise minimum DIMM addr/size alignment to 128Mb

2015-09-21 Thread Igor Mammedov
it's attempt to workaround virtio bug reported earlier: http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg00522.html where virtio can't handle buffer that crosses border between 2 DIMM's (i.e. 2 MemoryRegions). Testing showed that virtio doesn't hit above bug with 128Mb DIMM's granularity

Re: [Qemu-devel] [PATCH 0/8] target-i386: Implement debug extensions

2015-09-21 Thread Paolo Bonzini
On 15/09/2015 20:45, Richard Henderson wrote: > Best guess, since I can't find any code that actually uses them. > Linux actively turns them off at boot... I've sent a kvm-unit-tests patch to test debug extensions. It shows that debug extensions work, but the following needs to be squashed in p

Re: [Qemu-devel] RFC: virtio-peer shared memory based peer communication device

2015-09-21 Thread Michael S. Tsirkin
On Fri, Sep 18, 2015 at 06:29:27PM +0200, Claudio Fontana wrote: > Hello, > > this is a first RFC for virtio-peer 0.1, which is still very much a work in > progress: > > https://github.com/hw-claudio/virtio-peer/wiki > > It is also available as PDF there, but the text is reproduced here for >

Re: [Qemu-devel] RFC: virtio-peer shared memory based peer communication device

2015-09-21 Thread Paolo Bonzini
On 21/09/2015 12:47, Jan Kiszka wrote: >> > Apart from the windows idea, how does virtio-peer compare to virtio-rpmsg? > rpmsg is a very specialized thing. It targets single AMP cores, assuming > that those have full access to the main memory. Yes, this is why I did say "apart from the windows i

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-09-21 Thread Paolo Bonzini
On 21/09/2015 11:52, Peter Lieven wrote: >> >> e4efd8a488d0a68b0af34d8ee245463df7c8bdf4 qemu-timer: initialize >> "timers_done_ev" to set >> 12d69ac03b45156356b240424623719f15d8143e tests: remove irrelevant assertions >> from test-aio >> 6493c975af75be5b8d9ade954239bdf5492b7911 aio-win32: reorg

Re: [Qemu-devel] [PATCH] pc: memhotplug: rise minimum DIMM addr/size alignment to 128Mb

2015-09-21 Thread Paolo Bonzini
On 21/09/2015 13:50, Igor Mammedov wrote: > it's attempt to workaround virtio bug reported earlier: > http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg00522.html > where virtio can't handle buffer that crosses border > between 2 DIMM's (i.e. 2 MemoryRegions). > > Testing showed that vi

[Qemu-devel] [PATCH 3/5] ide: add support for cancelable read requests

2015-09-21 Thread Peter Lieven
this patch adds a new aio readv compatible function which copies all data through a bounce buffer. The benefit is that these requests can be flagged as canceled to avoid guest memory corruption when a canceled request is completed by the backend at a later stage. If an IDE protocol wants to use th

[Qemu-devel] [PATCH 4/5] ide/atapi: enable cancelable requests

2015-09-21 Thread Peter Lieven
Signed-off-by: Peter Lieven --- hw/ide/atapi.c | 4 ++-- hw/ide/core.c | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index b209ed9..ab45495 100644 --- a/hw/ide/atapi.c +++ b/hw/ide/atapi.c @@ -141,7 +141,7 @@ static int cd_read_sector(IDESt

Re: [Qemu-devel] RFC: virtio-peer shared memory based peer communication device

2015-09-21 Thread Jan Kiszka
On 2015-09-21 14:13, Michael S. Tsirkin wrote: > On Fri, Sep 18, 2015 at 06:29:27PM +0200, Claudio Fontana wrote: >> Hello, >> >> this is a first RFC for virtio-peer 0.1, which is still very much a work in >> progress: >> >> https://github.com/hw-claudio/virtio-peer/wiki >> >> It is also available

[Qemu-devel] [PATCH 2/5] ide/atapi: blk_aio_readv may return NULL

2015-09-21 Thread Peter Lieven
Signed-off-by: Peter Lieven --- hw/ide/atapi.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index 9257e1c..b209ed9 100644 --- a/hw/ide/atapi.c +++ b/hw/ide/atapi.c @@ -371,6 +371,10 @@ static void ide_atapi_cmd_read_dma_cb(void *opaque, int ret) s-

[Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-09-21 Thread Peter Lieven
PIO read requests on the ATAPI interface used to be sync blk requests. This has to siginificant drawbacks. First the main loop hangs util an I/O request is completed and secondly if the I/O request does not complete (e.g. due to an unresponsive storage) Qemu hangs completely. Signed-off-by: Peter

Re: [Qemu-devel] [PATCH] pc: memhotplug: rise minimum DIMM addr/size alignment to 128Mb

2015-09-21 Thread Igor Mammedov
On Mon, 21 Sep 2015 14:22:23 +0200 Paolo Bonzini wrote: > > > On 21/09/2015 13:50, Igor Mammedov wrote: > > it's attempt to workaround virtio bug reported earlier: > > http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg00522.html > > where virtio can't handle buffer that crosses border

[Qemu-devel] [PATCH 0/5] ide: avoid main-loop hang on CDROM/NFS failure

2015-09-21 Thread Peter Lieven
This series aims at avoiding a hanging main-loop if a vserver has a CDROM image mounted from a NFS share and that NFS share goes down. Typical situation is that users mount an CDROM ISO to install something and then forget to eject that CDROM afterwards. As a consequence this mounted CD is able to

Re: [Qemu-devel] [PATCH] pc: memhotplug: rise minimum DIMM addr/size alignment to 128Mb

2015-09-21 Thread Paolo Bonzini
On 21/09/2015 15:05, Igor Mammedov wrote: >> > To some extend, enforcing natural alignment would be okay as a >> > workaround for the virtio bug as well. It would also make it easier to >> > ensure that hotplugged hugetlbfs-backed memory can use hugepages in the >> > guest. Does it make sense t

Re: [Qemu-devel] [PATCH] linux-user: fix cmsg conversion in case of multiple headers

2015-09-21 Thread Peter Maydell
On 20 September 2015 at 22:34, Jonathan Neuschäfer wrote: > On Fri, Sep 04, 2015 at 01:48:39PM +0100, Peter Maydell wrote: >> On 3 September 2015 at 06:27, Jonathan Neuschäfer >> wrote: >> > Currently, __target_cmsg_nxthdr compares a pointer derived from >> > target_cmsg against the msg_control

[Qemu-devel] [PATCH 5/5] block/nfs: cache allocated filesize for read-only files

2015-09-21 Thread Peter Lieven
If the file is readonly its not expected to grow so save the blocking call to nfs_fstat_async and use the value saved at connection time. Also important the monitor (and thus the main loop) will not hang if block device info is queried and the NFS share is unresponsive. Signed-off-by: Peter Lieven

Re: [Qemu-devel] [PATCH v2 0/2] Dynamic module support for block drivers

2015-09-21 Thread Marc Marí
Ping! Anyone has more comments for the next version? Thanks Marc >On Tue, 8 Sep 2015 15:53:20 +0200 >Marc Marí wrote: > > The current module infrastructure has been improved to enable dynamic > module loading. > > This reduces the load time for very simple guests. For the following > configur

Re: [Qemu-devel] [PATCH] pc: memhotplug: rise minimum DIMM addr/size alignment to 128Mb

2015-09-21 Thread Igor Mammedov
On Mon, 21 Sep 2015 15:13:17 +0200 Paolo Bonzini wrote: > > > On 21/09/2015 15:05, Igor Mammedov wrote: > >> > To some extend, enforcing natural alignment would be okay as a > >> > workaround for the virtio bug as well. It would also make it easier to > >> > ensure that hotplugged hugetlbfs-ba

Re: [Qemu-devel] [PATCH] pc: memhotplug: rise minimum DIMM addr/size alignment to 128Mb

2015-09-21 Thread Paolo Bonzini
On 21/09/2015 15:32, Igor Mammedov wrote: > On Mon, 21 Sep 2015 15:13:17 +0200 > Paolo Bonzini wrote: > >> >> >> On 21/09/2015 15:05, Igor Mammedov wrote: > To some extend, enforcing natural alignment would be okay as a > workaround for the virtio bug as well. It would also make it eas

Re: [Qemu-devel] [PATCH v2 0/2] Dynamic module support for block drivers

2015-09-21 Thread Denis V. Lunev
On 09/08/2015 04:53 PM, Marc Marí wrote: The current module infrastructure has been improved to enable dynamic module loading. This reduces the load time for very simple guests. For the following configuration (very loaded) ./configure --enable-sdl --enable-gtk --enable-vte --enable-curses \

Re: [Qemu-devel] [PATCH v2 1/2] Add dynamic module loading for block drivers

2015-09-21 Thread Denis V. Lunev
On 09/08/2015 04:53 PM, Marc Marí wrote: Extend the current module interface to allow for block drivers to be loaded dynamically on request. The only block drivers that can be converted into modules are the drivers that don't perform any init operation except for registering themselves. This is

Re: [Qemu-devel] [PATCH v3 0/9] hmp command IO- and Local APIC dump state

2015-09-21 Thread Paolo Bonzini
On 21/09/2015 12:57, Denis V. Lunev wrote: > Added the hmp command to query IO- and Local APIC registers state, > it can be very useful to identify problems related to the emulation devices. > > (qemu) info lapic > dumping local APIC state for CPU 0 > > LVT0 0x00010700 active-hi edge maske

Re: [Qemu-devel] [PATCH v4 07/22] vhost: alloc shareable log

2015-09-21 Thread Marc-André Lureau
Hi - Original Message - > On Sat, Sep 19, 2015 at 12:11:58PM +0200, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > If the backend is of type VHOST_BACKEND_TYPE_USER, allocate > > shareable memory. Next patch will only allocate when the backend > > has the required

Re: [Qemu-devel] [PATCH v4 12/22] vhost: only use shared log if in use by backend

2015-09-21 Thread Marc-André Lureau
Hi - Original Message - > On Sat, Sep 19, 2015 at 12:12:03PM +0200, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Do not allocate a shared log if the backend doesn't support it. > > > > Signed-off-by: Marc-André Lureau > > If not there, we probably want to blo

Re: [Qemu-devel] [PATCH v4 11/22] vhost-user: send log shm fd along with log_base

2015-09-21 Thread Marc-André Lureau
- Original Message - > On Sat, Sep 19, 2015 at 12:12:02PM +0200, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Send the shm for the dirty pages logging if the backend supports > > VHOST_USER_PROTOCOL_F_LOG_SHMFD. > > > > Signed-off-by: Marc-André Lureau > > --

Re: [Qemu-devel] [PATCH 0/8] target-i386: Implement debug extensions

2015-09-21 Thread Eduardo Habkost
On Mon, Sep 21, 2015 at 02:05:52PM +0200, Paolo Bonzini wrote: > On 15/09/2015 20:45, Richard Henderson wrote: > > Best guess, since I can't find any code that actually uses them. > > Linux actively turns them off at boot... > > I've sent a kvm-unit-tests patch to test debug extensions. It shows

Re: [Qemu-devel] [PATCH v4 09/22] vhost: use a function for each call

2015-09-21 Thread Marc-André Lureau
- Original Message - > On Sat, Sep 19, 2015 at 12:12:00PM +0200, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Replace the generic vhost_call() by specific functions for each > > function call to help with type safety and changing arguments. > > > > Signed-off-

[Qemu-devel] [PATCH] vmxnet3: Support reading IMR registers on bar0

2015-09-21 Thread Shmulik Ladkani
Instead of asserting, return the actual IMR register value. This is aligned with what's returned on ESXi. Signed-off-by: Shmulik Ladkani Tested-by: Dana Rubin --- hw/net/vmxnet3.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index

Re: [Qemu-devel] [PATCH 0/8] target-i386: Implement debug extensions

2015-09-21 Thread Paolo Bonzini
On 21/09/2015 16:05, Eduardo Habkost wrote: > On Mon, Sep 21, 2015 at 02:05:52PM +0200, Paolo Bonzini wrote: >> On 15/09/2015 20:45, Richard Henderson wrote: >>> Best guess, since I can't find any code that actually uses them. >>> Linux actively turns them off at boot... >> >> I've sent a kvm-uni

Re: [Qemu-devel] [PATCH] hmp-commands-info.hx: fix drops hmp "info pci"

2015-09-21 Thread Markus Armbruster
Paolo Bonzini writes: > On 21/09/2015 07:58, Markus Armbruster wrote: >> Pavel Butsykin writes: >> >>> On 18.09.2015 19:26, Eric Blake wrote: On 09/18/2015 10:06 AM, Pavel Butsykin wrote: > The hmp command "info pci" accidentally lost when moving from monitor.c > > Signed-off-b

Re: [Qemu-devel] [PATCH v2 4/4] target-i386: Call cpu_exec_init() on realize

2015-09-21 Thread Eduardo Habkost
On Mon, Sep 21, 2015 at 11:11:47AM +0530, Bharata B Rao wrote: > On Sat, Sep 19, 2015 at 1:08 AM, Eduardo Habkost wrote: > > QOM instance_init functions are not supposed to have any side-effects, > > as new objects may be created at any moment for querying property > > information (see qmp_device_

Re: [Qemu-devel] [PATCH V4 2/2] sdhci: Split sdhci.h for public and internal device usage

2015-09-21 Thread Peter Crosthwaite
On Mon, Sep 14, 2015 at 2:26 AM, Sai Pavan Boddu wrote: > Split sdhci.h into sdhci-common.h(pubilc Version in include/) and > sdhci.h(internal version in hw/sd) base on register declarations and > object declaration. > > Signed-off-by: Sai Pavan Boddu > --- > Changes for V4: > Remain the name

Re: [Qemu-devel] [PATCH v2 0/2] Dynamic module support for block drivers

2015-09-21 Thread Marc Marí
On Mon, 21 Sep 2015 16:43:27 +0300 "Denis V. Lunev" wrote: > On 09/08/2015 04:53 PM, Marc Marí wrote: > > The current module infrastructure has been improved to enable > > dynamic module loading. > > > > This reduces the load time for very simple guests. For the following > > configuration (very

Re: [Qemu-devel] [PATCH v2 0/2] Dynamic module support for block drivers

2015-09-21 Thread Denis V. Lunev
On 09/21/2015 05:44 PM, Marc Marí wrote: On Mon, 21 Sep 2015 16:43:27 +0300 "Denis V. Lunev" wrote: On 09/08/2015 04:53 PM, Marc Marí wrote: The current module infrastructure has been improved to enable dynamic module loading. This reduces the load time for very simple guests. For the follow

  1   2   3   >