On Wed, 2 Sep 2015 16:58:45 -0300
Eduardo Habkost wrote:
> Ping?
In case that helps:
Acked-by: Cornelia Huck
>
> Andreas, should this go through your QOM tree?
>
> On Thu, Aug 20, 2015 at 02:54:26PM -0700, Eduardo Habkost wrote:
> > The machine class names in QEMU are not consistent today.
03.09.2015 10:33, Peter Maydell пишет:
On 3 September 2015 at 06:27, Sergey Smolov wrote:
I mean that in this example QEMU does not write to log "intermediate" SUBS
instructions which appear in loop-unrolling process.
For me it woulb be ok if QEMU generate the following in_asm log:
[log]
IN:
On Tue, Sep 01, 2015 at 06:28:28PM +0200, Jan Kiszka wrote:
> On 2015-09-01 18:02, Michael S. Tsirkin wrote:
> > On Tue, Sep 01, 2015 at 05:34:37PM +0200, Jan Kiszka wrote:
> >> On 2015-09-01 16:34, Michael S. Tsirkin wrote:
> >>> On Tue, Sep 01, 2015 at 04:09:44PM +0200, Jan Kiszka wrote:
> O
On Wed, Sep 02, 2015 at 09:45:45PM -0700, Nakajima, Jun wrote:
> BTW, can you please take a look at the following URL to see my
> understanding is correct? Our engineers are saying that they are not
> really sure if they understood your proposal (especially around
> IOMMU), and I drew a figure, add
On 2015-09-03 10:08, Michael S. Tsirkin wrote:
> On Tue, Sep 01, 2015 at 06:28:28PM +0200, Jan Kiszka wrote:
>> On 2015-09-01 18:02, Michael S. Tsirkin wrote:
>>> On Tue, Sep 01, 2015 at 05:34:37PM +0200, Jan Kiszka wrote:
On 2015-09-01 16:34, Michael S. Tsirkin wrote:
> On Tue, Sep 01, 20
On Wed, 2 Sep 2015 19:57:25 +0200
Greg Kurz wrote:
> On Wed, 2 Sep 2015 17:50:55 +0200
> Cornelia Huck wrote:
>
> > On Wed, 2 Sep 2015 17:23:49 +0200
> > Pierre Morel wrote:
> >
> > > Being working on dataplane I notice something strange:
> > >
> > > virtio_queue_get_avail_size() used a 64b
On Thu, Sep 03, 2015 at 10:21:28AM +0200, Jan Kiszka wrote:
> On 2015-09-03 10:08, Michael S. Tsirkin wrote:
> > On Tue, Sep 01, 2015 at 06:28:28PM +0200, Jan Kiszka wrote:
> >> On 2015-09-01 18:02, Michael S. Tsirkin wrote:
> >>> On Tue, Sep 01, 2015 at 05:34:37PM +0200, Jan Kiszka wrote:
> O
On 02.09.2015 22:45, Peter Maydell wrote:
> Maybe rather than trying to be clever with the existing wp APIs
> we should have support for targets to register "did this really hit?"
> callbacks that get called before the core code tries to really
> generate the exception.
Thank you, Peter, for the s
On Wed, 2 Sep 2015 18:53:44 +0200
Pierre Morel wrote:
> Let dataplane allocate different region for the desc/avail/used
> ring regions.
> Take VIRTIO_RING_F_EVENT_IDX into account to increase the used/avail
> rings accordingly.
>
> Signed-off-by: Pierre Morel
>
I'll re-run tests after people
On 1 September 2015 at 19:38, Michael Roth wrote:
> The following changes since commit 090d0bfd948343d522cd20bc634105b5cfe2483b:
>
> s390: fix softmmu compilation (2015-08-28 16:05:24 +0100)
>
> are available in the git repository at:
>
> git://github.com/mdroth/qemu.git tags/qga-pull-2015-09-
On Mo, 2015-08-31 at 10:55 +0200, Peter Lieven wrote:
> Am 28.08.2015 um 13:56 schrieb Gerd Hoffmann:
> > On Do, 2015-08-27 at 14:46 +0200, Peter Lieven wrote:
> >> I have observed that depending on the contents and the encoding it happens
> >> that sending data as RAW sometimes would take less spa
On Do, 2015-08-27 at 12:18 +0200, Peter Lieven wrote:
> This makes sure the number of reallocs is in O(log N).
Looks good, applied.
Dear Kevin,
Kevin Wolf writes:
> Am 03.07.2015 um 09:28 hat Bo Tu geschrieben:
>> Bo Tu (5):
>> qemu-iotests: qemu machine type support
>> qemu-iotests: disable default qemu devices for cross-platform
>> compatibility
>> qemu-iotests: s390x: fix test 041 and 055
>> qemu-iotests: s390
On Thu, 3 Sep 2015 10:23:44 +0200
Greg Kurz wrote:
> On Wed, 2 Sep 2015 19:57:25 +0200
> Greg Kurz wrote:
>
> > On Wed, 2 Sep 2015 17:50:55 +0200
> > Cornelia Huck wrote:
> >
> > > On Wed, 2 Sep 2015 17:23:49 +0200
> > > Pierre Morel wrote:
> > >
> > > > Being working on dataplane I notice
Hi Josh,
I just found the LWN.net article with the title in the subject:
http://lwn.net/SubscriberLink/655992/04701db2bbb7e716/
("Thank you LWN", of course. :))
This got me kind of excited. In your presentation, according to the
article, you were using KVM and OVMF to showcase the ACPI featur
Michael Roth writes:
> Quoting Markus Armbruster (2015-09-02 03:56:41)
>> Michael Roth writes:
>>
>> > Quoting Eric Blake (2015-09-01 14:12:24)
>> >> On 09/01/2015 12:40 PM, Michael Roth wrote:
>> >> > Quoting Markus Armbruster (2015-08-04 10:58:14)
>> >> >> Caution, rough edges.
>> >> >>
>> >>
Max Reitz writes:
> On 31.08.2015 22:33, Programmingkid wrote:
>>
>> On Aug 31, 2015, at 4:26 PM, Max Reitz wrote:
>
> [snip]
>
>>> The following works for me:
>>>
>>> $ echo foo > bar
>>> $ x86_64-softmmu/qemu-system-x86_64 -qmp stdio -usb -cdrom
>>> ~/tmp/archlinux-2015.07.01-dual.iso -enable-
Side point:
On 09/03/15 11:16, Laszlo Ersek wrote:
>
> I just found the LWN.net article with the title in the subject:
>
> http://lwn.net/SubscriberLink/655992/04701db2bbb7e716/
>
> ("Thank you LWN", of course. :))
I've just been advised in private, well-meaningly, that I shouldn't post
LWN
Programmingkid writes:
> On Sep 2, 2015, at 10:31 AM, Max Reitz wrote:
>
>> On 31.08.2015 22:33, Programmingkid wrote:
>>>
>>> On Aug 31, 2015, at 4:26 PM, Max Reitz wrote:
>>
>> [snip]
>>
The following works for me:
$ echo foo > bar
$ x86_64-softmmu/qemu-system-x86_64 -qm
On Do, 2015-08-27 at 11:39 +0100, Daniel P. Berrange wrote:
> On Thu, Aug 27, 2015 at 12:18:52PM +0200, Peter Lieven wrote:
> > currently the Buffer can only grow. This increases Qemu memory footprint
> > dramatically since normally the biggest VNC updates are at connection time.
> > But also after
Signed-off-by: Markus Armbruster
---
scripts/qapi.py | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/scripts/qapi.py b/scripts/qapi.py
index ac0e45e..817d824 100644
--- a/scripts/qapi.py
+++ b/scripts/qapi.py
@@ -1035,11 +1035,12 @@ def open_output(output_dir, do_c
Signed-off-by: Markus Armbruster
---
docs/qapi-code-gen.txt | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt
index b4d4a01..ff16df2 100644
--- a/docs/qapi-code-gen.txt
+++ b/docs/qapi-code-gen.txt
@@ -300,7 +300,6 @@ an impli
On Do, 2015-08-27 at 12:18 +0200, Peter Lieven wrote:
> if no client is connected there is no need to keep the server
> surface. Throw it away and replace it with a dummy surface to
> save memory.
No dummy surface please. Just set vd->server = NULL.
cheers,
Gerd
Markus Armbruster writes:
> Markus Armbruster writes:
>
>> v2:
>> * Trivially rebased, R-bys retained
>> * [PATCH 02] Clean up string literal to please pylint
>> * [PATCH 07] Commit message fix [Eric]
>> * [PATCH 20] Doc fix [Eric]
>> * [PATCH 21] Update test cases for the change even though the
Ping?
My "qapi: QMP introspection" series fails "make check" without these
fixes.
Markus Armbruster writes:
> v1 was posted for possible inclusion into 2.4, but the maintainer
> didn't bite ;-)
>
> v2:
> * Commit messages updated.
>
> Markus Armbruster (2):
> qom: Do not reuse errp after a po
Am 03.09.2015 um 11:52 schrieb Gerd Hoffmann:
On Do, 2015-08-27 at 11:39 +0100, Daniel P. Berrange wrote:
On Thu, Aug 27, 2015 at 12:18:52PM +0200, Peter Lieven wrote:
currently the Buffer can only grow. This increases Qemu memory footprint
dramatically since normally the biggest VNC updates ar
Am 03.09.2015 um 11:57 schrieb Gerd Hoffmann:
On Do, 2015-08-27 at 12:18 +0200, Peter Lieven wrote:
if no client is connected there is no need to keep the server
surface. Throw it away and replace it with a dummy surface to
save memory.
No dummy surface please. Just set vd->server = NULL.
I
On 2 September 2015 at 17:01, Stefan Hajnoczi wrote:
> The following changes since commit 090d0bfd948343d522cd20bc634105b5cfe2483b:
>
> s390: fix softmmu compilation (2015-08-28 16:05:24 +0100)
>
> are available in the git repository at:
>
> git://github.com/stefanha/qemu.git tags/block-pull-r
On Fr, 2015-08-21 at 17:36 +0200, Kővágó, Zoltán wrote:
> This patch series adds support to multiple audio backends. Afterwards I
> add support to multiple backends. Audio fronteds gain a new audiodev
> option to specify the id of the audiodev to use. The audiodev= option
> is required, unless y
On 2015-09-03 10:37, Michael S. Tsirkin wrote:
> On Thu, Sep 03, 2015 at 10:21:28AM +0200, Jan Kiszka wrote:
>> On 2015-09-03 10:08, Michael S. Tsirkin wrote:
>>>
>>> IOW if you wish, you actually can create a shared memory device,
>>> make it accessible to the IOMMU and place some or all
>>> data
Am 03.09.2015 um 10:56 schrieb Gerd Hoffmann:
On Do, 2015-08-27 at 12:18 +0200, Peter Lieven wrote:
This makes sure the number of reallocs is in O(log N).
Looks good, applied.
I think there is a small error. The new capacity should be calculated as
follows:
diff --git a/ui/vnc.c b/ui/vnc.c
The following changes since commit f8b8091d2779d956011a3fb83ff60dbf7465c71d:
Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2015-09-01-v2-tag'
into staging (2015-09-01 19:42:43 +0100)
are available in the git repository at:
git://github.com/cohuck/qemu tags/s390x-201
From: "Jason J. Herne"
A new QOM style device is provided to back guest storage keys. A special
version for KVM is created, which handles the storage key access via
KVM_S390_GET_SKEYS and KVM_S390_SET_SKEYS ioctl.
Reviewed-by: David Hildenbrand
Signed-off-by: Jason J. Herne
Signed-off-by: Corn
From: "Jason J. Herne"
Provide an info skeys hmp sub-command to allow the end user to dump a storage
key for a given address. This is useful for guest operating system developers.
Reviewed-by: Thomas Huth
Reviewed-by: David Hildenbrand
Signed-off-by: Jason J. Herne
Signed-off-by: Cornelia Hu
From: "Jason J. Herne"
This code disables storage key migration when an older machine type is
specified.
Reviewed-by: David Hildenbrand
Signed-off-by: Jason J. Herne
Signed-off-by: Cornelia Huck
---
hw/s390x/s390-skeys.c | 33 ++---
hw/s390x/s390-virtio-
From: "Jason J. Herne"
Routines to save/load guest storage keys are provided. register_savevm is
called to register them as migration handlers.
We prepare the protocol to support more complex parameters. So we will
later be able to support standby memory (having empty holes), compression
and "st
From: "Jason J. Herne"
Add dump-skeys command to the human monitor.
Reviewed-by: Thomas Huth
Reviewed-by: David Hildenbrand
Signed-off-by: Jason J. Herne
Signed-off-by: Cornelia Huck
---
hmp-commands.hx | 16
hw/s390x/s390-skeys.c | 12
Am 03.09.2015 um 11:52 schrieb Gerd Hoffmann:
On Do, 2015-08-27 at 11:39 +0100, Daniel P. Berrange wrote:
On Thu, Aug 27, 2015 at 12:18:52PM +0200, Peter Lieven wrote:
currently the Buffer can only grow. This increases Qemu memory footprint
dramatically since normally the biggest VNC updates ar
From: "Jason J. Herne"
Provide a dump-skeys qmp command to allow the end user to dump storage
keys. This is useful for debugging problems with guest storage key support
within Qemu and for guest operating system developers.
Reviewed-by: Thomas Huth
Reviewed-by: David Hildenbrand
Signed-off-by:
---
scripts/indent.sh | 11 +++
1 file changed, 11 insertions(+)
create mode 100755 scripts/indent.sh
diff --git a/scripts/indent.sh b/scripts/indent.sh
new file mode 100755
index 000..8f045ec
--- /dev/null
+++ b/scripts/indent.sh
@@ -0,0 +1,11 @@
+#!/bin/sh
+#
+# indent wrapper scri
On Fr, 2015-08-21 at 17:36 +0200, Kővágó, Zoltán wrote:
> This patch series adds support to multiple audio backends. Afterwards I
> add support to multiple backends. Audio fronteds gain a new audiodev
> option to specify the id of the audiodev to use. The audiodev= option
> is required, unless y
Am 03.09.2015 um 10:56 hat Sascha Silbe geschrieben:
> Kevin Wolf writes:
>
> > Am 03.07.2015 um 09:28 hat Bo Tu geschrieben:
> >> Bo Tu (5):
> >> qemu-iotests: qemu machine type support
> >> qemu-iotests: disable default qemu devices for cross-platform
> >> compatibility
> >> qemu-iote
Reviewed-by: Jason J. Herne
Signed-off-by: Cornelia Huck
Acked-by: Christian Borntraeger
---
hw/s390x/s390-virtio-ccw.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index 4c51d1a..71df282 100644
When Xen is using the qemu usb framework for pure passthrough of I/Os
to host devices the handling of isoc jobs is rather complicated if
multiple isoc frames are transferred with one call.
Instead of calling the framework with each frame individually, using
timers to avoid polling in a loop and sa
This series adds a Xen pvUSB backend driver to qemu. USB devices
connected to the host can be passed through to a Xen guest. The
devices are specified via Xenstore. Access to the devices is done
via host-libusb.c
I've tested the backend with various USB devices (memory sticks,
keyboard, phono prea
Add a backend for para-virtualized USB devices for xen domains.
The backend is using host-libusb to forward USB requests from a
domain via libusb to the real device(s) passed through.
Signed-off-by: Juergen Gross
---
hw/usb/Makefile.objs |4 +
hw/usb/xen-usb.c | 1120 +++
Introduce a new dummy system device serving as parent for virtual
buses. This will enable new pv backends to introduce virtual buses
which are removable again opposed to system buses which are meant
to stay once added.
Signed-off-by: Juergen Gross
---
hw/xenpv/xen_machine_pv.c| 39 ++
From: "Jason J. Herne"
s390 guest initialization is modified to make use of new s390-storage-keys
device. Old code that globally allocated storage key array is removed.
The new device enables storage key access for kvm guests.
Cache storage key QOM objects in frequently used helper functions to
On Do, 2015-09-03 at 12:29 +0200, Peter Lieven wrote:
> -buffer->capacity = pow2ceil(buffer->capacity + len);
> +buffer->capacity = pow2ceil(buffer->offset + len);
Updated patch.
thanks,
Gerd
On Do, 2015-09-03 at 12:08 +0200, Peter Lieven wrote:
> Am 03.09.2015 um 11:57 schrieb Gerd Hoffmann:
> > On Do, 2015-08-27 at 12:18 +0200, Peter Lieven wrote:
> >> if no client is connected there is no need to keep the server
> >> surface. Throw it away and replace it with a dummy surface to
> >>
On Wed, Sep 02, 2015 at 11:38:10AM -0700, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
Reviewed-by: Edgar E. Iglesias
Tested-by: Edgar E. Iglesias
Thanks, I've added this to my CRIS queue.
Cheers,
Edgar
> ---
> This was originally posted back in February. I failed to keep
> a
On Wed, Sep 02, 2015 at 02:46:01PM -0700, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
Reviewed-by: Edgar E. Iglesias
Tested-by: Edgar E. Iglesias
I've added this to my MB queue, thanks.
Cheers,
Edgar
> ---
> This was originally posted back in February. I failed to keep
> an
On 2 September 2015 at 17:14, Stefan Hajnoczi wrote:
> The following changes since commit 090d0bfd948343d522cd20bc634105b5cfe2483b:
>
> s390: fix softmmu compilation (2015-08-28 16:05:24 +0100)
>
> are available in the git repository at:
>
> git://github.com/stefanha/qemu.git tags/net-pull-req
Hi,
> > Beside that I think it makes sense to have the shrinking logic in
> > buffer_reserve too so we don't have to add buffer_shrink calls all over
> > the place.
>
> We need a possibility to shrink the buffer after it has been used.
> Especially the queue->buffer.
That works fine. Test pat
Hi,
> buffer_reserve: 11/t-tight: 4096 kB
> buffer_reserve: 11/t-tight: 8192 kB
> buffer_reserve: 11/t-tight: 16384 kB
A bit more than what I see (4096 usually, 8192 once). No idea why.
> buffer_reserve: queue : 8192 kB
> buffer_reserve: 11/jobs : 8192 kB
> buffer_reserve: 11/out: 8
Am 03.09.2015 um 13:57 schrieb Gerd Hoffmann:
Hi,
buffer_reserve: 11/t-tight: 4096 kB
buffer_reserve: 11/t-tight: 8192 kB
buffer_reserve: 11/t-tight: 16384 kB
A bit more than what I see (4096 usually, 8192 once). No idea why.
buffer_reserve: queue : 8192 kB
buffer_reserve: 11/jobs
On 2 September 2015 at 20:58, Richard Henderson wrote:
> Fixed version of the patch set posted 17 August.
> Please pull.
>
>
> r~
>
>
> The following changes since commit 074a9925e1cfd659d5376dcaccd1436d3840e611:
>
> Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into
> sta
2015-09-03 12:15 keltezéssel, Gerd Hoffmann írta:
On Fr, 2015-08-21 at 17:36 +0200, Kővágó, Zoltán wrote:
This patch series adds support to multiple audio backends. Afterwards I
add support to multiple backends. Audio fronteds gain a new audiodev
option to specify the id of the audiodev to use
l.org/qemu tags/pull-ipxe-20150903-1
for you to fetch changes up to f4798320144245da66128edb840bd940fd287d28:
ipxe: update binaries (2015-09-03 14:46:24 +0200)
ipxe: update to 35c53797 to 4e03af
We had build problems due to the git version checking in the ipxe build
system in the past. Don't remember the details, but the problem seems
to be gone now, so lets remove the workaround.
Signed-off-by: Gerd Hoffmann
[ most likely ipxe commit 6153c09c41034250408f3596555fcaae715da46c:
[build]
git shortlog
Alex Williamson (1):
[dhcp] Extract timing parameters out to config/dhcp.h
Bernd Wiebelt (1):
[tg3] Add support for BCM57766
Christian Hesse (3):
[intel] Add PCI device IDs for Intel I218-LM and I218-V
[build] Add missing "const" qualifiers
Upstream supports named configurations now and ships with
settings for qemu. Use them, drop our config header copying.
Signed-off-by: Gerd Hoffmann
---
roms/Makefile | 11 ---
roms/config.ipxe.general.h | 4
2 files changed, 4 insertions(+), 11 deletions(-)
delete mo
Signed-off-by: Gerd Hoffmann
Reviewed-by: Laszlo Ersek
---
pc-bios/efi-e1000.rom| Bin 197120 -> 196608 bytes
pc-bios/efi-eepro100.rom | Bin 197632 -> 197120 bytes
pc-bios/efi-ne2k_pci.rom | Bin 195584 -> 195584 bytes
pc-bios/efi-pcnet.rom| Bin 195584 -> 195584 bytes
pc-bios/efi-rtl81
Am 31.07.2015 um 11:29 schrieb Paolo Bonzini:
On 31/07/2015 10:35, Peter Lieven wrote:
Am 31.07.2015 um 10:22 schrieb Paolo Bonzini:
52c91da memory: do not add a reference to the owner of aliased regions
This could be backported, yes. Feel free to send it to qemu-stable.
However, the bug was
On 3 September 2015 at 14:02, Gerd Hoffmann wrote:
> Hi,
>
> Here comes the ipxe update pull. Thanks to Stefan all bits are upstream
> now. Also upstream has a named configuration for qemu. That simplifies
> the whole process, I could drop some patches and so there are only 4 of
> them left,
On 2 September 2015 at 22:41, Richard Henderson wrote:
> These two patches represent all of the backlog for tcg/* of
> which I'm aware. Please pull.
>
>
> r~
>
>
> The following changes since commit 090d0bfd948343d522cd20bc634105b5cfe2483b:
>
> s390: fix softmmu compilation (2015-08-28 16:05:24
On Fri, Aug 28, 2015 at 10:18:28PM +0200, Laszlo Ersek wrote:
> +R1e. The generation ID shall not live in a page frame that could be mapped
> with
> + caching disabled. (In other words, if the generation ID lives in RAM,
> then
> + it shall only be mapped as cacheable.)
Same if it's in R
On 09/03/2015 02:17 AM, Richard Henderson wrote:
Avoids warnings from unused variables etc.
Signed-off-by: Richard Henderson
---
target-openrisc/translate.c | 20
1 file changed, 4 insertions(+), 16 deletions(-)
Reviewed-by: Bastian Koppelmann
Cheers,
Bastian
On 09/03/2015 02:17 AM, Richard Henderson wrote:
+
+void HELPER(ove)(CPUOpenRISCState *env, target_ulong test)
+{
+if (unlikely(test) && (env->sr & SR_OVE)) {
+OpenRISCCPU *cpu = openrisc_env_get_cpu(env);
+CPUState *cs = CPU(cpu);
+
+cs->exception_index = EXCP_RANGE
From: Marc-André Lureau
Remove the chardev implicitely when cleaning up the netdev. This
prevents from reusing the chardev since it would be in an incorrect
state for the server.
Signed-off-by: Marc-André Lureau
---
net/vhost-user.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/vhost
From: Marc-André Lureau
On init, vhost-user does qemu_chr_fe_claim_no_fail(). Do the opposite on
cleanup to allow removing or reusing the chardev.
Signed-off-by: Marc-André Lureau
---
net/vhost-user.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/vhost-user.c b/net/vhost-user.c
ind
From: Marc-André Lureau
The following 2 one-liners remove the chardev from the vhost-user
netdev it is attached to. This prevents from further reuse of the
chardev that would likely fail to setup again with the backend
depending on their state.
Related to:
https://bugzilla.redhat.com/show_bug.cg
On 26 August 2015 at 11:28, Pavel Fedin wrote:
> From: Shlomo Pongratz
>
> This class is to be used by both software and KVM implementations of GICv3
>
> Currently it is mostly a placeholder, but in future it is supposed to hold
> qemu's representation of GICv3 state, which is necessary for migra
On Sep 3, 2015, at 5:46 AM, Markus Armbruster wrote:
> Programmingkid writes:
>
>> On Sep 2, 2015, at 10:31 AM, Max Reitz wrote:
>>
>>> On 31.08.2015 22:33, Programmingkid wrote:
On Aug 31, 2015, at 4:26 PM, Max Reitz wrote:
>>>
>>> [snip]
>>>
> The following works for me:
>>>
On 09/03/15 15:49, Michael S. Tsirkin wrote:
> On Fri, Aug 28, 2015 at 10:18:28PM +0200, Laszlo Ersek wrote:
>> +R1e. The generation ID shall not live in a page frame that could be mapped
>> with
>> + caching disabled. (In other words, if the generation ID lives in RAM,
>> then
>> + it sh
On 09/02/2015 11:33 PM, Peter Maydell wrote:
You might find the 'exec' logging helpful for tracking
which translated blocks get executed.
Even then you will of course only log the head of unlinked chains of blocks.
r~
I want to name a new class QAPISchema.
While there, make it a new-style class.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
scripts/qapi.py | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/scripts/qapi.py b/scripts/qapi.py
index 817d824..a0165dd 10064
Fixes events whose data is struct with base to include the struct's
base members. Test case is qapi-schema-test.json's event
__org.qemu_x-command:
{ 'event': '__ORG.QEMU_X-EVENT', 'data': '__org.qemu_x-Struct' }
{ 'struct': '__org.qemu_x-Struct', 'base': '__org.qemu_x-Base',
'data'
New methods c_name(), c_type(), c_null(), json_type(),
alternate_qtype().
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
scripts/qapi.py | 76 +++--
1 file changed, 69 insertions(+), 7 deletions(-)
diff --git a/scripts/qapi.py b
One of the next patches will among other things generate a separate
typedef for some struct types, i.e.
typedef struct FOO FOO;
struct FOO {
...
};
instead of
typedef struct FOO {
...
} FOO;
To make the generated files easier to diff, anticipate the change.
Signed-
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
scripts/qapi-event.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/scripts/qapi-event.py b/scripts/qapi-event.py
index aed45d6..537da17 100644
--- a/scripts/qapi-event.py
+++ b/scripts/qapi-event.py
@@ -137,7 +
is_c_ptr() looks whether the end of the C text for the type looks like
a pointer. Works, but is fragile.
We now have a better tool: use QAPISchemaType method c_null(). The
initializers for non-pointers become prettier: 0, false or the
enumeration constant with the value 0 instead of {0}.
Signed
Duplicated in commit 21cd70d. Yes, we can't import qapi-types, but
that's no excuse. Move the helpers from qapi-types.py to qapi.py, and
replace the duplicates in qapi-event.py.
The generated event enumeration type's lookup table becomes
const-correct (see commit 2e4450f), and uses explicit inde
Still RFC, because we probably want to drop the "just to facilitate
review" patches, and maybe squash PATCH 31 or 32 into PATCH 30.
* PATCH 01-24 basically replace the interemediate representation. The
replacement isn't complete, but fully functional. See PATCH 02 for
rationale and future wo
This reverts commit 6542034f356ebc6f2818c1c6b8c9a143f817bb2a.
Signed-off-by: Markus Armbruster
---
scripts/qapi-types.py | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py
index 124a788..d162ca2 100644
--- a/scrip
The visitor will help keeping the code generation code simple and
reasonably separated from QAPISchema details.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
scripts/qapi.py | 46 ++
1 file changed, 46 insertions(+)
diff --git a/script
Output unchanged apart from reordering and white-space.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
scripts/qapi-commands.py | 154 ++-
scripts/qapi.py | 2 +-
2 files changed, 86 insertions(+), 70 deletions(-)
diff --git
Fixes flat unions to get the base's base members. Test case is from
commit 2fc0043, in qapi-schema-test.json:
{ 'union': 'UserDefFlatUnion',
'base': 'UserDefUnionBase',
'discriminator': 'enum1',
'data': { 'value1' : 'UserDefA',
'value2' : 'UserDefB',
Move gen_visit_decl() to a better place. Inline
generate_visit_struct_body().
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
scripts/qapi-visit.py | 43 +--
1 file changed, 17 insertions(+), 26 deletions(-)
diff --git a/scripts/qapi-visit.
Clarify how they map to JSON. Add how they map to C. Fix the
reference to StringInputVisitor.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
docs/qapi-code-gen.txt | 29 ++---
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/docs/qapi-code-
Fixes flat unions to visit the base's base members (the previous
commit merely added them to the struct). Same test case.
Patch's effect on visit_type_UserDefFlatUnion():
static void visit_type_UserDefFlatUnion_fields(Visitor *m,
UserDefFlatUnion **obj, Error **errp)
{
Error
This reverts commit 22ff4d4ac6cd553f328e400de6913dc879581c4c.
Signed-off-by: Markus Armbruster
---
scripts/qapi-commands.py | 7 ---
scripts/qapi-event.py| 12
scripts/qapi-types.py| 18 --
scripts/qapi-visit.py| 12
scripts/qapi.py
The effect of the next few patches on generated files is hard to
review, because stuff gets generated in different order, which renders
diffs of the generated files useless.
To get reviewable diffs, we need to split the generated files into
suitable parts: put every top-level declaration in a file
Generated qapi-event.[ch] lose line breaks. No change otherwise.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
scripts/qapi-commands.py | 11 ++-
scripts/qapi-event.py| 18 +++---
scripts/qapi.py | 16
3 files changed, 21 inserti
This reverts commit ebce6e3cd3fdf3c1d507a060c80822d98b034ba5.
Signed-off-by: Markus Armbruster
---
scripts/qapi-commands.py | 7 ---
scripts/qapi-event.py| 9 -
scripts/qapi-types.py| 8
scripts/qapi-visit.py| 9 -
scripts/qapi.py | 8
5
How many bits we use internally is an implementation detail. It could
be pressed into external interface service as very approximate range
information, but that's probably a bad idea. If we need range
information, we better do it properly.
Reduces output of query-schema by a negligible 0.5 out o
It doesn't take a 'props' argument, let alone one in the format
"NAME=VALUE,..."
The bogus arguments specification doesn't matter due to 'gen': false.
Clean it up to be incomplete rather than wrong, and document the
incompleteness.
While there, improve netdev_add usage example in the manual: add
It's first class, because unlike '**', it actually works, i.e. doesn't
require 'gen': false.
'**' will go away next.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
docs/qapi-code-gen.txt | 1 +
include/qapi/visitor-impl.h| 2 +
The QAPI code generators work with a syntax tree (nested dictionaries)
plus a few symbol tables (also dictionaries) on the side.
They have clearly outgrown these simple data structures. There's lots
of rummaging around in dictionaries, and information is recomputed on
the fly. For the work I'm g
Generate just 'FOO' instead of 'struct FOO' when possible.
Drop helper functions that are now unused.
Make pylint reasonably happy.
Rename generate_FOO() functions to gen_FOO() for consistency.
Use more consistent and sensible variable names.
Consistently use c_ for mapping keys when their val
1 - 100 of 312 matches
Mail list logo
