On 26 August 2015 at 11:28, Pavel Fedin <p.fe...@samsung.com> wrote: > From: Shlomo Pongratz <shlomo.pongr...@huawei.com> > > This class is to be used by both software and KVM implementations of GICv3 > > Currently it is mostly a placeholder, but in future it is supposed to hold > qemu's representation of GICv3 state, which is necessary for migration. > > The interface of this class is fully compatible with GICv2 one. This is > done in order to simplify integration with existing code. > > Signed-off-by: Shlomo Pongratz <shlomo.pongr...@huawei.com> > Signed-off-by: Pavel Fedin <p.fe...@samsung.com> > Reviewed-by: Eric Auger <eric.au...@linaro.org> > Tested-by: Ashok kumar <ash...@broadcom.com>
> +++ b/hw/intc/arm_gicv3_common.c > @@ -0,0 +1,140 @@ > +/* > + * ARM GICv3 support - common bits of emulated and KVM kernel model > + * > + * Copyright (c) 2012 Linaro Limited > + * Copyright (c) 2015 Huawei. > + * Written by Peter Maydell > + * Extended to 64 cores by Shlomo Pongratz You might want to reword that line, the 64 cores bit isn't quite right any more. > +#define TYPE_ARM_GICV3_COMMON "arm_gicv3_common" We prefer '-' in type names, not '_' (see http://wiki.qemu.org/QOMConventions). Obviously we have a bunch of older devices in the tree that don't follow that guideline... Otherwise Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM
