Re: [Qemu-devel] [Patch for-2.5 v2 6/6] hmp: add monitor command to add/remove a child

2015-08-31 Thread Markus Armbruster
Wen Congyang writes: > Ping... > Patch 1-4 have been reviewed by Alberto Garcia > Luiz Capitulino, Markus Armbruster, do you have time to review the > monitor command implementation? I will review at least the QMP parts of this series. My review queue has become painfully long... I apologize f

Re: [Qemu-devel] [PATCH v2 07/18] nvdimm: reserve address range for NVDIMM

2015-08-31 Thread Xiao Guangrong
Hi Eduardo, Thank you for reviewing my patches. On 08/29/2015 01:25 AM, Eduardo Habkost wrote: On Fri, Aug 14, 2015 at 10:52:00PM +0800, Xiao Guangrong wrote: NVDIMM reserves all the free range above 4G to do: - Persistent Memory (PMEM) mapping - implement NVDIMM ACPI device _DSM method Sign

Re: [Qemu-devel] [PATCH v8 03/11] netfilter: add netfilter_{add|del} commands

2015-08-31 Thread Markus Armbruster
Yang Hongyang writes: > On 08/28/2015 07:37 PM, Markus Armbruster wrote: [...] >> To make progress, I suggest you try the following: >> >> 1. Make NetFilter a flat union, as I suggested in my review of PATCH 2. >> >> 2. Use Eric's idea above, because it avoids the dependency on code >> that's

Re: [Qemu-devel] [PATCH] pci-testdev: add nodata test

2015-08-31 Thread Michael S. Tsirkin
On Mon, Aug 31, 2015 at 11:04:42AM +0800, Jason Wang wrote: > > > On 08/27/2015 06:30 PM, Michael S. Tsirkin wrote: > > Add nodata test where data length is ignored. > > Skip it for port IO since kvm does not support it there. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > hw/misc/pci-te

Re: [Qemu-devel] MTTCG next version?

2015-08-31 Thread alvise rigo
Hi Frederic, On Wed, Aug 26, 2015 at 2:18 PM, Frederic Konrad wrote: > Hi everybody, > > I'm trying to do the next version of the MTTCG work: > > I would like to rebase on Alvise atomic instruction branch: > - Alvise can you rebase it on the 2.4.0 version without MTTCG support and > then >

Re: [Qemu-devel] Mount image file feature

2015-08-31 Thread Markus Armbruster
Programmingkid writes: > On Aug 29, 2015, at 12:39 PM, Max Reitz wrote: > >> On 29.08.2015 17:57, Programmingkid wrote: >>> >>> On Aug 29, 2015, at 11:40 AM, Max Reitz wrote: >>> On 27.08.2015 03:05, G 3 wrote: > I want to share files between my host and guest computer. A feature I >>>

Re: [Qemu-devel] [PATCH] pci-testdev: add nodata test

2015-08-31 Thread Jason Wang
On 08/31/2015 03:28 PM, Michael S. Tsirkin wrote: > On Mon, Aug 31, 2015 at 11:04:42AM +0800, Jason Wang wrote: >> >> On 08/27/2015 06:30 PM, Michael S. Tsirkin wrote: >>> Add nodata test where data length is ignored. >>> Skip it for port IO since kvm does not support it there. >>> >>> Signed-off

Re: [Qemu-devel] Mount image file feature

2015-08-31 Thread Markus Armbruster
MagicCat Software writes: > On Aug 29, 2015, at 7:04 PM, Eric Blake wrote: > >> On 08/29/2015 11:36 AM, Programmingkid wrote: >> > Mac OS X is a second-class citizen in the QEMU world... Might have to do something with most (?) of it being non-free and Apple not caring

Re: [Qemu-devel] [snabb-devel] Re: [PATCH v6 1/2] vhost-user: add multi queue support

2015-08-31 Thread Ouyang, Changchun
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Sunday, August 30, 2015 2:16 PM > To: Ouyang, Changchun > Cc: snabb-de...@googlegroups.com; qemu-devel@nongnu.org; > thibaut.col...@6wind.com; n.nikol...@virtualopensystems.com; > l...@snabb.co; Long, Thomas;

Re: [Qemu-devel] [PATCH 1/2] block/io: allow AIOCB without callback

2015-08-31 Thread Peter Lieven
Am 21.08.2015 um 08:12 schrieb Eric Blake: On 08/20/2015 01:14 AM, Peter Lieven wrote: If the backend storage is unresponsive and we cancel a request due to a timeout we cannot immediately destroy the AIOCB because the storage might complete the original request laster if it is responsive again.

Re: [Qemu-devel] [PATCH] block/iscsi: validate block size returned from target

2015-08-31 Thread Peter Lieven
Am 14.08.2015 um 13:33 schrieb Peter Lieven: It has been reported that at least tgtd returns a block size of 0 for LUN 0. To avoid running into divide by zero later on and protect against other problematic block sizes validate the block size right at connection time. Cc: qemu-sta...@nongnu.org R

Re: [Qemu-devel] [PATCH v5] vhost-user: add multi queue support

2015-08-31 Thread Marcel Apfelbaum
On 08/31/2015 08:42 AM, Xu, Qian Q wrote: + Jingguo, and he will be working on the vhost multi-queue support functional tests. Marcel, What you try to is to run dpdk-vhost sample and the dpdk-virtio(virtio-pmd) case? Attached the step-by-step guide of running it with one queue, you can update

Re: [Qemu-devel] [PATCH] vnc: allow fall back to RAW encoding

2015-08-31 Thread Peter Lieven
Am 28.08.2015 um 13:56 schrieb Gerd Hoffmann: On Do, 2015-08-27 at 14:46 +0200, Peter Lieven wrote: I have observed that depending on the contents and the encoding it happens that sending data as RAW sometimes would take less space than the encoded data. This is especially the case for small upd

[Qemu-devel] [PATCH 0/2] alpha-host: Add Alpha host tcg backend to latest QEMU

2015-08-31 Thread gang . chen . 5i5j
From: Chen Gang It is only for version merging, no any functional modification. Chen Gang (2): alpha-host: Add Alpha host tcg backend. alpha-host: Fix alpha host related merging issues. configure | 16 +- include/exec/exec-all.h | 11 +- include/qemu-common.h |4 +-

[Qemu-devel] [PATCH 2/2] alpha-host: Fix alpha host related merging issues.

2015-08-31 Thread gang . chen . 5i5j
From: Chen Gang It can pass simple test for i386-linux-user under ALpha VM: run i386 bash successfully (let pagesize be TARGET_PAGE_SIZE, temporary). Signed-off-by: Chen Gang --- tcg/alpha/tcg-target.c | 139 +++-- tcg/alpha/tcg-target.h | 8 ++- 2

[Qemu-devel] [PATCH 1/2] alpha-host: Add Alpha host tcg backend.

2015-08-31 Thread gang . chen . 5i5j
From: Chen Gang It is merged from git://github.com/rth7680/qemu.git tcg-alpha-2 Signed-off-by: Richard Henderson Signed-off-by: Chen Gang --- configure | 16 +- include/exec/exec-all.h | 11 +- include/qemu-common.h |4 +- tcg/alpha/tcg-target.c | 1945 +++

Re: [Qemu-devel] [PATCH v8 03/11] netfilter: add netfilter_{add|del} commands

2015-08-31 Thread Yang Hongyang
On 08/31/2015 03:08 PM, Markus Armbruster wrote: Yang Hongyang writes: On 08/28/2015 07:37 PM, Markus Armbruster wrote: [...] To make progress, I suggest you try the following: 1. Make NetFilter a flat union, as I suggested in my review of PATCH 2. 2. Use Eric's idea above, because it avoi

Re: [Qemu-devel] [PATCH RFC v3 26/32] qapi: Introduce a first class 'any' type

2015-08-31 Thread Markus Armbruster
Markus Armbruster writes: > Eric Blake writes: > >> On 08/04/2015 09:58 AM, Markus Armbruster wrote: >>> It's first class, because unlike '**', it actually works, i.e. doesn't >>> require 'gen': false. >>> >>> '**' will go away next. >>> >>> Signed-off-by: Markus Armbruster >>> Reviewed-by: E

[Qemu-devel] QEMU fw_cfg DMA interface

2015-08-31 Thread Marc Marí
Implementation of the FW CFG DMA interface. When running a Linux guest on top of QEMU, using the -kernel options, this is the timing improvement for x86: QEMU commit 090d0bf and SeaBIOS commit 2fc20dc QEMU startup time: .078 BIOS startup time: .060 Kernel setup time: .578 Total time: .716 QEMU w

[Qemu-devel] [PATCH v2 0/5] fw_cfg DMA interface

2015-08-31 Thread Marc Marí
Implement host-side of the FW CFG DMA interface both for x86 and ARM. Based on Gerd Hoffman's initial implementation. Gabriel L. Somlo (1): fw_cfg: document fw_cfg_modify_iXX() update functions Marc Marí (4): fw_cfg DMA interface documentation Implement fw_cfg DMA interface Enable fw_cfg

[Qemu-devel] [PATCH v2 4/5] Enable fw_cfg DMA interface for ARM

2015-08-31 Thread Marc Marí
Enable the fw_cfg DMA interface for the ARM virt machine. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí --- hw/arm/virt.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index b88c104..54d5f54 100644 ---

[Qemu-devel] [PATCH v2 1/5] fw_cfg: document fw_cfg_modify_iXX() update functions

2015-08-31 Thread Marc Marí
From: "Gabriel L. Somlo" Document the behavior of fw_cfg_modify_iXX() for leak-less updating of integer-type blobs. Currently only fw_cfg_modify_i16() is coded, but 32- and 64-bit versions may be added later if necessary.. Signed-off-by: Gabriel Somlo Signed-off-by: Gerd Hoffmann Reviewed-by:

[Qemu-devel] [PATCH v2 5/5] Enable fw_cfg DMA interface for x86

2015-08-31 Thread Marc Marí
Enable the fw_cfg DMA interface for all the x86 platforms. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí --- hw/i386/pc.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 9f2924e..c6dc84f 100644 --- a/hw

[Qemu-devel] [PATCH v2 3/5] Implement fw_cfg DMA interface

2015-08-31 Thread Marc Marí
Based on the specifications on docs/specs/fw_cfg.txt This interface is an addon. The old interface can still be used as usual. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí --- hw/arm/virt.c | 2 +- hw/nvram/fw_cfg.c | 261 ++

[Qemu-devel] [PATCH v2 2/5] fw_cfg DMA interface documentation

2015-08-31 Thread Marc Marí
Add fw_cfg DMA interface specification in the documentation. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí --- docs/specs/fw_cfg.txt | 68 --- 1 file changed, 64 insertions(+), 4 deletions(-) diff --git a/docs/specs/fw_

Re: [Qemu-devel] [PATCH 0/2] alpha-host: Add Alpha host tcg backend to latest QEMU

2015-08-31 Thread Chen Gang
On 2015年08月31日 16:59, gang.chen.5...@gmail.com wrote: > From: Chen Gang > > It is only for version merging, no any functional modification. > > Chen Gang (2): > alpha-host: Add Alpha host tcg backend. > alpha-host: Fix alpha host related merging issues. > It is only for version merging, so I

Re: [Qemu-devel] [PATCH v6] hw/arm/virt: Add high MMIO PCI region, 512G in size

2015-08-31 Thread Igor Mammedov
On Wed, 12 Aug 2015 15:12:13 +0300 Pavel Fedin wrote: > This large region is necessary for some devices like ivshmem and video cards > 32-bit kernels can be built without LPAE support. In this case such a kernel > will not be able to use PCI controller which has windows in high addresses. > In or

Re: [Qemu-devel] [PATCH COLO-Frame v8 19/34] qmp event: Add event notification for COLO error

2015-08-31 Thread zhanghailiang
On 2015/8/29 6:13, Eric Blake wrote: On 07/29/2015 02:45 AM, zhanghailiang wrote: If some errors happen during VM's COLO FT stage, it's import to notify the users s/import/important/ this event, Togehter with 'colo_lost_heartbeat', users can intervene in COLO's s/this event,/of this event.

[Qemu-devel] [PATCH v10 0/4] remove icc bus/bridge

2015-08-31 Thread Zhu Guihua
ICC Bus was used for providing a hotpluggable bus for APIC and CPU, but now we use HotplugHandler to make hotplug. So ICC Bus is unnecessary. This code has passed the new pc-cpu-test. And I have tested with kvm along with kernel_irqchip=on/off, it works fine. This patch series is based on the lat

[Qemu-devel] [PATCH v10 2/4] x86: use new method to correct reset sequence

2015-08-31 Thread Zhu Guihua
Something must be occur during reset of the X86 platform in a specific order. For example, some devices (such as hpet, rtc) reset will send irq to apic, this will update the apic register. In order to ensure the apic register could be set to default values, apic reset must be after those devices re

[Qemu-devel] [PATCH v10 3/4] cpu/apic: drop icc bus/bridge

2015-08-31 Thread Zhu Guihua
From: Chen Fan After CPU hotplug has been converted to BUS-less hot-plug infrastructure, the only function ICC bus performs is to propagate reset to LAPICs. However LAPIC could be reset by registering its reset handler after all device are initialized. Do so and drop ~200LOC of not needed anymore

[Qemu-devel] [PATCH v10 1/4] apic: map APIC's MMIO region at each CPU's address space

2015-08-31 Thread Zhu Guihua
From: Chen Fan After ICC bus/bridge have been removed, APIC MMIO area could not be mapped into sysbus MMIO any more. So replace mapping APIC at global system address space with mapping it at per-CPU address spaces. Signed-off-by: Chen Fan Signed-off-by: Zhu Guihua --- hw/i386/pc.c |

[Qemu-devel] [PATCH v10 4/4] icc_bus: drop the unused files

2015-08-31 Thread Zhu Guihua
ICC bus impl has been droped, so all icc related files are not useful any more; delete them. Signed-off-by: Zhu Guihua --- default-configs/i386-softmmu.mak | 1 - default-configs/x86_64-softmmu.mak | 1 - hw/cpu/Makefile.objs | 1 - hw/cpu/icc_bus.c | 118

Re: [Qemu-devel] [PATCH v3 2/2] rtl8139: correctly track full receive buffer in standard mode

2015-08-31 Thread Jason Wang
On 08/28/2015 10:06 PM, Vladislav Yasevich wrote: > In standard operation mode, when the receive ring buffer > is full, the buffer actually appears empty to the driver since > the RxBufAddr (the location we wirte new data to) and RxBufPtr > (the location guest would stat reading from) are the sam

[Qemu-devel] [PATCH 0/1] Allow passing BlockdevOptions to blockdev-snapshot-sync

2015-08-31 Thread Alberto Garcia
Here's my first attempt to solve the problem explained here: https://lists.gnu.org/archive/html/qemu-devel/2015-08/msg02847.html In short: there's no way to pass options to snapshots created using blockdev-snapshot-sync. This patch simply allows passing a BlockdevOptions structure to that com

[Qemu-devel] [PATCH 1/1] block: Allow passing BlockdevOptions to blockdev-snapshot-sync

2015-08-31 Thread Alberto Garcia
Snapshots created using blockdev-snapshot-sync are currently opened using their default options, not even inheriting those from the images they are based on. This patch extends the command by adding an 'options' parameter that takes a BlockdevOptions structure. Since some of the options that can b

Re: [Qemu-devel] [PATCH COLO-Frame v8 21/34] COLO: Add new command parameter 'forward_nic' 'colo_script' for net

2015-08-31 Thread zhanghailiang
Hi Eric This patch will be dropped in next version since we will realize the proxy in qemu. Thanks, zhanghailiang On 2015/8/29 6:24, Eric Blake wrote: On 07/29/2015 02:45 AM, zhanghailiang wrote: The 'forward_nic' should be assigned with network name, for exmple, 'eth2'. It will be parameter

[Qemu-devel] [PATCH v3 6/8] s390x: Info skeys sub-command

2015-08-31 Thread Cornelia Huck
From: "Jason J. Herne" Provide an info skeys hmp sub-command to allow the end user to dump a storage key for a given address. This is useful for guest operating system developers. Reviewed-by: Thomas Huth Reviewed-by: David Hildenbrand Signed-off-by: Jason J. Herne Signed-off-by: Cornelia Hu

[Qemu-devel] [PATCH v3 0/8] s390x: storage key migration

2015-08-31 Thread Cornelia Huck
The next edition of the storage key migration patches. Changes from v2: - more tweaks to use qemu error handling infrastructure - some message tweaks Cornelia Huck (1): s390x: add 2.5 compat s390-ccw-virtio machine Jason J. Herne (7): s390x: Create QOM device for s390 storage keys s390x: E

[Qemu-devel] [PATCH v3 4/8] s390x: Dump storage keys qmp command

2015-08-31 Thread Cornelia Huck
From: "Jason J. Herne" Provide a dump-skeys qmp command to allow the end user to dump storage keys. This is useful for debugging problems with guest storage key support within Qemu and for guest operating system developers. Reviewed-by: Thomas Huth Reviewed-by: David Hildenbrand Signed-off-by:

[Qemu-devel] [PATCH v3 2/8] s390x: Create QOM device for s390 storage keys

2015-08-31 Thread Cornelia Huck
From: "Jason J. Herne" A new QOM style device is provided to back guest storage keys. A special version for KVM is created, which handles the storage key access via KVM_S390_GET_SKEYS and KVM_S390_SET_SKEYS ioctl. Reviewed-by: David Hildenbrand Signed-off-by: Jason J. Herne Signed-off-by: Corn

[Qemu-devel] [PATCH v3 5/8] s390x: Dump-skeys hmp support

2015-08-31 Thread Cornelia Huck
From: "Jason J. Herne" Add dump-skeys command to the human monitor. Reviewed-by: Thomas Huth Reviewed-by: David Hildenbrand Signed-off-by: Jason J. Herne Signed-off-by: Cornelia Huck --- hmp-commands.hx | 16 hw/s390x/s390-skeys.c | 12

[Qemu-devel] [PATCH v3 7/8] s390x: Migrate guest storage keys (initial memory only)

2015-08-31 Thread Cornelia Huck
From: "Jason J. Herne" Routines to save/load guest storage keys are provided. register_savevm is called to register them as migration handlers. We prepare the protocol to support more complex parameters. So we will later be able to support standby memory (having empty holes), compression and "st

[Qemu-devel] [PATCH v3 8/8] s390x: Disable storage key migration on old machine type

2015-08-31 Thread Cornelia Huck
From: "Jason J. Herne" This code disables storage key migration when an older machine type is specified. Reviewed-by: David Hildenbrand Signed-off-by: Jason J. Herne Signed-off-by: Cornelia Huck --- hw/s390x/s390-skeys.c | 33 ++--- hw/s390x/s390-virtio-

Re: [Qemu-devel] [PATCH 6/8] qcow2: add autoclear bit for dirty bitmaps

2015-08-31 Thread Vladimir Sementsov-Ogievskiy
On 27.08.2015 10:45, Vladimir Sementsov-Ogievskiy wrote: On 09.06.2015 18:50, Stefan Hajnoczi wrote: On Mon, Jun 08, 2015 at 06:21:24PM +0300, Vladimir Sementsov-Ogievskiy wrote: diff --git a/block/qcow2.c b/block/qcow2.c index 406e55d..f85a55a 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@

[Qemu-devel] [PATCH v3 3/8] s390x: Enable new s390-storage-keys device

2015-08-31 Thread Cornelia Huck
From: "Jason J. Herne" s390 guest initialization is modified to make use of new s390-storage-keys device. Old code that globally allocated storage key array is removed. The new device enables storage key access for kvm guests. Cache storage key QOM objects in frequently used helper functions to

[Qemu-devel] [PATCH v3 1/8] s390x: add 2.5 compat s390-ccw-virtio machine

2015-08-31 Thread Cornelia Huck
Reviewed-by: Jason J. Herne Signed-off-by: Cornelia Huck Acked-by: Christian Borntraeger --- hw/s390x/s390-virtio-ccw.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 4c51d1a..71df282 100644

[Qemu-devel] [PATCH 02/23] s390x/css: ccw-0 enforces count > 0

2015-08-31 Thread Cornelia Huck
Type-0 ccws need to have a count > 0 for any command other than TIC. Generate a channel-program check if this is not the case. Reviewed-by: Matthew Rosato Signed-off-by: Cornelia Huck --- hw/s390x/css.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/s390x/css.c b/hw/s390x/css.c inde

[Qemu-devel] [PATCH 01/23] s390x/css: handle ccw-0 TIC correctly

2015-08-31 Thread Cornelia Huck
From: Pierre Morel In CCW-0 format TIC command 4 highest bits are ignored in the subchannel. In CCW-1 format the TIC command 4 highest bits must be 0. To convert TIC from CCW-0 to CCW-1 we clear the 4 highest bits to guarantee compatibility. Signed-off-by: Pierre Morel Reviewed-by: Cornelia Huc

[Qemu-devel] [PATCH 05/23] s390x/event-facility: fix location of receive mask

2015-08-31 Thread Cornelia Huck
For read event mask, we assumed that the layout of the sccb was |sccb header|event buffer header|receive mask|...| The correct layout, however, is |sccb header|receive mask|...| as in-buffer and |sccb header|event buffer header|...| as out-buffer. Fix this: This makes selective read work. R

[Qemu-devel] [PATCH 00/23] s390x: further patches

2015-08-31 Thread Cornelia Huck
Hi, here's a further set of patches on top of the storage key migration patches (v3) I just sent out. Contained in there are: - various bugfixes (css/event-facility) - more efficient adapter interrupt routes setup - gdb enhancement - sclp got treated with a lot of remodelling/cleanup Alexander Y

[Qemu-devel] [PATCH 11/23] s390/sclp: rework sclp event facility initialization + device realization

2015-08-31 Thread Cornelia Huck
From: David Hildenbrand The current code only works by chance. The event facility is a sysbus device, but specifies in its class structure as parent the DeviceClass (instead of a device class). The init function in return lies therefore at the same position as the init function of SysBusDeviceCl

[Qemu-devel] [PATCH 17/23] s390: no need to manually parse for slots and maxmem

2015-08-31 Thread Cornelia Huck
From: David Hildenbrand ram_slots and maxram_size has already been parsed and verified by common code for us. Reviewed-by: Matthew Rosato Signed-off-by: David Hildenbrand Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw.c | 3 +-- hw/s390x/sclp.c| 11 +++ 2 file

[Qemu-devel] [PATCH 16/23] s390/sclp: move sclp_service_interrupt into the sclp device

2015-08-31 Thread Cornelia Huck
From: David Hildenbrand Let's make that function a method of the new sclp device, keeping the wrapper for existing users. We can now let go of get_event_facility(). Reviewed-by: Matthew Rosato Signed-off-by: David Hildenbrand Signed-off-by: Cornelia Huck --- hw/s390x/sclp.c | 21 +++

[Qemu-devel] [PATCH 03/23] s390x/event-facility: fix receive mask check

2015-08-31 Thread Cornelia Huck
For selective read event, we need to check if any event is requested that is not active instead of whether none of the requested events is active. Reviewed-by: David Hildenbrand Reviewed-by: Eric Farman Signed-off-by: Cornelia Huck --- hw/s390x/event-facility.c | 5 +++-- 1 file changed, 3 ins

[Qemu-devel] [PATCH 19/23] s390/sclp: ignore memory hotplug operations if it is disabled

2015-08-31 Thread Cornelia Huck
From: David Hildenbrand If no memory hotplug device was created, the sclp command facility is not exposed (SCLP_FC_ASSIGN_ATTACH_READ_STOR). We therefore have no memory hotplug and should correctly report SCLP_RC_INVALID_SCLP_COMMAND if any such command is executed. This gets rid of these ugly a

[Qemu-devel] [PATCH 08/23] s390x/kvm: make setting of in-kernel irq routes more efficient

2015-08-31 Thread Cornelia Huck
From: Jens Freimann When we add new adapter routes we call kvm_irqchip_add_route() for every virtqueue and in the same step also do the KVM_SET_GSI_ROUTING ioctl. This is unnecessary costly as the interface allows us to set multiple routes in one go. Let's first add all routes to the table store

[Qemu-devel] [PATCH 13/23] s390/sclp: temporarily fix unassignment/reassignment of memory subregions

2015-08-31 Thread Cornelia Huck
From: David Hildenbrand Commit 374f2981d1f1 ("memory: protect current_map by RCU") broke unassignment of standby memory on s390x. Looks like that the new parallelism allows races with our (semi broken) memory hotplug code. The flatview_unref() can now be executed after our unparenting. Therefore

[Qemu-devel] [PATCH 18/23] s390: disallow memory hotplug for the s390-virtio machine

2015-08-31 Thread Cornelia Huck
From: David Hildenbrand That machine type doesn't currently support memory hotplug, so let's abort if it is requested. Reason is, that the virtio queues are allocated for now at the end of the initial ram - extending the ram is therefore not possible. Reviewed-by: Matthew Rosato Signed-off-by:

[Qemu-devel] [PATCH 14/23] s390/sclp: introduce a root sclp device

2015-08-31 Thread Cornelia Huck
From: David Hildenbrand Let's create a root sclp device, which has other sclp devices as children (e.g. the event facility for now) and can later be used for migration of sclp specific attributes and setup of memory. Reviewed-by: Matthew Rosato Signed-off-by: David Hildenbrand Signed-off-by: C

[Qemu-devel] [PATCH 04/23] s390x/css: start with cleared cstat/dstat

2015-08-31 Thread Cornelia Huck
When executing the start function, we should start with a clear state regarding subchannel and device status; it is easy to forget updating one of them after the ccw has been processed. Note that we don't need to care about resetting the various control fields: They are cleared by tsch(), and if t

[Qemu-devel] [PATCH 07/23] pc-bios/s390-ccw: rebuild image

2015-08-31 Thread Cornelia Huck
Contains: - Device detection in higher subchannel sets Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw.img | Bin 13784 -> 13856 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-bios/s390-ccw.img b/pc-bios/s390-ccw.img index f64380a972f280d66a4df03f029e4e1d42da292d..0c54

[Qemu-devel] [PATCH 21/23] s390: unify allocation of initial memory

2015-08-31 Thread Cornelia Huck
From: David Hildenbrand Now that the calculation of the initial memory is hidden in the sclp device, we can unify the allocation of the initial memory. The remaining ugly part is the reserved memory for the virtio queues, but that can be cleaned up later. Reviewed-by: Matthew Rosato Signed-off

[Qemu-devel] [PATCH 23/23] s390/sclp: simplify calculation of rnmax

2015-08-31 Thread Cornelia Huck
From: David Hildenbrand rnmax can be directly calculated using machine->maxram_size. Reviewed-by: Matthew Rosato Signed-off-by: David Hildenbrand Signed-off-by: Cornelia Huck --- hw/s390x/sclp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/s390x/sclp.c b/hw/s390x

[Qemu-devel] [PATCH 10/23] sclp/s390: rework sclp cpu hotplug device notification

2015-08-31 Thread Cornelia Huck
From: David Hildenbrand Let's get rid of this strange local variable + irq logic and work directly on the QOM. (hint: what happens if two such devices are created?) We could introduce proper QOM class + state for the cpu hotplug device, however that would result in too much overhead for a simple

[Qemu-devel] [PATCH 12/23] s390/sclp: replace sclp event types with proper defines

2015-08-31 Thread Cornelia Huck
From: David Hildenbrand Introduce TYPE_SCLP_QUIESCE and make use of it. Also use TYPE_SCLP_CPU_HOTPLUG where applicable. Reviewed-by: Matthew Rosato Signed-off-by: David Hildenbrand Signed-off-by: Cornelia Huck --- hw/s390x/event-facility.c | 2 +- hw/s390x/sclpcpu.c|

[Qemu-devel] [PATCH 06/23] pc-bios/s390-ccw: Device detection in higher subchannel sets

2015-08-31 Thread Cornelia Huck
From: Alexander Yarygin If no bootdevice was specified, we try to autodetect a suitable IPL device. Current code only searched in subchannel set 0; extend this search to higher subchannel sets as well. Signed-off-by: Alexander Yarygin Reviewed-by: David Hildenbrand Reviewed-by: Cornelia Huck

[Qemu-devel] [PATCH 20/23] s390: move memory calculation into the sclp device

2015-08-31 Thread Cornelia Huck
From: David Hildenbrand The restrictions for memory calculation belong to the sclp device. Let's move the calculation to that point, so we are able to unify it for both s390 machines. The sclp device is the first device to be initialized. It performs the calculation and safely stores it in the m

[Qemu-devel] [PATCH 15/23] s390/sclp: move sclp_execute related functions into the SCLP class

2015-08-31 Thread Cornelia Huck
From: David Hildenbrand Let's move the sclp_execute related functions into the SCLP class and pass the device state as parameter, so we have easy access to the SCLPDevice later on. Reviewed-by: Matthew Rosato Signed-off-by: David Hildenbrand Signed-off-by: Cornelia Huck --- hw/s390x/sclp.c

[Qemu-devel] [PATCH 09/23] s390x/gdb: support reading/writing of control registers

2015-08-31 Thread Cornelia Huck
From: David Hildenbrand Let's support reading and writing of control registers for kvm and tcg. We have to take care of flushing the tlb (tcg) and pushing the changed registers into kvm. Reviewed-by: Christian Borntraeger Signed-off-by: David Hildenbrand Signed-off-by: Cornelia Huck --- con

[Qemu-devel] [PATCH 22/23] s390/sclp: store the increment_size in the sclp device

2015-08-31 Thread Cornelia Huck
From: David Hildenbrand Let's calculate it once and reuse it. Suggested-by: Matthew Rosato Reviewed-by: Matthew Rosato Signed-off-by: David Hildenbrand Signed-off-by: Cornelia Huck --- hw/s390x/sclp.c | 20 +++- include/hw/s390x/sclp.h | 1 + 2 files changed, 4 inse

Re: [Qemu-devel] [snabb-devel] Re: [PATCH v6 1/2] vhost-user: add multi queue support

2015-08-31 Thread Michael S. Tsirkin
On Mon, Aug 31, 2015 at 08:29:39AM +, Ouyang, Changchun wrote: > > > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Sunday, August 30, 2015 2:16 PM > > To: Ouyang, Changchun > > Cc: snabb-de...@googlegroups.com; qemu-devel@nongnu.org; > > thibaut.

[Qemu-devel] PING: [PATCH v12 0/5] vGICv3 support

2015-08-31 Thread Pavel Fedin
Knock-knock! Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia > -Original Message- > From: qemu-devel-bounces+p.fedin=samsung@nongnu.org [mailto:qemu-devel- > bounces+p.fedin=samsung@nongnu.org] On Behalf Of Pavel Fedin > Sent: Wednesday, Augu

Re: [Qemu-devel] [PATCH] pci-testdev: add nodata test

2015-08-31 Thread Michael S. Tsirkin
On Mon, Aug 31, 2015 at 04:01:11PM +0800, Jason Wang wrote: > > > On 08/31/2015 03:28 PM, Michael S. Tsirkin wrote: > > On Mon, Aug 31, 2015 at 11:04:42AM +0800, Jason Wang wrote: > >> > >> On 08/27/2015 06:30 PM, Michael S. Tsirkin wrote: > >>> Add nodata test where data length is ignored. > >>>

Re: [Qemu-devel] [PATCH COLO-Frame v8 31/34] COLO: Add colo-set-checkpoint-period command

2015-08-31 Thread zhanghailiang
On 2015/8/29 6:26, Eric Blake wrote: On 07/29/2015 02:45 AM, zhanghailiang wrote: With this command, we can control the period of checkpoint, if there is no comparison of net packets. Cc: Luiz Capitulino Cc: Eric Blake Cc: Markus Armbruster Signed-off-by: zhanghailiang Signed-off-by: Li Zhi

Re: [Qemu-devel] [PATCH v8] hw/arm/virt: Add high MMIO PCI region, 512G in size

2015-08-31 Thread Igor Mammedov
On Mon, 24 Aug 2015 10:31:54 +0300 Pavel Fedin wrote: > This large region is necessary for some devices like ivshmem and video cards > 32-bit kernels can be built without LPAE support. In this case such a kernel > will not be able to use PCI controller which has windows in high addresses. > In or

Re: [Qemu-devel] [PATCH] target-i386: Enable "check" mode by default

2015-08-31 Thread Igor Mammedov
On Wed, 26 Aug 2015 13:50:25 -0300 Eduardo Habkost wrote: > Current default behavior of QEMU is to silently disable features that > are not supported by the host when a CPU model is requested in the > command-line. This means that in addition to risking breaking guest ABI > by default, we are sil

Re: [Qemu-devel] [PATCH for-2.5 0/4] vhost: cleanups and switching to sorted memory map

2015-08-31 Thread Igor Mammedov
On Wed, 12 Aug 2015 10:33:47 +0300 "Michael S. Tsirkin" wrote: > On Tue, Jul 28, 2015 at 04:52:49PM +0200, Igor Mammedov wrote: > > making memory map a sorted array helps to simplify > > and speed up lookup/insertion and deletion ops on it. > > It also makes insertion/deteletion code easier to re

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 3/8] scripts: Submit changes while updating linux headers

2015-08-31 Thread Laurent Vivier
On 28/08/2015 14:30, Gavin Shan wrote: > On Fri, Aug 28, 2015 at 01:50:47PM +0200, Laurent Vivier wrote: >> On 28/08/2015 09:15, Gavin Shan wrote: >>> This submits changes with formatted commit log while updating Linux >>> headers using scripts/update-linux-headers.sh. >>> >>> Signed-off-by: Gavi

Re: [Qemu-devel] Mount image file feature

2015-08-31 Thread Programmingkid
On Aug 31, 2015, at 3:52 AM, Markus Armbruster wrote: > Programmingkid writes: > >> On Aug 29, 2015, at 12:39 PM, Max Reitz wrote: >> >>> On 29.08.2015 17:57, Programmingkid wrote: On Aug 29, 2015, at 11:40 AM, Max Reitz wrote: > On 27.08.2015 03:05, G 3 wrote: >> I wa

Re: [Qemu-devel] [PATCH v10 1/4] apic: map APIC's MMIO region at each CPU's address space

2015-08-31 Thread Igor Mammedov
On Mon, 31 Aug 2015 17:47:44 +0800 Zhu Guihua wrote: > From: Chen Fan > > After ICC bus/bridge have been removed, APIC MMIO area could > not be mapped into sysbus MMIO any more. > So replace mapping APIC at global system address space with > mapping it at per-CPU address spaces. Whe

Re: [Qemu-devel] [PATCH v10 2/4] x86: use new method to correct reset sequence

2015-08-31 Thread Igor Mammedov
On Mon, 31 Aug 2015 17:47:45 +0800 Zhu Guihua wrote: > Something must be occur during reset of the X86 platform in a specific > order. For example, some devices (such as hpet, rtc) reset will send > irq to apic, this will update the apic register. In order to ensure > the apic register could be s

[Qemu-devel] rfc: vhost user enhancements for vm2vm communication

2015-08-31 Thread Michael S. Tsirkin
Hello! During the KVM forum, we discussed supporting virtio on top of ivshmem. I have considered it, and came up with an alternative that has several advantages over that - please see below. Comments welcome. - Existing solutions to userspace switching between VMs on the same host are vhost-u

Re: [Qemu-devel] [PATCH v3 2/2] rtl8139: correctly track full receive buffer in standard mode

2015-08-31 Thread Vlad Yasevich
On 08/31/2015 05:59 AM, Jason Wang wrote: > > > On 08/28/2015 10:06 PM, Vladislav Yasevich wrote: >> In standard operation mode, when the receive ring buffer >> is full, the buffer actually appears empty to the driver since >> the RxBufAddr (the location we wirte new data to) and RxBufPtr >> (the

Re: [Qemu-devel] [PATCH v3 4/8] s390x: Dump storage keys qmp command

2015-08-31 Thread Eric Blake
On 08/31/2015 05:00 AM, Cornelia Huck wrote: > From: "Jason J. Herne" > > Provide a dump-skeys qmp command to allow the end user to dump storage > keys. This is useful for debugging problems with guest storage key support > within Qemu and for guest operating system developers. > > Reviewed-by:

Re: [Qemu-devel] [PATCH] target-i386: Enable "check" mode by default

2015-08-31 Thread Eduardo Habkost
On Mon, Aug 31, 2015 at 02:20:54PM +0200, Igor Mammedov wrote: > On Wed, 26 Aug 2015 13:50:25 -0300 > Eduardo Habkost wrote: > > Current default behavior of QEMU is to silently disable features that > > are not supported by the host when a CPU model is requested in the > > command-line. This means

Re: [Qemu-devel] [PATCH v8 03/11] netfilter: add netfilter_{add|del} commands

2015-08-31 Thread Eric Blake
On 08/31/2015 03:01 AM, Yang Hongyang wrote: > > Sorry that I don't know much about the QAPI part, I have a question, in > previous reply, Eric suggested: > > > > Then this becomes something like: > > > > { 'command': 'netfilter-add', 'data': 'NetFilter' } > If we do this (which req

Re: [Qemu-devel] [snabb-devel] Re: [PATCH v6 1/2] vhost-user: add multi queue support

2015-08-31 Thread Eric Blake
On 08/31/2015 05:30 AM, Michael S. Tsirkin wrote: > On Mon, Aug 31, 2015 at 08:29:39AM +, Ouyang, Changchun wrote: >>> On Wed, Aug 12, 2015 at 02:25:41PM +0800, Ouyang Changchun wrote: Based on patch by Nikolay Nikolaev: When you start to have this much nested quoting,... >>

Re: [Qemu-devel] [PATCH COLO-Frame v8 19/34] qmp event: Add event notification for COLO error

2015-08-31 Thread Eric Blake
On 08/31/2015 03:27 AM, zhanghailiang wrote: >>> +Data: None. >>> + >>> + - "mode": COLO mode, 'primary' or 'secondary' >>> + - "error": Error message (json-string, optional) The "Data: None" designation is inconsistent with the fact that you do provide data. >>> + >>> +Example: >>> + >>> +{"tim

Re: [Qemu-devel] [PATCH v3 4/8] s390x: Dump storage keys qmp command

2015-08-31 Thread Cornelia Huck
On Mon, 31 Aug 2015 08:48:03 -0600 Eric Blake wrote: > On 08/31/2015 05:00 AM, Cornelia Huck wrote: > > From: "Jason J. Herne" > > > > Provide a dump-skeys qmp command to allow the end user to dump storage > > keys. This is useful for debugging problems with guest storage key support > > within

Re: [Qemu-devel] [PATCH v2 2/5] fw_cfg DMA interface documentation

2015-08-31 Thread Kevin O'Connor
On Mon, Aug 31, 2015 at 11:10:14AM +0200, Marc Marí wrote: > Add fw_cfg DMA interface specification in the documentation. > > Based on Gerd Hoffman's initial implementation. Thanks for working on this. [...] > += Guest-side DMA Interface = > + > +If bit 1 of the feature bitmap is set, the DMA in

[Qemu-devel] [PATCH 31/31] qapi: Simplify error reporting for array types

2015-08-31 Thread Markus Armbruster
check_type() first checks and peels off the array type, then checks the element type. For two out of four error messages, it takes pains to report errors for "array of T" instead of just T. Odd. Let's examine the errors. * Unknown element type, e.g. tests/qapi-schema/args-array-unknown.json:

[Qemu-devel] [PATCH 27/31] qapi: Drop one of two "simple union must not have base" checks

2015-08-31 Thread Markus Armbruster
The first check ensures the second one can't trigger. Drop the first one, because the second one is in a more logical place, and emits a nicer error message. Signed-off-by: Markus Armbruster --- scripts/qapi.py | 8 tests/qapi-schema/union-base-no-disc

[Qemu-devel] [PATCH 29/31] tests/qapi-schema: Cover non-string, non-dictionary members

2015-08-31 Thread Markus Armbruster
We always report "should be a dictionary" then. This is misleading: when allow_dict, it can be a dictionary or a type name string, else it can only be a type name. Signed-off-by: Markus Armbruster --- tests/Makefile | 2 ++ tests/qapi-schema/args-invalid.err

[Qemu-devel] [PATCH 28/31] tests/qapi-schema: Cover two more syntax errors

2015-08-31 Thread Markus Armbruster
Syntax error coverage should now be complete. Signed-off-by: Markus Armbruster --- tests/Makefile | 1 + tests/qapi-schema/leading-comma-list.err| 1 + tests/qapi-schema/leading-comma-list.exit | 1 + tests/qapi-schema/leading-comma-list.json | 2 ++ tests/qa

[Qemu-devel] [PATCH 30/31] qapi: Fix errors for non-string, non-dictionary members

2015-08-31 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- scripts/qapi.py | 10 ++ tests/qapi-schema/args-invalid.err | 2 +- tests/qapi-schema/args-invalid.json | 1 - tests/qapi-schema/struct-data-invalid.err| 2 +- tests/qapi-schema/struct-data-invalid

Re: [Qemu-devel] [PATCH v2 3/5] Implement fw_cfg DMA interface

2015-08-31 Thread Kevin O'Connor
On Mon, Aug 31, 2015 at 11:10:15AM +0200, Marc Marí wrote: > Based on the specifications on docs/specs/fw_cfg.txt > > This interface is an addon. The old interface can still be used as usual. > > Based on Gerd Hoffman's initial implementation. > > Signed-off-by: Marc Marí > --- > hw/arm/virt.c

Re: [Qemu-devel] [PATCH 27/31] qapi: Drop one of two "simple union must not have base" checks

2015-08-31 Thread Eric Blake
On 08/31/2015 09:55 AM, Markus Armbruster wrote: > The first check ensures the second one can't trigger. Drop the first > one, because the second one is in a more logical place, and emits a > nicer error message. Second one added in 44bd1276; first one in older a8d4a2e4 (back before 'alternate' e

Re: [Qemu-devel] [PATCH 28/31] tests/qapi-schema: Cover two more syntax errors

2015-08-31 Thread Eric Blake
On 08/31/2015 09:55 AM, Markus Armbruster wrote: > Syntax error coverage should now be complete. > > Signed-off-by: Markus Armbruster > --- > tests/Makefile | 1 + > tests/qapi-schema/leading-comma-list.err| 1 + > tests/qapi-schema/leading-comma-list.exit | 1

Re: [Qemu-devel] [PATCH 29/31] tests/qapi-schema: Cover non-string, non-dictionary members

2015-08-31 Thread Eric Blake
On 08/31/2015 09:55 AM, Markus Armbruster wrote: > We always report "should be a dictionary" then. This is misleading: > when allow_dict, it can be a dictionary or a type name string, else it > can only be a type name. This exposes the current (poor) conditions; then it will be obvious what impro

  1   2   3   >