[Qemu-devel] [PATCH v4 1/4] iotests: fix exclusion option

2015-08-25 Thread John Snow
If you are running out-of-tree, the -x option to exclude a certain iotest is broken. Replace porcelain usage of ls with a sturdier awk command. Reviewed-by: Fam Zheng Signed-off-by: John Snow --- tests/qemu-iotests/common | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/te

[Qemu-devel] [PATCH v4 4/4] iotests: clarify help text

2015-08-25 Thread John Snow
Split the help text to highlight the groups of options a little better, carving out a clear "format" and "protocols" section. Reviewed-by: Fam Zheng Signed-off-by: John Snow --- tests/qemu-iotests/common | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests

[Qemu-devel] [PATCH v4 2/4] iotests: Add dependency info to groups list

2015-08-25 Thread John Snow
Add a few external dependency groups to the iotests groups list, such as "qemu", "nbd", and "scm". This will assist us in knowing which tests need to be re-run when those dependencies are updated, or by helping us to avoid tests that we know are broken for a certain file. qemu-img and qemu-io are

Re: [Qemu-devel] [PATCH v2 10/12] qga: add an optionnal qemu-ga.conf system configuration

2015-08-25 Thread Michael Roth
Quoting marcandre.lur...@redhat.com (2015-08-25 17:10:22) > From: Marc-André Lureau > > Learn to configure the agent with a system configuration. > > This may simplify command-line handling, especially when the blacklist > is long. > > Among the other benefits, this may standardize the configur

Re: [Qemu-devel] [PATCH v2 11/12] qga: add --dump-conf option

2015-08-25 Thread Michael Roth
Quoting marcandre.lur...@redhat.com (2015-08-25 17:10:23) > From: Marc-André Lureau > > This new option allows to review the agent configuration, > and ease the task of writing a configuration file. > > Signed-off-by: Marc-André Lureau > --- > qga/main.c | 62 > +++

Re: [Qemu-devel] [PATCH v2 12/12] qga: start a man page

2015-08-25 Thread Michael Roth
Quoting marcandre.lur...@redhat.com (2015-08-25 17:10:24) > From: Marc-André Lureau > > Add a simple man page for the qemu agent. > > Signed-off-by: Marc-André Lureau Reviewed-by: Michael Roth > --- > Makefile | 14 +- > qemu-doc.texi | 6 +++ > qemu-ga.texi | 136 > ++

Re: [Qemu-devel] [PATCH v2 10/12] qga: add an optionnal qemu-ga.conf system configuration

2015-08-25 Thread Marc-André Lureau
Hi On Wed, Aug 26, 2015 at 1:09 AM, Michael Roth wrote: > We should probably do this in init_dfl_pathnames() for consistency. QGA_FSFREEZE_HOOK_DEFAULT is also initialized here in init_dfl_pathnames(), it depends on the value of get_local_state_pathname() while here it's static. >> >> static

Re: [Qemu-devel] [PATCH v2 10/12] qga: add an optionnal qemu-ga.conf system configuration

2015-08-25 Thread Michael Roth
Quoting Marc-André Lureau (2015-08-25 18:18:16) > Hi > > On Wed, Aug 26, 2015 at 1:09 AM, Michael Roth > wrote: > > We should probably do this in init_dfl_pathnames() for consistency. > > QGA_FSFREEZE_HOOK_DEFAULT is also initialized here > > in init_dfl_pathnames(), it depends on the value of

Re: [Qemu-devel] [PATCH v2 11/12] qga: add --dump-conf option

2015-08-25 Thread Marc-André Lureau
Hi On Wed, Aug 26, 2015 at 1:13 AM, Michael Roth wrote: > Since we have the list_join() helper to convert config->blacklist, it > makes me wonder if there's really any need to add/init config->bliststr > in the previous patch. It is just to keep the string in memory. split_list() doesn't dup the

[Qemu-devel] [PATCH 1/1] ide: unify io_buffer_offset increments

2015-08-25 Thread John Snow
IDEState's io_buffer_offset was originally added to keep track of offsets in AHCI rather exclusively, but it was added to IDEState instead of an AHCI-specific structure. AHCI fakes all PIO transfers using DMA and a scatter-gather list. When the core or atapi layers invoke HBA-specific mechanisms f

[Qemu-devel] [PATCH 0/1] ahci: fix ATAPI PIO

2015-08-25 Thread John Snow
Fixes ATAPI PIO for transfers of greater than one sector, and centralizes the fix applied for HDD PIO transfers all in one place, finally. For convenience, this branch is available at: https://github.com/jnsnow/qemu.

Re: [Qemu-devel] [PATCH v6 3/8] scripts: Submit changes while updating linux headers

2015-08-25 Thread Gavin Shan
On Tue, Aug 25, 2015 at 04:09:22PM +0100, Peter Maydell wrote: >On 25 August 2015 at 00:58, Gavin Shan wrote: >> On Mon, Aug 24, 2015 at 03:08:33PM +0100, Peter Maydell wrote: >>>On 24 August 2015 at 13:03, Gavin Shan wrote: +cd $to +name=$(git config --get user.name) +

Re: [Qemu-devel] [Qemu-ppc] [PATCH v6 7/8] sPAPR: Support RTAS call ibm, {open, close}-errinjct

2015-08-25 Thread Gavin Shan
On Tue, Aug 25, 2015 at 04:07:35PM +0200, Thomas Huth wrote: >On 24/08/15 14:03, Gavin Shan wrote: >> This supports RTAS calls "ibm,{open,close}-errinjct" to manupliate >> the token, which is passed to RTAS call "ibm,errinjct" to indicate >> the valid context for error injection. Each VM is permitt

[Qemu-devel] [PATCH 2/9] i8257: remove cpu_request_exit irq

2015-08-25 Thread Paolo Bonzini
This is unused. cpu_exit now is almost exclusively an internal function to the CPU execution loop. The next patch will change the remaining occurrences to qemu_cpu_kick, making it truly internal. Signed-off-by: Paolo Bonzini --- hw/dma/i82374.c | 5 + hw/dma/i8257.c | 13

[Qemu-devel] [PATCH 1/9] i8257: rewrite DMA_schedule to avoid hooking into the CPU loop

2015-08-25 Thread Paolo Bonzini
The i8257 DMA controller uses an idle bottom half, which by default does not cause the main loop to exit. Therefore, the DMA_schedule function is there to ensure that the CPU relinquishes the iothread mutex to the iothread. However, this is not enough since the iothread will call aio_compute_time

[Qemu-devel] [PATCH 4/9] remove qemu/tls.h

2015-08-25 Thread Paolo Bonzini
TLS is now required on all platforms, so DECLARE_TLS/DEFINE_TLS is not needed anymore. Removing it does not break Windows because of the previous patch. Signed-off-by: Paolo Bonzini --- exec.c | 2 +- include/qemu/tls.h | 52 inc

[Qemu-devel] [PATCH v2 0/9] tcg: signal-free qemu_cpu_kick

2015-08-25 Thread Paolo Bonzini
This version of the signal-free qemu_cpu_kick patches is, ehm, much better. Variable are accessed either with Java-style volatiles or protected by memory barriers, and the cleanups go further by removing qemu/tls.h and C volatiles. The logic is relatively simple. The I/O thread does (letters in

[Qemu-devel] [PATCH 6/9] tcg: synchronize cpu->exit_request and cpu->tcg_exit_req accesses

2015-08-25 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- cpu-exec.c | 6 +- qom/cpu.c | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/cpu-exec.c b/cpu-exec.c index 7fcc46f..2128bf1 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -542,8 +542,12 @@ int cpu_exec(CPUState *cpu)

[Qemu-devel] [PATCH 3/9] tcg: introduce tcg_current_cpu

2015-08-25 Thread Paolo Bonzini
This is already useful on Windows in order to remove tls.h, because accesses to current_cpu are done from a different thread on that platform. It will be used on POSIX platforms as soon TCG stops using signals to interrupt the execution of translated code. Signed-off-by: Paolo Bonzini --- cpu-e

[Qemu-devel] [PATCH 9/9] tcg: signal-free qemu_cpu_kick

2015-08-25 Thread Paolo Bonzini
Signals are slow and do not exist on Win32. The previous patches have done most of the legwork to introduce memory barriers (some of them were even there already for the sake of Windows!) and we can now set the flags directly in the iothread. qemu_cpu_kick_thread is not used anymore on TCG, since

[Qemu-devel] [PATCH 5/9] tcg: assign cpu->current_tb in a simpler place

2015-08-25 Thread Paolo Bonzini
TCG has not been reading cpu->current_tb from signal handlers for years. The code that synchronized cpu_exec with the signal handler is not needed anymore. Signed-off-by: Paolo Bonzini --- cpu-exec.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/cpu-exec.c b/cpu-ex

[Qemu-devel] [PATCH 7/9] tcg: synchronize exit_request and tcg_current_cpu accesses

2015-08-25 Thread Paolo Bonzini
Synchronize the remaining pair of accesses in cpu_signal. The wrongly-ordered accesses in cpu_signal are currently not an issue on Windows because they execute atomically between SuspendProcess and ResumeProcess. Only cpu_exec can be split (and the newly introduced atomic_mb_read would be needed

[Qemu-devel] [PATCH 8/9] use qemu_cpu_kick instead of cpu_exit or qemu_cpu_kick_thread

2015-08-25 Thread Paolo Bonzini
Use the same API to trigger interruption of a CPU, no matter if under TCG or KVM. There is no difference: these calls come from the CPU thread, so the qemu_cpu_kick calls will send a signal to the running thread and it will be processed synchronously, just like a call to cpu_exit. The only differ

Re: [Qemu-devel] [PATCH 3/4] linux-user: call rcu_(un)register_thread on thread creation/deletion

2015-08-25 Thread Paolo Bonzini
On 25/08/2015 02:41, Emilio G. Cota wrote: > Note that the right place to call rcu_register_thread() is > do_cpu_loop() and not just in clone_func(), since the > original 'main' thread needs to call rcu_register_thread() > as well. > > Signed-off-by: Emilio G. Cota It doesn't actually, see rcu

Re: [Qemu-devel] [RFC 35/38] cputlb: use cpu_tcg_sched_work for tlb_flush_all

2015-08-25 Thread Paolo Bonzini
- Original Message - > From: "Emilio G. Cota" > To: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, mt...@greensocs.com, "guillaume delbergue" > , "alex > bennee" , "mark burton" , > "a rigo" > , "Frederic Konrad" > Sent: Wednesday, August 26, 2015 12:31:22 AM > Subject: Re: [RFC 35/38]

[Qemu-devel] [PATCH] vhost-scsi: fix wrong vhost-scsi firmware path

2015-08-25 Thread arei.gonglei
From: Gonglei vhost-scsi bootindex does't work because Qemu passes wrong fireware path to seabios. before: /pci@i0cf8/scsi@7channel@0/vhost-scsi@0,0 after applying the patch: /pci@i0cf8/scsi@7/channel@0/vhost-scsi@0,0 Reported-by: Subo Signed-off-by: Gonglei --- hw/scsi/vhost-scsi.c | 2

Re: [Qemu-devel] [PATCH] vhost-scsi: fix wrong vhost-scsi firmware path

2015-08-25 Thread Gonglei
On 2015/8/26 9:52, arei.gong...@huawei.com wrote: > From: Gonglei > > vhost-scsi bootindex does't work because Qemu passes > wrong fireware path to seabios. > > before: > /pci@i0cf8/scsi@7channel@0/vhost-scsi@0,0 > after applying the patch: > /pci@i0cf8/scsi@7/channel@0/vhost-scsi@0,0 > > R

[Qemu-devel] [FIX PATCH] spapr_rtas: Prevent QEMU crash during hotplug without a prior device_add

2015-08-25 Thread Bharata B Rao
If drmgr is used in the guest to hotplug a device before a device_add has been issued via the QEMU monitor, QEMU segfaults in configure_connector call. This occurs due to accessing of NULL FDT which otherwise would have been created and associated with the DRC during device_add command. Check for

Re: [Qemu-devel] [RFC PATCH v0 1/3] pc-dimm: Add a field to PCDIMMDevice to mark device deletion state

2015-08-25 Thread Bharata B Rao
On Mon, Aug 24, 2015 at 09:30:35PM -0500, Michael Roth wrote: > Quoting Bharata B Rao (2015-08-19 01:56:09) > > Add a field to PCDIMMDevice to note that the device has been marked > > for removal. This will be used by PowerPC memory hotplug code to > > honour the LMB removal requests of only those

Re: [Qemu-devel] [PATCH 5/6] virtio-pci: introduce pio notification capability for modern device

2015-08-25 Thread Jason Wang
On 08/25/2015 07:48 PM, Michael S. Tsirkin wrote: > On Fri, Aug 21, 2015 at 05:05:49PM +0800, Jason Wang wrote: >> > We used to use mmio for notification. This could be slow on some arch >> > (e.g on x86 without EPT). So this patch introduces pio bar and a pio >> > notification cap for modern dev

Re: [Qemu-devel] [PATCH v2 RFC 0/8] block: persistent dirty bitmaps

2015-08-25 Thread Vladimir Sementsov-Ogievskiy
On 12.06.2015 13:36, Stefan Hajnoczi wrote: On Fri, Jun 12, 2015 at 12:58:35PM +0300, Denis V. Lunev wrote: On 11/06/15 23:06, Stefan Hajnoczi wrote: The load/store API is not scalable when bitmaps are 1 MB or larger. For example, a 500 GB disk image with 64 KB granularity requires a 1 MB bitm

Re: [Qemu-devel] QEMU produces invalid JSON due to locale-dependent code

2015-08-25 Thread Gerd Hoffmann
Hi, > > It seems the only thing that we really care about being localized is > > the messages catalogue, so the GTK UI gets internationalization in > > its menus / dialogs / etc. As such I think that we should do the > > opposite of (C). ie run every LC_* in the C locale, except for > > LC_MESSA

<    1   2   3