From: "Jason J. Herne"
Provide a dump-skeys qmp command to allow the end user to dump storage
keys. This is useful for debugging problems with guest storage key support
within Qemu and for guest operating system developers.
Reviewed-by: Thomas Huth
Reviewed-by: David Hildenbrand
Signed-off-by:
From: "Jason J. Herne"
Routines to save/load guest storage keys are provided. register_savevm is
called to register them as migration handlers.
We prepare the protocol to support more complex parameters. So we will
later be able to support standby memory (having empty holes), compression
and "st
From: "Jason J. Herne"
Add dump-skeys command to the human monitor.
Reviewed-by: Thomas Huth
Reviewed-by: David Hildenbrand
Signed-off-by: Jason J. Herne
Signed-off-by: Cornelia Huck
---
hmp-commands.hx | 16
hw/s390x/s390-skeys.c | 12
On Fri, Aug 14, 2015 at 10:52:03PM +0800, Xiao Guangrong wrote:
> @@ -257,14 +258,91 @@ static void build_nfit_table(GSList *device_list, char
> *buf)
> }
> }
>
> +struct dsm_buffer {
> +/* RAM page. */
> +uint32_t handle;
> +uint8_t arg0[16];
> +uint32_t arg1;
> +uint3
On Fri, Aug 14, 2015 at 10:52:06PM +0800, Xiao Guangrong wrote:
> +#ifdef NVDIMM_DEBUG
> +#define nvdebug(fmt, ...) fprintf(stderr, "nvdimm: " fmt, ## __VA_ARGS__)
> +#else
> +#define nvdebug(...)
> +#endif
The following allows the compiler to check format strings and syntax
check the argument exp
On 08/25/2015 05:42 AM, Michael S. Tsirkin wrote:
> On Wed, Aug 19, 2015 at 09:30:20AM -0700, Eduardo Habkost wrote:
>> On Wed, Aug 19, 2015 at 10:55:26AM +0100, Dr. David Alan Gilbert wrote:
>>> * Eduardo Habkost (ehabk...@redhat.com) wrote:
Migration with q35 was not possible before commit
On Mon, Aug 24, 2015 at 11:54:48AM +0200, Markus Armbruster wrote:
> John Snow writes:
>
> > On 08/19/2015 02:55 AM, Dr. David Alan Gilbert wrote:
> >> * Eduardo Habkost (ehabk...@redhat.com) wrote:
> >>> Migration with q35 was not possible before commit
> >>> 04329029a8c539eb5f75dcb6d8b016f0c53a
On Fri, Aug 14, 2015 at 10:52:07PM +0800, Xiao Guangrong wrote:
> @@ -306,6 +354,18 @@ struct dsm_buffer {
> static ram_addr_t dsm_addr;
> static size_t dsm_size;
>
> +struct cmd_out_implemented {
QEMU coding style uses typedef struct {} CamelCase. Please follow this
convention in all user-de
On Fri, Aug 14, 2015 at 10:52:08PM +0800, Xiao Guangrong wrote:
> Function 4 is used to get Namespace lable size
s/lable/label/
On Fri, Aug 14, 2015 at 10:51:53PM +0800, Xiao Guangrong wrote:
> Changlog:
> - Use litten endian for DSM method, thanks for Stefan's suggestion
>
> - introduce a new parameter, @configdata, if it's false, Qemu will
> build a static and readonly namespace in memory and use it serveing
> for DS
On Fri, Aug 21, 2015 at 08:44:16PM +0300, Denis V. Lunev wrote:
> Denis has spent 6 years working with this format in Parallels and QEMU
> code was rewritten almost completely by his. Thus it would be quite
> natural to add him as a maintainer and point of contact.
>
> Patches are going to flow th
On 08/25/2015 10:10 AM, Cornelia Huck wrote:
> From: "Jason J. Herne"
>
> Provide a dump-skeys qmp command to allow the end user to dump storage
> keys. This is useful for debugging problems with guest storage key support
> within Qemu and for guest operating system developers.
>
> Reviewed-by:
Quoting Marc-André Lureau (2015-07-01 06:47:38)
> The function is going to be reused in a later patch.
>
> Signed-off-by: Marc-André Lureau
Reviewed-by: Michael Roth
> ---
> qga/main.c | 33 ++---
> 1 file changed, 22 insertions(+), 11 deletions(-)
>
> diff --git
Quoting Marc-André Lureau (2015-07-01 06:47:43)
> Once the options are populated, move the running state to
> a run_agent() function.
>
> Signed-off-by: Marc-André Lureau
> ---
> qga/main.c | 123
> +
> 1 file changed, 67 insertions(+)
Quoting Marc-André Lureau (2015-07-01 06:47:39)
> 'path' is already a global function, rename the variable since it's
> going to be in global scope in a later patch.
>
> Signed-off-by: Marc-André Lureau
I think I'd prefer something like 'channel_path' since we support
sockets as well. Looks good
On Tue, Aug 25, 2015 at 4:25 PM, Richard Henderson wrote:
> On 08/24/2015 11:44 PM, Artyom Tarasenko wrote:
>>
>> This is very surprising: the patch should have no effect on a sun4u
>> machine.
>
>
> Er, no, it should. The primary vector by which I expect improvement is via
> not encoding dmmu.mm
Quoting Marc-André Lureau (2015-07-01 06:47:42)
> Fill all default options during main(). This is a preparation patch
> to allow to dump the configuration.
>
> Signed-off-by: Marc-André Lureau
Reviewed-by: Michael Roth
> ---
> qga/main.c | 34 +-
> 1 file chang
Quoting Marc-André Lureau (2015-07-01 06:47:41)
> Move option parsing out of giant main().
>
> Signed-off-by: Marc-André Lureau
> ---
> qga/main.c | 41 +
> 1 file changed, 25 insertions(+), 16 deletions(-)
>
> diff --git a/qga/main.c b/qga/main.c
> index
On 25 August 2015 at 16:23, Peter Maydell wrote:
> Here's the ARM queue. I know I have a pile of backed-up code
> review to do, but I wanted to get these patches out rather
> than accumulating a fifty-patch queue...
>
> This is v2: only change is to drop the two smbios patches.
v2 applied to mast
Quoting Marc-André Lureau (2015-07-01 06:47:45)
> This new option allows to review the agent configuration,
> and ease the task of writing a configuration file.
>
> Signed-off-by: Marc-André Lureau
> ---
> qga/main.c | 46 +-
> 1 file changed, 45 inser
g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
for two reasons. One, it catches multiplication overflowing size_t.
Two, it returns T * rather than void *, which lets the compiler catch
more type errors.
This commit only touches allocations with size arguments of the form
si
Quoting Marc-André Lureau (2015-07-01 06:47:47)
> Add a simple man page for the qemu agent.
>
> Signed-off-by: Marc-André Lureau
> ---
> Makefile | 14 +-
> qemu-doc.texi | 6 +++
> qemu-ga.texi | 135
> ++
> 3 files changed,
On 18/08/2015 18:35, Petar Jovanovic wrote:
> From: Petar Jovanovic
>
> Instructions recip.{s|d} and rsqrt.{s|d} do not require 64-bit FPU neither
> they require any particular mode for its FPU. This patch removes the checks
> that may break a program that uses these instructions.
This seems to
When a function returns a null pointer on error and only on error, you
can do
if (!foo(foos, errp)) {
... handle error ...
}
instead of the more cumbersome
Error *err = NULL;
if (!foo(foos, &err)) {
error_propagate(errp, err);
... handle error ...
}
v1 was posted for possible inclusion into 2.4, but the maintainer
didn't bite ;-)
v2:
* Commit messages updated.
Markus Armbruster (2):
qom: Do not reuse errp after a possible error
qom: Fix invalid error check in property_get_str()
qom/object.c | 53
The argument for an Error **errp parameter must point to a null
pointer. If it doesn't, and an error happens, error_set() fails its
assertion.
Instead of
foo(foos, errp);
bar(bars, errp);
you need to do something like
Error *err = NULL;
foo(foos, &err);
if (err) {
On Mon, Aug 24, 2015 at 20:41:10 -0400, Emilio G. Cota wrote:
> Note: cannot compile bsd-user here (linux), please compile-test.
>
> Signed-off-by: Emilio G. Cota
> ---
(snip)
> diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
> index 5902614..751efd5 100644
> --- a/bsd-user/qemu.h
> +++ b/bsd-user
On 08/25/2015 07:37 AM, Dennis Luehring wrote:
Am 25.08.2015 um 16:25 schrieb Richard Henderson:
Er, no, it should. The primary vector by which I expect improvement is via not
encoding dmmu.mmu_primary_context into the TB flags. I.e. ASI_DMMU, which
sun4u certainly uses.
The fact that the pat
On 07/01/2015 02:47 PM, Marc-André Lureau wrote:
---
qga/qapi-schema.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index b446dc7..fbf983c 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -755,7 +755,7 @@
#
Paolo Bonzini writes:
> On 19/06/2015 10:09, Andreas Färber wrote:
>>> > -Lines are 80 characters; not longer.
>>> > +Lines should be 80 characters; try not to make them longer.
>>> > +
>>> > +Sometimes it is hard to do, especially when dealing with QEMU subsystems
>>> > +that use long function o
Programmingkid writes:
> On Aug 25, 2015, at 11:33 AM, Peter Maydell wrote:
>
>> On 25 August 2015 at 16:25, Programmingkid wrote:
>>> On Aug 25, 2015, at 8:42 AM, Markus Armbruster wrote:
Eric Blake writes:
> On 08/24/2015 12:53 PM, Programmingkid wrote:
>> +/* USB's max num
Am 25.08.2015 um 20:09 schrieb Richard Henderson:
On 08/25/2015 07:37 AM, Dennis Luehring wrote:
> Am 25.08.2015 um 16:25 schrieb Richard Henderson:
>> Er, no, it should. The primary vector by which I expect improvement is via
not
>> encoding dmmu.mmu_primary_context into the TB flags. I.e. AS
On Aug 25, 2015, at 2:30 PM, Markus Armbruster wrote:
> Programmingkid writes:
>
>> On Aug 25, 2015, at 11:33 AM, Peter Maydell wrote:
>>
>>> On 25 August 2015 at 16:25, Programmingkid
>>> wrote:
On Aug 25, 2015, at 8:42 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
Am 25.08.2015 um 20:09 schrieb Richard Henderson:
But you're right, it would be nice to put together a coherent set of
benchmarks. Ideally, a guest kernel plus minimal ramdisk with the tests
pre-loaded so that we can boot and run ./benchmark at the prompt. That's
the sort of thing we can easily
On 08/25/2015 11:39 AM, Markus Armbruster wrote:
> g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
> for two reasons. One, it catches multiplication overflowing size_t.
> Two, it returns T * rather than void *, which lets the compiler catch
> more type errors.
>
> This commi
On 08/25/2015 02:20 PM, Markus Armbruster wrote:
> Paolo Bonzini writes:
>
>> On 19/06/2015 10:09, Andreas Färber wrote:
> -Lines are 80 characters; not longer.
> +Lines should be 80 characters; try not to make them longer.
> +
> +Sometimes it is hard to do, especially when deal
W dniu 2015-08-25 o 07:52, Liang Li pisze:
This patch is for kvm live migration optimization, it fixes the issue which
commit 317b0a6d8ba tries to fix in another way, and it can reduce the live
migration VM downtime about 300us.
*This patch is not tested for the issue commit 317b0a6d8ba tries to
On Mon, Aug 24, 2015 at 22:30:03 -0400, Emilio G. Cota wrote:
> On Sun, Aug 23, 2015 at 18:04:46 -0700, Paolo Bonzini wrote:
> > On 23/08/2015 17:23, Emilio G. Cota wrote:
> (snip)
> > Applied, but in the end the spinlock will probably simply use a simple
> > test-and-test-and-set lock, or an MCS l
On 08/24/2015 01:36 PM, Sergey Fedorov wrote:
> Hi all,
>
> Seems there is a bug in ARM breakpoint emulation. I am not sure how to
> fix it and I would appreciate any suggestion. It is best illustrated by
> a simple test which sets up and enables an unlinked address match
> breakpoint but does not
On 07/01/2015 02:47 PM, Marc-André Lureau wrote:
The option parsing is going to be moved to a seperate function,
use exit() consistantly.
s/seperate/separate/
s/consistantly/consistently/
Signed-off-by: Marc-André Lureau
---
qga/main.c | 24
1 file changed, 12 inse
On Sun, Aug 23, 2015 at 18:09:48 -0700, Paolo Bonzini wrote:
> On 23/08/2015 17:23, Emilio G. Cota wrote:
> > Signed-off-by: Emilio G. Cota
> > ---
> > cpu-exec.c | 9 ++---
> > exec.c | 2 +-
> > hw/openrisc/cputimer.c | 2 +-
Hi Peter,
On 08/13/2015 12:35 PM, Peter Maydell wrote:
> This patch series implements support for semihosting for the
> 64-bit ARM instruction set.
>
> It owes a significant debt to the patches sent earlier
> by Christopher Covington (and with code written by Derek Hower).
> However, it is a full
muldiv64() is used to convert microseconds to nanoseconds.
Use qemu_clock_get_ns() instead of qemu_clock_get_us()
to avoid this operation.
Signed-off-by: Laurent Vivier
---
target-arm/helper.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/target-arm/helper.c b/tar
Originally, timers were ticks based, and it made sense to
add ticks to current time to know when to trigger an alarm.
But since commit:
7447545 change all other clock references to use nanosecond resolution accessors
All timers use nanoseconds and we need to convert ticks to nanoseconds, by
doin
Originally, timers were ticks based, and it made sense to
add ticks to current time to know when to trigger an alarm.
But since commit:
7447545 change all other clock references to use nanosecond resolution accessors
All timers use nanoseconds and we need to convert ticks to nanoseconds, by
doin
muldiv64() is used to convert nanoseconds to microseconds.
x = muldiv64(y, 100, get_ticks_per_sec());
As get_ticks_per_sec() is 10^9, it can be replaced by:
x = y / 1000;
Signed-off-by: Laurent Vivier
---
net/dump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --gi
Originally, timers were ticks based, and it made sense to
add ticks to current time to know when to trigger an alarm.
But since commit:
7447545 change all other clock references to use nanosecond resolution accessors
All timers use nanoseconds and we need to convert ticks to nanoseconds, by
doin
Originally, timers were ticks based, and it made sense to
add ticks to current time to know when to trigger an alarm.
But since commit:
7447545 change all other clock references to use nanosecond resolution accessors
All timers use nanoseconds and we need to convert ticks to nanoseconds, by
doin
hpet defines a clock period in femtoseconds but
then converts it to nanoseconds to use the internal
timers.
We can define the period in nanoseconds and use it
directly, this allows to remove muldiv64().
We only need to convert the period to femtoseconds
to put it in internal hpet capability regis
Originally, timers were ticks based, and it made sense to
add ticks to current time to know when to trigger an alarm.
But since commit:
7447545 change all other clock references to use nanosecond resolution accessors
All timers use nanoseconds and we need to convert ticks to nanoseconds.
As get
On Tue, Aug 25, 2015 at 1:44 PM, Laurent Vivier wrote:
> muldiv64() is used to convert microseconds to nanoseconds.
>
> Use qemu_clock_get_ns() instead of qemu_clock_get_us()
> to avoid this operation.
>
> Signed-off-by: Laurent Vivier
> ---
> target-arm/helper.c | 9 +++--
> 1 file changed,
On Sun, Aug 23, 2015 at 19:01:39 -0700, Paolo Bonzini wrote:
> On 23/08/2015 17:23, Emilio G. Cota wrote:
> > Otherwise after an exception we end up in a deadlock.
>
> Can you explain better the path that exits cpu_exec with the lock taken?
In fact I cannot :-) So please ignore this patch.
I wro
On 25/08/2015 23:11, Peter Crosthwaite wrote:
> On Tue, Aug 25, 2015 at 1:44 PM, Laurent Vivier wrote:
>> muldiv64() is used to convert microseconds to nanoseconds.
>>
>> Use qemu_clock_get_ns() instead of qemu_clock_get_us()
>> to avoid this operation.
>>
>> Signed-off-by: Laurent Vivier
>> --
On 8/25/15 22:28, Richard Henderson wrote:
> On 08/25/2015 06:12 AM, Chen Gang wrote:
Consider a bundle like
{ add r0, r0, r1 ; exch r2, r0, r3 }
In Chen's implementation, the writeback to r0 would occur before the
exception, and so the exch would happen to the w
On Sun, Aug 23, 2015 at 18:14:58 -0700, Paolo Bonzini wrote:
> On 23/08/2015 17:23, Emilio G. Cota wrote:
> > This paves the way for a lockless tb_find_fast.
> >
> > Signed-off-by: Emilio G. Cota
> > ---
(snip)
> > @@ -1707,12 +1735,14 @@ void tb_flush_jmp_cache(CPUState *cpu, target_ulong
> > a
Quoting Leonid Bloch (2015-08-03 12:54:23)
> This is done to follow the recommendations given here:
> https://msdn.microsoft.com/en-us/library/aa368269%28VS.85%29.aspx
>
> Signed-off-by: Leonid Bloch
> ---
> qga/installer/qemu-ga.wxs | 47
> ---
> 1
ping
On Tue, Jun 30, 2015 at 4:37 PM, Marc-André Lureau
wrote:
> Use NetUserSetInfo() to set the user password.
>
> This function is notoriously known to be problematic for users with EFS
> encrypted files. But the alternative, NetUserChangePassword() requires
> the old password. Nevertheless, Th
On Sun, Aug 23, 2015 at 18:07:04 -0700, Paolo Bonzini wrote:
> On 23/08/2015 17:24, Emilio G. Cota wrote:
> > Note that user-only uses mmap_lock for this.
> >
> > Signed-off-by: Emilio G. Cota
>
> Why is this needed? The RCU-like page_find should work just fine.
Ouch, you're right, forgot abou
Quoting Leonid Bloch (2015-08-03 12:54:20)
> The main purpose here is to fix a bug that caused the QEMU GA VSS service to
> be unregistered on reinstallation using the .msi file.
> Also, two fixes are introduced to the .wxs file, which is used to create the
> MSI with Wixl: GUID capitalization an
On Tue, Aug 25, 2015 at 7:43 PM, Michael Roth wrote:
> Quoting Marc-André Lureau (2015-07-01 06:47:47)
>> Add a simple man page for the qemu agent.
>>
>> Signed-off-by: Marc-André Lureau
>> ---
>> Makefile | 14 +-
>> qemu-doc.texi | 6 +++
>> qemu-ga.texi | 135
>>
On Tue, Aug 25, 2015 at 7:11 PM, Michael Roth wrote:
> I think we're missing fsfreeze_hook option here.
>
good catch
> To me it seems cleaner to actually create the GKeyFile from current
> options, then let GLib do all the work of generation a config file
> we can spit out (g_key_file_to_data()
Quoting Michael Roth (2015-08-25 16:48:25)
> Quoting Leonid Bloch (2015-08-03 12:54:23)
> > This is done to follow the recommendations given here:
> > https://msdn.microsoft.com/en-us/library/aa368269%28VS.85%29.aspx
> >
> > Signed-off-by: Leonid Bloch
> > ---
> > qga/installer/qemu-ga.wxs | 47
On Tue, Aug 25, 2015 at 6:51 PM, Michael Roth wrote:
> It's hard to draw the line between what should be in main() as opposed
> to run_agent(), but we have some s->frozen initialization happening
> here, and then the statefile-based setting s->frozen values being set
> in run_agent(), so at least
hi
On Tue, Aug 25, 2015 at 6:24 PM, Michael Roth wrote:
> Since we want to pass these around as a representation of the
> configuration state, I'd rather we package them into a GAConfig
> structure or something of the sort that and pass it around as arguments
> rather than as globals. Between par
hi
On Tue, Aug 25, 2015 at 5:55 PM, Michael Roth wrote:
> Quoting Marc-André Lureau (2015-07-01 06:47:39)
>> 'path' is already a global function, rename the variable since it's
>> going to be in global scope in a later patch.
>>
>> Signed-off-by: Marc-André Lureau
>
> I think I'd prefer somethin
> W dniu 2015-08-25 o 07:52, Liang Li pisze:
> > This patch is for kvm live migration optimization, it fixes the issue
> > which commit 317b0a6d8ba tries to fix in another way, and it can
> > reduce the live migration VM downtime about 300us.
> >
> > *This patch is not tested for the issue commit 3
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
qga/qapi-schema.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index 18e3cc3..6b0bd16 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -793,7 +793,7
From: Marc-André Lureau
Hi,
The following patches for the qemu agent add support for an optionnal
configuration file, and a man page.
Since v1:
- spelling fixes
- change device_path to channel_path
- moving config to GAConfig struct
- do check_is_frozen() during main
- use g_key_file_to_data()
From: Marc-André Lureau
The option parsing is going to be moved to a separate function,
use exit() consistently.
Signed-off-by: Marc-André Lureau
Reviewed-by: Denis V. Lunev
Reviewed-by: Eric Blake
---
qga/main.c | 24
1 file changed, 12 insertions(+), 12 deletions(-
From: Marc-André Lureau
The function is going to be reused in a later patch.
Signed-off-by: Marc-André Lureau
Reviewed-by: Michael Roth
---
qga/main.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/qga/main.c b/qga/main.c
index 10bb2f7.
From: Marc-André Lureau
Move option parsing out of giant main().
Signed-off-by: Marc-André Lureau
---
qga/main.c | 165 +++--
1 file changed, 96 insertions(+), 69 deletions(-)
diff --git a/qga/main.c b/qga/main.c
index 83b7804..a8dda38 1
From: Marc-André Lureau
Fill all default options during main(). This is a preparation patch
to allow to dump the configuration.
Signed-off-by: Marc-André Lureau
Reviewed-by: Michael Roth
---
qga/main.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-
From: Marc-André Lureau
A following patch will return allocated string.
Signed-off-by: Marc-André Lureau
---
qga/main.c | 57 +++--
1 file changed, 31 insertions(+), 26 deletions(-)
diff --git a/qga/main.c b/qga/main.c
index ede5306..83b7804
From: Marc-André Lureau
'path' is already a global function, rename the variable since it's
going to be in global scope in a later patch.
Signed-off-by: Marc-André Lureau
---
qga/main.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/qga/main.c b/qga/main.c
index e
From: Marc-André Lureau
Now that main() has a single exit point, we can free a few
more allocations.
Signed-off-by: Marc-André Lureau
---
qga/main.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/qga/main.c b/qga/main.c
index 118847c..58f2fc7 100644
--- a/qga/main.c
From: Marc-André Lureau
This new option allows to review the agent configuration,
and ease the task of writing a configuration file.
Signed-off-by: Marc-André Lureau
---
qga/main.c | 62 ++
1 file changed, 62 insertions(+)
diff --git
From: Marc-André Lureau
Once the options are populated, move the running state to
a run_agent() function.
Signed-off-by: Marc-André Lureau
---
qga/main.c | 164 +
1 file changed, 89 insertions(+), 75 deletions(-)
diff --git a/qga/mai
On Sun, Aug 23, 2015 at 18:24:55 -0700, Paolo Bonzini wrote:
> On 23/08/2015 17:24, Emilio G. Cota wrote:
> > This is similar in intent to the async_safe_work mechanism. The main
> > differences are:
> >
> > - Work is run on a single CPU thread *after* all others are put to sleep
> >
> > - Sleepi
From: Marc-André Lureau
Learn to configure the agent with a system configuration.
This may simplify command-line handling, especially when the blacklist
is long.
Among the other benefits, this may standardize the configuration of a
init service (instead of distro-specific init keys/files)
Sign
From: Marc-André Lureau
Add a simple man page for the qemu agent.
Signed-off-by: Marc-André Lureau
---
Makefile | 14 +-
qemu-doc.texi | 6 +++
qemu-ga.texi | 136 ++
3 files changed, 154 insertions(+), 2 deletions(-)
create
On 08/25/2015 04:10 PM, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> qga/qapi-schema.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This already had Reviewed-by in version 1:
http://thread.gmane.org/gmane.comp.emulators
On Sun, Aug 23, 2015 at 18:29:33 -0700, Paolo Bonzini wrote:
>
>
> On 23/08/2015 17:24, Emilio G. Cota wrote:
> > Signed-off-by: Emilio G. Cota
> > ---
> > cputlb.c | 41 +++--
> > 1 file changed, 11 insertions(+), 30 deletions(-)
>
> As suggested by me and
Quoting marcandre.lur...@redhat.com (2015-08-25 17:10:13)
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
Reviewed-by: Michael Roth
> ---
> qga/qapi-schema.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.jso
Quoting marcandre.lur...@redhat.com (2015-08-25 17:10:17)
> From: Marc-André Lureau
>
> A following patch will return allocated string.
>
> Signed-off-by: Marc-André Lureau
Reviewed-by: Michael Roth
> ---
> qga/main.c | 57 +++--
> 1 file
Quoting marcandre.lur...@redhat.com (2015-08-25 17:10:14)
> From: Marc-André Lureau
>
> The option parsing is going to be moved to a separate function,
> use exit() consistently.
>
> Signed-off-by: Marc-André Lureau
> Reviewed-by: Denis V. Lunev
> Reviewed-by: Eric Blake
Reviewed-by: Michael
Quoting marcandre.lur...@redhat.com (2015-08-25 17:10:16)
> From: Marc-André Lureau
>
> 'path' is already a global function, rename the variable since it's
> going to be in global scope in a later patch.
>
> Signed-off-by: Marc-André Lureau
Reviewed-by: Michael Roth
> ---
> qga/main.c | 9 +
On Sun, Aug 23, 2015 at 19:01:28 -0700, Paolo Bonzini wrote:
> > * tb_flush: do it once all other CPUs have been put to sleep by calling
> > rcu_synchronize().
> > We also instrument tb_lock to make sure that only one tb_flush request
> > can
> > happen at a given time.
>
> What do
Hi
On Wed, Aug 26, 2015 at 12:30 AM, Eric Blake wrote:
> It's best to edit your commit message and manually add in that notation,
> when sending a v2, so that reviewers know that nothing changed since
> last time they approved it:
> http://wiki.qemu.org/Contribute/SubmitAPatch
Weird, I thought
-Original Message-
From: Leon Alrae [mailto:leon.al...@imgtec.com]
Sent: Tuesday, August 25, 2015 7:58 PM
To: Petar Jovanovic ; qemu-devel@nongnu.org
Cc: petar.jovano...@imgtec.com; aurel...@aurel32.net
Subject: Re: [Qemu-devel] [PATCH] target-mips: remove wrong checks for
recip.fmt and rs
Quoting marcandre.lur...@redhat.com (2015-08-25 17:10:19)
> From: Marc-André Lureau
>
> Fill all default options during main(). This is a preparation patch
> to allow to dump the configuration.
>
> Signed-off-by: Marc-André Lureau
> Reviewed-by: Michael Roth
> ---
> qga/main.c | 36 ++
Quoting marcandre.lur...@redhat.com (2015-08-25 17:10:18)
> From: Marc-André Lureau
>
> Move option parsing out of giant main().
>
> Signed-off-by: Marc-André Lureau
Reviewed-by: Michael Roth
> ---
> qga/main.c | 165
> +++--
> 1 file
> The seqlock for tb_jmp_cache is necessary the moment that the
> array can be wiped out with a memset(), as shown above. That
> function (tb_flush_jmp_cache) is called by tlb_flush_page,
> which has many callers.
>
> One could argue that we could enforce calling tlb_flush_page to be
> a) always d
> Originally, timers were ticks based, and it made sense to
> add ticks to current time to know when to trigger an alarm.
>
> But since commit:
>
> 7447545 change all other clock references to use nanosecond resolution
> accessors
>
> All timers use nanoseconds and we need to convert ticks to na
> This patch is needed as is. One real risk this is protecting
> against is the call of cpu_interrupt(cpu_foo) when the calling
> thread is not cpu_foo's thread--this write to interrupt_request
> might race with other writes, e.g. another call to cpu_interrupt
> from another thread, or the clearin
> > I just tested a fetch-and-swap+exp.backoff spinlock with usermode on a
> > program that spawns N threads and each thread performs an 2**M atomic
> > increments
> > on the same variable. That is, a degenerate worst-case kind of contention.
> > N varies from 1 to 64, and M=15 on all runs, 5 runs
Quoting marcandre.lur...@redhat.com (2015-08-25 17:10:20)
> From: Marc-André Lureau
>
> Once the options are populated, move the running state to
> a run_agent() function.
>
> Signed-off-by: Marc-André Lureau
Reviewed-by: Michael Roth
> ---
> qga/main.c | 164
>
> lfence and sfence here serve two purposes:
>
> 1) Template for other architectures
Ok, this makes sense.
> 2) x86 code does sometimes have lfence/sfence (e.g. movntq+sfence),
>so I guessed they should remain in the translated code.
>If on x86 we always ignore the Write-Combining from
Hi
On Wed, Aug 26, 2015 at 12:46 AM, Michael Roth
wrote:
> I think this needs to be config->method and config->device_path. It gets
> fixed in the next patch, but looks like it'll break build bisect.
indeed
> Since that requires a respin anyway: there's an extra space in
> 'int main()' that get
Like a makefile, try to skip tests if we know they have already been
executed using the current set of external dependencies.
If a user passes the -ts option to ./check, if a test or its output
or its dependencies (qemu, qemu-nbd, qemu-io, qemu-img,
socket-scm-helper) have been modified, the test
This patchset is a little off the beaten path, but:
Add the ability to skip tests that have already been run whose external
dependencies have remained unchanged since the last test run.
This is useful for, say, re-running a test set to see if a failure was
a one-off or is reproducible by just re-
101 - 200 of 232 matches
Mail list logo
