Re: [Qemu-devel] [PATCH RFC] pseries: define coldplugged devices as "configured"

2015-08-14 Thread Laurent Vivier
On 14/08/2015 07:20, Bharata B Rao wrote: > On Thu, Aug 13, 2015 at 02:53:02PM +0200, Laurent Vivier wrote: >> When a device is hotplugged, attach() sets "configured" to >> false, waiting an action from the OS to configure it and then >> to call ibm,configure-connector. On ibm,configure-connector

Re: [Qemu-devel] [PATCH RFC] pseries: define coldplugged devices as "configured"

2015-08-14 Thread Laurent Vivier
On 14/08/2015 07:20, Bharata B Rao wrote: > On Thu, Aug 13, 2015 at 02:53:02PM +0200, Laurent Vivier wrote: >> When a device is hotplugged, attach() sets "configured" to >> false, waiting an action from the OS to configure it and then >> to call ibm,configure-connector. On ibm,configure-connector

Re: [Qemu-devel] [PATCH RFC] pseries: define coldplugged devices as "configured"

2015-08-14 Thread Bharata B Rao
On Fri, Aug 14, 2015 at 09:16:08AM +0200, Laurent Vivier wrote: > > > On 14/08/2015 07:20, Bharata B Rao wrote: > > On Thu, Aug 13, 2015 at 02:53:02PM +0200, Laurent Vivier wrote: > >> When a device is hotplugged, attach() sets "configured" to > >> false, waiting an action from the OS to configur

Re: [Qemu-devel] about the patch kvmclock Ensure proper env->tsc value for kvmclock_current_nsec calculation

2015-08-14 Thread Li, Liang Z
> >>> Could please point out what issue the patch 317b0a6d8ba44e try > >>> to fix? I > >> found in live migration the cpu_synchronize_all_states will be called > >> twice, and it will take more than 1 ms sometimes. I try to do some > >> optimization but lack the knowledge about the background

Re: [Qemu-devel] about the patch kvmclock Ensure proper env->tsc value for kvmclock_current_nsec calculation

2015-08-14 Thread Marcin Gibuła
W dniu 2015-08-14 o 03:23, Li, Liang Z pisze: On Thu, Aug 13, 2015 at 01:25:29AM +, Li, Liang Z wrote: Hi Paolo & Marcelo, Could please point out what issue the patch 317b0a6d8ba44e try to fix? I found in live migration the cpu_synchronize_all_states will be called twice, and it will

Re: [Qemu-devel] [PATCH RFC 02/10] maint: remove double semicolons in many files

2015-08-14 Thread Daniel P. Berrange
On Thu, Aug 13, 2015 at 06:57:55PM +0100, Peter Maydell wrote: > On 31 July 2015 at 17:30, Daniel P. Berrange wrote: > > A number of source files have statements accidentally > > terminated by a double semicolon - eg 'foo = bar;;'. > > This is harmless but a mistake none the less. > > > > The tcg/

Re: [Qemu-devel] [RFC PATCH V7 07/19] protect TBContext with tb_lock.

2015-08-14 Thread Frederic Konrad
On 12/08/2015 20:20, Alex Bennée wrote: Frederic Konrad writes: On 10/08/2015 17:27, fred.kon...@greensocs.com wrote: From: KONRAD Frederic This protects TBContext with tb_lock to make tb_* thread safe. We can still have issue with tb_flush in case of multithread TCG: An other CPU can

Re: [Qemu-devel] [PULL 0/4] target-mips queue

2015-08-14 Thread Peter Maydell
On 13 August 2015 at 17:45, Leon Alrae wrote: > Hi, > > First target-mips pull request for 2.5 consisting of patches sent during > 2.4 freeze. > > Thanks, > Leon > > Cc: Peter Maydell > Cc: Aurelien Jarno > > The following changes since commit ca0e5d8b0d065a95d0f9042f71b2ace45b015596: > > Open

Re: [Qemu-devel] Plan for using softmmu with linux-user

2015-08-14 Thread Peter Maydell
On 14 August 2015 at 04:25, gchen gchen wrote: > - If the performance of "linux-user + softmmu + tci" is not acceptable >(at present, I am not quite sure), we have to implement SW64 tcg host >target instead of tci. If you care even slightly about performance, then do not use TCI. A tcg b

Re: [Qemu-devel] [PATCH QEMU] vmstate: Remove redefinition of VMSTATE_UINT32_ARRAY

2015-08-14 Thread Peter Maydell
On 14 August 2015 at 07:16, Soren Brinkmann wrote: > The macro is defined twice in identical ways. > > Signed-off-by: Soren Brinkmann > --- > I have the feeling I'm missing a tiny one-letter difference or some > ifdef, but I believe the mentioned macro is defined twice. Duplicate accidentally in

Re: [Qemu-devel] about the patch kvmclock Ensure proper env->tsc value for kvmclock_current_nsec calculation

2015-08-14 Thread Marcin Gibuła
Thanks for your reply, I have read the thread in your email, what's the mean of 'switching from old to new disk', could give a detail description? The test case was like that (using libvirt): 1. Get VM running (linux, using kvmclock), 2. Use blockcopy to copy disk data from one location t

Re: [Qemu-devel] about the patch kvmclock Ensure proper env->tsc value for kvmclock_current_nsec calculation

2015-08-14 Thread Li, Liang Z
> Subject: Re: [Qemu-devel] about the patch kvmclock Ensure proper env->tsc > value for kvmclock_current_nsec calculation > > > Thanks for your reply, I have read the thread in your email, what's the > mean of 'switching from old to new disk', could give a detail description? > > The test ca

Re: [Qemu-devel] [PATCH 00/10] translate-all.c thread-safety

2015-08-14 Thread Frederic Konrad
On 12/08/2015 18:40, Paolo Bonzini wrote: Hi, this is my attempt at 1) extracting upstreamable parts out of Fred's MTTCG, Can you take this one as well after the replace spinlock by QemuMutex: "remove unused spinlock." Thanks, Fred and 2) documenting what's going on in user-mode MTTCG 3) fi

Re: [Qemu-devel] Plan for using softmmu with linux-user

2015-08-14 Thread gchen gchen
On 2015年08月14日 16:44, Peter Maydell wrote: > On 14 August 2015 at 04:25, gchen gchen wrote: >> - If the performance of "linux-user + softmmu + tci" is not acceptable >>(at present, I am not quite sure), we have to implement SW64 tcg host >>target instead of tci. > > If you care even sligh

Re: [Qemu-devel] [PATCH RFC 00/10] Enable repository wide style checking

2015-08-14 Thread Daniel P. Berrange
On Thu, Aug 13, 2015 at 09:39:48PM +0100, Peter Maydell wrote: > On 13 August 2015 at 19:27, Eric Blake wrote: > > It's worth asking the gnulib folks for an opinion on whether relaxing > > the license on maint.mk and GNUmakefile to explicitly go back to GPLv2+, > > and/or explicitly add some expli

Re: [Qemu-devel] [PATCH 0/5] Wire up various EL2/EL3 address translation ops

2015-08-14 Thread Peter Maydell
Ping? thanks -- PMM On 24 July 2015 at 16:20, Peter Maydell wrote: > This patch series wires up some of the EL2 and EL3 address > translation operations which we were missing: > * the AArch64 EL2 and EL3 AT ops > * the AArch32 ATS12NSO ops > * the AArch32 ATS1H ops > > Most of these are still

Re: [Qemu-devel] [PATCH v2 0/6] replace qemu_fls() with pow2ceil()/pow2floor()

2015-08-14 Thread Peter Maydell
Ping? (Patches 1 and 2 have been reviewed; thanks.) -- PMM On 24 July 2015 at 13:33, Peter Maydell wrote: > We have a qemu_fls() function which is just a silly wrapper > around clz32() and which is used in only a handful of places > in the codebase. It turns out that all of those are really > t

Re: [Qemu-devel] [PATCH 0/5] arm_gic: Drop running_irq and last_active arrays

2015-08-14 Thread Peter Maydell
Ping? thanks -- PMM On 28 July 2015 at 14:22, Peter Maydell wrote: > This patchset is a bit of cleanup to our GIC implementation that > I've wanted to do for ages. > > Our current GIC code uses a couple of arrays (running_irq and > last_active) to track currently active interrupts so that > it c

Re: [Qemu-devel] [PATCH 0/4] target-arm: Implement missing EL3 (and EL2) registers

2015-08-14 Thread Peter Maydell
Ping? thanks -- PMM On 30 July 2015 at 19:36, Peter Maydell wrote: > This series adds a handful of EL3 system registers that > we were missing. It also includes the EL2 flavours > where there were obvious easy parallels. I think this > means we now have all the EL3 sysregs we care about. > (A pr

Re: [Qemu-devel] [PATCH 1/6] cputlb: Add functions for flushing TLB for a single MMU index

2015-08-14 Thread Peter Maydell
On 7 August 2015 at 13:33, Peter Maydell wrote: > Guest CPU TLB maintenance operations may be sufficiently > specialized to only need to flush TLB entries corresponding > to a particular MMU index. Implement cputlb functions for > this, to avoid the inefficiency of flushing TLB entries > which we

[Qemu-devel] [PATCH] Move RAMBlock and ram_list to ram_addr.h

2015-08-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert --- include/exec/cpu-all.h | 41 - include/exec/ram_addr.h | 40 2 files changed, 40 insertions(+), 41 deletions(-) diff --git a/include/exec/c

[Qemu-devel] [PATCH] trace-events: Add hmp completion

2015-08-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add completion for the trace event names in the hmp trace-event command. Signed-off-by: Dr. David Alan Gilbert --- hmp-commands.hx | 1 + hmp.h | 1 + monitor.c | 20 3 files changed, 22 insertions(+) diff --git a/hmp-comma

Re: [Qemu-devel] [PATCH] mirror: Fix coroutine reentrance

2015-08-14 Thread Stefan Hajnoczi
On Thu, Aug 13, 2015 at 10:41:50AM +0200, Kevin Wolf wrote: > This fixes a regression introduced by commit dcfb3beb ("mirror: Do zero > write on target if sectors not allocated"), which was reported to cause > aborts with the message "Co-routine re-entered recursively". > > The cause for this bug

Re: [Qemu-devel] [PATCH RFC 00/10] Enable repository wide style checking

2015-08-14 Thread Peter Maydell
On 14 August 2015 at 11:30, Paul Eggert wrote: > Peter Maydell wrote: >> I just don't want >> a GPLv3-licensed file in the git repo and an integrated part >> of our build-and-test system... > > > My kneejerk reaction is that the build procedures in question are large > enough that they should stay

[Qemu-devel] [PATCH v2 0/6] flush TLBs for one MMUidx only, missing AArch64 TLB ops

2015-08-14 Thread Peter Maydell
This series does three things: (1) implement the "flush the TLB only for a specified MMU index" functionality that we talked about when we added all the new MMU index values for ARM for EL2 and EL3 (2) use that to restrict the AArch64 TLB maintenance operations to only the MMU indexes they need t

[Qemu-devel] [PATCH v2 6/6] target-arm: Implement AArch64 TLBI operations on IPAs

2015-08-14 Thread Peter Maydell
Implement the AArch64 TLBI operations which take an intermediate physical address and invalidate stage 2 translations. Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias --- target-arm/helper.c | 55 + 1 file changed, 55 insertions(+)

[Qemu-devel] [PATCH v2 4/6] target-arm: Implement missing EL2 TLBI operations

2015-08-14 Thread Peter Maydell
Implement the missing TLBI operations that exist only if EL2 is implemented. Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias --- target-arm/helper.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index aea8b33..7

[Qemu-devel] [PATCH v2 2/6] target-arm: Move TLBI ALLE1/ALLE1IS definitions into numeric order

2015-08-14 Thread Peter Maydell
Move the two regdefs for TLBI ALLE1 and TLBI ALLE1IS down so that the whole set of AArch64 TLBI regdefs is arranged in numeric order. Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias --- target-arm/helper.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff

[Qemu-devel] [PATCH v2 5/6] target-arm: Implement missing EL3 TLB invalidate operations

2015-08-14 Thread Peter Maydell
Implement the remaining stage 1 TLB invalidate operations visible from EL3. Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias --- target-arm/helper.c | 76 + 1 file changed, 76 insertions(+) diff --git a/target-arm/helper.c b/target

[Qemu-devel] [PATCH v2 1/6] cputlb: Add functions for flushing TLB for a single MMU index

2015-08-14 Thread Peter Maydell
Guest CPU TLB maintenance operations may be sufficiently specialized to only need to flush TLB entries corresponding to a particular MMU index. Implement cputlb functions for this, to avoid the inefficiency of flushing TLB entries which we don't need to. Signed-off-by: Peter Maydell --- cputlb.c

[Qemu-devel] [PATCH v2 3/6] target-arm: Restrict AArch64 TLB flushes to the MMU indexes they must touch

2015-08-14 Thread Peter Maydell
Now we have the ability to flush the TLB only for specific MMU indexes, update the AArch64 TLB maintenance instruction implementations to only flush the parts of the TLB they need to, rather than doing full flushes. We take the opportunity to remove some duplicate functions (the per-asid tlb ops w

Re: [Qemu-devel] [PATCH 0/4] target-sparc: Update to use VMStateDescription

2015-08-14 Thread Peter Maydell
On 13 August 2015 at 23:37, Mark Cave-Ayland wrote: > On 10/08/15 13:34, Peter Maydell wrote: > >> This patchset updates target-sparc to use VMStateDescription >> rather than hand-written save/load functions. (This and CRIS >> are the last two targets still using the old approach.) >> >> It's base

[Qemu-devel] Help debugging a regression in KVM Module

2015-08-14 Thread Peter Lieven
Hi, some time a go I stumbled across a regression in the KVM Module that has been introduced somewhere between 3.17 and 3.19. I have a rather old openSUSE guest with an XFS filesystem which realiably crashes after some live migrations. I originally believed that the issue might be related to my

Re: [Qemu-devel] Win32 stdio not working if SDL is enabled

2015-08-14 Thread Daniel P. Berrange
On Thu, Aug 13, 2015 at 07:48:47PM +0200, Stefan Weil wrote: > Am 13.08.2015 um 14:06 schrieb Daniel P. Berrange: > > When debugging some patches on Windows, I discovered that nothing printed > > to stderr ever appears on the console. Eventually I discovered that if I > > build with --disable-sdl,

[Qemu-devel] [PATCH] block/iscsi: validate block size returned from target

2015-08-14 Thread Peter Lieven
It has been reported that at least tgtd returns a block size of 0 for LUN 0. To avoid running into divide by zero later on and protect against other problematic block sizes validate the block size right at connection time. Cc: qemu-sta...@nongnu.org Reported-by: Andrey Korolyov Signed-off-by: Pet

[Qemu-devel] qemu-img seg, test 082 not showing the error

2015-08-14 Thread Dr. David Alan Gilbert
Hi, I noticed that although 'make check-block' was passing happily I was seeing a kernel log showing a qemu-img seg: [Fri Aug 14 12:26:07 2015] qemu-img[7725]: segfault at 0 ip (null) sp 773e9a98 error 14 in qemu-img[55f707577000+f8000] The case that fails is: run_qemu_img a

Re: [Qemu-devel] Win32 stdio not working if SDL is enabled

2015-08-14 Thread Daniel P. Berrange
On Fri, Aug 14, 2015 at 12:14:15PM +0100, Daniel P. Berrange wrote: > On Thu, Aug 13, 2015 at 07:48:47PM +0200, Stefan Weil wrote: > > Am 13.08.2015 um 14:06 schrieb Daniel P. Berrange: > > > When debugging some patches on Windows, I discovered that nothing printed > > > to stderr ever appears on t

Re: [Qemu-devel] [PATCH 0/4] target-sparc: Update to use VMStateDescription

2015-08-14 Thread Artyom Tarasenko
Hi Mark, On Fri, Aug 14, 2015 at 12:37 AM, Mark Cave-Ayland wrote: > On 10/08/15 13:34, Peter Maydell wrote: > >> This patchset updates target-sparc to use VMStateDescription >> rather than hand-written save/load functions. (This and CRIS >> are the last two targets still using the old approach.)

Re: [Qemu-devel] [Qemu-ppc] [PATCH RFC] pseries: define coldplugged devices as "configured"

2015-08-14 Thread Laurent Vivier
I'd like to know if it is the good way to fix the problem: are there more comments on this patch ? People from IBM ? Laurent On 13/08/2015 14:53, Laurent Vivier wrote: > When a device is hotplugged, attach() sets "configured" to > false, waiting an action from the OS to configure it and then > to

[Qemu-devel] [PATCH] vl: redirect stdio to a file in Windows GUI build

2015-08-14 Thread Daniel P. Berrange
If linked to the windows subsystem (-mwindows gcc arg) then there will be no console available for stdout/err to send data to. Use the same approach as SDL by redirecting stdout/err to text files in the current directory. If linked to the console subsystem then leave stdout/err untouched. The red

Re: [Qemu-devel] [PATCH v2 2/6] hw/arm: new interface for devices which need to behave differently for kernel boot

2015-08-14 Thread Peter Maydell
On 18 July 2015 at 10:00, Peter Maydell wrote: > On 18 July 2015 at 04:55, Peter Crosthwaite > wrote: >> On Thu, Jul 16, 2015 at 1:11 PM, Peter Maydell >> wrote: >>> For ARM we have a little minimalist bootloader in hw/arm/boot.c which >>> takes the place of firmware if we're directly booting a

[Qemu-devel] [PATCH] spice: Allow to set password even if disable-ticketing was used

2015-08-14 Thread Christophe Fergeau
Before commit b1ea7b79e1, it was possible to start with -spice disable-ticketing, and then use the "set_password spice" command to enable ticketing with SPICE. Since commit b1ea7b79e1 this is no longer possible as qemu_spice_set_ticket() will return an error unless the 'auth' type is "spice". When

Re: [Qemu-devel] [PATCH v2 2/6] hw/arm: new interface for devices which need to behave differently for kernel boot

2015-08-14 Thread Peter Maydell
[oops, forgot to update Peter C's email address in the From line; apologies to everybody else for the duplicate mail.] On 18 July 2015 at 10:00, Peter Maydell wrote: > On 18 July 2015 at 04:55, Peter Crosthwaite > wrote: >> On Thu, Jul 16, 2015 at 1:11 PM, Peter Maydell >> wrote: >>> For ARM w

Re: [Qemu-devel] [PATCH] spice: Allow to set password even if disable-ticketing was used

2015-08-14 Thread Daniel P. Berrange
On Fri, Aug 14, 2015 at 02:47:15PM +0200, Christophe Fergeau wrote: > Before commit b1ea7b79e1, it was possible to start with -spice > disable-ticketing, and then use the "set_password spice" command to > enable ticketing with SPICE. Since commit b1ea7b79e1 this is no longer > possible as qemu_spic

Re: [Qemu-devel] Help debugging a regression in KVM Module

2015-08-14 Thread Paolo Bonzini
- Original Message - > From: "Peter Lieven" > To: qemu-devel@nongnu.org, k...@vger.kernel.org > Cc: "Paolo Bonzini" > Sent: Friday, August 14, 2015 1:11:34 PM > Subject: Help debugging a regression in KVM Module > > Hi, > > some time a go I stumbled across a regression in the KVM Modu

[Qemu-devel] [PULL v2 09/20] configure: Default to enable module build

2015-08-14 Thread Paolo Bonzini
From: Fam Zheng We have module build support around for a while, but also had it bitrot several times. It probably makes sense to enable it by default so that people can notice and use it. Add --disable-modules as a counterpart to --enable-modules, which is now turned on by default. If both are

[Qemu-devel] [PULL v2 00/20] SCSI, build, TCG, RCU, misc patches for 2015-08-12

2015-08-14 Thread Paolo Bonzini
The following changes since commit cb48f67ad8c7b33c617d4f8144a27706e69fd688: bsd-user: Fix operand to cpu_x86_exec (2015-07-30 12:38:49 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to 2dfebe37e6210278cddd07076

Re: [Qemu-devel] [PATCH] spice: Allow to set password even if disable-ticketing was used

2015-08-14 Thread Christophe Fergeau
Hey, On Fri, Aug 14, 2015 at 01:54:59PM +0100, Daniel P. Berrange wrote: > On Fri, Aug 14, 2015 at 02:47:15PM +0200, Christophe Fergeau wrote: > > Before commit b1ea7b79e1, it was possible to start with -spice > > disable-ticketing, and then use the "set_password spice" command to > > enable ticke

[Qemu-devel] [PATCH 2/3] i8257: remove cpu_request_exit irq

2015-08-14 Thread Paolo Bonzini
This is unused. cpu_exit now is almost exclusively an internal function to the CPU execution loop. The next patch will change the remaining occurrences to qemu_cpu_kick, making it truly internal. Signed-off-by: Paolo Bonzini --- hw/dma/i82374.c | 5 + hw/dma/i8257.c | 13

[Qemu-devel] [PATCH 1/3] i8257: rewrite DMA_schedule to avoid hooking into the CPU loop

2015-08-14 Thread Paolo Bonzini
The i8257 DMA controller uses an idle bottom half, which by default does not cause the main loop to exit. Therefore, the DMA_schedule function is there to ensure that the CPU relinquishes the iothread mutex to the iothread. However, this is not enough since the iothread will call aio_compute_time

[Qemu-devel] [PATCH 0/3] Signal-free qemu_cpu_kick for TCG

2015-08-14 Thread Paolo Bonzini
The first two patches remove most uses of cpu_exit outside the CPU loop. The third patch converts qemu_cpu_kick to do memory accesses from the iothread instead of using a signal. Paolo Paolo Bonzini (3): i8257: rewrite DMA_schedule to avoid hooking into the CPU loop i8257: remove cpu_request

[Qemu-devel] [PATCH 3/3] tcg: signal-free qemu_cpu_kick

2015-08-14 Thread Paolo Bonzini
Signals are slow and do not exist on Win32. It is not much more complicated to use memory barriers (which we already need anyway on Windows!) and set the existing flags in the iothread. qemu_cpu_kick_thread is not used anymore on TCG, since the TCG thread is never outside usermode while the CPU i

Re: [Qemu-devel] [PATCH RFC 00/10] Enable repository wide style checking

2015-08-14 Thread Paul Eggert
Peter Maydell wrote: I just don't want a GPLv3-licensed file in the git repo and an integrated part of our build-and-test system... My kneejerk reaction is that the build procedures in question are large enough that they should stay GPLv3. If you don't want those files in your git repo you c

[Qemu-devel] [PATCH] e500 ATMU register reads broken

2015-08-14 Thread Rudolf Marek
Hi all, I noticed that ATMU register reads on E500 are broken. Due to the wrong mask, some registers cannot be read and instead some other registers are read. Please see attached patch which fixes the problem. I also noticed that if there was an intention to have 1:1 PCI/CPU space mapping fo

[Qemu-devel] [Bug 1484925] [NEW] Segfault with custom vnc client

2015-08-14 Thread Uli Stärk
Public bug reported: Hey, I'm using Citrix XenServer 6.5. I worte a script that uses noVNC to connect to the rfb console via xapi. When I use GRML and try to boot it, the QEMU process segfaults and kills my VM. This happens when the screen resizes and the kernel is loading: recvfrom(3, "\3\1\0\0

Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-08-14 Thread Peter Lieven
Am 22.06.2015 um 23:54 schrieb John Snow: > > On 06/22/2015 09:09 AM, Peter Lieven wrote: >> Am 22.06.2015 um 11:25 schrieb Stefan Hajnoczi: >>> On Fri, Jun 19, 2015 at 2:14 PM, Peter Lieven wrote: Am 18.06.2015 um 11:36 schrieb Stefan Hajnoczi: > On Thu, Jun 18, 2015 at 10:29 AM, Peter L

Re: [Qemu-devel] [PATCH] mirror: Fix coroutine reentrance

2015-08-14 Thread Jeff Cody
On Thu, Aug 13, 2015 at 10:41:50AM +0200, Kevin Wolf wrote: > This fixes a regression introduced by commit dcfb3beb ("mirror: Do zero > write on target if sectors not allocated"), which was reported to cause > aborts with the message "Co-routine re-entered recursively". > > The cause for this bug

Re: [Qemu-devel] [PATCH] mirror: Fix coroutine reentrance

2015-08-14 Thread Jeff Cody
On Thu, Aug 13, 2015 at 10:41:50AM +0200, Kevin Wolf wrote: > This fixes a regression introduced by commit dcfb3beb ("mirror: Do zero > write on target if sectors not allocated"), which was reported to cause > aborts with the message "Co-routine re-entered recursively". > > The cause for this bug

[Qemu-devel] [PULL 0/2] Block job patches

2015-08-14 Thread Jeff Cody
The following changes since commit be1f13ac9d9fc21908975460652a72f5f0c018c5: Merge remote-tracking branch 'remotes/lalrae/tags/mips-20150813' into staging (2015-08-13 17:47:44 +0100) are available in the git repository at: g...@github.com:codyprime/qemu-kvm-jtc.git tags/block-pull-request

[Qemu-devel] [PULL 1/2] block/mirror: limit qiov to IOV_MAX elements

2015-08-14 Thread Jeff Cody
From: Stefan Hajnoczi If mirror has more free buffers than IOV_MAX, preadv(2)/pwritev(2) EINVAL failures may be encountered. It is possible to trigger this by setting granularity to a low value like 8192. This patch stops appending chunks once IOV_MAX is reached. The spurious EINVAL failure ca

[Qemu-devel] [PULL 2/2] mirror: Fix coroutine reentrance

2015-08-14 Thread Jeff Cody
From: Kevin Wolf This fixes a regression introduced by commit dcfb3beb ("mirror: Do zero write on target if sectors not allocated"), which was reported to cause aborts with the message "Co-routine re-entered recursively". The cause for this bug is the following code in mirror_iteration_done():

Re: [Qemu-devel] [PULL v2 00/20] SCSI, build, TCG, RCU, misc patches for 2015-08-12

2015-08-14 Thread Peter Maydell
On 14 August 2015 at 14:03, Paolo Bonzini wrote: > The following changes since commit cb48f67ad8c7b33c617d4f8144a27706e69fd688: > > bsd-user: Fix operand to cpu_x86_exec (2015-07-30 12:38:49 +0100) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git tags/for-upstr

Re: [Qemu-devel] [PATCH] spice: Allow to set password even if disable-ticketing was used

2015-08-14 Thread Daniel P. Berrange
On Fri, Aug 14, 2015 at 03:09:44PM +0200, Christophe Fergeau wrote: > Hey, > > On Fri, Aug 14, 2015 at 01:54:59PM +0100, Daniel P. Berrange wrote: > > On Fri, Aug 14, 2015 at 02:47:15PM +0200, Christophe Fergeau wrote: > > > Before commit b1ea7b79e1, it was possible to start with -spice > > > disa

Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-08-14 Thread Kevin Wolf
Am 14.08.2015 um 15:43 hat Peter Lieven geschrieben: > Am 22.06.2015 um 23:54 schrieb John Snow: > > > > On 06/22/2015 09:09 AM, Peter Lieven wrote: > >> Am 22.06.2015 um 11:25 schrieb Stefan Hajnoczi: > >>> On Fri, Jun 19, 2015 at 2:14 PM, Peter Lieven wrote: > Am 18.06.2015 um 11:36 schrieb

Re: [Qemu-devel] about the patch kvmclock Ensure proper env->tsc value for kvmclock_current_nsec calculation

2015-08-14 Thread Marcin Gibuła
So, the problem is cause by stop_vm(RUN_STATE_PAUSED), in this case the env->tsc is not updated, which lead to the issue. Is that right? I think so. If the cpu_clean_all_dirty() is needed just for the APIC status reason, I think we can do the cpu_synchronize_all_states() in do_vm_stop and af

Re: [Qemu-devel] [PULL v2 00/20] SCSI, build, TCG, RCU, misc patches for 2015-08-12

2015-08-14 Thread Paolo Bonzini
On 14/08/2015 15:53, Peter Maydell wrote: > Hi; I'm afraid this failed to build on my w32 config: > > /home/petmay01/linaro/qemu-for-merges/block/dmg.c:1: warning: -fPIC > ignored for target (all code is position independent) > > (I have warnings-are-errors enabled.) This is a very weird warni

Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-08-14 Thread Peter Lieven
Am 14.08.2015 um 16:08 schrieb Kevin Wolf: > Am 14.08.2015 um 15:43 hat Peter Lieven geschrieben: >> Am 22.06.2015 um 23:54 schrieb John Snow: >>> On 06/22/2015 09:09 AM, Peter Lieven wrote: Am 22.06.2015 um 11:25 schrieb Stefan Hajnoczi: > On Fri, Jun 19, 2015 at 2:14 PM, Peter Lieven wr

Re: [Qemu-devel] [PULL v2 00/20] SCSI, build, TCG, RCU, misc patches for 2015-08-12

2015-08-14 Thread Paolo Bonzini
On 14/08/2015 16:21, Paolo Bonzini wrote: > > > On 14/08/2015 15:53, Peter Maydell wrote: >> Hi; I'm afraid this failed to build on my w32 config: >> >> /home/petmay01/linaro/qemu-for-merges/block/dmg.c:1: warning: -fPIC >> ignored for target (all code is position independent) >> >> (I have war

[Qemu-devel] [Bug 1484925] Re: Segfault with custom vnc client

2015-08-14 Thread Daniel Berrange
Can you attach GDB to your qemu-dm process and attempt to capture a full stack trace when it crashes (ie thread apply all backtrace) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1484925 Title: Seg

Re: [Qemu-devel] [PULL v2 00/20] SCSI, build, TCG, RCU, misc patches for 2015-08-12

2015-08-14 Thread Peter Maydell
On 14 August 2015 at 15:21, Paolo Bonzini wrote: > > > On 14/08/2015 15:53, Peter Maydell wrote: >> Hi; I'm afraid this failed to build on my w32 config: >> >> /home/petmay01/linaro/qemu-for-merges/block/dmg.c:1: warning: -fPIC >> ignored for target (all code is position independent) >> >> (I have

Re: [Qemu-devel] [PATCH] spice: Allow to set password even if disable-ticketing was used

2015-08-14 Thread Christophe Fergeau
On Fri, Aug 14, 2015 at 03:04:48PM +0100, Daniel P. Berrange wrote: > Hmm, is oVirt using this via libvirt ? If so, I guess we have to fix > it, as that would be a break in current usage. Yes this is done through libvirt. Before commit qemu-2.1.0-rc2~11^2, you could use virsh update-device with

Re: [Qemu-devel] [PATCH] spice: Allow to set password even if disable-ticketing was used

2015-08-14 Thread Daniel P. Berrange
On Fri, Aug 14, 2015 at 02:47:15PM +0200, Christophe Fergeau wrote: > Before commit b1ea7b79e1, it was possible to start with -spice > disable-ticketing, and then use the "set_password spice" command to > enable ticketing with SPICE. Since commit b1ea7b79e1 this is no longer > possible as qemu_spic

[Qemu-devel] [PULL 1/2] throttle: refuse bps_max/iops_max without bps/iops

2015-08-14 Thread Stefan Hajnoczi
The bps_max/iops_max values are meaningless without corresponding bps/iops values. Reported an error if bps_max/iops_max is given without bps/iops. Signed-off-by: Stefan Hajnoczi Reviewed-by: Alberto Garcia Message-id: 1438683733-2-2-git-send-email-stefa...@redhat.com --- blockdev.c

[Qemu-devel] [PULL 0/2] Block patches

2015-08-14 Thread Stefan Hajnoczi
The following changes since commit 2be4f242b50a84bf360df02480b173bfed161107: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into staging (2015-08-04 16:51:24 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for

[Qemu-devel] [PULL 2/2] throttle: add throttle_max_is_missing_limit() test

2015-08-14 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi Reviewed-by: Alberto Garcia Message-id: 1438683733-2-3-git-send-email-stefa...@redhat.com --- tests/test-throttle.c | 21 + 1 file changed, 21 insertions(+) diff --git a/tests/test-throttle.c b/tests/test-throttle.c index 0168445..85c9b6c 1

Re: [Qemu-devel] Plan for using softmmu with linux-user

2015-08-14 Thread Richard Henderson
On 08/14/2015 02:37 AM, gchen gchen wrote: > - If I implement SW64 tcg backend, I guess, I cann't get help from qemu >upstream: I don't think SW64 is valuable enough for upstream (either >I am not sure that I can implment Alpha tcg backend in working time). It'll need some updating to app

Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-08-14 Thread Peter Lieven
Am 14.08.2015 um 16:08 schrieb Kevin Wolf: > Am 14.08.2015 um 15:43 hat Peter Lieven geschrieben: >> Am 22.06.2015 um 23:54 schrieb John Snow: >>> On 06/22/2015 09:09 AM, Peter Lieven wrote: Am 22.06.2015 um 11:25 schrieb Stefan Hajnoczi: > On Fri, Jun 19, 2015 at 2:14 PM, Peter Lieven wr

Re: [Qemu-devel] [PULL 0/2] Block job patches

2015-08-14 Thread Peter Maydell
On 14 August 2015 at 14:57, Jeff Cody wrote: > The following changes since commit be1f13ac9d9fc21908975460652a72f5f0c018c5: > > Merge remote-tracking branch 'remotes/lalrae/tags/mips-20150813' into > staging (2015-08-13 17:47:44 +0100) > > are available in the git repository at: > > > g...@gi

Re: [Qemu-devel] [PULL 0/2] Block job patches

2015-08-14 Thread Jeff Cody
On Fri, Aug 14, 2015 at 03:51:03PM +0100, Peter Maydell wrote: > On 14 August 2015 at 14:57, Jeff Cody wrote: > > The following changes since commit be1f13ac9d9fc21908975460652a72f5f0c018c5: > > > > Merge remote-tracking branch 'remotes/lalrae/tags/mips-20150813' into > > staging (2015-08-13 17

[Qemu-devel] [PATCH v2 01/18] acpi: allow aml_operation_region() working on 64 bit offset

2015-08-14 Thread Xiao Guangrong
Currently, the offset in OperationRegion is limited to 32 bit, extend it to 64 bit so that we can switch SSDT to 64 bit in later patch Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 2 +- include/hw/acpi/aml-build.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH v2 03/18] acpi: add aml_derefof

2015-08-14 Thread Xiao Guangrong
Implement DeRefOf term which is used by NVDIMM _DSM method in later patch Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 02f9e3d..9e89efc

[Qemu-devel] [PATCH v2 09/18] nvdimm: build ACPI NFIT table

2015-08-14 Thread Xiao Guangrong
NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT) Currently, we only support PMEM mode. Each device has 3 tables: - SPA table, define the PMEM region info - MEM DEV table, it has the @handle which is used to associate specified ACPI NVDIMM device we will introduce in l

[Qemu-devel] [PATCH v2 02/18] i386/acpi-build: allow SSDT to operate on 64 bit

2015-08-14 Thread Xiao Guangrong
Only 512M is left for MMIO below 4G and that are used by PCI, BIOS etc. Other components also reserve regions from their internal usage, e.g, [0xFED0, 0xFED0 + 0x400) is reserved for HPET Switch SSDT to 64 bit to use the huge free room above 4G. In the later patches, we will dynamical allo

[Qemu-devel] [PATCH v2 04/18] acpi: add aml_sizeof

2015-08-14 Thread Xiao Guangrong
Implement SizeOf term which is used by NVDIMM _DSM method in later patch Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 9e89efc..a526eed

[Qemu-devel] [PATCH v2 07/18] nvdimm: reserve address range for NVDIMM

2015-08-14 Thread Xiao Guangrong
NVDIMM reserves all the free range above 4G to do: - Persistent Memory (PMEM) mapping - implement NVDIMM ACPI device _DSM method Signed-off-by: Xiao Guangrong --- hw/i386/pc.c | 12 ++-- hw/mem/nvdimm/pc-nvdimm.c | 13 + include/hw/mem/pc-nvdimm.h | 1 + 3 fil

[Qemu-devel] [PATCH v2 13/18] nvdimm: build namespace config data

2015-08-14 Thread Xiao Guangrong
If @configdata is false, Qemu will build a static and readonly namespace in memory and use it serveing for DSM GET_CONFIG_SIZE/GET_CONFIG_DATA requests Signed-off-by: Xiao Guangrong --- hw/mem/Makefile.objs | 3 +- hw/mem/nvdimm/acpi.c | 10 ++ hw/mem/nvdimm/internal.h | 12 ++

[Qemu-devel] [PATCH v2 05/18] acpi: add aml_create_field

2015-08-14 Thread Xiao Guangrong
Implement CreateField term which are used by NVDIMM _DSM method in later patch Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 14 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 15 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index a5

[Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area

2015-08-14 Thread Xiao Guangrong
The parameter @file is used as backed memory for NVDIMM which is divided into two parts if @dataconfig is true: - first parts is (0, size - 128K], which is used as PMEM (Persistent Memory) - 128K at the end of the file, which is used as Config Data Area, it's used to store Label namespace data

[Qemu-devel] [PATCH v2 12/18] nvdimm: save arg3 for NVDIMM device _DSM method

2015-08-14 Thread Xiao Guangrong
Check if the function (Arg2) has additional input info (arg3) and save the info if needed We only do the save on NVDIMM device since we are not going to support any function on root device Signed-off-by: Xiao Guangrong --- hw/mem/nvdimm/acpi.c | 73 ++

[Qemu-devel] [PATCH v2 17/18] nvdimm: support NFIT_CMD_SET_CONFIG_DATA

2015-08-14 Thread Xiao Guangrong
Function 6 is used to set Namespace Label Data Signed-off-by: Xiao Guangrong --- hw/mem/nvdimm/acpi.c | 40 1 file changed, 40 insertions(+) diff --git a/hw/mem/nvdimm/acpi.c b/hw/mem/nvdimm/acpi.c index 517d710..283228d 100644 --- a/hw/mem/nvdimm/acpi.c

[Qemu-devel] [PATCH v2 00/18] implement vNVDIMM

2015-08-14 Thread Xiao Guangrong
Changlog: - Use litten endian for DSM method, thanks for Stefan's suggestion - introduce a new parameter, @configdata, if it's false, Qemu will build a static and readonly namespace in memory and use it serveing for DSM GET_CONFIG_SIZE/GET_CONFIG_DATA requests. In this case, no reserved regi

[Qemu-devel] [PATCH v2 06/18] pc: implement NVDIMM device abstract

2015-08-14 Thread Xiao Guangrong
Introduce "pc-nvdimm" device and it has two parameters: - @file, which is the backed memory file for NVDIMM device - @configdata, specify if we need to reserve 128k at the end of @file for nvdimm device's config data. Default is false If @configdata is false, Qemu will build a static and readon

[Qemu-devel] [PATCH v2 14/18] nvdimm: support NFIT_CMD_IMPLEMENTED function

2015-08-14 Thread Xiao Guangrong
__DSM is defined in ACPI 6.0: 9.14.1 _DSM (Device Specific Method) Function 0 is a query function. We do not support any function on root device and only 3 functions are support for NVDIMM device, NFIT_CMD_GET_CONFIG_SIZE, NFIT_CMD_GET_CONFIG_DATA and NFIT_CMD_SET_CONFIG_DATA, that means we curren

[Qemu-devel] [PATCH v2 16/18] nvdimm: support NFIT_CMD_GET_CONFIG_DATA

2015-08-14 Thread Xiao Guangrong
Function 5 is used to get Namespace Label Data Signed-off-by: Xiao Guangrong --- hw/mem/nvdimm/acpi.c | 32 1 file changed, 32 insertions(+) diff --git a/hw/mem/nvdimm/acpi.c b/hw/mem/nvdimm/acpi.c index 0a5f2c2..517d710 100644 --- a/hw/mem/nvdimm/acpi.c +++ b/h

[Qemu-devel] [PATCH 07/11] target-m68k: Use setcond for scc

2015-08-14 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-m68k/translate.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index ce48e2a..28c3e1e 100644 --- a/target-m68k/translate.c +++ b/target-m68k/translate.c @@ -88

[Qemu-devel] [PATCH 10/11] target-m68k: Inline shifts

2015-08-14 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-m68k/helper.c| 52 --- target-m68k/helper.h| 3 -- target-m68k/translate.c | 94 + 3 files changed, 72 insertions(+), 77 deletions(-) diff --git a/target-m68k/helper.c b/t

[Qemu-devel] [PATCH v2 18/18] nvdimm: add maintain info

2015-08-14 Thread Xiao Guangrong
Add NVDIMM maintainer Signed-off-by: Xiao Guangrong --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 978b717..86786e6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -793,6 +793,12 @@ M: Jiri Pirko S: Maintained F: hw/net/rocker/ +NVDIM

[Qemu-devel] [PATCH v2 10/18] nvdimm: init the address region used by DSM method

2015-08-14 Thread Xiao Guangrong
This memory range is used to transfer data between ACPI in guest and Qemu, it occupies two pages: - one is RAM-based used to save the input info of _DSM method and Qemu reuse it store output info - another one is MMIO-based, ACPI write data to this page to transfer the control to Qemu Signed-

[Qemu-devel] [PATCH v2 11/18] nvdimm: build ACPI nvdimm devices

2015-08-14 Thread Xiao Guangrong
NVDIMM devices is defined in ACPI 6.0 9.20 NVDIMM Devices This is a root device under \_SB and specified NVDIMM device are under the root device. Each NVDIMM device has _ADR which return its handle used to associate MEMDEV table in NFIT We reserve handle 0 for root device. In this patch, we save

[Qemu-devel] [PATCH 00/11] Proposed format for m68k flags

2015-08-14 Thread Richard Henderson
As promised a couple of days ago, with the addition of CC_OP_CMP, which wasn't in the text of my proposal the other day. From the looks of the generated code, I believe this is ideal. The following is based on Laurent's 8/30 Update cpu flags management. FWIW, there's something in the last patch

  1   2   >