Hello!
> This Doesn't compile, a problem with KVM_DEV_TYPE_ARM_VGIC_V2.
> I assume this is include file issue as it exists in linux-headers/linux/kvm.h
> Note that everything should compile also for TCG only.
Damn! I think i know what the problem is... Your host arch != target arch and
CONFIG_
Hello!
> > --- a/hw/arm/virt.c
> > +++ b/hw/arm/virt.c
> > @@ -125,6 +125,7 @@ static const MemMapEntry a15memmap[] = {
> > [VIRT_PCIE_PIO] = { 0x3eff, 0x0001 },
> > [VIRT_PCIE_ECAM] = { 0x3f00, 0x0100 },
> > [VIRT_MEM] ={ 0x40
Sorry, weekend.
But I'll test it as soon as possible.
S.P.
On Fri, Jul 24, 2015, 10:13 Pavel Fedin wrote:
> Hello!
>
> > This Doesn't compile, a problem with KVM_DEV_TYPE_ARM_VGIC_V2.
> > I assume this is include file issue as it exists in
> linux-headers/linux/kvm.h
> > Note that everything sh
On 23/07/2015 13:43, Fam Zheng wrote:
> On Thu, 07/23 10:15, Paolo Bonzini wrote:
>>
>>
>> On 23/07/2015 08:32, Fam Zheng wrote:
>>>
>>> What is realized in this series is similar except the "disable, poll,
>>> enable"
>>> method, instead the bit mask of interesting client types is passed to
>>>
Hello!
> Sorry, weekend.
> But I'll test it as soon as possible.
Thanks for pointing at it, my guess was correct, i have verified it by myself.
Looks like i cannot use KVM definitions outside of KVM-only code. And simple
#include will not help because this will not compile on non-Linux
host
Hi Jason,
On 07/24/2015 10:12 AM, Jason Wang wrote:
On 07/24/2015 10:04 AM, Dong, Eddie wrote:
Hi Stefan:
Thanks for your comments!
On Mon, Jul 20, 2015 at 02:42:33PM +0800, Li Zhijian wrote:
We are planning to implement colo-proxy in qemu to cache and compare
packets.
I thought
On 07/23/15 22:11, Peter Maydell wrote:
> I'm happy to be able to announce that the QEMU project
> has joined Software Freedom Conservancy. This is something
> we've been wanting to do for a while now (we've talked
> about it at several previous QEMU Summit meetings).
>
> Software Freedom Conserva
On 07/23/15 16:47, Eric Blake wrote:
> On 07/23/2015 08:01 AM, Markus Armbruster wrote:
>> This is particularly useful when we abort in error_propagate(),
>> because there the stack backtrace doesn't lead to where the error was
>> created. Looks like this:
>>
>> Unexpected error in parse_block
Some kernels program a 0 address for io regions. PCI 3.0 spec
section 6.2.5.1 doesn't seem to disallow this.
based on patch by Michael Roth
Add pci_allow_0_addr in MachineClass to conditionally
allow addr 0 for pseries, as this can break other architectures.
This patch allows to hotplug PCI car
On 24 July 2015 at 06:10, Paolo Bonzini wrote:
>
>
> On 23/07/2015 22:10, Peter Maydell wrote:
>>> > The series looks good, but I'd prefer (especially for patch 4 which is
>>> > in a fast path) if pow2ceil and pow2floor were made inline.
>> Yeah, I was wondering if I was going to be asked to do th
On 23 July 2015 at 22:49, Michael Roth wrote:
> I seem to recall Michael suggesting it may have already been
> fixed on x86. I think we had a TODO to figure out all
> the architectures that don't use IO windows and figure out
> if they need a fix as well.
If we think we've fixed x86, then I think
On 24/07/2015 10:39, Peter Maydell wrote:
>> > But in patch 4 the call is only in the rare case where "l & (l - 1)" is
>> > not zero.
> True. Any preferences for which header file to put them in?
> qemu-common.h is where the prototype is currently and where
> the inline is_power_of_2() is defined
On 24/07/2015 10:46, Peter Maydell wrote:
> On 23 July 2015 at 22:49, Michael Roth wrote:
>> I seem to recall Michael suggesting it may have already been
>> fixed on x86. I think we had a TODO to figure out all
>> the architectures that don't use IO windows and figure out
>> if they need a fix a
Eric Blake writes:
> On 07/23/2015 08:01 AM, Markus Armbruster wrote:
>> Duplicated when commit 680d16d added error_set_errno(), and again when
>> commit 20840d4 added error_set_win32().
>>
>> Make the original copy in error_set() reusable by factoring out
>> error_setv(), then rewrite error_set
Eric Blake writes:
> On 07/23/2015 08:01 AM, Markus Armbruster wrote:
>> This is particularly useful when we abort in error_propagate(),
>> because there the stack backtrace doesn't lead to where the error was
>> created. Looks like this:
>>
>> Unexpected error in parse_block_error_action()
On 24 July 2015 at 08:44, Pavel Fedin wrote:
> Thanks for pointing at it, my guess was correct, i have verified
> it by myself. Looks like i cannot use KVM definitions outside of
> KVM-only code. And simple #include will not help
> because this will not compile on non-Linux hosts. I will look fo
** Description changed:
FPU bug in qemu-system-i386 makes software which use floating point
numbers work incorrectly. For instance, the one included in attachment
prints out 0 instead of 2147483648. The same code works ok in qemu-
system-x86_64.
I have this issue in QEMU 2.3.0 on two
The number of slots per page being 511 (i.e. not a power of two) means
that the (32-bit) read and write indexes going beyond 2^32 will likely
disturb operation. The hypervisor side gets I/O req server creation
extended so we can indicate that we're using suitable atomic accesses
where needed, allow
On Thu, Jul 16, 2015 at 12:47:26PM +0100, Peter Maydell wrote:
> On CPUs with EL3, there are two physical timers, one for Secure and one
> for Non-secure. Implement this extra timer and the AArch64 registers
> which access it.
>
> Signed-off-by: Peter Maydell
> ---
> target-arm/cpu-qom.h | 1 +
Thanks! That patch solves the issue for me. May I ask maintainer to
commit the fix?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1477683
Title:
FPU in qemu-system-i386 works incorrectly
Status in
This series introduces support for GICv3 by KVM. Software emulation is
currently not supported.
Differences from v6:
- Wrap own GIC type definitions on top of KVM ones. Fixed build on
non-ARM-Linux hosts
Differences from v5:
- Fixed various checkpatch.pl style warnings
- Removed TODO in gicv3_i
These functions are useful also for vGICv3 implementation. Make them accessible
from within other modules.
Actually kvm_dist_get() and kvm_dist_put() could also be made reusable, but
they would require two extra parameters (s->dev_fd and s->num_cpu) as well as
lots of typecasts of 's' to DeviceSta
This patch introduces kernel_irqchip_type member in Machine class, which
is passed to kvm_arch_irqchip_create. Machine models which can use vGIC
now use it in order to supply correct GIC type for KVM capability
verification. The variable is defined as int in order to be
architecture-agnostic for po
Just speficying ops = NULL in some cases can be more convenient than having
two functions. GICv3 code is going to use this. GICv2 code can be refactored
in a similar way, killing some code duplication.
Signed-off-by: Pavel Fedin
Acked-by: Paolo Bonzini
---
include/exec/memory.h | 14 +++
Get/put routines are missing, live migration is not possible.
Signed-off-by: Pavel Fedin
---
hw/intc/Makefile.objs | 3 +
hw/intc/arm_gicv3_kvm.c | 155
2 files changed, 158 insertions(+)
create mode 100644 hw/intc/arm_gicv3_kvm.c
diff --git
Set kernel_irqchip_type according to value of the option and pass it
around where necessary. Instantiate devices and fdt nodes according
to the choice.
max_cpus for virt machine increased to 64. GICv2 compatibility check
happens inside arm_gic_common_realize().
Signed-off-by: Pavel Fedin
---
hw
From: Shlomo Pongratz
This class is to be used by both software and KVM implementations of GICv3
Signed-off-by: Shlomo Pongratz
Signed-off-by: Pavel Fedin
---
hw/intc/Makefile.objs | 1 +
hw/intc/arm_gicv3_common.c | 249 +
hw/intc/gi
On 24 July 2015 at 10:48, Edgar E. Iglesias wrote:
> On Thu, Jul 16, 2015 at 12:47:26PM +0100, Peter Maydell wrote:
>> +{ .name = "CNTPS_CVAL_EL1", .state = ARM_CP_STATE_AA64,
>> + .opc0 = 3, .opc1 = 7, .crn = 14, .crm = 2, .opc2 = 2,
>> + .type = ARM_CP_IO,
>> + .accessfn = gt_
22.07.2015 19:37, Kevin O'Connor пишет:
Hi,
Hi,
Is the motivation of this patch to improve the correctness of the
hardware emulation or is there some feature that the current QEMU
implementation prevents?
The motivation is to improve correctness. The current QEMU PAM
implementation prevents ex
aio_notify can be optimized away, and in fact almost always will. However,
qemu_notify_event is used in places where this is incorrect---most notably,
when handling SIGTERM. When aio_notify is optimized away, it is possible that
QEMU enters a blocking ppoll immediately afterwards and stays there,
On 23 July 2015 at 20:06, Alex Williamson wrote:
> The following changes since commit b69b30532e0a80e25449244c01b0cbed000c99a3:
>
> Update version for v2.4.0-rc2 release (2015-07-22 18:17:19 +0100)
>
> are available in the git repository at:
>
> git://github.com/awilliam/qemu-vfio.git tags/vfi
From: Peter Maydell
When accessing the dispatch pointer in an AddressSpace within an RCU
critical section we should always use atomic_rcu_read(). Fix an
access within memory_region_section_get_iotlb() which was incorrectly
doing a direct pointer access.
Signed-off-by: Peter Maydell
Message-Id:
From: Gonglei
If vnc's password is configured, it will leak memory
which cipher variable pointed on every vnc connection.
Cc: Daniel P. Berrange
Reviewed-by: Daniel P. Berrange
Signed-off-by: Gonglei
Message-Id: <1437556133-11268-1-git-send-email-arei.gong...@huawei.com>
Signed-off-by: Paolo
From: Nils Carlson
Commit 812c1057 introduced HUP detection on unix and tcp sockets prior
to a read in tcp_chr_read. This unfortunately broke CloudStack 4.2
which relied on the old behaviour where data on a socket was readable
even if a HUP was present.
A working solution is to properly check th
From: "Daniel P. Berrange"
The current unit test only verifies the encryption API,
resulting in us missing a recently introduced bug in the
decryption API from commit d3462e3. It was fortunately
later discovered & fixed by commit bd09594, thanks to the
QEMU I/O tests for qcow2 encryption, but we
The following changes since commit dc94bd9166af5236a56bd5bb06845911915a925c:
Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into
staging (2015-07-22 12:52:34 +0100)
are available in the git repository at:
git://github.com/bonzini/qemu.git tags/for-upstream
for you
Signed-off-by: Paolo Bonzini
---
qemu-char.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 617e034..3200200 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2797,7 +2797,10 @@ static ssize_t tcp_chr_recv(CharDriverState *chr, char
From: Stefan Weil
This regression was caused by commit 70b94331.
CCvl.o
vl.c: In function ‘select_display’:
vl.c:2064:12: error: unused variable ‘err’ [-Werror=unused-variable]
Error *err = NULL;
^
Reported-by: Claudio Fontana
Signed-off-by: Stefan Weil
Message-Id: <143
For a board that has multiple framebuffer devices, both of them
might want to use DIRTY_MEMORY_VGA on the same memory region.
The lack of reference counting in memory_region_set_log makes
this very awkward to implement.
Suggested-by: Peter Maydell
Signed-off-by: Paolo Bonzini
---
include/exec/m
Otherwise, grace periods are detected too early!
Signed-off-by: Paolo Bonzini
---
cpus.c| 6 ++
iothread.c| 5 +
migration/migration.c | 4
tests/test-rcu-list.c | 4
util/rcu.c| 2 ++
5 files changed, 21 insertions(+)
diff --git a/cpus.
The MemoryRegionSection contains enough information to access the
RAM region underlying the framebuffer, and can be cached inside the
display device.
By doing this, the new framebuffer_update_memory_section function can
enable dirty memory logging on the relevant RAM region. The function
must be
From: Matthew Rosato
Currently, scsi_get_configuration always returns a current
profile (DVD or CD), even when there is actually no media present.
By comparison, ide/atapi uses a default profile of 0 (MMC_PROFILE_NONE)
for this case and checks for tray_open, so let's do the same for scsi.
This f
From: Dmitry Poletaev
There is a cut-and-paste mistake in the patch
https://lists.gnu.org/archive/html/qemu-devel/2014-11/msg01657.html .
It cause errors in guest work. Here is the bugfix.
Signed-off-by: Dmitry Poletaev
Reported-by: Kirill Batuzov
Message-Id: <2692911436348...@web2m.yandex.ru
This is a guest-triggerable buffer overflow present in QEMU 2.2.0
and newer. scsi_cdb_length returns -1 as an error value, but the
caller does not check it.
Luckily, the massive overflow means that QEMU will just SIGSEGV,
making the impact much smaller.
Reported-by: Zhu Donghai (朱东海)
Fixes: 189
From: Gonglei
Signed-off-by: Gonglei
Message-Id: <1435917057-9396-1-git-send-email-arei.gong...@huawei.com>
Reviewed-by: Peter Maydell
Signed-off-by: Paolo Bonzini
---
qemu-doc.texi | 2 +-
qemu-options.hx | 2 +-
qemu-tech.texi | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
dif
On 24 July 2015 at 11:12, Paolo Bonzini wrote:
> aio_notify can be optimized away, and in fact almost always will. However,
> qemu_notify_event is used in places where this is incorrect---most notably,
> when handling SIGTERM. When aio_notify is optimized away, it is possible that
> QEMU enters
On Fri, 24 Jul 2015, Jan Beulich wrote:
> The number of slots per page being 511 (i.e. not a power of two) means
> that the (32-bit) read and write indexes going beyond 2^32 will likely
> disturb operation. The hypervisor side gets I/O req server creation
> extended so we can indicate that we're us
This could be used by VM FT solutions like Macrocheckpointing,
to buffer/release packets.
Usage:
-netdev tap,id=bn0 # you can use whatever backend as needed
-netdev filter,id=f0,backend=bn0
-netdev filter-buffer,id=p0,filter=f0
-device e1000,netdev=f0
Will supply a public API to release
This patch add a net filter between network backend and NIC devices.
All packets will pass by this filter.
Also implement a netbuffer plugin for example, the netbuffer plugin
could be used by VM FT solutions like Macrocheckpointing,
to buffer/release packets.
Based on this, dump plugin could be eas
virtio-net explicity check for tap device, aupport for tap
with filter attached.
Signed-off-by: Yang Hongyang
---
hw/net/virtio-net.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 304d3dd..59e9707 100644
---
Signed-off-by: Yang Hongyang
---
include/net/queue.h | 7 +++
net/queue.c | 12 ++--
2 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/include/net/queue.h b/include/net/queue.h
index fc02b33..fea6c51 100644
--- a/include/net/queue.h
+++ b/include/net/queue.h
@@
Signed-off-by: Yang Hongyang
---
net/filter.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/net/filter.c b/net/filter.c
index 89ee830..7ef7bee 100644
--- a/net/filter.c
+++ b/net/filter.c
@@ -11,6 +11,7 @@
#include "qemu-common.h"
#include "qemu/error-report.h"
#include "
Signed-off-by: Yang Hongyang
---
include/net/net.h | 2 ++
net/net.c | 18 ++
2 files changed, 20 insertions(+)
diff --git a/include/net/net.h b/include/net/net.h
index 250f365..10927e1 100644
--- a/include/net/net.h
+++ b/include/net/net.h
@@ -108,6 +108,8 @@ char *qemu
Signed-off-by: Yang Hongyang
---
include/net/filter.h | 3 ++
net/filter-buffer.c | 107 ++-
2 files changed, 109 insertions(+), 1 deletion(-)
diff --git a/include/net/filter.h b/include/net/filter.h
index 44ba10f..f640cf7 100644
--- a/include/n
Am 23.07.2015 um 21:20 hat Shailesh Kumar geschrieben:
> On Mon, Feb 23, 2015 at 3:25 AM, Kevin Wolf wrote:
> > Am 11.02.2015 um 04:51 hat Shailesh Kumar geschrieben:
> >> Hi,
> >>
> >> I am implementing read equivalent routine in qemu. Can some one
> >> help me understand control flow of the
This patch add a net filter between network backend and NIC devices.
All packets will pass by this filter.
TODO:
multiqueue support.
+--+ +-+
+--+ |filter| |frontend(NIC)|
| peer+--> | |
Signed-off-by: Yang Hongyang
---
net/net.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/net/net.c b/net/net.c
index c273981..321362f 100644
--- a/net/net.c
+++ b/net/net.c
@@ -385,9 +385,20 @@ void qemu_del_net_client(NetClientState *nc)
{
NetClientState *ncs[MAX_QUEUE_N
Signed-off-by: Yang Hongyang
---
include/net/queue.h | 19 +++
net/queue.c | 19 ---
2 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/include/net/queue.h b/include/net/queue.h
index fea6c51..3cdd669 100644
--- a/include/net/queue.h
+++ b/inc
This large region is necessary for some devices like ivshmem and video cards
Signed-off-by: Pavel Fedin
---
Changes since v1:
- Region address changed to 512G, leaving more space for RAM
---
hw/arm/virt.c | 13 -
include/hw/arm/virt.h | 1 +
2 files changed, 13 insertions(+
On 24 July 2015 at 04:43, Richard Henderson wrote:
> Whee. Back from holidays just in time for -rc3.
>
> Three of these four patches attack the truncation problem that Leon
> pointed out for us affecting mips. The last is a patch that Aurelien
> asked to be included on IRC.
>
>
> r~
>
>
> The fo
This patchset improves the code generation for the SH4 target, by using
new TCG ops or using some tricks.
Aurelien Jarno (5):
target-sh4: add flags markups for FP helpers
target-sh4: use deposit in swap.b instruction
target-sh4: improve cmp/str instruction
target-sh4: improve shld instruct
The SH4 shld instruction can shift in both direction, depending on the
sign of the shift. This is currently implemented using branches, which
is not really efficient and prevents the optimizer to do its job. In
practice it is often used with a constant loaded in a register just
before.
Simplify th
Signed-off-by: Aurelien Jarno
---
target-sh4/translate.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/target-sh4/translate.c b/target-sh4/translate.c
index 3b4a1b5..a6f3f59 100644
--- a/target-sh4/translate.c
+++ b/target-sh4/translate.c
@@ -612,15 +612,11 @@ static
Most floating point helpers can trigger an exception, but don't change
the globals. Mark these helpers as TCG_CALL_NO_WG.
Signed-off-by: Aurelien Jarno
---
target-sh4/helper.h | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/target-sh4/help
The SH4 shad instruction can shift in both direction, depending on the
sign of the shift. This is currently implemented using branches, which
is not really efficient and prevents the optimizer to do its job. In
practice it is often used with a constant loaded in a register just
before.
Simplify th
Instead of testing bytes one by one, we can use the following trick
from https://graphics.stanford.edu/~seander/bithacks.html:
haszero(v) = (v - 0x01010101) & ~v & 0x80808080
The subexpression v - 0x01010101, evaluates to a high bit set in any
byte whenever the corresponding byte in v is zero o
On 2015-07-24 13:14, Aurelien Jarno wrote:
> The SH4 shad instruction can shift in both direction, depending on the
> sign of the shift. This is currently implemented using branches, which
> is not really efficient and prevents the optimizer to do its job. In
> practice it is often used with a cons
Eric Blake writes:
> On 07/01/2015 02:21 PM, Markus Armbruster wrote:
>> qapi-event.py breaks when you ask for a funny prefix like '@'.
>> Protect it.
>
> Only possible from the command line (not triggered by our makefiles);
> but doesn't hurt.
>
>>
>> Signed-off-by: Markus Armbruster
>> ---
>>
aio_notify can be optimized away, and in fact almost always will. However,
qemu_notify_event is used in places where this is incorrect---most notably,
when handling SIGTERM. When aio_notify is optimized away, it is possible that
QEMU enters a blocking ppoll immediately afterwards and stays there,
Eric Blake writes:
> On 07/01/2015 02:21 PM, Markus Armbruster wrote:
>> gen_sync_call()'s parameter indent is useless: gen_sync_call() uses it
>> only as optional argument for push_indent() and pop_indent(), their
>> default is four, and gen_sync_call()'s only caller passes four.
>>
>> gen_visi
On 23/07/15 14:07, Igor Mammedov wrote:
> On Wed, 22 Jul 2015 15:59:50 +0200
> Thomas Huth wrote:
>
>> The code in smp_parse already checks the topology information for
>> sockets * cores * threads < cpus and bails out with an error in
>> that case. However, it is still possible to supply a bad c
On 24 July 2015 at 11:16, Paolo Bonzini wrote:
> The following changes since commit dc94bd9166af5236a56bd5bb06845911915a925c:
>
> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request'
> into staging (2015-07-22 12:52:34 +0100)
>
> are available in the git repository at:
>
>
Eric Blake writes:
> On 07/01/2015 02:21 PM, Markus Armbruster wrote:
>> The struct generated for a flat union is weird: the members of its
>> base are at the end, except for the union tag, which is renamed to
>> 'kind' and put at the beginning.
>>
>
>> Change to put all base members at the begi
On 24/07/2015 13:56, Peter Maydell wrote:
> MALLOC_PERTURB_=${MALLOC_PERTURB_:-$((RANDOM % 255 + 1))} gtester -k
> --verbose -m=quick tests/test-crypto-cipher
> TEST: tests/test-crypto-cipher... (pid=94271)
> /crypto/cipher/aes-ecb-128: **
> ERROR:/Users
The following changes since commit dc94bd9166af5236a56bd5bb06845911915a925c:
Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into
staging (2015-07-22 12:52:34 +0100)
are available in the git repository at:
git://github.com/bonzini/qemu.git tags/for-upstream
for you
On Fri, Jul 24, 2015 at 02:02:57PM +0200, Paolo Bonzini wrote:
>
>
> On 24/07/2015 13:56, Peter Maydell wrote:
> > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$((RANDOM % 255 + 1))} gtester -k
> > --verbose -m=quick tests/test-crypto-cipher
> > TEST: tests/test-crypto-cipher... (pid=94271)
> > /crypto/c
On Fri, Jul 24, 2015 at 02:02:57PM +0200, Paolo Bonzini wrote:
>
>
> On 24/07/2015 13:56, Peter Maydell wrote:
> > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$((RANDOM % 255 + 1))} gtester -k
> > --verbose -m=quick tests/test-crypto-cipher
> > TEST: tests/test-crypto-cipher... (pid=94271)
> > /crypto/c
On 24/07/2015 14:24, Daniel P. Berrange wrote:
>> > I'll respin without this patch. I can reproduce it with
>> > --disable-gnutls. Dan, can you take a look?
> So this patch was not actually causing the problem, merely exposing a
> latent bug.
Yes, that was likely.
> I've just sent a fix for t
We have a qemu_fls() function which is just a silly wrapper
around clz32() and which is used in only a handful of places
in the codebase. It turns out that all of those are really
trying to round up or down to a power of 2, which is something
we have utility functions for. This series replaces all
On 07/20/2015 10:19 PM, Benjamin Herrenschmidt wrote:
> Currently, we get to the slow path for any unaligned access in the
> backend, because we effectively preserve the bottom address bits
> below the alignment requirement when comparing with the TLB entry,
> so any non-0 bit there will cause the
On Fri, Jul 24, 2015 at 02:30:02PM +0200, Paolo Bonzini wrote:
>
>
> On 24/07/2015 14:24, Daniel P. Berrange wrote:
> >> > I'll respin without this patch. I can reproduce it with
> >> > --disable-gnutls. Dan, can you take a look?
> > So this patch was not actually causing the problem, merely ex
Use pow2ceil() to round up to the next power of 2, rather
than an inline calculation.
Signed-off-by: Peter Maydell
---
hw/block/nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 40d4880..5da41b2 100644
--- a/hw/block/nvme.c
+++ b/h
Use pow2floor() to round down to the nearest power of 2,
rather than an inline calculation.
Signed-off-by: Peter Maydell
---
exec.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/exec.c b/exec.c
index 7d60e15..4710e2d 100644
--- a/exec.c
+++ b/exec.c
@@ -2371,9 +2371,7 @@
Use the utility function pow2ceil() for rounding up to the next
largest power of 2, rather than inline calculation.
Signed-off-by: Peter Maydell
---
hw/virtio/virtio-pci.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index
Nothing uses qemu_fls() any more, so delete it.
Signed-off-by: Peter Maydell
---
include/qemu-common.h | 1 -
util/cutils.c | 5 -
2 files changed, 6 deletions(-)
diff --git a/include/qemu-common.h b/include/qemu-common.h
index 237d654..bc6f8f8 100644
--- a/include/qemu-common.h
+++
A couple of places in hw/pci use an inline calculation to round a
size up to the next largest power of 2. We have a utility routine
for this, so use it.
(The behaviour of the old code is different if the size value
is 0 -- it would leave it as 0 rather than rounding up to 1,
but in both cases we k
On Wed, Jul 08, 2015 at 04:48:27PM +0100, Peter Maydell wrote:
> On 8 July 2015 at 16:21, Paolo Bonzini wrote:
> >
> >
> > On 08/07/2015 16:46, Peter Maydell wrote:
> >> I'm afraid this fails to link on my linux-static build:
> >>
> >> c++ -I/usr/include/pixman-1-Werror -m64 -D_GNU_SOURCE
> >>
Since the pow2floor() function is now used in a hot code path,
make it inline; for consistency, provide pow2ceil() as an inline
function too.
Because these functions use ctz64() we have to put the inline
versions into host-utils.h, so they have access to ctz64(),
and move the inline is_power_of_2(
On 24/07/2015 14:52, Daniel P. Berrange wrote:
> I'm happy to fix configure to check that gnutls has working static
> libs, but we do have a much broader pre-existing problem in this respect.
> So it seems people wanting todo static builds currently have to deal with
> installing all the correct
On 24 July 2015 at 13:53, Paolo Bonzini wrote:
>
>
> On 24/07/2015 14:52, Daniel P. Berrange wrote:
>> I'm happy to fix configure to check that gnutls has working static
>> libs, but we do have a much broader pre-existing problem in this respect.
>> So it seems people wanting todo static builds cu
On 24/07/2015 15:00, Peter Maydell wrote:
> > > I'm happy to fix configure to check that gnutls has working static
> > > libs, but we do have a much broader pre-existing problem in this respect.
> > > So it seems people wanting todo static builds currently have to deal with
> > > installing all t
On 24 July 2015 at 14:00, Peter Maydell wrote:
> On 24 July 2015 at 13:53, Paolo Bonzini wrote:
>> Ok, then it looks like a preexisting problem indeed.
>
> Well, not entirely. This set of configure flags used to work,
> and now it does not. That's a regression.
In particular, configure --static
On Fri, Jul 24, 2015 at 02:06:44PM +0100, Peter Maydell wrote:
> On 24 July 2015 at 14:00, Peter Maydell wrote:
> > On 24 July 2015 at 13:53, Paolo Bonzini wrote:
> >> Ok, then it looks like a preexisting problem indeed.
> >
> > Well, not entirely. This set of configure flags used to work,
> > an
Am 23.07.2015 um 14:48 hat Stefan Hajnoczi geschrieben:
> v3:
> * Fix Patch 2 commit description because the mention of raw-posix.c ignored
>Windows [Markus]
> * Drop #ifdef CONFIG_LINUX_AIO from qemu-nbd.c
>
> v2:
> * Banish CONFIG_LINUX_AIO from blockdev.c, that is raw-posix.c's business
The qcrypto_cipher_decrypt_aes method was using the wrong
key material, and passing the wrong mode. This caused it
to incorrectly decrypt ciphertext.
Signed-off-by: Daniel P. Berrange
---
crypto/cipher-builtin.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/crypto/c
On 07/24/2015 04:14 AM, Aurelien Jarno wrote:
> This patchset improves the code generation for the SH4 target, by using
> new TCG ops or using some tricks.
>
> Aurelien Jarno (5):
> target-sh4: add flags markups for FP helpers
> target-sh4: use deposit in swap.b instruction
> target-sh4: imp
On 24 July 2015 at 14:10, Daniel P. Berrange wrote:
> On Fri, Jul 24, 2015 at 02:06:44PM +0100, Peter Maydell wrote:
>> On 24 July 2015 at 14:00, Peter Maydell wrote:
>> > On 24 July 2015 at 13:53, Paolo Bonzini wrote:
>> >> Ok, then it looks like a preexisting problem indeed.
>> >
>> > Well, no
Someone has posted a similar fix a few weeks ago, and it has just been
merged.
** Changed in: qemu
Status: New => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1477683
Title:
On Thu, Jul 23, 2015 at 9:11 PM, Peter Maydell wrote:
> I'm happy to be able to announce that the QEMU project
> has joined Software Freedom Conservancy.
I added a wiki page listing the Leadership Committee members and
explaining the relationship with Software Freedom Conservancy:
http://qemu-pro
On Fri, Jul 24, 2015 at 02:31:12PM +0100, Peter Maydell wrote:
> On 24 July 2015 at 14:10, Daniel P. Berrange wrote:
> > On Fri, Jul 24, 2015 at 02:06:44PM +0100, Peter Maydell wrote:
> >> On 24 July 2015 at 14:00, Peter Maydell wrote:
> >> > On 24 July 2015 at 13:53, Paolo Bonzini wrote:
> >> >
1 - 100 of 164 matches
Mail list logo
