Re: [Qemu-devel] [RFC PATCH V6 01/18] cpu: make cpu_thread_is_idle public.

2015-07-07 Thread Frederic Konrad
On 07/07/2015 11:47, Alex Bennée wrote: fred.kon...@greensocs.com writes: From: KONRAD Frederic Why are we making this visible? Looking at the tree I can't see it being used outside the cpus.c. I see the function is modified later for async work. Is this something we are planing to use later?

Re: [Qemu-devel] [BUG/RFC] Two cpus are not brought up normally in SLES11 sp3 VM after reboot

2015-07-07 Thread zhanghailiang
On 2015/7/7 19:23, Igor Mammedov wrote: On Mon, 6 Jul 2015 17:59:10 +0800 zhanghailiang wrote: On 2015/7/6 16:45, Paolo Bonzini wrote: On 06/07/2015 09:54, zhanghailiang wrote: From host, we found that QEMU vcpu1 thread and vcpu7 thread were not consuming any cpu (Should be in idle stat

Re: [Qemu-devel] [RFC PATCH V6 02/18] replace spinlock by QemuMutex.

2015-07-07 Thread Frederic Konrad
On 07/07/2015 12:15, Alex Bennée wrote: fred.kon...@greensocs.com writes: From: KONRAD Frederic spinlock is only used in two cases: * cpu-exec.c: to protect TranslationBlock * mem_helper.c: for lock helper in target-i386 (which seems broken). It's a pthread_mutex_t in user-mode so bett

[Qemu-devel] [PATCH] s390/virtio-ccw: Fix migration

2015-07-07 Thread Christian Borntraeger
commit 213941d73b ("virtio-ccw: migrate ->revision") broke migration: 2015-07-07T11:22:55.570968Z qemu-system-s390x: VQ 39 address 0x0 inconsistent with Host index 0x100 2015-07-07T11:22:55.571008Z qemu-system-s390x: error while loading state for instance 0x0 of If thinint support is active, the

Re: [Qemu-devel] [RFC PATCH V6 02/18] replace spinlock by QemuMutex.

2015-07-07 Thread Frederic Konrad
On 07/07/2015 12:22, Paolo Bonzini wrote: On 07/07/2015 12:15, Alex Bennée wrote: Why are the locking rules different for CONFIG_USER versus system emulation? Looking at the final tree: tb = tb_find_fast(env); this eventually ends up doing a tb_lock on the find_slow path wh

Re: [Qemu-devel] [Qemu-block] [PATCH v2] opts: produce valid command line in qemu_opts_print

2015-07-07 Thread Stefan Hajnoczi
On Fri, Jul 03, 2015 at 04:45:36PM +0200, Kővágó, Zoltán wrote: > This will let us print options in a format that the user would actually > write it on the command line (foo=bar,baz=asd,etc=def), without > prepending a spurious comma at the beginning of the list, or quoting > values unnecessarily.

Re: [Qemu-devel] [Qemu-block] [PATCH] block/raw-posix: Don't think /dev/fd/ is a floppy drive.

2015-07-07 Thread Stefan Hajnoczi
On Wed, Jul 01, 2015 at 03:40:14PM +0100, Richard W.M. Jones wrote: > In libguestfs we use /dev/fd/ to pass pre-opened file descriptors > to qemu-img. Lately I've discovered that although this works, qemu > believes that these are floppy disk images. That in itself isn't much > of a problem, but

Re: [Qemu-devel] [PATCH qemu v10 14/14] spapr_pci/spapr_pci_vfio: Support Dynamic DMA Windows (DDW)

2015-07-07 Thread Alexey Kardashevskiy
On 07/07/2015 09:35 PM, Thomas Huth wrote: On Tue, 7 Jul 2015 20:43:44 +1000 Alexey Kardashevskiy wrote: On 07/07/2015 07:33 PM, Thomas Huth wrote: On Mon, 6 Jul 2015 12:11:10 +1000 Alexey Kardashevskiy wrote: ... +static void rtas_ibm_create_pe_dma_window(PowerPCCPU *cpu, +

Re: [Qemu-devel] [PATCH] blockjob: add block_job_release function

2015-07-07 Thread Stefan Hajnoczi
On Fri, Jun 26, 2015 at 05:37:35PM +0800, Ting Wang wrote: > There is job resource leak in function mirror_start_job, > although bdrv_create_dirty_bitmap is unlikely failed. > Add block_job_release for each release when needed. > > Signed-off-by: Ting Wang > --- > block/mirror.c | 2

Re: [Qemu-devel] [Qemu-block] [PATCH v2 01/13] block: Use bdrv_drain to replace uncessary bdrv_drain_all

2015-07-07 Thread Stefan Hajnoczi
On Tue, Jun 16, 2015 at 05:01:04PM +0100, Stefan Hajnoczi wrote: > On Tue, Jun 02, 2015 at 11:21:50AM +0800, Fam Zheng wrote: > > There callers work on a single BlockDriverState subtree, where using > > bdrv_drain() is more accurate. > > > > Signed-off-by: Fam Zheng > > Reviewed-by: Paolo Bonzini

[Qemu-devel] [PULL for-2.4 0/7] Block patches

2015-07-07 Thread Stefan Hajnoczi
The following changes since commit f6e3035f75e5c6a73485335765ae070304c7a110: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream-smm' into staging (2015-07-06 23:37:53 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for

[Qemu-devel] [PULL for-2.4 3/7] block/nfs: add support for setting debug level

2015-07-07 Thread Stefan Hajnoczi
From: Peter Lieven upcoming libnfs versions will support logging debug messages. Add support for it in qemu through a per-drive option. Examples: qemu -drive if=virtio,file=nfs://...,file.debug=2 qemu-img create -o debug=2 nfs://... 10G Signed-off-by: Peter Lieven Reviewed-by: Fam Zheng Mes

[Qemu-devel] [PULL for-2.4 1/7] qcow2: remove unnecessary check

2015-07-07 Thread Stefan Hajnoczi
From: Alberto Garcia The value of 'i' is guaranteed to be >= 0 Signed-off-by: Alberto Garcia Message-id: 1435824371-2660-1-git-send-email-be...@igalia.com Signed-off-by: Stefan Hajnoczi --- block/qcow2-cache.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/block/qcow2-cache.c b/block/q

[Qemu-devel] [PULL for-2.4 2/7] block: update bdrv_drain_all()/bdrv_drain() comments

2015-07-07 Thread Stefan Hajnoczi
The doc comments for bdrv_drain_all() and bdrv_drain() are outdated: * The bdrv_drain() comment is a poor man's bdrv_lock()/bdrv_unlock() which Fam Zheng is currently developing. Unfortunately this warning was never really enough because devices keep submitting I/O and op blockers don't

[Qemu-devel] [PULL for-2.4 4/7] block: Initialize local_err in bdrv_append_temp_snapshot

2015-07-07 Thread Stefan Hajnoczi
From: Fam Zheng Cc: qemu-sta...@nongnu.org Signed-off-by: Fam Zheng Message-id: 1436156684-16526-1-git-send-email-f...@redhat.com Signed-off-by: Stefan Hajnoczi --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 7e130cc..42eb8e3 100644 --- a

[Qemu-devel] [PULL for-2.4 5/7] block: Use bdrv_drain to replace uncessary bdrv_drain_all

2015-07-07 Thread Stefan Hajnoczi
From: Fam Zheng There callers work on a single BlockDriverState subtree, where using bdrv_drain() is more accurate. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- block.c | 6 +++--- block/snapshot.c | 2 +- migration/block.c | 2 +- 3 files changed, 5 insertions(+), 5

[Qemu-devel] [PULL for-2.4 6/7] block/raw-posix: Don't think /dev/fd/ is a floppy drive.

2015-07-07 Thread Stefan Hajnoczi
From: "Richard W.M. Jones" In libguestfs we use /dev/fd/ to pass pre-opened file descriptors to qemu-img. Lately I've discovered that although this works, qemu believes that these are floppy disk images. That in itself isn't much of a problem, but now qemu prints a warning about host floppy pas

Re: [Qemu-devel] [PATCH qemu v10 13/14] vfio: spapr: Add SPAPR IOMMU v2 support (DMA memory preregistering)

2015-07-07 Thread Alexey Kardashevskiy
On 07/07/2015 02:13 AM, Alex Williamson wrote: On Tue, 2015-07-07 at 01:34 +1000, Alexey Kardashevskiy wrote: On 07/06/2015 11:42 PM, Alex Williamson wrote: On Mon, 2015-07-06 at 12:11 +1000, Alexey Kardashevskiy wrote: This makes use of the new "memory registering" feature. The idea is to pro

[Qemu-devel] [PULL for-2.4 7/7] blockjob: add block_job_release function

2015-07-07 Thread Stefan Hajnoczi
From: Ting Wang There is job resource leak in function mirror_start_job, although bdrv_create_dirty_bitmap is unlikely failed. Add block_job_release for each release when needed. Signed-off-by: Ting Wang Reviewed-by: John Snow Message-id: 1435311455-56048-1-git-send-email-kathy.wangt...@huawei

Re: [Qemu-devel] [BUG/RFC] Two cpus are not brought up normally in SLES11 sp3 VM after reboot

2015-07-07 Thread Igor Mammedov
On Tue, 7 Jul 2015 19:43:35 +0800 zhanghailiang wrote: > On 2015/7/7 19:23, Igor Mammedov wrote: > > On Mon, 6 Jul 2015 17:59:10 +0800 > > zhanghailiang wrote: > > > >> On 2015/7/6 16:45, Paolo Bonzini wrote: > >>> > >>> > >>> On 06/07/2015 09:54, zhanghailiang wrote: > > From host,

Re: [Qemu-devel] [RFC PATCH V6 05/18] protect TBContext with tb_lock.

2015-07-07 Thread Alex Bennée
fred.kon...@greensocs.com writes: > From: KONRAD Frederic > > This protects TBContext with tb_lock to make tb_* thread safe. > > We can still have issue with tb_flush in case of multithread TCG: > An other CPU can be executing code during a flush. > > This can be fixed later by making all othe

[Qemu-devel] [PULL 3/3] virtio-gpu: add to display-vga test

2015-07-07 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/Makefile | 3 +++ tests/display-vga-test.c | 18 ++ 2 files changed, 21 insertions(+) diff --git a/tests/Makefile b/tests/Makefile index eff5e11..2cd1195 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -135,6 +135,9 @@ check-q

[Qemu-devel] [PULL for-2.4 0/3] vga patch queue

2015-07-07 Thread Gerd Hoffmann
0:55 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-vga-20150707-1 for you to fetch changes up to 501eea4f4187b6c62b6cf348ab0b100d57d8c56b: virtio-gpu: add to display-vga test (2015-07-07 11:2

[Qemu-devel] [PULL 2/3] virtio-gpu: use virtio_instance_init_common, fixup properties

2015-07-07 Thread Gerd Hoffmann
Switch over to virtio_instance_init_common. Drop duplicate properties in virtio-gpu-pci and virtio-vga as they are properly aliased now. Also drop the indirection via DEFINE_VIRTIO_GPU_PROPERTIES, we don't need it any more as the properties are defined in a single place now. Signed-off-by: Gerd

[Qemu-devel] [PULL 1/3] virtio-gpu: update console device property.

2015-07-07 Thread Gerd Hoffmann
Update the device link of the QemuConsole, so it points to the virtio-gpu-pci or virtio-vga device instead of virtio-gpu-device. This is needed because we want to find the device by id, for example for input routing, and the id specified on the command line is attached to the pci proxy, not the vi

Re: [Qemu-devel] [RFC PATCH V6 06/18] tcg: remove tcg_halt_cond global variable.

2015-07-07 Thread Alex Bennée
Frederic Konrad writes: > On 26/06/2015 17:02, Paolo Bonzini wrote: >> >> On 26/06/2015 16:47, fred.kon...@greensocs.com wrote: >>> From: KONRAD Frederic >>> >>> This removes tcg_halt_cond global variable. >>> We need one QemuCond per virtual cpu for multithread TCG. >>> >>> Signed-off-by: KONR

Re: [Qemu-devel] [RFC PATCH V6 07/18] Drop global lock during TCG code execution

2015-07-07 Thread Alex Bennée
Frederic Konrad writes: > On 26/06/2015 16:56, Jan Kiszka wrote: >> On 2015-06-26 16:47, fred.kon...@greensocs.com wrote: >>> From: Jan Kiszka >>> >>> This finally allows TCG to benefit from the iothread introduction: Drop >>> the global mutex while running pure TCG CPU code. Reacquire the lock

Re: [Qemu-devel] [RFC PATCH V6 02/18] replace spinlock by QemuMutex.

2015-07-07 Thread Paolo Bonzini
On 07/07/2015 13:48, Frederic Konrad wrote: >>> this eventually ends up doing a tb_lock on the find_slow path which IIRC >>> is when might end up doing the actual code generation. >> >> Up to this point, system emulation is using the BQL for everything. I >> guess things change later. > > Actual

Re: [Qemu-devel] qemu build fails on xen

2015-07-07 Thread Peter Maydell
On 7 July 2015 at 10:26, Paul Durrant wrote: >> -Original Message- >> From: Michael S. Tsirkin [mailto:m...@redhat.com] >> Sent: 07 July 2015 09:48 >> To: Stefano Stabellini >> Cc: Chen, Tiejun; pbonz...@redhat.com; r...@twiddle.net; >> ehabk...@redhat.com; qemu-devel@nongnu.org; Paul Durr

[Qemu-devel] [PULL for-2.4 0/9] Net patches

2015-07-07 Thread Stefan Hajnoczi
The following changes since commit f6e3035f75e5c6a73485335765ae070304c7a110: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream-smm' into staging (2015-07-06 23:37:53 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/net-pull-request for yo

[Qemu-devel] [PULL for-2.4 2/9] e1000: flush packets when link comes up

2015-07-07 Thread Stefan Hajnoczi
e1000_can_receive() checks the link up status register bit. If the bit is clear, packets will be queued and the peer may disable receive to avoid wasting CPU reading packets that cannot be delivered. The queue must be flushed once the link comes back up again. This patch fixes broken e1000 recei

[Qemu-devel] [PULL for-2.4 7/9] rocker: return -1 when dropping packet on ingress

2015-07-07 Thread Stefan Hajnoczi
From: Scott Feldman Signed-off-by: Scott Feldman Message-id: 1435746792-41278-4-git-send-email-sfel...@gmail.com Signed-off-by: Stefan Hajnoczi --- hw/net/rocker/rocker_world.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/rocker/rocker_world.c b/hw/net/rocker/rock

[Qemu-devel] [PULL for-2.4 1/9] rocker: fix memory leak

2015-07-07 Thread Stefan Hajnoczi
From: Gonglei Meanwhile, using g_new0 instead of g_malloc0, refer to commit 5839e53. Signed-off-by: Gonglei Message-id: 1435213450-6700-1-git-send-email-arei.gong...@huawei.com Signed-off-by: Stefan Hajnoczi --- hw/net/rocker/rocker.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) d

[Qemu-devel] [PULL for-2.4 3/9] vmxnet3: Fix incorrect small packet padding

2015-07-07 Thread Stefan Hajnoczi
From: Brian Kress When running ESXi under qemu there is an issue with the ESXi guest discarding packets that are too short. The guest discards any packets under the normal minimum length for an ethernet packet (60). This results in odd behaviour where other hosts or VMs on other hosts can commu

[Qemu-devel] [PULL for-2.4 4/9] rocker: don't queue receive pkts when port is disabled

2015-07-07 Thread Stefan Hajnoczi
From: Scott Feldman Commit 6e99c63 ("net/socket: Drop net_socket_can_send") changed the semantics around .can_receive for sockets to now require the device to flush queued pkts when transitioning to a .can_receive=true state. Rocker device was not flushing the queue on .can_receive=true transiti

[Qemu-devel] [PULL for-2.4 8/9] rocker: mark copy-to-cpu pkts as forwarding offloaded

2015-07-07 Thread Stefan Hajnoczi
From: Scott Feldman For pkts copied to the CPU (to be processed by guest driver), mark the Rx descriptor with flag "OFFLOAD_FWD" to indicate device has already forwarded pkt. The guest driver will use this indicator to avoid duplicate forwarding in the guest OS. Examples include bcast/mcast/unk

[Qemu-devel] [PULL for-2.4 6/9] rocker: fix missing break statements

2015-07-07 Thread Stefan Hajnoczi
From: Scott Feldman Signed-off-by: Scott Feldman Reported-by: Paolo Bonzini Message-id: 1435746792-41278-3-git-send-email-sfel...@gmail.com Signed-off-by: Stefan Hajnoczi --- hw/net/rocker/rocker.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/ro

[Qemu-devel] [PULL for-2.4 9/9] rocker: tests: don't need to specify master/self when setting vlans

2015-07-07 Thread Stefan Hajnoczi
From: Scott Feldman 4.1 Linux kernel doesn't require specifying "master" or "self" when setting vlans on a port, so clean these up from the tests that use vlans. Signed-off-by: Scott Feldman Message-id: 1435746792-41278-6-git-send-email-sfel...@gmail.com Signed-off-by: Stefan Hajnoczi --- tes

[Qemu-devel] [PULL for-2.4 5/9] rocker: fix misplaced break statement

2015-07-07 Thread Stefan Hajnoczi
From: Scott Feldman Premature break in switch case block. This particular case (group L2 rewrite) will be used for L2 LAG and L3 ECMP support, neither of which are enabled in the guest driver at this time, but are under development. Signed-off-by: Scott Feldman Reported-by: Paolo Bonzini Mess

Re: [Qemu-devel] [PATCH 00/27] sPAPR updates 2015-07-02

2015-07-07 Thread Alexander Graf
On 07/02/15 08:23, David Gibson wrote: Hi Alex, Here are my accumulated spapr related qemu updates for the last little while. This obsoletes the patch series I sent for 2015-06-24, since those haven't been merged yet. Highlights are a SLOF update and changes to move PCI device node creation fr

[Qemu-devel] [PULL 01/13] dataplane: fix cross-endian issues

2015-07-07 Thread Michael S. Tsirkin
From: Greg Kurz Accesses to vring_avail_event and vring_used_event must honor the queue endianness. This patch allows cross-endian setups to use dataplane (tested with ppc64 on ppc64le, and vice-versa). Suggested-by: Cornelia Huck Signed-off-by: Greg Kurz Reviewed-by: Michael S. Tsirkin Sign

[Qemu-devel] [PULL 10/13] virtio_net: reuse constants from linux

2015-07-07 Thread Michael S. Tsirkin
VIRTIO_NET_F_CTRL_GUEST_OFFLOADS now appears in the linux header, let's reuse it. Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio-net.h | 12 include/standard-headers/linux/virtio_net.h | 16 2 files changed, 16 insertions(+), 12 deletion

[Qemu-devel] [PULL 02/13] Revert "dataplane: allow virtio-1 devices"

2015-07-07 Thread Michael S. Tsirkin
From: Cornelia Huck This reverts commit f5a5628cf0b65b223fa0c9031714578dfac4cf04. This was an old patch that had been already superseded by b0e5d90eb ("dataplane: endianness-aware accesses"). Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Acked

[Qemu-devel] [PULL 00/13] pc,virtio,pci: fixes and updates

2015-07-07 Thread Michael S. Tsirkin
The following changes since commit f6e3035f75e5c6a73485335765ae070304c7a110: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream-smm' into staging (2015-07-06 23:37:53 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upst

Re: [Qemu-devel] [PATCH v4 0/9] GIC-500 implementation, software + KVM

2015-07-07 Thread Pavel Fedin
> do you plan to resend a version without TCG code, just using shared base > class? Done that, you missed it: http://lists.nongnu.org/archive/html/qemu-devel/2015-07/msg00830.html Sorry for confusion with version numbers, i have to idea how to do this correctly when combining/splitting differ

[Qemu-devel] [PULL 03/13] acpi: split out ICH ACPI support

2015-07-07 Thread Michael S. Tsirkin
MIPS doesn't need it, and including it creates problem as we are adding dependency on ISA LPC bridge. Signed-off-by: Michael S. Tsirkin --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 + hw/acpi/Makefile.objs | 3 ++- 3 files changed, 4 insertion

[Qemu-devel] [PULL 04/13] ich9: add TCO interface emulation

2015-07-07 Thread Michael S. Tsirkin
From: Paulo Alcantara This interface provides some registers within a 32-byte range and can be acessed through PCI-to-LPC bridge interface (PMBASE + 0x60). It's commonly used as a watchdog timer to detect system lockups through SMIs that are generated -- if TCO_EN bit is set -- on every timeout.

Re: [Qemu-devel] [BUG/RFC] Two cpus are not brought up normally in SLES11 sp3 VM after reboot

2015-07-07 Thread zhanghailiang
On 2015/7/7 20:21, Igor Mammedov wrote: On Tue, 7 Jul 2015 19:43:35 +0800 zhanghailiang wrote: On 2015/7/7 19:23, Igor Mammedov wrote: On Mon, 6 Jul 2015 17:59:10 +0800 zhanghailiang wrote: On 2015/7/6 16:45, Paolo Bonzini wrote: On 06/07/2015 09:54, zhanghailiang wrote: From host,

[Qemu-devel] [PULL 06/13] ich9: implement strap SPKR pin logic

2015-07-07 Thread Michael S. Tsirkin
From: Paulo Alcantara If the signal is sampled high, this indicates that the system is strapped to the "No Reboot" mode (ICH9 will disable the TCO Timer system reboot feature). The status of this strap is readable via the NO_REBOOT bit (CC: offset 0x3410:bit 5). The NO_REBOOT bit is set when SPK

[Qemu-devel] [PULL 09/13] hw/i386/pc: don't carry FDC from pc_basic_device_init() to pc_cmos_init()

2015-07-07 Thread Michael S. Tsirkin
From: Laszlo Ersek Thanks to the last patch, pc_cmos_init() doesn't need the (optional) board-default FDC any longer as an input parameter. Update pc_basic_device_init() not to hand it back to pc_init1() / pc_q35_init(), and update the latter not to carry the FDC to pc_cmos_init(). This simplifie

[Qemu-devel] [PULL 05/13] tests: add testcase for TCO watchdog emulation

2015-07-07 Thread Michael S. Tsirkin
From: Paulo Alcantara This patch adds a testcase that covers the following: 1) TCO default values 2) first and second TCO timeout 3) watch and validate ticks counter through TCO_RLD register 4) maximum supported TCO timeout (0x3ff) 5) watchdog actions (pause/reset/shutdown/none) upon se

[Qemu-devel] [PULL 07/13] hw/i386/pc: factor out pc_cmos_init_floppy()

2015-07-07 Thread Michael S. Tsirkin
From: Laszlo Ersek Extract the pc_cmos_init_floppy() function from pc_cmos_init(). The function sets two RTC registers: floppy drive types (0x10), overwriting the earlier value in there), and REG_EQUIPMENT_BYTE (0x14), setting bits in the prior value. Cc: Jan Tomko Cc: John Snow Cc: Markus Arm

Re: [Qemu-devel] [PULL for-2.4 3/7] block/nfs: add support for setting debug level

2015-07-07 Thread Peter Lieven
Am 07.07.2015 um 14:08 schrieb Stefan Hajnoczi: From: Peter Lieven upcoming libnfs versions will support logging debug messages. Add support for it in qemu through a per-drive option. Examples: qemu -drive if=virtio,file=nfs://...,file.debug=2 qemu-img create -o debug=2 nfs://... 10G Sign

[Qemu-devel] [PULL 12/13] pcie: Set the "link active" in the link status register

2015-07-07 Thread Michael S. Tsirkin
From: Benjamin Herrenschmidt Some firmwares can test that and assume the device hasn't come up if that bit isn't set Signed-off-by: Benjamin Herrenschmidt Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/pci/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-devel] [PULL 08/13] hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS

2015-07-07 Thread Michael S. Tsirkin
From: Laszlo Ersek With the pc-q35-2.4 machine type, if the user creates an ISA FDC manually: -device isa-fdc,driveA=drive-fdc0-0-0 \ -drive file=...,if=none,id=drive-fdc0-0-0,format=raw then the board-default FDC will be skipped, and only the explicitly requested FDC will exist. qtree-wise

[Qemu-devel] [PULL 13/13] virtio: define virtio_pci_cfg_cap in header.

2015-07-07 Thread Michael S. Tsirkin
Update virtio pci header from linux-next virtio maintainer tree. We already have VIRTIO_PCI_CAP_PCI_CFG, let's define the structure that goes with it. Signed-off-by: Michael S. Tsirkin --- include/standard-headers/linux/virtio_pci.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/inclu

Re: [Qemu-devel] [PATCH V3] block/nfs: add support for setting debug level

2015-07-07 Thread Kevin Wolf
Am 07.07.2015 um 08:50 hat Peter Lieven geschrieben: > upcoming libnfs versions will support logging debug messages. Add > support for it in qemu through a per-drive option. > > Examples: > qemu -drive if=virtio,file=nfs://...,file.debug=2 > qemu-img create -o debug=2 nfs://... 10G > > Signed-o

[Qemu-devel] [PATCH] migration: Make events a capability

2015-07-07 Thread Juan Quintela
Make check fails with events. THis is due to the parser/lexer that it uses. Just in case that they are more broken parsers, just only send events when there are capabilities. Signed-off-by: Juan Quintela --- include/migration/migration.h | 1 + migration/migration.c | 20 +

[Qemu-devel] [PULL 11/13] pci_regs.h: import from linux

2015-07-07 Thread Michael S. Tsirkin
It seems to make sense to import pci_regs.h from linux: why maintain our own? As a first step, move the header to standard-headers, and add it to the update script. Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pci_regs.h | 720 +- include/stand

Re: [Qemu-devel] [PATCH v2 05/10] block: add block job transactions

2015-07-07 Thread Stefan Hajnoczi
On Tue, Jul 07, 2015 at 03:32:45PM +0800, Fam Zheng wrote: > On Mon, 07/06 15:24, Stefan Hajnoczi wrote: > > +/** > > + * block_job_txn_add_job: > > + * @txn: The transaction (may be NULL) > > + * @job: Job to add to the transaction > > + * > > + * Add @job to the transaction. The @job must not al

Re: [Qemu-devel] [RFC PATCH V6 08/18] cpu: remove exit_request global.

2015-07-07 Thread Alex Bennée
fred.kon...@greensocs.com writes: > From: KONRAD Frederic > > This removes exit_request global and adds a variable in CPUState for this. > Only the flag for the first cpu is used for the moment as we are still with > one > TCG thread. > > Signed-off-by: KONRAD Frederic > --- > cpu-exec.c | 15

Re: [Qemu-devel] [PULL 00/10] qemu-ga patches for 2.4.0

2015-07-07 Thread Olga Krishtal
On 07/07/15 13:32, Peter Maydell wrote: On 7 July 2015 at 05:40, Michael Roth wrote: Hi Peter, Sorry for the last minute pull. This is a round-up of all tested/reviewed qemu-ga patches posted prior to soft-freeze, along with 1 bug fix that came in last week. This adds win32 implementations of

Re: [Qemu-devel] [RFC PATCH V6 02/18] replace spinlock by QemuMutex.

2015-07-07 Thread Frederic Konrad
On 07/07/2015 14:34, Paolo Bonzini wrote: On 07/07/2015 13:48, Frederic Konrad wrote: this eventually ends up doing a tb_lock on the find_slow path which IIRC is when might end up doing the actual code generation. Up to this point, system emulation is using the BQL for everything. I guess thi

Re: [Qemu-devel] [PATCH] migration: Make events a capability

2015-07-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Make check fails with events. THis is due to the parser/lexer that it > uses. Just in case that they are more broken parsers, just only send > events when there are capabilities. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert

[Qemu-devel] [PULL 01/28] rdma: fix memory leak

2015-07-07 Thread Juan Quintela
From: Gonglei Variable "r" going out of scope leaks the storage it points to in line 3268. Signed-off-by: Gonglei Reviewed-by: Amit Shah Signed-off-by: Juan Quintela --- migration/rdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c

[Qemu-devel] [PULL v3 00/28] Migration pull request

2015-07-07 Thread Juan Quintela
59233: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20150706.0' into staging (2015-07-07 09:22:40 +0100) are available in the git repository at: git://github.com/juanquintela/qemu.git tags/migration/20150707 for you to fetch changes up to dd63169766abd2b8dc33f4451

[Qemu-devel] [PULL 07/28] Allow rdma_delete_block to work without the hash

2015-07-07 Thread Juan Quintela
From: "Dr. David Alan Gilbert" In the next patch we remove the hash on the destination, rdma_delete_block does two things with the hash which can be avoided: a) The caller passes the offset and rdma_delete_block looks it up in the hash; fixed by getting the caller to pass the block b) Th

[Qemu-devel] [PULL 05/28] Translate offsets to destination address space

2015-07-07 Thread Juan Quintela
From: "Dr. David Alan Gilbert" The 'offset' field in RDMACompress and 'current_addr' field in RDMARegister are commented as being offsets within a particular RAMBlock, however they appear to actually be offsets within the ram_addr_t space. The code currently assumes that the offsets on the sourc

[Qemu-devel] [PULL 02/28] Only try and read a VMDescription if it should be there

2015-07-07 Thread Juan Quintela
From: "Dr. David Alan Gilbert" The VMDescription section maybe after the EOF mark, the current code does a 'qemu_get_byte' and either gets the header byte identifying the description or an error (which it ignores). Doing the 'get' upsets RDMA which hangs on old machine types without the VMDescri

[Qemu-devel] [PULL 03/28] rdma typos

2015-07-07 Thread Juan Quintela
From: "Dr. David Alan Gilbert" A couple of typo fixes. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Juan Quintela --- migration/rdma.c | 6 +++--- trace-events | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/migration/rdma.c b/migration/rdma.c index 0a0029

[Qemu-devel] [PULL 08/28] Rework ram block hash

2015-07-07 Thread Juan Quintela
From: "Dr. David Alan Gilbert" RDMA uses a hash from block offset->RAM Block; this isn't needed on the destination, and it becomes harder to maintain after the next patch in the series that sorts the block list. Split the hash so that it's only generated on the source. Signed-off-by: Dr. David

[Qemu-devel] [PULL 04/28] Store block name in local blocks structure

2015-07-07 Thread Juan Quintela
From: "Dr. David Alan Gilbert" In a later patch the block name will be used to match up two views of the block list. Keep a copy of the block name with the local block list. (At some point it could be argued that it would be best just to let migration see the innards of RAMBlock and avoid the n

[Qemu-devel] [PULL 06/28] Rework ram_control_load_hook to hook during block load

2015-07-07 Thread Juan Quintela
From: "Dr. David Alan Gilbert" We need the names of RAMBlocks as they're loaded for RDMA, reuse a slightly modified ram_control_load_hook: a) Pass a 'data' parameter to use for the name in the block-reg case b) Only some hook types now require the presence of a hook function. Signed-off

[Qemu-devel] [PULL 10/28] Sanity check RDMA remote data

2015-07-07 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Perform some basic (but probably not complete) sanity checking on requests from the RDMA source. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Michael R. Hines Signed-off-by: Juan Quintela --- migration/rdma.c | 30 ++ 1 file ch

[Qemu-devel] [PULL 15/28] migration: create new section to store global state

2015-07-07 Thread Juan Quintela
This includes a new section that for now just stores the current qemu state. Right now, there are only one way to control what is the state of the target after migration. - If you run the target qemu with -S, it would start stopped. - If you run the target qemu without -S, it would run just after

[Qemu-devel] [PULL 11/28] Fail more cleanly in mismatched RAM cases

2015-07-07 Thread Juan Quintela
From: "Dr. David Alan Gilbert" If the number of RAMBlocks was different on the source from the destination, QEMU would hang waiting for a disconnect on the source and wouldn't release from that hang until the destination was manually killed. Mark the stream as being in error, this causes the des

[Qemu-devel] [PULL 13/28] runstate: Add runstate store

2015-07-07 Thread Juan Quintela
This allows us to store the current state to send it through migration. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/sysemu/sysemu.h | 1 + vl.c| 12 2 files changed, 13 insertions(+) diff --git a/include/sysemu/sysemu.h b/inclu

[Qemu-devel] [PULL 12/28] Fix older machine type compatibility on power with section footers

2015-07-07 Thread Juan Quintela
From: "Dr. David Alan Gilbert" I forgot to add compatibility for Power when adding section footers. Signed-off-by: Dr. David Alan Gilbert Fixes: 37fb569c0198cba58e3e Signed-off-by: Juan Quintela --- hw/ppc/spapr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/

[Qemu-devel] [PULL 25/28] migration: Add migration events on target side

2015-07-07 Thread Juan Quintela
We reuse the migration events from the source side, sending them on the appropiate place. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Dr. David Alan Gilbert --- migration/migration.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/migration/migrati

[Qemu-devel] [PULL 09/28] Sort destination RAMBlocks to be the same as the source

2015-07-07 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Use the order of incoming RAMBlocks from the source to record an index number; that then allows us to sort the destination local RAMBlock list to match the source. Now that the RAMBlocks are known to be in the same order, this simplifies the RDMA Registration step

[Qemu-devel] [PULL 16/28] global_state: Make section optional

2015-07-07 Thread Juan Quintela
This section would be sent: a- for all new machine types b- for old machine types if section state is different form {running,paused} that were the only giving us troubles. So, in new qemus: it is alwasy there. In old qemus: they are only there if it an error has happened, basically stoping o

[Qemu-devel] [PULL 14/28] runstate: migration allows more transitions now

2015-07-07 Thread Juan Quintela
Next commit would allow to move from incoming migration to error happening on source. Should we add more states to this transition? Luiz? Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- vl.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/vl.c

[Qemu-devel] [PULL 26/28] check_section_footers: Check the correct section_id

2015-07-07 Thread Juan Quintela
From: "Dr. David Alan Gilbert" The section footers check was incorrectly checking the section_id in the SaveStateEntry not the LoadStateEntry. These can validly be different if the two QEMU instances have instantiated their devices in a different order. The test only cares that we're finishing

[Qemu-devel] [PULL 17/28] vmstate: Create optional sections

2015-07-07 Thread Juan Quintela
To make sections optional, we need to do it at the beggining of the code. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/vmstate.h | 2 ++ migration/savevm.c | 8 migration/vmstate.c | 11 +++ trace-events

[Qemu-devel] [PULL 27/28] migration: protect migration_bitmap

2015-07-07 Thread Juan Quintela
From: Li Zhijian Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang Signed-off-by: Juan Quintela --- migration/ram.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 644f52a..9c0bcfe 100644 --- a/migration/

[Qemu-devel] [PULL 18/28] migration: Add configuration section

2015-07-07 Thread Juan Quintela
It needs to be the first one and it is not optional, that is the reason why it is opencoded. For new machine types, it is required that machine type name is the same in both sides. It is just done right now for pc's. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- hw/i386

[Qemu-devel] [PULL 23/28] migration: create migration event

2015-07-07 Thread Juan Quintela
We have one argument that tells us what event has happened. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake --- docs/qmp/qmp-events.txt | 14 ++ migration/migration.c | 2 ++ qapi/event.json | 12 3 files changed, 28 insertions(+) diff --git a/docs/qmp/

Re: [Qemu-devel] qemu build fails on xen

2015-07-07 Thread Paul Durrant
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: 07 July 2015 13:38 > To: Paul Durrant > Cc: Michael S. Tsirkin; Stefano Stabellini; Chen, Tiejun; pbonz...@redhat.com; > r...@twiddle.net; ehabk...@redhat.com; qemu-devel@nongnu.org > Subject: Re: qemu buil

[Qemu-devel] [PULL 19/28] migration: Use cmpxchg correctly

2015-07-07 Thread Juan Quintela
cmpxchg returns the old value Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index edb4f3e..1e34aa5 100644 --- a/migration/migration.c ++

[Qemu-devel] [PULL 21/28] migration: Use always helper to set state

2015-07-07 Thread Juan Quintela
There were three places that were not using the migrate_set_state() helper, just fix that. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/migration.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/migration/migration.c b/migration/migra

Re: [Qemu-devel] [RFC PATCH V6 09/18] cpu: add a tcg_executing flag.

2015-07-07 Thread Alex Bennée
fred.kon...@greensocs.com writes: > From: KONRAD Frederic > > We need to know whether any other VCPU is executing code or not it's possible > with this flag. Reword: "This flag indicates if the vCPU is currently executing TCG code"? > > Signed-off-by: KONRAD Frederic > --- > cpu-exec.c

[Qemu-devel] [PULL 20/28] migration: ensure we start in NONE state

2015-07-07 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/migration.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index 1e34aa5..5c1233f 100644 --- a/migration/migration.c +++ b/migration/migration.c

[Qemu-devel] [PULL 24/28] migration: Make events a capability

2015-07-07 Thread Juan Quintela
Make check fails with events. THis is due to the parser/lexer that it uses. Just in case that they are more broken parsers, just only send events when there are capabilities. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/migration.h | 1 + migration/m

Re: [Qemu-devel] [RFC PATCH V6 05/18] protect TBContext with tb_lock.

2015-07-07 Thread Frederic Konrad
On 07/07/2015 14:22, Alex Bennée wrote: fred.kon...@greensocs.com writes: From: KONRAD Frederic This protects TBContext with tb_lock to make tb_* thread safe. We can still have issue with tb_flush in case of multithread TCG: An other CPU can be executing code during a flush. This can be

[Qemu-devel] [PULL 22/28] migration: No need to call trace_migrate_set_state()

2015-07-07 Thread Juan Quintela
We now use the helper everywhere, so no need to call this on this two places. See on previous commit that there were a place where we missed to mark the trace. Now all tracing is done in migrate_set_state(). Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/migrat

Re: [Qemu-devel] [PULL 00/10] qemu-ga patches for 2.4.0

2015-07-07 Thread Peter Maydell
On 7 July 2015 at 14:06, Olga Krishtal wrote: > Do we have minimal version which should be supported for the > case? If so, should we use config option for this or bump > minimal version? Incidentally, I don't inherently object to bumping the minimum version of mingw or whatever here; that's a de

[Qemu-devel] [PULL 28/28] migration: extend migration_bitmap

2015-07-07 Thread Juan Quintela
From: Li Zhijian Prevously, if we hotplug a device(e.g. device_add e1000) during migration is processing in source side, qemu will add a new ram block but migration_bitmap is not extended. In this case, migration_bitmap will overflow and lead qemu abort unexpectedly. Signed-off-by: Li Zhijian S

Re: [Qemu-devel] [PULL 00/10] qemu-ga patches for 2.4.0

2015-07-07 Thread Olga Krishtal
On 07/07/15 13:32, Peter Maydell wrote: On 7 July 2015 at 05:40, Michael Roth wrote: Hi Peter, Sorry for the last minute pull. This is a round-up of all tested/reviewed qemu-ga patches posted prior to soft-freeze, along with 1 bug fix that came in last week. This adds win32 implementations of

Re: [Qemu-devel] [PULL for-2.4 3/7] block/nfs: add support for setting debug level

2015-07-07 Thread Stefan Hajnoczi
On Tue, Jul 7, 2015 at 1:50 PM, Peter Lieven wrote: > Am 07.07.2015 um 14:08 schrieb Stefan Hajnoczi: >> >> From: Peter Lieven >> >> upcoming libnfs versions will support logging debug messages. Add >> support for it in qemu through a per-drive option. >> >> Examples: >> qemu -drive if=virtio,f

Re: [Qemu-devel] qemu build fails on xen

2015-07-07 Thread Paul Durrant
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: 07 July 2015 13:38 > To: Paul Durrant > Cc: Michael S. Tsirkin; Stefano Stabellini; Chen, Tiejun; pbonz...@redhat.com; > r...@twiddle.net; ehabk...@redhat.com; qemu-devel@nongnu.org > Subject: Re: qemu buil

<    1   2   3   4   5   >