On Fri, Jul 03, 2015 at 04:45:36PM +0200, Kővágó, Zoltán wrote: > This will let us print options in a format that the user would actually > write it on the command line (foo=bar,baz=asd,etc=def), without > prepending a spurious comma at the beginning of the list, or quoting > values unnecessarily. This patch provides the following changes: > * write and id=, if the option has an id > * do not print separator before the first element > * do not quote string arguments > * properly escape commas (,) for QEMU > > Signed-off-by: Kővágó, Zoltán <dirty.ice...@gmail.com> > Reviewed-by: Markus Armbruster <arm...@redhat.com> > --- > > Change from v1: > * updated escaped_print as suggested by Markus > > block.c | 2 +- > util/qemu-option.c | 29 ++++++++++++++++++++++++++--- > 2 files changed, 27 insertions(+), 4 deletions(-)
Looks good but please fix qemu-iotests so the test suite keeps passing: $ make && cd tests/qemu-iotests && ./check -qcow2 The test fixes must be in the same commit so the git commit history remains bisectable.
pgpeFqnEw_Iln.pgp
Description: PGP signature
