[Qemu-devel] [PATCH pic32 v2 0/5] Support for Microchip pic32mx7 and pic32mz microcontrollers

2015-07-01 Thread Serge Vakulenko
Please find below a set of patches, which allow to simulate Microchip PIC32 microcontrollers on QEMU. For examples of real PIC32 applications running on QEMU, see page: https://github.com/sergev/qemu/wiki (1) Make the CPU clock frequency configurable per platform. Currently the clock rate for

[Qemu-devel] [PATCH pic32 v2 1/5] Speed of MIPS CPU timer made configurable per platform.

2015-07-01 Thread Serge Vakulenko
Signed-off-by: Serge Vakulenko --- hw/mips/cputimer.c| 13 +++-- hw/mips/mips_fulong2e.c | 2 +- hw/mips/mips_jazz.c | 2 +- hw/mips/mips_malta.c | 4 ++-- hw/mips/mips_mipssim.c| 2 +- hw/mips/mips_r4k.c| 2 +- include/hw/mips/cpudevs.h | 2 +- targ

[Qemu-devel] [PATCH pic32 v2 2/5] Fixed random index generation for TLBWR instruction. It was not quite random and did not skip Wired entries.

2015-07-01 Thread Serge Vakulenko
Signed-off-by: Serge Vakulenko --- hw/mips/cputimer.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/hw/mips/cputimer.c b/hw/mips/cputimer.c index 4f02a9f..94a29df 100644 --- a/hw/mips/cputimer.c +++ b/hw/mips/cputimer.c @@ -25,21 +25,13 @@ #include "qemu

[Qemu-devel] [PATCH pic32 v2 3/5] Added support for external interrupt controller (EIC) mode.

2015-07-01 Thread Serge Vakulenko
Signed-off-by: Serge Vakulenko --- hw/mips/cputimer.c | 17 +++-- hw/mips/mips_int.c | 12 ++-- target-mips/cpu.h| 9 - target-mips/helper.c | 20 ++-- 4 files changed, 47 insertions(+), 11 deletions(-) diff --git a/hw/mips/cputimer.c b/hw/mip

[Qemu-devel] [PATCH pic32 v2 4/5] Two new processor variants: M4K and microAptivP.

2015-07-01 Thread Serge Vakulenko
Signed-off-by: Serge Vakulenko --- target-mips/cpu.h| 2 ++ target-mips/translate_init.c | 46 2 files changed, 48 insertions(+) diff --git a/target-mips/cpu.h b/target-mips/cpu.h index ab830ee..9f5890c 100644 --- a/target-mips/cpu.h +++

[Qemu-devel] [PATCH 1/3] musicpal: Drop eth_can_receive

2015-07-01 Thread Fam Zheng
True is the default. Signed-off-by: Fam Zheng --- hw/arm/musicpal.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c index a3b1314..42f66b3 100644 --- a/hw/arm/musicpal.c +++ b/hw/arm/musicpal.c @@ -187,11 +187,6 @@ static void eth_rx_desc_get(uint32

[Qemu-devel] [PATCH 0/3] hw/net: Drop unnecessary .can_receive functions

2015-07-01 Thread Fam Zheng
These are all repeating the default, and since we're cleaning up .can_receive, let's get these out of the way. Fam Fam Zheng (3): musicpal: Drop eth_can_receive etraxfs_eth: Drop eth_can_receive lan9118: Drop lan9118_can_receive hw/arm/musicpal.c| 6 -- hw/net/etraxfs_eth.c | 6 -

[Qemu-devel] [PATCH 2/3] etraxfs_eth: Drop eth_can_receive

2015-07-01 Thread Fam Zheng
True is the default. Signed-off-by: Fam Zheng --- hw/net/etraxfs_eth.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/net/etraxfs_eth.c b/hw/net/etraxfs_eth.c index 4773dea..d600275 100644 --- a/hw/net/etraxfs_eth.c +++ b/hw/net/etraxfs_eth.c @@ -520,11 +520,6 @@ static int eth_matc

[Qemu-devel] [PATCH 3/3] lan9118: Drop lan9118_can_receive

2015-07-01 Thread Fam Zheng
True is the default. Signed-off-by: Fam Zheng --- hw/net/lan9118.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/net/lan9118.c b/hw/net/lan9118.c index f169c38..4f0e840 100644 --- a/hw/net/lan9118.c +++ b/hw/net/lan9118.c @@ -461,11 +461,6 @@ static void lan9118_reset(DeviceState *

Re: [Qemu-devel] [PATCH 10/11] migration: create migration event

2015-07-01 Thread Juan Quintela
Eric Blake wrote: > On 06/16/2015 07:50 PM, Juan Quintela wrote: >> We have one argument that tells us what event has happened. >> >> Signed-off-by: Juan Quintela >> >> X3 >> >> Signed-off-by: Juan Quintela > > Intentional double-S-o-b? No, merge artifact > >> --- >> docs/qmp/qmp-events.t

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 02/22] virtio: run drivers in 32bit mode

2015-07-01 Thread Gerd Hoffmann
On Di, 2015-06-30 at 10:36 -0400, Kevin O'Connor wrote: > On Tue, Jun 30, 2015 at 10:38:53AM +0200, Gerd Hoffmann wrote: > > virtio version 1.0 registers can (and actually do in the qemu > > implementation) live in mmio space. So we must run the blk and > > scsi virtio drivers in 32bit mode, other

Re: [Qemu-devel] [PATCH 08/11] migration: Use always helper to set state

2015-07-01 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> There were three places that were not using the migrate_set_state() >> helper, just fix that. >> >> Signed-off-by: Juan Quintela >> --- >> migration/migration.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 de

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 03/22] virtio: add struct vp_device

2015-07-01 Thread Gerd Hoffmann
> > -u16 vp_init_simple(u16 bdf) > > +struct vp_device *vp_init_simple(u16 bdf) > > { > > -u16 ioaddr = pci_config_readl(bdf, PCI_BASE_ADDRESS_0) & > > +struct vp_device *vp = malloc_high(sizeof(*vp)); > > + > > +vp->ioaddr = pci_config_readl(bdf, PCI_BASE_ADDRESS_0) & > > PCI

Re: [Qemu-devel] [PATCH 03/11] migration: create new section to store global state

2015-07-01 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> This includes a new section that for now just stores the current qemu state. >> >> Right now, there are only one way to control what is the state of the >> target after migration. >> >> - If you run the target qemu

Re: [Qemu-devel] [PATCH v2 1/1] KVM s390 pci infrastructure modelling

2015-07-01 Thread Hong Bo Li
On 7/1/2015 14:22, Michael S. Tsirkin wrote: On Tue, Jun 30, 2015 at 02:16:59PM +0800, Hong Bo Li wrote: On 6/29/2015 18:01, Michael S. Tsirkin wrote: On Mon, Jun 29, 2015 at 05:24:53PM +0800, Hong Bo Li wrote: This patch introduce a new facility(and bus) to hold devices representing informa

Re: [Qemu-devel] [PATCH v2 1/1] KVM s390 pci infrastructure modelling

2015-07-01 Thread Michael S. Tsirkin
On Wed, Jul 01, 2015 at 03:56:25PM +0800, Hong Bo Li wrote: > > > On 7/1/2015 14:22, Michael S. Tsirkin wrote: > >On Tue, Jun 30, 2015 at 02:16:59PM +0800, Hong Bo Li wrote: > >>On 6/29/2015 18:01, Michael S. Tsirkin wrote: > >>>On Mon, Jun 29, 2015 at 05:24:53PM +0800, Hong Bo Li wrote: > Th

Re: [Qemu-devel] [PATCH v2 02/22] virtio: run drivers in 32bit mode

2015-07-01 Thread Michael S. Tsirkin
On Tue, Jun 30, 2015 at 10:38:53AM +0200, Gerd Hoffmann wrote: > virtio version 1.0 registers can (and actually do in the qemu > implementation) live in mmio space. So we must run the blk and > scsi virtio drivers in 32bit mode, otherwise we can't access them. > > This also allows to drop a bunch

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-07-01 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > On 07/01/2015 03:01 AM, Dr. David Alan Gilbert wrote: > > * Wen Congyang (we...@cn.fujitsu.com) wrote: > >> On 06/27/2015 03:03 AM, Dr. David Alan Gilbert wrote: > > > > > > > >>> Ah, I hadn't realised you could do that; so do you just do: > >>> > >

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-07-01 Thread Wen Congyang
On 07/01/2015 04:11 PM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> On 07/01/2015 03:01 AM, Dr. David Alan Gilbert wrote: >>> * Wen Congyang (we...@cn.fujitsu.com) wrote: On 06/27/2015 03:03 AM, Dr. David Alan Gilbert wrote: >>> >>> >>> > Ah, I hadn't r

[Qemu-devel] [PATCH] net: Flush queued packets when guest resumes

2015-07-01 Thread Fam Zheng
Since commit 6e99c63 "net/socket: Drop net_socket_can_send" and friends, net queues need to be explicitly flushed after qemu_can_send_packet() returns false, because the netdev side will disable the polling of fd. This fixes the case of "cont" after "stop" (or migration), i.e. vm_running changes t

Re: [Qemu-devel] [Bug 1469946] Re: guest can't get IP when create guest with bridge.

2015-07-01 Thread Fam Zheng
On Wed, 07/01 06:36, chao zhou wrote: > after try the patch > http://lists.nongnu.org/archive/html/qemu-devel/2015-06/msg07377.html with > qemu.git commit(d2966f804d70a244f5dde395fc5d22a50ed3e74e) the guest can get > IP, but after save/retore or live migration, the guest is alive, but ping or > ssh

Re: [Qemu-devel] [PATCH] RDMA: Missing free in (probably unreachable) error path

2015-07-01 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Coverity CID 1307773 > > Signed-off-by: Dr. David Alan Gilbert Integrated gonglei patch for this, just moved the malloc. > --- > migration/rdma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/migration/rdma.

Re: [Qemu-devel] [PATCH] Only try and read a VMDescription if it should be there

2015-07-01 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > The VMDescription section maybe after the EOF mark, the current code > does a 'qemu_get_byte' and either gets the header byte identifying the > description or an error (which it ignores). Doing the 'get' upsets > RDMA whi

Re: [Qemu-devel] [PATCH v2 0/2] avoid a hotplug operation leading migration's source side abort

2015-07-01 Thread Juan Quintela
Li Zhijian wrote: > qemu migration's source side will exit unexpectedly when we hotplug a deivce > during a migration is processing. > we can reproduced it easily by following step > 1. do something with dirty memory requently(like memtester) in guest > 2. startup a background migration with '-d'

Re: [Qemu-devel] [PATCH v2 01/12] Rename RDMA structures to make destination clear

2015-07-01 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > RDMA has two data types that are named confusingly; >RDMALocalBlock (pointed to indirectly by local_ram_blocks) >RDMARemoteBlock (pointed to by block in RDMAContext) > > RDMALocalBlocks, as the name suggests is a d

Re: [Qemu-devel] [PATCH v2 02/12] qemu_ram_foreach_block: pass up error value, and down the ramblock name

2015-07-01 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > check the return value of the function it calls and error if it's non-0 > Fixup qemu_rdma_init_one_block that is the only current caller, > and rdma_add_block the only function it calls using it. > > Pass the name of the

Re: [Qemu-devel] [PATCH v2 03/12] Remove unneeded memset

2015-07-01 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: Michael R. Hines Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH 4/5] net/dump: Add dump option for netdev devices

2015-07-01 Thread Stefan Hajnoczi
On Tue, Jun 30, 2015 at 12:37:46PM +0200, Thomas Huth wrote: > On Fri, 26 Jun 2015 10:44:59 +0100 > Stefan Hajnoczi wrote: > > > On Wed, Jun 24, 2015 at 05:56:20PM +0200, Thomas Huth wrote: > > > diff --git a/net/net.c b/net/net.c > > > index cc36c7b..8871b77 100644 > > > --- a/net/net.c > > > ++

Re: [Qemu-devel] [PATCH v2 04/12] rdma typos

2015-07-01 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > A couple of typo fixes. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v2 05/12] Store block name in local blocks structure

2015-07-01 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > In a later patch the block name will be used to match up two views > of the block list. Keep a copy of the block name with the local block > list. > > (At some point it could be argued that it would be best just to let >

Re: [Qemu-devel] [PATCH] more check for replaced node

2015-07-01 Thread Stefan Hajnoczi
On Thu, Jun 25, 2015 at 02:55:10PM +0800, Wen Congyang wrote: > Signed-off-by: Wen Congyang > --- > block.c | 5 +++-- > block/mirror.c| 3 ++- > blockdev.c| 2 +- > include/block/block.h | 3 ++- > 4 files changed, 8 insertions(+), 5 deletions(-) This patch is

Re: [Qemu-devel] [PATCH v2 06/12] Translate offsets to destination address space

2015-07-01 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > The 'offset' field in RDMACompress and 'current_addr' field > in RDMARegister are commented as being offsets within a particular > RAMBlock, however they appear to actually be offsets within the > ram_addr_t space. > > The

Re: [Qemu-devel] [PATCH 07/10] block/backup: support block job transactions

2015-07-01 Thread Stefan Hajnoczi
On Tue, Jun 30, 2015 at 11:52:54AM -0400, John Snow wrote: > On 06/30/2015 11:27 AM, Stefan Hajnoczi wrote: > > On Mon, Jun 29, 2015 at 06:39:08PM -0400, John Snow wrote: > >> On 06/25/2015 08:12 AM, Stefan Hajnoczi wrote: > >>> @@ -537,6 +539,9 @@ void backup_start(BlockDriverState *bs, > >>> Blo

Re: [Qemu-devel] [PATCH] more check for replaced node

2015-07-01 Thread Wen Congyang
On 07/01/2015 04:39 PM, Stefan Hajnoczi wrote: > On Thu, Jun 25, 2015 at 02:55:10PM +0800, Wen Congyang wrote: >> Signed-off-by: Wen Congyang >> --- >> block.c | 5 +++-- >> block/mirror.c| 3 ++- >> blockdev.c| 2 +- >> include/block/block.h | 3 ++- >> 4 files

Re: [Qemu-devel] [PATCH v2 07/12] Rework ram_control_load_hook to hook during block load

2015-07-01 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Michael R. Hines (mrhi...@linux.vnet.ibm.com) wrote: >> > qemu_rdma_registration_handle_unregister_success(uint64_t chunk) "%" >> > PRIu64 >> >-qemu_rdma_registration_handle_wait(uint64_t flags) "Waiting for next >> >request %" PRIu64 >> >+qemu_rdma_registra

Re: [Qemu-devel] [PATCH v2 07/12] Rework ram_control_load_hook to hook during block load

2015-07-01 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > We need the names of RAMBlocks as they're loaded for RDMA, > reuse a slightly modified ram_control_load_hook: > a) Pass a 'data' parameter to use for the name in the block-reg > case > b) Only some hook types now

Re: [Qemu-devel] [PATCH v2 07/12] Rework ram_control_load_hook to hook during block load

2015-07-01 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > We need the names of RAMBlocks as they're loaded for RDMA, > > reuse a slightly modified ram_control_load_hook: > > a) Pass a 'data' parameter to use for the name in t

[Qemu-devel] [PATCH 09/12] migration: Use always helper to set state

2015-07-01 Thread Juan Quintela
There were three places that were not using the migrate_set_state() helper, just fix that. Signed-off-by: Juan Quintela --- migration/migration.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index c5b778b..a8d2da5 100644

[Qemu-devel] [PATCH 01/12] runstate: Add runstate store

2015-07-01 Thread Juan Quintela
This allows us to store the current state to send it through migration. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/sysemu/sysemu.h | 1 + vl.c| 12 2 files changed, 13 insertions(+) diff --git a/include/sysemu/sysemu.h b/inclu

[Qemu-devel] [PATCH 02/12] runstate: migration allows more transitions now

2015-07-01 Thread Juan Quintela
Next commit would allow to move from incoming migration to error happening on source. Should we add more states to this transition? Luiz? Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- vl.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/vl.c

[Qemu-devel] [PATCH 04/12] global_state: Make section optional

2015-07-01 Thread Juan Quintela
This section would be sent: a- for all new machine types b- for old achine types if section state is different form {running,paused} that were the only giving us troubles. So, in new qemus: it is alwasy there. In old qemus: they are only there if it an error has happened, basically stoping on

[Qemu-devel] [PATCH v2 00/12] Migration events + optional sections

2015-07-01 Thread Juan Quintela
Hi At the end, Daved asked for a couple of things on previous series. [v2] - Ensure that we start in NONE even after failed/canceled migration - move printf's to traces - make sure that we can migrate the new states like guest-panicked (not sure if it is a good idea to enable migrate a guest-pan

[Qemu-devel] [PATCH 03/12] migration: create new section to store global state

2015-07-01 Thread Juan Quintela
This includes a new section that for now just stores the current qemu state. Right now, there are only one way to control what is the state of the target after migration. - If you run the target qemu with -S, it would start stopped. - If you run the target qemu without -S, it would run just after

[Qemu-devel] [PATCH 05/12] vmstate: Create optional sections

2015-07-01 Thread Juan Quintela
To make sections optional, we need to do it at the beggining of the code. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/vmstate.h | 2 ++ migration/savevm.c | 8 migration/vmstate.c | 11 +++ trace-events

[Qemu-devel] [PATCH 07/12] migration: Use cmpxchg correctly

2015-07-01 Thread Juan Quintela
cmpxchg returns the old value Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index 0fd5962..cfcc227 100644 --- a/migration/migration.c ++

[Qemu-devel] [PATCH 06/12] migration: Add configuration section

2015-07-01 Thread Juan Quintela
It needs to be the first one and it is not optional, that is the reason why it is opencoded. For new machine types, it is required than machine type name is the same in both sides. It is just done right now for pc's. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- hw/i386

[Qemu-devel] [PATCH 10/12] migration: No need to call trace_migrate_set_state()

2015-07-01 Thread Juan Quintela
We now use the helper everywhere, so no need to call this on this two places. See on previous commit that there were a place where we missed to mark the trace. Now all tracing is done in migrate_set_state(). Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/migrat

[Qemu-devel] [PATCH 08/12] migration: ensure we start in NONE state

2015-07-01 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/migration.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index cfcc227..c5b778b 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -693,7 +693,6 @@ void qmp_migrate

[Qemu-devel] [PATCH 12/12] migration: Add migration events on target side

2015-07-01 Thread Juan Quintela
We reuse the migration events from the source side, sending them on the appropiate place. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Dr. David Alan Gilbert --- migration/migration.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/migration/migrati

[Qemu-devel] [PATCH 11/12] migration: create migration event

2015-07-01 Thread Juan Quintela
We have one argument that tells us what event has happened. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake --- docs/qmp/qmp-events.txt | 14 ++ migration/migration.c | 2 ++ qapi/event.json | 12 3 files changed, 28 insertions(+) diff --git a/docs/qmp/

Re: [Qemu-devel] [PATCH] net: Flush queued packets when guest resumes

2015-07-01 Thread Fam Zheng
On Wed, 07/01 16:23, Fam Zheng wrote: > Since commit 6e99c63 "net/socket: Drop net_socket_can_send" and friends, > net queues need to be explicitly flushed after qemu_can_send_packet() > returns false, because the netdev side will disable the polling of fd. > > This fixes the case of "cont" after

Re: [Qemu-devel] [PATCH v4 1/5] softmmu: add helper function to pass through retaddr

2015-07-01 Thread Richard Henderson
On 06/29/2015 08:23 AM, Pavel Dovgalyuk wrote: This patch introduces several helpers to pass return address which points to the TB. Correct return address allows correct restoring of the guest PC and icount. These functions should be used when helpers embedded into TB invoke memory operations. S

Re: [Qemu-devel] [PATCH v4 2/5] cpu-exec: introduce loop exit with restore function

2015-07-01 Thread Richard Henderson
On 06/29/2015 08:23 AM, Pavel Dovgalyuk wrote: This patch introduces loop exit function, which also restores guest CPU state according to the value of host program counter. Signed-off-by: Pavel Dovgalyuk --- cpu-exec.c |9 + include/exec/exec-all.h |1 + 2 files

Re: [Qemu-devel] [PATCH 03/12] migration: create new section to store global state

2015-07-01 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > This includes a new section that for now just stores the current qemu state. > > Right now, there are only one way to control what is the state of the > target after migration. > > - If you run the target qemu with -S, it would start stopped. > - If

Re: [Qemu-devel] [PATCH v2 1/1] KVM s390 pci infrastructure modelling

2015-07-01 Thread Hong Bo Li
On 7/1/2015 16:05, Michael S. Tsirkin wrote: On Wed, Jul 01, 2015 at 03:56:25PM +0800, Hong Bo Li wrote: On 7/1/2015 14:22, Michael S. Tsirkin wrote: On Tue, Jun 30, 2015 at 02:16:59PM +0800, Hong Bo Li wrote: On 6/29/2015 18:01, Michael S. Tsirkin wrote: On Mon, Jun 29, 2015 at 05:24:53PM

Re: [Qemu-devel] [PATCH 04/12] global_state: Make section optional

2015-07-01 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > This section would be sent: > > a- for all new machine types > b- for old achine types if section state is different form {running,paused} >that were the only giving us troubles. > > So, in new qemus: it is alwasy there. In old qemus: they are o

[Qemu-devel] [PATCH 1/1] s390x/migration: Introduce 2.4 machine

2015-07-01 Thread Christian Borntraeger
The section footer changes commit f68945d42bab ("Add a protective section footer") and commit 37fb569c0198 ("Disable section footers on older machine types") broke migration for any non-versioned machines. While one can argue that section footer should be enabled explicitely for new versions inste

Re: [Qemu-devel] [PATCH v4 4/5] target-i386: fix memory operations in helpers

2015-07-01 Thread Richard Henderson
On 06/29/2015 08:23 AM, Pavel Dovgalyuk wrote: This patch passes TB return address into softmmu functions that are invoked from target helpers. This allows correct PC and icount recovering while handling MMU faults. Signed-off-by: Pavel Dovgalyuk --- target-i386/cc_helper.c |2 target-i

Re: [Qemu-devel] [PATCH v2 1/1] KVM s390 pci infrastructure modelling

2015-07-01 Thread Michael S. Tsirkin
On Wed, Jul 01, 2015 at 05:13:11PM +0800, Hong Bo Li wrote: > > > On 7/1/2015 16:05, Michael S. Tsirkin wrote: > >On Wed, Jul 01, 2015 at 03:56:25PM +0800, Hong Bo Li wrote: > >> > >>On 7/1/2015 14:22, Michael S. Tsirkin wrote: > >>>On Tue, Jun 30, 2015 at 02:16:59PM +0800, Hong Bo Li wrote: > >>

Re: [Qemu-devel] [PATCH v4 4/5] target-i386: fix memory operations in helpers

2015-07-01 Thread Pavel Dovgaluk
> From: Richard Henderson [mailto:rth7...@gmail.com] On Behalf Of Richard > Henderson > On 06/29/2015 08:23 AM, Pavel Dovgalyuk wrote: > > This patch passes TB return address into softmmu functions that are > > invoked from target helpers. This allows correct PC and icount recovering > > while han

Re: [Qemu-devel] [PATCH] Fix older machine type compatibility on power with section footers

2015-07-01 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > I forgot to add compatibility for Power when adding section footers. > > Signed-off-by: Dr. David Alan Gilbert > > Fixes: 37fb569c0198cba58e3e Reviewed-by: Juan Quintela Applied > --- > hw/ppc/spapr.c | 2 ++ > 1 fil

Re: [Qemu-devel] [PATCH v4 4/5] target-i386: fix memory operations in helpers

2015-07-01 Thread Richard Henderson
On 07/01/2015 10:22 AM, Pavel Dovgaluk wrote: Indeed. I described it here:http://lists.nongnu.org/archive/html/qemu-devel/2014-09/msg02960.html One of the applications used maskmov_xmm, which caused MMU fault. Then execution of TB restarted instead of continuing from maskmov. Ah, excellent, t

Re: [Qemu-devel] [PATCH v7 14/42] Return path: Send responses from destination to source

2015-07-01 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> "Dr. David Alan Gilbert (git)" wrote: >> > From: "Dr. David Alan Gilbert" >> > >> > Add migrate_send_rp_message to send a message from destination to source >> > along the return path. >> > (It uses a mutex to l

Re: [Qemu-devel] [PATCH 08/12] migration: ensure we start in NONE state

2015-07-01 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > migration/migration.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/migration/migration.c b/migration/migration.c > index cfcc227..c5b778b 100644 > --- a/migration/migration.c > +

Re: [Qemu-devel] [PATCH 03/12] migration: create new section to store global state

2015-07-01 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> This includes a new section that for now just stores the current qemu state. >> >> Right now, there are only one way to control what is the state of the >> target after migration. >> >> - If you run the target qemu

Re: [Qemu-devel] [PATCH 09/12] migration: Use always helper to set state

2015-07-01 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > There were three places that were not using the migrate_set_state() > helper, just fix that. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/migration.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 delet

Re: [Qemu-devel] [PATCH 04/12] global_state: Make section optional

2015-07-01 Thread Yang Hongyang
On 07/01/2015 04:51 PM, Juan Quintela wrote: This section would be sent: a- for all new machine types b- for old achine types if section state is different form {running,paused} s/achine/machine/ that were the only giving us troubles. So, in new qemus: it is alwasy there. In old qemu

Re: [Qemu-devel] [PATCH 06/12] migration: Add configuration section

2015-07-01 Thread Yang Hongyang
On 07/01/2015 04:51 PM, Juan Quintela wrote: It needs to be the first one and it is not optional, that is the reason why it is opencoded. For new machine types, it is required than machine s/than/that/ BTW, only check machine type is enough? should we send/check all the configurations? ty

Re: [Qemu-devel] [PATCH 08/12] migration: ensure we start in NONE state

2015-07-01 Thread Yang Hongyang
On 07/01/2015 04:51 PM, Juan Quintela wrote: Signed-off-by: Juan Quintela --- migration/migration.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index cfcc227..c5b778b 100644 --- a/migration/migration.c +++ b/migrati

Re: [Qemu-devel] [PATCH 1/1] s390x/migration: Introduce 2.4 machine

2015-07-01 Thread Juan Quintela
Christian Borntraeger wrote: First of all Reviewed-by: Juan Quintela For the patch. But one said that, I don't agree with the commint text. > The section footer changes commit f68945d42bab ("Add a protective > section footer") and commit 37fb569c0198 ("Disable section footers > on older mac

Re: [Qemu-devel] [PATCH 06/12] migration: Add configuration section

2015-07-01 Thread Juan Quintela
Yang Hongyang wrote: > On 07/01/2015 04:51 PM, Juan Quintela wrote: >> It needs to be the first one and it is not optional, that is the reason >> why it is opencoded. For new machine types, it is required than machine > > s/than/that/ > > BTW, only check machine type is enough? should we send/che

Re: [Qemu-devel] [PATCH pic32 v2 1/5] Speed of MIPS CPU timer made configurable per platform.

2015-07-01 Thread Aurelien Jarno
On 2015-06-30 21:12, Serge Vakulenko wrote: > Signed-off-by: Serge Vakulenko > --- > hw/mips/cputimer.c| 13 +++-- > hw/mips/mips_fulong2e.c | 2 +- > hw/mips/mips_jazz.c | 2 +- > hw/mips/mips_malta.c | 4 ++-- > hw/mips/mips_mipssim.c| 2 +- > hw/mips/mips_r

Re: [Qemu-devel] [PATCH 09/12] migration: Use always helper to set state

2015-07-01 Thread Yang Hongyang
On 07/01/2015 04:51 PM, Juan Quintela wrote: There were three places that were not using the migrate_set_state() helper, just fix that. Signed-off-by: Juan Quintela Reviewed-by: Yang Hongyang --- migration/migration.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -

Re: [Qemu-devel] [PATCH v2 1/1] KVM s390 pci infrastructure modelling

2015-07-01 Thread Hong Bo Li
On 7/1/2015 17:22, Michael S. Tsirkin wrote: On Wed, Jul 01, 2015 at 05:13:11PM +0800, Hong Bo Li wrote: On 7/1/2015 16:05, Michael S. Tsirkin wrote: On Wed, Jul 01, 2015 at 03:56:25PM +0800, Hong Bo Li wrote: On 7/1/2015 14:22, Michael S. Tsirkin wrote: On Tue, Jun 30, 2015 at 02:16:59PM

Re: [Qemu-devel] [PATCH pic32 v2 2/5] Fixed random index generation for TLBWR instruction. It was not quite random and did not skip Wired entries.

2015-07-01 Thread Aurelien Jarno
On 2015-06-30 21:12, Serge Vakulenko wrote: > Signed-off-by: Serge Vakulenko > --- > hw/mips/cputimer.c | 18 +- > 1 file changed, 5 insertions(+), 13 deletions(-) > > diff --git a/hw/mips/cputimer.c b/hw/mips/cputimer.c > index 4f02a9f..94a29df 100644 > --- a/hw/mips/cputimer.c

Re: [Qemu-devel] [PATCH RFC 1/4] Add virt-v3 machine that uses GIC-500

2015-07-01 Thread Christoffer Dall
On Fri, May 22, 2015 at 01:58:41PM +0300, Pavel Fedin wrote: > This patch introduces kernel_irqchip_type member in Machine class. Currently > it it used only by virt machine for its internal purposes, however in future > it is to be passed to KVM in kvm_irqchip_create(). The variable is defined a

Re: [Qemu-devel] [PATCH RFC 2/4] Set kernel_irqchip_type for other ARM boards which use GIC

2015-07-01 Thread Christoffer Dall
Missing commit text completely? On Fri, May 22, 2015 at 01:58:42PM +0300, Pavel Fedin wrote: > Signed-off-by: Pavel Fedin > --- > hw/arm/exynos4_boards.c | 1 + > hw/arm/realview.c | 1 + > hw/arm/vexpress.c | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/hw/arm/exynos4_b

Re: [Qemu-devel] [PATCH RFC 3/4] First bits of vGICv3 support:

2015-07-01 Thread Christoffer Dall
Hi Pavel, Please get rid of the trailing colon in the subject message. On Fri, May 22, 2015 at 01:58:43PM +0300, Pavel Fedin wrote: > - Make use of kernel_irqchip_type in kvm_arch_irqchip_create() > - Instantiate "kvm-arm-gicv3" class (not implemented yet) for GICv3 with KVM > acceleration I f

Re: [Qemu-devel] [PATCH RFC 0/4] vGICv3 support

2015-07-01 Thread Christoffer Dall
On Fri, May 22, 2015 at 01:58:40PM +0300, Pavel Fedin wrote: > This is my alternative to Ashok's vGICv3 patch > (https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg03021.html), which > i am currently working on. It addresses vGIC capability verification issue > (kvm_irqchip_create() / kvm_ar

Re: [Qemu-devel] [PATCH 1/1] s390x/migration: Introduce 2.4 machine

2015-07-01 Thread Christian Borntraeger
Am 01.07.2015 um 11:56 schrieb Juan Quintela: > Christian Borntraeger wrote: > > First of all > > Reviewed-by: Juan Quintela > > For the patch. > > But one said that, I don't agree with the commint text. So let's just drop this sentence >> While one can argue that section footer should be en

Re: [Qemu-devel] [PATCH RFC 0/4] vGICv3 support

2015-07-01 Thread Daniel P. Berrange
On Wed, Jul 01, 2015 at 12:21:12PM +0200, Christoffer Dall wrote: > On Fri, May 22, 2015 at 01:58:40PM +0300, Pavel Fedin wrote: > > This is my alternative to Ashok's vGICv3 patch > > (https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg03021.html), which > > i am currently working on. It add

Re: [Qemu-devel] [PATCH v2 2/2] migration: extend migration_bitmap

2015-07-01 Thread Juan Quintela
Li Zhijian wrote: > Prevously, if we hotplug a device(e.g. device_add e1000) during > migration is processing in source side, qemu will add a new ram > block but migration_bitmap is not extended. > In this case, migration_bitmap will overflow and lead qemu abort > unexpectedly. > > Signed-off-by:

[Qemu-devel] [PATCH 1/5] rocker: fix misplaced break statement

2015-07-01 Thread sfeldma
From: Scott Feldman Premature break in switch case block. This particular case (group L2 rewrite) will be used for L2 LAG and L3 ECMP support, neither of which are enabled in the guest driver at this time, but are under development. Signed-off-by: Scott Feldman Reported-by: Paolo Bonzini ---

[Qemu-devel] [PATCH 0/5] rocker device updates

2015-07-01 Thread sfeldma
From: Scott Feldman A couple of fixes reported by Paolo Bonzini and some changes to sync with current Linux 4.1 kernel rocker device driver. Scott Feldman (5): rocker: fix misplaced break statement rocker: fix missing break statements rocker: return -1 when dropping packet on ingress roc

[Qemu-devel] [PATCH 2/5] rocker: fix missing break statements

2015-07-01 Thread sfeldma
From: Scott Feldman Signed-off-by: Scott Feldman Reported-by: Paolo Bonzini --- hw/net/rocker/rocker.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c index 4d25842..55ad317 100644 --- a/hw/net/rocker/rocker.c +++ b/hw/net/rocker/rocker.

[Qemu-devel] [PATCH 3/5] rocker: return -1 when dropping packet on ingress

2015-07-01 Thread sfeldma
From: Scott Feldman Signed-off-by: Scott Feldman --- hw/net/rocker/rocker_world.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/rocker/rocker_world.c b/hw/net/rocker/rocker_world.c index b991e87..a6b18f1 100644 --- a/hw/net/rocker/rocker_world.c +++ b/hw/net/rock

[Qemu-devel] [PATCH 5/5] rocker: tests: don't need to specify master/self when setting vlans

2015-07-01 Thread sfeldma
From: Scott Feldman 4.1 Linux kernel doesn't require specifying "master" or "self" when setting vlans on a port, so clean these up from the tests that use vlans. Signed-off-by: Scott Feldman --- tests/rocker/bridge-vlan |4 ++-- tests/rocker/bridge-vlan-stp |4 ++-- 2 files changed

[Qemu-devel] [PATCH 4/5] rocker: mark copy-to-cpu pkts as forwarding offloaded

2015-07-01 Thread sfeldma
From: Scott Feldman For pkts copied to the CPU (to be processed by guest driver), mark the Rx descriptor with flag "OFFLOAD_FWD" to indicate device has already forwarded pkt. The guest driver will use this indicator to avoid duplicate forwarding in the guest OS. Examples include bcast/mcast/unk

Re: [Qemu-devel] [PATCH 04/12] global_state: Make section optional

2015-07-01 Thread Juan Quintela
Yang Hongyang wrote: > On 07/01/2015 04:51 PM, Juan Quintela wrote: >> This section would be sent: >> >> a- for all new machine types >> b- for old achine types if section state is different form {running,paused} > > s/achine/machine/ Thanks, done

Re: [Qemu-devel] [PATCH RFC 4/4] Initial implementation of vGICv3.

2015-07-01 Thread Christoffer Dall
Hi Pavel, On Fri, May 22, 2015 at 07:57:13PM +0300, Pavel Fedin wrote: > Hi! > > > Looks GICv3 common class currently miss this security_extn field + > > parent_fiq so it does not compile without changes. Or did I miss something? > > Just throw this if(...) away. It's my fault. Actually i have

Re: [Qemu-devel] [PATCH v2 1/1] KVM s390 pci infrastructure modelling

2015-07-01 Thread Michael S. Tsirkin
On Wed, Jul 01, 2015 at 06:04:24PM +0800, Hong Bo Li wrote: > > > On 7/1/2015 17:22, Michael S. Tsirkin wrote: > >On Wed, Jul 01, 2015 at 05:13:11PM +0800, Hong Bo Li wrote: > >> > >>On 7/1/2015 16:05, Michael S. Tsirkin wrote: > >>>On Wed, Jul 01, 2015 at 03:56:25PM +0800, Hong Bo Li wrote: > >>

[Qemu-devel] [PULL 00/26] Migration pull request

2015-07-01 Thread Juan Quintela
github.com/juanquintela/qemu.git tags/migration/20150701 for you to fetch changes up to a4fe58b0ea0d78f92461607f4f90be3384fa30e5: migration: Add migration events on target side (2015-07-01 12:35:05 +0200) migration/next fo

[Qemu-devel] [PULL 01/26] migration: protect migration_bitmap

2015-07-01 Thread Juan Quintela
From: Li Zhijian Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang Signed-off-by: Juan Quintela --- migration/ram.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 57368e1..4754aa9 100644 --- a/migratio

[Qemu-devel] [PULL 07/26] Translate offsets to destination address space

2015-07-01 Thread Juan Quintela
From: "Dr. David Alan Gilbert" The 'offset' field in RDMACompress and 'current_addr' field in RDMARegister are commented as being offsets within a particular RAMBlock, however they appear to actually be offsets within the ram_addr_t space. The code currently assumes that the offsets on the sourc

[Qemu-devel] [PULL 04/26] Only try and read a VMDescription if it should be there

2015-07-01 Thread Juan Quintela
From: "Dr. David Alan Gilbert" The VMDescription section maybe after the EOF mark, the current code does a 'qemu_get_byte' and either gets the header byte identifying the description or an error (which it ignores). Doing the 'get' upsets RDMA which hangs on old machine types without the VMDescri

[Qemu-devel] [PULL 03/26] rdma: fix memory leak

2015-07-01 Thread Juan Quintela
From: Gonglei Variable "r" going out of scope leaks the storage it points to in line 3268. Signed-off-by: Gonglei Reviewed-by: Amit Shah Signed-off-by: Juan Quintela --- migration/rdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c

[Qemu-devel] [PULL 09/26] Allow rdma_delete_block to work without the hash

2015-07-01 Thread Juan Quintela
From: "Dr. David Alan Gilbert" In the next patch we remove the hash on the destination, rdma_delete_block does two things with the hash which can be avoided: a) The caller passes the offset and rdma_delete_block looks it up in the hash; fixed by getting the caller to pass the block b) Th

[Qemu-devel] [PULL 02/26] migration: extend migration_bitmap

2015-07-01 Thread Juan Quintela
From: Li Zhijian Prevously, if we hotplug a device(e.g. device_add e1000) during migration is processing in source side, qemu will add a new ram block but migration_bitmap is not extended. In this case, migration_bitmap will overflow and lead qemu abort unexpectedly. Signed-off-by: Li Zhijian S

[Qemu-devel] [PULL 16/26] runstate: migration allows more transitions now

2015-07-01 Thread Juan Quintela
Next commit would allow to move from incoming migration to error happening on source. Should we add more states to this transition? Luiz? Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- vl.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/vl.c

[Qemu-devel] [PULL 06/26] Store block name in local blocks structure

2015-07-01 Thread Juan Quintela
From: "Dr. David Alan Gilbert" In a later patch the block name will be used to match up two views of the block list. Keep a copy of the block name with the local block list. (At some point it could be argued that it would be best just to let migration see the innards of RAMBlock and avoid the n

  1   2   3   4   5   >