Re: [Qemu-devel] [PATCH v8 01/11] i.MX: Split the i.MX serial driver into a header file and a source file

2015-06-30 Thread Peter Crosthwaite
On Mon, Jun 29, 2015 at 1:11 PM, Jean-Christophe Dubois wrote: > Also adding a "realise" callback. > > This is to prepare to accomodate the SOC requirements. > You have also done a significant code style sweep. I would suggest doing a git add -p and split this into 3 patches: 1: Style cleanups 2

Re: [Qemu-devel] [PATCH v8 02/11] i.MX: Split the i.MX AVIC emulator into a header file and a source file

2015-06-30 Thread Peter Crosthwaite
On Mon, Jun 29, 2015 at 1:11 PM, Jean-Christophe Dubois wrote: > This is to prepare to accomodate the SOC requirements. > Same but only 2, one for style, one for headering. Regards, Peter > Signed-off-by: Jean-Christophe Dubois > --- > > Changes since v1: > * not present on v1 > > Changes

Re: [Qemu-devel] [PATCH v8 06/11] kzm: Use modified i.MX emulators.

2015-06-30 Thread Peter Crosthwaite
On Mon, Jun 29, 2015 at 1:12 PM, Jean-Christophe Dubois wrote: > Use modified AVIC, CCM, UART, GPT, EPIT emultors. > "emulators" > Tested by booting Linux one KZM emulator. > "on"? > Signed-off-by: Jean-Christophe Dubois > --- > > Changes since v1: > * not present on v1 > > Changes since

Re: [Qemu-devel] [PATCH v8 04/11] i.MX: Split the i.MX EPIT emulator into a header file and a source file.

2015-06-30 Thread Peter Crosthwaite
On Mon, Jun 29, 2015 at 1:11 PM, Jean-Christophe Dubois wrote: > This is to prepare to accomodate the SOC requirements. > > Signed-off-by: Jean-Christophe Dubois > --- > > Changes since v1: > * not present on v1 > > Changes since v2: > * not present on v2 > > Changes since v3: > * not

Re: [Qemu-devel] (no subject)

2015-06-30 Thread Fam Zheng
On Tue, 06/30 00:49, Scott Feldman wrote: > Hi Fam, Stefan, > > I'm running a test with rocker device using UDP sockets connections > and I'm seeing the socket s->read_poll stay disabled if the device > receives a packet when the device's can_receive returns false. > Receive is stuck after that; n

Re: [Qemu-devel] [Bug 1469946] Re: guest can't get IP when create guest with bridge.

2015-06-30 Thread Fam Zheng
On Tue, 06/30 03:41, chao zhou wrote: > the first bad commit is > commit a90a7425cf592a3afeff3eaf32f543b83050ee5c > Author: Fam Zheng > Date: Thu Jun 4 14:45:17 2015 +0800 > > tap: Drop tap_can_send > > This callback is called by main loop before polling s->fd, if it returns >

Re: [Qemu-devel] [PATCH] tcg/s390: fix branch target change during code retranslation

2015-06-30 Thread Alexander Graf
On 29.06.15 17:00, Richard Henderson wrote: > On 06/16/2015 06:11 AM, Aurelien Jarno wrote: >> Make sure to not modify the branch target. This ensure that the >> branch target is not corrupted during partial retranslation. >> >> Cc: Alexander Graf >> Cc: Richard Henderson >> Signed-off-by: Aureli

Re: [Qemu-devel] [PATCH] target-s390x: fix CONVERT TO BINARY (CVD, CVDY)

2015-06-30 Thread Alexander Graf
On 30.06.15 07:53, Richard Henderson wrote: > On 06/29/2015 09:24 PM, Aurelien Jarno wrote: >> On 2015-06-29 10:28, Richard Henderson wrote: >>> On 06/25/2015 08:16 PM, Aurelien Jarno wrote: for (shift = 4; (shift < 64) && bin; shift += 4) { -int current_number = bin % 10;

Re: [Qemu-devel] [PATCH v8 09/11] i.MX25: Add the i.MX25 SOC support

2015-06-30 Thread Peter Crosthwaite
On Mon, Jun 29, 2015 at 1:12 PM, Jean-Christophe Dubois wrote: > For now we do support the foolowing devices: > * GPT timers (from i.MX31) > * EPIT timers (from i.MX31) > * CCM (from i.MX31) > * AVIC (from i.MX31) > * UART (from i.MX31) > * Ethernet FEC port > * I2C controller > > Si

Re: [Qemu-devel] [PATCH] tcg/s390: fix branch target change during code retranslation

2015-06-30 Thread Richard Henderson
On 06/30/2015 08:27 AM, Alexander Graf wrote: On 29.06.15 17:00, Richard Henderson wrote: On 06/16/2015 06:11 AM, Aurelien Jarno wrote: Make sure to not modify the branch target. This ensure that the branch target is not corrupted during partial retranslation. Cc: Alexander Graf Cc: Richard

Re: [Qemu-devel] [PATCH] tcg/s390: fix branch target change during code retranslation

2015-06-30 Thread Alexander Graf
On 30.06.15 09:36, Richard Henderson wrote: > On 06/30/2015 08:27 AM, Alexander Graf wrote: >> >> >> On 29.06.15 17:00, Richard Henderson wrote: >>> On 06/16/2015 06:11 AM, Aurelien Jarno wrote: Make sure to not modify the branch target. This ensure that the branch target is not corrupt

Re: [Qemu-devel] [PATCH pic32 1/7] Speed of MIPS CPU timer made configurable per platform.

2015-06-30 Thread Peter Crosthwaite
Hi, On Mon, Jun 29, 2015 at 10:00 PM, Serge Vakulenko wrote: > Please find below a set of patches, which allow to simulate Microchip > PIC32 microcontrollers on QEMU. For examples of real PIC32 > applications running on QEMU, see page: > https://github.com/sergev/qemu/wiki > > (1) Make the CPU cl

Re: [Qemu-devel] [PATCH/RFC] s390x/ipl: Fix boot if no bootindex was specified

2015-06-30 Thread Cornelia Huck
On Thu, 18 Jun 2015 17:54:28 +0200 Christian Borntraeger wrote: > commit fa92e218df1d ("s390x/ipl: avoid sign extension") introduced > a regression: > > qemu-system-s390x -drive file=/home/cborntra/image.zhyp409,format=qcow2 > does not boot, the bios states > "No virtio-blk device found!" > > a

[Qemu-devel] [PATCH for-2.4] s390x: the stragglers

2015-06-30 Thread Cornelia Huck
I've added two more patches to my s390-next branch at git://github.com/cohuck/qemu s390-next - Christian's fix for the ipl device id (<1434642868-18685-1-git-send-email-borntrae...@de.ibm.com>) - a gdb fix from David Will send a pull request later this week. David Hildenbrand (1): s390x/gdb

[Qemu-devel] [PATCH for-2.4] s390x/gdb: synchronize cpu state after modifying acrs

2015-06-30 Thread Cornelia Huck
From: David Hildenbrand Whenever we touch the access control registers, we have to make sure that the values will make it into kvm. Otherwise the change will simply be lost. When synchronizing qemu and kvm, a normal KVM_PUT_RUNTIME_STATE does not take care of these registers. Let's simply trigge

[Qemu-devel] mem1 is in use, can not be deleted

2015-06-30 Thread Eduardo Otubo
Hello all, I compiled the HEAD of the master branch and was testing memory hotunplug and got to this issue. Note: I followed exactly what's written on the docs/memory-hotplug.txt file. QEMU 2.3.50 monitor - type 'help' for more information (qemu) object_add memory-backend-ram,id=mem1,size=1G obje

Re: [Qemu-devel] Resource leaking in gen_intermediate_code_internal ?

2015-06-30 Thread Peter Maydell
On 30 June 2015 at 03:45, Jun Koi wrote: > Hello, > > In function gen_intermediate_code_internal() of target-i386/translate.c, we > have this code: > > cpu_T[0] = tcg_temp_new(); > cpu_T[1] = tcg_temp_new(); > cpu_A0 = tcg_temp_new(); > > > I cannot see anywhere cpu_T & cpu_A0 are free

Re: [Qemu-devel] [PATCH pic32 1/7] Speed of MIPS CPU timer made configurable per platform.

2015-06-30 Thread Frederic Konrad
Hi, This is nice. You should use the checkpatch (script/checkpatch) to check the coding style of your patch. The first is corrupted and there are some coding style issues. And as Peter suggest use --cover-letter and git send email to send the emails. Fred On 30/06/2015 07:00, Serge Vakulen

Re: [Qemu-devel] [PATCH] gdbstub:Return non-zero value for thread-id in user mode

2015-06-30 Thread Peter Maydell
On 30 June 2015 at 06:55, Bhushan Attarde wrote: > When client requests the stop information by sending ? packet, the gdbstub > replies with stop info packet which includes thread-id of the stopped thread. > In user mode this thread-id is given by cpu->host_tid, which could be zero. > Some clients

[Qemu-devel] IO performance difference on different kernels

2015-06-30 Thread cauchy-love
I am using qemu2.3.0 to start a guest on different linux kernel (2.6.33 and 2.6.39). The qemu command line is: kvm -m 2g -hda guest.img -enable-kvm Experiments show that the disk write bandwidth of the guest on 2.6.33.3 is 10 times of that on 2.6.39. The period of paio_submit (time differ

Re: [Qemu-devel] [PATCH for-2.4] e1000: flush packets when link comes up

2015-06-30 Thread Jason Wang
On 06/29/2015 06:39 PM, Stefan Hajnoczi wrote: > On Fri, Jun 26, 2015 at 05:06:01PM +0800, Jason Wang wrote: >> >> On 06/25/2015 05:18 PM, Stefan Hajnoczi wrote: >>> e1000_can_receive() checks the link up status register bit. If the bit >>> is clear, packets will be queued and the peer may disab

[Qemu-devel] [PATCH v2 10/22] virtio: add read/write functions and macros

2015-06-30 Thread Gerd Hoffmann
Add macros to read/write virtio registers. Signed-off-by: Gerd Hoffmann --- src/hw/virtio-pci.h | 86 + 1 file changed, 86 insertions(+) diff --git a/src/hw/virtio-pci.h b/src/hw/virtio-pci.h index a04d38b..a092e86 100644 --- a/src/hw/virtio-p

[Qemu-devel] [PATCH v2 04/22] virtio: pass struct pci_device to vp_init_simple

2015-06-30 Thread Gerd Hoffmann
... instead of the bdf only. Signed-off-by: Gerd Hoffmann --- src/hw/virtio-blk.c | 2 +- src/hw/virtio-pci.c | 6 +++--- src/hw/virtio-pci.h | 3 ++- src/hw/virtio-scsi.c | 2 +- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/hw/virtio-blk.c b/src/hw/virtio-blk.c index 13

[Qemu-devel] [PATCH v2 01/22] pci: allow to loop over capabilities

2015-06-30 Thread Gerd Hoffmann
Add a parameter to pci_find_capability, to specify the start point. This allows to find multiple capabilities of the same type, by calling pci_find_capability again with the offset of the last capability found. Signed-off-by: Gerd Hoffmann --- src/fw/pciinit.c | 4 ++-- src/hw/pci.c | 11 ++

[Qemu-devel] [PATCH v2 08/22] virtio: create vp_cap struct for legacy bar

2015-06-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- src/hw/virtio-pci.c | 5 - src/hw/virtio-pci.h | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/hw/virtio-pci.c b/src/hw/virtio-pci.c index 0acf65f..3badb15 100644 --- a/src/hw/virtio-pci.c +++ b/src/hw/virtio-pci.c @@ -144,8 +144,11

[Qemu-devel] [PATCH v2 02/22] virtio: run drivers in 32bit mode

2015-06-30 Thread Gerd Hoffmann
virtio version 1.0 registers can (and actually do in the qemu implementation) live in mmio space. So we must run the blk and scsi virtio drivers in 32bit mode, otherwise we can't access them. This also allows to drop a bunch of GET_LOWFLAT calls from the virtio code in the following patches. Sig

[Qemu-devel] [PATCH v2 00/22] virtio: add version 1.0 support

2015-06-30 Thread Gerd Hoffmann
Hi, This patch series adds virtio 1.0 support to the virtio blk and scsi drivers in seabios. With this series applied seabios happily boots in virtio 1.0 mode from both transitional and modern devices. Tested with Fedora 22 guest, booting from virtio-scsi cdrom (live iso), virtio-scsi disk and

[Qemu-devel] [PATCH v2 14/22] virtio: add version 1.0 support to vp_reset

2015-06-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- src/hw/virtio-pci.c | 11 +++ src/hw/virtio-pci.h | 9 + 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/src/hw/virtio-pci.c b/src/hw/virtio-pci.c index b66326a..5a599c3 100644 --- a/src/hw/virtio-pci.c +++ b/src/hw/virtio-pci.c @@

[Qemu-devel] [PATCH v2 16/22] virtio: remove unused vp_del_vq

2015-06-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- src/hw/virtio-pci.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/src/hw/virtio-pci.h b/src/hw/virtio-pci.h index 7e7a377..2790a48 100644 --- a/src/hw/virtio-pci.h +++ b/src/hw/virtio-pci.h @@ -234,17 +234,6 @@ void vp_set_status(struct vp_device

[Qemu-devel] [PATCH v2 05/22] virtio: add version 1.0 structs and #defines

2015-06-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- src/hw/virtio-pci.h | 61 src/hw/virtio-ring.h | 5 + 2 files changed, 66 insertions(+) diff --git a/src/hw/virtio-pci.h b/src/hw/virtio-pci.h index 3cf0327..18beb83 100644 --- a/src/hw/virtio-pci.h +++ b

[Qemu-devel] [PATCH v2 06/22] virtio: add version 0.9.5 struct

2015-06-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- src/hw/virtio-pci.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/hw/virtio-pci.h b/src/hw/virtio-pci.h index 18beb83..bc2eb05 100644 --- a/src/hw/virtio-pci.h +++ b/src/hw/virtio-pci.h @@ -40,6 +40,20 @@ /* Virtio ABI version, this must

[Qemu-devel] [PATCH v2 12/22] virtio: add version 1.0 support to vp_{get, set}_status

2015-06-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- src/hw/virtio-pci.c | 20 src/hw/virtio-pci.h | 13 ++--- 2 files changed, 22 insertions(+), 11 deletions(-) diff --git a/src/hw/virtio-pci.c b/src/hw/virtio-pci.c index 80b6fcc..29d0295 100644 --- a/src/hw/virtio-pci.c +++ b/src/hw/v

[Qemu-devel] [PATCH v2 19/22] virtio-blk: fix initialization for version 1.0

2015-06-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- src/hw/virtio-blk.c | 85 + src/hw/virtio-pci.h | 13 2 files changed, 72 insertions(+), 26 deletions(-) diff --git a/src/hw/virtio-blk.c b/src/hw/virtio-blk.c index 9e56d42..0a4a677 100644 --- a/src/hw

[Qemu-devel] [PATCH v2 17/22] virtio: add version 1.0 support to vp_find_vq

2015-06-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- src/hw/virtio-pci.c | 58 +++-- 1 file changed, 43 insertions(+), 15 deletions(-) diff --git a/src/hw/virtio-pci.c b/src/hw/virtio-pci.c index 3f530e5..f8f9c4e 100644 --- a/src/hw/virtio-pci.c +++ b/src/hw/virtio-pc

[Qemu-devel] [PATCH v2 09/22] virtio: add version 0.9.5 struct [fixup]

2015-06-30 Thread Gerd Hoffmann
--- src/hw/virtio-pci.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/hw/virtio-pci.h b/src/hw/virtio-pci.h index 29cd969..a04d38b 100644 --- a/src/hw/virtio-pci.h +++ b/src/hw/virtio-pci.h @@ -42,7 +42,7 @@ /* --- virtio 0.9.5 (legacy) struct -

[Qemu-devel] [PATCH v2 11/22] virtio: make features 64bit, support version 1.0 features

2015-06-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- src/hw/virtio-blk.c | 2 +- src/hw/virtio-pci.c | 33 + src/hw/virtio-pci.h | 12 +++- 3 files changed, 37 insertions(+), 10 deletions(-) diff --git a/src/hw/virtio-blk.c b/src/hw/virtio-blk.c index 4f39aa2..9e56d42 100644

[Qemu-devel] [PATCH v2 21/22] virtio: also probe version 1.0 pci ids

2015-06-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- src/hw/pci_ids.h | 8 ++-- src/hw/virtio-blk.c | 5 +++-- src/hw/virtio-scsi.c | 5 +++-- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/src/hw/pci_ids.h b/src/hw/pci_ids.h index 1cd4f72..cdf9b3c 100644 --- a/src/hw/pci_ids.h +++ b/src/hw

[Qemu-devel] [PATCH v2 13/22] virtio: add version 1.0 support to vp_get_isr

2015-06-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- src/hw/virtio-pci.c | 9 + src/hw/virtio-pci.h | 6 +- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/hw/virtio-pci.c b/src/hw/virtio-pci.c index 29d0295..b66326a 100644 --- a/src/hw/virtio-pci.c +++ b/src/hw/virtio-pci.c @@ -77,6

Re: [Qemu-devel] [PATCH for-2.3] Revert seccomp tests that allow it to be used on non-x86 architectures

2015-06-30 Thread Andrew Jones
On Mon, Jun 29, 2015 at 04:24:55PM -0400, Paul Moore wrote: > On Monday, June 29, 2015 07:47:29 PM Andrew Jones wrote: > > On Mon, Jun 29, 2015 at 10:53:14AM -0400, Paul Moore wrote: > > > On Monday, June 29, 2015 09:50:17 AM Andrew Jones wrote: > > > > On Fri, Jun 26, 2015 at 04:26:22PM -0400, Pau

[Qemu-devel] [PATCH v2 18/22] virtio-scsi: fix initialization for version 1.0

2015-06-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- src/hw/virtio-scsi.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/src/hw/virtio-scsi.c b/src/hw/virtio-scsi.c index b208d49..3ee0f49 100644 --- a/src/hw/virtio-scsi.c +++ b/src/hw/virtio-scsi.c @@ -146,14 +146,35 @

[Qemu-devel] [PATCH v2 20/22] virtio: use version 1.0 if available (flip the big switch)

2015-06-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- src/hw/virtio-pci.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/hw/virtio-pci.c b/src/hw/virtio-pci.c index f8f9c4e..1186603 100644 --- a/src/hw/virtio-pci.c +++ b/src/hw/virtio-pci.c @@ -261,16 +261,19 @@ struct vp_d

[Qemu-devel] [PATCH v2 03/22] virtio: add struct vp_device

2015-06-30 Thread Gerd Hoffmann
For virtio 1.0 support we will need more state than just the (legacy mode) ioaddr for each virtio-pci device. Prepare for that by adding a new struct for it. For now it carries the ioaddr only. Signed-off-by: Gerd Hoffmann --- src/hw/virtio-blk.c | 20 ++-- src/hw/virtio-pci.c

[Qemu-devel] [PATCH v2 07/22] virtio: find version 1.0 virtio capabilities

2015-06-30 Thread Gerd Hoffmann
virtio 1.0 specifies the location of the various virtio regions using pci capabilities. Look them up and store the results. Signed-off-by: Gerd Hoffmann --- src/hw/virtio-pci.c | 55 + src/hw/virtio-pci.h | 8 2 files changed, 63 ins

[Qemu-devel] [PATCH v2 22/22] virtio: legacy cleanup

2015-06-30 Thread Gerd Hoffmann
Now that all code is switched over to use vp_read/write we can drop the ioaddr field from vp_device and the offset #defines. Signed-off-by: Gerd Hoffmann --- src/hw/virtio-pci.c | 1 - src/hw/virtio-pci.h | 33 + 2 files changed, 1 insertion(+), 33 deletions(-)

[Qemu-devel] [PATCH v2 15/22] virtio: add version 1.0 support to vp_notify

2015-06-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- src/hw/virtio-pci.c | 22 +- src/hw/virtio-pci.h | 7 ++- src/hw/virtio-ring.c | 2 +- src/hw/virtio-ring.h | 1 + 4 files changed, 25 insertions(+), 7 deletions(-) diff --git a/src/hw/virtio-pci.c b/src/hw/virtio-pci.c index 5a599c3.

[Qemu-devel] [PATCH] virtio-pci: add a per-device-class queue limit

2015-06-30 Thread Gerd Hoffmann
The qemu virtio 1.0 implementation uses one page per virtqueue for notification, which sums up to 4M address space for the 1024 possible queues. We have three devices which might use many queues: virtio-scsi and virtio-net have multiqueue support, and virtio-serial uses one queue pair per port. A

Re: [Qemu-devel] [PATCH] virtio-net: Drop net_virtio_info.can_receive

2015-06-30 Thread Jason Wang
On 06/30/2015 11:06 AM, Fam Zheng wrote: > virtio_net_receive still does the check by calling > virtio_net_can_receive, if the device or driver is not ready, the packet > is dropped. > > This is necessary because returning false from can_receive complicates > things: the peer would disable sendin

[Qemu-devel] [PATCH] move QemuOpts from qemu/option.h to qemu/typedefs.h

2015-06-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/qemu/option.h | 2 +- include/qemu/typedefs.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/qemu/option.h b/include/qemu/option.h index 57e51c9..28195ba 100644 --- a/include/qemu/option.h +++ b/include/qemu/option.h @@ -28,

Re: [Qemu-devel] [PATCH] move QemuOpts from qemu/option.h to qemu/typedefs.h

2015-06-30 Thread Peter Maydell
On 30 June 2015 at 10:09, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > include/qemu/option.h | 2 +- > include/qemu/typedefs.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) I don't object necessarily, but it would be nice if the commit message said what the rationale

Re: [Qemu-devel] mem1 is in use, can not be deleted

2015-06-30 Thread Igor Mammedov
On Tue, 30 Jun 2015 10:07:52 +0200 Eduardo Otubo wrote: > Hello all, > > I compiled the HEAD of the master branch and was testing memory > hotunplug and got to this issue. Note: I followed exactly what's written > on the docs/memory-hotplug.txt file. > > QEMU 2.3.50 monitor - type 'help' for mo

Re: [Qemu-devel] [RESEND PATCH v8 2/4] hw: add a wrapper for registering reset handler

2015-06-30 Thread Igor Mammedov
On Tue, 30 Jun 2015 14:31:50 +0800 Zhu Guihua wrote: > > On 06/26/2015 01:28 AM, Andreas Färber wrote: > > Am 25.06.2015 um 19:00 schrieb Paolo Bonzini: > >> On 25/06/2015 04:17, Zhu Guihua wrote: > >>> Add a wrapper to specify reset order when registering reset handler, > >>> instead of non-obv

Re: [Qemu-devel] [PATCH 2/4] Allow ISA bus to be configured out

2015-06-30 Thread Andreas Färber
Am 30.06.2015 um 06:48 schrieb David Gibson: > On Tue, Jun 30, 2015 at 01:44:10PM +1000, David Gibson wrote: >> On Mon, Jun 29, 2015 at 12:26:50PM +0200, Andreas Färber wrote: >>> Am 29.06.2015 um 07:36 schrieb David Gibson: Currently, the code to handle the legacy ISA bus is always included i

[Qemu-devel] [PATCH v2] cpu-exec: Do not invalidate original TB in cpu_exec_nocache()

2015-06-30 Thread Sergey Fedorov
Instead of invalidating an original TB in cpu_exec_nocache() prematurely, just save a link to it in the temporary generated TB. If cpu_io_recompile() is raised subsequently from the temporary TB, invalidate the original one as well. That allows reusing the original TB each time cpu_exec_nocache() i

[Qemu-devel] Trace memory access in guest VM?

2015-06-30 Thread Jun Koi
Hello, I am trying to monitor all the memory accesses inside the guest VM running on Qemu. I know this is heavy, but this is only the first step of my experiments. To do this, I look at the sample trace in "trace-events" and wondering: is it possible to trace all the memory access (read/write) in

[Qemu-devel] [PATCH] linux-user, ppc: mftbl can be used by user application

2015-06-30 Thread Laurent Vivier
In qemu-linux-user, when calling gethostbyname2(), it was hanging in .__res_nmkquery. (gdb) bt 0 in .__res_nmkquery () from /lib64/libresolv.so.2 1 in .__libc_res_nquery () from /lib64/libresolv.so.2 2 in .__libc_res_nsearch () from /lib64/libresolv.so.2 3 in ._nss_dns_gethostbyname3_r () from /li

Re: [Qemu-devel] [PATCH] linux-user, ppc: mftbl can be used by user application

2015-06-30 Thread Alexander Graf
On 06/30/15 11:49, Laurent Vivier wrote: In qemu-linux-user, when calling gethostbyname2(), it was hanging in .__res_nmkquery. (gdb) bt 0 in .__res_nmkquery () from /lib64/libresolv.so.2 1 in .__libc_res_nquery () from /lib64/libresolv.so.2 2 in .__libc_res_nsearch () from /lib64/libresolv.so.2

Re: [Qemu-devel] Trace memory access in guest VM?

2015-06-30 Thread Peter Maydell
On 30 June 2015 at 10:47, Jun Koi wrote: > I am trying to monitor all the memory accesses inside the guest VM running > on Qemu. I know this is heavy, but this is only the first step of my > experiments. > > To do this, I look at the sample trace in "trace-events" and wondering: is > it possible t

Re: [Qemu-devel] [RESEND PATCH v8 2/4] hw: add a wrapper for registering reset handler

2015-06-30 Thread Andreas Färber
Am 30.06.2015 um 08:31 schrieb Zhu Guihua: > On 06/26/2015 01:28 AM, Andreas Färber wrote: >> Am 25.06.2015 um 19:00 schrieb Paolo Bonzini: >>> On 25/06/2015 04:17, Zhu Guihua wrote: Add a wrapper to specify reset order when registering reset handler, instead of non-obvious initiazation c

[Qemu-devel] [PATCH v6 0/10] QGA: disk and volume info for Windows & guest exec

2015-06-30 Thread Denis V. Lunev
Implementation of qmp_quest_get_fsinfo. This functionality will be used together with vss-provider in order to do freeze/unfreeze per volume (single mounted fs). These patches for guest-agent add the functionality to execute commands on a guest UNIX and Windows machines. These patches add the fol

[Qemu-devel] [PATCH 04/10] qga: handle possible SIGPIPE in guest-file-write

2015-06-30 Thread Denis V. Lunev
From: Olga Krishtal qemu-ga should not exit on guest-file-write to pipe without read end but proper error code should be returned. The behavior of the spawned process should be default thus SIGPIPE processing should be reset to default after fork() but before exec(). Signed-off-by: Olga Krishtal

[Qemu-devel] [PATCH 05/10] qga: guest-pipe-open for Windows guest

2015-06-30 Thread Denis V. Lunev
From: Olga Krishtal The patch creates anonymous pipe that can be passed as stdin/stdout/stderr handle to a child process spawned using forthcoming guest-file-exec command. Working with a pipe is done using the existing guest-file-* API. Signed-off-by: Olga Krishtal Signed-off-by: Denis V. Lunev

[Qemu-devel] [PATCH 01/10] util, qga: drop guest_file_toggle_flags

2015-06-30 Thread Denis V. Lunev
From: Olga Krishtal guest_file_toggle_flags is a copy from semi-portable qemu_set_nonblock. The latter is not working properly for Windows due to reduced Windows Posix implementation. On Windows OS there is a separate API for changing flags of file, pipes and sockets. Portable way to change file

[Qemu-devel] [PATCH 08/10] qga: added mountpoint and filesystem type for single volume

2015-06-30 Thread Denis V. Lunev
From: Olga Krishtal We should use GetVolumeXXX api to work with volumes. This will help us to resolve the situation with volumes without drive letter, i.e. when the volume is mounted as a folder. Such volume is called mounted folder. This volume is a regular mounted volume from all other points o

[Qemu-devel] [PATCH 09/10] qga: added bus type and disk location path

2015-06-30 Thread Denis V. Lunev
From: Olga Krishtal According to Microsoft disk location path can be obtained via IOCTL_SCSI_GET_ADDRESS. Unfortunately this ioctl can not be used for all devices. There are certain bus types which could be obtained with this API. Please, refer to the following link for more details https://techn

[Qemu-devel] [PATCH 07/10] qga: added empty qmp_quest_get_fsinfo functionality.

2015-06-30 Thread Denis V. Lunev
From: Olga Krishtal We need qmp_quest_get_fsinfo togather with vss-provider, which works with volumes. The call to this function is implemented via FindFirst/NextVolumes. Moreover, volumes in Windows OS are filesystem unit, so it will be more effective to work with them rather with devices. Sign

[Qemu-devel] [PATCH 06/10] qga: guest exec functionality for Windows guests

2015-06-30 Thread Denis V. Lunev
From: Olga Krishtal Child process' stdin/stdout/stderr can be associated with handles for communication via read/write interfaces. The workflow should be something like this: * Open an anonymous pipe through guest-pipe-open * Execute a binary or a script in the guest. Arbitrary arguments and e

[Qemu-devel] [PATCH 10/10] qga: added GuestPCIAddress information

2015-06-30 Thread Denis V. Lunev
From: Olga Krishtal PCIAddress inforfation is obtained via SetupApi, which provides the information about address, bus, etc. We look throught entire device tree in the system and try to find device object for given volume. For this PDO SetupDiGetDeviceRegistryProperty is called, which reads PCI c

Re: [Qemu-devel] [PATCH 4/5] net/dump: Add dump option for netdev devices

2015-06-30 Thread Thomas Huth
On Fri, 26 Jun 2015 10:44:59 +0100 Stefan Hajnoczi wrote: > On Wed, Jun 24, 2015 at 05:56:20PM +0200, Thomas Huth wrote: > > diff --git a/net/net.c b/net/net.c > > index cc36c7b..8871b77 100644 > > --- a/net/net.c > > +++ b/net/net.c > > @@ -568,6 +568,12 @@ ssize_t qemu_deliver_packet(NetClientS

Re: [Qemu-devel] [PATCH v2] macio: remove nonexistent interrupt on pin 1

2015-06-30 Thread Alexander Graf
On 06/18/15 00:04, Cormac O'Brien wrote: The current macio implementation declares an interrupt that doesn't appear to exist in the hardware or any other emulator implementation. OpenBIOS detects this interrupt and generates an 'interrupts' property in the macio device tree entry. Mac OS 9 halts

Re: [Qemu-devel] [RESEND PATCH v8 2/4] hw: add a wrapper for registering reset handler

2015-06-30 Thread Zhu Guihua
On 06/30/2015 05:21 PM, Igor Mammedov wrote: On Tue, 30 Jun 2015 14:31:50 +0800 Zhu Guihua wrote: On 06/26/2015 01:28 AM, Andreas Färber wrote: Am 25.06.2015 um 19:00 schrieb Paolo Bonzini: On 25/06/2015 04:17, Zhu Guihua wrote: Add a wrapper to specify reset order when registering reset h

Re: [Qemu-devel] [RESEND PATCH v8 2/4] hw: add a wrapper for registering reset handler

2015-06-30 Thread Peter Maydell
On 30 June 2015 at 11:50, Zhu Guihua wrote: > Originally, there are some devices (such as hpet, rtc) reset before apic > reset. > When these devices reset, they would send irq to apic. In our current (arguably broken) reset design, this is a bug in those devices -- they shouldn't be raising inter

[Qemu-devel] [PATCH 02/10] qga: implement guest-pipe-open command

2015-06-30 Thread Denis V. Lunev
From: Olga Krishtal The command creates FIFO pair that can be used with existing file read/write interfaces to communicate with processes spawned via the forthcoming guest-file-exec interface. Signed-off-by: Olga Krishtal Signed-off-by: Denis V. Lunev Acked-by: Roman Kagan CC: Eric Blake CC:

[Qemu-devel] [PATCH 03/10] qga: guest exec functionality for Unix guests

2015-06-30 Thread Denis V. Lunev
From: Olga Krishtal Child process' stdin/stdout/stderr can be associated with handles for communication via read/write interfaces. The workflow should be something like this: * Open an anonymous pipe through guest-pipe-open * Execute a binary or a script in the guest. Arbitrary arguments and e

Re: [Qemu-devel] [PATCH] move QemuOpts from qemu/option.h to qemu/typedefs.h

2015-06-30 Thread Gerd Hoffmann
On Di, 2015-06-30 at 10:15 +0100, Peter Maydell wrote: > On 30 June 2015 at 10:09, Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann > > --- > > include/qemu/option.h | 2 +- > > include/qemu/typedefs.h | 1 + > > 2 files changed, 2 insertions(+), 1 deletion(-) > > I don't object necessar

Re: [Qemu-devel] QEMU to generate host binary

2015-06-30 Thread Dr. David Alan Gilbert
* Ayaz Akram (aaq...@gmail.com) wrote: > Thanks for your answers. The thing that i still do not get is once we have > host assembly code (output assembly log generated for compiled TBs ), > should we still worry about problems like self modifying code and other > dynamic conditions? Moreover, assum

[Qemu-devel] [PATCH v3 0/9] HyperV equivalent of pvpanic driver

2015-06-30 Thread Denis V. Lunev
Windows 2012 guests can notify hypervisor about occurred guest crash (Windows bugcheck(BSOD)) by writing specific Hyper-V msrs. This patch does handling of this MSR's by KVM and sending notification to user space that allows to gather Windows guest crash dump by QEMU/LIBVIRT. The idea is to provid

[Qemu-devel] [PATCH 5/9] kvm: added KVM_REQ_HV_CRASH value to notify qemu about hyper-v crash

2015-06-30 Thread Denis V. Lunev
From: Andrey Smetanin Added KVM_REQ_HV_CRASH - vcpu request used for notify user space(QEMU) about Hyper-V crash. Signed-off-by: Andrey Smetanin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Gleb Natapov --- include/linux/kvm_host.h | 1 + 1 file changed, 1 insertion(+) diff --git a/

[Qemu-devel] [PATCH 4/9] kvm/x86: added hyper-v crash msrs into kvm hyperv context

2015-06-30 Thread Denis V. Lunev
From: Andrey Smetanin Added kvm Hyper-V context hv crash variables as storage of Hyper-V crash msrs. Signed-off-by: Andrey Smetanin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Gleb Natapov --- arch/x86/include/asm/kvm_host.h | 4 1 file changed, 4 insertions(+) diff --git a/ar

[Qemu-devel] [PATCH 9/9] qemu/kvm: kvm hyper-v based guest crash event handling

2015-06-30 Thread Denis V. Lunev
From: Andrey Smetanin KVM Hyper-V based guests can notify hypervisor about occurred guest crash. This patch does handling of KVM crash event by sending to libvirt guest panic event that allows to gather guest crash dump by QEMU/LIBVIRT. Add support of HV_X64_MSR_CRASH_P0-P4, HV_X64_MSR_CRASH_CTL

[Qemu-devel] [PATCH 1/9] kvm/x86: move Hyper-V MSR's/hypercall code into hyperv.c file

2015-06-30 Thread Denis V. Lunev
From: Andrey Smetanin This patch introduce Hyper-V related source code file - hyperv.c and per vm and per vcpu hyperv context structures. All Hyper-V MSR's and hypercall code moved into hyperv.c. All Hyper-V kvm/vcpu fields moved into appropriate hyperv context structures. Copyrights and authors

[Qemu-devel] [PATCH 2/9] kvm: introduce vcpu_debug = kvm_debug + vcpu context

2015-06-30 Thread Denis V. Lunev
From: Andrey Smetanin vcpu_debug is useful macro like kvm_debug but additionally includes vcpu context inside output. Signed-off-by: Andrey Smetanin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Gleb Natapov --- include/linux/kvm_host.h | 3 +++ 1 file changed, 3 insertions(+) diff -

[Qemu-devel] [PATCH 3/9] kvm: add hyper-v crash msrs values

2015-06-30 Thread Denis V. Lunev
From: Andrey Smetanin Added Hyper-V crash msrs values - HV_X64_MSR_CRASH*. Signed-off-by: Andrey Smetanin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Gleb Natapov --- arch/x86/include/uapi/asm/hyperv.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/x86/inc

[Qemu-devel] [PATCH 6/9] kvm/x86: mark hyper-v crash msrs as partition wide

2015-06-30 Thread Denis V. Lunev
From: Andrey Smetanin Hyper-V crash msr's are per vm, aren't per vcpu, so mark them as partition wide. Signed-off-by: Andrey Smetanin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Gleb Natapov --- arch/x86/kvm/hyperv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/kvm

[Qemu-devel] [PATCH 8/9] kvm/x86: add sending hyper-v crash notification to user space

2015-06-30 Thread Denis V. Lunev
From: Andrey Smetanin Sending of notification is done by exiting vcpu to user space if KVM_REQ_HV_CRASH is enabled for vcpu. kvm_run structure will contains system_event with type KVM_SYSTEM_EVENT_CRASH and flag KVM_SYSTEM_EVENT_FL_HV_CRASH to clarify that crash occures inside Hyper-V based guest

[Qemu-devel] [PATCH 7/9] kvm/x86: added hyper-v crash data and ctl msr's get/set'ers

2015-06-30 Thread Denis V. Lunev
From: Andrey Smetanin Added hyper-v crash msr's(HV_X64_MSR_CRASH*) data and control geters and setters. User space allowed to setup Hyper-V crash ctl msr. This msr should be setup to HV_X64_MSR_CRASH_CTL_NOTIFY value so Hyper-V guest knows it can send crash data to host. But Hyper-V guest notifi

[Qemu-devel] [PATCH v2] block/curl: Don't lose original error when a connection

2015-06-30 Thread Richard W.M. Jones
No change since version 1, but I've added Jeff and Kevin to the CC as suggested by 'scripts/get_maintainer.pl'.

[Qemu-devel] [PATCH v2] block/curl: Don't lose original error when a connection fails.

2015-06-30 Thread Richard W.M. Jones
Currently if qemu is connected to a curl source (eg. web server), and the web server fails / times out / dies, you always see a bogus EIO "Input/output error". For example, choose a large file located on any local webserver which you control: $ qemu-img convert -p http://example.com/large.iso /

[Qemu-devel] [PATCH] spapr_vty: lookup should only return valid VTY objects

2015-06-30 Thread Greg Kurz
If a guest passes the reg property of a valid VIO object that is not a VTY to either H_GET_TERM_CHAR or H_PUT_TERM_CHAR, QEMU hits a dynamic cast assertion and aborts. PAPR+ says "Hypervisor checks the termno parameter for validity against the Vterm IOA unit addresses assigned to the partition, el

Re: [Qemu-devel] QEMU + KVM PSCI and VCPU creation / destruction

2015-06-30 Thread Andrew Jones
On Mon, Jun 29, 2015 at 07:51:15PM +0200, Claudio Fontana wrote: > Hello, > > while heavily testing PSCI on QEMU+KVM during OSv enablement, I encountered, > among others, the following issue: > > I am running a test in which I boot an OS at EL1 under KVM, then boot a > secondary VCPU, > then im

Re: [Qemu-devel] QEMU to generate host binary

2015-06-30 Thread Alex Bennée
Dr. David Alan Gilbert writes: > * Ayaz Akram (aaq...@gmail.com) wrote: >> Thanks for your answers. The thing that i still do not get is once we have >> host assembly code (output assembly log generated for compiled TBs ), >> should we still worry about problems like self modifying code and othe

Re: [Qemu-devel] [PATCH v3 0/9] HyperV equivalent of pvpanic driver

2015-06-30 Thread Daniel P. Berrange
On Tue, Jun 30, 2015 at 02:33:18PM +0300, Denis V. Lunev wrote: > Windows 2012 guests can notify hypervisor about occurred guest crash > (Windows bugcheck(BSOD)) by writing specific Hyper-V msrs. This patch does > handling of this MSR's by KVM and sending notification to user space that > allows to

[Qemu-devel] Exynos maintainership (was: RE: [PATCH 0/2] Remove CP15 timer from the device tree if KVM is used without in-kernel irqchip)

2015-06-30 Thread Pavel Fedin
Hello! > Speaking of Samsung, can you suggest a suitable update for > the MAINTAINERS file section for the Exynos board models? These guys do not work here any more, and their projects were closed long time ago. Currently those divisions are not interested in qemu any more, and Exynos is actu

Re: [Qemu-devel] [PATCH] spapr_vty: lookup should only return valid VTY objects

2015-06-30 Thread Greg Kurz
On Tue, 30 Jun 2015 14:04:31 +0200 Greg Kurz wrote: > If a guest passes the reg property of a valid VIO object that is not a VTY > to either H_GET_TERM_CHAR or H_PUT_TERM_CHAR, QEMU hits a dynamic cast > assertion and aborts. > > PAPR+ says "Hypervisor checks the termno parameter for validity aga

Re: [Qemu-devel] [PATCH v3 0/9] HyperV equivalent of pvpanic driver

2015-06-30 Thread Denis V. Lunev
On 30/06/15 15:26, Daniel P. Berrange wrote: On Tue, Jun 30, 2015 at 02:33:18PM +0300, Denis V. Lunev wrote: Windows 2012 guests can notify hypervisor about occurred guest crash (Windows bugcheck(BSOD)) by writing specific Hyper-V msrs. This patch does handling of this MSR's by KVM and sending n

Re: [Qemu-devel] [PATCH] block: remove redundant check before g_slist_find()

2015-06-30 Thread Stefan Hajnoczi
On Mon, Jun 29, 2015 at 04:12:13PM +0300, Alberto Garcia wrote: > An empty GSList is represented by a NULL pointer, therefore it's a > perfectly valid argument for g_slist_find() and there's no need to > make any additional check. > > Signed-off-by: Alberto Garcia > --- > block/io.c | 2 +- > 1

Re: [Qemu-devel] [PATCH] target-mips: fix MIPS64R6-generic configuration

2015-06-30 Thread Leon Alrae
On 29/06/2015 10:11, Yongbok Kim wrote: > Fix core configuration for MIPS64R6-generic to make it as close as > I6400. > I6400 core has 48-bit of Virtual Address available (SEGBITS). > MIPS SIMD Architecture is available. > Rearrange order of bits to match the specification. > > Signed-off-by: Yong

[Qemu-devel] [PATCH 4/5] hw/cpu/{a15mpcore, a9mpcore}: enable TrustZone in GIC if it is enabled in CPUs

2015-06-30 Thread Peter Maydell
If the A9 and A15 CPUs which we're creating the peripherals for have TrustZone (EL3) enabled, then also enable it in the GIC we create. Signed-off-by: Peter Maydell --- hw/cpu/a15mpcore.c | 13 + hw/cpu/a9mpcore.c | 11 +++ 2 files changed, 24 insertions(+) diff --git a/hw/

[Qemu-devel] [PATCH 0/5] arm: enable TZ support for the GIC

2015-06-30 Thread Peter Maydell
This patchset enables the TZ support in the GIC for the systems where we enable TZ support in the CPU. In practice that means just the "virt" and "vexpress" boards, since all the others disable the CPU TZ support. Patch 1 I've already put out on list as a bugfix targeting 2.4. The main interestin

Re: [Qemu-devel] [PATCH] refresh filename after the node is replaced

2015-06-30 Thread Max Reitz
On 29.06.2015 03:16, Wen Congyang wrote: On 06/26/2015 11:16 PM, Max Reitz wrote: On 26.06.2015 16:27, Wen Congyang wrote: At 2015/6/26 21:47, Max Reitz Wrote: On 25.06.2015 08:41, Wen Congyang wrote: We can use block job mirror to repair broken quorum files. But the command 'info block' does

Re: [Qemu-devel] [PATCH] linux-user: Fix MIPS N64 trap and break instruction bug

2015-06-30 Thread Leon Alrae
On 29/06/2015 11:20, Andrew Bennett wrote: > From: Andrew Bennett > > For the MIPS N64 ABI when QEMU reads the break/trap instruction so that > it can inspect the break/trap code it reads 8 rather than 4 bytes > which means it finds the code field from the instruction after the > break/trap inst

  1   2   3   >