Re: [Qemu-devel] [PULL v2 43/60] i386: drop FDC in pc-q35-2.4+ if neither it nor floppy drives are wanted

2015-06-19 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > From: Laszlo Ersek > > It is Very annoying to carry forward an outdatEd coNtroller with a mOdern > Machine type. > > Hence, let us not instantiate the FDC when all of the following apply: > - the machine type is pc-q35-2.4 or later, > - "-device isa-fdc" is not pas

Re: [Qemu-devel] [PATCH v3 00/11] implement dynamic endianness switching

2015-06-19 Thread Paolo Bonzini
On 18/06/2015 22:24, Peter Crosthwaite wrote: >> > >> > I'm pushing everything I have to tcg-arm-setend on my github repo. >> > > Already found that branch and have rebased it. It looks like since > yesterday your merge base has changed but is not fully up to date. Yes, the one before was tested

Re: [Qemu-devel] m68k orphaned?

2015-06-19 Thread Peter Maydell
On 19 June 2015 at 06:00, Greg Ungerer wrote: > Hi All, > > I see in the MAINTAINERS file that pretty much everything related > to the m68k architecture is listed as "Orphan". > > I have some patches that have been around for quite a while (posted > here twice) to fix some issues with the ColdFire

Re: [Qemu-devel] m68k orphaned?

2015-06-19 Thread Greg Ungerer
Hi Peter, On 19/06/15 15:53, Peter Crosthwaite wrote: > On Thu, Jun 18, 2015 at 10:00 PM, Greg Ungerer wrote: >> Hi All, >> >> I see in the MAINTAINERS file that pretty much everything related >> to the m68k architecture is listed as "Orphan". >> >> I have some patches that have been around for q

Re: [Qemu-devel] m68k orphaned?

2015-06-19 Thread Greg Ungerer
Hi Peter, On 19/06/15 17:12, Peter Maydell wrote: > On 19 June 2015 at 06:00, Greg Ungerer wrote: >> Hi All, >> >> I see in the MAINTAINERS file that pretty much everything related >> to the m68k architecture is listed as "Orphan". >> >> I have some patches that have been around for quite a while

Re: [Qemu-devel] m68k orphaned?

2015-06-19 Thread Peter Maydell
On 19 June 2015 at 08:17, Greg Ungerer wrote: > Hi Peter, > > On 19/06/15 17:12, Peter Maydell wrote: >> If you make the minor fixes Peter C has suggested, rebase >> them onto current master and resend with the relevant >> reviewed-by: tags in the commit messages, I'll apply >> them to master. > >

[Qemu-devel] [PATCH] CODING_STYLE: update line length and mixed declaration rules

2015-06-19 Thread Paolo Bonzini
1) Line lengths above 80 characters do exist. They are rare, but they happen from time to time. An ignored rule is worse than an exception to the rule, so do the latter. 2) Mixed declarations also do exist at the top of #ifdef blocks. Remark on this particular usage and suggest an alternative.

Re: [Qemu-devel] [RFC PATCH V3] Use atomic cmpxchg to atomically check the exclusive value in a STREX

2015-06-19 Thread Mark Burton
> On 18 Jun 2015, at 21:53, Peter Maydell wrote: > > On 18 June 2015 at 19:32, Mark Burton wrote: >> for the 1<> a little worrying - I’ll check. >> >>> On 18 Jun 2015, at 17:56, Peter Maydell wrote: >>> >>> On 18 June 2015 at 16:44, wrote: +uint64_t oldval, *p; +p

Re: [Qemu-devel] [RFC PATCH V3] Use atomic cmpxchg to atomically check the exclusive value in a STREX

2015-06-19 Thread Paolo Bonzini
On 19/06/2015 09:29, Mark Burton wrote: > Does anybody know if the current atomic_cmpxchg will support 64 bit > on a (normal) 32 bit x86, or do we need to special case that with > cmpxchg8b ? (I get the impression that it will automatically use > cmpxchg8b, but not cmpxchg16b - but I’m by no mean

Re: [Qemu-devel] [PULL 00/10] virtio, pci fixes, enhancements

2015-06-19 Thread Michael S. Tsirkin
On Thu, Jun 18, 2015 at 05:29:23PM +0100, Peter Maydell wrote: > On 18 June 2015 at 12:14, Michael S. Tsirkin wrote: > > On Thu, Jun 18, 2015 at 11:36:26AM +0100, Peter Maydell wrote: > >> Hi. I'm afraid this fails to build for OSX: > >> > >> LINK arm-softmmu/qemu-system-arm > >> Undefined symb

Re: [Qemu-devel] [RFC PATCH V3] Use atomic cmpxchg to atomically check the exclusive value in a STREX

2015-06-19 Thread Mark Burton
> On 19 Jun 2015, at 09:31, Paolo Bonzini wrote: > > > > On 19/06/2015 09:29, Mark Burton wrote: >> Does anybody know if the current atomic_cmpxchg will support 64 bit >> on a (normal) 32 bit x86, or do we need to special case that with >> cmpxchg8b ? (I get the impression that it will automat

Re: [Qemu-devel] [RFC PATCH V3] Use atomic cmpxchg to atomically check the exclusive value in a STREX

2015-06-19 Thread Paolo Bonzini
On 19/06/2015 09:40, Mark Burton wrote: >> On 19/06/2015 09:29, Mark Burton wrote: >>> Does anybody know if the current atomic_cmpxchg will support >>> 64 bit on a (normal) 32 bit x86, or do we need to special >>> case that with cmpxchg8b ? (I get the impression that it will >>> automatically use

[Qemu-devel] [PATCH] tap: fix non-linux build

2015-06-19 Thread Michael S. Tsirkin
tap_fd_set_vnet_le/tap_fd_set_vnet_be was missing, fix it up. Signed-off-by: Michael S. Tsirkin --- net/tap-aix.c | 10 ++ net/tap-bsd.c | 10 ++ net/tap-haiku.c | 10 ++ net/tap-solaris.c | 10 ++ net/tap-win32.c | 10 ++ 5 files changed, 50 i

Re: [Qemu-devel] [RFC PATCH V3] Use atomic cmpxchg to atomically check the exclusive value in a STREX

2015-06-19 Thread Mark Burton
> On 19 Jun 2015, at 09:42, Paolo Bonzini wrote: > > > > On 19/06/2015 09:40, Mark Burton wrote: >>> On 19/06/2015 09:29, Mark Burton wrote: Does anybody know if the current atomic_cmpxchg will support 64 bit on a (normal) 32 bit x86, or do we need to special case that with cmpx

[Qemu-devel] [PULL 06/15] i8254: fix out-of-bounds memory access in pit_ioport_read()

2015-06-19 Thread Paolo Bonzini
From: Petr Matousek Due converting PIO to the new memory read/write api we no longer provide separate I/O region lenghts for read and write operations. As a result, reading from PIT Mode/Command register will end with accessing pit->channels with invalid index. Fix this by ignoring read from the

[Qemu-devel] [PULL 00/15] Timer, virtio-scsi-test, build, memory changes for 2015-06-19

2015-06-19 Thread Paolo Bonzini
The following changes since commit 93f6d1c16036aaf34055d16f54ea770fb8d6d280: Merge remote-tracking branch 'remotes/kraxel/tags/pull-vga-20150615-1' into staging (2015-06-16 10:35:43 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you t

[Qemu-devel] [PULL 09/15] libqos: Complete virtio device ID definition list

2015-06-19 Thread Paolo Bonzini
From: Fam Zheng Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- tests/libqos/virtio.h | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/libqos/virtio.h b/tests/libqos/virtio.h index 2449fee..0101278 100644 --- a/tests/libqos/virtio.h +++ b/tests/lib

[Qemu-devel] [PULL 07/15] tests: Link libqos virtio object to virtio-scsi-test

2015-06-19 Thread Paolo Bonzini
From: Fam Zheng Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- tests/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile b/tests/Makefile index c5e4744..9ac7ac2 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -370,7 +370,7 @@ tests/virtio-

[Qemu-devel] [PULL 05/15] qemu-ga: Building Windows MSI installation with configure/Makefile

2015-06-19 Thread Paolo Bonzini
From: Yossi Hindin New options were added to enable Windows MSI installation package creation: Option --enable-guest-agent-msi, like the name suggests, enables building Windows MSI package for QEMU guest agent; option --disable-guest-agent-msi disables MSI package creation; by default, no MSI pa

[Qemu-devel] [PULL 10/15] tests: virtio-scsi: Move start/stop to individual test functions

2015-06-19 Thread Paolo Bonzini
From: Fam Zheng Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- tests/virtio-scsi-test.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/tests/virtio-scsi-test.c b/tests/virtio-scsi-test.c index 989f825..ba119c1 100644 --- a/tests/vir

[Qemu-devel] [PULL 01/15] qemu-log: Open file for logging when specified

2015-06-19 Thread Paolo Bonzini
From: Pranith Kumar qemu-log defaults to stderr when there is no '-D' option mentioned on command line. When '-D' option is specified, we also need to specify '-d' option for it to use the specified logfile. When using monitor to enable logging this is troublesome since there will be no '-d' opti

[Qemu-devel] [PULL 03/15] qemu-ga: debug printouts to help troubleshoot installation

2015-06-19 Thread Paolo Bonzini
From: Yossi Hindin Debug printouts extended, helps installation troubleshooting Signed-off-by: Yossi Hindin Message-Id: <1430913460-13174-3-git-send-email-yhin...@redhat.com> Signed-off-by: Paolo Bonzini --- qga/channel-win32.c | 2 +- qga/commands-win32.c | 1 + 2 files changed, 2 insertion

[Qemu-devel] [PULL 08/15] libqos: Allow calling guest_free on NULL pointer

2015-06-19 Thread Paolo Bonzini
From: Fam Zheng Signed-off-by: Fam Zheng Reviewed-by: John Snow Signed-off-by: Paolo Bonzini --- tests/libqos/malloc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/libqos/malloc.c b/tests/libqos/malloc.c index 8276130..82b9df5 100644 --- a/tests/libqos/malloc.c +++ b/tests/lib

[Qemu-devel] [PULL 14/15] exec: do not clamp accesses to MMIO regions

2015-06-19 Thread Paolo Bonzini
It is common for MMIO registers to overlap, for example a 4 byte register at 0xcf8 (totally random choice... :)) and a 1 byte register at 0xcf9. If these registers are implemented via separate MemoryRegions, it is wrong to clamp the accesses as the value written would be truncated. Hence for these

[Qemu-devel] [PULL 04/15] qemu-ga: Introduce Windows MSI script

2015-06-19 Thread Paolo Bonzini
From: Yossi Hindin The script enables building Windows MSI installation package on Linux with wixl tool. Signed-off-by: Yossi Hindin Message-Id: <1430913460-13174-4-git-send-email-yhin...@redhat.com> Signed-off-by: Paolo Bonzini --- qga/installer/qemu-ga.wxs | 145 +++

[Qemu-devel] [PULL 11/15] tests: virtio-scsi: Add test for unaligned WRITE SAME

2015-06-19 Thread Paolo Bonzini
From: Fam Zheng This is an exercise for virtio-scsi tests using the libqos virtio library. A few common routines are added to facilitate future extensions of the test set. The added test case is a regression test for the bug in d7f4b1999e. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 15/15] exec: clamp accesses against the MemoryRegionSection

2015-06-19 Thread Paolo Bonzini
Because the clamping was done against the MemoryRegion, address_space_rw was effectively broken if a write spanned multiple sections that are not linear in underlying memory (with the memory not being under an IOMMU). This is visible with the MIPS rc4030 IOMMU, which is implemented as a series of

[Qemu-devel] [PULL 02/15] qemu-ga: adding vss-[un]install options

2015-06-19 Thread Paolo Bonzini
From: Yossi Hindin Existing command line options include '-s install' and '-s uninstall'. These options install/uninstall both Windows QEMU GA service and optional VSS COM server. The QEMU GA Windows service allows always-on serving guest agent's QMP commands and VSS COM server enables guest agen

Re: [Qemu-devel] [PULL 1/1] virtio-input: evdev passthrough

2015-06-19 Thread Michael S. Tsirkin
On Thu, Jun 18, 2015 at 05:44:48PM +0200, Gerd Hoffmann wrote: > Hi, > > > > +static Property virtio_input_host_pci_properties[] = { > > > +DEFINE_VIRTIO_INPUT_PROPERTIES(VirtIOInputPCI, vdev.input), > > > +DEFINE_PROP_STRING("evdev", VirtIOInputHostPCI, vdev.evdev), > > > +DEFINE_PR

[Qemu-devel] [PULL 12/15] qemu-timer: Call clock reset notifiers on forward jumps

2015-06-19 Thread Paolo Bonzini
From: Paul Donohue Commit 691a0c9c introduced a mechanism by which QEMU_CLOCK_HOST can notify other parts of the emulator when the host clock has jumped backward. This is used to avoid stalling timers that were scheduled based on the host clock. However, if the host clock jumps forward, then ti

Re: [Qemu-devel] [PATCH] CODING_STYLE: update line length and mixed declaration rules

2015-06-19 Thread Thomas Huth
On Fri, 19 Jun 2015 09:29:04 +0200 Paolo Bonzini wrote: > 1) Line lengths above 80 characters do exist. They are rare, but > they happen from time to time. An ignored rule is worse than an > exception to the rule, so do the latter. > > 2) Mixed declarations also do exist at the top of #ifdef b

[Qemu-devel] [PULL 13/15] mc146818rtc: Reset the periodic timer on load

2015-06-19 Thread Paolo Bonzini
From: Paul Donohue When loading a VM from a snapshot or migration, clock changes can cause the periodic timer to stall or loop rapidly. qemu-timer has a reset notifier mechanism that is used to avoid timer stalls or loops if the host clock changes while the VM is running when using QEMU_CLOCK_HO

Re: [Qemu-devel] [PATCH] CODING_STYLE: update line length and mixed declaration rules

2015-06-19 Thread Paolo Bonzini
On 19/06/2015 09:53, Thomas Huth wrote: > > - WARN("line over 80 characters\n" . $herecurr); > > + if ($length > 90) { > > + ERROR("line over 90 characters\n" . $herecurr); > > + } if ($length > 80) { > > Did you mea

Re: [Qemu-devel] [PATCH] CODING_STYLE: update line length and mixed declaration rules

2015-06-19 Thread Andreas Färber
Am 19.06.2015 um 09:29 schrieb Paolo Bonzini: > 1) Line lengths above 80 characters do exist. They are rare, but > they happen from time to time. An ignored rule is worse than an > exception to the rule, so do the latter. > > 2) Mixed declarations also do exist at the top of #ifdef blocks. > Rem

Re: [Qemu-devel] Adding new migration-parameters - any easier way?

2015-06-19 Thread Markus Armbruster
zhanghailiang writes: > Hi, > > Is there any news about this discussion? > Is anyone working on it? ;) > > Since the 'hard feature freeze' time is closer, we'd better to fix it in 2.4 > before libvirt uses it. > > I have sent a RFC patch "[RFC] migration: Re-implement > 'migrate-set-parameters'

Re: [Qemu-devel] [PATCH] tap: fix non-linux build

2015-06-19 Thread Thomas Huth
On Fri, 19 Jun 2015 09:44:00 +0200 "Michael S. Tsirkin" wrote: > tap_fd_set_vnet_le/tap_fd_set_vnet_be was missing, > fix it up. > > Signed-off-by: Michael S. Tsirkin > --- > net/tap-aix.c | 10 ++ > net/tap-bsd.c | 10 ++ > net/tap-haiku.c | 10 ++ > net/tap-

Re: [Qemu-devel] [PATCH v2 0/3] Fix exceptions handling for MIPS and i386

2015-06-19 Thread Aurelien Jarno
On 2015-06-19 08:09, Pavel Dovgaluk wrote: > > From: Aurelien Jarno [mailto:aurel...@aurel32.net] > > On 2015-06-18 12:02, Paolo Bonzini wrote: > > > > > > TCG can then use them to fill in an array stored inside the > > > TranslationBlock, together with the host PC. Since the gen_opc_pc, > > > gen

Re: [Qemu-devel] [PULL 00/10] virtio, pci fixes, enhancements

2015-06-19 Thread Peter Maydell
On 19 June 2015 at 08:30, Michael S. Tsirkin wrote: > They are trivial - a single patch on top that adds stubs for missing > platforms. And I think breaking bisect on non-linux isn't a big deal. > If you agree, please apply. I would prefer the fix folded in to the correct point in the patchset,

Re: [Qemu-devel] Greate difference of disk I/O performance for guest on Qemu-2.30 of CentOS.

2015-06-19 Thread Paolo Bonzini
On 19/06/2015 03:03, cauchy-love wrote: > I have tried your qemu cammand line but got no luck (the embedded os > have no virtio support but this is not the problem i think). The > problem probably lies in the host kernel version as it is the only > difference for my tests. I traced the guest kern

Re: [Qemu-devel] [PATCH] CODING_STYLE: update line length and mixed declaration rules

2015-06-19 Thread Paolo Bonzini
On 19/06/2015 10:09, Andreas Färber wrote: >> > -Lines are 80 characters; not longer. >> > +Lines should be 80 characters; try not to make them longer. >> > + >> > +Sometimes it is hard to do, especially when dealing with QEMU subsystems >> > +that use long function or symbol names. Even in that

[Qemu-devel] [PATCH for-2.4 0/3] virtio-input: property fixes, add passthrough

2015-06-19 Thread Gerd Hoffmann
Hi, This little series updates the virtio-input devices to follow latest practices, so device properties are handled properly. It also adds evdev passthrough device for virtio-input (patch has updated property handling too), and finally a MAINTAINERS entry for virtio-input. please review, Ge

[Qemu-devel] [PATCH for-2.4 3/3] Add MAINTAINERS entry for virtio-input

2015-06-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 32c7ca4..9e06082 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -727,6 +727,12 @@ S: Supported F: hw/s390x/virtio-ccw.[hc] T: git git://github.com/cohuck/qemu vi

[Qemu-devel] [PATCH for-2.4 1/3] virtio-input: move properties, use virtio_instance_init_common

2015-06-19 Thread Gerd Hoffmann
Move properties from virtio-*-pci to virtio-*-device. Also make better use of QOM and attach common properties to the abstract parent classes (virtio-input-device and virtio-input-pci-device). Switch the hid device instance init functions over to use virtio_instance_init_common, so we get the prop

Re: [Qemu-devel] [PULL 1/1] virtio-input: evdev passthrough

2015-06-19 Thread Gerd Hoffmann
Hi, > > Hmm, looking into this. Can't figure how this works. For virtio-net a > > bunch of properties are defined for virtio-net-device. But they show up > > (using -device $dev,?) on both virtio-net-device and virtio-net-pci. > > > > Trying to do the same for the (already merged) virtio-inp

[Qemu-devel] [PATCH for-2.4 2/3] virtio-input: evdev passthrough

2015-06-19 Thread Gerd Hoffmann
This allows to assign host input devices to the guest: qemu -device virtio-input-host-pci,evdev=/dev/input/event The guest gets exclusive access to the input device, so be careful with assigning the keyboard if you have only one connected to your machine. Signed-off-by: Gerd Hoffmann --- hw/in

Re: [Qemu-devel] [PULL v2 00/12] QOM devices patch queue 2015-05-27

2015-06-19 Thread Andreas Färber
Am 28.05.2015 um 13:46 schrieb Peter Maydell: > On 27 May 2015 at 19:20, Andreas Färber wrote: >> Hello Peter, >> >> This is my QOM (devices) patch queue. Please pull. >> >> v2 contains changes that hopefully fix warnings on gcc 4.7. > > Hi. I'm afraid this doesn't build on our minimum glib versi

Re: [Qemu-devel] [PULL v2 00/12] QOM devices patch queue 2015-05-27

2015-06-19 Thread Peter Maydell
On 19 June 2015 at 09:45, Andreas Färber wrote: > Am 28.05.2015 um 13:46 schrieb Peter Maydell: >> On 27 May 2015 at 19:20, Andreas Färber wrote: >>> Hello Peter, >>> >>> This is my QOM (devices) patch queue. Please pull. >>> >>> v2 contains changes that hopefully fix warnings on gcc 4.7. >> >> H

Re: [Qemu-devel] [PATCH 5/6] vhost-net: tell tap backend about the vnet endianness

2015-06-19 Thread Thomas Huth
Hi, On Wed, 17 Jun 2015 15:23:49 +0200 Greg Kurz wrote: > The default behaviour for TAP/MACVTAP is to consider vnet as native endian. > > This patch handles the cases when this is not true: > - virtio 1.0: always little-endian > - legacy cross-endian > > Signed-off-by: Greg Kurz > --- > hw

Re: [Qemu-devel] [PATCH] tap: fix non-linux build

2015-06-19 Thread Greg Kurz
On Fri, 19 Jun 2015 09:44:00 +0200 "Michael S. Tsirkin" wrote: > tap_fd_set_vnet_le/tap_fd_set_vnet_be was missing, > fix it up. > > Signed-off-by: Michael S. Tsirkin > --- > net/tap-aix.c | 10 ++ > net/tap-bsd.c | 10 ++ > net/tap-haiku.c | 10 ++ > net/tap-s

Re: [Qemu-devel] [PATCH] q35: Re-enable FDC on pc-q35-2.3 and older

2015-06-19 Thread Peter Maydell
On 19 June 2015 at 07:43, Markus Armbruster wrote: > Laszlo Ersek writes: > >> On 06/18/15 18:49, Eduardo Habkost wrote: >>> commit ea96bc629cbd52be98b2967a4b4f72e91dfc3ee4 doesn't match the patch >>> submitted by Laszlo to qemu-devel. We reuse pc_q35_2_4_machine_options() >>> inside pc_q35_2_3_m

[Qemu-devel] [PATCH v2 1/1] vvfat: add a label option

2015-06-19 Thread Wolfgang Bumiller
Until now the vvfat volume label was hardcoded to be "QEMU VVFAT", now you can pass a file.label=labelname option to the -drive to change it. The FAT structure defines the volume label to be limited to 11 bytes and is filled up spaces when shorter than that. The trailing spaces however aren't expo

[Qemu-devel] [PATCH v2 0/1] vvfat label option updated

2015-06-19 Thread Wolfgang Bumiller
* Till/Until changed * Added (since 2.4) to json file * Added the 11-byte limit description. Without mentioning the trailing spaces in the json file since the guest OS doesn't expose them to the user. However, I mentioned it in the commit message. The limit comes from the FAT structure, but fo

Re: [Qemu-devel] [PATCH v3] cocoa.m: machine menu device menu items

2015-06-19 Thread Peter Maydell
On 15 June 2015 at 02:53, Programmingkid wrote: > Adds all removable devices to the Machine menu as a Change and Eject menu > item pair. ide-cd0 would have a "Change ide-cd0..." and "Eject ide-cd0" > menu items. > > Signed-off-by: John Arbuckle > > --- > Removed depreciated code from QEMU_Alert()

Re: [Qemu-devel] [PATCH 5/6] vhost-net: tell tap backend about the vnet endianness

2015-06-19 Thread Greg Kurz
On Fri, 19 Jun 2015 11:16:35 +0200 Thomas Huth wrote: > > Hi, > > On Wed, 17 Jun 2015 15:23:49 +0200 > Greg Kurz wrote: > > > The default behaviour for TAP/MACVTAP is to consider vnet as native endian. > > > > This patch handles the cases when this is not true: > > - virtio 1.0: always litt

Re: [Qemu-devel] [PATCH 2/2] target-i386: automatically raise cpuid level to 0xd

2015-06-19 Thread Radim Krčmář
2015-06-18 12:50-0300, Eduardo Habkost: > On Thu, Jun 18, 2015 at 05:24:24PM +0200, Radim Krčmář wrote: > > We already bump to level 7 if features there are requested, so do the > > same for 0xD. > > > > Signed-off-by: Radim Krčmář > > This breaks guest ABI and live-migration, as CPUID data is n

Re: [Qemu-devel] [PATCH 2/2] target-i386: automatically raise cpuid level to 0xd

2015-06-19 Thread Radim Krčmář
2015-06-19 11:47+0200, Radim Krčmář: > 2015-06-18 12:50-0300, Eduardo Habkost: > > I have considered introducing "min-[x]level" and "max-{x]level" > > properties to control automatic increasing of level/xlevel. The existing > > X86CPUDefinition.level field could just control min_level, while > > ex

[Qemu-devel] [PATCH] vhost_net: fix misuse of assert()

2015-06-19 Thread Greg Kurz
In case NDEBUG is defined, assert() expands to nothing and vhost_net_set_vnet_endian() doesn't get called... Suggested-by: Thomas Huth Signed-off-by: Greg Kurz --- hw/net/vhost_net.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Michael, Yet another fix for the cross-endian vhost

Re: [Qemu-devel] [PULL v2 07/12] vl: Create (most) objects before creating chardev backends

2015-06-19 Thread Andreas Färber
Am 27.05.2015 um 20:20 schrieb Andreas Färber: > From: "Daniel P. Berrange" > > Some types of object must be created before chardevs, other types of > object must be created after chardevs. As such there is no option but > to create objects in two phases. > > This takes the decision to create as

Re: [Qemu-devel] [PULL v2 07/12] vl: Create (most) objects before creating chardev backends

2015-06-19 Thread Paolo Bonzini
On 19/06/2015 12:03, Andreas Färber wrote: > Am 27.05.2015 um 20:20 schrieb Andreas Färber: >> From: "Daniel P. Berrange" >> >> Some types of object must be created before chardevs, other types of >> object must be created after chardevs. As such there is no option but >> to create objects in tw

Re: [Qemu-devel] [PATCH] vhost_net: fix misuse of assert()

2015-06-19 Thread Michael S. Tsirkin
On Fri, Jun 19, 2015 at 12:00:53PM +0200, Greg Kurz wrote: > In case NDEBUG is defined, assert() expands to nothing and > vhost_net_set_vnet_endian() doesn't get called... > > Suggested-by: Thomas Huth > Signed-off-by: Greg Kurz Not sure what the point is. We don't support building with NDEBUG.

[Qemu-devel] [PATCH v3 1/5] include/softmmu-semi.h: Make semihosting support 64-bit clean

2015-06-19 Thread Leon Alrae
From: "Maciej W. Rozycki" Correct addresses passed around in semihosting to use a data type suitable for both 32-bit and 64-bit targets. Signed-off-by: Maciej W. Rozycki Signed-off-by: Leon Alrae --- include/exec/softmmu-semi.h | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(

[Qemu-devel] [PATCH v3 2/5] hw/mips: Do not clear BEV for MIPS malta kernel load

2015-06-19 Thread Leon Alrae
From: Matthew Fortune The BEV flag controls whether the boot exception vector is still in place when starting a kernel. When cleared the exception vector at EBASE (or hard coded address of 0x8000) is used instead. The early stages of the linux kernel would benefit from BEV still being set t

[Qemu-devel] [PATCH v3 0/5] target-mips: add UHI semihosting support

2015-06-19 Thread Leon Alrae
This series introduces the Unified Hosting Interface support to QEMU. Version 3 of this patchset contains just minor cleanup and corrections in mips-semi.c comparing to previous version. It has been on the mailing list for a while and given that command line option responsible for passing semihost

Re: [Qemu-devel] [Qemu-block] [PATCH v7 00/11] Support streaming to an intermediate layer

2015-06-19 Thread Alberto Garcia
On Thu 18 Jun 2015 02:36:13 PM CEST, Eric Blake wrote: [Detecting support for intermediate block streaming] >> One possibility is to try to stream to an intermediate node and see >> if it fails. >> >> Example: in a chain like [A] <- [B] <- [C], streaming to [B] using >> [A] as the 'base' param

[Qemu-devel] [PATCH v3 4/5] target-mips: add Unified Hosting Interface (UHI) support

2015-06-19 Thread Leon Alrae
Add UHI semihosting support for MIPS. QEMU run with "-semihosting" option will alter the behaviour of SDBBP 1 instruction -- UHI operation will be called instead of generating a debug exception. Also tweak Malta's pseudo-bootloader. On CPU reset the $4 register is set to -1 if semihosting argument

[Qemu-devel] [PATCH v3 3/5] target-mips: remove identical code in different branch

2015-06-19 Thread Leon Alrae
Signed-off-by: Leon Alrae --- target-mips/translate.c | 25 - 1 file changed, 4 insertions(+), 21 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 1d128ee..6fd6dd9 100644 --- a/target-mips/translate.c +++ b/target-mips/translate.c @@ -1185

[Qemu-devel] [PATCH v3 5/5] target-mips: convert host to MIPS errno values when required

2015-06-19 Thread Leon Alrae
Convert only errno values which can be returned by system calls in mips-semi.c and are not generic to all archs. Signed-off-by: Leon Alrae --- target-mips/mips-semi.c | 44 +--- 1 file changed, 33 insertions(+), 11 deletions(-) diff --git a/target-mips/mi

[Qemu-devel] [PATCH] [RfC] fw_cfg file sort

2015-06-19 Thread Gerd Hoffmann
This is what it takes to have a sorted fw_cfg file directory. Entries are inserted at the correct place instead of being appended to the end in case sorting is enabled. Compatibility fluff (enable sorting for new machine types only) isn't there yet. Signed-off-by: Gerd Hoffmann --- hw/nvram/fw_

Re: [Qemu-devel] [PATCH] vhost_net: fix misuse of assert()

2015-06-19 Thread Peter Maydell
On 19 June 2015 at 11:07, Michael S. Tsirkin wrote: > On Fri, Jun 19, 2015 at 12:00:53PM +0200, Greg Kurz wrote: >> In case NDEBUG is defined, assert() expands to nothing and >> vhost_net_set_vnet_endian() doesn't get called... >> >> Suggested-by: Thomas Huth >> Signed-off-by: Greg Kurz > > Not

Re: [Qemu-devel] [PATCH] vhost_net: fix misuse of assert()

2015-06-19 Thread Michael S. Tsirkin
On Fri, Jun 19, 2015 at 11:13:40AM +0100, Peter Maydell wrote: > On 19 June 2015 at 11:07, Michael S. Tsirkin wrote: > > On Fri, Jun 19, 2015 at 12:00:53PM +0200, Greg Kurz wrote: > >> In case NDEBUG is defined, assert() expands to nothing and > >> vhost_net_set_vnet_endian() doesn't get called...

[Qemu-devel] [RFC PATCH v4 1/5] spapr: Initialize hotplug memory address space

2015-06-19 Thread Bharata B Rao
Initialize a hotplug memory region under which all the hotplugged memory is accommodated. Also enable memory hotplug by setting CONFIG_MEM_HOTPLUG. Modelled on i386 memory hotplug. Signed-off-by: Bharata B Rao --- default-configs/ppc64-softmmu.mak | 1 + hw/ppc/spapr.c| 28

[Qemu-devel] [RFC PATCH v4 3/5] spapr: Support ibm, dynamic-reconfiguration-memory

2015-06-19 Thread Bharata B Rao
Parse ibm,architecture.vec table obtained from the guest and enable memory node configuration via ibm,dynamic-reconfiguration-memory if guest supports it. This is in preparation to support memory hotplug for sPAPR guests. This changes the way memory node configuration is done. Currently all memory

[Qemu-devel] [RFC PATCH v4 2/5] spapr: Add LMB DR connectors

2015-06-19 Thread Bharata B Rao
Enable memory hotplug for pseries 2.4 and add LMB DR connectors. With memory hotplug, enforce NUMA node memory size and maxmem to be a multiple of SPAPR_MEMORY_BLOCK_SIZE (256M) since that's the granularity in which LMBs are represented and hot-added. LMB DR connectors will be used by the memory h

Re: [Qemu-devel] [PULL 00/10] virtio, pci fixes, enhancements

2015-06-19 Thread Michael S. Tsirkin
On Fri, Jun 19, 2015 at 09:32:48AM +0100, Peter Maydell wrote: > On 19 June 2015 at 08:30, Michael S. Tsirkin wrote: > > They are trivial - a single patch on top that adds stubs for missing > > platforms. And I think breaking bisect on non-linux isn't a big deal. > > If you agree, please apply. >

[Qemu-devel] [RFC PATCH v4 5/5] spapr: Memory hotplug support

2015-06-19 Thread Bharata B Rao
Make use of pc-dimm infrastructure to support memory hotplug for PowerPC. Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c| 126 ++ hw/ppc/spapr_events.c | 8 ++-- 2 files changed, 131 insertions(+), 3 deletions(-) diff --git a/hw/ppc/spa

[Qemu-devel] [RFC PATCH v4 0/5] Memory hotplug for PowerPC sPAPR guests

2015-06-19 Thread Bharata B Rao
Hi, This is the next version of memory hotplug support patchset for PowerPC sPAPR guests. This is a split-out from the previous version (v3) that was carrying CPU and memory hotplug together. This patchset applies on spapr-next branch of David Gibson's tree with the other prerequisite patchset ap

[Qemu-devel] [RFC PATCH v4 4/5] spapr: Make hash table size a factor of maxram_size

2015-06-19 Thread Bharata B Rao
The hash table size is dependent on ram_size, but since with hotplug the memory can grow till maxram_size. Hence make hash table size dependent on maxram_size. This allows to hotplug huge amounts of memory to the guest. Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c | 2 +- 1 file changed, 1 i

Re: [Qemu-devel] [PULL 00/15] Timer, virtio-scsi-test, build, memory changes for 2015-06-19

2015-06-19 Thread Peter Maydell
On 19 June 2015 at 08:45, Paolo Bonzini wrote: > The following changes since commit 93f6d1c16036aaf34055d16f54ea770fb8d6d280: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-vga-20150615-1' into > staging (2015-06-16 10:35:43 +0100) > > are available in the git repository at: > > g

Re: [Qemu-devel] [PATCH for-2.4 1/3] virtio-input: move properties, use virtio_instance_init_common

2015-06-19 Thread Michael S. Tsirkin
On Fri, Jun 19, 2015 at 10:38:35AM +0200, Gerd Hoffmann wrote: > Move properties from virtio-*-pci to virtio-*-device. > Also make better use of QOM and attach common properties > to the abstract parent classes (virtio-input-device and > virtio-input-pci-device). > > Switch the hid device instance

Re: [Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V based guest crash data handling

2015-06-19 Thread Andrey Smetanin
On Wed, 2015-06-17 at 14:44 +0200, Paolo Bonzini wrote: > > On 11/06/2015 15:18, Denis V. Lunev wrote: > > From: Andrey Smetanin > > > > Windows 2012 guests can notify hypervisor about occurred guest crash > > (Windows bugcheck(BSOD)) by writing specific Hyper-V msrs. This patch does > > handlin

[Qemu-devel] [PULL 3/3] ui/cocoa.m: Add machine menu items to change and eject removable drive media

2015-06-19 Thread Peter Maydell
From: John Arbuckle Adds all removable devices to the Machine menu as a Change and Eject menu item pair. ide-cd0 would have a "Change ide-cd0..." and "Eject ide-cd0" menu items. Signed-off-by: John Arbuckle Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- ui/cocoa.m | 156

[Qemu-devel] [PULL 2/3] ui/cocoa.m: Add Reset and Power Down menu items to Machine menu

2015-06-19 Thread Peter Maydell
From: John Arbuckle Add "Reset" and "Power Down" menu items to Machine menu. Signed-off-by: John Arbuckle Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- ui/cocoa.m | 17 + 1 file changed, 17 insertions(+) diff --git a/ui/cocoa.m b/ui/cocoa.m index d28140b..55905

[Qemu-devel] [PULL 1/3] ui/cocoa.m: Add Machine menu with pause and resume menu items

2015-06-19 Thread Peter Maydell
From: John Arbuckle Add Machine menu to the Macintosh interface with pause and resume menu items. These items can either pause or resume execution of the guest operating system. Signed-off-by: John Arbuckle Message-id: 6d7ae6aa-0595-4fad-aacf-9dfab8724...@gmail.com Reviewed-by: Peter Maydell S

[Qemu-devel] [PULL 0/3] cocoa queue

2015-06-19 Thread Peter Maydell
: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-cocoa-20150619-1 for you to fetch changes up to 693a3e01af8082f855094061650311fcaf3e1269: ui/cocoa.m: Add machine menu items to change and eject removable drive media (2015-06-19 11:22:31 +0100

Re: [Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V based guest crash data handling

2015-06-19 Thread Paolo Bonzini
On 19/06/2015 12:28, Andrey Smetanin wrote: > On Wed, 2015-06-17 at 14:44 +0200, Paolo Bonzini wrote: >> >> On 11/06/2015 15:18, Denis V. Lunev wrote: >>> From: Andrey Smetanin >>> >>> Windows 2012 guests can notify hypervisor about occurred guest crash >>> (Windows bugcheck(BSOD)) by writing sp

Re: [Qemu-devel] qapi: What does "'gen': false" actually do, and when should I use it?

2015-06-19 Thread Paolo Bonzini
On 09/06/2015 10:42, Markus Armbruster wrote: > Part 2: When to use it? > > We use 'gen': false when we can't (be bothered to) specify the exact > type of an argument or result. > > Bad example: netdev_add > > We have arguments 'type': 'str' and '*props': '**'. > > We should have a un

Re: [Qemu-devel] [PULL v2 07/12] vl: Create (most) objects before creating chardev backends

2015-06-19 Thread Daniel P. Berrange
On Fri, Jun 19, 2015 at 12:03:13PM +0200, Andreas Färber wrote: > Am 27.05.2015 um 20:20 schrieb Andreas Färber: > > From: "Daniel P. Berrange" > > > > Some types of object must be created before chardevs, other types of > > object must be created after chardevs. As such there is no option but >

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-19 Thread Stefan Hajnoczi
On Fri, Jun 19, 2015 at 08:54:56AM +0800, Wen Congyang wrote: > On 06/19/2015 12:06 AM, Stefan Hajnoczi wrote: > > On Thu, Jun 18, 2015 at 10:36:39PM +0800, Wen Congyang wrote: > >> At 2015/6/18 20:55, Stefan Hajnoczi Wrote: > >>> On Thu, Jun 18, 2015 at 04:49:12PM +0800, Wen Congyang wrote: >

Re: [Qemu-devel] [PATCH] vhost_net: fix misuse of assert()

2015-06-19 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Fri, Jun 19, 2015 at 11:13:40AM +0100, Peter Maydell wrote: >> On 19 June 2015 at 11:07, Michael S. Tsirkin wrote: >> > On Fri, Jun 19, 2015 at 12:00:53PM +0200, Greg Kurz wrote: >> >> In case NDEBUG is defined, assert() expands to nothing and >> >> vhost_net_se

Re: [Qemu-devel] [PATCH 0/4] block: Improve warnings for doubly-connected drives

2015-06-19 Thread Peter Maydell
Ping? thanks -- PMM On 12 June 2015 at 14:26, Peter Maydell wrote: > This patchset attempts to improve the warning and error messages for > bad user command lines that attempt to connect a drive up to two > devices. The motivation here is patch #4, which changes the default > interface for the v

Re: [Qemu-devel] incorrect memory size inside vm

2015-06-19 Thread Piotr Rybicki
Hello. Actually it was my mistake. After some time using memory in guest (find /, cp bigfine, etc), res size of qemu process shrinks to expected value. Sorry for disturbing. Now i don't see any memory waste in guest and host when using 'base' memory + 'dimm' memory. Although i have one issu

[Qemu-devel] [PATCH v2] target-i386: emulate CPUID level of real hardware

2015-06-19 Thread Radim Krčmář
W10 insider has a bug where it ignores CPUID level and interprets CPUID.(EAX=07H, ECX=0H) incorrectly, because CPUID in fact returned CPUID.(EAX=04H, ECX=0H); this resulted in execution of unsupported instructions. While it's a Windows bug, there is no reason to emulate incorrect level. I have u

Re: [Qemu-devel] [PATCH 2/2] target-i386: automatically raise cpuid level to 0xd

2015-06-19 Thread Radim Krčmář
2015-06-19 11:47+0200, Radim Krčmář: > 2015-06-18 12:50-0300, Eduardo Habkost: > > I have considered introducing "min-[x]level" and "max-{x]level" > > properties to control automatic increasing of level/xlevel. The existing > > X86CPUDefinition.level field could just control min_level, while > > ex

Re: [Qemu-devel] [PULL 00/10] virtio, pci fixes, enhancements

2015-06-19 Thread Peter Maydell
On 19 June 2015 at 11:19, Michael S. Tsirkin wrote: > On Fri, Jun 19, 2015 at 09:32:48AM +0100, Peter Maydell wrote: >> On 19 June 2015 at 08:30, Michael S. Tsirkin wrote: >> > They are trivial - a single patch on top that adds stubs for missing >> > platforms. And I think breaking bisect on non

[Qemu-devel] [PATCH] configure: Add support for jemalloc

2015-06-19 Thread Alexandre Derumier
This adds "--enable-jemalloc" and "--disable-jemalloc" to allow linking to jemalloc memory allocator. We have already tcmalloc support, but it seem to not working well with a lot of iothreads/disks. The main problem is that tcmalloc use a shared thread cache of 16MB by default. With more threads,

Re: [Qemu-devel] [PATCH v2] util/hbitmap: Add an API to reset all set bits in hbitmap

2015-06-19 Thread Stefan Hajnoczi
On Fri, May 22, 2015 at 09:29:46AM +0800, Wen Congyang wrote: > The function bdrv_clear_dirty_bitmap() is updated to use > faster hbitmap_reset_all() call. > > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Acked-by: Paolo Bonzini > Reviewed-by: Eric Blak

Re: [Qemu-devel] incorrect memory size inside vm

2015-06-19 Thread Andrey Korolyov
On Fri, Jun 19, 2015 at 2:14 PM, Piotr Rybicki wrote: > Hello. > > Actually it was my mistake. > After some time using memory in guest (find /, cp bigfine, etc), res size of > qemu process shrinks to expected value. > > Sorry for disturbing. > Now i don't see any memory waste in guest and host whe

Re: [Qemu-devel] incorrect memory size inside vm

2015-06-19 Thread Vasiliy Tolstov
2015-06-19 15:01 GMT+03:00 Andrey Korolyov : > > Please don`t top-post in technical mailing lists. Do you have a > crashkernel-reserved area there in the boot arguments? What > distro/guest kernel are running in this guest and what is dimm > configuration? disabling crashkernel in my case save is

[Qemu-devel] [PATCH v2] vhost_net: fix misuse of assert()

2015-06-19 Thread Greg Kurz
>From assert(3): "assert() is implemented as a macro; if the expression tested has side-effects, program behavior will be different depending on whether NDEBUG is defined." Even if QEMU isn't compiled with NDEBUG, it is bad practice to put bits with a relevant functionnal meaning in assert(). Thi

Re: [Qemu-devel] [PULL 0/3] cocoa queue

2015-06-19 Thread Peter Maydell
5-2.3 and older (2015-06-19 09:40:35 +0100) > > are available in the git repository at: > > git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-cocoa-20150619-1 > > for you to fetch changes up to 693a3e01af8082f855094061650311fcaf3e1269: > > ui/cocoa.m: Add machin

  1   2   3   4   >