Am 28.05.2015 um 13:46 schrieb Peter Maydell: > On 27 May 2015 at 19:20, Andreas Färber <afaer...@suse.de> wrote: >> Hello Peter, >> >> This is my QOM (devices) patch queue. Please pull. >> >> v2 contains changes that hopefully fix warnings on gcc 4.7. > > Hi. I'm afraid this doesn't build on our minimum glib version (2.22): > > /Users/pm215/src/qemu/tests/check-qom-proplist.c:235:5: warning: implicit > declaration of function 'g_assert_null' is invalid in C99 > [-Wimplicit-function-declaration] > g_assert_null(dobj); > ^ > /Users/pm215/src/qemu/tests/check-qom-proplist.c:236:5: warning: implicit > declaration of function 'g_assert_nonnull' is invalid in C99 > [-Wimplicit-function-declaration] > g_assert_nonnull(err); > ^ > > g_assert_nonnull() first appears in glib 2.38.
Holy crap... :/ I could've sworn that Anthony did not apply the same minimum-glib version for make check as for the actual code, and macros should be easy to add to our glib-compat.h, but let's get this in first and consider refactorings then. Unfortunately the pull no longer applies cleanly due to QemuOpts changes in vl.c, looking into it. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg)
