On 18/06/2015 10:58, zhanghailiang wrote:
> +void qemu_system_shutdown_request(void)
> +{
> +trace_qemu_system_shutdown_request();
> +/*
> +* if in colo mode, we need do some significant work before respond to the
> +* shutdown request.
> +*/
> +if (loadvm_in_colo_state())
On 18 June 2015 at 15:23, Emilio G. Cota wrote:
> On Thu, Jun 18, 2015 at 08:42:40 +0100, Peter Maydell wrote:
>> > What data structures are you referring to? Are they ppc-specific?
>>
>> None of the code generation data structures are locked at all --
>> if two threads try to generate code at the
Am 16.06.2015 um 23:23 schrieb Aurelien Jarno:
> On 2015-06-16 23:08, Alexander Graf wrote:
>> We now finally have TCG support for the basic set of instructions necessary
>> to run the s390-ccw machine. That means in any aspect possible that machine
>> type is now superior to the legacy s390-virtio
On 18 June 2015 at 15:30, Liviu Ionescu wrote:
>
>> On 18 Jun 2015, at 13:21, Peter Maydell wrote:
>>
>> ... "do_unassigned_access" is the QOM CPUClass hook for this,
>
> this hook seems associated with the "Trying to execute code outside
> RAM or ROM at 0x" error, which is a bit different, I wan
Hello,
commit ea96bc629cbd52be98b2967a4b4f72e91dfc3ee4
i386: drop FDC in pc-q35-2.4+ if neither it nor floppy drives are wanted
dropped the controller for older machine types too, despite the commit
message.
It seems the logic in the merged commit does not match the original patch:
http://thre
On Tue, Jun 16, 2015 at 10:05 AM, Jason Wang wrote:
>
>
> On 06/16/2015 03:24 PM, Thibaut Collet wrote:
>> If my understanding is correct, on a resume operation, we have the
>> following callback trace:
>> 1. virtio_pci_restore function that calls all restore call back of
>> virtio devices
>> 2. v
At 2015/6/18 20:47, Stefan Hajnoczi Wrote:
On Thu, Jun 18, 2015 at 04:49:11PM +0800, Wen Congyang wrote:
Signed-off-by: Wen Congyang
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
---
block.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/block.c b/block.c
index d1ed227.
The first patch uses CPUID levels from the internet, which has a nice
side effect of making W10 insider preview bootable.
The second patch is a traditional buggy bug fix.
Radim Krčmář (2):
target-i386: emulate CPUID level of real hardware
target-i386: automatically raise cpuid level to 0xd
W10 insider has a bug where it ignores CPUID level and interprets
CPUID.(EAX=07H, ECX=0H) incorrectly, because CPUID in fact returned
CPUID.(EAX=04H, ECX=0H); this resulted in execution of unsupported
instructions.
While it's a Windows bug, there is no reason to emulate incorrect level;
and amend
We already bump to level 7 if features there are requested, so do the
same for 0xD.
Signed-off-by: Radim Krčmář
---
If we want this behavior, we should not do it by writing a case for
every level.
target-i386/cpu.c | 4
1 file changed, 4 insertions(+)
diff --git a/target-i386/cpu.c b/ta
On 18/06/2015 17:24, Radim Krčmář wrote:
> W10 insider has a bug where it ignores CPUID level and interprets
> CPUID.(EAX=07H, ECX=0H) incorrectly, because CPUID in fact returned
> CPUID.(EAX=04H, ECX=0H); this resulted in execution of unsupported
> instructions.
>
> While it's a Windows bug, t
Eric Blake writes:
> On 06/17/2015 01:24 AM, Michael S. Tsirkin wrote:
>> makes it possible to copy error_abort pointers,
>> not just pass them on directly.
>>
>
>> @@ -168,7 +175,7 @@ void error_free(Error *err)
>>
>> void error_propagate(Error **dst_errp, Error *local_err)
>> {
>> -if
2015-06-18 17:29+0200, Paolo Bonzini:
> On 18/06/2015 17:24, Radim Krčmář wrote:
> > W10 insider has a bug where it ignores CPUID level and interprets
> > CPUID.(EAX=07H, ECX=0H) incorrectly, because CPUID in fact returned
> > CPUID.(EAX=04H, ECX=0H); this resulted in execution of unsupported
> >
On 06/18/15 15:40, Michael S. Tsirkin wrote:
> On Thu, Jun 18, 2015 at 03:22:59PM +0200, Laszlo Ersek wrote:
>> On 06/17/15 23:50, Michael S. Tsirkin wrote:
>>> On Wed, Jun 17, 2015 at 09:44:07PM +0200, Laszlo Ersek wrote:
On 06/17/15 21:32, Michael S. Tsirkin wrote:
> On Wed, Jun 17, 2015
On 18/06/2015 17:40, Radim Krčmář wrote:
> > This unfortunately has to be done only for new machine types. Old types
> > will remain buggy forever.
>
> Ah, ok, which machine type should I target, 2.4?
Yes.
> And is patch 2 is only supposed to work with new machine types?
I'm a bit undecided t
It is common for MMIO registers to overlap, for example a 4 byte register
at 0xcf8 (totally random choice... :)) and a 1 byte register at 0xcf9.
If these registers are implemented via separate MemoryRegions, it is
wrong to clamp the accesses as the value written would be truncated.
Hence for these
The first patch fixes the remaining problems with Peter Crosthwaite's
access clamping patch (which broke kvmvapic and hence Windows XP/2003).
The second patch actually puts the clamping to good use: by fixing
address_space_translate_internal, the MIPS rc4030 emulation does not need
anymore the addr
Because the clamping was done against the MemoryRegion,
address_space_rw was effectively broken if a write spanned
multiple sections that are not linear in underlying memory
(with the memory not being under an IOMMU).
This is visible with the MIPS rc4030 IOMMU, which is implemented
as a series of
Hi,
> > +static Property virtio_input_host_pci_properties[] = {
> > +DEFINE_VIRTIO_INPUT_PROPERTIES(VirtIOInputPCI, vdev.input),
> > +DEFINE_PROP_STRING("evdev", VirtIOInputHostPCI, vdev.evdev),
> > +DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, 2),
> > +DEFINE_PROP_END
From: KONRAD Frederic
This mechanism replaces the existing load/store exclusive mechanism which seems
to be broken for multithread.
It follows the intention of the existing mechanism and stores the target address
and data values during a load operation and checks that they remain unchanged
before
On 18/06/2015 17:44, fred.kon...@greensocs.com wrote:
> +hwaddr len = 8 << size;
Should be 1 << size, and likewise below in the "if".
Paolo
> +hwaddr paddr;
> +target_ulong page_size;
> +int prot;
> +
> +arm_exclusive_lock();
> +
> +if (env->exclusive_addr != addr) {
>
On Thu, Jun 18, 2015 at 05:24:24PM +0200, Radim Krčmář wrote:
> We already bump to level 7 if features there are requested, so do the
> same for 0xD.
>
> Signed-off-by: Radim Krčmář
This breaks guest ABI and live-migration, as CPUID data is not part of
the migration stream (although we have cons
commit fa92e218df1d ("s390x/ipl: avoid sign extension") introduced
a regression:
qemu-system-s390x -drive file=/home/cborntra/image.zhyp409,format=qcow2
does not boot, the bios states
"No virtio-blk device found!"
adding bootindex=1 does boot.
The reason is that the uint32_t as return value will
On Wed, Jun 17, 2015 at 01:37:18PM +0300, Alexander Yarygin wrote:
> Changes in v3:
>- Added aio_context_acquire/aio_context_release around blk_drain() in
> "virtio-blk: Use blk_drain() to drain IO requests" + updated commit
> description
>
> Please update Cc: qemu-stable@ if it nece
On 18 June 2015 at 16:44, wrote:
> +uint64_t oldval, *p;
> +p = address_space_map(cs->as, paddr, &len, true);
> +if (len == 8 << size) {
> +oldval = (uint64_t)env->exclusive_val;
> +result = (atomic_cmpxchg(p, oldval, (uint64_t)newval) == oldval);
Add new "arg" sub-argument to the --semihosting-config allowing the user
to pass multiple input arguments separately. It is required for example
by UHI semihosting to construct argc and argv.
Also, update ARM semihosting to support new option (at the moment it is
the only target which cares about
Just a rebase of v4 as there were changes in qemu_opt_foreach API.
Regards,
Leon
v5:
* rebase
v4:
* add semihosting_get_cmdline() and update arm-semi.c to support new option
* for backward compatibility use -kernel/-append to initialize semihosting.argv
* update qemu doc to describe the interact
Remove semihosting_enabled and semihosting_target and replace them with
SemihostingConfig structure containing equivalent fields. The structure
is defined in vl.c where it is actually set.
Also introduce separate header file include/exec/semihost.h allowing to
access semihosting config related stu
On 06/16/2015 04:57 PM, Aurelien Jarno wrote:
The MOVE LONG instruction should pad the destination operand with the
byte from bit positions 32-39 of the source length (r2 + 1), not with
the same byte in the source address.
Cc: Alexander Graf
Cc: Richard Henderson
Signed-off-by: Aurelien Jarno
--
On Thu, Jun 18, 2015 at 10:36:39PM +0800, Wen Congyang wrote:
> At 2015/6/18 20:55, Stefan Hajnoczi Wrote:
> >On Thu, Jun 18, 2015 at 04:49:12PM +0800, Wen Congyang wrote:
> >>+void bdrv_connect(BlockDriverState *bs, Error **errp)
> >>+{
> >>+BlockDriver *drv = bs->drv;
> >>+
> >>+if (drv &
On Thu, Jun 18, 2015 at 04:08:41PM +0200, Wolfgang Bumiller wrote:
> Till now the vvfat filesystem's label was hardcoded to be
> "QEMU VVFAT", now you can pass a file.label=labelname option
> to the -drive to change it.
>
> Signed-off-by: Wolfgang Bumiller
> ---
> block/vvfat.c| 25 +
"Michael S. Tsirkin" writes:
> makes it possible to copy error_abort pointers,
> not just pass them on directly.
Humor me, and start your sentences with a capital letter :)
> This is needed because follow-up patches add support for
> Error *local_err = ...;
> as a way to set an abort-on-err
These are the new patches for SMRAM support, using multiple address spaces
and, thus, multiple KVMMemoryListeners. No more layering violations, yay!
The meat is in patches 6 and 7, which parameterize KVM's memory listener
so that: 1) each memory listener handles its own array of memory slots;
2)
On 16 June 2015 at 02:51, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Hi,
>
> This is what is left of round 3 of our series towards support for EL2 for
> AArch64.
>
> Comments welcome!
Given that we're now in softfreeze, and these patches don't actually
enable a new feature by thems
From: Andrew Jones
Currently kvm_mem_flags just translates bools to bits, let's
make it also determine the bools first. This avoids its parameter
list growing each time we add a flag.
Signed-off-by: Andrew Jones
Signed-off-by: Paolo Bonzini
---
kvm-all.c | 42 -
Apart from the MSR, the smi field of struct kvm_vcpu_events has to be
translated into the corresponding CPUX86State fields. Also,
memory transaction flags depend on SMM state, so pull it from struct
kvm_run on every exit from KVM to userspace.
Signed-off-by: Paolo Bonzini
---
target-i386/cpu.h
Signed-off-by: Paolo Bonzini
---
kvm-all.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index 195886d..abde1cf 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -69,8 +69,6 @@ typedef struct KVMSlot
int flags;
} KVMSlot;
-typedef struct kvm_dirty_lo
On 18 June 2015 at 12:14, Michael S. Tsirkin wrote:
> On Thu, Jun 18, 2015 at 11:36:26AM +0100, Peter Maydell wrote:
>> Hi. I'm afraid this fails to build for OSX:
>>
>> LINK arm-softmmu/qemu-system-arm
>> Undefined symbols for architecture x86_64:
>> "_tap_fd_set_vnet_be", referenced from:
>
i386 code will have to define a different KVMMemoryListener. Create
an internal header so that KVMSlot is not exposed outside.
Signed-off-by: Paolo Bonzini
---
include/sysemu/kvm_int.h | 30 ++
kvm-all.c| 18 +-
2 files changed, 31 ins
These commands are handled entirely by QEMU. Do not raise an SMI
when they happen, because Windows (at least 2008r2) expects these
commands to work and (depending on the value of APMC_EN at
startup) the firmware might not have installed an SMI handler.
When this happens (e.g. the kernel supports
KVM_CREATE_IRQCHIP should never fail, and so should its userspace
wrapper kvm_irqchip_create. The function does not do anything
if the irqchip capability is not available, as is the case for PPC.
With this patch, kvm_arch_init can allocate memory and it will not
be leaked.
Signed-off-by: Paolo B
Make kvm_memory_listener_register public, and assign a kernel
address space id to each KVMMemoryListener.
Signed-off-by: Paolo Bonzini
---
include/sysemu/kvm_int.h | 4
kvm-all.c| 13 ++---
2 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/include/syse
We will enable SMM even if KVM is in use. Rename the field and
arguments.
Signed-off-by: Paolo Bonzini
---
hw/acpi/piix4.c | 10 +-
hw/i386/pc_piix.c| 2 +-
include/hw/i386/pc.h | 2 +-
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/acpi/piix4.c b/hw/acpi/p
The property can take values on, off or auto. The default is "off"
for KVM and pre-2.4 machines, otherwise "auto" (which makes it
available on TCG or on new-enough kernels).
Signed-off-by: Paolo Bonzini
---
hw/i386/pc.c | 51 +++
hw/i386/p
Q35's ACPI device is hard-coding SMM availability to KVM. Place the
logic where the board is created instead, so that it will be possible
to override it.
Signed-off-by: Paolo Bonzini
---
hw/acpi/ich9.c | 5 +++--
hw/i386/pc_q35.c | 2 +-
hw/isa/lpc_ich9.c | 6 --
include/
"Michael S. Tsirkin" writes:
> It's a common idiom:
>
> Error *local_err = NULL;
>
> foo(&local_err);
> ...
> if (local_err) {
> error_propagate(errp, local_err);
> return;
> }
>
> Unfortunately it mean
Signed-off-by: Paolo Bonzini
---
target-i386/kvm.c | 41 -
1 file changed, 40 insertions(+), 1 deletion(-)
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 6ee5feb..3e7b26b 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -22,7 +22,7 @@
No semantic change, but s->slots moves into a new struct
KVMMemoryListener. KVM's memory listener becomes a member of struct
KVMState, and becomes of type KVMMemoryListener.
Signed-off-by: Paolo Bonzini
---
include/sysemu/kvm_int.h | 5 ++
kvm-all.c| 151 ++
This series of patches adds a new -audiodev command line option to
specify audio subsytem parameters instead of environment variables.
This will later allow us to specify multiple audio backends. The
syntax is something like this:
-audiodev driver_name,id=id,property=value,...
like:
-audiodev a
Signed-off-by: Kővágó, Zoltán
---
numa.c | 2 +-
qapi-schema.json | 47 ---
2 files changed, 37 insertions(+), 12 deletions(-)
diff --git a/numa.c b/numa.c
index d227ccc..822a22e 100644
--- a/numa.c
+++ b/numa.c
@@ -141,7 +141,7 @@ static in
Signed-off-by: Kővágó, Zoltán
---
hw/arm/musicpal.c| 2 +-
hw/core/qdev-properties-system.c | 2 +-
hw/net/allwinner_emac.c | 2 +-
hw/net/cadence_gem.c | 2 +-
hw/net/dp8393x.c | 2 +-
hw/net/e1000.c | 2 +-
hw/ne
This will let us print options in a format that the user would actually
write it on the command line (foo=bar,baz=asd,etc=def), without
prepending a spurious comma at the beginning of the list, or quoting
values unnecessarily. This patch provides the following changes:
* write and id=, if the opti
On Tue, 2015-06-16 at 16:10 +0800, Chen Fan wrote:
> Signed-off-by: Chen Fan
> ---
> hw/vfio/common.c | 9 -
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/hw/vfio/common.c b/hw/vfio/common.c
> index df3171d..15f19a2 100644
> --- a/hw/vfio/common.c
> +++ b/hw/vfio/comm
They are required for flat unions (you still have to allocate the
structs).
Signed-off-by: Kővágó, Zoltán
---
qapi/opts-visitor.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
index f2ad6d7..f02059d 100644
--- a/qapi/opts-visitor.c
This patch adds structures into qapi to replace the existing
configuration structures used by audio backends currently. This qapi
will be the base of the -audiodev command line parameter (that replaces
the old environment variables based config).
This is not a 1:1 translation of the old options, I
I had to include an enum for audio sampling formats into qapi, but that
meant duplicating the audfmt_e enum. This patch replaces audfmt_e and
associated values with the qapi generated AudioFormat enum.
This patch is mostly a search-and-replace, except for switches where the
qapi generated AUDIO_F
The current OptsVisitor flattens the whole structure, if there are same
named fields under different paths (like `in' and `out' in `Audiodev'),
the current visitor can't cope with them (for example setting
`frequency=44100' will set the in's frequency to 44100 and leave out's
frequency unspecified)
This function will be used to avoid recursive locking of the iothread lock
whenever address_space_rw/ld*/st* are called with the BQL held, which is
almost always the case.
Tracking whether the iothread is owned is very cheap (just use a TLS
variable) but requires some care because now the lock mus
This patch adds an -audiodev command line option, and deprecates the
QEMU_* environment variables for audio backend configuration. It's
syntax is similar to existing options (-netdev, -device, etc): -audiodev
driver_name,property=value,...
Audio drivers now get an Audiodev * as config paramters,
From: Jan Kiszka
This introduces the memory region property "global_locking". It is true
by default. By setting it to false, a device model can request BQL-free
dispatching of region accesses to its r/w handlers. The actual BQL
break-up will be provided in a separate patch.
Signed-off-by: Jan Ki
This is the rebased and updated version of the patches I posted a
couple months ago (well before soft freeze :)).
This version introduces a qemu_mutex_iothread_locked() primitive
in order to avoid recursive locking of the BQL. The previous
attempts, which used functions such as address_space_rw_u
As memory_region_read/write_accessor will now be run also without BQL held,
we need to move coalesced MMIO flushing earlier in the dispatch process.
Signed-off-by: Paolo Bonzini
---
exec.c | 21 +
memory.c | 6 --
2 files changed, 21 insertions(+), 6 deletions(-)
diff
From: Jan Kiszka
The MMIO case is further broken up in two cases: if the caller does not
hold the BQL on invocation, the unlocked one takes or avoids BQL depending
on the locking strategy of the target memory region and its coalesced
MMIO handling. In this case, the caller should not hold _any_
The next patch will require the BQL to be always taken with
qemu_mutex_lock_iothread(), while right now this isn't the case.
Outside TCG mode this is not a problem. In TCG mode, we need to be
careful and avoid the "prod out of compiled code" step if already
in a VCPU thread. This is easily done
From: Jan Kiszka
Do not take the BQL before dispatching PIO requests of KVM VCPUs.
Instead, address_space_rw will do it if necessary. This enables
completely BQL-free PIO handling in KVM mode for upcoming devices with
fine-grained locking.
Signed-off-by: Jan Kiszka
Signed-off-by: Paolo Bonzini
Accessing QEMU_CLOCK_VIRTUAL is thread-safe.
Signed-off-by: Paolo Bonzini
---
hw/acpi/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/acpi/core.c b/hw/acpi/core.c
index 0f201d8..fe6215a 100644
--- a/hw/acpi/core.c
+++ b/hw/acpi/core.c
@@ -528,6 +528,7 @@ void acpi_pm_tmr_init(ACPIR
From: Jan Kiszka
This opens the path to get rid of the iothread lock on vmexits in KVM
mode. On x86, the in-kernel irqchips has to be used because we otherwise
need to synchronize APIC and other per-cpu state accesses that could be
changed concurrently.
s390x and ARM should be fine without speci
On 18/06/2015 18:34, Markus Armbruster wrote:
> Here's an utterly trivial way to get some of the gain for none of the
> complexity: make error_setg() & friends store caller's __FILE__ and
> __LINE__.
Yes, please!!
Paolo
Do not take the BQL before dispatching MMIO requests of KVM VCPUs.
Instead, address_space_rw will do it if necessary. This enables completely
BQL-free MMIO handling in KVM mode for upcoming devices with fine-grained
locking.
Signed-off-by: Paolo Bonzini
---
kvm-all.c | 3 +--
1 file changed, 3 d
commit ea96bc629cbd52be98b2967a4b4f72e91dfc3ee4 doesn't match the patch
submitted by Laszlo to qemu-devel. We reuse pc_q35_2_4_machine_options()
inside pc_q35_2_3_machine_options(), so we need to undo the no_floppy
change in pc_q35_2_3_machine_options().
This restores the previous behavior where a
On Thu, Jun 18, 2015 at 05:27:54PM +0100, Peter Maydell wrote:
> On 16 June 2015 at 02:51, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias"
> >
> > Hi,
> >
> > This is what is left of round 3 of our series towards support for EL2 for
> > AArch64.
> >
> > Comments welcome!
>
> Given that we
This small series covers the crypto consolidation patches
I previously posted:
RFC: https://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg02038.html
v1: https://lists.nongnu.org/archive/html/qemu-devel/2015-05/msg04267.html
v2: https://lists.nongnu.org/archive/html/qemu-devel/2015-06/msg00
Introduce a new crypto/ directory that will (eventually) contain
all the cryptographic related code. This initially defines a
wrapper for initializing gnutls and for computing hashes with
gnutls. The former ensures that gnutls is guaranteed to be
initialized exactly once in QEMU regardless of CLI a
To prepare for a generic internal cipher API, move the
built-in D3DES implementation into the crypto/ directory.
This is not in fact a normal D3DES implementation, it is
D3DES with double & triple length modes removed, and the
key bytes in reversed bit order. IOW it is crippled
specifically for th
To prepare for a generic internal cipher API, move the
built-in AES implementation into the crypto/ directory
Signed-off-by: Daniel P. Berrange
---
block/qcow.c | 2 +-
block/qcow2.c | 1 -
block/qcow2.h | 2 +-
crypto/Makefile.objs |
Remove the direct use of gnutls for hash processing in the
websockets code, in favour of using the crypto APIs. This
allows the websockets code to be built unconditionally
removing countless conditional checks from the VNC code.
Signed-off-by: Daniel P. Berrange
---
configure| 19 +--
Introduce a generic cipher API and an implementation of it that
supports only the built-in AES and DES-RFB algorithms.
The test suite checks the supported algorithms + modes to
validate that every backend implementation is actually correctly
complying with the specs.
Signed-off-by: Daniel P. Berr
Switch the VNC server over to use the generic cipher API, this
allows it to use the pluggable DES implementations, instead of
being hardcoded to use QEMU's built-in impl.
Signed-off-by: Daniel P. Berrange
---
ui/vnc.c | 52 +---
1 file changed, 41
Get rid of direct use of gnutls APIs in quorum blockdrv in
favour of using the crypto APIs. This avoids the need to
do conditional compilation of the quorum driver. It can
simply report an error at file open file instead if the
required hash algorithm isn't supported by QEMU.
Signed-off-by: Daniel
If we are linking to gnutls already and gnutls is built against
gcrypt, then we should use gcrypt as a cipher backend in
preference to our built-in backend.
This will be used when linking against GNUTLS 1.x and many
GNUTLS 2.x versions.
Signed-off-by: Daniel P. Berrange
---
configure
Switch the qcow/qcow2 block driver over to use the generic cipher
API, this allows it to use the pluggable AES implementations,
instead of being hardcoded to use QEMU's built-in impl.
Signed-off-by: Daniel P. Berrange
---
block/qcow.c | 102 +-
If we are linking to gnutls already and gnutls is built against
nettle, then we should use nettle as a cipher backend in
preference to our built-in backend.
This will be used when linking against some GNUTLS 2.x versions
and all GNUTLS 3.x versions.
Signed-off-by: Daniel P. Berrange
---
configu
Eduardo Habkost writes:
> On Thu, Jun 18, 2015 at 05:24:24PM +0200, Radim Krčmář wrote:
>> We already bump to level 7 if features there are requested, so do the
>> same for 0xD.
But doesn't bumping to 7 for feat[ebx] have the potential to break
ABI too ?
>> Signed-off-by: Radim Krčmář
>
> This
On 06/18/15 18:43, Kővágó, Zoltán wrote:
> The current OptsVisitor flattens the whole structure, if there are same
> named fields under different paths (like `in' and `out' in `Audiodev'),
> the current visitor can't cope with them (for example setting
> `frequency=44100' will set the in's frequenc
All callsites to this function navigate the cpu->env_ptr only for the
function to take the env ptr back to the original cpu ptr. Change the
function to just pass in the CPU pointer instead. Removes a core code
usage of ENV_GET_CPU (in gdbstub.c).
Cc: Riku Voipio
Reviewed-by: Andreas Färber
Signe
From: Bharata B Rao
Add an Error argument to cpu_exec_init() to let users collect the
error. This is in preparation to change the CPU enumeration logic
in cpu_exec_init(). With the new enumeration logic, cpu_exec_init()
can fail if cpu_index values corresponding to max_cpus have already
been hand
From: Bharata B Rao
Move cpu_exec_init() call from instance_init to realize. This allows
any failures from cpu_exec_init() to be handled appropriately.
Also add corresponding cpu_exec_exit() call from unrealize.
cpu_dt_id assignment from instance_init is no longer needed since
correct assignment
Remove un-needed usages of ENV_GET_CPU() by converting the APIs to use
CPUState pointers and retrieving the env_ptr as minimally needed.
Scripted conversion for target-* change:
for I in target-*/cpu.h; do
sed -i \
's/\(^int cpu_[^_]*_exec(\)[^ ][^ ]* \*s);$/\1CPUState *cpu);/' \
$I;
The sole caller of this function navigates the cpu->env_ptr only for
this function to take it back the cpu pointer straight away. Pass in
cpu pointer instead and grab the env pointer locally in the function.
Removes a core code usage of ENV_GET_CPU().
Reviewed-by: Andreas Färber
Signed-off-by: Pe
Hi All,
I'm moving towards the goal of having no core code usages of ENV_GET_CPU.
This has two advantages:
1: It means we are closer to common-obj'ing core code like exec.c, cpus.c
and friends.
2: Multi arch is easier if ENV_GET_CPU() stays arch specific. It means I
don't need those patches where
All of the core-code usages of this API have the cpu pointer handy so
pass it in. There are only 3 architecture specific usages (2 of which
are commented out) which can just use ENV_GET_CPU() locally to get the
cpu pointer. The reduces core code usage of the CPU env, which brings
us closer to commo
Paolo Bonzini writes:
> On 18/06/2015 17:24, Radim Krčmář wrote:
>> W10 insider has a bug where it ignores CPUID level and interprets
>> CPUID.(EAX=07H, ECX=0H) incorrectly, because CPUID in fact returned
>> CPUID.(EAX=04H, ECX=0H); this resulted in execution of unsupported
>> instructions.
>>
The callers (most of them in target-foo/cpu.c) to this function all
have the cpu pointer handy. Just pass it to avoid an ENV_GET_CPU() from
core code (in exec.c).
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Peter Maydell
Cc: "Edgar E. Iglesias"
Cc: "Andreas Färber"
Cc: Eduardo Habkost
Cc: Mi
On 2015-06-18 17:54, Christian Borntraeger wrote:
> commit fa92e218df1d ("s390x/ipl: avoid sign extension") introduced
> a regression:
>
> qemu-system-s390x -drive file=/home/cborntra/image.zhyp409,format=qcow2
> does not boot, the bios states
> "No virtio-blk device found!"
>
> adding bootindex=
From: Bharata B Rao
Currently CPUState.cpu_index is monotonically increasing and a newly
created CPU always gets the next higher index. The next available
index is calculated by counting the existing number of CPUs. This is
fine as long as we only add CPUs, but there are architectures which
are s
On Thu, Jun 18, 2015 at 01:12:32PM -0400, Bandan Das wrote:
> Eduardo Habkost writes:
>
> > On Thu, Jun 18, 2015 at 05:24:24PM +0200, Radim Krčmář wrote:
> >> We already bump to level 7 if features there are requested, so do the
> >> same for 0xD.
>
> But doesn't bumping to 7 for feat[ebx] have
2015-06-18 19:15 keltezéssel, Laszlo Ersek írta:
On 06/18/15 18:43, Kővágó, Zoltán wrote:
The current OptsVisitor flattens the whole structure, if there are same
named fields under different paths (like `in' and `out' in `Audiodev'),
the current visitor can't cope with them (for example setting
On 2015-06-18 12:02, Paolo Bonzini wrote:
>
>
> On 18/06/2015 11:42, Aurelien Jarno wrote:
> >> > QEMU could just always compute and store the restore_state information.
> >> > TCG needs to help filling it in (a new TCG opcode?), but it should be
> >> > easy.
> > Yes, that was another approach
Add a chassis_nr property Instead of using PXB bus number
as internal bridge's chassis nr.
Suggested-by: Michael S. Tsirkin
Signed-off-by: Marcel Apfelbaum
---
docs/pci_expander_bridge.txt| 7 +++
hw/pci-bridge/pci_expander_bridge.c | 5 -
2 files changed, 7 insertions(+), 5 del
On 06/18/15 18:49, Eduardo Habkost wrote:
> commit ea96bc629cbd52be98b2967a4b4f72e91dfc3ee4 doesn't match the patch
> submitted by Laszlo to qemu-devel. We reuse pc_q35_2_4_machine_options()
> inside pc_q35_2_3_machine_options(), so we need to undo the no_floppy
> change in pc_q35_2_3_machine_optio
201 - 300 of 383 matches
Mail list logo
