Re: [Qemu-devel] [RFC PATCH v0] numa: API to lookup NUMA node by address

2015-06-11 Thread Bharata B Rao
On Thu, Jun 11, 2015 at 08:56:03AM +0200, Igor Mammedov wrote: > > > > And to make this work, it needs to be aware of NUMA information for > > > > hotplugged memory too. > > > I've checked spapr_populate_drconf_memory() from original series, > > > it needs to be aware at startup about address rang

Re: [Qemu-devel] [PATCH v3 1/2] ACPI: Add definitions for the SPCR table

2015-06-11 Thread Igor Mammedov
On Wed, 10 Jun 2015 05:52:38 -0400 Andrew Jones wrote: > SPCR is the Serial Port Console Redirection Table. See the document > linked from http://uefi.org/acpi. For serial port types, "Interface > Type", see the documentation for the Debug Port Table 2 (DBG2). > > Signed-off-by: Andrew Jones >

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-11 Thread Igor Mammedov
On Wed, 10 Jun 2015 05:52:39 -0400 Andrew Jones wrote: > Signed-off-by: Andrew Jones > Tested-by: Shannon Zhao Reviewed-by: Igor Mammedov > --- > hw/arm/virt-acpi-build.c | 43 ++- > 1 file changed, 42 insertions(+), 1 deletion(-) > > diff --git a/hw/

[Qemu-devel] [PATCH] hw/vfio/platform: replace g_malloc0_n by g_malloc0

2015-06-11 Thread Eric Auger
g_malloc0_n() is introduced since glib-2.24 while QEMU currently requires glib-2.22. This may cause a link error on some distributions. Signed-off-by: Eric Auger --- hw/vfio/platform.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c i

[Qemu-devel] qemu freeze, seabios release

2015-06-11 Thread Gerd Hoffmann
Hi, qemu soft freeze for 2.4 is just around the corner, time to think about the seabios release which should be included there. A new release from master isn't even planned yet[1], so I think we should go for a 1.8.2 stable release. So, if there are any fixes which should be cherry-picked into

[Qemu-devel] PING: RE: [PATCH RFC V3 1/4] Use Aff1 with mpidr This is an improved and KVM-aware alternative to

2015-06-11 Thread Pavel Fedin
Hi Peter! > Hi. I think this patch largely makes sense, but I have some comments > below. If you want to fix these and resend as a standalone patch > I'm happy to apply that. How are things going? I have resent v4 of this on the very same day, and got no reaction from you since then. My vGICv3

[Qemu-devel] [PULL 2/2] spice: ui_info tweaks

2015-06-11 Thread Gerd Hoffmann
Use the new dpy_ui_info_supported function. Clarifies the control flow. Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/ui/spice-display.c b/ui/spice-display.c index 4e6356a..cc4a6ce 100644 --- a/ui/spice-d

[Qemu-devel] [PULL 0/2] spice patch queue

2015-06-11 Thread Gerd Hoffmann
o staging (2015-06-10 18:13:58 +0100) are available in the git repository at: git://anongit.freedesktop.org/spice/qemu tags/pull-spice-20150611-1 for you to fetch changes up to 5a9259a0b5d6f9424f94539cd9c715b1d166d90c: spice: ui_info tweaks (2015-06-11 09:0

[Qemu-devel] [PULL 1/2] spice-display: fix segfault in qemu_spice_create_update

2015-06-11 Thread Gerd Hoffmann
Although it is pretty unusual the stride for the guest image and the mirror image maintained by spice-display can be different. So use separate variables for them. https://bugzilla.redhat.com/show_bug.cgi?id=1163047 Cc: qemu-sta...@nongnu.org Reported-by: perrier vincent Signed-off-by: Gerd Hof

Re: [Qemu-devel] [PATCH] hw/vfio/platform: replace g_malloc0_n by g_malloc0

2015-06-11 Thread Gonglei
On 2015/6/11 15:14, Eric Auger wrote: > g_malloc0_n() is introduced since glib-2.24 while QEMU currently > requires glib-2.22. This may cause a link error on some distributions. > > Signed-off-by: Eric Auger > --- > hw/vfio/platform.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >

Re: [Qemu-devel] [PATCH 0/4] PPC IBM 40p PReP emulation

2015-06-11 Thread Artyom Tarasenko
Hi Hervé, On Wed, Jun 10, 2015 at 11:18 PM, Hervé Poussineau wrote: > Hi, > > This patchset adds the emulation of the IBM RS/6000 7020 (40p). Well done! Congratulations on a good job! > The real machine is > able to run AIX (up to 4.3.3), Windows NT (up to 4.0 SP1), the beta of OS/2 > PowerPC,

Re: [Qemu-devel] [SeaBIOS] qemu freeze, seabios release

2015-06-11 Thread Laszlo Ersek
On 06/11/15 09:42, Gerd Hoffmann wrote: > Hi, > > qemu soft freeze for 2.4 is just around the corner, time to think about > the seabios release which should be included there. > > A new release from master isn't even planned yet[1], so I think we > should go for a 1.8.2 stable release. So, if

Re: [Qemu-devel] [PATCH] block: Change bitmap truncate conditional to assertion

2015-06-11 Thread Kevin Wolf
Am 10.06.2015 um 22:55 hat John Snow geschrieben: > On 06/10/2015 04:52 PM, Eric Blake wrote: > > On 06/10/2015 11:24 AM, John Snow wrote: > >> Requires: 1433796555-5608-1-git-send-email-js...@redhat.com > >> [PATCH] block: record new size in bdrv_dirty_bitmap_truncate > >> > > > > Shouldn't thi

Re: [Qemu-devel] [PATCH 00/33] virtio 1.0 patch series rebased

2015-06-11 Thread Gerd Hoffmann
Hi, > Here's an incomplete todo for spec compliance: note that it does not > have to block this patchset: > - complete other devices besides net, balloon > need to disable a bunch of features > that 1.0 has deprecated So, what is the plan here? For legacy devi

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] block: driver should override flags in bdrv_open()

2015-06-11 Thread Stefan Hajnoczi
On Wed, Jun 10, 2015 at 10:37:10AM +0200, Kevin Wolf wrote: > Am 09.06.2015 um 17:21 hat Eric Blake geschrieben: > > On 06/09/2015 08:48 AM, Stefan Hajnoczi wrote: > > > I guess my @redhat.com email was received directly from Max because I > > > was in CC list. It didn't pass through Mailman. I s

Re: [Qemu-devel] [PATCH v7 0/8] block: Mirror discarded sectors

2015-06-11 Thread Fam Zheng
On Mon, 06/08 14:02, Stefan Hajnoczi wrote: > On Mon, Jun 08, 2015 at 01:56:06PM +0800, Fam Zheng wrote: > > v7: Fix the lost assignment of s->unmap. > > > > v6: Fix pnum in bdrv_get_block_status_above. [Paolo] > > > > v5: Rewrite patch 1. > > Address Eric's comments on patch 3. > > Add E

Re: [Qemu-devel] [PATCH 6/8] qcow2: add autoclear bit for dirty bitmaps

2015-06-11 Thread Kevin Wolf
Am 11.06.2015 um 01:42 hat John Snow geschrieben: > > > On 06/08/2015 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: > > From: Vladimir Sementsov-Ogievskiy > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy > > --- > > block/qcow2-dirty-bitmap.c | 5 + > > block/qcow2.c | 13

[Qemu-devel] [PULL 0/1] sdl patch queue

2015-06-11 Thread Gerd Hoffmann
t: git://git.kraxel.org/qemu tags/pull-sdl-20150611-1 for you to fetch changes up to 08d49df0dbaacc220a099dbfb644e1dc0eda57be: sdl2: fix crash in handle_windowevent() when restoring the screen size (2015-06-09 10:25:21 +0200)

[Qemu-devel] [PULL 1/1] sdl2: fix crash in handle_windowevent() when restoring the screen size

2015-06-11 Thread Gerd Hoffmann
From: Alberto Garcia The Ctrl-Alt-u keyboard shortcut restores the screen to its original size. In the SDL2 UI this is done by destroying the window and creating a new one. The old window emits SDL_WINDOWEVENT_HIDDEN when it's destroyed, but trying to call SDL_GetWindowFromID() from that event's

Re: [Qemu-devel] [PATCH v2 0/2] Makefile: Generate tag files under $SRC_PATH

2015-06-11 Thread Fam Zheng
On Fri, 05/22 13:35, Fam Zheng wrote: Ping :) Fam > > > Fam Zheng (2): > Makefile: Fix "make cscope TAGS" > Makefile: Add "make ctags" > > Makefile | 20 +++- > 1 file changed, 15 insertions(+), 5 deletions(-) > > -- > 2.4.1 > >

[Qemu-devel] [PATCH v2] hw/vfio/platform: replace g_malloc0_n by g_new0

2015-06-11 Thread Eric Auger
g_malloc0_n() is introduced since glib-2.24 while QEMU currently requires glib-2.22. This may cause a link error on some distributions. Signed-off-by: Eric Auger --- v1 -> v2: - replace g_malloc0 by g_new0 --- hw/vfio/platform.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --g

Re: [Qemu-devel] [PATCH] hw/vfio/platform: replace g_malloc0_n by g_malloc0

2015-06-11 Thread Eric Auger
Hi Gonglei, On 06/11/2015 09:55 AM, Gonglei wrote: > On 2015/6/11 15:14, Eric Auger wrote: >> g_malloc0_n() is introduced since glib-2.24 while QEMU currently >> requires glib-2.22. This may cause a link error on some distributions. >> >> Signed-off-by: Eric Auger >> --- >> hw/vfio/platform.c | 3

Re: [Qemu-devel] [PULL v2 1/3] hw/vfio/platform: vfio-platform skeleton

2015-06-11 Thread Peter Maydell
On 11 June 2015 at 03:21, Gonglei wrote: > Failed to build on SUSE11.3: > That's because g_malloc0_n() introduced since glib-2.24, > but QEMU just require glib-2.22. Thanks for the catch -- I do have a glib-2.22 system in my pre-pull build tests, but it's not x86/Linux, so it won't try to compil

Re: [Qemu-devel] PING: RE: [PATCH RFC V3 1/4] Use Aff1 with mpidr This is an improved and KVM-aware alternative to

2015-06-11 Thread Peter Maydell
On 11 June 2015 at 08:46, Pavel Fedin wrote: > Hi Peter! > >> Hi. I think this patch largely makes sense, but I have some comments >> below. If you want to fix these and resend as a standalone patch >> I'm happy to apply that. > > How are things going? I have resent v4 of this on the very same d

Re: [Qemu-devel] [PATCH v3 0/3] Support more than 8 MMU modes, speedup PPC by 10%

2015-06-11 Thread Artyom Tarasenko
Hi Paolo, On Tue, May 5, 2015 at 9:18 AM, Paolo Bonzini wrote: > Patches 1 and 2 enable support from more than 8 MMU modes in TCG (patch > 1 is in the targets, patch 2 is in cpu-defs.h). The TLB size is reduced > proportionally on targets where that is necessary. This is a very promising approa

Re: [Qemu-devel] [PATCH v3 4/6] hw/core: rebase sysbus_get_fw_dev_path() to g_strdup_printf()

2015-06-11 Thread Marcel Apfelbaum
On 06/11/2015 03:38 AM, Laszlo Ersek wrote: Cc: Markus Armbruster Cc: Marcel Apfelbaum Cc: Michael S. Tsirkin Signed-off-by: Laszlo Ersek --- Notes: v3: - new in v3 hw/core/sysbus.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/hw/core/sy

Re: [Qemu-devel] [PATCH v3 5/6] hw/core: explicit OFW unit address property for SysBusDevice

2015-06-11 Thread Marcel Apfelbaum
On 06/11/2015 03:38 AM, Laszlo Ersek wrote: The sysbus_get_fw_dev_path() function formats OpenFirmware device path nodes ("driver-name@unit-address") for sysbus devices. The first choice for "unit-address" is the base address of the device's first MMIO region. The second choice is its first IO po

Re: [Qemu-devel] [PATCH v3 6/6] hw/pci-bridge: set explicit OFW unit address for TYPE_PXB_HOST

2015-06-11 Thread Marcel Apfelbaum
On 06/11/2015 03:38 AM, Laszlo Ersek wrote: The PXB implementation doesn't allow firmware (SeaBIOS or OVMF) to boot off devices behind the PXB. This happens because the sysbus_get_fw_dev_path() function in "hw/core/sysbus.c" doesn't have enough information to format a unique identifier for the PX

[Qemu-devel] virt-test broken by 'gtk: add opengl support, using egl' 97edf3bd5

2015-06-11 Thread Dr. David Alan Gilbert
Hi, I've just bisected a virt-test breakage down to: 97edf3bd5 'gtk: add opengl support, using egl' I think the problem is that it's trying to start X up early on, even in the cases when qemu would just print some help and exit. I'm running virt-test on a remote machine via ssh and don't have

Re: [Qemu-devel] [PATCH v3 6/6] hw/pci-bridge: set explicit OFW unit address for TYPE_PXB_HOST

2015-06-11 Thread Laszlo Ersek
On 06/11/15 11:15, Marcel Apfelbaum wrote: > On 06/11/2015 03:38 AM, Laszlo Ersek wrote: >> The PXB implementation doesn't allow firmware (SeaBIOS or OVMF) to boot >> off devices behind the PXB. This happens because the >> sysbus_get_fw_dev_path() function in "hw/core/sysbus.c" doesn't have >> enou

[Qemu-devel] [PULL 1/1] gtk: don't exit early in case gtk init fails

2015-06-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrange --- ui/gtk.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/ui/gtk.c b/ui/gtk.c index 126326a..df2a79e 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1917,12 +1917,19 @@ static void gd_set_keycode_type(GtkD

[Qemu-devel] [PULL 0/1] gtk patch queue

2015-06-11 Thread Gerd Hoffmann
in the git repository at: git://git.kraxel.org/qemu tags/pull-gtk-20150611-1 for you to fetch changes up to 060ab76356fff6a420bc881a574c40a5dda086af: gtk: don't exit early in case gtk init fails (2015-06-11 11:37:56 +0200) gtk: d

Re: [Qemu-devel] [PATCH v2] RFC: qxl: allow to specify head limit to qxl driver

2015-06-11 Thread Gerd Hoffmann
On Do, 2015-06-11 at 10:38 +0100, Frediano Ziglio wrote: > libvirt has this as a video card parameter (actually set to 1 but not > used). This parameter will allow to limit setting a use can do (which > could be confusing). Hmm. So heads is '1' by default but ignored today. When this starts to b

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-11 Thread Vladimir Sementsov-Ogievskiy
On 10.06.2015 16:00, Eric Blake wrote: On 06/10/2015 02:19 AM, Vladimir Sementsov-Ogievskiy wrote: +Dirty bitmaps is an optional header extension. It provides a possibility of +storing dirty bitmaps in qcow2 image. The fields are: + + 0 - 3: nb_dirty_bitmaps + Numbe

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-11 Thread Vladimir Sementsov-Ogievskiy
On 10.06.2015 16:24, Stefan Hajnoczi wrote: On Wed, Jun 10, 2015 at 11:19:30AM +0300, Vladimir Sementsov-Ogievskiy wrote: On 09.06.2015 20:03, Stefan Hajnoczi wrote: On Mon, Jun 08, 2015 at 06:21:19PM +0300, Vladimir Sementsov-Ogievskiy wrote: @@ -166,6 +167,19 @@ the header extension data. Ea

Re: [Qemu-devel] [PATCH v3 6/6] hw/pci-bridge: set explicit OFW unit address for TYPE_PXB_HOST

2015-06-11 Thread Marcel Apfelbaum
On 06/11/2015 03:38 AM, Laszlo Ersek wrote: The PXB implementation doesn't allow firmware (SeaBIOS or OVMF) to boot off devices behind the PXB. This happens because the sysbus_get_fw_dev_path() function in "hw/core/sysbus.c" doesn't have enough information to format a unique identifier for the PX

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-11 Thread Vladimir Sementsov-Ogievskiy
On 10.06.2015 18:34, Kevin Wolf wrote: Am 08.06.2015 um 17:21 hat Vladimir Sementsov-Ogievskiy geschrieben: From: Vladimir Sementsov-Ogievskiy Persistent dirty bitmaps will be saved into qcow2 files. It may be used as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for other dri

Re: [Qemu-devel] [PATCH v3 6/6] hw/pci-bridge: set explicit OFW unit address for TYPE_PXB_HOST

2015-06-11 Thread Laszlo Ersek
On 06/11/15 12:21, Marcel Apfelbaum wrote: > On 06/11/2015 03:38 AM, Laszlo Ersek wrote: >> The PXB implementation doesn't allow firmware (SeaBIOS or OVMF) to boot >> off devices behind the PXB. This happens because the >> sysbus_get_fw_dev_path() function in "hw/core/sysbus.c" doesn't have >> enou

Re: [Qemu-devel] virt-test broken by 'gtk: add opengl support, using egl' 97edf3bd5

2015-06-11 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > Hi, > I've just bisected a virt-test breakage down to: This is fixed by the just posted 'gtk: don't exit early in case gtk init fails' Dave > > 97edf3bd5 'gtk: add opengl support, using egl' > > I think the problem is that it's trying t

Re: [Qemu-devel] [PATCH v3 6/6] hw/pci-bridge: set explicit OFW unit address for TYPE_PXB_HOST

2015-06-11 Thread Marcel Apfelbaum
On 06/11/2015 01:26 PM, Laszlo Ersek wrote: On 06/11/15 12:21, Marcel Apfelbaum wrote: On 06/11/2015 03:38 AM, Laszlo Ersek wrote: The PXB implementation doesn't allow firmware (SeaBIOS or OVMF) to boot off devices behind the PXB. This happens because the sysbus_get_fw_dev_path() function in "h

Re: [Qemu-devel] [PATCH 00/33] virtio 1.0 patch series rebased

2015-06-11 Thread Michael S. Tsirkin
On Thu, Jun 11, 2015 at 10:26:12AM +0200, Gerd Hoffmann wrote: > Hi, > > > Here's an incomplete todo for spec compliance: note that it does not > > have to block this patchset: > > - complete other devices besides net, balloon > > need to disable a bunch of features > >

Re: [Qemu-devel] [PATCH v3 2/2] vhost user: Add RARP injection for legacy guest

2015-06-11 Thread Michael S. Tsirkin
On Thu, Jun 11, 2015 at 01:54:22PM +0800, Jason Wang wrote: > > > On 06/11/2015 01:49 PM, Thibaut Collet wrote: > > > Yes, but still need a mechanism to notify the backend of migration > > > completion from qemu side if GUEST_ANNOUNCE is not negotiated. > > > > backend is aware of a connection wi

Re: [Qemu-devel] [PATCH 4/8] block: add bdrv_load_dirty_bitmap

2015-06-11 Thread Vladimir Sementsov-Ogievskiy
On 11.06.2015 01:33, John Snow wrote: On 06/09/2015 12:01 PM, Stefan Hajnoczi wrote: On Mon, Jun 08, 2015 at 06:21:22PM +0300, Vladimir Sementsov-Ogievskiy wrote: +BdrvDirtyBitmap *bdrv_load_dirty_bitmap(BlockDriverState *bs, +BlockDriverState *file, +

Re: [Qemu-devel] [PATCH v3 6/6] hw/pci-bridge: set explicit OFW unit address for TYPE_PXB_HOST

2015-06-11 Thread Laszlo Ersek
On 06/11/15 12:29, Marcel Apfelbaum wrote: > On 06/11/2015 01:26 PM, Laszlo Ersek wrote: >> On 06/11/15 12:21, Marcel Apfelbaum wrote: >>> On 06/11/2015 03:38 AM, Laszlo Ersek wrote: The PXB implementation doesn't allow firmware (SeaBIOS or OVMF) to boot off devices behind the PXB. This h

Re: [Qemu-devel] [PATCH 6/8] qcow2: add autoclear bit for dirty bitmaps

2015-06-11 Thread Vladimir Sementsov-Ogievskiy
On 11.06.2015 02:42, John Snow wrote: On 06/08/2015 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-dirty-bitmap.c | 5 + block/qcow2.c | 13 +++-- block/qcow2.h

[Qemu-devel] [PATCH] target-arm/cpu.h: remove pending_exception

2015-06-11 Thread Alex Bennée
This isn't used by any of the code. In fact it looks like it was never used as it came in with ARMv7 support. Signed-off-by: Alex Bennée --- target-arm/cpu.h | 1 - 1 file changed, 1 deletion(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 21b5b8e..7c1d95c 100644 --- a/target-arm/cpu.

Re: [Qemu-devel] [PATCH v3 6/6] hw/pci-bridge: set explicit OFW unit address for TYPE_PXB_HOST

2015-06-11 Thread Marcel Apfelbaum
On 06/11/2015 01:45 PM, Laszlo Ersek wrote: On 06/11/15 12:29, Marcel Apfelbaum wrote: On 06/11/2015 01:26 PM, Laszlo Ersek wrote: On 06/11/15 12:21, Marcel Apfelbaum wrote: On 06/11/2015 03:38 AM, Laszlo Ersek wrote: The PXB implementation doesn't allow firmware (SeaBIOS or OVMF) to boot off

[Qemu-devel] [PATCH v7 2/6] spapr_pci: encode class code including Prog IF register

2015-06-11 Thread Nikunj A Dadhania
Current code missed the Prog IF register. All Class Code, Subclass, and Prog IF registers are needed to identify the accurate device type. For example: USB controllers use the PROG IF for denoting: USB FullSpeed, HighSpeed or SuperSpeed. Signed-off-by: Nikunj A Dadhania Reviewed-by: Thomas Huth

[Qemu-devel] [PATCH v7 0/6] spapr_pci: DT field fixes and PCI DT node creation in QEMU

2015-06-11 Thread Nikunj A Dadhania
The patch series creates PCI device tree(DT) nodes in QEMU. The new hotplug code needs the device node creation in QEMU. While during boot, nodes were created in SLOF. It makes more sense to consolidate the code to one place for better maintainability. Based on David's spapr-next https://github.c

Re: [Qemu-devel] [PATCH] hw/vfio/platform: replace g_malloc0_n by g_malloc0

2015-06-11 Thread Markus Armbruster
Eric Auger writes: > g_malloc0_n() is introduced since glib-2.24 while QEMU currently > requires glib-2.22. This may cause a link error on some distributions. > > Signed-off-by: Eric Auger > --- > hw/vfio/platform.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/v

Re: [Qemu-devel] [PULL 0/1] gtk patch queue

2015-06-11 Thread Peter Maydell
axel/tags/pull-vga-20150610-1' into > staging (2015-06-10 18:13:58 +0100) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-gtk-20150611-1 > > for you to fetch changes up to 060ab76356fff6a420bc881a574c40a5dda086af: > > g

[Qemu-devel] [PATCH v7 6/6] spapr_pci: drop redundant args in spapr_populate_pci_child_dt

2015-06-11 Thread Nikunj A Dadhania
* phb_index is not being used and if required can be obtained from sphb * use helper to get drc_index in this function Suggested-by: Alexey Kardashevskiy Signed-off-by: Nikunj A Dadhania --- hw/ppc/spapr_pci.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/p

[Qemu-devel] [PATCH v7 5/6] spapr_pci: populate ibm,loc-code

2015-06-11 Thread Nikunj A Dadhania
Each hardware instance has a platform unique location code. The OF device tree that describes a part of a hardware entity must include the “ibm,loc-code” property with a value that represents the location code for that hardware entity. Populate ibm,loc-code. 1) PCI passthru devices need to ident

[Qemu-devel] [PATCH v7 1/6] spapr_pci: encode missing 64-bit memory address space

2015-06-11 Thread Nikunj A Dadhania
The properties reg/assigned-resources need to encode 64-bit memory address space as part of phys.hi dword. 00 if configuration space 01 if IO region, 10 if 32-bit MEM region 11 if 64-bit MEM region Signed-off-by: Nikunj A Dadhania Reviewed-by: Thomas Huth --- hw/ppc/spapr_pci.c | 10 ++

[Qemu-devel] [PATCH v7 3/6] spapr_pci: enumerate and add PCI device tree

2015-06-11 Thread Nikunj A Dadhania
All the PCI enumeration and device node creation was off-loaded to SLOF. With PCI hotplug support, code needed to be added to add device node. This creates multiple copy of the code one in SLOF and other in hotplug code. To unify this, the patch adds the pci device node creation in Qemu. For backwa

Re: [Qemu-devel] [PATCH v2 RFC 0/8] block: persistent dirty bitmaps

2015-06-11 Thread Vladimir Sementsov-Ogievskiy
On 10.06.2015 18:27, Stefan Hajnoczi wrote: On Mon, Jun 08, 2015 at 06:21:18PM +0300, Vladimir Sementsov-Ogievskiy wrote: QCow2 header is extended by fields 'nb_dirty_bitmaps' and 'dirty_bitmaps_offset' like with snapshots. Proposed command line syntax is the following: -dirty-bitmap [option1=

[Qemu-devel] [PATCH v7 4/6] spapr_pci: set device node unit address as hex

2015-06-11 Thread Nikunj A Dadhania
Device node names should encode the unit address as hex, while the code was encodind it as integers. Also, use FDT_NAME_MAX macro for allocating and composing the name. Signed-off-by: Nikunj A Dadhania Reviewed-by: Thomas Huth --- hw/ppc/spapr_pci.c | 12 +++- 1 file changed, 7 inserti

Re: [Qemu-devel] [PATCH v2] net:Enable vhost with vhostforce, vhost options for guests without MSI-X support

2015-06-11 Thread Pankaj Gupta
> > On 06/05/2015 10:32 PM, Pankaj Gupta wrote: > > We use vhostforce to enable vhost even if Guests don't have MSI-X > > support > > and we fall back to QEMU virtio-net. This patch will enable vhost > > unconditionally > > whenever we have vhostforce='ON' or vhost='ON'. > > > > Initially

[Qemu-devel] [PULL 10/42] vhost_net: add version_1 feature

2015-06-11 Thread Michael S. Tsirkin
Add VERSION_1 to list of features that we should test at the backend. Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- hw/net/vhost_net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c index 426b23e..dc48ece 100644 --- a/hw/net

[Qemu-devel] [PULL 05/42] virtio: disallow late feature changes for virtio-1

2015-06-11 Thread Michael S. Tsirkin
From: Cornelia Huck For virtio-1 devices, the driver must not attempt to set feature bits after it set FEATURES_OK in the device status. Simply reject it in that case. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirki

[Qemu-devel] [PULL 12/42] linux-headers: add virtio_pci

2015-06-11 Thread Michael S. Tsirkin
Easier than duplicating code. Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- linux-headers/linux/virtio_pci.h | 192 +++ hw/virtio/virtio-pci.c | 2 + 2 files changed, 194 insertions(+) create mode 100644 linux-headers/linu

[Qemu-devel] [PULL 08/42] virtio-net: support longer header

2015-06-11 Thread Michael S. Tsirkin
From: Cornelia Huck virtio-1 devices always use num_buffers in the header, even if mergeable rx buffers have not been negotiated. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- hw/net/virtio-net.c | 21 +

[Qemu-devel] [PULL 09/42] virtio-net: enable virtio 1.0

2015-06-11 Thread Michael S. Tsirkin
From: Cornelia Huck virtio-net (non-vhost) now should have everything in place to support virtio 1.0: let's enable the feature bit for it. Note that VIRTIO_F_VERSION_1 is technically a transport feature; once every device is ready for virtio 1.0, we can move setting this feature bit out of the i

[Qemu-devel] [PULL 04/42] dataplane: allow virtio-1 devices

2015-06-11 Thread Michael S. Tsirkin
From: Cornelia Huck Handle endianness conversion for virtio-1 virtqueues correctly. Note that dataplane now needs to be built per-target. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- hw/virtio/dataplane/v

[Qemu-devel] [PULL 14/42] virtio: generation counter support

2015-06-11 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- include/hw/virtio/virtio.h | 1 + hw/virtio/virtio-pci.c | 2 +- hw/virtio/virtio.c | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h index

[Qemu-devel] [PULL 15/42] virtio: add modern config accessors

2015-06-11 Thread Michael S. Tsirkin
virtio 1.0 defines config space as LE, as opposed to pre-1.0 which was native endian. Add API for transports to execute word/dword accesses in little endian format - will be useful for mmio and pci (byte access is also wrapped, for completeness). For simplicity, we still keep config in host nativ

[Qemu-devel] [PULL 02/42] virtio: endianness checks for virtio 1.0 devices

2015-06-11 Thread Michael S. Tsirkin
From: Cornelia Huck Add code that checks for the VERSION_1 feature bit in order to make decisions about the device's endianness. This allows us to support transitional devices. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael

[Qemu-devel] [PULL 13/42] virtio-pci: initial virtio 1.0 support

2015-06-11 Thread Michael S. Tsirkin
This is somewhat functional. With this, and linux driver from my tree, I was able to use virtio net as virtio 1.0 device for light browsing. At the moment, dataplane and vhost code is still missing. Based on Cornelia's virtio 1.0 patchset: Date: Thu, 11 Dec 2014 14:25:02 +0100 From: Corn

[Qemu-devel] [PULL 06/42] virtio: allow to fail setting status

2015-06-11 Thread Michael S. Tsirkin
From: Cornelia Huck virtio-1 allow setting of the FEATURES_OK status bit to fail if the negotiated feature bits are inconsistent: let's fail virtio_set_status() in that case and update virtio-ccw to post an error to the guest. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed

[Qemu-devel] [PULL 27/42] virtio-pci: move virtio_pci_add_mem_cap call to virtio_pci_modern_region_map

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann Also fill offset and length automatically, from VirtIOPCIRegion->offset and region size. Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 28 ++-- 1 file changed, 10 inserti

[Qemu-devel] [PULL 17/42] virtio-pci: add flags to enable/disable legacy/modern

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann Add VIRTIO_PCI_FLAG_DISABLE_LEGACY and VIRTIO_PCI_FLAG_DISABLE_MODERN for VirtIOPCIProxy->flags. Also add properties for them. They can be used to disable modern (virtio 1.0) or legacy (virtio 0.9) modes. By default only legacy is advertized, modern will be turned on by def

[Qemu-devel] [PULL 07/42] virtio-net: no writeable mac for virtio-1

2015-06-11 Thread Michael S. Tsirkin
From: Cornelia Huck Devices operating as virtio 1.0 may not allow writes to the mac address in config space. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- hw/net/virtio-net.c | 1 + 1 file changed, 1 insert

[Qemu-devel] [PULL 16/42] virtio-pci: switch to modern accessors for 1.0

2015-06-11 Thread Michael S. Tsirkin
virtio 1.0 config space is in LE format for all devices, use modern wrappers when accessed through the 1.0 BAR. Reported-by: Rusty Russell Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletion

[Qemu-devel] [PULL 28/42] virtio-pci: move cap type to VirtIOPCIRegion

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.h | 1 + hw/virtio/virtio-pci.c | 9 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/virtio/virtio-pci.h b/hw/virtio/virtio-p

[Qemu-devel] [PULL 18/42] virtio-pci: make QEMU_VIRTIO_PCI_QUEUE_MEM_MULT smaller

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index

[Qemu-devel] [PULL 11/42] vhost: 64 bit features

2015-06-11 Thread Michael S. Tsirkin
From: Cornelia Huck Make sure that all vhost interfaces use 64 bit features, as the virtio core does, and make sure to use ULL everywhere possible to be on the safe side. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsi

[Qemu-devel] [PULL 29/42] virtio-pci: drop identical virtio_pci_cap

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann Now the three struct virtio_pci_caps are identical, lets drop two of them ;) Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-)

[Qemu-devel] [PULL 22/42] virtio_balloon: header update

2015-06-11 Thread Michael S. Tsirkin
add modern header Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- include/hw/virtio/virtio-balloon.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/hw/virtio/virtio-balloon.h b/include/hw/virtio/virtio-balloon.h index 4ab8f54..346a9fd 100644 --- a/inclu

[Qemu-devel] [PULL 03/42] virtio: allow virtio-1 queue layout

2015-06-11 Thread Michael S. Tsirkin
From: Cornelia Huck For virtio-1 devices, we allow a more complex queue layout that doesn't require descriptor table and rings on a physically-contigous memory area: add virtio_queue_set_rings() to allow transports to set this up. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Si

[Qemu-devel] [PULL 31/42] pci: add PCI_CLASS_INPUT_*

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pci_ids.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/hw/pci/pci_ids.h b/include/hw/pci/pci_ids.h index c6de710..49c062b 100644 --- a/in

[Qemu-devel] [PULL 33/42] virtio-input: emulated devices [pci]

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann This patch adds virtio-pci support for the emulated virtio-input devices. Using them is as simple as adding "-device virtio-tablet-pci" to your command line. If you want add multiple devices but don't want waste a pci slot for each you can compose a multifunction device this

[Qemu-devel] [PULL 35/42] virtio-net.h: Remove unsed DEFINE_VIRTIO_NET_PROPERTIES

2015-06-11 Thread Michael S. Tsirkin
From: Shannon Zhao Remove unsed DEFINE_VIRTIO_NET_PROPERTIES in virtio-net.h and delete a space typo. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Paolo Bonzini Acked-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw

[Qemu-devel] [PULL 24/42] virtio-pci: add struct VirtIOPCIRegion for virtio-1 regions

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann For now just place the MemoryRegion there, following patches will add more. Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.h | 12 hw/virtio/virtio-pci.c | 20 +++- 2 fil

[Qemu-devel] [PULL 23/42] virtio-balloon: switch to virtio_add_feature

2015-06-11 Thread Michael S. Tsirkin
From: Cornelia Huck This was missed during the conversion of feature bit manipulation. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- hw/virtio/virtio-balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[Qemu-devel] [PULL 25/42] virtio-pci: add virtio_pci_modern_regions_init()

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann Add init function for the modern pci regions, move over the init code. Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 117 + 1 file changed, 59 ins

[Qemu-devel] [PULL 36/42] virtio-scsi: move qdev properties into virtio-scsi.c

2015-06-11 Thread Michael S. Tsirkin
From: Shannon Zhao As only one place in virtio-scsi.c uses DEFINE_VIRTIO_SCSI_PROPERTIES and DEFINE_VIRTIO_SCSI_FEATURES, there is no need to expose them. Inline them into virtio-scsi.c to avoid wrongly use. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Paolo Bonzini Ac

[Qemu-devel] [PULL 41/42] i386/acpi-build: more traditional _UID and _HID for PXB root buses

2015-06-11 Thread Michael S. Tsirkin
From: Laszlo Ersek The ACPI specification permits the _HID and _UID objects to evaluate to strings. (See "6.1.5 _HID (Hardware ID)" and "6.1.12 _UID (Unique ID)" in the ACPI v6.0 spec.) With regard to related standards, the UEFI specification can also express a device address composed from strin

[Qemu-devel] [PULL 40/42] vhost-scsi: move qdev properties into vhost-scsi.c

2015-06-11 Thread Michael S. Tsirkin
From: Shannon Zhao As only one place in vhost-scsi.c uses DEFINE_VHOST_SCSI_PROPERTIES, there is no need to expose it. Inline it into vhost-scsi.c to avoid wrongly use. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Paolo Bonzini Acked-by: Cornelia Huck Reviewed-by: Mic

[Qemu-devel] [PULL 30/42] virtio-pci: fill VirtIOPCIRegions early.

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann Initialize the modern bar and the VirtIOPCIRegion fields early, in realize. Also add a size field to VirtIOPCIRegion and variables for pci bars to VirtIOPCIProxy. This allows virtio-pci subclasses to change things before the device_plugged callback applies them. virtio-vga

[Qemu-devel] [PULL 32/42] virtio-input: core code & base class [pci]

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann This patch adds the virtio-pci support bits for virtio-input-device. Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.h | 14 ++ hw/virtio/virtio-pci.c | 36

Re: [Qemu-devel] [PATCH v3 2/2] vhost user: Add RARP injection for legacy guest

2015-06-11 Thread Thibaut Collet
I am not sure to understand your remark: > It needs to be sent when backend is activated by guest kick > (in case of virtio 1, it's possible to use DRIVER_OK for this). > This does not happen when VM still runs on source. Could you confirm rarp can be sent by backend when the VHOST_USER_SET_VRING

[Qemu-devel] [PULL 34/42] virtio-net: move qdev properties into virtio-net.c

2015-06-11 Thread Michael S. Tsirkin
From: Shannon Zhao As only one place in virtio-net.c uses DEFINE_VIRTIO_NET_FEATURES, there is no need to expose it. Inline it into virtio-net.c to avoid wrongly use. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off

[Qemu-devel] [PULL 38/42] virtio-serial-bus: move qdev properties into virtio-serial-bus.c

2015-06-11 Thread Michael S. Tsirkin
From: Shannon Zhao As only one place in virtio-serial-bus.c uses DEFINE_VIRTIO_SERIAL_PROPERTIES, there is no need to expose it. Inline it into virtio-serial-bus.c to avoid wrongly use. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Paolo Bonzini Acked-by: Cornelia Huck

[Qemu-devel] [PULL 21/42] virtio-pci: correctly set host notifiers for modern bar

2015-06-11 Thread Michael S. Tsirkin
From: Jason Wang Currently, during host notifier set. We only add eventfd for legacy bar, this is not correct since: - Non-transitional device does not have legacy bar, so qemu will crash since proxy->bar was not initialized. - Modern device uses modern bar and notify cap to notify the device,

[Qemu-devel] [PULL 00/42] pc, acpi, virtio

2015-06-11 Thread Michael S. Tsirkin
The following changes since commit 309750fad51f17d1ec6195c5d8ad7d741596ddb6: vhost: logs sharing (2015-06-04 12:44:49 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to 4ebc736e9938a7e88ecc785734

Re: [Qemu-devel] [PATCH v3 2/2] vhost user: Add RARP injection for legacy guest

2015-06-11 Thread Michael S. Tsirkin
On Thu, Jun 11, 2015 at 02:10:48PM +0200, Thibaut Collet wrote: > I am not sure to understand your remark: > > > It needs to be sent when backend is activated by guest kick > > (in case of virtio 1, it's possible to use DRIVER_OK for this). > > This does not happen when VM still runs on source. >

[Qemu-devel] [PULL 37/42] virtio-rng: move qdev properties into virtio-rng.c

2015-06-11 Thread Michael S. Tsirkin
From: Shannon Zhao As only one place in virtio-rng.c uses DEFINE_VIRTIO_RNG_PROPERTIES, there is no need to expose it. Inline it into virtio-rng.c to avoid wrongly use. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Paolo Bonzini Acked-by: Cornelia Huck Reviewed-by: Mic

[Qemu-devel] [PULL 39/42] virtio-9p-device: move qdev properties into virtio-9p-device.c

2015-06-11 Thread Michael S. Tsirkin
From: Shannon Zhao As only one place in virtio-9p-device.c uses DEFINE_VIRTIO_9P_PROPERTIES, there is no need to expose it. Inline it into virtio-9p-device.c to avoid wrongly use. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Paolo Bonzini Acked-by: Cornelia Huck Revie

[Qemu-devel] [PULL 01/42] vhost: put log correctly in vhost_dev_start()

2015-06-11 Thread Michael S. Tsirkin
From: Jason Wang We allocate an dummy log even if the size is zero. So we should put it unconditionally too. Signed-off-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[Qemu-devel] [PULL 42/42] i386/acpi-build: fix PXB workarounds for unsupported BIOSes

2015-06-11 Thread Michael S. Tsirkin
From: Laszlo Ersek The patch apci: fix PXB behaviour if used with unsupported BIOS uses the following condition to see if a "PXB mem/IO chunk" has *not* been configured by the BIOS: (!range_base || range_base > range_limit) When this condition evaluates to true, said patch *omits* the cor

  1   2   3   >