Re: [Qemu-devel] [PATCH 8/8] arm: xlnx-zynqmp: Add DisplayPort and DPDMA.

2015-05-18 Thread Frederic Konrad
Hi Peter, Thanks for your review. On 14/05/2015 05:30, Peter Crosthwaite wrote: On Wed, May 13, 2015 at 12:12 PM, wrote: From: KONRAD Frederic This adds the DP and the DPDMA to the Zynq MP. Signed-off-by: KONRAD Frederic --- hw/arm/xlnx-zynqmp.c | 23 +++ i

Re: [Qemu-devel] [PATCH v6 06/47] Provide runtime Target page information

2015-05-18 Thread Amit Shah
On (Tue) 14 Apr 2015 [18:03:32], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The migration code generally is built target-independent, however > there are a few places where knowing the target page size would > avoid artificially moving stuff into arch_init. > > Prov

Re: [Qemu-devel] [PATCH] macio: Convert to realize()

2015-05-18 Thread Thomas Huth
On Sat, 16 May 2015 14:42:35 +0200 Alexander Graf wrote: > > > On 15.05.15 15:43, Markus Armbruster wrote: > > Alexander Graf writes: > > > >> On 17.03.15 08:46, Markus Armbruster wrote: > >>> Alexander Graf writes: > >>> > On 09.03.15 19:30, Markus Armbruster wrote: > > Alexander G

Re: [Qemu-devel] [PATCH 3/8] console: add qemu_alloc_display_format.

2015-05-18 Thread Gerd Hoffmann
On Mi, 2015-05-13 at 21:12 +0200, fred.kon...@greensocs.com wrote: > From: KONRAD Frederic > > This allows to create a surface with a different format than xrgb. What is the use case for this? cheers, Gerd

Re: [Qemu-devel] [PATCH v6 09/47] Add wrapper for setting blocking status on a QEMUFile

2015-05-18 Thread Amit Shah
On (Tue) 14 Apr 2015 [18:03:35], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add a wrapper to change the blocking status on a QEMUFile > rather than having to use qemu_set_block(qemu_get_fd(f)); > it seems best to avoid exposing the fd since not all QEMUFile's > reall

Re: [Qemu-devel] [PATCH v2 09/13] piix: Move pc-0.14 qxl compat properties to PC_COMPAT_0_14

2015-05-18 Thread Gerd Hoffmann
On Do, 2015-05-14 at 15:53 -0300, Eduardo Habkost wrote: > So, move the properties to PC_COMPAT_0_14. This makes pc-0.13 and > older > inherit them, but that shouldn't be an issue as QEMU 0.13 didn't > support > qxl. Reviewed-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH v6 10/47] Rename save_live_complete to save_live_complete_precopy

2015-05-18 Thread Amit Shah
On (Tue) 14 Apr 2015 [18:03:36], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > In postcopy we're going to need to perform the complete phase > for postcopiable devices at a different point, start out by > renaming all of the 'complete's to make the difference obvious. >

Re: [Qemu-devel] [PATCH v2 10/13] piix: Move pc-0.11 drive version compat props to PC_COMPAT_0_11

2015-05-18 Thread Gerd Hoffmann
On Do, 2015-05-14 at 15:53 -0300, Eduardo Habkost wrote: > The current code setting ide-drive.ver and scsi-disk.ver on pc-0.11 > breaks the PC_COMPAT_* nesting pattern we currently use. > > As those variables are overwritten in pc-0.10 too, they can be inherited > by pc-0.10 with no side-effects a

Re: [Qemu-devel] [PATCH v2 11/13] piix: Move pc-0.13 virtio-9p-pci compat to PC_COMPAT_0_13

2015-05-18 Thread Gerd Hoffmann
On Do, 2015-05-14 at 15:53 -0300, Eduardo Habkost wrote: > The compat property was added by commit > 9dbcca5aa13cb9ab40788ac4c56bc227d94ca920, and the pc-0.12 and older > machine-types were not changed because virtio-9p-pci was introduced on > QEMU > 0.13 (commit 9f10751365b26b13b8a9b67e0e90536ae3d

Re: [Qemu-devel] [PATCH v2 12/13] piix: Move pc-0.1[23] rombar compat props to PC_COMPAT_0_13

2015-05-18 Thread Gerd Hoffmann
On Do, 2015-05-14 at 15:53 -0300, Eduardo Habkost wrote: > The VGA and vmware-svga rombar compat properties were added by commit > 281a26b15b4adcecb8604216738975abd754bea8, but only to pc-0.13 and > pc-0.12. This breaks the PC_COMPAT_* nesting pattern we currently > follow. > > The new variables w

[Qemu-devel] [PATCH] configure: Check for libfdt version 1.4.0

2015-05-18 Thread Thomas Huth
Some recent patches require functions from libfdt version 1.4.0, so we should check for this version during the configure step already. Unfortunately, there does not seem to be a proper #define for the version number in the libfdt headers. So alternatively, we check for the availability of the fdtX

Re: [Qemu-devel] [PATCH 3/8] console: add qemu_alloc_display_format.

2015-05-18 Thread Frederic Konrad
On 18/05/2015 09:34, Gerd Hoffmann wrote: On Mi, 2015-05-13 at 21:12 +0200, fred.kon...@greensocs.com wrote: From: KONRAD Frederic This allows to create a surface with a different format than xrgb. What is the use case for this? cheers, Gerd Hi, The Display Port introduced in pat

Re: [Qemu-devel] [PATCH v6 06/22] hw/arm/virt-acpi-build: Generation of DSDT table for virt devices

2015-05-18 Thread Alex Bennée
Shannon Zhao writes: > From: Shannon Zhao > > DSDT consists of the usual common table header plus a definition > block in AML encoding which describes all devices in the platform. > > After initializing DSDT with header information the namespace is > created which is followed by the device enco

Re: [Qemu-devel] VCPU Hot-Unplug Feature

2015-05-18 Thread Eduardo Otubo
On Mon, May 04, 2015 at 09=34=21PM +0300, Fahri Cihan Demirci wrote: > Hello Alexandre, > > Thank you for your response. I came upon that patch on the Libvirt mailing > list, too. However, the following comment makes me think that it's not likely > to be merged: > > https://www.redhat.com/archi

Re: [Qemu-devel] [PATCH 6/8] Introduce xilinx dpdma.

2015-05-18 Thread Peter Crosthwaite
On Wed, May 13, 2015 at 12:12 PM, wrote: > From: KONRAD Frederic > > This is the implementation of the DPDMA. > > Signed-off-by: KONRAD Frederic > --- > hw/dma/Makefile.objs |1 + > hw/dma/xilinx_dpdma.c | 1149 > + > hw/dma/xilinx_dpdma.h

Re: [Qemu-devel] [PATCH v4 0/27] write/create for Parallels images with reasonable performance

2015-05-18 Thread Denis V. Lunev
On 28/04/15 10:46, Denis V. Lunev wrote: This patchset provides an ability to create of/write to Parallels images and some testing of the new code. Readings and writings are optimized out and I expect the same or slightly better performance as qcow2. Changes from v4: - parallels format driver ma

Re: [Qemu-devel] [RFC v5 1/2] util: add memmem replacement function

2015-05-18 Thread Claudio Fontana
Hello Eric, On 15 May 2015 at 18:01, Eric Blake wrote: > On 05/15/2015 09:13 AM, Claudio Fontana wrote: > >>> Or back to the original question - why are we worrying about the O(n) >>> memmem implementation when the naive O(n^2) is MUCH shorter and easier >>> to understand, and where the scaling p

Re: [Qemu-devel] [PATCH 6/8] Introduce xilinx dpdma.

2015-05-18 Thread Frederic Konrad
On 18/05/2015 10:17, Peter Crosthwaite wrote: On Wed, May 13, 2015 at 12:12 PM, wrote: From: KONRAD Frederic This is the implementation of the DPDMA. Signed-off-by: KONRAD Frederic --- hw/dma/Makefile.objs |1 + hw/dma/xilinx_dpdma.c | 1149 +

Re: [Qemu-devel] [PATCH] macio: Convert to realize()

2015-05-18 Thread Peter Maydell
On 18 May 2015 at 08:11, Thomas Huth wrote: > On Sat, 16 May 2015 14:42:35 +0200 > Alexander Graf wrote: >> Some of the patches in David's latest spapr queue are regressing >> compilation on older libfdt versions right now. If I don't see patches >> to fix this, I'll just remove them from my queu

Re: [Qemu-devel] [RFC PATCH v4 09/28] COLO: Save VM state to slave when do checkpoint

2015-05-18 Thread zhanghailiang
On 2015/5/15 20:09, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: We should save PVM's RAM/device to slave when needed. For VM state, we will cache them in slave, we use QEMUSizedBuffer to store the data, we need know the data size of VM state, so in mas

Re: [Qemu-devel] [PATCH 1/9] migration: create savevm_state

2015-05-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > This way, we will put savevm global state here, instead of lots of variables. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > savevm.c | 53 + > 1 file changed, 29 i

Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-18 Thread Kevin Wolf
Am 14.05.2015 um 19:54 hat John Snow geschrieben: > On 05/14/2015 10:07 AM, Michael S. Tsirkin wrote: > > On Thu, May 14, 2015 at 02:02:04PM +0200, Markus Armbruster wrote: > >> * Create the FDC only if the option is "on". > >> > >> * Optional: make -drive if=floppy,... auto-enable it > > > > Ever

Re: [Qemu-devel] [PATCH] macio: Convert to realize()

2015-05-18 Thread Thomas Huth
On Mon, 18 May 2015 09:59:02 +0100 Peter Maydell wrote: > On 18 May 2015 at 08:11, Thomas Huth wrote: > > On Sat, 16 May 2015 14:42:35 +0200 > > Alexander Graf wrote: > >> Some of the patches in David's latest spapr queue are regressing > >> compilation on older libfdt versions right now. If I

Re: [Qemu-devel] [PATCH v15 00/10] KVM platform device passthrough

2015-05-18 Thread Eric Auger
Hi Baptiste, all, Thanks Baptiste for your reply. Is there anything left blocking this series and fellow Machvirt Dynamic Sysbus instantiation? Hope there is no cyclic dependency between both? Thanks in advance Best Regards Eric On 05/11/2015 02:37 PM, Baptiste Reynal wrote: > Hi Eric, > >

Re: [Qemu-devel] [PATCH 2/9] migration: Use normal VMStateDescriptions for Subsections

2015-05-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We create optional sections with this patch. But we already have > optional subsections. Instead of having two mechanism that do the > same, we can just generalize it. > > For subsections we just change: > > - Add a needed function to VMStateDescri

[Qemu-devel] where is the definition of cpu_ldub_code() for Softmmu mode?

2015-05-18 Thread Jun Koi
Hi, I am trying to find the definition of cpu_ldub_code() in Softmmu mode. However, the only thing I can find is like this in include/exec/cpu_ldst.h: #define cpu_ldub_code(env1, p) ldub_raw(p) Unfortunately, this is only for Usermode (CONFIG_USER_ONLY), so still I have no idea where cpu_ldu

Re: [Qemu-devel] [PATCH 4/9] runstate: create runstate_index function

2015-05-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Given a string state, we need a way to get the RunState for that string. > > Signed-off-by: Juan Quintela > --- > include/sysemu/sysemu.h | 1 + > vl.c| 13 + > 2 files changed, 14 insertions(+) > > diff --git a/inc

Re: [Qemu-devel] [PATCH v7 2/3] block: Fix NULL deference for unaligned write if qiov is NULL

2015-05-18 Thread Stefan Hajnoczi
On Wed, May 13, 2015 at 01:12:00PM +, Fam Zheng wrote: > For zero write, callers pass in NULL qiov (qemu-io "write -z" or > scsi-disk "write same"). > > Commit fc3959e466 fixed bdrv_co_write_zeroes which is the common case > for this bug, but it still exists in bdrv_aio_write_zeroes. A simpler

Re: [Qemu-devel] [PATCH v7 0/3] block: Fix unaligned bdrv_aio_write_zeroes

2015-05-18 Thread Stefan Hajnoczi
On Wed, May 13, 2015 at 01:11:58PM +, Fam Zheng wrote: > v7: Add Kevin's rev-by in patch 1 and 3. > Address Stefan's and Kevin's comments on patch 2: > - Don't duplicate tracked_request_begin and tracked_request_end; > - Don't forget to remove debug printf; > - Call qemu_vfree u

Re: [Qemu-devel] [PATCH 0/1] ahci: do not remap clb/fis unconditionally

2015-05-18 Thread Stefan Hajnoczi
On Tue, May 12, 2015 at 06:36:12PM -0400, John Snow wrote: > This continues the IOMMU fix from 2.3, where we should not attempt > to remap the CLB or FIS RX buffers if the AHCI device is currently > running. > > The same applies to migration: keep our mitts off these registers > unless the device

Re: [Qemu-devel] [PATCH v7 0/3] block: Fix unaligned bdrv_aio_write_zeroes

2015-05-18 Thread Stefan Hajnoczi
On Wed, May 13, 2015 at 01:11:58PM +, Fam Zheng wrote: > v7: Add Kevin's rev-by in patch 1 and 3. > Address Stefan's and Kevin's comments on patch 2: > - Don't duplicate tracked_request_begin and tracked_request_end; > - Don't forget to remove debug printf; > - Call qemu_vfree u

Re: [Qemu-devel] where is the definition of cpu_ldub_code() for Softmmu mode?

2015-05-18 Thread Peter Maydell
On 18 May 2015 at 10:55, Jun Koi wrote: > Hi, > > I am trying to find the definition of cpu_ldub_code() in Softmmu mode. > However, the only thing I can find is like this in include/exec/cpu_ldst.h: > > #define cpu_ldub_code(env1, p) ldub_raw(p) Your QEMU tree is out of date -- this macro was

[Qemu-devel] Single-run script to build multi-platform QEMU distribution packages, using Docker

2015-05-18 Thread Liviu Ionescu
For those interested in creating setup/install packages for QEMU, I just updated the GNU ARM Eclipse QEMU build procedures to use Docker containers. The current build-qemu.sh procedure includes a single run script, running on OS X and creating 5 files: gnuarmeclipse-qemu-debian32-2.3.50

Re: [Qemu-devel] [PATCH 6/9] migration: create new section to store global state

2015-05-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > This includes a new section that for now just stores the current qemu state. > > Right now, there are only one way to control what is the state of the > target after migration. > > - If you run the target qemu with -S, it would start stopped. > - If

Re: [Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add aml_interrupt() term

2015-05-18 Thread Michael S. Tsirkin
On Mon, May 18, 2015 at 12:05:49PM +0800, Shannon Zhao wrote: > On 2015/5/15 20:14, Igor Mammedov wrote: > > On Thu, 7 May 2015 16:51:31 +0100 > > Peter Maydell wrote: > > > >> > On 7 May 2015 at 10:29, Shannon Zhao wrote: > >>> > > From: Shannon Zhao > >>> > > > >>> > > Add aml_interrupt() for

Re: [Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add aml_interrupt() term

2015-05-18 Thread Michael S. Tsirkin
On Mon, May 18, 2015 at 12:00:09PM +0800, Shannon Zhao wrote: > On 2015/5/15 20:45, Igor Mammedov wrote: > > On Thu, 7 May 2015 17:29:07 +0800 > > Shannon Zhao wrote: > > > >> From: Shannon Zhao > >> > >> Add aml_interrupt() for describing device interrupt in resource template. > >> These can be

Re: [Qemu-devel] [PATCH 3/9] runstate: Add runstate store

2015-05-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > This allows us to store the current state to send it through migration. > > Signed-off-by: Juan Quintela > --- > include/sysemu/sysemu.h | 1 + > vl.c| 11 +++ > 2 files changed, 12 insertions(+) > > diff --git a/includ

Re: [Qemu-devel] [PATCH 3/9] runstate: Add runstate store

2015-05-18 Thread Denis V. Lunev
On 14/05/15 19:28, Juan Quintela wrote: This allows us to store the current state to send it through migration. Signed-off-by: Juan Quintela --- include/sysemu/sysemu.h | 1 + vl.c| 11 +++ 2 files changed, 12 insertions(+) diff --git a/include/sysemu/sysemu.h

[Qemu-devel] [PATCH 1/2] dtc: Update dtc / libfdt submodule to version 1.4.0

2015-05-18 Thread Thomas Huth
Since some recent patches require libfdt version 1.4.0, let's update the dtc submodule to this version. Signed-off-by: Thomas Huth --- dtc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dtc b/dtc index bc895d6..65cc4d2 16 --- a/dtc +++ b/dtc @@ -1 +1 @@ -Subproject commi

[Qemu-devel] [PATCH v2 0/2] ppc: Require libfdt 1.4.0 as minimum version

2015-05-18 Thread Thomas Huth
The patch "spapr_drc: initial implementation of sPAPRDRConnector device" requires the function fdt_get_property_by_offset() from libfdt, which is only properly exported there since version 1.4.0. So let's make sure that we require at least version 1.4.0 of libfdt nowadays. Thomas Huth (2): dtc:

[Qemu-devel] [PATCH 2/2] configure: Check for libfdt version 1.4.0

2015-05-18 Thread Thomas Huth
Some recent patches require a function from libfdt version 1.4.0, so we should check for this version during the configure step already. Unfortunately, there does not seem to be a proper #define for the version number in the libfdt headers. So alternatively, we check for the availability of the req

[Qemu-devel] [Bug 1308341] Re: Multiple CPUs causes blue screen on Windows guest (14.04 regression)

2015-05-18 Thread Peter Mráz
*** This bug is a duplicate of bug 1346917 *** https://bugs.launchpad.net/bugs/1346917 I have same problem after crash not help restarting virtual pc on next boot bsod with c5 code persist. I must force off machine and pover on. -- You received this bug notification because you are a member

Re: [Qemu-devel] [PATCH 7/9] global_state: Make section optional

2015-05-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > This section would be sent: > > a- for all new machine types > b- for old achine types if section state is different form {running,paused} >that were the only giving us troubles. > > So, in new qemus: it is alwasy there. In old qemus: they are o

Re: [Qemu-devel] [PATCH 3/8] console: add qemu_alloc_display_format.

2015-05-18 Thread Gerd Hoffmann
On Mo, 2015-05-18 at 09:51 +0200, Frederic Konrad wrote: > On 18/05/2015 09:34, Gerd Hoffmann wrote: > > On Mi, 2015-05-13 at 21:12 +0200, fred.kon...@greensocs.com wrote: > >> From: KONRAD Frederic > >> > >> This allows to create a surface with a different format than xrgb. > > What is the us

[Qemu-devel] [RFC v6 2/2] monitor: add memory search commands s, sp

2015-05-18 Thread hw . claudio
From: Claudio Fontana usage is similar to the commands x, xp. Example with string: looking for "ELF" header in memory: (qemu) s/100cb 0x40001000 "ELF" searching memory area [40001000-400f5240] 40090001 (qemu) x/20b 0x4009 4009: '\x7f' 'E' 'L' 'F' '\x0

[Qemu-devel] [RFC v6 1/2] util: add memmem replacement function

2015-05-18 Thread hw . claudio
From: Claudio Fontana if the memmem function is missing, provide a trivial replacement. Signed-off-by: Claudio Fontana --- configure| 15 + include/qemu/osdep.h | 4 util/Makefile.objs | 1 + util/memmem.c| 62 +++

[Qemu-devel] [RFC v6 0/2] monitor: add memory search commands s, sp

2015-05-18 Thread hw . claudio
From: Claudio Fontana This is the latest iteration of the memory search patch, including a trivial replacement for the memmem function for systems which don't provide one (notably Windows). It detects the presence of memmem in configure and sets CONFIG_MEMMEM, providing a trivial implementation

Re: [Qemu-devel] [PATCH 8/9] vmstate: Create optional sections

2015-05-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > To make sections optional, we need to do it at the beggining of the code. I didn't quite understand your description; but I think the reasoning here is that to make a top level section optional, you need to do it in the top level to avoid sending the

Re: [Qemu-devel] [Xen-devel] [PATCH][RFC] libxl: use new qemu parameters for emulated qemuu disks

2015-05-18 Thread George Dunlap
On Fri, May 15, 2015 at 12:54 PM, Fabio Fantoni wrote: > NOTES: > This patch is a only a fast draft for testing. > > Some tests result: > At xl create cdrom empty or not are both working, xl cd-insert is > working, xl cd-eject seems working but on xl command in linux hvm domU > return qmp error o

Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector

2015-05-18 Thread Cornelia Huck
On Fri, 15 May 2015 09:13:46 +0200 "Michael S. Tsirkin" wrote: > On Fri, May 15, 2015 at 09:08:07AM +0200, Christian Borntraeger wrote: > > Am 14.05.2015 um 19:00 schrieb Dr. David Alan Gilbert: > > > * Christian Borntraeger (borntrae...@de.ibm.com) wrote: > > >> Am 14.05.2015 um 11:36 schrieb Mi

Re: [Qemu-devel] [PATCH 9/9] migration: Add configuration section

2015-05-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > It needs to be the first one and it is not optional, that is the reason > why it is opencoded. For new machine types, it is required than machine > type name is the same in both sides. > > It is just done right now for pc's. > > Signed-off-by: Juan

Re: [Qemu-devel] [PATCH 3/8] console: add qemu_alloc_display_format.

2015-05-18 Thread Frederic Konrad
On 18/05/2015 13:17, Gerd Hoffmann wrote: On Mo, 2015-05-18 at 09:51 +0200, Frederic Konrad wrote: On 18/05/2015 09:34, Gerd Hoffmann wrote: On Mi, 2015-05-13 at 21:12 +0200, fred.kon...@greensocs.com wrote: From: KONRAD Frederic This allows to create a surface with a different format than x

Re: [Qemu-devel] [PULL v2 00/26] qapi: Fix qapi mangling of downstream names, and more

2015-05-18 Thread Peter Maydell
On 15 May 2015 at 17:49, Markus Armbruster wrote: > The following changes since commit 1eeace9c237a729d11c7acd7c0338ab4562af637: > > Merge remote-tracking branch 'remotes/agraf/tags/signed-s390-for-upstream' > into staging (2015-05-13 16:06:07 +0100) > > are available in the git repository at:

Re: [Qemu-devel] [RFC PATCH v4 09/28] COLO: Save VM state to slave when do checkpoint

2015-05-18 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > On 2015/5/15 20:09, Dr. David Alan Gilbert wrote: > >* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > >>We should save PVM's RAM/device to slave when needed. > >> > >>For VM state, we will cache them in slave, we use QEMUSizedBuffe

Re: [Qemu-devel] [RFC PATCH v4 09/28] COLO: Save VM state to slave when do checkpoint

2015-05-18 Thread zhanghailiang
On 2015/5/18 20:10, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: On 2015/5/15 20:09, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: We should save PVM's RAM/device to slave when needed. For VM state, we will cach

Re: [Qemu-devel] [Qemu-block] [PATCH v3 03/10] block: rename BlkTransactionState and BdrvActionOps

2015-05-18 Thread Stefan Hajnoczi
On Wed, Apr 22, 2015 at 08:04:46PM -0400, John Snow wrote: > These structures are misnomers, somewhat. > > (1) BlockTransactionState is not state for a transaction, > but is rather state for a single transaction action. > Rename it "BlkActionState" to be more accurate. > > (2) The BdrvAct

Re: [Qemu-devel] [Qemu-block] [PATCH v4 03/11] block: rename BlkTransactionState and BdrvActionOps

2015-05-18 Thread Stefan Hajnoczi
On Mon, May 11, 2015 at 07:04:18PM -0400, John Snow wrote: > These structures are misnomers, somewhat. > > (1) BlockTransactionState is not state for a transaction, > but is rather state for a single transaction action. > Rename it "BlkActionState" to be more accurate. > > (2) The BdrvAct

Re: [Qemu-devel] [Qemu-block] [PATCH v4 04/11] block: re-add BlkTransactionState

2015-05-18 Thread Stefan Hajnoczi
On Mon, May 11, 2015 at 07:04:19PM -0400, John Snow wrote: > + * @jobs: A reference count that tracks how many jobs still need to complete. > + * @actions: A list of all Actions in the Transaction. > + */ > +typedef struct BlkTransactionState { > +int jobs; ... > +static BlkTransactionState *ne

[Qemu-devel] [PATCH v3] bios-tables-test: handle false-positive smbios signature matches

2015-05-18 Thread Gabriel L. Somlo
It has been reported that sometimes the .rodata section of SeaBIOS, containing the constant string against which the SMBIOS signature ends up being compared, also falls within the guest f-segment. In that case, the test obviously fails, unless we continue searching for the *real* SMBIOS entry point

Re: [Qemu-devel] [PATCH] keyboard: handle ps2 typing buffer overrun

2015-05-18 Thread Eric Blake
On 05/17/2015 10:00 AM, penghao...@sina.com wrote: > Subject: [PATCH] keyboard: handle ps2 typing buffer overrun This line is redundant. Also, you have tried to send this patch more than once. Please be sure to include a proper 'v3' or 'v4' in the subject line, as appropriate. > Starting a linu

Re: [Qemu-devel] [PATCH] keyboard: handle ps2 typing buffer overrun

2015-05-18 Thread Eric Blake
On 05/18/2015 06:54 AM, Eric Blake wrote: > On 05/17/2015 10:00 AM, penghao...@sina.com wrote: >> Subject: [PATCH] keyboard: handle ps2 typing buffer overrun > > This line is redundant. > > Also, you have tried to send this patch more than once. Please be sure > to include a proper 'v3' or 'v4'

Re: [Qemu-devel] [PATCH V4 0/4] fw-cfg: cleanup and user-provided command line blobs

2015-05-18 Thread Gabriel L. Somlo
Ping? On Wed, Apr 29, 2015 at 11:21:49AM -0400, Gabriel L. Somlo wrote: > These patches are what's left over from before the pre-2.3 code freeze, > after the documentation patch was applied independently: > > 1/4: (clean-up) disallow guest-side data writes to fw_cfg > 2/4 & 3/4: (cl

Re: [Qemu-devel] [PATCH] ui: use libexpoxy

2015-05-18 Thread Alexander Graf
On 05/12/2015 03:48 PM, Gerd Hoffmann wrote: On Di, 2015-05-12 at 14:10 +0100, Peter Maydell wrote: On 12 May 2015 at 14:04, Gerd Hoffmann wrote: libepoxy does the opengl extension handling for us. It also is helpful for trouble-shooting as it prints nice error messages instead of silently fa

Re: [Qemu-devel] [PATCH v2 0/2] ppc: Require libfdt 1.4.0 as minimum version

2015-05-18 Thread Alexander Graf
On 05/18/2015 12:59 PM, Thomas Huth wrote: The patch "spapr_drc: initial implementation of sPAPRDRConnector device" requires the function fdt_get_property_by_offset() from libfdt, which is only properly exported there since version 1.4.0. So let's make sure that we require at least version 1.4.0

Re: [Qemu-devel] [Qemu-block] [PATCH v2] qemu-iotests: Make debugging python tests easier

2015-05-18 Thread Stefan Hajnoczi
On Mon, May 18, 2015 at 09:39:12AM +0800, Fam Zheng wrote: > Adding "-d" option. The output goes to "tee" so it appears in your > console. Also, raise the verbosity of unnitest runner. > > When testing a topic branch, it's possible that a bug introduced by a > code change makes the python test cas

Re: [Qemu-devel] [PATCH] target-s390x: fix CC computation for EX instruction

2015-05-18 Thread Alexander Graf
On 05/17/2015 01:28 AM, Aurelien Jarno wrote: Commit 7a6c7067f optimized CC computation by only saving cc_op before calling helpers as they either don't touch the CC or generate a new static value. This however doesn't work for the EX instruction as the helper changes or not the CC value dependin

Re: [Qemu-devel] [Bug 1455254] [NEW] Segmentation fault. __memcmp_sse4_1 () at ../sysdeps/x86_64/multiarch/memcmp-sse4.S:69

2015-05-18 Thread Stefan Hajnoczi
On Thu, May 14, 2015 at 10:18:33PM -, Manuel Baesler wrote: > Public bug reported: > > compiled qemu at commit 1eeace9c237a729d11c7acd7c0338ab4562af637 > > with ./configure --enable-debug --enable-vnc --target- > list=x86_64-softmmu > > > gdb --args ./qemu-system-x86_64 -nographic -parallel

Re: [Qemu-devel] New account on developer wiki

2015-05-18 Thread Stefan Hajnoczi
On Thu, May 14, 2015 at 02:07:44PM -0400, Eyal de Lara wrote: > I am new to qemu development, and would appreciate it very much if someone > please creates an account for me on the developer wiki. > > Thanks in advance for taking the time to address this request. Done. Please see private message

Re: [Qemu-devel] [PATCH 2/3] ui/cocoa.m: Adds device menu items to Machine menu

2015-05-18 Thread Kevin Wolf
Am 17.05.2015 um 00:21 hat Peter Maydell geschrieben: > On 11 May 2015 at 23:16, Programmingkid wrote: > > Adds all removable devices to the Machine menu as a Change and Eject menu > > item pair. > > ide-cd0 would have a "Change ide-cd0..." and "Eject ide-cd0" menu items. > > > > Signed-off-by: Jo

Re: [Qemu-devel] [PATCH 0/3] scripts/qemu-gdb: Add event tracing support

2015-05-18 Thread Stefan Hajnoczi
On Thu, May 14, 2015 at 05:43:52PM +0100, Peter Maydell wrote: > This patchset adds support for two new commands to our > gdb scripts, which allow dynamically enabling and disabling > tracing of events, like this: > > (gdb) source scripts/qemu-gdb.py > (gdb) qemu trace-enable translate_block > En

Re: [Qemu-devel] [PATCH 0/3] scripts/qemu-gdb: Add event tracing support

2015-05-18 Thread Stefan Hajnoczi
On Thu, May 14, 2015 at 05:43:52PM +0100, Peter Maydell wrote: > This patchset adds support for two new commands to our > gdb scripts, which allow dynamically enabling and disabling > tracing of events, like this: > > (gdb) source scripts/qemu-gdb.py > (gdb) qemu trace-enable translate_block > En

[Qemu-devel] [PATCH 1/3] target-s390x: fix CC computation for LOAD POSITIVE instructions

2015-05-18 Thread Aurelien Jarno
LOAD POSITIVE instructions (LPR, LPGR and LPGFR) set the following condition code: 0: Result zero; no overflow 1: -- 2: Result greater than zero; no overflow 3: Overflow The current code wrongly returns 1 instead of 2 in case of a result greater than 0. This patches fixes that. This fixes

[Qemu-devel] [PATCH 2/3] target-s390x: optimize (negative-) abs computation

2015-05-18 Thread Aurelien Jarno
Now that movcond exists, it's easy to write (negative-) absolute value using TCG code instead of an helper. Cc: Richard Henderson Cc: Alexander Graf Signed-off-by: Aurelien Jarno --- target-s390x/helper.h | 2 -- target-s390x/int_helper.c | 22 -- target-s390x/translat

[Qemu-devel] [PATCH 3/3] target-s390x: remove unused helpers

2015-05-18 Thread Aurelien Jarno
Cc: Richard Henderson Cc: Alexander Graf Signed-off-by: Aurelien Jarno --- target-s390x/helper.h | 2 -- target-s390x/int_helper.c | 20 2 files changed, 22 deletions(-) diff --git a/target-s390x/helper.h b/target-s390x/helper.h index c4ec3f1..e6f2afb 100644 --- a/tar

Re: [Qemu-devel] virtio: Question on VRING_DESC_F_WRITE flag

2015-05-18 Thread Stefan Hajnoczi
On Wed, May 13, 2015 at 07:16:13PM +, Subhashini Venkataraman wrote: > I have a question on VRING_DESC_F_WRITE flag. As per the specifications, if > this flag is set, then the corresponding buffer pointed by the descriptor is > Write only, otherwise Read Only. I am trying to understand why

Re: [Qemu-devel] [PATCH 4/8] introduce dpcd module.

2015-05-18 Thread Frederic Konrad
On 14/05/2015 06:10, Peter Crosthwaite wrote: On Wed, May 13, 2015 at 12:12 PM, wrote: From: KONRAD Frederic This introduces a DPCD modules. It wires on a aux-bus and can be accessed by driver to get lane-speed, etc. Signed-off-by: KONRAD Frederic --- hw/display/Makefile.objs | 1 + h

Re: [Qemu-devel] [PATCH 33/34] qemu-iotests: Test cache mode option inheritance

2015-05-18 Thread Kevin Wolf
Am 15.05.2015 um 21:16 hat Max Reitz geschrieben: > On 08.05.2015 19:22, Kevin Wolf wrote: > >This is doing a more complete test on setting cache modes both while > >opening an image (i.e. in a -drive command line) and in reopen > >situations. It checks that reopen can specify options for child nod

Re: [Qemu-devel] [Qemu-block] [PATCH v4 08/11] qmp: Add an implementation wrapper for qmp_drive_backup

2015-05-18 Thread Stefan Hajnoczi
On Mon, May 11, 2015 at 07:04:23PM -0400, John Snow wrote: > @@ -2900,9 +2917,16 @@ void qmp_drive_backup(const char *device, const char > *target, > } > } > > +/* If we are not supplied with callback override info, use our defaults > */ > +if (cb == NULL) { > +cb

Re: [Qemu-devel] [RFC v6 1/2] util: add memmem replacement function

2015-05-18 Thread Eric Blake
On 05/18/2015 05:22 AM, hw.clau...@gmail.com wrote: > From: Claudio Fontana > > if the memmem function is missing, provide a trivial replacement. > > Signed-off-by: Claudio Fontana > --- > configure| 15 + > include/qemu/osdep.h | 4 > util/Makefile.objs | 1 +

Re: [Qemu-devel] [PATCH] qemu-iotests: Make debugging python tests easier

2015-05-18 Thread John Snow
On 05/17/2015 09:32 PM, Fam Zheng wrote: > On Fri, 05/15 13:48, John Snow wrote: >> >> >> On 05/15/2015 01:26 AM, Fam Zheng wrote: >>> Adding "-d" option. The output goes to "tee" so it appears in your >>> console. Also, raise the verbosity of unnitest runner. >>> >>> When testing a topic branch,

Re: [Qemu-devel] [PATCH 3/9] runstate: Add runstate store

2015-05-18 Thread Eric Blake
On 05/18/2015 04:38 AM, Denis V. Lunev wrote: > On 14/05/15 19:28, Juan Quintela wrote: >> This allows us to store the current state to send it through migration. >> >> Signed-off-by: Juan Quintela >> --- >> +if (strlen(state)+1 > size) { >> +return -1; >> +} >> +strncpy(str,

Re: [Qemu-devel] [PATCH v2 0/2] block: Fix error code for bdrv_getlength when the image is too big

2015-05-18 Thread Kevin Wolf
Am 15.05.2015 um 10:36 hat Fam Zheng geschrieben: > v2: Correct detection of overflow. [Markus, Berto] > > If the image has a huge enough virtual size, > > $ qemu-img info afl9.img > qemu-img: Can't get size of device 'image': Unknown error -512 > > It's because of the multiplication overflo

Re: [Qemu-devel] [PATCH 00/23] userfaultfd v4

2015-05-18 Thread Pavel Emelyanov
On 05/14/2015 08:30 PM, Andrea Arcangeli wrote: > Hello everyone, > > This is the latest userfaultfd patchset against mm-v4.1-rc3 > 2015-05-14-10:04. > > The postcopy live migration feature on the qemu side is mostly ready > to be merged and it entirely depends on the userfaultfd syscall to be >

Re: [Qemu-devel] [PATCH 4/9] runstate: create runstate_index function

2015-05-18 Thread Eric Blake
On 05/18/2015 03:58 AM, Dr. David Alan Gilbert wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Given a string state, we need a way to get the RunState for that string. >> >> Signed-off-by: Juan Quintela >> --- >> include/sysemu/sysemu.h | 1 + >> vl.c| 13 +++

Re: [Qemu-devel] [PATCH v2] qemu-iotests: Make debugging python tests easier

2015-05-18 Thread Kevin Wolf
Am 18.05.2015 um 03:39 hat Fam Zheng geschrieben: > Adding "-d" option. The output goes to "tee" so it appears in your > console. Also, raise the verbosity of unnitest runner. > > When testing a topic branch, it's possible that a bug introduced by a > code change makes the python test case hang, w

Re: [Qemu-devel] [Qemu-block] [PATCH v3 01/10] qapi: Add transaction support to block-dirty-bitmap operations

2015-05-18 Thread Kevin Wolf
Am 11.05.2015 um 15:10 hat Stefan Hajnoczi geschrieben: > On Fri, May 08, 2015 at 08:29:09AM -0600, Eric Blake wrote: > > On 05/08/2015 07:14 AM, Stefan Hajnoczi wrote: > > > > > No it doesn't. Actions have to appear atomic to the qmp_transaction > > > caller. Both approaches achieve that so the

Re: [Qemu-devel] [Qemu-block] [PATCH v4 08/11] qmp: Add an implementation wrapper for qmp_drive_backup

2015-05-18 Thread John Snow
On 05/18/2015 10:42 AM, Stefan Hajnoczi wrote: > On Mon, May 11, 2015 at 07:04:23PM -0400, John Snow wrote: >> @@ -2900,9 +2917,16 @@ void qmp_drive_backup(const char *device, >> const char *target, } } >> >> +/* If we are not supplied with callback override info, use >> our defaults */ +

[Qemu-devel] [PATCH 1/7] kvm-all: put kvm_mem_flags to more work

2015-05-18 Thread Paolo Bonzini
From: Andrew Jones Currently kvm_mem_flags just translates bools to bits, let's make it also determine the bools first. This avoids its parameter list growing each time we add a flag. Signed-off-by: Andrew Jones Signed-off-by: Paolo Bonzini --- kvm-all.c | 25 +++-- 1 file

Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector

2015-05-18 Thread Cornelia Huck
On Mon, 18 May 2015 13:26:35 +0200 Cornelia Huck wrote: > Would the subsection approach be more acceptable if I default needed to > false and have only virtio-ccw override it in a callback? Smth like the following: From 773a753475d9c89fb8dc789005a694d07b0cfac2 Mon Sep 17 00:00:00 2001 From: Cor

[Qemu-devel] [PATCH 2/7] kvm-all: remove useless typedef

2015-05-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- kvm-all.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index b459855..bb9477c 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -69,8 +69,6 @@ typedef struct KVMSlot int flags; } KVMSlot; -typedef struct kvm_dirty_lo

[Qemu-devel] [PATCH 6/7] kvm-all: kvm_irqchip_create is not expected to fail

2015-05-18 Thread Paolo Bonzini
KVM_CREATE_IRQCHIP should never fail, and so should its userspace wrapper kvm_irqchip_create. The function does not do anything if the irqchip capability is not available, as is the case for PPC. With this patch, kvm_arch_init can allocate memory and it will not be leaked. Signed-off-by: Paolo B

[Qemu-devel] [PATCH 3/7] kvm-all: move internal types to kvm_int.h

2015-05-18 Thread Paolo Bonzini
i386 code will have to define a different KVMMemoryListener. Create an internal header so that KVMSlot is not exposed outside. Signed-off-by: Paolo Bonzini --- include/sysemu/kvm_int.h | 30 ++ kvm-all.c| 18 +- 2 files changed, 31 ins

[Qemu-devel] [PATCH 0/7] kvm-i386: QEMU support for SMRAM

2015-05-18 Thread Paolo Bonzini
These are the new patches for SMRAM support, using multiple address spaces and, thus, multiple KVMMemoryListeners. No more layering violations, yay! The meat is in patches 4 and 5, which parameterize KVM's memory listener so that: 1) each memory listener handles its own array of memory slots; 2)

[Qemu-devel] [PATCH 5/7] kvm-all: add support for multiple address spaces

2015-05-18 Thread Paolo Bonzini
Make kvm_memory_listener_register public, and assign a kernel address space id to each KVMMemoryListener. Signed-off-by: Paolo Bonzini --- include/sysemu/kvm_int.h | 4 kvm-all.c| 13 ++--- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/include/syse

Re: [Qemu-devel] [PATCH 33/34] qemu-iotests: Test cache mode option inheritance

2015-05-18 Thread Max Reitz
On 18.05.2015 16:39, Kevin Wolf wrote: Am 15.05.2015 um 21:16 hat Max Reitz geschrieben: On 08.05.2015 19:22, Kevin Wolf wrote: This is doing a more complete test on setting cache modes both while opening an image (i.e. in a -drive command line) and in reopen situations. It checks that reopen c

[Qemu-devel] [PATCH 4/7] kvm-all: make KVM's memory listener more generic

2015-05-18 Thread Paolo Bonzini
No semantic change, but s->slots and s->migration_log move into a new struct KVMMemoryListener. KVM's memory listener becomes a member of struct KVMState, and becomes of type KVMMemoryListener. Signed-off-by: Paolo Bonzini --- include/sysemu/kvm_int.h | 6 ++ kvm-all.c| 174 ++

[Qemu-devel] [PATCH 7/7] target-i386: register a separate KVM address space including SMRAM regions

2015-05-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- target-i386/kvm.c | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 09b4fc7..19ccc08 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -22,7 +22,7 @@

Re: [Qemu-devel] [PATCH] target-s390x: fix CC computation for EX instruction

2015-05-18 Thread Richard Henderson
On 05/16/2015 04:28 PM, Aurelien Jarno wrote: > Commit 7a6c7067f optimized CC computation by only saving cc_op before > calling helpers as they either don't touch the CC or generate a new > static value. This however doesn't work for the EX instruction as the > helper changes or not the CC value de

Re: [Qemu-devel] [PATCH v4 09/11] block: drive_backup transaction callback support

2015-05-18 Thread Stefan Hajnoczi
On Mon, May 11, 2015 at 07:04:24PM -0400, John Snow wrote: > +static void drive_backup_cb(BlkActionState *common) > +{ > +BlkActionCallbackData *cb_data = common->cb_data; > +BlockDriverState *bs = cb_data->opaque; > +DriveBackupState *state = DO_UPCAST(DriveBackupState, common, common)

Re: [Qemu-devel] [PATCH 1/3] target-s390x: fix CC computation for LOAD POSITIVE instructions

2015-05-18 Thread Richard Henderson
On 05/18/2015 06:39 AM, Aurelien Jarno wrote: > LOAD POSITIVE instructions (LPR, LPGR and LPGFR) set the following > condition code: > 0: Result zero; no overflow > 1: -- > 2: Result greater than zero; no overflow > 3: Overflow > > The current code wrongly returns 1 instead of 2 in case of

  1   2   3   >