On 05/17/2015 09:32 PM, Fam Zheng wrote: > On Fri, 05/15 13:48, John Snow wrote: >> >> >> On 05/15/2015 01:26 AM, Fam Zheng wrote: >>> Adding "-d" option. The output goes to "tee" so it appears in your >>> console. Also, raise the verbosity of unnitest runner. >>> >>> When testing a topic branch, it's possible that a bug introduced by a >>> code change makes the python test case hang, with debug output, it is >>> much easier to locate the problem. >>> >>> This can also be helpful if you want to watch the progress of a python >>> test, it offers you a way to sense the speed of each test case method >>> you're writing. >>> >> >> Awesome idea! >> >> Unfortunately, it explodes when I run ./check -v -d -qcow2 124: >> >> +Traceback (most recent call last): >> + File "124", line 363, in <module> >> + iotests.main(supported_fmts=['qcow2']) >> + File "/home/bos/jhuston/src/qemu/tests/qemu-iotests/iotests.py", line >> 367, in main >> + sys.stderr.write(re.sub(r'Ran (\d+) tests? in [\d.]+s', r'Ran \1 >> tests', output.getvalue())) >> +AttributeError: 'file' object has no attribute 'getvalue' >> Failures: 124 >> Failed 1 of 1 tests >> >> --js > > I guess we can skip this line if debug is True. (However, I should have noted > in the commit message, by specifying "-d", the purpose of the execution is > solely *debugging the test itself*, and because I didn't find a easy way to > get > *both* the verbose debug output and an output that would match $seq.out, this > patch always makes a "-d" execution fail.) > > Will send another version with an additional "if debug". > > Thanks, > > Fam >
Ah, I misunderstood: I thought you wanted to just increase the verbosity, and the failing test warnings gave me a bit of pause. Best not to have things that cause a python stack trace laying around on purpose. --js
