[Qemu-devel] [PATCH v7 01/23] hw/arm/virt: Move common definitions to virt.h

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao Move some common definitions to virt.h. These will be used by generating ACPI tables. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/arm/virt.c | 21 +-- include/hw/arm/virt.h | 56 +++

[Qemu-devel] [PATCH v7 02/23] hw/arm/virt: Record PCIe ranges in MemMapEntry array

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao To generate ACPI table for PCIe controller, we need the base and size of the PCIe ranges. Record these ranges in MemMapEntry array, then we could share and use them for generating ACPI table. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/arm/virt.c

[Qemu-devel] [PATCH v7 18/23] hw/acpi/aml-build: Add aml_create_dword_field() term

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée --- hw/acpi/aml-build.c | 11 +++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 12 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index d62c2b3..de

[Qemu-devel] [PATCH v7 20/23] hw/acpi/aml-build: Add Unicode macro

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/acpi/aml-build.c | 18 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 19 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 238d6a3..360023a 100644 --- a/

[Qemu-devel] [PATCH v7 00/23] Generate ACPI v5.1 tables and expose them to guest over fw_cfg on ARM

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao This patch series generate seven ACPI tables for machine virt on ARM. The set of generated tables are: - RSDP - RSDT - MADT - GTDT - FADT - DSDT - MCFG (For PCIe host bridge) These tables are created dynamically using the function of aml-build.c, taking into account the needed

[Qemu-devel] [PATCH v7 19/23] hw/acpi/aml-build: Add aml_dword_io() term

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée --- hw/acpi/aml-build.c | 18 ++ include/hw/acpi/aml-build.h | 5 + 2 files changed, 23 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index

[Qemu-devel] [Bug 1453025] Re: remote usb3.0 redir failed, when guest os has more than one vcpus

2015-05-14 Thread liaoxiaojun
** Summary changed: - remote usbredirection failed, when guest os has more than one vcpus + remote usb3.0 redir failed, when guest os has more than one vcpus -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/

Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector

2015-05-14 Thread Christian Borntraeger
Am 13.05.2015 um 23:47 schrieb Michael S. Tsirkin: > On Wed, May 13, 2015 at 08:57:00PM +0200, Christian Borntraeger wrote: >> Am 13.05.2015 um 18:14 schrieb Michael S. Tsirkin: - AFAICS, there's no easy way to add transport-specific subsections - and simply adding config_vector in ccw

[Qemu-devel] [PATCH v7 08/23] hw/arm/virt-acpi-build: Generate MADT table

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao MADT describes GIC enabled ARM platforms. The GICC and GICD subtables are used to define the GIC regions. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée --- hw/arm/virt-acpi-build.c | 57 in

[Qemu-devel] [PATCH v7 05/23] hw/acpi/aml-build: Add aml_interrupt() term

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao Add aml_interrupt() for describing device interrupt in resource template. These can be used to generating DSDT table for ACPI on ARM. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/acpi/aml-build.c | 23 + include/hw/acpi/aml-buil

[Qemu-devel] [PATCH v7 11/23] hw/arm/virt-acpi-build: Generate RSDP table

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao RSDP points to RSDT which in turn points to other tables. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée --- hw/arm/virt-acpi-build.c | 35 ++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/h

[Qemu-devel] [PATCH v7 06/23] hw/arm/virt-acpi-build: Generation of DSDT table for virt devices

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao DSDT consists of the usual common table header plus a definition block in AML encoding which describes all devices in the platform. After initializing DSDT with header information the namespace is created which is followed by the device encodings. The devices are described usi

[Qemu-devel] [PATCH v7 09/23] hw/arm/virt-acpi-build: Generate GTDT table

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao ACPI v5.1 defines GTDT for ARM devices as a place to describe timer related information in the system. The Arch Timer interrupts must be provided for GTDT. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/arm/virt-acpi-build.c| 29 +

[Qemu-devel] [PATCH v7 12/23] hw/arm/virt-acpi-build: Generate MCFG table

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao Generate MCFG table for PCIe controller. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/arm/virt-acpi-build.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 19ba69e..80d4

[Qemu-devel] [PATCH v7 22/23] ACPI: split CONFIG_ACPI into 4 pieces

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao As core.c, piix4.c, ich9.c and pcihp.c are for x86, add CONFIG_ACPI_X86 to make it only for x86. ARM doesn't support cpu and memory hotplug, add CONFIG_ACPI_CPU_HOTPLUG and CONFIG_ACPI_MEMORY_HOTPLUG to make them exclusive for target-arm. Signed-off-by: Shannon Zhao Signed-of

[Qemu-devel] [PATCH v7 07/23] hw/arm/virt-acpi-build: Generate FADT table and update ACPI headers

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao In the case of mach virt, it is used to set the Hardware Reduced bit and enable PSCI SMP booting through HVC. So ignore FACS and FADT points to DSDT. Update the header definitions for FADT taking into account the new additions of ACPI v5.1 in `include/hw/acpi/acpi-defs.h` Sig

[Qemu-devel] [PATCH v7 13/23] hw/acpi/aml-build: Make aml_buffer() definition consistent with the spec

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao According to ACPI spec, DefBuffer can take two parameters: BufferSize and ByteList. Make it consistent with the spec. If we want to request uninitialized buffer, pass ByteList as NULL to aml_buffer() to reserve spaces. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao

[Qemu-devel] [PATCH v7 10/23] hw/arm/virt-acpi-build: Generate RSDT table

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao RSDT points to other tables FADT, MADT, GTDT. This code is shared with x86. Here we still use RSDT as UEFI puts ACPI tables below 4G address space, and UEFI ignore the RSDT or XSDT. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/acpi/aml-build.c | 2

[Qemu-devel] [PATCH v7 23/23] hw/arm/virt: Enable dynamic generation of ACPI v5.1 tables

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao Initialize VirtGuestInfoState and register a machine_init_done notify to call virt_acpi_build(). Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/arm/virt.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c

[Qemu-devel] [PATCH v7 04/23] hw/acpi/aml-build: Add aml_memory32_fixed() term

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao Add aml_memory32_fixed() for describing device mmio region in resource template. These can be used to generating DSDT table for ACPI on ARM. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée --- hw/acpi/aml-build.c | 25 ++

[Qemu-devel] [PATCH v7 17/23] hw/acpi/aml-build: Add aml_else() term

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée --- hw/acpi/aml-build.c | 7 +++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 8 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 7945918..d62c2b3 1

[Qemu-devel] [PATCH v7 21/23] hw/arm/virt-acpi-build: Add PCIe controller in ACPI DSDT table

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao Add PCIe controller in ACPI DSDT table, so the guest can detect the PCIe. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/arm/virt-acpi-build.c | 155 +++ 1 file changed, 155 insertions(+) diff --git a/hw/arm/virt-

[Qemu-devel] [PATCH v7 03/23] hw/arm/virt-acpi-build: Basic framework for building ACPI tables on ARM

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao Introduce a preliminary framework in virt-acpi-build.c with the main ACPI build functions. It exposes the generated ACPI contents to guest over fw_cfg. The required ACPI v5.1 tables for ARM are: - RSDP: Initial table that points to XSDT - RSDT: Points to FADT GTDT MADT tables

Re: [Qemu-devel] [RFC PATCH v2 13/13] iohandler: Use AioContext internally

2015-05-14 Thread Paolo Bonzini
On 14/05/2015 06:35, Fam Zheng wrote: > Sorry, please skip this one for now (overlooked before sending), it's not safe > to include iohandler fds in nested aio_poll, at least until the "device IO" op > blocker patches are in. That's what I was going to ask. :) Still, good job! And for Win32 we

[Qemu-devel] [PATCH v7 14/23] hw/acpi/aml-build: Add ToUUID macro

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao Add ToUUID macro, this is useful for generating PCIe ACPI table. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/acpi/aml-build.c | 46 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 47 insertions(+)

[Qemu-devel] [PATCH v7 16/23] hw/acpi/aml-build: Add aml_lnot() term

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index e4ec938..7945918

[Qemu-devel] [PATCH v7 15/23] hw/acpi/aml-build: Add aml_or() term

2015-05-14 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 0e4d35f..e4ec938 100644 --- a/hw/acpi/

Re: [Qemu-devel] [RFC PATCH v2 00/13] main-loop: Get rid of fd_read_poll and qemu_set_fd_handler2

2015-05-14 Thread Paolo Bonzini
On 14/05/2015 06:39, Fam Zheng wrote: > On Thu, 05/14 11:34, Fam Zheng wrote: >> Patch 1 adds a stub for qemu_set_fd_handler which will be referenced in >> coming >> patches. >> >> Patch 2 converts qemu-nbd which compares two global numbers in the >> fd_read_poll >> callback. >> >> Patches 2~5 co

Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector

2015-05-14 Thread Michael S. Tsirkin
On Thu, May 14, 2015 at 11:22:13AM +0200, Christian Borntraeger wrote: > Am 13.05.2015 um 23:47 schrieb Michael S. Tsirkin: > > On Wed, May 13, 2015 at 08:57:00PM +0200, Christian Borntraeger wrote: > >> Am 13.05.2015 um 18:14 schrieb Michael S. Tsirkin: > - AFAICS, there's no easy way to add

Re: [Qemu-devel] [RFC PATCH v0] numa: API to lookup NUMA node by address

2015-05-14 Thread Paolo Bonzini
On 13/05/2015 20:06, Eduardo Habkost wrote: > Also, this introduces a circular dependency between pc-dimm.c and > numa.c. Instead of that, pc-dimm could simply notify us when a new > device is realized (with just (addr, end, node) as arguments), so we can > save the list of memory ranges inside s

Re: [Qemu-devel] [PATCH v3 2/2] target-mips: Misaligned memory accesses for MSA

2015-05-14 Thread Yongbok Kim
On 14/05/2015 10:00, Yongbok Kim wrote: > On 13/05/2015 20:28, Richard Henderson wrote: >> On 05/13/2015 08:37 AM, Yongbok Kim wrote: >>> +static inline void ensure_atomic_msa_block_access(CPUMIPSState *env, >>> + target_ulong addr, >>> +

Re: [Qemu-devel] [PATCH v1 5/7] STM32F205: Connect the ADC device

2015-05-14 Thread Alistair Francis
On Mon, Apr 27, 2015 at 5:26 AM, Peter Crosthwaite wrote: > On Sat, Apr 25, 2015 at 7:21 PM, Alistair Francis > wrote: >> On Sun, Apr 26, 2015 at 4:32 AM, Peter Crosthwaite >> wrote: >>> "devices" >>> >>> On Sat, Apr 25, 2015 at 1:18 AM, Alistair Francis >>> wrote: Connect the ADC device

Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector

2015-05-14 Thread Michael S. Tsirkin
On Thu, May 14, 2015 at 10:24:15AM +0200, Paolo Bonzini wrote: > > > On 13/05/2015 18:14, Michael S. Tsirkin wrote: > > > - AFAICS, there's no easy way to add transport-specific subsections - > > > and simply adding config_vector in ccw would break compatibility > > > > subsections break compa

Re: [Qemu-devel] [PATCH 2/2] scripts: qom-tree: add support of path as argument

2015-05-14 Thread Paolo Bonzini
On 13/05/2015 14:14, Martin Cerveny wrote: > for item in items: > if item['type'].startswith('child<'): > -list_node(path + '/' + item['name']) > +list_node((path if (path != '/') else '') + '/' + item['name']) I'm not sure which Python version introduced i

Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector

2015-05-14 Thread Paolo Bonzini
On 14/05/2015 11:36, Michael S. Tsirkin wrote: > > There are three answers: > 1. Yes, it's sure to get detected because everything gets shifted > and then you get an unexpected string instead of next device name. > 2. If you want a more generic way to detect this, then please work > on

[Qemu-devel] [PATCH] mirror: correct buf_size

2015-05-14 Thread Wen Congyang
If buf_size % granularity is not 0, mirror_free_init() will do dangerous things. Signed-off-by: Wen Congyang --- block/mirror.c | 4 1 file changed, 4 insertions(+) diff --git a/block/mirror.c b/block/mirror.c index 58f391a..bb6bc27 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -686,

Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector

2015-05-14 Thread Paolo Bonzini
On 14/05/2015 11:56, Michael S. Tsirkin wrote: > > That's expected. Subsections break compatibility because sometimes > > breaking migration is better than leaving a broken guest after migration. > > Right, and what happens is that some devices work kind of okay without > config interrupts? Chr

Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector

2015-05-14 Thread Michael S. Tsirkin
On Thu, May 14, 2015 at 12:04:05PM +0200, Paolo Bonzini wrote: > > > On 14/05/2015 11:56, Michael S. Tsirkin wrote: > > > That's expected. Subsections break compatibility because sometimes > > > breaking migration is better than leaving a broken guest after migration. > > > > Right, and what ha

[Qemu-devel] [Bug 1453436] Re: Building on OS X: Undefined symbols ___emutls_v.prng_state and ___emutls_v.prng_state_data

2015-05-14 Thread Molt
I have XQuartz 2.7.7 installed and there is no pixman in /opt/X11/bin. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1453436 Title: Building on OS X: Undefined symbols ___emutls_v.prng_state and

Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector

2015-05-14 Thread Paolo Bonzini
On 14/05/2015 12:07, Michael S. Tsirkin wrote: > > If you really want that, the hook should be in the virtio device class. > > Keying on the machine type is almost never the answer, at least upstream. > > Distros can always override it if they know what they're getting into. > > I beg to disagre

Re: [Qemu-devel] [PATCH v3 2/2] target-mips: Misaligned memory accesses for MSA

2015-05-14 Thread Leon Alrae
On 13/05/2015 20:28, Richard Henderson wrote: > As an aside, consider moving away from > > #define HELPER_LD(name, insn, type) \ > static inline type do_##name(CPUMIPSState *env, target_ulong addr, \ > int mem_idx)

Re: [Qemu-devel] [RFC/RFT PATCH v2 2/3] KVM: promote KVM_MEMSLOT_INCOHERENT to uapi

2015-05-14 Thread Paolo Bonzini
On 13/05/2015 13:31, Andrew Jones wrote: > Commit 1050dcda30529 introduced KVM_MEMSLOT_INCOHERENT to flag memory > regions that may have coherency issues due to mapping host system RAM > as non-cacheable. This was introduced as a KVM internal flag, but now > give KVM userspace access to it so tha

[Qemu-devel] [Bug 1453436] Re: Building on OS X: Undefined symbols ___emutls_v.prng_state and ___emutls_v.prng_state_data

2015-05-14 Thread Peter Maydell
It's /opt/X11/lib/libpixman-1.dylib and /opt/X11/include/pixman-1/ for me, but yes, it's possible I've got that from somewhere other than XQuartz. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1453436

Re: [Qemu-devel] [PATCH] mirror: correct buf_size

2015-05-14 Thread Paolo Bonzini
On 14/05/2015 12:07, Wen Congyang wrote: > Signed-off-by: Wen Congyang > --- > block/mirror.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/block/mirror.c b/block/mirror.c > index 58f391a..bb6bc27 100644 > --- a/block/mirror.c > +++ b/block/mirror.c > @@ -686,6 +686,10 @@ static

[Qemu-devel] [PATCH v2] mirror: correct buf_size

2015-05-14 Thread Wen Congyang
If buf_size % granularity is not 0, mirror_free_init() will do dangerous things. Signed-off-by: Wen Congyang --- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index 58f391a..9521212 100644 --- a/block/mirror.c +++ b/block/mirr

Re: [Qemu-devel] [RFC/RFT PATCH v2 0/3] KVM: Introduce KVM_MEM_UNCACHED

2015-05-14 Thread Christoffer Dall
On Wed, May 13, 2015 at 01:31:51PM +0200, Andrew Jones wrote: > Introduce a new memory region flag, KVM_MEM_UNCACHED, which is > needed by ARM. This flag informs KVM that the given memory region > is typically mapped by the guest as non-cacheable. KVM for ARM > then ensures that that memory is inde

Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector

2015-05-14 Thread Christian Borntraeger
Am 14.05.2015 um 11:36 schrieb Michael S. Tsirkin: > On Thu, May 14, 2015 at 11:22:13AM +0200, Christian Borntraeger wrote: >> Am 13.05.2015 um 23:47 schrieb Michael S. Tsirkin: >>> On Wed, May 13, 2015 at 08:57:00PM +0200, Christian Borntraeger wrote: Am 13.05.2015 um 18:14 schrieb Michael S.

Re: [Qemu-devel] [PATCH v3 1/6] mirror: Do zero write on target if sectors not allocated

2015-05-14 Thread Paolo Bonzini
On 12/05/2015 13:48, Fam Zheng wrote: > +if (!bdrv_is_allocated_above(source, NULL, sector_num, > + nb_sectors, &pnum)) { > +op->nb_sectors = pnum; > +if (s->source_may_unmap) { Can you avoid this check by introducing bdrv_get_block_status_abov

Re: [Qemu-devel] [PATCH v3 2/6] block: Fix dirty bitmap in bdrv_co_discard

2015-05-14 Thread Paolo Bonzini
On 12/05/2015 13:48, Fam Zheng wrote: > Unsetting dirty globally with discard is not very correct. The discard may > zero > out sectors (depending on can_write_zeroes_with_unmap), we should replicate > this change to destinition side to make sure that the guest sees the same > data. > > Callin

Re: [Qemu-devel] [RFC/RFT PATCH v2 0/3] KVM: Introduce KVM_MEM_UNCACHED

2015-05-14 Thread Andrew Jones
On Wed, May 13, 2015 at 01:31:51PM +0200, Andrew Jones wrote: > Introduce a new memory region flag, KVM_MEM_UNCACHED, which is > needed by ARM. This flag informs KVM that the given memory region > is typically mapped by the guest as non-cacheable. KVM for ARM > then ensures that that memory is inde

Re: [Qemu-devel] [PATCH v3 4/6] qemu-iotests: Make block job methods common

2015-05-14 Thread Paolo Bonzini
On 12/05/2015 13:48, Fam Zheng wrote: > Signed-off-by: Fam Zheng > Reviewed-by: John Snow > --- > tests/qemu-iotests/041| 66 > ++- > tests/qemu-iotests/iotests.py | 28 ++ > 2 files changed, 43 insertions(+), 51 deletions(-) >

Re: [Qemu-devel] [RFC/RFT PATCH v2 2/3] KVM: promote KVM_MEMSLOT_INCOHERENT to uapi

2015-05-14 Thread Christoffer Dall
On Wed, May 13, 2015 at 01:31:53PM +0200, Andrew Jones wrote: > Commit 1050dcda30529 introduced KVM_MEMSLOT_INCOHERENT to flag memory > regions that may have coherency issues due to mapping host system RAM > as non-cacheable. This was introduced as a KVM internal flag, but now > give KVM userspace

[Qemu-devel] [PATCH] block: get_block_status: use "else" when testing the opposite condition

2015-05-14 Thread Paolo Bonzini
A bit of Boolean algebra (and common sense) tells us that the second "if" here is looking for blocks that are not allocated. This is the opposite of the "if" that sets BDRV_BLOCK_ALLOCATED, and thus it can use an "else". Signed-off-by: Paolo Bonzini --- block/io.c | 4 +--- 1 file changed, 1 ins

Re: [Qemu-devel] [PATCH v1 4/7] STM32F2xx: Add the SPI device

2015-05-14 Thread Alistair Francis
On Sun, Apr 26, 2015 at 4:43 AM, Peter Crosthwaite wrote: > On Sat, Apr 25, 2015 at 1:18 AM, Alistair Francis > wrote: >> Add the STM32F2xx SPI device. >> >> Signed-off-by: Alistair Francis >> --- >> >> default-configs/arm-softmmu.mak | 1 + >> hw/ssi/Makefile.objs| 1 + >> hw/

<    1   2   3   4