On 14/05/2015 12:07, Michael S. Tsirkin wrote: > > If you really want that, the hook should be in the virtio device class. > > Keying on the machine type is almost never the answer, at least upstream. > > Distros can always override it if they know what they're getting into. > > I beg to disagree. Check out PC_COMPAT_ macros.
I'm talking specifically about migration subsections. None of them are keyed on the machine type downstream, as far as I know. > But if you are saying > migration with virtio-ccw is just too broken ATM, so we shouldn't care > about its migration compatibility upstream, then I can buy that. Yes, I'm also saying that (and Christian must agree or they would not have posted this patch). Paolo
