[Qemu-devel] [PATCH v4 0/2] Fix guest-fstrim behaviour

2015-05-11 Thread Justin Ossevoort
The qemu-ga 'guest-fstrim' command is currently not working properly. There are 2 issues: - The current implementation reuses a struct between ioctl() calls without reinitialising it's fields. This struct however is updated to reflect the result of the trim operation. Therefor only the first

[Qemu-devel] [PATCH v4 1/2] qga/commands-posix: Fix bug in guest-fstrim

2015-05-11 Thread Justin Ossevoort
The FITRIM ioctl updates the fstrim_range structure it receives. This way the caller can determine how many bytes were trimmed. The guest-fstrim logic reuses the same fstrim_range for each filesystem, effectively limiting each filesystem to trim at most as much as the previous was able to trim. If

[Qemu-devel] [PATCH v4 2/2] qga/qmp_guest_fstrim: Return per path fstrim result

2015-05-11 Thread Justin Ossevoort
The current guest-fstrim support only returns an error if some mountpoint was unable to be trimmed, skipping any possible additional mountpoints. The result of the TRIM operation itself is also discarded. This change returns a per mountpoint result of the TRIM operation. If an error occurs on some

Re: [Qemu-devel] [RFC PATCH 00/34] Multi Architecture System Emulation

2015-05-11 Thread Peter Maydell
On 11 May 2015 at 07:29, Peter Crosthwaite wrote: > This is target-multi, a system-mode build that can support multiple > cpu-types. Patches 1-3 are the main infrastructure. The hard part > is the per-target changes needed to get each arch into an includable > state. Interesting. This is somethin

[Qemu-devel] [PATCH 3/9] qapi: qapi-commands.py option --type is unused, drop it

2015-05-11 Thread Markus Armbruster
Anything but --type sync (which is the default) suppresses output entirely, which makes no sense. Dates back to the initial commit c17d990. Commit message says "Currently only generators for synchronous qapi/qmp functions are supported", so maybe output other than "synchronous qapi/qmp" was plann

[Qemu-devel] [PATCH 8/9] qapi: Drop pointless flush() before close()

2015-05-11 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi.py | 4 1 file changed, 4 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 1f68fa9..784212c 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -1046,9 +1046,5 @@ def close_output(fdef, fdecl):

[Qemu-devel] [PATCH 4/9] qapi: Factor parse_command_line() out of the generators

2015-05-11 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-commands.py | 34 +++--- scripts/qapi-event.py| 32 +--- scripts/qapi-types.py| 36 scripts/qapi-visit.py| 35 ---

[Qemu-devel] [PATCH 0/9] qapi: Mostly generator cleanups

2015-05-11 Thread Markus Armbruster
You've seen these patches before, in "[PATCH RFC 00/19] qapi: QMP introspection". Eric has pulled a few into "[PATCH v2 0/3] parse 'null' literal in QMP" and "[PATCH v3 00/14] Fix qapi mangling of downstream names". This series has the remaining ones, except for "[PATCH RFC 19/19] qapi: New QMP c

[Qemu-devel] [PATCH 7/9] qapi: Factor open_output(), close_output() out of generators

2015-05-11 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-commands.py | 101 +-- scripts/qapi-event.py| 85 --- scripts/qapi-types.py| 81 - scripts/qapi-

[Qemu-devel] [PATCH 5/9] qapi: Fix generators to report command line errors decently

2015-05-11 Thread Markus Armbruster
Report to stderr, prefix with the program name. Also reject extra arguments. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index d90a538..5807476 100644 ---

[Qemu-devel] [PATCH 1/9] tests: Add missing dependencies on $(qapi-py)

2015-05-11 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Makefile b/tests/Makefile index 666aee2..6d2f2e5 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -301,22 +301,22 @@ tests/test-vmstate

[Qemu-devel] [PATCH 9/9] qapi: Inline gen_command_decl_prologue(), gen_command_def_prologue()

2015-05-11 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-commands.py | 58 1 file changed, 24 insertions(+), 34 deletions(-) diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py index c3e420e..1c1d3aa 100644 --- a/scr

[Qemu-devel] [PATCH 6/9] qapi: Turn generators' mandatory option -i into an argument

2015-05-11 Thread Markus Armbruster
Mandatory option is silly, and the error handling is missing: the programs crash when -i isn't supplied. Make it an argument, and check it properly. Signed-off-by: Markus Armbruster --- Makefile | 14 +++--- docs/qapi-code-gen.txt | 10 +- scripts/qapi.py|

[Qemu-devel] [PATCH 2/9] qapi: qapi-event.py option -b does nothing, drop it

2015-05-11 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- Makefile | 2 +- scripts/qapi-event.py | 7 ++- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index f032158..bfa5dab 100644 --- a/Makefile +++ b/Makefile @@ -273,7 +273,7 @@ $(qapi-

Re: [Qemu-devel] [RFC 2/5] Add new TLB_EXCL flag

2015-05-11 Thread alvise rigo
Hi Richard, Thank you for looking at this. Some comments below. On Thu, May 7, 2015 at 7:25 PM, Richard Henderson wrote: > > On 05/06/2015 08:38 AM, Alvise Rigo wrote: > > Add a new flag for the TLB entries to force all the accesses made to a > > page to follow the slow-path. > > > > Mark the ac

Re: [Qemu-devel] [RFC 1/5] exec: Add new exclusive bitmap to ram_list

2015-05-11 Thread alvise rigo
On Thu, May 7, 2015 at 7:12 PM, Richard Henderson wrote: > On 05/06/2015 08:38 AM, Alvise Rigo wrote: >> The purpose of this new bitmap is to flag the memory pages that are in >> the middle of LL/SC operations (after a LL, before a SC). >> For all these pages, the corresponding TLB entries will be

Re: [Qemu-devel] [PATCH 1/4] block: Fix dirty bitmap in bdrv_co_discard

2015-05-11 Thread Fam Zheng
On Wed, 05/06 12:21, Paolo Bonzini wrote: > > > On 06/05/2015 11:50, Fam Zheng wrote: > > # src can_write_zeroes_with_unmap target > > can_write_zeroes_with_unmap > > > > 1 true

Re: [Qemu-devel] [RFC 3/5] softmmu: Add helpers for a new slow-path

2015-05-11 Thread alvise rigo
On Thu, May 7, 2015 at 7:56 PM, Richard Henderson wrote: > On 05/06/2015 08:38 AM, Alvise Rigo wrote: >> +#define DATA_SIZE (1 << SHIFT) >> + >> +#if DATA_SIZE == 8 >> +#define SUFFIX q >> +#define LSUFFIX q >> +#define SDATA_TYPE int64_t >> +#define DATA_TYPE uint64_t > > Duplicating all of the

Re: [Qemu-devel] [RFC 4/5] tcg-op: create new TCG qemu_ldlink and qemu_stcond instructions

2015-05-11 Thread alvise rigo
On Thu, May 7, 2015 at 7:58 PM, Richard Henderson wrote: > On 05/06/2015 08:38 AM, Alvise Rigo wrote: >> +/* An output operand to return the StoreConditional result */ >> +static void gen_stcond_i32(TCGOpcode opc, TCGv_i32 is_dirty, TCGv_i32 val, >> + TCGv addr, TCGMemOp me

Re: [Qemu-devel] [RFC PATCH 00/34] Multi Architecture System Emulation

2015-05-11 Thread Peter Crosthwaite
On Mon, May 11, 2015 at 12:13 AM, Peter Maydell wrote: > On 11 May 2015 at 07:29, Peter Crosthwaite wrote: >> This is target-multi, a system-mode build that can support multiple >> cpu-types. Patches 1-3 are the main infrastructure. The hard part >> is the per-target changes needed to get each ar

Re: [Qemu-devel] [PATCH 1/4] block: Fix dirty bitmap in bdrv_co_discard

2015-05-11 Thread Paolo Bonzini
On 11/05/2015 10:02, Fam Zheng wrote: > > /* >* ... >* >* 'pnum' is set to the number of sectors (including and immediately > following >* the specified sector) that are known to be in the same >* allocated/unallocated state. >* >* '

Re: [Qemu-devel] [PATCH v4] Makefile.target: set icon for binary file on Mac OS X

2015-05-11 Thread Paolo Bonzini
On 10/05/2015 21:58, Peter Maydell wrote: > Unless anybody objects or Paolo particularly wants to take this > through his tree I'll add this modified version to my cocoa tree. I almost never want to take something through my tree. :) Paolo

Re: [Qemu-devel] [RFC PATCH 25/34] arm: cpu: Move CPU_COMMON to front of env

2015-05-11 Thread Paolo Bonzini
On 11/05/2015 08:29, Peter Crosthwaite wrote: > To allow pointer casts to the the multi-arch CPUArchState which > contains just the CPU_COMMON components. > > Signed-off-by: Peter Crosthwaite This can cause worse performance, unfortunately, because of bigger offsets when registers are written

Re: [Qemu-devel] [PATCHv2] parallel: Allow to disable CONFIG_PARALLEL

2015-05-11 Thread Paolo Bonzini
On 11/05/2015 07:38, mreza...@redhat.com wrote: > From: Miroslav Rezanina > > Disabling CONFIG_PARALLEL cause build failure as commit 07dc788 factored > out initialization to parallel_hds_isa_init function in hw/char/parallel.c > that is not build. > > Stub file is added to be able to disabl

Re: [Qemu-devel] [PULL 0/8] s390x: various patches

2015-05-11 Thread Peter Maydell
On 8 May 2015 at 10:08, Cornelia Huck wrote: > The following changes since commit f8340b360b9bc29d48716ba8aca79df2b9544979: > > hw/ptimer: Do not artificially limit timers when using icount (2015-05-08 > 17:15:23 +1000) > > are available in the git repository at: > > git://github.com/cohuck/q

Re: [Qemu-devel] [RFC PATCH 00/34] Multi Architecture System Emulation

2015-05-11 Thread Peter Maydell
On 11 May 2015 at 09:21, Peter Crosthwaite wrote: > On Mon, May 11, 2015 at 12:13 AM, Peter Maydell > wrote: >> Do you give each CPU its own codegen buffer? (I'm thinking that some >> of this might also be more easily done once multithreadded-TCG is >> complete, since that will properly split the

Re: [Qemu-devel] clang -fsanitize=undefined warnings in the string visitors

2015-05-11 Thread Peter Maydell
Paolo: ping^2, since we're out of release freeze now? thanks -- PMM On 5 February 2015 at 17:03, Peter Maydell wrote: > Ping on this warning issue, since I guess everybody missed it > over Christmas :-) > > thanks > -- PMM > > On 23 December 2014 at 23:17, Peter Maydell wrote: >> If you do a cl

Re: [Qemu-devel] clang -fsanitize=undefined warnings in the string visitors

2015-05-11 Thread Paolo Bonzini
On 11/05/2015 10:53, Peter Maydell wrote: > Paolo: ping^2, since we're out of release freeze now? I have some patches, but this isn't really the best time for me to post them... Paolo

Re: [Qemu-devel] [RFC 0/5] Slow-path for atomic instruction translation

2015-05-11 Thread alvise rigo
Hi, On Fri, May 8, 2015 at 5:22 PM, Alex Bennée wrote: > > Alvise Rigo writes: > >> This patch series provides an infrastructure for atomic >> instruction implementation in QEMU, paving the way for TCG multi-threading. >> The adopted design does not rely on host atomic >> instructions and is int

Re: [Qemu-devel] [RFC 0/5] Slow-path for atomic instruction translation

2015-05-11 Thread alvise rigo
On Fri, May 8, 2015 at 8:29 PM, Emilio G. Cota wrote: > On Wed, May 06, 2015 at 17:38:02 +0200, Alvise Rigo wrote: >> This patch series provides an infrastructure for atomic >> instruction implementation in QEMU, paving the way for TCG multi-threading. >> The adopted design does not rely on host a

[Qemu-devel] [PATCH 0/3] virtio-balloon: use alias property

2015-05-11 Thread shannon . zhao
From: Shannon Zhao The wrappers of virtio-balloon are using object_property_add to add properties and all have their own getters/setters which are duplicate of those in virtio-balloon device. So this patchset uses object_property_add_alias for these properties as Paolo suggested. Shannon Zhao (3

[Qemu-devel] [PATCH 2/3] hw/virtio/virtio-pci: use alias property for virtio-balloon-pci

2015-05-11 Thread shannon . zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/virtio/virtio-pci.c | 40 ++-- 1 file changed, 6 insertions(+), 34 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index c7c3f72..2dae8db 100644 ---

[Qemu-devel] [PATCH 1/3] hw/virtio/virtio-balloon: move adding property to virtio_balloon_instance_init

2015-05-11 Thread shannon . zhao
From: Shannon Zhao This is prepared for using alias property in virtio-balloon-pci and virtio-balloon-ccw. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/virtio/virtio-balloon.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/hw/virt

[Qemu-devel] [PATCH 3/3] hw/s390x/virtio-ccw: use alias property for virtio-balloon-ccw

2015-05-11 Thread shannon . zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/s390x/virtio-ccw.c | 39 ++- 1 file changed, 6 insertions(+), 33 deletions(-) diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c index 430cc6f..426a097 100644 --- a/hw

Re: [Qemu-devel] [PULL 00/19] usb: qomify, bugfixes for xhci & uhci.

2015-05-11 Thread Peter Maydell
On 8 May 2015 at 12:45, Gerd Hoffmann wrote: > Hi, > > Here comes the usb patch queue with a few bugfixes > and the qomify patch series from Gonglei. > > please pull, > Gerd > > The following changes since commit 838686357b1a175e9a32569700a153b207a9e10f: > > Merge remote-tracking branch > '

Re: [Qemu-devel] [PATCH v2 1/5] block: Use bdrv_is_sg() everywhere

2015-05-11 Thread Kevin Wolf
Am 08.05.2015 um 19:47 hat Dimitris Aragiorgis geschrieben: > Instead of checking bs->sg use bdrv_is_sg() consistently throughout > the code. > > Signed-off-by: Dimitris Aragiorgis > Reviewed-by: Paolo Bonzini > --- > block.c |6 +++--- > block/iscsi.c |2 +- > block/raw-p

Re: [Qemu-devel] [PATCHv2] parallel: Allow to disable CONFIG_PARALLEL

2015-05-11 Thread Paolo Bonzini
On 11/05/2015 11:36, Miroslav Rezanina wrote: >> > This patch will make "-parallel" a nop. The right thing to do is to >> > fail startup whenever -parallel is passed and CONFIG_PARALLEL is disabled. >> > > This was original behavior before 07dc788. Intention of this patch is to > make qemu buil

Re: [Qemu-devel] [PATCH v2 2/5] Fix migration in case of scsi-generic

2015-05-11 Thread Kevin Wolf
Am 08.05.2015 um 19:47 hat Dimitris Aragiorgis geschrieben: > During migration, QEMU uses fsync()/fdatasync() on the open file > descriptor for read-write block devices to flush data just before > stopping the VM. > > However, fsync() on a scsi-generic device returns -EINVAL which > causes the mig

Re: [Qemu-devel] [PATCH 1/3] hw/virtio/virtio-balloon: move adding property to virtio_balloon_instance_init

2015-05-11 Thread Paolo Bonzini
On 11/05/2015 11:34, shannon.z...@linaro.org wrote: > From: Shannon Zhao > > This is prepared for using alias property in virtio-balloon-pci and > virtio-balloon-ccw. English note: "This prepares for..." Can be fixed by the committer. Paolo > Signed-off-by: Shannon Zhao > Signed-off-by: Sh

Re: [Qemu-devel] [PATCH 0/3] virtio-balloon: use alias property

2015-05-11 Thread Paolo Bonzini
On 11/05/2015 11:34, shannon.z...@linaro.org wrote: > From: Shannon Zhao > > The wrappers of virtio-balloon are using object_property_add to add > properties and all have their own getters/setters which are duplicate of > those in virtio-balloon device. So this patchset uses > object_property_a

Re: [Qemu-devel] [PATCH v2 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT

2015-05-11 Thread Kevin Wolf
Am 08.05.2015 um 19:47 hat Dimitris Aragiorgis geschrieben: > Building the QEMU tools fails if we #define DEBUG_BLOCK inside > block/raw-posix.c. Here instead of adding qemu-log.o in block-obj-y > so that DEBUG_BLOCK_PRINT can be used, we substitute the latter with > a simple DPRINTF(). > > Signed

Re: [Qemu-devel] [PATCH 2/2] atomic-test: Add spinlock test case

2015-05-11 Thread Andrew Jones
On Thu, May 07, 2015 at 01:31:42PM +0200, Alexander Spyridakis wrote: > Sample spinlock test case with the option to implement the spinlock > by means of GCC atomic instructions or unsafe memory operations. > Additionally, printf is wrapped around a spinlock to avoid concurrent > access to the seri

Re: [Qemu-devel] [RFC PATCH 02/34] tcg+qom: QOMify core CPU defintions

2015-05-11 Thread Andreas Färber
Am 11.05.2015 um 08:29 schrieb Peter Crosthwaite: > These definitions are defined per-target and globall linked/defined > between core code and target-foo. QOMify them. Provide weakly linked > conditional default implementations for the non-qomified global fns. > This means converted architectures

Re: [Qemu-devel] [PATCH v2 4/5] raw-posix: Use DPRINTF for DEBUG_FLOPPY

2015-05-11 Thread Kevin Wolf
Am 08.05.2015 um 19:47 hat Dimitris Aragiorgis geschrieben: > Get rid of several #ifdef DEBUG_FLOPPY and substitute them with > DPRINTF. > > Signed-off-by: Dimitris Aragiorgis Hm, this removes the option of selectively enabling debug messages. It's probably not a big probem in this case, though.

Re: [Qemu-devel] [RFC PATCH 25/34] arm: cpu: Move CPU_COMMON to front of env

2015-05-11 Thread Andreas Färber
Am 11.05.2015 um 10:36 schrieb Paolo Bonzini: > > > On 11/05/2015 08:29, Peter Crosthwaite wrote: >> To allow pointer casts to the the multi-arch CPUArchState which >> contains just the CPU_COMMON components. >> >> Signed-off-by: Peter Crosthwaite > > This can cause worse performance, unfortuna

Re: [Qemu-devel] [PATCH v2 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT

2015-05-11 Thread Paolo Bonzini
On 11/05/2015 12:16, Kevin Wolf wrote: > Am 08.05.2015 um 19:47 hat Dimitris Aragiorgis geschrieben: >> > Building the QEMU tools fails if we #define DEBUG_BLOCK inside >> > block/raw-posix.c. Here instead of adding qemu-log.o in block-obj-y >> > so that DEBUG_BLOCK_PRINT can be used, we substitu

Re: [Qemu-devel] [RFC PATCH 02/34] tcg+qom: QOMify core CPU defintions

2015-05-11 Thread Paolo Bonzini
On 11/05/2015 12:18, Andreas Färber wrote: >> > +int (*cpu_mmu_index)(CPUState *cpu); >> > +void (*cpu_get_tb_cpu_state)(CPUState *cpu, >> > + void *pc, /* target_long * */ >> > + void *cs_base, /* target_long */ >> > +

Re: [Qemu-devel] [RFC PATCH 00/34] Multi Architecture System Emulation

2015-05-11 Thread Andreas Färber
Hi, Am 11.05.2015 um 08:29 schrieb Peter Crosthwaite: > Microblaze translation needs a change pattern to allow conversion to 64-bit > TARGET_LONG. Uses of TCGv need to be removed and explicited to 32-bit. I did have a patchset doing exactly that for one of my microcontroller targets but someone (

Re: [Qemu-devel] [RFC PATCH 02/34] tcg+qom: QOMify core CPU defintions

2015-05-11 Thread Andreas Färber
Am 11.05.2015 um 12:24 schrieb Paolo Bonzini: > On 11/05/2015 12:18, Andreas Färber wrote: +int (*cpu_mmu_index)(CPUState *cpu); +void (*cpu_get_tb_cpu_state)(CPUState *cpu, + void *pc, /* target_long * */ +

Re: [Qemu-devel] [RFC PATCH 02/34] tcg+qom: QOMify core CPU defintions

2015-05-11 Thread Paolo Bonzini
On 11/05/2015 12:36, Andreas Färber wrote: > > Right. My point was that these functions are not polymorphic. Each > > call to these should know exactly which function to call. > > > > cputlb.c, cpu-exec.c and parts of translate-all.c should be the moral > > equivalent of C++ templates. I woul

Re: [Qemu-devel] [PATCH 2/2] atomic-test: Add spinlock test case

2015-05-11 Thread Alexander Spyridakis
Hi Andrew, On 11 May 2015 at 12:17, Andrew Jones wrote: > > + > > +void atomic_lock(int *lock_var) > > +{ > > +while (__sync_lock_test_and_set(lock_var, 1)); > > +} > > + > > +void atomic_unlock(int *lock_var) > > +{ > > +__sync_lock_release(lock_var); > > +} > > Do these builtins actuall

Re: [Qemu-devel] [RFC PATCH 02/34] tcg+qom: QOMify core CPU defintions

2015-05-11 Thread Peter Maydell
On 11 May 2015 at 07:29, Peter Crosthwaite wrote: > These definitions are defined per-target and globall linked/defined > between core code and target-foo. QOMify them. Provide weakly linked > conditional default implementations for the non-qomified global fns. > This means converted architectures

Re: [Qemu-devel] [RFC PATCH 00/34] Multi Architecture System Emulation

2015-05-11 Thread Andreas Färber
Am 11.05.2015 um 10:21 schrieb Peter Crosthwaite: > On Mon, May 11, 2015 at 12:13 AM, Peter Maydell > wrote: >> On 11 May 2015 at 07:29, Peter Crosthwaite >> wrote: >>> The env as handle by common code now needs to architecture-agnostic. The >>> MB and ARM envs are refactored to have CPU_COMMON

Re: [Qemu-devel] [PATCH RFC 0/2] virt bare-metal payload infrastructure with atomic test case

2015-05-11 Thread Alexander Spyridakis
Hello Paolo, On 7 May 2015 at 14:55, Paolo Bonzini wrote: >> For the example spinlock test, racing errors could not be reproduced in >> the default single-threaded TCG, even with a non-atomic lock. In KVM the >> expected behaviour of no errors with regular locks, and some errors with >> a non-ato

Re: [Qemu-devel] [PULL 00/16] Migration pull request (v2)

2015-05-11 Thread Amit Shah
On (Fri) 08 May 2015 [10:31:56], Stefan Hajnoczi wrote: > On Thu, May 07, 2015 at 11:40:50PM +0530, Amit Shah wrote: > > On (Thu) 07 May 2015 [13:45:26], Peter Maydell wrote: > > > On 7 May 2015 at 12:50, Juan Quintela wrote: > > > > > > > > > > > > Hi again > > > > > > > > For v2 > > > > > > > >

Re: [Qemu-devel] [PATCH RFC, Ping 0/3] Checkpoint-assisted migration proposal

2015-05-11 Thread Amit Shah
On (Fri) 24 Apr 2015 [13:38:54], Bohdan Trach wrote: > Ping. It's taking a while, just because there are some other patches in the queue. I'll get to this soon. Thanks for your patience. Amit

Re: [Qemu-devel] [PATCH v6 02/47] Split header writing out of qemu_savevm_state_begin

2015-05-11 Thread Amit Shah
On (Tue) 14 Apr 2015 [18:03:28], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Split qemu_savevm_state_begin to: > qemu_savevm_state_header That writes the initial file header. > qemu_savevm_state_beginThat sets up devices and does the first >

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-11 Thread Shlomo Pongratz
Hi Pavel, Thank you, I just pulled last git and git am-ed your patch on-top of my first 3 patches and got this error: /home/shlomo/qemu-new.git/qemu-64/hw/arm/virt.c: In function ‘fdt_add_gic_node’: /home/shlomo/qemu-new.git/qemu-64/hw/arm/virt.c:366:17: error: ‘KVM_DEV_TYPE_ARM_VGIC_V3’ undec

[Qemu-devel] [PATCH v2 2/2] target-mips: Misaligned memory accesses for MSA

2015-05-11 Thread Yongbok Kim
MIPS SIMD Architecture vector loads and stores require misalignment support. MSA Memory access should work as an atomic operation. Therefore, it has to check validity of all addresses for an access if it is spanning into two pages. Introduced misaligned flag to indicate MSA ld/st is ongoing, is us

[Qemu-devel] [PATCH v2 1/2] target-mips: Misaligned memory accesses for R6

2015-05-11 Thread Yongbok Kim
Release 6 requires misaligned memory access support for all ordinary memory access instructions (for example, LW/SW, LWC1/SWC1). However misaligned support is not provided for certain special memory accesses such as atomics (for example, LL/SC). Allows misaligned accesses from mips_cpu_do_unaligne

[Qemu-devel] [PATCH v2 0/2] target-mips: Add support for misaligned accesses

2015-05-11 Thread Yongbok Kim
This patch set adds support for misaligned memory accesses in MIPS architecture Release 6 and MIPS SIMD Architecture. The behaviour, semantics, and architecture specifications of misaligned memory accesses are described in: MIPS Architecture For Programmers Volume I-A: Introduction to the MIPS64 A

Re: [Qemu-devel] [PULL 0/5] gtk patch queue.

2015-05-11 Thread Peter Maydell
On 8 May 2015 at 12:48, Gerd Hoffmann wrote: > Hi, > > This brings ui_info support for gtk and some small cleanups+fixes. > > please pull, > Gerd > > The following changes since commit 874e9aeeeb74c5459639a93439a502d262847e68: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-sdl-20

Re: [Qemu-devel] [PULL 00/16] Migration pull request (v2)

2015-05-11 Thread Peter Maydell
On 11 May 2015 at 12:04, Amit Shah wrote: > I'm wondering how Peter does his builds, and if he can share his > recipes or build farms for maintainer trees (or just some -staging > tree like the kernel). https://git.linaro.org/people/peter.maydell/misc-scripts.git and notably the remake-merge-buil

[Qemu-devel] qmp block-mirror hang, lots of nfs op/s on nfs source disk

2015-05-11 Thread Alexandre DERUMIER
Hi, I'm currently playing with drive-mirror, (qemu 2.2) and I have qmp hang when drive-mirror is starting. just after qmp "drive-mirror" exec, qmp socket or hmp are not responding. After some times it's working again, and I can see result of query-block-jobs. The source volume is on nfs (v4),

Re: [Qemu-devel] [PULL 00/16] Migration pull request (v2)

2015-05-11 Thread Alex Bennée
Stefan Hajnoczi writes: > On Thu, May 07, 2015 at 11:40:50PM +0530, Amit Shah wrote: >> On (Thu) 07 May 2015 [13:45:26], Peter Maydell wrote: >> > On 7 May 2015 at 12:50, Juan Quintela wrote: >> > > >> > > >> > > Hi again >> > > >> > > For v2 >> > > >> > > - fix 32bit compilation (as said, comp

Re: [Qemu-devel] qmp block-mirror hang, lots of nfs op/s on nfs source disk

2015-05-11 Thread Paolo Bonzini
On 11/05/2015 13:38, Alexandre DERUMIER wrote: > Hi, > > I'm currently playing with drive-mirror, (qemu 2.2) > > and I have qmp hang when drive-mirror is starting. > > just after qmp "drive-mirror" exec, qmp socket or hmp are not > responding. > > After some times it's working again, and I ca

Re: [Qemu-devel] [PATCHv2] parallel: Allow to disable CONFIG_PARALLEL

2015-05-11 Thread Miroslav Rezanina
On Mon, May 11, 2015 at 08:46:19AM +0200, Markus Armbruster wrote: > mreza...@redhat.com writes: > > > From: Miroslav Rezanina > > > > Disabling CONFIG_PARALLEL cause build failure as commit 07dc788 factored > > out initialization to parallel_hds_isa_init function in hw/char/parallel.c > > that

Re: [Qemu-devel] [PATCHv2] parallel: Allow to disable CONFIG_PARALLEL

2015-05-11 Thread Miroslav Rezanina
On Mon, May 11, 2015 at 10:40:04AM +0200, Paolo Bonzini wrote: > > > On 11/05/2015 07:38, mreza...@redhat.com wrote: > > From: Miroslav Rezanina > > > > Disabling CONFIG_PARALLEL cause build failure as commit 07dc788 factored > > out initialization to parallel_hds_isa_init function in hw/char/p

Re: [Qemu-devel] [v8 13/14] migration: Add qmp commands to set and query parameters

2015-05-11 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > Add the qmp commands to tune and query the parameters used in live > migration. Hi, Do you know if there's anyone working on libvirt code to drive this interface and turn on your compression code? Dave > > Signed-off-by: Liang Li > Signed-off-by: Ya

Re: [Qemu-devel] [PATCH 0/3] virtio-balloon: use alias property

2015-05-11 Thread Cornelia Huck
On Mon, 11 May 2015 17:34:04 +0800 shannon.z...@linaro.org wrote: > From: Shannon Zhao > > The wrappers of virtio-balloon are using object_property_add to add > properties and all have their own getters/setters which are duplicate of > those in virtio-balloon device. So this patchset uses > obje

Re: [Qemu-devel] qmp block-mirror hang, lots of nfs op/s on nfs source disk

2015-05-11 Thread Alexandre DERUMIER
>>That is because drive-mirror checks the whole disk for allocated areas. Oh, ok, that's why I'm seeing a lot of lseek in strace lseek(21, 1447493632, 0x4 /* SEEK_??? */) = 107374182400 lseek(21, 1447559168, 0x3 /* SEEK_??? */) = 1447559168 lseek(21, 1447559168, 0x4 /* SEEK_??? */) = 10737418240

Re: [Qemu-devel] [PATCH] ich9: implement SMI_LOCK

2015-05-11 Thread Paolo Bonzini
On 06/05/2015 10:58, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann The commit message is a bit laconic, but looks good. I'll post the whole series now for review. You're welcome to add to the commit messages, and send a new git tree for me to reuse. :) Paolo > --- > hw/acpi/ich9.c

[Qemu-devel] [PULL 1/5] target-tricore: Fix LOOP using wrong register for compare

2015-05-11 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index 54a48cd..d2cd640 100644 --- a/target-tricore/translate.c +++ b/target-tricore/translate.c @@ -3440,7 +

[Qemu-devel] [PULL 0/5] tricore-patches

2015-05-11 Thread Bastian Koppelmann
stream.git tags/pull-tricore-20150511 for you to fetch changes up to 3446a11181c6e8263dbd9c13c28986df4317099e: target-tricore: fix rfe not restoring the PC (2015-05-11 14:25:49 +0200) TriCor

[Qemu-devel] [PULL 3/5] target-tricore: fix BO_OFF10_SEXT calculating the wrong offset

2015-05-11 Thread Bastian Koppelmann
The lower part of the combined offset was sign extended and could lead to wrong results. Signed-off-by: Bastian Koppelmann --- target-tricore/tricore-opcodes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-tricore/tricore-opcodes.h b/target-tricore/tricore-opcodes.h

[Qemu-devel] [PULL 2/5] target-tricore: fix SLR_LD_W and SLR_LD_W_POSTINC insn being a 2 byte memory access insted of 4

2015-05-11 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index d2cd640..663b2a0 100644 --- a/target-tricore/translate.c +++ b/target-tricore/translate.c @@ -3745

[Qemu-devel] [PULL 5/5] target-tricore: fix rfe not restoring the PC

2015-05-11 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target-tricore/op_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-tricore/op_helper.c b/target-tricore/op_helper.c index 1dc25c2..9919b5b 100644 --- a/target-tricore/op_helper.c +++ b/target-tricore/op_helper.c @@ -2458,6 +2458,7 @@ void h

[Qemu-devel] [PULL 4/5] target-tricore: fix rslcx restoring the upper context instead of the lower

2015-05-11 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- Note here, that I swaped the attributes here as compared to the patch on the list, since this was wrong. target-tricore/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-tricore/op_helper.c b/target-tricore/op_helper.c i

Re: [Qemu-devel] [PATCH v15 00/10] KVM platform device passthrough

2015-05-11 Thread Baptiste Reynal
Hi Eric, I rebased amba patches on this serie. Everything is working fine with the PL330 device. Regards, Baptiste On Wed, May 6, 2015 at 8:37 AM, Eric Auger wrote: > Dear All, > > Please ignore the previous void message. For unknown reason the reply > systematically ignores the content of the

Re: [Qemu-devel] [PULL v2 0/9] KVM, QOM, NBD, build fixes for 2015-05-08

2015-05-11 Thread Peter Maydell
On 8 May 2015 at 13:48, Paolo Bonzini wrote: > The following changes since commit 498147529d1f8e902e6528a0115143b53475791e: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20150430' into > staging (2015-04-30 14:15:56 +0100) > > are available in the git repository at: > > git://gi

[Qemu-devel] [PULL 00/28] pc, virtio enhancements

2015-05-11 Thread Michael S. Tsirkin
The following changes since commit 0d81cdddaa40a1988b24657aeac19959cfad0fde: Merge remote-tracking branch 'remotes/qmp-unstable/tags/for-upstream' into staging (2015-04-27 17:28:41 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_ups

[Qemu-devel] [PULL 02/28] hw/i386: Move ACPI header definitions in an arch-independent location

2015-05-11 Thread Michael S. Tsirkin
From: Shannon Zhao The ACPI related header file acpi-defs.h, includes definitions that apply on other architectures as well. Move it in `include/hw/acpi/` to sanely include it from other architectures. Signed-off-by: Alvise Rigo Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed

[Qemu-devel] [PULL 01/28] acpi-build: close } in comment

2015-05-11 Thread Michael S. Tsirkin
missing } confuses editors Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index e761005..1cfe265 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -976,7 +976

[Qemu-devel] [PULL 07/28] spapr: add machine type specific instance init function

2015-05-11 Thread Michael S. Tsirkin
From: Jason Wang This patches adds machine type specific instance initialization functions. Those functions will be used by following patches to compat class properties for legacy machine types. Cc: Alexander Graf Cc: qemu-...@nongnu.org Signed-off-by: Jason Wang Reviewed-by: Michael S. Tsirki

[Qemu-devel] [PULL 05/28] virtio-net: fix the upper bound when trying to delete queues

2015-05-11 Thread Michael S. Tsirkin
From: Jason Wang Virtqueue were indexed from zero, so don't delete virtqueue whose index is n->max_queues * 2 + 1. Cc: Michael S. Tsirkin Cc: qemu-stable Signed-off-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/net/virtio-net.c | 2 +- 1 file chang

[Qemu-devel] [PULL 08/28] ppc: spapr: add 2.4 machine type

2015-05-11 Thread Michael S. Tsirkin
From: Jason Wang The following patches will limit the following things to legacy machine type: - maximum number of virtqueues for virtio-pci were limited to 64 Cc: Alexander Graf Cc: qemu-...@nongnu.org Signed-off-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsir

[Qemu-devel] [PULL 04/28] vhost-user: Send VHOST_RESET_OWNER on vhost stop

2015-05-11 Thread Michael S. Tsirkin
From: Luke Gorrie Ensure that the vhost-user slave knows when the vrings are valid and when they are invalid, for example during a guest reboot. The vhost-user protocol says this of VHOST_RESET_OWNER: Issued when a new connection is about to be closed. The Master will no longer own

[Qemu-devel] [PULL 09/28] monitor: replace the magic number 255 with MAX_QUEUE_NUM

2015-05-11 Thread Michael S. Tsirkin
From: Jason Wang This patch replace the magic number 255, and increase it to MAX_QUEUE_NUM which is maximum number of queues supported by a nic. Cc: Luiz Capitulino Signed-off-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- monitor.c | 17 ++-

[Qemu-devel] [PULL 10/28] monitor: check return value of qemu_find_net_clients_except()

2015-05-11 Thread Michael S. Tsirkin
From: Jason Wang qemu_find_net_clients_except() may return a value which is greater than the size of array we provided. So we should check this value before using it, otherwise this may cause unexpected memory access. This patch fixes the net related command completion when we have a virtio-net

[Qemu-devel] [PULL 13/28] virtio-pci: speedup MSI-X masking and unmasking

2015-05-11 Thread Michael S. Tsirkin
From: Jason Wang This patch tries to speed up the MSI-X masking and unmasking through the mapping between vector and queues. With this patch it will there's no need to go through all possible virtqueues, which may help to reduce the time spent when doing MSI-X masking/unmasking a single vector wh

[Qemu-devel] [PULL 03/28] hw/i386/acpi-build: move generic acpi building helpers into dedictated file

2015-05-11 Thread Michael S. Tsirkin
From: Shannon Zhao Move generic acpi building helpers into dedictated file and this can be shared with other machines. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/aml-build.h | 29 +

[Qemu-devel] [PULL 20/28] acpi: extend aml_field() to support UpdateRule

2015-05-11 Thread Michael S. Tsirkin
From: Zhu Guihua The flags field is declared with default update rule 'Preserve', this patch extends aml_field() to support UpdateRule so that we can specify different values per field. Reviewed-by: Igor Mammedov Signed-off-by: Zhu Guihua Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael

[Qemu-devel] [PULL 11/28] virtio-ccw: using VIRTIO_NO_VECTOR instead of 0 for invalid virtqueue

2015-05-11 Thread Michael S. Tsirkin
From: Jason Wang It's a bad idea to need to use vector 0 for invalid virtqueue. So this patch changes to using VIRTIO_NO_VECTOR instead. Cc: Michael S. Tsirkin Cc: Cornelia Huck CC: Christian Borntraeger Cc: Richard Henderson Cc: Alexander Graf Signed-off-by: Jason Wang Acked-by: Cornelia

[Qemu-devel] [PULL 14/28] pci: remove hard-coded bar size in msix_init_exclusive_bar()

2015-05-11 Thread Michael S. Tsirkin
From: Jason Wang This patch lets msix_init_exclusive_bar() can calculate the bar and pba size based on the number of MSI-X vectors other than using a hard-coded limit 4096. This is needed to allow device to have more than 128 MSI_X vectors. To keep migration compatibility, keep using 4096 as bar

[Qemu-devel] [PULL 06/28] pc: add 2.4 machine types

2015-05-11 Thread Michael S. Tsirkin
From: Jason Wang The following patches will limit the following things to legacy machine type: - maximum number of virtqueues for virtio-pci were limited to 64 - auto msix bar size for virtio-net-pci were disabled by default Cc: Paolo Bonzini Cc: Richard Henderson Cc: Michael S. Tsirkin Sign

[Qemu-devel] [PULL 22/28] acpi: add hardware implementation for memory hot unplug

2015-05-11 Thread Michael S. Tsirkin
From: Zhu Guihua - implements QEMU hardware part of memory hot unplug protocol described at "docs/spec/acpi_mem_hotplug.txt" - handles memory remove notification event - handles device eject notification Reviewed-by: Igor Mammedov Signed-off-by: Zhu Guihua Reviewed-by: Michael S. Tsirkin Si

[Qemu-devel] [PULL 18/28] acpi, mem-hotplug: add unplug request cb for memory device

2015-05-11 Thread Michael S. Tsirkin
From: Tang Chen This patch adds unplug request cb for memory device, and adds the is_removing boolean field to MemStatus. This field is used to indicate whether the memory device in slot has been requested to be ejected. This field is set to true in acpi_memory_unplug_request_cb(). Reviewed-by:

[Qemu-devel] [PULL 12/28] virtio: introduce vector to virtqueues mapping

2015-05-11 Thread Michael S. Tsirkin
From: Jason Wang Currently we will try to traverse all virtqueues to find a subset that using a specific vector. This is sub optimal when we will support hundreds or even thousands of virtqueues. So this patch introduces a method which could be used by transport to get all virtqueues that using a

[Qemu-devel] [PULL 16/28] docs: update documentation for memory hot unplug

2015-05-11 Thread Michael S. Tsirkin
From: Zhu Guihua Add specification about how to use memory hot unplug, and add a flow diagram to explain memory hot unplug process. Reviewed-by: Igor Mammedov Signed-off-by: Zhu Guihua Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- docs/memory-hotplug.txt | 23

[Qemu-devel] [PULL 28/28] acpi: update expected files for memory unplug

2015-05-11 Thread Michael S. Tsirkin
commit c06b2ffb02bfcc642c67300d2c4dffd5aa54932b acpi: add hardware implementation for memory hot unplug Changed both the DSDT and the SSDT. Update the expected files accordingly. Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/pc/DSDT | Bin 2970 -> 3028 bytes tests/acpi-

  1   2   3   4   >