Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested

2015-04-23 Thread Gerd Hoffmann
Hi, > > The third one is messy. It relies on SMI_EN, which is an ioport at > > PMBA+0x30. It requires a configured PMBA. Isn't that initialized early anyway, because the pm timer lives there? It's not a regular pci bar exactly to allow early init, so the full pci bus scan + bar allocation done

Re: [Qemu-devel] Trouble with numlock and SDL

2015-04-23 Thread Gerd Hoffmann
On Mi, 2015-04-22 at 18:20 +0200, Erik Rull wrote: > Hi all, > > I'm struggling a bit with the numlock state when using SDL. > On SDL 1.2.13 I have the problem that the numlock state is inverted for QEMU - > but it is switchable. Move focus out of sdl window -- hit numlock once -- move focus back

Re: [Qemu-devel] [PATCH v2] hw/ppc/spapr_iommu: Fix the check for invalid upper bits in liobn

2015-04-23 Thread David Gibson
On Tue, Apr 21, 2015 at 05:12:11PM +0200, Thomas Huth wrote: > The check "liobn & 0xULL" in spapr_tce_find_by_liobn() > is completely useless since liobn is only declared as an uint32_t > parameter. Fix this by using target_ulong instead (this is what most > of the callers of this f

Re: [Qemu-devel] cpu modelling and hotplug (was: [PATCH RFC 0/4] target-i386: PC socket/core/thread modeling, part 1)

2015-04-23 Thread David Gibson
On Tue, Apr 07, 2015 at 02:43:43PM +0200, Christian Borntraeger wrote: > We had a call and I was asked to write a summary about our conclusion. > > The more I wrote, there more I became uncertain if we really came to a > conclusion and became more certain that we want to define the QMP/HMP/CLI >

Re: [Qemu-devel] [RFC 00/10] MultiThread TCG.

2015-04-23 Thread Frederic Konrad
On 22/04/2015 15:18, Peter Maydell wrote: On 22 April 2015 at 13:26, Frederic Konrad wrote: [re summary of design] Does that makes sense? Oops, I think that I lost that email in the flow of stuff through the mailing list. I think Alex is going to be doing the bulk of the review on this for Lin

Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested

2015-04-23 Thread Laszlo Ersek
On 04/23/15 09:02, Gerd Hoffmann wrote: > Hi, > >>> The third one is messy. It relies on SMI_EN, which is an ioport at >>> PMBA+0x30. It requires a configured PMBA. > > Isn't that initialized early anyway, because the pm timer lives there? TimerLib (which is based in OVMF's case on the PM time

Re: [Qemu-devel] [PATCH 0/2] virtfs-proxy-helper: small fixes

2015-04-23 Thread Aneesh Kumar K.V
Stefan Hajnoczi writes: > On Mon, Mar 30, 2015 at 02:57:14PM +0100, Stefan Hajnoczi wrote: >> These fixes are not critical but it wouldn't hurt to get them into QEMU 2.3. >> >> See patches for descriptions. >> >> Stefan Hajnoczi (2): >> virtfs-proxy-helper: add missing long option terminator

Re: [Qemu-devel] [PATCH v2 9/9] target-arm: Add WFx instruction trap support

2015-04-23 Thread Peter Maydell
On 23 April 2015 at 03:49, Edgar E. Iglesias wrote: > On Wed, Apr 22, 2015 at 12:09:21PM -0500, Greg Bellows wrote: >> void HELPER(wfe)(CPUARMState *env) >> { >> CPUState *cs = CPU(arm_env_get_cpu(env)); >> +int target_el = check_wfx_trap(env, true); >> >> /* Don't actually halt th

Re: [Qemu-devel] [PATCH v2 0/9] target-arm: EL3 trap support

2015-04-23 Thread Peter Maydell
On 23 April 2015 at 04:37, Edgar E. Iglesias wrote: > On Wed, Apr 22, 2015 at 12:09:12PM -0500, Greg Bellows wrote: >> Initial patchset adding support for trapping to an EL other than EL1. >> Support >> includes changes to interfaces to allow specification of the target EL. Also >> includes the

Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested

2015-04-23 Thread Laszlo Ersek
On 04/23/15 09:41, Laszlo Ersek wrote: > On 04/23/15 09:02, Gerd Hoffmann wrote: >> Hi, >> The third one is messy. It relies on SMI_EN, which is an ioport at PMBA+0x30. It requires a configured PMBA. >> >> Isn't that initialized early anyway, because the pm timer lives there? > > Timer

Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested

2015-04-23 Thread Gerd Hoffmann
Hi, > I'll ask Jordan too about the dynamic feature detection, because there's > another big hurdle with it (selecting a LockBox library instance at > runtime, dependent on the presence of SMM). Deciding about SMM support > at build time would make things hugely easier (because that's how > firm

Re: [Qemu-devel] [libvirt] [RFC 0/7] Live Migration with Pass-through Devices proposal

2015-04-23 Thread Chen Fan
On 04/20/2015 06:29 AM, Laine Stump wrote: On 04/17/2015 04:53 AM, Chen Fan wrote: backgrond: Live migration is one of the most important features of virtualization technology. With regard to recent virtualization techniques, performance of network I/O is critical. Current network I/O virtual

Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested

2015-04-23 Thread Laszlo Ersek
On 04/23/15 10:34, Gerd Hoffmann wrote: > Hi, > >> I'll ask Jordan too about the dynamic feature detection, because there's >> another big hurdle with it (selecting a LockBox library instance at >> runtime, dependent on the presence of SMM). Deciding about SMM support >> at build time would make

Re: [Qemu-devel] [PATCH 0/2] virtfs-proxy-helper: small fixes

2015-04-23 Thread Aneesh Kumar K.V
"Aneesh Kumar K.V" writes: > Stefan Hajnoczi writes: > >> On Mon, Mar 30, 2015 at 02:57:14PM +0100, Stefan Hajnoczi wrote: >>> These fixes are not critical but it wouldn't hurt to get them into QEMU 2.3. >>> I am not sure whether this is critical enough to go to Qemu 2.3 ? If so I can send a p

Re: [Qemu-devel] [PATCH 03/27] block/parallels: switch to bdrv_read

2015-04-23 Thread Stefan Hajnoczi
On Wed, Apr 22, 2015 at 03:30:50PM +0300, Denis V. Lunev wrote: > On 22/04/15 15:23, Stefan Hajnoczi wrote: > >On Wed, Mar 11, 2015 at 01:27:57PM +0300, Denis V. Lunev wrote: > >>From: Roman Kagan > >> > >>Switch the .bdrv_read method implementation from using bdrv_pread() to > >>bdrv_read() on th

[Qemu-devel] [PATCH 1/2] irq: add get_gsi callback

2015-04-23 Thread Eric Auger
Add a new IRQState get_gsi_cb field, corresponding to a callback that transforms the interrupt controller pin number into a global system interrupt number. A setter is introduced for the interrupt controller to populate the callback. Also add a public function that calls this callback. Signed-off

[Qemu-devel] [PATCH 0/2] irq: add get_gsi callback

2015-04-23 Thread Eric Auger
This series introduces a new callback function in IRQState, named get_gsi_cb. It is supposed to be populated by the interrupt controller and its role is to convert the interrupt controller pin number into the global system interrupt (gsi) number. The gsi is used when setting irqfd up. With PCI the

[Qemu-devel] [PATCH 2/2] intc: arm_gic_kvm: set the get_gsi callback

2015-04-23 Thread Eric Auger
The arm_gic_kvm now sets the get_gsi_cb callback so that the global system interrupt of a qemu_irq can be retrieved. This enables VFIO platform signaling to be setup. Signed-off-by: Eric Auger --- hw/intc/arm_gic_kvm.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/intc/arm_g

[Qemu-devel] [PATCH] sysbus: add irq_routing_notifier

2015-04-23 Thread Eric Auger
Add a new irq_routing_notifier notifier and its setter. This notifier is called on sysbus_connect_irq. The same notifier is used for all interrupts. Signed-off-by: Eric Auger --- hw/core/sysbus.c| 9 + include/hw/sysbus.h | 6 ++ 2 files changed, 15 insertions(+) diff --git a/hw

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-04-23 Thread Claudio Fontana
On 21 April 2015 at 16:47, Paolo Bonzini wrote: > > > On 21/04/2015 16:35, Luiz Capitulino wrote: >> > gladly, I am definitely looking for Review, first I wanted to check if the >> > idea itself was acceptable. >> >> I honestly don't have an opinion on this, which means I'm willing >> to apply if

Re: [Qemu-devel] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Kevin Wolf
Am 22.04.2015 um 12:12 hat Paolo Bonzini geschrieben: > On 22/04/2015 11:31, Kevin Wolf wrote: > >> Actually I liked the "foo+colo" names. > >> > >> These are just internal details of the implementations and the > >> primary/secondary disks actually can be any format. > >> > >> Stefan, what was you

Re: [Qemu-devel] [PATCH 05/27] block/parallels: add get_block_status

2015-04-23 Thread Stefan Hajnoczi
On Wed, Apr 22, 2015 at 03:42:23PM +0300, Denis V. Lunev wrote: > On 22/04/15 15:39, Stefan Hajnoczi wrote: > >On Wed, Mar 11, 2015 at 01:27:59PM +0300, Denis V. Lunev wrote: > >>+static int64_t coroutine_fn parallels_co_get_block_status(BlockDriverState > >>*bs, > >>+int64_t sector_num, i

Re: [Qemu-devel] [PATCH 2/8] block: allow block jobs in any arbitrary node

2015-04-23 Thread Alberto Garcia
On Wed 22 Apr 2015 10:06:15 PM CEST, Eric Blake wrote: >> -- "device": Device name (json-string) >> +- "device": Device name, or node name if not present (json-string) > > You used this wording for all the events... >> # Throttling can be disabled by setting the speed to 0. >> # >> -# @devi

Re: [Qemu-devel] [PATCH 08/27] block/parallels: _co_writev callback for Parallels format

2015-04-23 Thread Stefan Hajnoczi
On Wed, Apr 22, 2015 at 04:16:38PM +0300, Denis V. Lunev wrote: > On 22/04/15 16:08, Stefan Hajnoczi wrote: > >On Wed, Mar 11, 2015 at 01:28:02PM +0300, Denis V. Lunev wrote: > >>+static int64_t allocate_cluster(BlockDriverState *bs, int64_t sector_num) > >>+{ > >>+BDRVParallelsState *s = bs->o

Re: [Qemu-devel] [PATCH 05/27] block/parallels: add get_block_status

2015-04-23 Thread Denis V. Lunev
On 23/04/15 12:03, Stefan Hajnoczi wrote: On Wed, Apr 22, 2015 at 03:42:23PM +0300, Denis V. Lunev wrote: On 22/04/15 15:39, Stefan Hajnoczi wrote: On Wed, Mar 11, 2015 at 01:27:59PM +0300, Denis V. Lunev wrote: +static int64_t coroutine_fn parallels_co_get_block_status(BlockDriverState *bs, +

Re: [Qemu-devel] [PATCH 26/27] block/parallels: optimize linear image expansion

2015-04-23 Thread Stefan Hajnoczi
On Wed, Apr 22, 2015 at 05:25:14PM +0300, Denis V. Lunev wrote: > On 22/04/15 17:18, Stefan Hajnoczi wrote: > >On Wed, Mar 11, 2015 at 01:28:20PM +0300, Denis V. Lunev wrote: > >>Plain image expansion spends a lot of time to update image file size. > >>This seriously affects the performance. The fo

Re: [Qemu-devel] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Paolo Bonzini
On 23/04/2015 11:00, Kevin Wolf wrote: > Because it may be the right design. > > If you're really worried about the test matrix, put a check in the > filter block driver that its bs->file is qcow2. Of course, such an > artificial restriction looks a bit ugly, but using a bad design just > in ord

Re: [Qemu-devel] [PATCH 0/2] irq: add get_gsi callback

2015-04-23 Thread Paolo Bonzini
On 23/04/2015 10:49, Eric Auger wrote: > This series introduces a new callback function in IRQState, named > get_gsi_cb. It is supposed to be populated by the interrupt controller > and its role is to convert the interrupt controller pin number into > the global system interrupt (gsi) number. The

Re: [Qemu-devel] [PATCH 08/27] block/parallels: _co_writev callback for Parallels format

2015-04-23 Thread Kevin Wolf
Am 23.04.2015 um 11:20 hat Stefan Hajnoczi geschrieben: > On Wed, Apr 22, 2015 at 04:16:38PM +0300, Denis V. Lunev wrote: > > On 22/04/15 16:08, Stefan Hajnoczi wrote: > > >On Wed, Mar 11, 2015 at 01:28:02PM +0300, Denis V. Lunev wrote: > > >>+static int64_t allocate_cluster(BlockDriverState *bs, i

Re: [Qemu-devel] [PATCH] sysbus: add irq_routing_notifier

2015-04-23 Thread Paolo Bonzini
On 23/04/2015 10:55, Eric Auger wrote: > Add a new irq_routing_notifier notifier and its setter. This > notifier is called on sysbus_connect_irq. The same notifier > is used for all interrupts. > > Signed-off-by: Eric Auger I'm sorry, same problem here. The question is: why? :) I can sort of

Re: [Qemu-devel] [PATCH 08/27] block/parallels: _co_writev callback for Parallels format

2015-04-23 Thread Denis V. Lunev
On 23/04/15 12:20, Stefan Hajnoczi wrote: On Wed, Apr 22, 2015 at 04:16:38PM +0300, Denis V. Lunev wrote: On 22/04/15 16:08, Stefan Hajnoczi wrote: On Wed, Mar 11, 2015 at 01:28:02PM +0300, Denis V. Lunev wrote: +static int64_t allocate_cluster(BlockDriverState *bs, int64_t sector_num) +{ +

Re: [Qemu-devel] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Wen Congyang
On 04/23/2015 05:26 PM, Paolo Bonzini wrote: > > > On 23/04/2015 11:00, Kevin Wolf wrote: >> Because it may be the right design. >> >> If you're really worried about the test matrix, put a check in the >> filter block driver that its bs->file is qcow2. Of course, such an >> artificial restriction

Re: [Qemu-devel] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Kevin Wolf
Am 23.04.2015 um 11:26 hat Paolo Bonzini geschrieben: > > > On 23/04/2015 11:00, Kevin Wolf wrote: > > Because it may be the right design. > > > > If you're really worried about the test matrix, put a check in the > > filter block driver that its bs->file is qcow2. Of course, such an > > artific

Re: [Qemu-devel] [PATCH 0/2] irq: add get_gsi callback

2015-04-23 Thread Eric Auger
Hi Paolo, On 04/23/2015 11:30 AM, Paolo Bonzini wrote: > > > On 23/04/2015 10:49, Eric Auger wrote: >> This series introduces a new callback function in IRQState, named >> get_gsi_cb. It is supposed to be populated by the interrupt controller >> and its role is to convert the interrupt controller

Re: [Qemu-devel] [PATCH 08/27] block/parallels: _co_writev callback for Parallels format

2015-04-23 Thread Denis V. Lunev
On 23/04/15 12:32, Kevin Wolf wrote: Am 23.04.2015 um 11:20 hat Stefan Hajnoczi geschrieben: On Wed, Apr 22, 2015 at 04:16:38PM +0300, Denis V. Lunev wrote: On 22/04/15 16:08, Stefan Hajnoczi wrote: On Wed, Mar 11, 2015 at 01:28:02PM +0300, Denis V. Lunev wrote: +static int64_t allocate_clust

Re: [Qemu-devel] [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Stefan Hajnoczi
On Wed, Apr 22, 2015 at 05:28:01PM +0800, Wen Congyang wrote: > On 04/22/2015 05:18 PM, Stefan Hajnoczi wrote: > > On Tue, Apr 21, 2015 at 05:28:01PM +0200, Paolo Bonzini wrote: > >> On 21/04/2015 03:25, Wen Congyang wrote: > > Please do not introduce "+colo" block drivers. This approach is >

Re: [Qemu-devel] [PATCH 0/2] irq: add get_gsi callback

2015-04-23 Thread Paolo Bonzini
On 23/04/2015 11:40, Eric Auger wrote: >> > Why can't you just use a GHashTable? > You mean implementing this hash table in the interrupt controller? No, in KVM. Basically the kvm-vgic interrupt controller registers its qemu_irqs with kvm-all.c, passing the gsi number for KVM_IRQFD along the

Re: [Qemu-devel] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Wen Congyang
On 04/23/2015 05:00 PM, Kevin Wolf wrote: > Am 22.04.2015 um 12:12 hat Paolo Bonzini geschrieben: >> On 22/04/2015 11:31, Kevin Wolf wrote: Actually I liked the "foo+colo" names. These are just internal details of the implementations and the primary/secondary disks actually can

Re: [Qemu-devel] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Paolo Bonzini
On 23/04/2015 11:14, Wen Congyang wrote: > The bs->file->driver should support backing file, and use backing reference > already. > > What about the primary side? We should control when to connect to NBD server, > not in nbd_open(). My naive suggestion could be to add a BDRV_O_NO_CONNECT option

Re: [Qemu-devel] [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Wen Congyang
On 04/23/2015 05:55 PM, Stefan Hajnoczi wrote: > On Wed, Apr 22, 2015 at 05:28:01PM +0800, Wen Congyang wrote: >> On 04/22/2015 05:18 PM, Stefan Hajnoczi wrote: >>> On Tue, Apr 21, 2015 at 05:28:01PM +0200, Paolo Bonzini wrote: On 21/04/2015 03:25, Wen Congyang wrote: >>> Please do not int

Re: [Qemu-devel] [PATCH 08/27] block/parallels: _co_writev callback for Parallels format

2015-04-23 Thread Kevin Wolf
Am 23.04.2015 um 11:47 hat Denis V. Lunev geschrieben: > On 23/04/15 12:32, Kevin Wolf wrote: > >Am 23.04.2015 um 11:20 hat Stefan Hajnoczi geschrieben: > >>On Wed, Apr 22, 2015 at 04:16:38PM +0300, Denis V. Lunev wrote: > >>>On 22/04/15 16:08, Stefan Hajnoczi wrote: > On Wed, Mar 11, 2015 at 0

Re: [Qemu-devel] [PATCH v2 0/9] target-arm: EL3 trap support

2015-04-23 Thread Peter Maydell
On 23 April 2015 at 04:37, Edgar E. Iglesias wrote: > I had a comment on the trapping of WFX, I recall not checking for > has_work was causing a lot of exception round-trips when running > XEN. To the point were things almost stopped working. For traps on WFE, or traps on WFI? If the former, we s

Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: do lazy allocation of the L2 cache

2015-04-23 Thread Stefan Hajnoczi
On Wed, Apr 22, 2015 at 04:37:15PM +0200, Alberto Garcia wrote: > On Wed 22 Apr 2015 12:26:02 PM CEST, Stefan Hajnoczi wrote: > > >> Large disk images need large L2 caches in order to maximize their I/O > >> performance. However setting a correct size for the cache is not > >> necessarily easy sin

Re: [Qemu-devel] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Kevin Wolf
Am 23.04.2015 um 12:05 hat Paolo Bonzini geschrieben: > > > On 23/04/2015 11:14, Wen Congyang wrote: > > The bs->file->driver should support backing file, and use backing reference > > already. > > > > What about the primary side? We should control when to connect to NBD > > server, > > not in

Re: [Qemu-devel] [PATCH v2 0/9] target-arm: EL3 trap support

2015-04-23 Thread Edgar E. Iglesias
--- Sent from my phone On 23/04/2015 8:10 pm, "Peter Maydell" wrote: > > On 23 April 2015 at 04:37, Edgar E. Iglesias wrote: > > I had a comment on the trapping of WFX, I recall not checking for > > has_work was causing a lot of exception round-trips when running > > XEN. To the point were things

Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested

2015-04-23 Thread Paolo Bonzini
On 23/04/2015 09:02, Gerd Hoffmann wrote: >>> > > The third one is messy. It relies on SMI_EN, which is an ioport at >>> > > PMBA+0x30. It requires a configured PMBA. > Isn't that initialized early anyway, because the pm timer lives there? > It's not a regular pci bar exactly to allow early init,

Re: [Qemu-devel] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Paolo Bonzini
On 23/04/2015 12:17, Kevin Wolf wrote: > > Perhaps quorum is not a great match after all, and it's better to add a > > new "colo" driver similar to quorum but simpler and only using the read > > policy that you need for colo. The new driver would also know how to > > use BDRV_O_NO_CONNECT. In a

Re: [Qemu-devel] [PATCH v2 9/9] target-arm: Add WFx instruction trap support

2015-04-23 Thread Edgar E. Iglesias
On 23/04/2015 6:00 pm, "Peter Maydell" wrote: > > On 23 April 2015 at 03:49, Edgar E. Iglesias wrote: > > On Wed, Apr 22, 2015 at 12:09:21PM -0500, Greg Bellows wrote: > >> void HELPER(wfe)(CPUARMState *env) > >> { > >> CPUState *cs = CPU(arm_env_get_cpu(env)); > >> +int target_el = ch

Re: [Qemu-devel] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Kevin Wolf
Am 23.04.2015 um 12:33 hat Paolo Bonzini geschrieben: > On 23/04/2015 12:17, Kevin Wolf wrote: > > > Perhaps quorum is not a great match after all, and it's better to add a > > > new "colo" driver similar to quorum but simpler and only using the read > > > policy that you need for colo. The new dr

Re: [Qemu-devel] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Paolo Bonzini
On 23/04/2015 12:40, Kevin Wolf wrote: > The question that is still open for me is whether it would be a colo.c > or an active-mirror.c, i.e. if this would be tied specifically to COLO > or if it could be kept generic enough that it could be used for other > use cases as well. Understood (now).

Re: [Qemu-devel] [PATCH v2 9/9] target-arm: Add WFx instruction trap support

2015-04-23 Thread Peter Maydell
On 23 April 2015 at 11:39, Edgar E. Iglesias wrote: > > On 23/04/2015 6:00 pm, "Peter Maydell" wrote: >> In theory you could maybe check has_work() for the WFI case, >> since doing an EXCP_HLT really should cause us to stop until >> has_work is true, but it seems a bit fragile -- could we really

Re: [Qemu-devel] [PATCH V7 09/16] virtio-ccw: introduce ccw specific queue limit

2015-04-23 Thread Cornelia Huck
On Thu, 23 Apr 2015 14:21:42 +0800 Jason Wang wrote: > Instead of depending on marco, using a bus specific limit. Also make > it clear that the number of gsis per I/O adapter is not directly > depending on the number of virtio queues, but rather the other way > around. > > Cc: Alexander Graf >

Re: [Qemu-devel] [PATCH 3/3] arm: semihosting: Wire up A64 HLT 0xf000

2015-04-23 Thread Leon Alrae
Hi Christopher, On 09/04/2015 18:57, Peter Maydell wrote: > On 9 April 2015 at 18:23, Christopher Covington > wrote: >> On Fri, Mar 27, 2015 at 12:40 PM, Peter Maydell >> wrote: >>> You need to have the semihosting_enabled check here rather >>> than in the do_interrupt code, because otherwise we

Re: [Qemu-devel] [PATCH v2 9/9] target-arm: Add WFx instruction trap support

2015-04-23 Thread Edgar E. Iglesias
On Thu, Apr 23, 2015 at 11:57:10AM +0100, Peter Maydell wrote: > On 23 April 2015 at 11:39, Edgar E. Iglesias wrote: > > > > On 23/04/2015 6:00 pm, "Peter Maydell" wrote: > >> In theory you could maybe check has_work() for the WFI case, > >> since doing an EXCP_HLT really should cause us to stop

Re: [Qemu-devel] [PATCH V7 15/16] virtio-pci: increase the maximum number of virtqueues to 513

2015-04-23 Thread Cornelia Huck
On Thu, 23 Apr 2015 14:21:48 +0800 Jason Wang wrote: > This patch increases the maximum number of virtqueues for pci from 64 > to 513. This will allow booting a virtio-net-pci device with 256 queue ^^^ > pairs on recent Linux host (which supports up to 256 tuntap queue pairs). > > To keep

Re: [Qemu-devel] [PATCH V7 00/16] Support more virtio queues

2015-04-23 Thread Cornelia Huck
On Thu, 23 Apr 2015 14:21:33 +0800 Jason Wang wrote: > Stress/migration test on virtio-pci, compile test on other > targets. And make check on s390x-softmmu and ppc64-softmmu. This passes my smoke tests on the s390-ccw-virtio and s390-virtio machines.

Re: [Qemu-devel] [PATCH 0/2] irq: add get_gsi callback

2015-04-23 Thread Eric Auger
Hi Paolo, thanks for taking the time to explain. I will rewrite accordingly. Best Regards Eric On 04/23/2015 11:58 AM, Paolo Bonzini wrote: > > > On 23/04/2015 11:40, Eric Auger wrote: Why can't you just use a GHashTable? >> You mean implementing this hash table in the interrupt controll

Re: [Qemu-devel] [PATCH v2 9/9] target-arm: Add WFx instruction trap support

2015-04-23 Thread Peter Maydell
On 23 April 2015 at 12:24, Edgar E. Iglesias wrote: > Maybe we can consider YIELD instead of NOP when has_work() is true as a WFI > is probably a good hint from guests to reschedule QEMU CPUs. That I'm not convinced about. If we have a pending interrupt then our best bet is probably to take it im

Re: [Qemu-devel] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Wen Congyang
On 04/23/2015 06:44 PM, Paolo Bonzini wrote: > > > On 23/04/2015 12:40, Kevin Wolf wrote: >> The question that is still open for me is whether it would be a colo.c >> or an active-mirror.c, i.e. if this would be tied specifically to COLO >> or if it could be kept generic enough that it could be u

Re: [Qemu-devel] [PATCH v2 9/9] target-arm: Add WFx instruction trap support

2015-04-23 Thread Edgar E. Iglesias
On Thu, Apr 23, 2015 at 12:28:43PM +0100, Peter Maydell wrote: > On 23 April 2015 at 12:24, Edgar E. Iglesias wrote: > > Maybe we can consider YIELD instead of NOP when has_work() is true as a WFI > > is probably a good hint from guests to reschedule QEMU CPUs. > > That I'm not convinced about. I

Re: [Qemu-devel] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Kevin Wolf
Am 23.04.2015 um 12:44 hat Paolo Bonzini geschrieben: > On 23/04/2015 12:40, Kevin Wolf wrote: > > The question that is still open for me is whether it would be a colo.c > > or an active-mirror.c, i.e. if this would be tied specifically to COLO > > or if it could be kept generic enough that it coul

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.4 V2 0/9] various improvements for the iSCSI driver

2015-04-23 Thread Stefan Hajnoczi
On Thu, Apr 16, 2015 at 04:08:24PM +0200, Peter Lieven wrote: > v1->v2: - removed the requirement for libiscsi 1.10.0 [Paolo] > - reworked to force_next_flush logic [Paolo] > > Peter Lieven (9): > block/iscsi: do not forget to logout from target > block/iscsi: change all iscsilun prope

Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: do lazy allocation of the L2 cache

2015-04-23 Thread Alberto Garcia
On Thu 23 Apr 2015 12:15:04 PM CEST, Stefan Hajnoczi wrote: >> For a cache size of 128MB, the PSS is actually ~10MB larger without >> the patch, which seems to come from posix_memalign(). > > Do you mean RSS or are you using a tool that reports a "PSS" number > that I don't know about? > > We shou

Re: [Qemu-devel] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Paolo Bonzini
On 23/04/2015 13:36, Kevin Wolf wrote: > Crap. Then we need to figure out dynamic reconfiguration for filters > (CCed Markus and Jeff). > > And this is really part of the fundamental operation mode and not just a > way to give users a way to change their mind at runtime? Because if it > were, we

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-23 Thread Leon Alrae
On 21/04/2015 19:08, Liviu Ionescu wrote: > >> On 21 Apr 2015, at 16:34, Leon Alrae wrote: >> >> I'll resend the patch with dropped "RFC" as I would really like to go >> forward and finally close this issue. > > perhaps you should first take a closer look at the patch I submitted, since > it co

Re: [Qemu-devel] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 23/04/2015 13:36, Kevin Wolf wrote: > > Crap. Then we need to figure out dynamic reconfiguration for filters > > (CCed Markus and Jeff). > > > > And this is really part of the fundamental operation mode and not just a > > way to give users a

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-23 Thread Liviu Ionescu
> On 23 Apr 2015, at 14:55, Leon Alrae wrote: > > have been broken into 3 separate patches: please feel free to reorganise the patches as you think it is more appropriate. to avoid conflicts in my branch I would obviously appreciate keeping the structure as is, and also keeping the cmdline as

Re: [Qemu-devel] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Paolo Bonzini
On 23/04/2015 14:05, Dr. David Alan Gilbert wrote: > As presented at the moment, I don't see there's any dynamic reconfiguration > on the primary side at the moment So that means the bdrv_start_replication and bdrv_stop_replication callbacks are more or less redundant, at least on the primary?

Re: [Qemu-devel] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 23/04/2015 14:05, Dr. David Alan Gilbert wrote: > > As presented at the moment, I don't see there's any dynamic reconfiguration > > on the primary side at the moment > > So that means the bdrv_start_replication and bdrv_stop_replication > cal

Re: [Qemu-devel] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Paolo Bonzini
On 23/04/2015 14:19, Dr. David Alan Gilbert wrote: >> > So that means the bdrv_start_replication and bdrv_stop_replication >> > callbacks are more or less redundant, at least on the primary? >> > >> > In fact, who calls them? Certainly nothing in this patch set... >> > :) > In the main colo set

Re: [Qemu-devel] [PATCH] target-arm: Adjust id_aa64pfr0 when has_el3 CPU property disabled

2015-04-23 Thread Peter Maydell
On 22 April 2015 at 03:18, Sergey Fedorov wrote: > Signed-off-by: Sergey Fedorov > --- > target-arm/cpu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied to target-arm.next, thanks. -- PMM

Re: [Qemu-devel] [PATCH 01/10] s390x/kvm: Remove message about "switch_amode" kernel parameter

2015-04-23 Thread Christian Borntraeger
Am 09.04.2015 um 10:51 schrieb Cornelia Huck: > From: Thomas Huth > > The "switch_amode" parameter has been removed from the Linux kernel > sources since version 3.7 - so QEMU should not advise this parameter > nowadays anymore. > > Signed-off-by: Thomas Huth > Acked-by: Cornelia Huck > Signed

Re: [Qemu-devel] [PATCH v1 RFC 00/34] Generic support for TLS protocol & I/O channels

2015-04-23 Thread Stefan Hajnoczi
On Fri, Apr 17, 2015 at 03:22:03PM +0100, Daniel P. Berrange wrote: > While I will probably start work on it, I'm not intending to submit > the update of the NBD/migration code, until this series has been > positively reviewed and looks like it is close to accepted for merge, > as there are already

Re: [Qemu-devel] [PATCH v1 RFC 23/34] io: add QIOChannelSocket class

2015-04-23 Thread Daniel P. Berrange
On Mon, Apr 20, 2015 at 09:18:49AM +0200, Gerd Hoffmann wrote: > On Fr, 2015-04-17 at 15:22 +0100, Daniel P. Berrange wrote: > > Implement a QIOChannel subclass that supports sockets I/O > > > > TBD check errno handling of windows port & fix watch impl > > > +struct QIOChannelSocket { > > +QI

Re: [Qemu-devel] [PATCH v1 RFC 34/34] char: introduce support for TLS encrypted TCP chardev backend

2015-04-23 Thread Daniel P. Berrange
On Fri, Apr 17, 2015 at 12:27:06PM -0600, Eric Blake wrote: > On 04/17/2015 08:22 AM, Daniel P. Berrange wrote: > > This integrates support for QIOChannelTLS object in the TCP > > chardev backend. If the 'tls-cred=NAME' option is passed with > > the '-chardev tcp' argument, then it will setup the c

Re: [Qemu-devel] [PATCH 01/10] s390x/kvm: Remove message about "switch_amode" kernel parameter

2015-04-23 Thread Cornelia Huck
On Thu, 23 Apr 2015 14:26:44 +0200 Christian Borntraeger wrote: > Am 09.04.2015 um 10:51 schrieb Cornelia Huck: > > From: Thomas Huth > > > > The "switch_amode" parameter has been removed from the Linux kernel > > sources since version 3.7 - so QEMU should not advise this parameter > > nowadays

[Qemu-devel] [PATCH] qmp-commands.hx: Update the supported 'transaction' operations

2015-04-23 Thread Kashyap Chamarthy
Although the canonical source of reference for QMP commands is qapi-schema.json, for consistency's sake, update qmp-commands.hx to state the list of supported transactionable operations, namely: drive-backup blockdev-backup blockdev-snapshot-internal-sync abort block-dirty-bitm

Re: [Qemu-devel] [PATCH RFC 19/19] qapi: New QMP command query-schema for QMP schema introspection

2015-04-23 Thread Kevin Wolf
Am 15.04.2015 um 14:56 hat Eric Blake geschrieben: > On 04/15/2015 03:16 AM, Alberto Garcia wrote: > > On Sat 11 Apr 2015 01:06:58 AM CEST, Eric Blake wrote: > > > >>> +{ 'type': 'SchemaInfoEnum', > >>> + 'data': { 'values': ['str'] } } > >> > >> At one point, one thread suggested that we might

Re: [Qemu-devel] [PATCH v2 0/4] scripts: qmp-shell: add transaction support

2015-04-23 Thread Luiz Capitulino
On Wed, 22 Apr 2015 15:27:17 -0400 John Snow wrote: > > > On 04/22/2015 12:21 PM, John Snow wrote: > > The qmp-shell is a little rudimentary, but it can be hacked > > to give us some transactional support without too much difficulty. > > > > (1) Prep. > > (2) Add support for serializing json ar

Re: [Qemu-devel] [PATCH RFC 19/19] qapi: New QMP command query-schema for QMP schema introspection

2015-04-23 Thread Kevin Wolf
One question in addition to what Eric already asked: Am 02.04.2015 um 19:29 hat Markus Armbruster geschrieben: > +{ 'enum': 'SchemaMetaType', > + 'data': [ 'builtin', 'enum', 'array', 'object', 'alternate', > +'command', 'event' ] } > + > +{ 'type': 'SchemaInfoBase', > + 'data': { 'n

Re: [Qemu-devel] [Qemu-block] [PATCH v6 00/21] block: transactionless incremental backup series

2015-04-23 Thread Stefan Hajnoczi
On Fri, Apr 17, 2015 at 07:49:48PM -0400, John Snow wrote: > === > v6: > === > > 01: s/underlaying/underlying/ > Removed a reference to 'disabled' bitmaps. > Touching up inconsistent list indentation. > Added FreeBSD Documentation License, primarily to be difficult Please stick to the

Re: [Qemu-devel] [Qemu-block] [PATCH v6 06/21] hbitmap: cache array lengths

2015-04-23 Thread Stefan Hajnoczi
On Fri, Apr 17, 2015 at 07:49:54PM -0400, John Snow wrote: > As a convenience: between incremental backups, bitmap migrations > and bitmap persistence we seem to need to recalculate these a lot. > > Because the lengths are a little bit-twiddly, let's just solidly > cache them and be done with it.

[Qemu-devel] [PATCH RFC v7 0/7] Update tests/qemu-iotests failing cases for the s390 platform

2015-04-23 Thread Bo Tu
v7. 1. Add a pc specific output file for test 130. 2. A new variable device_id is defined in test 130 to support multiplatform. 3. Update the output file for test 051 based on it's current output. 4. test 049 failed in s390x platform while specifying a negtive size using -o option when create an i

[Qemu-devel] [PATCH RFC v7 5/7] qemu-iotests: s390x: fix test 049

2015-04-23 Thread Bo Tu
when creating an image qemu-img enable us specifying the size of the image using -o size=xx options. But when we specify an invalid size such as a negtive size then different platform gives different result. parse_option_size() function in util/qemu-option.c will be called to parse the size, a cas

Re: [Qemu-devel] Add an IPMI device to qemu

2015-04-23 Thread Noel Burton-Krahn
OK, I've build qemu and openipmi. I'm simulating a system where a central control node boots from USB, then uses IPMI to boot a cluster of slave nodes and provisions them by tftpboot. If I understand correctly, I'll be running one ipmi_sim per slave node, and my control node will tell that to boo

[Qemu-devel] [PATCH RFC v7 1/7] qemu-iotests: qemu machine type support

2015-04-23 Thread Bo Tu
From: Xiao Guang Chen This patch adds qemu machine type support to the io test suite. Based on the qemu default machine type and alias of the default machine type the reference output file can now vary from the default to a machine specific output file if necessary. When using a machine specific

[Qemu-devel] [PATCH RFC v7 2/7] qemu-iotests: run qemu with -nodefaults and fix 067, 071, 081 and 087

2015-04-23 Thread Bo Tu
From: Xiao Guang Chen This patch fixes an io test suite issue that was introduced with the commit c88930a6866e74953e931ae749781e98e486e5c8 'qemu-char: Permit only a single "stdio" character device'. The option supresses the creation of default devices such as the floopy and cdrom. Output files fo

[Qemu-devel] [PATCH RFC v7 4/7] qemu-iotests: s390x: fix test 055

2015-04-23 Thread Bo Tu
From: Xiao Guang Chen There is no 'ide-cd' device defined on s390 platform, so test_medium_not_found() test should be skipped. Reviewed-by: Max Reitz Reviewed-by: Michael Mueller Signed-off-by: Xiao Guang Chen --- tests/qemu-iotests/055 | 9 + 1 file changed, 9 insertions(+) diff --

Re: [Qemu-devel] cpu modelling and hotplug (was: [PATCH RFC 0/4] target-i386: PC socket/core/thread modeling, part 1)

2015-04-23 Thread Eduardo Habkost
On Thu, Apr 23, 2015 at 05:32:33PM +1000, David Gibson wrote: > On Tue, Apr 07, 2015 at 02:43:43PM +0200, Christian Borntraeger wrote: > > We had a call and I was asked to write a summary about our conclusion. > > > > The more I wrote, there more I became uncertain if we really came to a > > conc

[Qemu-devel] [PATCH RFC v7 3/7] qemu-iotests: s390x: fix test 041

2015-04-23 Thread Bo Tu
From: Xiao Guang Chen There is no 'ide-cd' device defined on s390 platform, so test_medium_not_found() test should be skipped. Reviewed-by: Max Reitz Reviewed-by: Michael Mueller Signed-off-by: Xiao Guang Chen --- tests/qemu-iotests/041 | 6 ++ 1 file changed, 6 insertions(+) diff --git

[Qemu-devel] [PATCH RFC v7 7/7] qemu-iotests-s390x-fix-test-130

2015-04-23 Thread Bo Tu
The tests for device type "ide_cd" should only be tested for the pc platform. The default device id of hard disk on the s390 platform differs to that of the x86 platform. A new variable device_id is defined and "virtio0" set for the s390 platform. A x86 platform specific output file is also needed.

[Qemu-devel] [PATCH] kvm: do not force hypervisor flag in guest`s CPUID

2015-04-23 Thread Vladislav Yarmak
Do not force hypervisor flag in guests` CPUID - let invoker decide this. It is needed for hidding hypervisor from guest and aimed to run Hyper-V nested in KVM. Signed-off-by: Vladislav A Yarmak --- target-i386/kvm.c | 4 1 file changed, 4 deletions(-) diff --git a/target-i386/kvm.c b/tar

[Qemu-devel] [PATCH RFC v7 6/7] qemu-iotests: s390x: fix test 051

2015-04-23 Thread Bo Tu
From: Xiao Guang Chen The tests for device type "ide_cd" should only be tested for the pc platform. The default device id of hard disk on the s390 platform differs to that of the x86 platform. A new variable device_id is defined and "virtio0" set for the s390 platform. A x86 platform specific out

Re: [Qemu-devel] [PATCH v2 RESEND 1/5] apic: Implement LAPIC low priority arbitration functions

2015-04-23 Thread Radim Krčmář
2015-04-06 17:45-0600, James Sullivan: > Currently, apic_get_arb_pri() is unimplemented and returns 0. > > Implemented apic_get_arb_pri() and added two helper functions > apic_compare_prio() and apic_lowest_prio() to be used for LAPIC > arbitration. > > Signed-off-by: James Sullivan > --- > +sta

Re: [Qemu-devel] [PATCH v6 07/21] hbitmap: add hbitmap_merge

2015-04-23 Thread Stefan Hajnoczi
On Fri, Apr 17, 2015 at 07:49:55PM -0400, John Snow wrote: > We add a bitmap merge operation to assist in error cases > where we wish to combine two bitmaps together. > > This is algorithmically O(bits) provided HBITMAP_LEVELS remains > constant. For a full bitmap on a 64bit machine: > sum(bits/64

Re: [Qemu-devel] [Qemu-block] [PATCH v6 10/21] qmp: Add support of "dirty-bitmap" sync mode for drive-backup

2015-04-23 Thread Stefan Hajnoczi
On Fri, Apr 17, 2015 at 07:49:58PM -0400, John Snow wrote: > For "dirty-bitmap" sync mode, the block job will iterate through the > given dirty bitmap to decide if a sector needs backup (backup all the > dirty clusters and skip clean ones), just as allocation conditions of > "top" sync mode. > > S

Re: [Qemu-devel] About address mapping between host and guest in QEMU

2015-04-23 Thread Wenjie Liu
Can anybody take a few minutes to answer my question? 2015-04-22 23:26 GMT+08:00 Wenjie Liu : > In http://vm-kernel.org/blog/2009/07/10/qemu-internal-part-2-softmmu/, > the following equation is mentioned. > host_virtual_address = phys_ram_base(qemu variable) + > guest_physical_address – guest_ph

Re: [Qemu-devel] [Qemu-block] [PATCH v6 15/21] block: Resize bitmaps on bdrv_truncate

2015-04-23 Thread Stefan Hajnoczi
On Fri, Apr 17, 2015 at 07:50:03PM -0400, John Snow wrote: > Signed-off-by: John Snow > --- > block.c| 18 ++ > include/qemu/hbitmap.h | 10 ++ > util/hbitmap.c | 48 > 3 files changed, 76 insertions(

Re: [Qemu-devel] About address mapping between host and guest in QEMU

2015-04-23 Thread Peter Maydell
On 23 April 2015 at 14:56, Wenjie Liu wrote: > Can anybody take a few minutes to answer my question? It might help if you explained at a higher level what you're trying to achieve. Usually you don't need to manually try to do this conversion from guest to host address because there is an API whic

Re: [Qemu-devel] [PATCH v2 0/9] target-arm: EL3 trap support

2015-04-23 Thread Greg Bellows
On Thu, Apr 23, 2015 at 5:10 AM, Peter Maydell wrote: > On 23 April 2015 at 04:37, Edgar E. Iglesias > wrote: > > I had a comment on the trapping of WFX, I recall not checking for > > has_work was causing a lot of exception round-trips when running > > XEN. To the point were things almost stoppe

  1   2   3   >