On 23/04/2015 14:19, Dr. David Alan Gilbert wrote: >> > So that means the bdrv_start_replication and bdrv_stop_replication >> > callbacks are more or less redundant, at least on the primary? >> > >> > In fact, who calls them? Certainly nothing in this patch set... >> > :) > In the main colo set (I'm looking at the February version) there > are calls to them, the 'stop_replication' is called at failover time. > > Here is I think the later version: > http://lists.nongnu.org/archive/html/qemu-devel/2015-03/msg05391.html
I think the primary shouldn't do any I/O after failover (and the secondary should close the NBD server) so it is probably okay to ignore the removal for now. Inserting the filter dynamically is probably needed though. Paolo
