[Qemu-devel] [Bug 1444081] Re: x86_64 heavy crash on PPC 64 host

2015-04-16 Thread thh
Ok, if everything is working fine with rc3, please close this bug ticket again. Concerning your OT question, you should better ask such stuff on one of the QEMU mailing lists (http://qemu-project.org/MailingLists). But yes, as far as I know, there's some work going on to implement this feature (se

Re: [Qemu-devel] [PATCH qemu v6 04/15] vfio: spapr: Move SPAPR-related code to a separate file

2015-04-16 Thread Thomas Huth
Am Sat, 11 Apr 2015 01:24:33 +1000 schrieb Alexey Kardashevskiy : > This moves SPAPR bits to a separate file to avoid pollution of x86 code. > > This is a mechanical patch. > > Signed-off-by: Alexey Kardashevskiy > Reviewed-by: David Gibson > --- > hw/vfio/Makefile.objs | 1 + > hw/

Re: [Qemu-devel] virtio-blk and virtio-scsi performance comparison

2015-04-16 Thread Paolo Bonzini
On 16/04/2015 03:27, Fam Zheng wrote: > > virtio-scsi, on the other hand, provides more features and means to be more > scalable (you won't need to painfully mess with pci bridges to attach 1000 > disks). > > Anyway, we are working on improving virtio-scsi performance, although it's > theoretic

Re: [Qemu-devel] [PATCH 1/2] q35: implement SMRAM.D_LCK

2015-04-16 Thread Michael S. Tsirkin
On Wed, Apr 15, 2015 at 04:12:00PM +0200, Gerd Hoffmann wrote: > Hi, > > > > d->config[MCH_HOST_BRIDGE_SMRAM] = MCH_HOST_BRIDGE_SMRAM_DEFAULT; > > > +d->wmask[MCH_HOST_BRIDGE_SMRAM] = 0xff; > > > > Is this right? I see a bunch of reserved bits etc there. > > Restores the state we had

Re: [Qemu-devel] [PATCH 1/2] q35: implement SMRAM.D_LCK

2015-04-16 Thread Paolo Bonzini
On 15/04/2015 15:58, Gerd Hoffmann wrote: > The "A Tour Beyond BIOS Implementing S3 Resume with EDKII" white paper > lists "Lock SMM. This must be done to maintain SMM integrity." as todo > list item for the edk2 resume code path (page 18). > > So it seems to me it is the job of the firmware to

Re: [Qemu-devel] [Qemu-block] [PATCH 2/6] block: allow block jobs in any arbitrary node

2015-04-16 Thread Alberto Garcia
On Wed 15 Apr 2015 05:22:13 PM CEST, Max Reitz wrote: >> diff --git a/block/mirror.c b/block/mirror.c >> index 4056164..189e8f8 100644 >> --- a/block/mirror.c >> +++ b/block/mirror.c >> @@ -607,8 +607,9 @@ static void mirror_complete(BlockJob *job, Error **errp) >> return; >> } >>

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-16 Thread Leon Alrae
On 15/04/2015 17:08, Liviu Ionescu wrote: > >> On 15 Apr 2015, at 15:49, Leon Alrae wrote: >> >> ... If there aren't any objections for the proposed solution, then let's >> just cook up the patch. > > the changes related to moving --semihosting-cmdline to the end of the line > are in: > > gi

Re: [Qemu-devel] [Qemu-block] [PATCH 4/6] block: Support streaming to an intermediate layer

2015-04-16 Thread Alberto Garcia
On Wed 15 Apr 2015 06:09:18 PM CEST, Max Reitz wrote: >> +orig_bs_flags = bdrv_get_flags(bs); >> +if (!(orig_bs_flags & BDRV_O_RDWR)) { > > I feel like we don't want to do this if we're not streaming to an > intermediate layer but to the top layer (because that means there is > some reason

Re: [Qemu-devel] [PATCH qemu v6 07/15] vfio: spapr: Add SPAPR IOMMU v2 support (DMA memory preregistering)

2015-04-16 Thread Thomas Huth
Am Sat, 11 Apr 2015 01:24:36 +1000 schrieb Alexey Kardashevskiy : > This makes use of the new "memory registering" feature. The idea is > to provide the userspace ability to notify the host kernel about pages > which are going to be used for DMA. Having this information, the host > kernel can pin

Re: [Qemu-devel] [PATCH] block: document block-stream in qmp-commands.hx

2015-04-16 Thread Stefan Hajnoczi
On Wed, Apr 15, 2015 at 03:08:30PM +0200, Max Reitz wrote: > On 15.04.2015 12:43, Stefan Hajnoczi wrote: > >The 'block-stream' QMP command is documented in block-core.json but not > >qmp-commands.hx. Add a summary of the command to qmp-commands.hx > >(similar to the documentation for 'block-commit

Re: [Qemu-devel] [PATCH qemu v6 10/15] spapr_pci_vfio: Remove unnecessary cast to sPAPRPHBVFIOState

2015-04-16 Thread Thomas Huth
Am Sat, 11 Apr 2015 01:24:39 +1000 schrieb Alexey Kardashevskiy : > EEH handlers only need AddressSpace to get to the right VFIO container > to call ioctl() so remove unnecessary cast of sPAPRPHBState to > sPAPRPHBVFIOState. > > Signed-off-by: Alexey Kardashevskiy > --- > hw/ppc/spapr_pci_vfio.

Re: [Qemu-devel] [PATCH qemu v6 08/15] spapr_iommu: Introduce "enabled" state for TCE table

2015-04-16 Thread Thomas Huth
Am Sat, 11 Apr 2015 01:24:37 +1000 schrieb Alexey Kardashevskiy : > Currently TCE tables are created once at start and their size never > changes. We are going to change that by introducing a Dynamic DMA windows > support where DMA configuration may change during the guest execution. > > This cha

Re: [Qemu-devel] [Question]Support of China loogson processor

2015-04-16 Thread Leon Alrae
On 15/04/2015 10:35, James Hogan wrote: > On 13/04/15 12:29, vt wrote: >> Hi, guys >> >> I saw the architecture code about mips in the qemu and kvm modules, so it is >> no doubt that mips cpu can be supported. >> But I wonder if anyone have used qemu/kvm virtualization with China loongson >> pr

Re: [Qemu-devel] virtio-blk and virtio-scsi performance comparison

2015-04-16 Thread Konstantin Krotov
16.04.2015 04:27, Fam Zheng пишет: On Wed, 04/15 11:17, Konstantin Krotov wrote: Hello list! I performed tests with fio and obtained results: *** virtio-scsi with cache=none, io=threads, blok device is md-device from mdadm raid1, random r/w, 32 thread from guest (debian, kernel 3.16): fio f

Re: [Qemu-devel] virtio-blk and virtio-scsi performance comparison

2015-04-16 Thread Paolo Bonzini
On 16/04/2015 13:17, Konstantin Krotov wrote: > In my production system i'm interested to use io=thread, becouse i > export MD raid1 devices to guest's and i need to read from the MD device > performs balanced between raid1 legs (it's true only if io=thread). Can you detail the problem more? Tha

Re: [Qemu-devel] [Question]Support of China loogson processor

2015-04-16 Thread Paolo Bonzini
On 16/04/2015 13:07, Leon Alrae wrote: > Since I also haven't had a chance to test Loongson emulation, I thought > I'd give it a try (TCG only, Loongson-2E cpu and fulong2e machine). > > Good news is that I'm able to get to the login prompt using ancient QEMU > v1.0, kernel 2.6.33 (with addition

[Qemu-devel] [PATCH for-2.4 03/10] block/iscsi: rename iscsi_write_protected and let it return void

2015-04-16 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/iscsi.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 6cf7e99..221c9fc 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1253,11 +1253,11 @@ static void iscsi_attach_aio_context(BlockDriver

[Qemu-devel] [PATCH for-2.4 02/10] block/iscsi: change all iscsilun properties from uint8_t to bool

2015-04-16 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/iscsi.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index be8af46..6cf7e99 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -57,9 +57,6 @@ typedef struct IscsiLun { int events; QE

[Qemu-devel] [PATCH for-2.4 00/10] various improvements for the iSCSI driver

2015-04-16 Thread Peter Lieven
Peter Lieven (10): block/iscsi: do not forget to logout from target block/iscsi: change all iscsilun properties from uint8_t to bool block/iscsi: rename iscsi_write_protected and let it return void block/iscsi: store DPOFUA bit from the modesense command block/iscsi: optimize WRITE10/16 i

[Qemu-devel] [PATCH for-2.4 01/10] block/iscsi: do not forget to logout from target

2015-04-16 Thread Peter Lieven
We actually were always impolitely dropping the connection and not cleanly logging out. CC: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven --- block/iscsi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index ba33290..be8af46 100644 --- a/block/iscsi

[Qemu-devel] [PATCH for-2.4 04/10] block/iscsi: store DPOFUA bit from the modesense command

2015-04-16 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/iscsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index 221c9fc..237faa1 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -66,6 +66,7 @@ typedef struct IscsiLun { bool write_protected; bool lbpme; boo

[Qemu-devel] [PATCH for-2.4 06/10] block/iscsi: increase retry count

2015-04-16 Thread Peter Lieven
The idea is that a command is retried in a BUSY condition up a time of approx. 60 seconds before it is failed. This should be far higher than any command timeout in the guest. Signed-off-by: Peter Lieven --- block/iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/

[Qemu-devel] [PATCH for-2.4 09/10] block/iscsi: bump year in copyright notice

2015-04-16 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index 3d0ffeb..04c1309 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -2,7 +2,7 @@ * QEMU Block driver for iSCSI images * * Copyright (c) 2010-2

[Qemu-devel] [PATCH for-2.4 08/10] block/iscsi: handle SCSI_STATUS_TASK_SET_FULL

2015-04-16 Thread Peter Lieven
a target may issue a SCSI_STATUS_TASK_SET_FULL status if there is more than one "BUSY" command queued already. Signed-off-by: Peter Lieven --- block/iscsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index a4902ea..3d0ffeb 100644 --- a/b

[Qemu-devel] [PATCH for-2.4 07/10] block/iscsi: bump libiscsi requirement to 1.10.0

2015-04-16 Thread Peter Lieven
We need this to support SCSI_STATUS_TASK_SET_FULL. Signed-off-by: Peter Lieven --- configure | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 6969f6f..f73b8d0 100755 --- a/configure +++ b/configure @@ -3630,15 +3630,15 @@ if compile_prog "" ""

[Qemu-devel] [PATCH for-2.4 10/10] block/iscsi: use the allocationmap also if cache.direct=on

2015-04-16 Thread Peter Lieven
the allocationmap has only a hint character. The driver always double checks that blocks marked unallocated in the cache are still unallocated before taking the fast path and return zeroes. So using the allocationmap is migration safe and can also be enabled with cache.direct=on. Signed-off-by: Pe

[Qemu-devel] [PATCH for-2.4 05/10] block/iscsi: optimize WRITE10/16 if cache.writeback is not set

2015-04-16 Thread Peter Lieven
SCSI allowes to tell the target to not return from a write command if the date is not written to the disk. Use this so called FUA bit if it is supported to optimize WRITE commands if writeback is not allowed. In this case qemu always issues a WRITE followed by a FLUSH. This is 2 round trip times.

Re: [Qemu-devel] [Qemu-block] [PATCH 4/6] block: Support streaming to an intermediate layer

2015-04-16 Thread Eric Blake
On 04/16/2015 03:36 AM, Alberto Garcia wrote: > On Wed 15 Apr 2015 06:09:18 PM CEST, Max Reitz wrote: > >>> +orig_bs_flags = bdrv_get_flags(bs); >>> +if (!(orig_bs_flags & BDRV_O_RDWR)) { >> >> I feel like we don't want to do this if we're not streaming to an >> intermediate layer but to t

Re: [Qemu-devel] [Qemu-block] [PATCH 4/6] block: Support streaming to an intermediate layer

2015-04-16 Thread Alberto Garcia
On Thu 16 Apr 2015 02:27:39 PM CEST, Eric Blake wrote: +orig_bs_flags = bdrv_get_flags(bs); +if (!(orig_bs_flags & BDRV_O_RDWR)) { >>> >>> I feel like we don't want to do this if we're not streaming to an >>> intermediate layer but to the top layer (because that means there is >>

Re: [Qemu-devel] [PATCH for-2.4 07/10] block/iscsi: bump libiscsi requirement to 1.10.0

2015-04-16 Thread Paolo Bonzini
On 16/04/2015 14:18, Peter Lieven wrote: > We need this to support SCSI_STATUS_TASK_SET_FULL. Any reason apart from the missing constant? Paolo > Signed-off-by: Peter Lieven > --- > configure | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/configure b/configur

Re: [Qemu-devel] [PATCH for-2.4 05/10] block/iscsi: optimize WRITE10/16 if cache.writeback is not set

2015-04-16 Thread Paolo Bonzini
On 16/04/2015 14:18, Peter Lieven wrote: > SCSI allowes to tell the target to not return from a write command > if the date is not written to the disk. Use this so called FUA > bit if it is supported to optimize WRITE commands if writeback is > not allowed. > > In this case qemu always issues a

Re: [Qemu-devel] [PATCH for-2.4 00/10] various improvements for the iSCSI driver

2015-04-16 Thread Paolo Bonzini
On 16/04/2015 14:18, Peter Lieven wrote: > Peter Lieven (10): > block/iscsi: do not forget to logout from target > block/iscsi: change all iscsilun properties from uint8_t to bool > block/iscsi: rename iscsi_write_protected and let it return void > block/iscsi: store DPOFUA bit from the m

Re: [Qemu-devel] [PATCH for-2.4 07/10] block/iscsi: bump libiscsi requirement to 1.10.0

2015-04-16 Thread Peter Lieven
Am 16.04.2015 um 14:33 schrieb Paolo Bonzini: On 16/04/2015 14:18, Peter Lieven wrote: We need this to support SCSI_STATUS_TASK_SET_FULL. Any reason apart from the missing constant? No, but I wanted to avoid starting checking for constants that were added shortly after this. You can't check

Re: [Qemu-devel] [PATCH v3 7/7] poll-linux: Add timerfd support

2015-04-16 Thread Stefan Hajnoczi
On Thu, Apr 16, 2015 at 12:57:36PM +0800, Fam Zheng wrote: > +static int qemu_poll_timerfd(QEMUPoll *qpoll, int64_t timeout_ns) > +{ > +int r; > +struct itimerspec its = { { 0 } }; > + > +if (timeout_ns > 0) { > +its.it_value.tv_sec = timeout_ns / 10LL; > +its.it

Re: [Qemu-devel] [PATCH for-2.4 05/10] block/iscsi: optimize WRITE10/16 if cache.writeback is not set

2015-04-16 Thread Peter Lieven
Am 16.04.2015 um 14:42 schrieb Paolo Bonzini: On 16/04/2015 14:18, Peter Lieven wrote: SCSI allowes to tell the target to not return from a write command if the date is not written to the disk. Use this so called FUA bit if it is supported to optimize WRITE commands if writeback is not allowed.

Re: [Qemu-devel] [PATCH v3 0/7] aio: Support epoll by introducing qemu_poll abstraction

2015-04-16 Thread Stefan Hajnoczi
On Thu, Apr 16, 2015 at 12:57:29PM +0800, Fam Zheng wrote: > v3: Rebase to master for 2.4. > Although epoll_pwait1 syscall is still being worked on [1], the QEMU part > (if any) will base on this, so let's merge it first. > > That part is not included in this version because I'm st

Re: [Qemu-devel] [PATCH for-2.4 05/10] block/iscsi: optimize WRITE10/16 if cache.writeback is not set

2015-04-16 Thread Paolo Bonzini
On 16/04/2015 15:02, Peter Lieven wrote: >>> >> Also, I think it is iscsi_co_generic_cb that should set >> force_next_flush, so that it is only set on failure. Not really for the >> optimization value, but because it's clearer. > > I don't get what you mean with it should only "set on failure".

Re: [Qemu-devel] [PATCH for-2.4 07/10] block/iscsi: bump libiscsi requirement to 1.10.0

2015-04-16 Thread Paolo Bonzini
On 16/04/2015 14:58, Peter Lieven wrote: >> >> On 16/04/2015 14:18, Peter Lieven wrote: >>> We need this to support SCSI_STATUS_TASK_SET_FULL. >> Any reason apart from the missing constant? > > No, but I wanted to avoid starting checking for constants that were > added shortly after this. > You

[Qemu-devel] How to modify QEMU source to read the bus for SATA directly?

2015-04-16 Thread Peter Teoh
My objective is not to emulate the SATA disk in anyway, but to passthrough all command the guest OS (either Windows or Linux) issued directly to the underlying harddisk. Will the following parameters achieved that goal? ./x86_64-softmmu/qemu-system-x86_64 \ -drive file=...,if=none,id=mydisk \

Re: [Qemu-devel] [PATCH 0/5] Extend TPM support with a QEMU-external TPM

2015-04-16 Thread Igor Mammedov
On Wed, 15 Apr 2015 18:38:43 -0400 Stefan Berger wrote: > The following series of patches extends TPM support with an > external TPM that offers a Linux CUSE (character device in userspace) > interface. This TPM lets each VM access its own private vTPM. > The CUSE TPM supports suspend/resume and

Re: [Qemu-devel] How to modify QEMU source to read the bus for SATA directly?

2015-04-16 Thread Paolo Bonzini
On 16/04/2015 15:25, Peter Teoh wrote: > > Now my question is: Is it possible to modify the QEMU source code, or > pass in the correct parameters in the command line, so as provide direct > I/O access from the QEMU guest all the way to the underlying host's AHCI > sata bus (based on my AMD's h

[Qemu-devel] unknown keycodes

2015-04-16 Thread Daniel Moyle
Hello, I’m running OS X 10.5.10 running the X11 server XQuartz 2.7.7 (xorg-server 1.15.2). Qemu is running on freeBSD being transmitted to the local machine over SSH. Qemu version: QEMU PC emulator version 0.11.1, Copyright (c) 2003-2008 Fabrice Bellard. All keypresses seem to send the incorrect

[Qemu-devel] Unparking vCPU mechanism

2015-04-16 Thread Mohsin Kazmi
Hi Zhu, I am testing the hot unplug feature using your github branch 'cpu-hotplug'. It is working fine when first time I added and deleted cpu. But when I tried to add cpu second time, it showed me the following error: (qemu) device_add kvm64-x86_64-cpu,apic-id=1,id=cpu1 Duplic

[Qemu-devel] [Bug 1444081] Re: x86_64 heavy crash on PPC 64 host

2015-04-16 Thread luigiburdo
** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1444081 Title: x86_64 heavy crash on PPC 64 host Status in QEMU: Fix Released Bug descriptio

Re: [Qemu-devel] [PATCH 0/5] Extend TPM support with a QEMU-external TPM

2015-04-16 Thread Stefan Berger
On 04/16/2015 09:35 AM, Igor Mammedov wrote: On Wed, 15 Apr 2015 18:38:43 -0400 Stefan Berger wrote: The following series of patches extends TPM support with an external TPM that offers a Linux CUSE (character device in userspace) interface. This TPM lets each VM access its own private vTPM. T

[Qemu-devel] [PATCH for-2.4 V2 2/9] block/iscsi: change all iscsilun properties from uint8_t to bool

2015-04-16 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/iscsi.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index be8af46..6cf7e99 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -57,9 +57,6 @@ typedef struct IscsiLun { int events; QE

[Qemu-devel] [PATCH for-2.4 V2 0/9] various improvements for the iSCSI driver

2015-04-16 Thread Peter Lieven
v1->v2: - removed the requirement for libiscsi 1.10.0 [Paolo] - reworked to force_next_flush logic [Paolo] Peter Lieven (9): block/iscsi: do not forget to logout from target block/iscsi: change all iscsilun properties from uint8_t to bool block/iscsi: rename iscsi_write_protected and

[Qemu-devel] [PATCH for-2.4 V2 8/9] block/iscsi: bump year in copyright notice

2015-04-16 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index 328907b..8364f97 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -2,7 +2,7 @@ * QEMU Block driver for iSCSI images * * Copyright (c) 2010-2

[Qemu-devel] [PATCH for-2.4 V2 6/9] block/iscsi: increase retry count

2015-04-16 Thread Peter Lieven
The idea is that a command is retried in a BUSY condition up a time of approx. 60 seconds before it is failed. This should be far higher than any command timeout in the guest. Signed-off-by: Peter Lieven --- block/iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/

[Qemu-devel] [PATCH for-2.4 V2 4/9] block/iscsi: store DPOFUA bit from the modesense command

2015-04-16 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/iscsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index 221c9fc..237faa1 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -66,6 +66,7 @@ typedef struct IscsiLun { bool write_protected; bool lbpme; boo

[Qemu-devel] [PATCH for-2.4 V2 3/9] block/iscsi: rename iscsi_write_protected and let it return void

2015-04-16 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/iscsi.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 6cf7e99..221c9fc 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1253,11 +1253,11 @@ static void iscsi_attach_aio_context(BlockDriver

[Qemu-devel] [PATCH for-2.4 V2 5/9] block/iscsi: optimize WRITE10/16 if cache.writeback is not set

2015-04-16 Thread Peter Lieven
SCSI allowes to tell the target to not return from a write command if the date is not written to the disk. Use this so called FUA bit if it is supported to optimize WRITE commands if writeback is not allowed. In this case qemu always issues a WRITE followed by a FLUSH. This is 2 round trip times.

[Qemu-devel] [PATCH for-2.4 V2 7/9] block/iscsi: handle SCSI_STATUS_TASK_SET_FULL

2015-04-16 Thread Peter Lieven
a target may issue a SCSI_STATUS_TASK_SET_FULL status if there is more than one "BUSY" command queued already. Signed-off-by: Peter Lieven --- block/iscsi.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 5999f74..328907b 100644 ---

[Qemu-devel] [PATCH for-2.4 V2 1/9] block/iscsi: do not forget to logout from target

2015-04-16 Thread Peter Lieven
We actually were always impolitely dropping the connection and not cleanly logging out. CC: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven --- block/iscsi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index ba33290..be8af46 100644 --- a/block/iscsi

[Qemu-devel] [PATCH for-2.4 V2 9/9] block/iscsi: use the allocationmap also if cache.direct=on

2015-04-16 Thread Peter Lieven
the allocationmap has only a hint character. The driver always double checks that blocks marked unallocated in the cache are still unallocated before taking the fast path and return zeroes. So using the allocationmap is migration safe and can also be enabled with cache.direct=on. Signed-off-by: Pe

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-16 Thread Peter Maydell
On 15 April 2015 at 10:09, Liviu Ionescu wrote: > we currently have two solutions: > > - multiple: --semihosting-config arg="..." > - a single option, placed at the end, and followed by any number > of arguments: --semihosting-cmdline $@ \n > > both can generate the array of args required by UHI

Re: [Qemu-devel] How to modify QEMU source to read the bus for SATA directly?

2015-04-16 Thread Peter Teoh
On Thu, Apr 16, 2015 at 9:43 PM, Paolo Bonzini wrote: > > > On 16/04/2015 15:25, Peter Teoh wrote: > > > > Now my question is: Is it possible to modify the QEMU source code, or > > pass in the correct parameters in the command line, so as provide direct > > I/O access from the QEMU guest all th

Re: [Qemu-devel] [Qemu-block] [PATCH 4/6] block: Support streaming to an intermediate layer

2015-04-16 Thread Alberto Garcia
On Wed 15 Apr 2015 06:09:18 PM CEST, Max Reitz wrote: >> +orig_bs_flags = bdrv_get_flags(bs); >> +if (!(orig_bs_flags & BDRV_O_RDWR)) { > > I feel like we don't want to do this if we're not streaming to an > intermediate layer but to the top layer (because that means there is > some reaso

Re: [Qemu-devel] How to modify QEMU source to read the bus for SATA directly?

2015-04-16 Thread Paolo Bonzini
On 16/04/2015 16:26, Peter Teoh wrote: > > You can use PCI passthrough and let the guest use the whole SATA bus, if > you have another way to access other disks on the same bus (e.g. boot > from a USB stick or access the filesystems on NFS). > > Or you can use SCSI passthrough a

Re: [Qemu-devel] [Question]Support of China loogson processor

2015-04-16 Thread Leon Alrae
On 16/04/2015 13:02, Paolo Bonzini wrote: > > > On 16/04/2015 13:07, Leon Alrae wrote: >> Since I also haven't had a chance to test Loongson emulation, I thought >> I'd give it a try (TCG only, Loongson-2E cpu and fulong2e machine). >> >> Good news is that I'm able to get to the login prompt usin

[Qemu-devel] [PATCH 6/8] docs: Document how to stream to an intermediate layer

2015-04-16 Thread Alberto Garcia
Signed-off-by: Alberto Garcia --- docs/live-block-ops.txt | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/docs/live-block-ops.txt b/docs/live-block-ops.txt index a257087..3bf86be 100644 --- a/docs/live-block-ops.txt +++ b/docs/live-block-ops.tx

[Qemu-devel] [PATCH 8/8] qemu-iotests: test streaming to an intermediate layer

2015-04-16 Thread Alberto Garcia
This adds test_stream_intermediate(), similar to test_stream() but streams to the intermediate image instead. Signed-off-by: Alberto Garcia --- tests/qemu-iotests/030 | 18 +- tests/qemu-iotests/030.out | 4 ++-- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH 5/8] block: Add QMP support for streaming to an intermediate layer

2015-04-16 Thread Alberto Garcia
This patch makes the 'device' paramater of the 'block-stream' command accept a node name as well as a device name. In addition to that, operation blockers will be checked in all intermediate nodes between the top and the base node. Since qmp_block_stream() now uses the error from bdrv_lookup_bs()

[Qemu-devel] [PATCH 3/8] block: never cancel a streaming job without running stream_complete()

2015-04-16 Thread Alberto Garcia
We need to call stream_complete() in order to do all the necessary clean-ups, even if there's an early failure. At the moment it's only useful to make sure that s->backing_file_str is not leaked, but it will become more important as we introduce support for streaming to any intermediate node. Sign

[Qemu-devel] [PATCH 1/8] block: keep a list of block jobs

2015-04-16 Thread Alberto Garcia
The current way to obtain the list of existing block jobs is to iterate over all root nodes and check which ones own a job. Since we want to be able to support block jobs in other nodes as well, this patch keeps a list of jobs that is updated everytime one is created or destroyed. This also updat

[Qemu-devel] [PATCH v4 0/8] Support streaming to an intermediate layer

2015-04-16 Thread Alberto Garcia
New series. As I wrote in a separate e-mail, we don't need to have any additional checks on the top image before reopening it in R/W mode since bdrv_reopen_prepare() already takes care of checking the BDRV_O_ALLOW_RDWR flag, which serves our purpose. v4: - Refactor find_block_job to use the error

[Qemu-devel] [PATCH 2/8] block: allow block jobs in any arbitrary node

2015-04-16 Thread Alberto Garcia
Currently, block jobs can only be owned by root nodes. This patch allows block jobs to be in any arbitrary node, by making the following changes: - Block jobs can now be identified by the node name of their BlockDriverState in addition to the device name. Since both device and node names live

[Qemu-devel] [PATCH 4/8] block: Support streaming to an intermediate layer

2015-04-16 Thread Alberto Garcia
This makes sure that the image we are steaming into is open in read-write mode during the operation. Operation blockers are also set in all intermediate nodes, since they will be removed from the chain afterwards. Finally, this also unblocks the stream operation in backing files. Signed-off-by:

Re: [Qemu-devel] [Question]Support of China loogson processor

2015-04-16 Thread Paolo Bonzini
On 16/04/2015 17:05, Leon Alrae wrote: > On 16/04/2015 13:02, Paolo Bonzini wrote: >> >> >> On 16/04/2015 13:07, Leon Alrae wrote: >>> Since I also haven't had a chance to test Loongson emulation, I thought >>> I'd give it a try (TCG only, Loongson-2E cpu and fulong2e machine). >>> >>> Good news

[Qemu-devel] [PATCH 7/8] qemu-iotests: fix test_stream_partial()

2015-04-16 Thread Alberto Garcia
This test is streaming to the top layer using the intermediate image as the base. This is a mistake since block-stream never copies data from the base image and its backing chain, so this is effectively a no-op. In addition to fixing the base parameter, this patch also writes some data to the inte

[Qemu-devel] ARM: PCI devices emulation broken with KVM due to cache issue

2015-04-16 Thread Jérémy Fanguède
Hello, Attaching PCI devices to the virt model works fine with TCG, but fails once KVM is enabled. For instance, with this command line: ./qemu-system-arm -m 512 -machine type=virt \ -enable-kvm -cpu host \ -nographic \ -kernel zImage \ -drive if=none,file=ubuntu.img,id=fs,format=

Re: [Qemu-devel] ARM: PCI devices emulation broken with KVM due to cache issue

2015-04-16 Thread Paolo Bonzini
On 16/04/2015 17:54, Jérémy Fanguède wrote: > The guest kernel driver of the lsi device fails to enable it correctly > with a cache error: > [...] > sym53c8xx :00:01.0: enabling device (0100 -> 0103) > sym0: <895a> rev 0x0 at pci :00:01.0 irq 54 > sym0: No NVRAM, ID 7, Fast-40, LVD, parit

Re: [Qemu-devel] [PATCH qemu v6 04/15] vfio: spapr: Move SPAPR-related code to a separate file

2015-04-16 Thread Alexey Kardashevskiy
On 04/16/2015 05:50 PM, Thomas Huth wrote: Am Sat, 11 Apr 2015 01:24:33 +1000 schrieb Alexey Kardashevskiy : This moves SPAPR bits to a separate file to avoid pollution of x86 code. This is a mechanical patch. Signed-off-by: Alexey Kardashevskiy Reviewed-by: David Gibson --- hw/vfio/Makef

[Qemu-devel] ppc64 not resuming with v2.3.0-rc3

2015-04-16 Thread Stefan Berger
The culprit patch seems to be the following commit. If I remove these changes from the tip of the tree it works again (on SLOF level): commit 2360b6e84f78d41fa0f76555a947148b73645259 Author: Mark Cave-Ayland Date: Mon Feb 9 22:40:48 2015 + target-ppc: force update of msr bits in cpu_

Re: [Qemu-devel] driver enhancement for Intel IGD passthrough

2015-04-16 Thread Tian, Kevin
ping... > From: Tian, Kevin > Sent: Friday, April 10, 2015 10:33 AM > > Hi, > > We are working on Linux/Windows graphics driver enhancement to > remove those non-standard PCI resource accesses, e.g. to PCH/MCH > registers, in parallel with the ongoing effort from Tiejun on current > driver suppo

Re: [Qemu-devel] [[PATCH] 1/7] target-arm: Add exception target el infrastructure

2015-04-16 Thread Peter Maydell
On 27 March 2015 at 19:10, Greg Bellows wrote: > Add a CPU state exception target EL field that will be used for communicating > the EL to which an exception should be routed. > > Add a target EL argument to the generic exception helper for callers to > specify > the EL to which the exception sho

Re: [Qemu-devel] [[PATCH] 2/7] target-arm: Extend helpers to route exceptions

2015-04-16 Thread Peter Maydell
On 27 March 2015 at 19:10, Greg Bellows wrote: > Updated the various helper routines to set the target EL as needed. > > Signed-off-by: Greg Bellows > --- > target-arm/op_helper.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c > inde

Re: [Qemu-devel] [[PATCH] 3/7] target-arm: Update interrupt handling to use target EL

2015-04-16 Thread Peter Maydell
On 27 March 2015 at 19:10, Greg Bellows wrote: > Updated the interrupt handling to utilize and report through the target EL > exception field. This includes consolidating and cleaning up code where > needed. Target EL is now calculated once in arm_cpu_exec_interrupt() and > do_interrupt was updat

[Qemu-devel] [PATCH for-2.4 2/2] vfio-pci: Fix error path sign

2015-04-16 Thread Alex Williamson
This is an impossible error path due to the fact that we're reading a kernel provided, rather than user provided link, which will certainly always fit in PATH_MAX. Currently it returns a fixed 26 char path plus %d group number, which typically maxes out at double digits. However, the caller of the

Re: [Qemu-devel] [[PATCH] 5/7] target-arm: Add TTBR regime function and use

2015-04-16 Thread Peter Maydell
On 27 March 2015 at 19:10, Greg Bellows wrote: > Add a utility function for choosing the correct TTBR system register based on > the specified MMU index. Add use of function on physical address lookup. > @@ -5376,20 +5390,26 @@ static int get_phys_addr_lpae(CPUARMState *env, > target_ulong addre

Re: [Qemu-devel] [[PATCH] 6/7] target-arm: Add WFx syndrome function

2015-04-16 Thread Peter Maydell
On 27 March 2015 at 19:10, Greg Bellows wrote: > Adds a utility function for creating a WFx exception syndrome > > Signed-off-by: Greg Bellows > --- Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [[PATCH] 4/7] target-arm: Add AArch64 CPTR registers

2015-04-16 Thread Peter Maydell
On 27 March 2015 at 19:10, Greg Bellows wrote: > Adds CPTR_EL2/3 system registers definitions and access function. > > Signed-off-by: Greg Bellows > --- > target-arm/cpu.h| 18 +- > target-arm/helper.c | 43 ++- > 2 files changed, 59 in

Re: [Qemu-devel] [PATCH for-2.4 0/2] vfio-pci: Fixes for fixes

2015-04-16 Thread Laszlo Ersek
On 04/16/15 20:00, Alex Williamson wrote: > Fix a couple issues spotted by Laszlo in downstream review. Thanks, > > Alex > > --- > > Alex Williamson (2): > vfio-pci: Further fix BAR size overflow > vfio-pci: Fix error path sign > > > hw/vfio/pci.c |4 ++-- > 1 file changed, 2

Re: [Qemu-devel] [[PATCH] 7/7] target-arm: Add WFx instruction trap support

2015-04-16 Thread Peter Maydell
On 27 March 2015 at 19:10, Greg Bellows wrote: > Add support for trapping WFI and WFE instructions to the proper EL when > SCTLR/SCR/HCR settings apply. > > Signed-off-by: Greg Bellows > --- > target-arm/op_helper.c | 75 > +++--- > 1 file changed, 71

Re: [Qemu-devel] [PATCH v10] Support vhd type VHD_DIFFERENCING

2015-04-16 Thread John Baboval
Thank you for this patch. I found a few places where you have 32-bit integer overflows that result in failure. They are marked inline below. On 03/04/2015 09:18 AM, Xiaodong Gong wrote: diff --git a/block/vpc.c b/block/vpc.c index 46803b1..d9a8d19 100644 --- a/block/vpc.c +++ b/block/vpc.c @@

[Qemu-devel] [PATCH for-2.4 1/2] vfio-pci: Further fix BAR size overflow

2015-04-16 Thread Alex Williamson
In an analysis by Laszlo, the resulting type of our calculation for the end of the MSI-X table, and thus the start of memory after the table, is uint32_t. We're therefore not correctly preventing the corner case overflow that we intended to fix here where a BAR >=4G could place the MSI-X table to

[Qemu-devel] [PATCH for-2.4 0/2] vfio-pci: Fixes for fixes

2015-04-16 Thread Alex Williamson
Fix a couple issues spotted by Laszlo in downstream review. Thanks, Alex --- Alex Williamson (2): vfio-pci: Further fix BAR size overflow vfio-pci: Fix error path sign hw/vfio/pci.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH 0/5] Extend TPM support with a QEMU-external TPM

2015-04-16 Thread Michael S. Tsirkin
On Thu, Apr 16, 2015 at 03:35:06PM +0200, Igor Mammedov wrote: > On Wed, 15 Apr 2015 18:38:43 -0400 > Stefan Berger wrote: > > > The following series of patches extends TPM support with an > > external TPM that offers a Linux CUSE (character device in userspace) > > interface. This TPM lets each

Re: [Qemu-devel] [PATCH 0/5] Extend TPM support with a QEMU-external TPM

2015-04-16 Thread Stefan Berger
On 04/16/2015 02:55 PM, Michael S. Tsirkin wrote: On Thu, Apr 16, 2015 at 03:35:06PM +0200, Igor Mammedov wrote: On Wed, 15 Apr 2015 18:38:43 -0400 Stefan Berger wrote: The following series of patches extends TPM support with an external TPM that offers a Linux CUSE (character device in users

Re: [Qemu-devel] [Question]Support of China loogson processor

2015-04-16 Thread Leon Alrae
On 16/04/15 16:17, Paolo Bonzini wrote: > > > On 16/04/2015 17:05, Leon Alrae wrote: >> On 16/04/2015 13:02, Paolo Bonzini wrote: >>> >>> >>> On 16/04/2015 13:07, Leon Alrae wrote: Since I also haven't had a chance to test Loongson emulation, I thought I'd give it a try (TCG only, Loong

Re: [Qemu-devel] Missing interrupts on g3beige and mac99 machines

2015-04-16 Thread Mark Cave-Ayland
On 16/04/15 19:03, Cormac O'Brien wrote: > While trying to implement OS 9 support on QEMU, I've run into the following > errors from the operating system: > > g3beige: > *** MacOS: Fatal Error! (0xF3B37FDB) *** > Official Apple copyright message missing. >

Re: [Qemu-devel] [Question]Support of China loogson processor

2015-04-16 Thread Paolo Bonzini
On 16/04/2015 21:25, Leon Alrae wrote: > On 16/04/15 16:17, Paolo Bonzini wrote: >> >> >> On 16/04/2015 17:05, Leon Alrae wrote: >>> On 16/04/2015 13:02, Paolo Bonzini wrote: On 16/04/2015 13:07, Leon Alrae wrote: > Since I also haven't had a chance to test Loongson emulation,

Re: [Qemu-devel] ppc64 not resuming with v2.3.0-rc3

2015-04-16 Thread Mark Cave-Ayland
On 16/04/15 17:43, Stefan Berger wrote: > The culprit patch seems to be the following commit. If I remove these > changes from the tip of the tree it works again (on SLOF level): > > commit 2360b6e84f78d41fa0f76555a947148b73645259 > Author: Mark Cave-Ayland > Date: Mon Feb 9 22:40:48 2015 +000

Re: [Qemu-devel] ppc64 not resuming with v2.3.0-rc3

2015-04-16 Thread Stefan Berger
On 04/16/2015 03:42 PM, Mark Cave-Ayland wrote: On 16/04/15 17:43, Stefan Berger wrote: The culprit patch seems to be the following commit. If I remove these changes from the tip of the tree it works again (on SLOF level): commit 2360b6e84f78d41fa0f76555a947148b73645259 Author: Mark Cave-Aylan

Re: [Qemu-devel] ppc64 not resuming with v2.3.0-rc3

2015-04-16 Thread Mark Cave-Ayland
On 16/04/15 20:49, Stefan Berger wrote: >> H the fix is correct in that internal MSR variables need to be >> updated post-restore (as noted in the message above it was the exception >> prefix variables that weren't updated by having MSR_EP set). >> >> Maybe on ppc64 there is another bit similar

Re: [Qemu-devel] [[PATCH] 3/7] target-arm: Update interrupt handling to use target EL

2015-04-16 Thread Greg Bellows
On Thu, Apr 16, 2015 at 12:52 PM, Peter Maydell wrote: > On 27 March 2015 at 19:10, Greg Bellows wrote: > > Updated the interrupt handling to utilize and report through the target > EL > > exception field. This includes consolidating and cleaning up code where > > needed. Target EL is now calcu

Re: [Qemu-devel] ppc64 not resuming with v2.3.0-rc3

2015-04-16 Thread Stefan Berger
On 04/16/2015 04:53 PM, Mark Cave-Ayland wrote: On 16/04/15 20:49, Stefan Berger wrote: H the fix is correct in that internal MSR variables need to be updated post-restore (as noted in the message above it was the exception prefix variables that weren't updated by having MSR_EP set). Maybe

Re: [Qemu-devel] [[PATCH] 3/7] target-arm: Update interrupt handling to use target EL

2015-04-16 Thread Peter Maydell
On 16 April 2015 at 22:03, Greg Bellows wrote: > > > On Thu, Apr 16, 2015 at 12:52 PM, Peter Maydell > wrote: >> >> On 27 March 2015 at 19:10, Greg Bellows wrote: >> > Updated the interrupt handling to utilize and report through the target >> > EL >> > exception field. This includes consolidati

Re: [Qemu-devel] [PATCH] vhost: fix log base address

2015-04-16 Thread Paolo Bonzini
On 15/04/2015 11:56, zhanghailiang wrote: > On 2015/4/15 17:37, Michael S. Tsirkin wrote: >> VHOST_SET_LOG_BASE got an incorrect address, causing >> migration errors and potentially even memory corruption. >> >> Cc: Peter Maydell >> Reported-by: Wen Congyang >> Signed-off-by: Michael S. Tsirkin

Re: [Qemu-devel] [[PATCH] 1/7] target-arm: Add exception target el infrastructure

2015-04-16 Thread Greg Bellows
On Thu, Apr 16, 2015 at 12:50 PM, Peter Maydell wrote: > On 27 March 2015 at 19:10, Greg Bellows wrote: > > Add a CPU state exception target EL field that will be used for > communicating > > the EL to which an exception should be routed. > > > > Add a target EL argument to the generic exception

  1   2   >