Re: [Qemu-devel] cpu modelling and hotplug

2015-04-08 Thread Christian Borntraeger
Am 07.04.2015 um 17:07 schrieb Igor Mammedov: >> >> power >> - Topology possible >>- interfaces to query topology? > ? I wanted to say: I forgot all the details about topology > >> - SMT: Power8: no threads in host and full core passed in due to HW >> design may change in the future >> >> s/

Re: [Qemu-devel] [PATCH v2 1/4] blockjob: Allow nested pause

2015-04-08 Thread Alberto Garcia
On Fri, Apr 03, 2015 at 10:05:18PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > block/mirror.c | 2 +- > blockdev.c | 8 +--- > blockjob.c | 23 +-- > include/block/blockjob.h | 20 > 4 files chang

Re: [Qemu-devel] [PATCH v6 00/36] drop qapi nested structs

2015-04-08 Thread Alberto Garcia
On Mon, Apr 06, 2015 at 07:13:28AM -0600, Eric Blake wrote: > My apologies - I mis-typed Berto's email address, so if you > reply-to-all, you'll get a bounce message if you don't manually fix > it. Is it worth me resending the series with an updated CC list? For me it's not necessary, but thanks

Re: [Qemu-devel] [PATCH qemu] qemu-options: Add documentation about PPC64's "-cpu compat" option

2015-04-08 Thread Alexey Kardashevskiy
On 04/08/2015 04:29 PM, Alexander Graf wrote: Am 08.04.2015 um 03:45 schrieb Alexey Kardashevskiy : On 04/08/2015 06:43 AM, Alexander Graf wrote: On 04/02/2015 08:26 AM, Alexey Kardashevskiy wrote: Since 8dfa3a5e "target-ppc: Add "compat" CPU option" (which was a part of client-architectur

Re: [Qemu-devel] [PATCH qemu] qemu-options: Add documentation about PPC64's "-cpu compat" option

2015-04-08 Thread Alexander Graf
> Am 08.04.2015 um 09:41 schrieb Alexey Kardashevskiy : > >> On 04/08/2015 04:29 PM, Alexander Graf wrote: >> >> >> Am 08.04.2015 um 03:45 schrieb Alexey Kardashevskiy : > On 04/08/2015 06:43 AM, Alexander Graf wrote: > On 04/02/2015 08:26 AM, Alexey Kardashevskiy wrote: >

Re: [Qemu-devel] [Migration Bug? ] Occasionally, the content of VM's memory is inconsistent between Source and Destination of migration

2015-04-08 Thread Jason Wang
On 04/03/2015 05:20 PM, zhanghailiang wrote: > On 2015/4/3 16:51, Jason Wang wrote: >> >> >> On 04/02/2015 07:52 PM, zhanghailiang wrote: >>> On 2015/4/1 3:06, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > On 2015/3/30 15:59, Dr. David Alan Gilbe

Re: [Qemu-devel] [PATCH V5 16/18] virtio-pci: increase the maximum number of virtqueues to 513

2015-04-08 Thread Jason Wang
On 04/08/2015 12:54 AM, Alexander Graf wrote: > On 04/01/2015 10:15 AM, Jason Wang wrote: >> This patch increases the maximum number of virtqueues for pci from 64 >> to 513. This will allow booting a virtio-net-pci device with 256 queue >> pairs. >> >> To keep migration compatibility, 64 was kept

Re: [Qemu-devel] [PATCH V5 16/18] virtio-pci: increase the maximum number of virtqueues to 513

2015-04-08 Thread Alexander Graf
> Am 08.04.2015 um 10:10 schrieb Jason Wang : > > > >> On 04/08/2015 12:54 AM, Alexander Graf wrote: >>> On 04/01/2015 10:15 AM, Jason Wang wrote: >>> This patch increases the maximum number of virtqueues for pci from 64 >>> to 513. This will allow booting a virtio-net-pci device with 256 que

Re: [Qemu-devel] [RFC PATCH v4 00/28] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service

2015-04-08 Thread zhanghailiang
Hi, ping ... The main blocked bugs for COLO have been solved, we also have finished some new features and optimization on COLO. (If you are interested in this, we can send them to you in private ;)) For easy of review, it is better to keep it simple now, so we will not add too much new codes

Re: [Qemu-devel] [PATCH V5 16/18] virtio-pci: increase the maximum number of virtqueues to 513

2015-04-08 Thread Jason Wang
On Wed, Apr 8, 2015 at 2:06 AM, Luigi Rizzo wrote: On Tue, Apr 7, 2015 at 6:54 PM, Alexander Graf wrote: On 04/01/2015 10:15 AM, Jason Wang wrote: This patch increases the maximum number of virtqueues for pci from 64 to 513. This will allow booting a virtio-net-pci device with 256 queue

Re: [Qemu-devel] [PATCH V5 16/18] virtio-pci: increase the maximum number of virtqueues to 513

2015-04-08 Thread Jason Wang
On Wed, Apr 8, 2015 at 2:33 AM, Alexander Graf wrote: On 04/07/2015 08:06 PM, Luigi Rizzo wrote: On Tue, Apr 7, 2015 at 6:54 PM, Alexander Graf wrote: On 04/01/2015 10:15 AM, Jason Wang wrote: This patch increases the maximum number of virtqueues for pci from 64 to 513. This will allow b

Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags

2015-04-08 Thread Paolo Bonzini
On 07/04/2015 22:46, Eduardo Habkost wrote: > This uses the feature name arrays to register "feat-*" QOM properties > for feature flags. This simply adds the properties so they can be > configured using -global, but doesn't change x86_cpu_parse_featurestr() > to use them yet. Out of curiosity, w

Re: [Qemu-devel] [PATCH V5 16/18] virtio-pci: increase the maximum number of virtqueues to 513

2015-04-08 Thread Jason Wang
On Wed, Apr 8, 2015 at 4:13 PM, Alexander Graf wrote: Am 08.04.2015 um 10:10 schrieb Jason Wang : On 04/08/2015 12:54 AM, Alexander Graf wrote: On 04/01/2015 10:15 AM, Jason Wang wrote: This patch increases the maximum number of virtqueues for pci from 64 to 513. This will al

Re: [Qemu-devel] [PATCH 1/6] target-i386: Move error handling to end of x86_cpu_parse_featurestr()

2015-04-08 Thread Paolo Bonzini
On 07/04/2015 22:46, Eduardo Habkost wrote: > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 03b33cf..f83d586 100644 > --- a/target-i386/cpu.c > +++ b/target

Re: [Qemu-devel] [PATCH 5/6] target-i386: X86CPU::xlevel2 QOM property

2015-04-08 Thread Paolo Bonzini
On 07/04/2015 22:46, Eduardo Habkost wrote: > We already have "level" and "xlevel", only "xlevel2" is missing. > > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index

Re: [Qemu-devel] [Qemu-block] [PATCH] block/iscsi: handle zero events from iscsi_which_events

2015-04-08 Thread Stefan Hajnoczi
On Tue, Apr 7, 2015 at 9:08 PM, Peter Lieven wrote: Please CC qemu-devel@nongnu.org in the future. All patches must be on the qemu-devel mailing list so they can be merged (for transparency). I have added qemu-devel to CC. > +/* newer versions of libiscsi may return zero events. In this > +

Re: [Qemu-devel] [PATCH V5 16/18] virtio-pci: increase the maximum number of virtqueues to 513

2015-04-08 Thread Alexander Graf
On 08.04.15 10:29, Jason Wang wrote: > > > On Wed, Apr 8, 2015 at 2:33 AM, Alexander Graf wrote: >> On 04/07/2015 08:06 PM, Luigi Rizzo wrote: >>> >>> >>> On Tue, Apr 7, 2015 at 6:54 PM, Alexander Graf wrote: On 04/01/2015 10:15 AM, Jason Wang wrote: > This patch increases the maximu

Re: [Qemu-devel] [Qemu-block] [PATCH v4 15/20] block: Resize bitmaps on bdrv_truncate

2015-04-08 Thread Stefan Hajnoczi
On Tue, Apr 07, 2015 at 12:45:30PM -0400, John Snow wrote: > > > On 04/07/2015 08:57 AM, Stefan Hajnoczi wrote: > >On Thu, Apr 02, 2015 at 11:57:59AM -0400, John Snow wrote: > >> > >> > >>On 04/02/2015 09:37 AM, Stefan Hajnoczi wrote: > >>>On Fri, Mar 20, 2015 at 03:16:58PM -0400, John Snow wrote

Re: [Qemu-devel] [PATCH V5 16/18] virtio-pci: increase the maximum number of virtqueues to 513

2015-04-08 Thread Jason Wang
On Wed, Apr 8, 2015 at 4:41 PM, Alexander Graf wrote: On 08.04.15 10:29, Jason Wang wrote: On Wed, Apr 8, 2015 at 2:33 AM, Alexander Graf wrote: On 04/07/2015 08:06 PM, Luigi Rizzo wrote: On Tue, Apr 7, 2015 at 6:54 PM, Alexander Graf wrote: On 04/01/2015 10:15 AM, Jason Wan

[Qemu-devel] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED

2015-04-08 Thread Alberto Garcia
Since this event can occur in nodes that cannot have a device name associated, include also a field with the node name. Signed-off-by: Alberto Garcia --- block/qcow2.c | 8 ++-- docs/qmp/qmp-events.txt | 21 + qapi/block-core.json| 17 +++-- 3 f

[Qemu-devel] [PATCH 2/3] block: use bdrv_get_device_or_node_name() in error messages

2015-04-08 Thread Alberto Garcia
There are several error messages that identify a BlockDriverState by its device name. However those errors can be produced in nodes that don't have a device name associated. In those cases we should use bdrv_get_device_or_node_name() to fall back to the node name and produce a more meaningful mess

[Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name()

2015-04-08 Thread Alberto Garcia
This function gets the device name associated with a BlockDriverState, or its node name if the device name is empty. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block.c | 9 + block/quorum.c| 5 + include/block/block.h | 1 + 3 files changed, 11 in

Re: [Qemu-devel] [PATCH for-2.3 v2] qcow2: Fix header update with overridden backing file

2015-04-08 Thread Stefan Hajnoczi
On Tue, Apr 07, 2015 at 03:03:16PM +0200, Kevin Wolf wrote: > In recent qemu versions, it is possible to override the backing file > name and format that is stored in the image file with values given at > runtime. In such cases, the temporary override could end up in the > image header if the qcow2

[Qemu-devel] [PATCH v4 0/3] Add bdrv_get_device_or_node_name()

2015-04-08 Thread Alberto Garcia
This series contains a couple of minor changes suggested by Markus in the previous one. I removed the Reviewed-by line by Max in the modified patch even if the changes are small, hope that's ok. v4: - Fix documentation of the 'node-name' field in BLOCK_IMAGE_CORRUPTED. Its annotation is now (jso

[Qemu-devel] [PATCH qemu v2] qemu-options: Add documentation about PPC64's "-cpu compat" option

2015-04-08 Thread Alexey Kardashevskiy
Since 8dfa3a5e "target-ppc: Add "compat" CPU option" (which was a part of client-architecture-support patchset) there is a "compat" option of "-cpu". However it was not documented at all and this is what this patch is trying to do. Signed-off-by: Alexey Kardashevskiy --- After the patch: [aik@v

Re: [Qemu-devel] [PATCH v2 for-2.3] virtio-blk: correctly dirty guest memory

2015-04-08 Thread Stefan Hajnoczi
On Tue, Apr 7, 2015 at 3:11 PM, Stefan Hajnoczi wrote: > On Thu, Apr 02, 2015 at 07:50:44PM +0200, Paolo Bonzini wrote: >> After qemu_iovec_destroy, the QEMUIOVector's size is zeroed and >> the zero size ultimately is used to compute virtqueue_push's len >> argument. Therefore, reads from virtio-

Re: [Qemu-devel] [PATCH v2 for-2.3] virtio-blk: correctly dirty guest memory

2015-04-08 Thread Stefan Hajnoczi
On Thu, Apr 02, 2015 at 07:50:44PM +0200, Paolo Bonzini wrote: > After qemu_iovec_destroy, the QEMUIOVector's size is zeroed and > the zero size ultimately is used to compute virtqueue_push's len > argument. Therefore, reads from virtio-blk devices did not > migrate their results correctly. (Writ

Re: [Qemu-devel] [PATCH v6 0/8] QEMU memory hot unplug support

2015-04-08 Thread Zhu Guihua
Ping... On 04/02/2015 05:50 PM, Zhu Guihua wrote: This patchset adds support to hot unplug memory. Memory hot unplug is complicated multi-stage process. Unplug request callback sends remove request. After guest os processes ejection request, OSPM will execute _EJ0 to signal qemu that a device

Re: [Qemu-devel] [PATCH v6 0/8] QEMU memory hot unplug support

2015-04-08 Thread Michael S. Tsirkin
On Wed, Apr 08, 2015 at 05:49:42PM +0800, Zhu Guihua wrote: > Ping... It's only been 4 days. We are finalizing 2.3 so pls sit tight. > > On 04/02/2015 05:50 PM, Zhu Guihua wrote: > >This patchset adds support to hot unplug memory. > > > >Memory hot unplug is complicated multi-stage process. Unp

Re: [Qemu-devel] [PATCH] aio: strengthen memory barriers for bottom half scheduling

2015-04-08 Thread Laszlo Ersek
On 04/07/15 20:20, Leveille, Paul wrote: > Paolo, > > I've applied your patch in place of my prototype patch and, as expected, it's > working fine. Thanks! I also tested the patch (on top of 5a24f20a72), and on aarch64 it doesn't fix the hang. If there's interest, I can write up the reproducer

Re: [Qemu-devel] [PATCH v5 5/7] vfio-pci: pass the aer error to guest

2015-04-08 Thread Chen Fan
On 04/01/2015 11:46 PM, Alex Williamson wrote: On Wed, 2015-04-01 at 12:12 +0800, Chen Fan wrote: On 03/25/2015 10:41 AM, Alex Williamson wrote: On Wed, 2015-03-25 at 09:53 +0800, Chen Fan wrote: On 03/16/2015 10:09 PM, Alex Williamson wrote: On Mon, 2015-03-16 at 15:35 +0800, Chen Fan wrote

Re: [Qemu-devel] [PATCH] aio: strengthen memory barriers for bottom half scheduling

2015-04-08 Thread Richard W.M. Jones
On Tue, Apr 07, 2015 at 05:16:19PM +0200, Paolo Bonzini wrote: > This bug is, most likely, also the cause of failures in the libguestfs > testsuite on AArch64. I'm afraid I have to agree with Laszlo, that this patch unfortunately does not cure the aarch64 race. The test case I'm using is: http://

Re: [Qemu-devel] [PATCH v2 1/4] blockjob: Allow nested pause

2015-04-08 Thread Stefan Hajnoczi
On Fri, Apr 03, 2015 at 10:05:18PM +0800, Fam Zheng wrote: > This patch changes block_job_pause to increase the pause counter and > block_job_resume to decrease it. > > The counter will allow calling block_job_pause/block_job_resume > unconditionally on a job when we need to suspend the IO tempora

Re: [Qemu-devel] [PATCH] aio: strengthen memory barriers for bottom half scheduling

2015-04-08 Thread Laszlo Ersek
On 04/08/15 12:15, Richard W.M. Jones wrote: > On Tue, Apr 07, 2015 at 05:16:19PM +0200, Paolo Bonzini wrote: >> This bug is, most likely, also the cause of failures in the libguestfs >> testsuite on AArch64. > > I'm afraid I have to agree with Laszlo, that this patch unfortunately > does not cure

Re: [Qemu-devel] [PATCH v2 2/4] block: Pause block jobs in bdrv_drain_all

2015-04-08 Thread Stefan Hajnoczi
On Fri, Apr 03, 2015 at 10:05:19PM +0800, Fam Zheng wrote: > This is necessary to suppress more IO requests from being generated from > block job coroutines. > > Signed-off-by: Fam Zheng > --- > block.c | 20 > 1 file changed, 20 insertions(+) > > diff --git a/block.c b/blo

Re: [Qemu-devel] [PATCH v2 0/4] Fix "stop" draining block jobs

2015-04-08 Thread Stefan Hajnoczi
On Fri, Apr 03, 2015 at 10:05:17PM +0800, Fam Zheng wrote: > v2: Use "pause" approach as suggested by Paolo. > > Stopping the vm will drive the block job all the way to the end, because the > sleep duration is too short, which means the block_job_sleep_ns in the block > jobs are unhelpful. That is

Re: [Qemu-devel] [PATCH v2 3/4] qemu-iotests: Test that "stop" doesn't drain block jobs

2015-04-08 Thread Stefan Hajnoczi
On Fri, Apr 03, 2015 at 10:05:20PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/129 | 86 > ++ > tests/qemu-iotests/129.out | 5 +++ > tests/qemu-iotests/group | 1 + > 3 files changed, 92 insertions(+) > creat

Re: [Qemu-devel] [PATCH] kvm: fix slot flags sync between Qemu and KVM

2015-04-08 Thread Paolo Bonzini
On 08/04/2015 08:34, Xiao Guangrong wrote: > We noticed that KVM keeps tracking dirty for the memslots when > live migration failed which causes bad performance due to huge > page mapping disallowed for this kind of memslot > > It is caused by slot flags does not properly sync-ed between Qemu >

Re: [Qemu-devel] [PATCH v6 0/8] QEMU memory hot unplug support

2015-04-08 Thread Paulo Ricardo Paz Vital
On Wed, 2015-04-08 at 11:52 +0200, Michael S. Tsirkin wrote: > On Wed, Apr 08, 2015 at 05:49:42PM +0800, Zhu Guihua wrote: > > Ping... > > It's only been 4 days. We are finalizing 2.3 so pls sit tight. I agree with Michael, it's time to close 2.3. But I have a question. Is the patch counter cor

Re: [Qemu-devel] [PATCH 01/14] memory: Define API for MemoryRegionOps to take attrs and return status

2015-04-08 Thread Paolo Bonzini
On 07/04/2015 22:09, Peter Maydell wrote: > Define an API so that devices can register MemoryRegionOps whose read > and write callback functions are passed an arbitrary pointer to some > transaction attributes and can return a success-or-failure status code. > This will allow us to model devices

Re: [Qemu-devel] [PATCH 02/14] memory: Add MemTxAttrs, MemTxResult to io_mem_read and io_mem_write

2015-04-08 Thread Paolo Bonzini
On 07/04/2015 22:09, Peter Maydell wrote: > Add a MemTxAttrs argument to the io_mem_read() and io_mem_write() > functions, and make them return MemTxResult rather than bool, > thus pushing these new arguments out one level of the callstack > (all the callers callers currently pass MEMTXATTRS_UNSP

Re: [Qemu-devel] [PATCH 03/14] Make CPU iotlb a structure rather than a plain hwaddr

2015-04-08 Thread Paolo Bonzini
On 07/04/2015 22:09, Peter Maydell wrote: > Make the CPU iotlb a structure rather than a plain hwaddr; > this will allow us to add transaction attributes to it. > > Signed-off-by: Peter Maydell > --- > cputlb.c| 4 ++-- > include/exec/cpu-defs.h | 13 +++-- > softmmu_t

Re: [Qemu-devel] [PATCH 04/14] Add MemTxAttrs to the IOTLB

2015-04-08 Thread Paolo Bonzini
On 07/04/2015 22:09, Peter Maydell wrote: > Add a MemTxAttrs field to the IOTLB, and allow target-specific > code to set it via a new tlb_set_page_with_attrs() function; > pass the attributes through to the device when making IO accesses. > > Signed-off-by: Peter Maydell > --- > cputlb.c

Re: [Qemu-devel] [PATCH 05/14] exec.c: Convert subpage memory ops to _with_attrs

2015-04-08 Thread Paolo Bonzini
On 07/04/2015 22:09, Peter Maydell wrote: > Convert the subpage memory ops to _with_attrs; this will allow > us to pass the attributes through to the underlying access > functions. Perhaps mention in the commit message that the attributes are not used yet. Reviewed-by: Paolo Bonzini > Signed-

Re: [Qemu-devel] [PATCH 02/14] memory: Add MemTxAttrs, MemTxResult to io_mem_read and io_mem_write

2015-04-08 Thread Peter Maydell
On 8 April 2015 at 11:51, Paolo Bonzini wrote: > This could be the occasion to drop io_mem_read/io_mem_write and use > memory_region_dispatch_read/memory_region_dispatch_write altogether. As > you prefer. Makes sense, I guess; memory_region_* are better named for what they do, so promoting those

Re: [Qemu-devel] [PATCH 07/14] exec.c: Add new address_space_ld*/st* functions

2015-04-08 Thread Paolo Bonzini
On 07/04/2015 22:09, Peter Maydell wrote: > +#ifdef NEED_CPU_H > +uint32_t address_space_lduw(AddressSpace *as, hwaddr addr, > +MemTxAttrs attrs, MemTxResult *result); > +uint32_t address_space_ldl(AddressSpace *as, hwaddr addr, > +MemTxAttr

Re: [Qemu-devel] [PATCH 09/14] exec.c: Capture the memory attributes for a watchpoint hit

2015-04-08 Thread Paolo Bonzini
On 07/04/2015 22:09, Peter Maydell wrote: > Capture the memory attributes for the transaction which triggered > a watchpoint; this allows CPU specific code to implement features > like ARM's "user-mode only WPs also hit for LDRT/STRT accesses > made from privileged code". > > Signed-off-by: Pete

Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags

2015-04-08 Thread Eduardo Habkost
On Wed, Apr 08, 2015 at 10:30:52AM +0200, Paolo Bonzini wrote: > > > On 07/04/2015 22:46, Eduardo Habkost wrote: > > This uses the feature name arrays to register "feat-*" QOM properties > > for feature flags. This simply adds the properties so they can be > > configured using -global, but doesn'

Re: [Qemu-devel] [PATCH 02/14] memory: Add MemTxAttrs, MemTxResult to io_mem_read and io_mem_write

2015-04-08 Thread Paolo Bonzini
On 08/04/2015 12:59, Peter Maydell wrote: > Incidentally in the course of this patch I noticed that we have > exactly two places outside the memory system that use these > functions: hw/s390x/s390-pci-inst.c and hw/vfio/pci.c. Is > this a reasonable thing, or should they in an ideal world > have

Re: [Qemu-devel] [PATCH 09/14] exec.c: Capture the memory attributes for a watchpoint hit

2015-04-08 Thread Peter Maydell
On 8 April 2015 at 12:04, Paolo Bonzini wrote: > > > On 07/04/2015 22:09, Peter Maydell wrote: >> Capture the memory attributes for the transaction which triggered >> a watchpoint; this allows CPU specific code to implement features >> like ARM's "user-mode only WPs also hit for LDRT/STRT accesses

Re: [Qemu-devel] [v7 08/14] migration: Add the core code of multi-thread compression

2015-04-08 Thread Juan Quintela
Liang Li wrote: > Implement the core logic of the multiple thread compression. At this > point, multiple thread compression can't co-work with xbzrle yet. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang Reviewed-by: Juan Quintela

Re: [Qemu-devel] [v7 09/14] migration: Make compression co-work with xbzrle

2015-04-08 Thread Juan Quintela
Liang Li wrote: > Now, multiple thread compression can co-work with xbzrle. when > xbzrle is on, multiple thread compression will only work at the > first round of RAM data sync. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > Reviewed-by: Dr.David Alan Gilbert Reviewed-by: Juan Quin

Re: [Qemu-devel] [v7 10/14] migration: Add the core code for decompression

2015-04-08 Thread Juan Quintela
Liang Li wrote: > Implement the core logic of multiple thread decompression, > the decompression can work now. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > arch_init.c | 51 --- > 1 file changed, 48 insertions(+), 3 deletions(-)

Re: [Qemu-devel] [v7 11/14] migration: Add interface to control compression

2015-04-08 Thread Juan Quintela
Liang Li wrote: > The multiple compression threads can be turned on/off through > qmp and hmp interface before doing live migration. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > Reviewed-by: Dr.David Alan Gilbert > Reviewed-by: Eric Blake Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags

2015-04-08 Thread Igor Mammedov
On Tue, 7 Apr 2015 17:46:40 -0300 Eduardo Habkost wrote: > This uses the feature name arrays to register "feat-*" QOM properties > for feature flags. This simply adds the properties so they can be > configured using -global, but doesn't change x86_cpu_parse_featurestr() > to use them yet. > > S

Re: [Qemu-devel] [v7 12/14] migration: Use an array instead of 3 parameters

2015-04-08 Thread Juan Quintela
Liang Li wrote: > Put the three parameters related to multiple thread (de)compression > into an int array, and use an enum type to index the parameter. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang Reviewed-by: Juan Quintela BTW, for the libvirt people, what do you think about movi

Re: [Qemu-devel] [v7 13/14] migration: Add qmp commands to set and query parameters

2015-04-08 Thread Juan Quintela
Liang Li wrote: > Add the qmp commands to tune and query the parameters used in live > migration. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang Eric, can you review this and the following patch? I think they are correct, but I preffer someone more versed on QMP to review them. Thank

Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags

2015-04-08 Thread Eduardo Habkost
On Wed, Apr 08, 2015 at 01:36:29PM +0200, Igor Mammedov wrote: > On Tue, 7 Apr 2015 17:46:40 -0300 > Eduardo Habkost wrote: > > > This uses the feature name arrays to register "feat-*" QOM properties > > for feature flags. This simply adds the properties so they can be > > configured using -glob

Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags

2015-04-08 Thread Paolo Bonzini
On 08/04/2015 14:20, Eduardo Habkost wrote: >> > it would be better to create generic bit property and replace above code >> > with it >> > something similar to object_property_add_uint32_ptr() > object_property_add_*_ptr() adds read-only properties, and I didn't want > to make object_property_a

[Qemu-devel] [PATCH] kvm: add support for memory transaction attributes

2015-04-08 Thread Paolo Bonzini
Let kvm_arch_post_run convert fields in the kvm_run struct to MemTxAttrs. These are then passed to address_space_rw. Signed-off-by: Paolo Bonzini --- Peter, feel free to include this in your series if you wish to (and if you agree with the implementation). include/sysemu/kvm.h |

[Qemu-devel] [PATCH] kvm: add support for memory transaction attributes

2015-04-08 Thread Paolo Bonzini
Let kvm_arch_post_run convert fields in the kvm_run struct to MemTxAttrs. These are then passed to address_space_rw. Signed-off-by: Paolo Bonzini --- include/sysemu/kvm.h | 3 ++- kvm-all.c| 21 - target-arm/kvm.c | 4 +++- target-i386/kvm.c| 4 +++- ta

Re: [Qemu-devel] 64-bit build of qemu-system-arm with mingw-w64 not functional

2015-04-08 Thread Liviu Ionescu
> On 08 Apr 2015, at 09:20, Stefan Weil wrote: > > ... Here is my package list (from Debian Jessie): > > ii binutils-mingw-w64-i686 2.22-8+deb7u2+2+deb7u1amd64 > Cross-binutils for Win32 (x86) using MinGW-w64 > ii binutils-mingw-w64-x86-64 2.22-8+deb7u2+2+deb7u1amd64

Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags

2015-04-08 Thread Andreas Färber
Am 08.04.2015 um 13:06 schrieb Eduardo Habkost: > On Wed, Apr 08, 2015 at 10:30:52AM +0200, Paolo Bonzini wrote: >> On 07/04/2015 22:46, Eduardo Habkost wrote: >>> This uses the feature name arrays to register "feat-*" QOM properties >>> for feature flags. This simply adds the properties so they ca

Re: [Qemu-devel] [PATCH 06/14] exec.c: Make address_space_rw take transaction attributes

2015-04-08 Thread Paolo Bonzini
On 07/04/2015 22:09, Peter Maydell wrote: > Make address_space_rw take transaction attributes, rather > than always using the 'unspecified' attributes. > > Signed-off-by: Peter Maydell > --- > dma-helpers.c| 3 ++- > exec.c | 51 > ++-

Re: [Qemu-devel] [PATCH for-2.4 v5 0/7] Target-specific unit test support, add unit tests for target-i386/cpu.c code

2015-04-08 Thread Andreas Färber
Am 23.03.2015 um 20:37 schrieb Eduardo Habkost: > Changes v4 -> v5: > * Rewrite fake kvm_arch_get_supported_cpuid() code > * Add new test to ensure KVM defaults won't override explicit command-line >options > > Changes v3 -> v4: > * Move target_words_bigendian() prototype back inside tests/

Re: [Qemu-devel] [PATCH V5 16/18] virtio-pci: increase the maximum number of virtqueues to 513

2015-04-08 Thread Michael S. Tsirkin
On Tue, Apr 07, 2015 at 08:06:14PM +0200, Luigi Rizzo wrote: > > > On Tue, Apr 7, 2015 at 6:54 PM, Alexander Graf wrote: > > On 04/01/2015 10:15 AM, Jason Wang wrote: > > This patch increases the maximum number of virtqueues for pci from 64 > to 513. This will allow booting

Re: [Qemu-devel] [PATCH for-2.4 v5 0/7] Target-specific unit test support, add unit tests for target-i386/cpu.c code

2015-04-08 Thread Eduardo Habkost
(CCing Jiri Denemark in case he has anything to add about libvirt requirements) On Wed, Apr 08, 2015 at 03:06:41PM +0200, Andreas Färber wrote: > Am 23.03.2015 um 20:37 schrieb Eduardo Habkost: > > Changes v4 -> v5: > > * Rewrite fake kvm_arch_get_supported_cpuid() code > > * Add new test to ens

Re: [Qemu-devel] [v7 09/14] migration: Make compression co-work with xbzrle

2015-04-08 Thread Li, Liang Z
> > Now, multiple thread compression can co-work with xbzrle. when xbzrle > > is on, multiple thread compression will only work at the first round > > of RAM data sync. > > > > Signed-off-by: Liang Li > > Signed-off-by: Yang Zhang > > Reviewed-by: Dr.David Alan Gilbert > > Reviewed-by: Juan Qui

Re: [Qemu-devel] [PATCH] aio: strengthen memory barriers for bottom half scheduling

2015-04-08 Thread Leveille, Paul
Paolo, I've applied your patch in place of my prototype patch and, as expected, it's working fine. Thanks! -Original Message- From: Paolo Bonzini [mailto:pbonz...@redhat.com] Sent: Tuesday, April 07, 2015 11:16 AM To: qemu-devel@nongnu.org Cc: ler...@redhat.com; Leveille, Paul; stefa...

[Qemu-devel] [Bug 1441443] [NEW] Is there a way to create a 10G network interface for VMs in KVM2.0?

2015-04-08 Thread praveen mulimani
Public bug reported: We have installed & configured the KVM 2.0 (qemu-kvm 2.0.0+dfsg- 2ubuntu1.10) on Ubuntu 14.04. The physical server is connected to 10G network, KVM is configured in Bridged mode But the issue is, when we create Network interface on VMs, we have only 1G device as an options fo

Re: [Qemu-devel] [PATCH] kvm: fix slot flags sync between Qemu and KVM

2015-04-08 Thread Xiao Guangrong
On 04/08/2015 02:34 PM, Xiao Guangrong wrote: We noticed that KVM keeps tracking dirty for the memslots when live migration failed which causes bad performance due to huge page mapping disallowed for this kind of memslot It is caused by slot flags does not properly sync-ed between Qemu and KVM

[Qemu-devel] [PATCH] kvm: fix slot flags sync between Qemu and KVM

2015-04-08 Thread Xiao Guangrong
We noticed that KVM keeps tracking dirty for the memslots when live migration failed which causes bad performance due to huge page mapping disallowed for this kind of memslot It is caused by slot flags does not properly sync-ed between Qemu and KVM. Current code doing slot update depends on slot-

[Qemu-devel] SIGTERM signal to qemu-kvm process

2015-04-08 Thread Jatin Davey
Hi I am using QEMU 0.12.1 as the hypervisor in my RHEL installation of 6.5. I wanted to know if there are any side-effects with respect to VM image corruption when i use SIGTERM signal to kill a qemu-kvm process which effectively stops my VM running on the host. Appreciate if you can provide

Re: [Qemu-devel] [v7 10/14] migration: Add the core code for decompression

2015-04-08 Thread Li, Liang Z
> > @@ -889,7 +889,6 @@ static inline void > start_compression(CompressParam *param) > > qemu_mutex_unlock(¶m->mutex); } > > > > - > > static uint64_t bytes_transferred; > > > > static void flush_compressed_data(QEMUFile *f) @@ -1458,8 +1457,28 > @@ > > void ram_handle_compressed(void *host

Re: [Qemu-devel] [PATCH for-2.4 v5 0/7] Target-specific unit test support, add unit tests for target-i386/cpu.c code

2015-04-08 Thread Andreas Färber
Am 08.04.2015 um 15:42 schrieb Eduardo Habkost: > (CCing Jiri Denemark in case he has anything to add about libvirt > requirements) > > On Wed, Apr 08, 2015 at 03:06:41PM +0200, Andreas Färber wrote: >> Am 23.03.2015 um 20:37 schrieb Eduardo Habkost: >>> Changes v4 -> v5: >>> * Rewrite fake kvm_a

Re: [Qemu-devel] [PATCH] kvm: add support for memory transaction attributes

2015-04-08 Thread Peter Maydell
On 8 April 2015 at 13:28, Paolo Bonzini wrote: > Let kvm_arch_post_run convert fields in the kvm_run struct to MemTxAttrs. > These are then passed to address_space_rw. > > Signed-off-by: Paolo Bonzini Reviewed-by: Peter Maydell At some point it might be nice to support returning the transactio

Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags

2015-04-08 Thread Igor Mammedov
On Wed, 08 Apr 2015 14:24:35 +0200 Paolo Bonzini wrote: > > > On 08/04/2015 14:20, Eduardo Habkost wrote: > >> > it would be better to create generic bit property and replace above code > >> > with it > >> > something similar to object_property_add_uint32_ptr() > > object_property_add_*_ptr()

Re: [Qemu-devel] 64-bit build of qemu-system-arm with mingw-w64 not functional

2015-04-08 Thread Liviu Ionescu
> On 08 Apr 2015, at 02:10, Peter Maydell wrote: > > ... I dug out my > notes on my setup at the time. ... > but at the time (about June last year) this was a reproducible > recipe that other people were able to use to build working > w64 binaries. thank you, Peter, I'll first try to reproduce

Re: [Qemu-devel] [PATCH v4 03/20] hw/arm/virt-acpi-build: Basic framework for building ACPI tables on ARM

2015-04-08 Thread Alex Bennée
Shannon Zhao writes: > From: Shannon Zhao > > Introduce a preliminary framework in virt-acpi-build.c with the main > ACPI build functions. It exposes the generated ACPI contents to > guest over fw_cfg. > > The required ACPI v5.1 tables for ARM are: > - RSDP: Initial table that points to XSDT >

Re: [Qemu-devel] 64-bit build of qemu-system-arm with mingw-w64 not functional

2015-04-08 Thread Peter Maydell
On 8 April 2015 at 15:13, Liviu Ionescu wrote: > p.s. I'm always amazed when for exact tasks, like complex > builds, people prefer narrative recipes instead of ready > to run scripts... I agree generally, though this one is tedious because it involves several different machines. The reason it end

[Qemu-devel] Add 3D video card acceleration

2015-04-08 Thread Programmingkid
It would be great if QEMU could emulate a 3D video card. We would all be able to play our games in it. VirtualBox does have a GPL v2 implementation of a 2D and 3D video card. If there any reason why we can't port their video card to QEMU?

[Qemu-devel] [PATCH 3/6] block: never cancel a streaming job without running stream_complete()

2015-04-08 Thread Alberto Garcia
We need to call stream_complete() in order to do all the necessary clean-ups, even if there's an early failure. At the moment it's only useful to make sure that s->backing_file_str is not leaked, but it will become more important as we introduce support for streaming to any intermediate node. Sign

[Qemu-devel] [PATCH 4/6] block: Support streaming to an intermediate layer

2015-04-08 Thread Alberto Garcia
This makes sure that the image we are steaming into is open in read-write mode during the operation. Operation blockers are also set in all intermediate nodes, since they will be removed from the chain afterwards. Finally, this also unblocks the stream operation in backing files. Signed-off-by:

[Qemu-devel] [PATCH 5/6] block: Add QMP support for streaming to an intermediate layer

2015-04-08 Thread Alberto Garcia
This patch makes the 'device' paramater of the 'block-stream' command allow a node name as well as a device name. In addition to that, operation blockers will be checked in all intermediate nodes between the top and the base node. Signed-off-by: Alberto Garcia --- blockdev.c | 20

[Qemu-devel] [PATCH v3 0/6] Support streaming to an intermediate layer

2015-04-08 Thread Alberto Garcia
There's only one change in this series: there's now a list of block jobs that is updated everytime a new one is created or destroyed. This way we can iterate the list directly, rather than searching all BlockDriverStates for the ones that own a block job. Otherwise please check the summary I wrot

[Qemu-devel] [PATCH 2/6] block: allow block jobs in any arbitrary node

2015-04-08 Thread Alberto Garcia
Currently, block jobs can only be owned by root nodes. This patch allows block jobs to be in any arbitrary node, by making the following changes: - Block jobs can now be identified by the node name of their BlockDriverState in addition to the device name. Since both device and node names live

Re: [Qemu-devel] [v7 10/14] migration: Add the core code for decompression

2015-04-08 Thread Juan Quintela
"Li, Liang Z" wrote: >> > @@ -889,7 +889,6 @@ static inline void >> start_compression(CompressParam *param) >> > qemu_mutex_unlock(¶m->mutex); } >> > >> > - >> > static uint64_t bytes_transferred; >> > >> > static void flush_compressed_data(QEMUFile *f) @@ -1458,8 +1457,28 >> @@ >> > void

[Qemu-devel] [PATCH 1/6] block: keep a list of block jobs

2015-04-08 Thread Alberto Garcia
The current way to obtain the list of existing block jobs is to iterate over all root nodes and check which ones own a job. Since we want to be able to support block jobs in other nodes as well, this patch keeps a list of jobs that is updated everytime one is created or destroyed. This also updat

[Qemu-devel] [PATCH 6/6] docs: Document how to stream to an intermediate layer

2015-04-08 Thread Alberto Garcia
Signed-off-by: Alberto Garcia --- docs/live-block-ops.txt | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/docs/live-block-ops.txt b/docs/live-block-ops.txt index a257087..5e969fd 100644 --- a/docs/live-block-ops.txt +++ b/docs/live-block-ops.

Re: [Qemu-devel] [PATCH v4 04/20] hw/acpi/aml-build: Add aml_memory32_fixed() term

2015-04-08 Thread Alex Bennée
Shannon Zhao writes: > From: Shannon Zhao > > Add aml_memory32_fixed() for describing device mmio region in resource > template. > These can be used to generating DSDT table for ACPI on ARM. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/acpi/aml-build.c |

Re: [Qemu-devel] [PATCH v2 2/4] block: Pause block jobs in bdrv_drain_all

2015-04-08 Thread Alberto Garcia
On Wed, Apr 08, 2015 at 11:37:52AM +0100, Stefan Hajnoczi wrote: > > +QTAILQ_FOREACH(bs, &bdrv_states, device_list) { > > +AioContext *aio_context = bdrv_get_aio_context(bs); > > + > > +aio_context_acquire(aio_context); > > +if (bs->job) { > > +block_job_pau

Re: [Qemu-devel] [PATCH v4 05/20] hw/acpi/aml-build: Add aml_interrupt() term

2015-04-08 Thread Alex Bennée
Shannon Zhao writes: > From: Shannon Zhao > > Add aml_interrupt() for describing device interrupt in resource template. > These can be used to generating DSDT table for ACPI on ARM. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/acpi/aml-build.c | 18 +++

Re: [Qemu-devel] [PATCH for-2.4 v5 0/7] Target-specific unit test support, add unit tests for target-i386/cpu.c code

2015-04-08 Thread Eduardo Habkost
On Wed, Apr 08, 2015 at 04:05:59PM +0200, Andreas Färber wrote: > Am 08.04.2015 um 15:42 schrieb Eduardo Habkost: > > (CCing Jiri Denemark in case he has anything to add about libvirt > > requirements) > > > > On Wed, Apr 08, 2015 at 03:06:41PM +0200, Andreas Färber wrote: > >> Am 23.03.2015 um 20

Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags

2015-04-08 Thread Eduardo Habkost
On Wed, Apr 08, 2015 at 04:09:32PM +0200, Igor Mammedov wrote: > On Wed, 08 Apr 2015 14:24:35 +0200 > Paolo Bonzini wrote: > > > > > > > On 08/04/2015 14:20, Eduardo Habkost wrote: > > >> > it would be better to create generic bit property and replace above > > >> > code with it > > >> > somet

Re: [Qemu-devel] [PATCH v3 5/5] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-04-08 Thread Gabriel L. Somlo
On Mon, Mar 23, 2015 at 04:52:44PM +0100, Paolo Bonzini wrote: > On 23/03/2015 15:11, Laszlo Ersek wrote: > > Depends on the exact maintainer picking up your series. > > > > ... Now good luck figuring out who that's going to be :) > > > > (I ran "scripts/get_maintainer.pl" on a squashed diff for

[Qemu-devel] KVM call agenda for 2015-04-14

2015-04-08 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. Call details: By popular demand, a google calendar public entry with it https://www.google.com/calendar/embed?src=dG9iMXRqcXAzN3Y4ZXZwNzRoMHE4a3BqcXNAZ3JvdXAuY2FsZW5kYXIuZ29vZ2xlLmNvbQ (Let me know if you have any problems wi

Re: [Qemu-devel] [PATCH] aio: strengthen memory barriers for bottom half scheduling

2015-04-08 Thread Stefan Hajnoczi
On Tue, Apr 7, 2015 at 4:16 PM, Paolo Bonzini wrote: > There are two problems with memory barriers in async.c. The fix is > to use atomic_xchg in order to achieve sequential consistency between > the scheduling of a bottom half and the corresponding execution. > > First, if bh->scheduled is alrea

[Qemu-devel] bios-tables-test failing for x86_64 on ppc

2015-04-08 Thread Andreas Färber
Hello, With rcutorture fixed, I am still seeing the following failure in -rc2. It is only for /x86_64/acpi/..., not for /i386/acpi/...; only on ppc host, not on ppc64 or ppc64le (so not endianness), nor on i586 (so not 32-bitness alone). Alex was suggesting it may be a ppc TCG problem, but I'm no

Re: [Qemu-devel] [snabb-devel] Re: [PATCH v2] vhost-user: add multi queue support

2015-04-08 Thread Nikolay Nikolaev
On Mon, Apr 6, 2015 at 6:07 PM, Michael S. Tsirkin wrote: > > On Sat, Jan 24, 2015 at 02:22:29PM +0200, Nikolay Nikolaev wrote: > > Vhost-user will implement the multiqueueu support in a similar way to what > > multiqueue > > > vhost already has - a separate thread for each queue. > > > > To enabl

[Qemu-devel] Last call for release-critical fixes for 2.3...

2015-04-08 Thread Peter Maydell
It looks like we have perhaps only a few more issues which need fixes to go into 2.3, so what I'd like to do is hold rc3 until we have them all fixed and then roll an rc3 which will with luck be our final release (bar the version number). Can people reply to this mail if they have things that need

  1   2   3   >