[Qemu-devel] [PATCH] exec: avoid possible overwriting of mmaped area in qemu_ram_remap

2015-03-25 Thread Paolo Bonzini
It is not necessary to munmap an area before remapping it with MAP_FIXED; if the memory region specified by addr and len overlaps pages of any existing mapping, then the overlapped part of the existing mapping will be discarded. On the other hand, if QEMU does munmap the pages, there is a small pr

Re: [Qemu-devel] [PATCH v4 2/4] configure: factor out supported flag check

2015-03-25 Thread Stefan Hajnoczi
On Tue, Mar 24, 2015 at 02:19:44PM -0400, John Snow wrote: > +cc_has_warning_flag() { > +write_c_skeleton; > + > # Use the positive sense of the flag when testing for -Wno-wombat > # support (gcc will happily accept the -Wno- form of unknown > # warning options). > -optflag="

Re: [Qemu-devel] [PATCH for-2.3] mips: memory: Replace memory_region_init_ram with memory_region_allocate_system_memory

2015-03-25 Thread Leon Alrae
On 24/03/2015 23:01, Andreas Färber wrote: > Am 24.03.2015 um 22:28 schrieb Dirk Müller: >> Commit 0b183fc871:"memory: move mem_path handling to >> memory_region_allocate_system_memory" split memory_region_init_ram and >> memory_region_init_ram_from_file. Also it moved mem-path handling a step >> u

Re: [Qemu-devel] AioContext of block jobs

2015-03-25 Thread Stefan Hajnoczi
On Wed, Mar 25, 2015 at 04:31:39PM +0800, Fam Zheng wrote: > I was looking at block jobs' AioContext and realized that the block job > coroutines are actually started in main loop. > > I'm confused because 5a7e7a0bad17c96e03f55ed7019e2d7545e21a96 and friends in > the series [1] seem to move the co

Re: [Qemu-devel] [PATCH for-2.3] mips: memory: Replace memory_region_init_ram with memory_region_allocate_system_memory

2015-03-25 Thread Paolo Bonzini
On 25/03/2015 14:23, Leon Alrae wrote: > On 24/03/2015 23:01, Andreas Färber wrote: >> Am 24.03.2015 um 22:28 schrieb Dirk Müller: >>> Commit 0b183fc871:"memory: move mem_path handling to >>> memory_region_allocate_system_memory" split memory_region_init_ram and >>> memory_region_init_ram_from_fi

Re: [Qemu-devel] [PATCH v2 for-2.3] m68k: memory: Replace memory_region_init_ram with memory_region_allocate_system_memory

2015-03-25 Thread Paolo Bonzini
On 24/03/2015 23:11, Dirk Müller wrote: > Commit 0b183fc871:"memory: move mem_path handling to > memory_region_allocate_system_memory" split memory_region_init_ram and > memory_region_init_ram_from_file. Also it moved mem-path handling a step > up from memory_region_init_ram to memory_region_allo

Re: [Qemu-devel] [PATCH for-2.3] sparc: memory: Replace memory_region_init_ram with memory_region_allocate_system_memory

2015-03-25 Thread Paolo Bonzini
On 24/03/2015 22:30, Dirk Müller wrote: > Commit 0b183fc871:"memory: move mem_path handling to > memory_region_allocate_system_memory" split memory_region_init_ram and > memory_region_init_ram_from_file. Also it moved mem-path handling a step > up from memory_region_init_ram to memory_region_allo

Re: [Qemu-devel] [PATCH] rdma: Fix cleanup in error paths

2015-03-25 Thread Padmanabh Ratnakar
> -Original Message- > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > Sent: Wednesday, March 25, 2015 4:10 PM > To: Padmanabh Ratnakar > Cc: quint...@redhat.com; amit.s...@redhat.com; mrhi...@us.ibm.com; > Padmanabh Ratnakar; Meghana Cheripady; qemu-devel@nongnu.org > Subject:

Re: [Qemu-devel] [PATCH] rdma: Fix cleanup in error paths

2015-03-25 Thread Padmanabh Ratnakar
> > This other three are nice, remove code, and make it correct with the case > that qp has to be removed first. > > So, should we drop the listen_id part, or there is a reason for it? > > Later, Juan. > listen_id is used only in server side. Saw that listen_id gets created before cm_id. So f

Re: [Qemu-devel] [PATCH] rdma: Fix cleanup in error paths

2015-03-25 Thread Juan Quintela
Padmanabh Ratnakar wrote: > As part of commit e325b49a320b493cc5d69e263751ff716dc458fe, > order in which resources are destroyed was changed for fixing > a seg fault. Due to this change, CQ will never get destroyed as > CQ should be destroyed after QP destruction. Seg fault is caused > improper cl

Re: [Qemu-devel] [PATCH 0/8] net/dp8393x improvements

2015-03-25 Thread Leon Alrae
On 05/03/2015 22:13, Hervé Poussineau wrote: > Hi, > > This patchset improves dp8393x network card emulation to current QEMU > standards, > mostly decouples it from MIPS rc4030 chipset emulation, and add PROM and > load/save > functionalities. > Only required cleanup has been done on the rc4030

[Qemu-devel] [PATCH v2 for-2.3 0/5] Contain drive, serial, parallel, net misuse

2015-03-25 Thread Markus Armbruster
This is v2 of my "[PATCH for-2.3 0/3] Contain drive_get() misuse". Drives defined with if!=none, character devices defined with -serial and -parallel, network devices defined with -net nic are all for board initialization to wire up. Board code calls drive_get() or similar to find them, and creat

[Qemu-devel] [PATCH v2 for-2.3 1/5] hw: Mark devices picking up block backends actively FIXME

2015-03-25 Thread Markus Armbruster
Drives defined with if!=none are for board initialization to wire up. Board code calls drive_get() or similar to find them, and creates devices with their qdev drive properties set accordingly. Except a few devices go on a fishing expedition for a suitable backend instead of exposing a drive prope

[Qemu-devel] [PATCH v2 for-2.3 2/5] hw: Mark devices picking up char backends actively FIXME

2015-03-25 Thread Markus Armbruster
Character devices defined with -serial and -parallel are for board initialization to wire up. Board code examines serial_hds[] and parallel_hds[] to find them, and creates devices with their qdev chardev properties set accordingly. Except a few devices go on a fishing expedition for a suitable ba

[Qemu-devel] [PATCH v2 for-2.3 3/5] hw: Mark device misusing nd_table[] FIXME

2015-03-25 Thread Markus Armbruster
NICs defined with -net nic are for board initialization to wire up. Board code examines nd_table[] to find them, and creates devices with their qdev NIC properties set accordingly. Except "allwinner-a10" goes on a fishing expedition for NIC configuration instead of exposing the usual NIC propertie

[Qemu-devel] [PATCH v2 for-2.3 5/5] sysbus: Make devices picking up backends unavailable with -device

2015-03-25 Thread Markus Armbruster
Device models aren't supposed to go on fishing expeditions for backends. They should expose suitable properties for the user to set. For onboard devices, board code sets them. A number of sysbus devices pick up block backends in their init() / instance_init() methods with drive_get_next() instead

Re: [Qemu-devel] Support for NetLogic XLP Processors

2015-03-25 Thread Duarte Silva
On Wednesday 25 March 2015 13:13:14 James Hogan wrote: > Hi Duarte, > > On 22/03/15 11:13, Duarte Silva wrote: > > Hi guys, > > > > I have been struggling to get some binaries compiled for NetLogic XLP > > processor to run under QEMU. I have tried a bunch of things (most going > > back and forth)

[Qemu-devel] [PATCH v2 for-2.3 4/5] sdhci: Make device "sdhci-pci" unavailable with -device

2015-03-25 Thread Markus Armbruster
Device models aren't supposed to go on fishing expeditions for backends. They should expose suitable properties for the user to set. For onboard devices, board code sets them. "sdhci-pci" picks up its block backend in its realize() method with drive_get_next() instead. Already marked FIXME. See

Re: [Qemu-devel] [RFC PATCH COLO v2 00/13] Block replication for continuous checkpoints

2015-03-25 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > Block replication is a very important feature which is used for > continuous checkpoints(for example: COLO). > > Usage: > Please refer to docs/block-replication.txt > > You can get the patch here: > https://github.com/wencongyang/qemu-colo/commits/bl

Re: [Qemu-devel] [PATCH for-2.3 0/3] Contain drive_get() misuse

2015-03-25 Thread Markus Armbruster
Superseded by [PATCH v2 for-2.3 0/5] Contain drive, serial, parallel, net misuse

[Qemu-devel] [PATCH 3/3] qga support process list, netstat and file stat/delete

2015-03-25 Thread itamar . tal4
From: Itamar Tal this patch add support for some more functionality in the qemu-guest-agent, both for windows and linux. Main added features are: - interface listing in Windows - Process list in Windows - network connections enumeration in Windows - file delete for both Windows and Posix - file s

Re: [Qemu-devel] Support for NetLogic XLP Processors

2015-03-25 Thread Leon Alrae
Hi Duarte, On 25/03/2015 14:20, Duarte Silva wrote: > On Wednesday 25 March 2015 13:13:14 James Hogan wrote: >> Hi Duarte, >> >> On 22/03/15 11:13, Duarte Silva wrote: >>> Hi guys, >>> >>> I have been struggling to get some binaries compiled for NetLogic XLP >>> processor to run under QEMU. I have

Re: [Qemu-devel] [PATCH 1/8] rc4030: create custom DMA address space

2015-03-25 Thread Paolo Bonzini
On 05/03/2015 23:13, Hervé Poussineau wrote: > Add a new memory region in system address space where DMA address space > definition (the 'translation table') belongs, so we can update on the fly > the DMA address space. > > Signed-off-by: Hervé Poussineau Would it make sense to just use an IOM

[Qemu-devel] Bouncing maintainers

2015-03-25 Thread Markus Armbruster
I just had another cc: to an address gotten from MAINTAINERS bounce with "user unknown". How do we weed out dead MAINTAINERS entries?

[Qemu-devel] [PATCH] s390x: do not include ram_addr.h

2015-03-25 Thread Paolo Bonzini
ram_addr.h is an internal interface and it is not needed anyway by hw/s390x/ipl.c. Cc: Christian Borntraeger Signed-off-by: Paolo Bonzini --- hw/s390x/ipl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index 54d0835..5c86613 100644 --- a/hw/s390x/ipl.c +++

Re: [Qemu-devel] [PATCH v5 20/45] Modify savevm handlers for postcopy

2015-03-25 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Tue, Mar 24, 2015 at 08:04:14PM +, Dr. David Alan Gilbert wrote: > > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > > On Fri, Mar 20, 2015 at 12:37:59PM +, Dr. David Alan Gilbert wrote: > > > > * David Gibson (da...@gibson.dr

Re: [Qemu-devel] Support for NetLogic XLP Processors

2015-03-25 Thread Leon Alrae
On 25/03/2015 14:44, Leon Alrae wrote: > Hi Duarte, > > On 25/03/2015 14:20, Duarte Silva wrote: >> On Wednesday 25 March 2015 13:13:14 James Hogan wrote: >>> Hi Duarte, >>> >>> On 22/03/15 11:13, Duarte Silva wrote: Hi guys, I have been struggling to get some binaries compiled for

Re: [Qemu-devel] [PATCH v3 1/7] Bug fix: delete the reader entry after queueing an event, not before.

2015-03-25 Thread Marc-André Lureau
ACK. Reviewed-by: Marc-André Lureau On Fri, Mar 13, 2015 at 8:45 PM, Jeremy White wrote: > As far as I can tell, the vreader_remove_reader function is not presently in > use anywhere; I have an upcoming patch set that uses it. > > Signed-off-by: Jeremy White > --- > libcacard/vreader.c |2

Re: [Qemu-devel] [PATCH v3 2/7] Retrieve the correct TD byte when checking an ATR.

2015-03-25 Thread Marc-André Lureau
ACK. Reviewed-by: Marc-André Lureau On Fri, Mar 13, 2015 at 8:45 PM, Jeremy White wrote: > A physical smartcard with an ATR of > 3B 95 95 40 FF AE 01 0E 00 00 > was parsed incorrectly. > > The '40' should have been the second TD; instead > the FF is used, incorrectly. > > Signed-off-by: Jerem

Re: [Qemu-devel] [PATCH v3 3/7] Add a configure check for libpcsclite, and an option to enable or disable it.

2015-03-25 Thread Marc-André Lureau
ACK. Reviewed-by: Marc-André Lureau On Fri, Mar 13, 2015 at 8:45 PM, Jeremy White wrote: > > Signed-off-by: Jeremy White > --- > configure | 38 ++ > 1 file changed, 38 insertions(+) > > diff --git a/configure b/configure > index b858756..f22dbae 100755 >

Re: [Qemu-devel] [PATCH v3 6/7] Enable support for passthru (e.g. direct to pcsc) smart cards in the emul_options entry point in libcacard.

2015-03-25 Thread Marc-André Lureau
ACK. Reviewed-by: Marc-André Lureau On Fri, Mar 13, 2015 at 8:45 PM, Jeremy White wrote: > > Signed-off-by: Jeremy White > --- > libcacard/vcard.c |2 +- > libcacard/vcard.h |2 +- > libcacard/vcard_emul_nss.c | 29 - > libcacard/vcar

Re: [Qemu-devel] [PATCH v3 4/7] Add error checking to vcard_emul_options.

2015-03-25 Thread Marc-André Lureau
ACK. Reviewed-by: Marc-André Lureau On Fri, Mar 13, 2015 at 8:45 PM, Jeremy White wrote: > Also add an alias of 'nssemul' for the default card > of hw=yes hw_type=cac, and an alias of 'passthru' for > the new card type of hw=yes hw_type=passthru. > > This allows the spice-gtk client to take a m

Re: [Qemu-devel] [PATCH v3 5/7] Add a VCARD_DIRECT implemention to the libcacard smartcard support.

2015-03-25 Thread Marc-André Lureau
ACK. Reviewed-by: Marc-André Lureau (the extra symbols should be shaved in a future libcacard update) On Fri, Mar 13, 2015 at 8:45 PM, Jeremy White wrote: > This uses libpcsclite to provide direct communication with a smartcard. > > Signed-off-by: Jeremy White > --- > Makefile.objs

Re: [Qemu-devel] [PATCH v3 0/7] Add support for passthru cards to libcacard

2015-03-25 Thread Marc-André Lureau
Hi On Mon, Mar 16, 2015 at 6:19 PM, Paolo Bonzini wrote: > On 16/03/2015 17:52, Jeremy White wrote: >> It seemed as though the convention was that all non static functions >> went into the .syms file; I may have misunderstood. > > I suspect that the .syms file was introduced as a way to hide util

Re: [Qemu-devel] [PATCH v3 7/7] Remove the (broken) passthru option.

2015-03-25 Thread Marc-André Lureau
ACK. Reviewed-by: Marc-André Lureau On Fri, Mar 13, 2015 at 8:45 PM, Jeremy White wrote: > That option can be achieved using -e "use_hw=yes hw_type=passthru" > > Signed-off-by: Jeremy White > --- > libcacard/vscclient.c | 16 +++- > 1 file changed, 3 insertions(+), 13 deletions(

Re: [Qemu-devel] [PATCH v2 for-2.3 1/5] hw: Mark devices picking up block backends actively FIXME

2015-03-25 Thread Andreas Färber
Am 25.03.2015 um 15:16 schrieb Markus Armbruster: > Drives defined with if!=none are for board initialization to wire up. > Board code calls drive_get() or similar to find them, and creates > devices with their qdev drive properties set accordingly. > > Except a few devices go on a fishing expedit

Re: [Qemu-devel] [PATCH] target-i386: remove superfluous TARGET_HAS_SMC macro

2015-03-25 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] pcspk: Fix I/O port name

2015-03-25 Thread Michael Tokarev
19.03.2015 15:08, Jan Kiszka wrote: > Probably a copy&paste bug. Fixing it helps identifying the device model > behind port 0x61. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] target-tricore: Fix check which was always false

2015-03-25 Thread Michael Tokarev
21.03.2015 16:44, Stefan Weil wrote: > With a mask value of 0x0040, the result will never be 1. > This fixes a Coverity warning. Might be a bit risky if the whole thing wasn't a complete no-op. I wonder maybe the whole this if statement should be removed.. But anyway, applied to -trivial, tha

Re: [Qemu-devel] [PATCH] acpi: Add missing GCC_FMT_ATTR to local function

2015-03-25 Thread Michael S. Tsirkin
On Wed, Mar 25, 2015 at 06:17:52PM +0300, Michael Tokarev wrote: > 20.03.2015 20:11, Stefan Weil wrote: > > This fixes these gcc warnings (not enabled in default build): > > > > hw/acpi/aml-build.c:83:5: warning: > > function might be possible candidate for ‘gnu_printf’ format attribute > > [-Ws

Re: [Qemu-devel] [PATCH] acpi: Add missing GCC_FMT_ATTR to local function

2015-03-25 Thread Michael Tokarev
20.03.2015 20:11, Stefan Weil wrote: > This fixes these gcc warnings (not enabled in default build): > > hw/acpi/aml-build.c:83:5: warning: > function might be possible candidate for ‘gnu_printf’ format attribute > [-Wsuggest-attribute=format] > hw/acpi/aml-build.c:88:5: warning: > function mig

Re: [Qemu-devel] [for-2.3 PATCH v2] gitignore: Ignore more .pod files.

2015-03-25 Thread Michael Tokarev
20.03.2015 19:30, Eric Blake wrote: > kvm_stat.{1,pod} started showing up as untracked files in my > directory, and I nearly accidentally merged them into a commit > with my usual habit of 'git add .'. Rather than spelling out > each such file, just ignore the entire pattern. Applied to -trivial,

Re: [Qemu-devel] [PATCH v2 for-2.3 2/5] hw: Mark devices picking up char backends actively FIXME

2015-03-25 Thread Andreas Färber
Am 25.03.2015 um 15:16 schrieb Markus Armbruster: > Character devices defined with -serial and -parallel are for board > initialization to wire up. Board code examines serial_hds[] and > parallel_hds[] to find them, and creates devices with their qdev > chardev properties set accordingly. > > Exc

Re: [Qemu-devel] [PATCH] s390x: do not include ram_addr.h

2015-03-25 Thread Christian Borntraeger
Am 25.03.2015 um 15:56 schrieb Paolo Bonzini: > ram_addr.h is an internal interface and it is not needed anyway by > hw/s390x/ipl.c. > > Cc: Christian Borntraeger > Signed-off-by: Paolo Bonzini Applied to our tree. thanks. containing pull request will probably be sent by Cornelia. > --- > h

Re: [Qemu-devel] [PATCH v2 for-2.3 1/5] hw: Mark devices picking up block backends actively FIXME

2015-03-25 Thread Paolo Bonzini
On 25/03/2015 16:17, Andreas Färber wrote: > > @@ -319,11 +319,13 @@ static void pc87312_realize(DeviceState *dev, Error > > **errp) > > d = DEVICE(isa); > > qdev_prop_set_uint32(d, "iobase", get_fdc_iobase(s)); > > qdev_prop_set_uint32(d, "irq", 6); > > +/* FI

Re: [Qemu-devel] [PATCH for-2.3 0/2] qtest: Fix remaining test paths to include architecture

2015-03-25 Thread Stefan Hajnoczi
On Tue, Mar 24, 2015 at 11:45:46PM +0100, Andreas Färber wrote: > Hello, > > This mini-series is a follow-up, fixing the last remaining GTester paths > to indicate the architecture they are executed for (i386 vs. x86_64). > > Unlike the previous patch, there is no libqtest wrapper function adding

[Qemu-devel] [PULL 3/3] virtio-net: validate backend queue numbers against bus limitation

2015-03-25 Thread Michael S. Tsirkin
From: Jason Wang We don't validate the backend queue numbers against bus limitation, this will easily crash qemu if it exceeds the limitation which will hit the abort() in virtio_del_queue(). An example is trying to starting a virtio-net device with 256 queues. E.g: ./qemu-system-x86_64 -netdev

[Qemu-devel] [PULL 1/3] acpi: Add missing GCC_FMT_ATTR to local function

2015-03-25 Thread Michael S. Tsirkin
From: Stefan Weil This fixes these gcc warnings (not enabled in default build): hw/acpi/aml-build.c:83:5: warning: function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] hw/acpi/aml-build.c:88:5: warning: function might be possible candidate for ‘g

[Qemu-devel] [PULL 2/3] virtio-serial: fix virtio config size

2015-03-25 Thread Michael S. Tsirkin
commit 9b70c1790acacae54d559d38ca69186a85040bb8 virtio-serial: switch to standard-headers changes virtio_console_config size from 8 to 12 bytes: it adds an optional 4 byte emerg_wr field. As this crosses a power of two boundary, this changes the PCI BAR size, which breaks migration compatibil

[Qemu-devel] [PULL 0/3] pc, virtio bugfixes for 2.3

2015-03-25 Thread Michael S. Tsirkin
The following changes since commit 054903a832b865eb5432d79b5c9d1e1ff31b58d7: Update version for v2.3.0-rc1 release (2015-03-24 16:34:16 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to 7e0e736e

Re: [Qemu-devel] [PATCH v4] block: Switch to host monotonic clock for IO throttling

2015-03-25 Thread Stefan Hajnoczi
On Wed, Mar 25, 2015 at 03:27:26PM +0800, Fam Zheng wrote: > Currently, throttle timers won't make any progress when VCPU is not > running, which would stall the request queue in utils, qtest, vm > suspending, and live migration, without special handling. > > Block jobs are confusingly inconsisten

Re: [Qemu-devel] Support for NetLogic XLP Processors

2015-03-25 Thread Duarte Silva
On Wednesday 25 March 2015 14:54:41 Leon Alrae wrote: > On 25/03/2015 14:44, Leon Alrae wrote: > > Hi Duarte, > > > > On 25/03/2015 14:20, Duarte Silva wrote: > >> On Wednesday 25 March 2015 13:13:14 James Hogan wrote: > >>> Hi Duarte, > >>> > >>> On 22/03/15 11:13, Duarte Silva wrote: > Hi

Re: [Qemu-devel] [Qemu-block] [RFC PATCH COLO v2 01/13] docs: block replication's description

2015-03-25 Thread Eric Blake
On 03/25/2015 03:36 AM, Wen Congyang wrote: > Signed-off-by: Wen Congyang > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Hongyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > --- > docs/block-replication.txt | 147 > + > 1 file c

Re: [Qemu-devel] [PATCH] target-tricore: Fix check which was always false

2015-03-25 Thread Bastian Koppelmann
On 03/25/2015 04:20 PM, Michael Tokarev wrote: 21.03.2015 16:44, Stefan Weil wrote: With a mask value of 0x0040, the result will never be 1. This fixes a Coverity warning. Might be a bit risky if the whole thing wasn't a complete no-op. I wonder maybe the whole this if statement should be

Re: [Qemu-devel] [RFC PATCH COLO v2 04/13] Add new block driver interfaces to control block replication

2015-03-25 Thread Eric Blake
On 03/25/2015 06:48 AM, Paolo Bonzini wrote: >> ## >> +# @COLOMode >> +# >> +# An enumeration of COLO mode. s/mode/modes/ >> +# >> +# @unprotected: COLO is not started or after failover >> +# >> +# @primary: Primary mode, the vm's state will be sent to secondary QEMU. Inconsistent on whether y

Re: [Qemu-devel] Bouncing maintainers

2015-03-25 Thread John Snow
On 03/25/2015 10:48 AM, Markus Armbruster wrote: I just had another cc: to an address gotten from MAINTAINERS bounce with "user unknown". How do we weed out dead MAINTAINERS entries? Automated spambot that runs once a release cycle and reports back to the list which entries were dead? --

Re: [Qemu-devel] [PATCH 1/2] object: Add can_be_deleted callback to TypeInfo and TypeImpl

2015-03-25 Thread Lin Ma
在 2015年03月23日 21:30, Igor Mammedov 写道: On Mon, 23 Mar 2015 14:13:07 +0100 Andreas Färber wrote: Hi, For consistency in git-log, please use "qom:" rather than "object:". Am 23.03.2015 um 13:06 schrieb Paolo Bonzini: On 23/03/2015 11:36, Peter Crosthwaite wrote: I don't think TypeInfo is th

Re: [Qemu-devel] [PATCH] block: Document blockdev-add's immaturity

2015-03-25 Thread Stefan Hajnoczi
On Fri, Mar 20, 2015 at 02:32:17PM +0100, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > qapi/block-core.json | 4 > qmp-commands.hx | 4 > 2 files changed, 8 insertions(+) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefa

Re: [Qemu-devel] [PATCH RESEND 1/2] Block: Block replication design for COLO

2015-03-25 Thread Eric Blake
On 12/25/2014 08:31 PM, Yang Hongyang wrote: > This is the initial design of block replication. > The blkcolo block driver enables disk replication for continuous > checkpoints. It is designed for COLO that Secondary VM is running. > It can also be applied for FT/HA scene that Secondary VM is not >

Re: [Qemu-devel] [PATCH RESEND 1/2] Block: Block replication design for COLO

2015-03-25 Thread Eric Blake
On 03/25/2015 10:06 AM, Eric Blake wrote: > On 12/25/2014 08:31 PM, Yang Hongyang wrote: >> This is the initial design of block replication. >> The blkcolo block driver enables disk replication for continuous >> checkpoints. It is designed for COLO that Secondary VM is running. >> It can al

Re: [Qemu-devel] [RFC PATCH v2 19/23] spapr: CPU hot unplug support

2015-03-25 Thread Bharata B Rao
On Wed, Mar 25, 2015 at 04:44:48PM +1100, David Gibson wrote: > On Mon, Mar 23, 2015 at 07:06:00PM +0530, Bharata B Rao wrote: > > Support hot removal of CPU for sPAPR guests by sending the hot > > unplug notification to the guest via EPOW interrupt. > > > > Signed-off-by: Bharata B Rao > > --- >

Re: [Qemu-devel] [PATCH v5 20/45] Modify savevm handlers for postcopy

2015-03-25 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > On Tue, Mar 24, 2015 at 08:04:14PM +, Dr. David Alan Gilbert wrote: > > > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > > > On Fri, Mar 20, 2015 at 12:37:59PM +, Dr. Dav

Re: [Qemu-devel] [PATCH RFC 3/4] pc: Create sockets and cores for CPUs

2015-03-25 Thread Bharata B Rao
On Mon, Mar 23, 2015 at 11:02 PM, Andreas Färber wrote: > Inline realized=true from pc_new_cpu() so that the realization can be > deferred, as it would otherwise create a device[n] node. > > Signed-off-by: Andreas Färber > --- > hw/i386/pc.c | 66 > ++

Re: [Qemu-devel] [PATCH RFC 3/4] pc: Create sockets and cores for CPUs

2015-03-25 Thread Andreas Färber
Am 25.03.2015 um 17:55 schrieb Bharata B Rao: > On Mon, Mar 23, 2015 at 11:02 PM, Andreas Färber wrote: >> Inline realized=true from pc_new_cpu() so that the realization can be >> deferred, as it would otherwise create a device[n] node. >> >> Signed-off-by: Andreas Färber >> --- >> hw/i386/pc.c

Re: [Qemu-devel] Support for NetLogic XLP Processors

2015-03-25 Thread Leon Alrae
On 25/03/2015 15:38, Duarte Silva wrote: > On Wednesday 25 March 2015 14:54:41 Leon Alrae wrote: >> On 25/03/2015 14:44, Leon Alrae wrote: >>> Hi Duarte, >>> >>> On 25/03/2015 14:20, Duarte Silva wrote: On Wednesday 25 March 2015 13:13:14 James Hogan wrote: > Hi Duarte, > > On 22/0

Re: [Qemu-devel] [PATCH v5 33/45] Page request: Process incoming page request

2015-03-25 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Wed, Feb 25, 2015 at 04:51:56PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > On receiving MIG_RPCOMM_REQ_PAGES look up the address and > > queue the page. > > > > Signed-off-by: Dr. David Alan Gilbe

Re: [Qemu-devel] [PATCH v5 35/45] postcopy_ram.c: place_page and helpers

2015-03-25 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Wed, Feb 25, 2015 at 04:51:58PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > postcopy_place_page (etc) provide a way for postcopy to place a page > > into guests memory atomically (using the copy ioc

Re: [Qemu-devel] [PATCH 0/3] hw/arm: add Fixed Virtual Platform VE support

2015-03-25 Thread Sergey Fedorov
On 25.03.2015 04:06, Peter Maydell wrote: > On 25 March 2015 at 01:43, Sergey Fedorov wrote: >> On 24.03.2015 18:30, Sergey Fedorov wrote: >>> So if I understand you correctly, it would be suitable to implement a >>> model like Juno ARM Development Platform in order to get AArch64 VE >>> model w

Re: [Qemu-devel] [PATCH v5 32/45] Page request: Add MIG_RP_CMD_REQ_PAGES reverse command

2015-03-25 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Wed, Feb 25, 2015 at 04:51:55PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Add MIG_RP_CMD_REQ_PAGES command on Return path for the postcopy > > destination to request a page from the source. > > >

[Qemu-devel] [PATCH for-2.3 v2 2/4] qtest: Add qtest_add() wrapper macro

2015-03-25 Thread Andreas Färber
It extends g_test_add() macro with the architecture path. Signed-off-by: Andreas Färber --- tests/libqtest.h | 20 1 file changed, 20 insertions(+) diff --git a/tests/libqtest.h b/tests/libqtest.h index 9281f5c..03469b8 100644 --- a/tests/libqtest.h +++ b/tests/libqtest.h @

[Qemu-devel] [PATCH for-2.3 v2 1/4] qtest: Add qtest_add_data_func() wrapper function

2015-03-25 Thread Andreas Färber
It calls g_test_add_data_func() with a path supplemented by the architecture, like qtest_add_func() does. Reviewed-by: John Snow Reviewed-by: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/libqtest.c | 7 +++ tests/libqtest.h | 12 2 files changed, 19 insertions(+)

[Qemu-devel] [PATCH v2 4/4] tests: Use qtest_add_data_func() consistently

2015-03-25 Thread Andreas Färber
Replace uses of g_test_add_data_func() for QTest test cases. It is still valid to use it for any non-QTest test cases, which are not run for multiple target binaries. Suggested-by: John Snow Signed-off-by: Andreas Färber --- tests/ahci-test.c | 9 ++--- tests/e1000-test.c | 4

[Qemu-devel] [PATCH for-2.3 v2 3/4] i440fx-test: Fix test paths to include architecture

2015-03-25 Thread Andreas Färber
Replace g_test_add_func() with new qtest_add_func() and g_test_add() macro with qtest_add() macro. Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber --- tests/i440fx-test.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/i440fx-test.c b/tests/i440fx-

[Qemu-devel] [PATCH for-2.3 v2 0/4] qtest: Fix remaining test paths to include architecture

2015-03-25 Thread Andreas Färber
Hello, This mini-series fixes the last remaining GTester paths to indicate the architecture they are executed for (i386 vs. x86_64). Unlike the previous fw_cfg-test patch, there are no libqtest wrappers adding the architecture yet; other tests manually constructed a correct path to pass to g_test

Re: [Qemu-devel] [PATCH v5 01/28] qapi: Document type-safety considerations

2015-03-25 Thread Markus Armbruster
Eric Blake writes: > Go into more details about the various types of valid expressions > in a qapi schema, including tweaks to document fixes being done > later in the current patch series. Also fix some stale and missing > documentation in the QMP specification. > > Signed-off-by: Eric Blake >

Re: [Qemu-devel] [PATCH v5 11/45] Return path: Send responses from destination to source

2015-03-25 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Tue, Mar 10, 2015 at 02:34:03PM +, Dr. David Alan Gilbert wrote: > > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > > On Wed, Feb 25, 2015 at 04:51:34PM +, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David A

Re: [Qemu-devel] [PATCH 1/8] rc4030: create custom DMA address space

2015-03-25 Thread Hervé Poussineau
Le 25/03/2015 15:45, Paolo Bonzini a écrit : On 05/03/2015 23:13, Hervé Poussineau wrote: Add a new memory region in system address space where DMA address space definition (the 'translation table') belongs, so we can update on the fly the DMA address space. Signed-off-by: Hervé Poussineau

[Qemu-devel] [PATCH] tcg: optimise memory layout of TCGTemp

2015-03-25 Thread Emilio G. Cota
This brings down the size of the struct from 56 to 32 bytes on 64-bit, and to 16 bytes on 32-bit. The appended adds macros to prevent us from mistakenly overflowing the bitfields when more elements are added to the corresponding enums/macros. Note that reg/mem_reg need only 6 bits (for ia64) but

Re: [Qemu-devel] [PATCH v5 01/28] qapi: Document type-safety considerations

2015-03-25 Thread Eric Blake
On 03/25/2015 12:31 PM, Markus Armbruster wrote: > Eric Blake writes: > >> Go into more details about the various types of valid expressions >> in a qapi schema, including tweaks to document fixes being done >> later in the current patch series. Also fix some stale and missing >> documentation i

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-25 Thread Andrey Korolyov
On Mon, Mar 16, 2015 at 10:17 PM, Andrey Korolyov wrote: > For now, it looks like bug have a mixed Murphy-Heisenberg nature, as > it appearance is very rare (compared to the number of actual launches) > and most probably bounded to the physical characteristics of my > production nodes. As soon as

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-25 Thread Andrey Korolyov
> - attach serial console (I am using virsh list for this exact purpose), virsh console of course, sorry

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-25 Thread Kevin O'Connor
On Wed, Mar 25, 2015 at 11:43:31PM +0300, Andrey Korolyov wrote: > On Mon, Mar 16, 2015 at 10:17 PM, Andrey Korolyov wrote: > > For now, it looks like bug have a mixed Murphy-Heisenberg nature, as > > it appearance is very rare (compared to the number of actual launches) > > and most probably boun

Re: [Qemu-devel] [PATCH v5 01/28] qapi: Document type-safety considerations

2015-03-25 Thread Eric Blake
On 03/25/2015 02:11 PM, Eric Blake wrote: >> The QObject types are QTYPE_NONE, QTYPE_QINT, QTYPE_QSTRING, >> QTYPE_QDICT, QTYPE_QLIST, QTYPE_QFLOAT, QTYPE_QBOOL, QTYPE_QERROR. >> >> The connections JSON string - QTYPE_QSTRING, JSON object - QTYPE_QDICT, >> JSON array - QTYPE_QLIST and JSON boolean

[Qemu-devel] [PULL 2.3 0/5] ppc patch queue 2015-03-25 for 2.3

2015-03-25 Thread Alexander Graf
Hi Peter, This is my current patch queue for ppc against 2.3. Please pull. Alex The following changes since commit 054903a832b865eb5432d79b5c9d1e1ff31b58d7: Update version for v2.3.0-rc1 release (2015-03-24 16:34:16 +) are available in the git repository at: git://github.com/agraf/q

[Qemu-devel] [PULL 2.3 3/5] target-ppc: Remove POWER5+ v0.0 that never existed

2015-03-25 Thread Alexander Graf
From: Alexey Kardashevskiy IBM uses low 16bits to specify the chip version of a POWER CPU. So there has never been an actual silicon with PVR = 0x003B. The first silicon would have PVR 0x003B0100 but it is very unlikely to find it in any machine shipped to any customer as it was too raw. Thi

[Qemu-devel] [PULL 2.3 2/5] spapr: Add missing checks for NULL pointers and report failures

2015-03-25 Thread Alexander Graf
From: Stefan Weil This fixes potential runtime crashes and two warnings from Coverity. The new error message does not add a prefix "qemu:" because that is already done in function hw_error. It also starts with an uppercase letter because that seems to be the mostly used form. Signed-off-by: St

[Qemu-devel] [PULL 2.3 5/5] powerpc: fix -machine usb=no for newworld and pseries machines

2015-03-25 Thread Alexander Graf
From: Paolo Bonzini Capture the explicit setting of "usb=no" into a separate bool, and use it to skip the update of machine->usb in the board init function. Signed-off-by: Paolo Bonzini Signed-off-by: Alexander Graf --- hw/core/machine.c | 1 + hw/ppc/mac_newworld.c | 2 +- hw/ppc/spapr.c

[Qemu-devel] [PULL 2.3 4/5] PPC: pseries: Implement boot once=foo

2015-03-25 Thread Alexander Graf
On sPAPR we haven't supported boot once ever since it emerged, but recently grew need for it. This patch implements boot once logic to it. While at it, we also move to the new bootdevice handling that got introduced to the tree recently. Reported-by: Dinar Valeev Signed-off-by: Alexander Graf -

[Qemu-devel] [PULL 2.3 1/5] pseries: Update SLOF firmware image to qemu-slof-20150313

2015-03-25 Thread Alexander Graf
From: Alexey Kardashevskiy The changelog is: > virtio: Fix vring allocation > helpers: Fix SLOF_alloc_mem_aligned to meet callers expectation > Set default palette according to "16-color Text Extension" document > Fix rectangle drawing functions to work also with higher bit depths > Fix

Re: [Qemu-devel] GSoC Proposal: ARM Virtualization Extensions

2015-03-25 Thread Merten Sach
On 24/03/15 14:47, Sergey Fedorov wrote: > On 23.03.2015 04:29, Merten Sach wrote: >> On 21/03/15 04:16, Sergey Fedorov wrote: >>> Hi! >>> >>> I am currently working on AArch64 EL2 support. There is a plan to submit >>> the changes to the community. Merten, IIUYC, you are going to support >>> only

Re: [Qemu-devel] [PATCH for-2.3 v2 2/4] qtest: Add qtest_add() wrapper macro

2015-03-25 Thread John Snow
On 03/25/2015 02:20 PM, Andreas Färber wrote: It extends g_test_add() macro with the architecture path. Signed-off-by: Andreas Färber --- tests/libqtest.h | 20 1 file changed, 20 insertions(+) diff --git a/tests/libqtest.h b/tests/libqtest.h index 9281f5c..03469b8 10

Re: [Qemu-devel] [PATCH for-2.3 v2 3/4] i440fx-test: Fix test paths to include architecture

2015-03-25 Thread John Snow
On 03/25/2015 02:20 PM, Andreas Färber wrote: Replace g_test_add_func() with new qtest_add_func() and g_test_add() macro with qtest_add() macro. Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber --- tests/i440fx-test.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(

Re: [Qemu-devel] [PATCH v2 4/4] tests: Use qtest_add_data_func() consistently

2015-03-25 Thread John Snow
On 03/25/2015 02:20 PM, Andreas Färber wrote: Replace uses of g_test_add_data_func() for QTest test cases. It is still valid to use it for any non-QTest test cases, which are not run for multiple target binaries. Suggested-by: John Snow Signed-off-by: Andreas Färber --- tests/ahci-test.c

Re: [Qemu-devel] [PATCH v2 0/2] ahci: test varying sector offsets

2015-03-25 Thread John Snow
On 03/25/2015 08:55 AM, Stefan Hajnoczi wrote: On Fri, Mar 13, 2015 at 03:22:01PM -0400, John Snow wrote: This is a re-send of patches 7 & 8 from an earlier series, "[PATCH v2 0/8] ahci: add more IO tests" which ultimately got bounced back because I used some glib functions that were too new.

Re: [Qemu-devel] [PATCH v2 0/6] ahci: rerror/werror=stop resume tests

2015-03-25 Thread John Snow
On 03/10/2015 04:14 PM, John Snow wrote: This series is based on: "[Qemu-devel] [PATCH 0/2] ahci: test varying sector offsets" There appear to be some upstream issues for iotests 051 and 061, but this series does not appear to alter the existing bad behavior of those tests. This patchset bring

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-25 Thread Andrey Korolyov
On Wed, Mar 25, 2015 at 11:54 PM, Kevin O'Connor wrote: > On Wed, Mar 25, 2015 at 11:43:31PM +0300, Andrey Korolyov wrote: >> On Mon, Mar 16, 2015 at 10:17 PM, Andrey Korolyov wrote: >> > For now, it looks like bug have a mixed Murphy-Heisenberg nature, as >> > it appearance is very rare (compare

[Qemu-devel] [PATCH v5 2/4] configure: factor out supported flag check

2015-03-25 Thread John Snow
Factor out the function that checks if a compiler flag is supported or not. Signed-off-by: John Snow --- configure | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/configure b/configure index 7a8637e..3e71bb8 100755 --- a/configure +++ b/con

[Qemu-devel] [PATCH v5 4/4] configure: Add workaround for ccache and clang

2015-03-25 Thread John Snow
Test if ccache is interfering with semantic analysis of macros, disable its habit of trying to compile already pre-processed versions of code if so. ccache attempts to save time by compiling pre-processed versions of code, but this disturbs clang's static analysis enough to produce false positives.

[Qemu-devel] [PATCH v5 3/4] configure: silence glib unknown attribute __alloc_size__

2015-03-25 Thread John Snow
The glib headers use GCC attributes. Unfortunately the __GNUC__ and __GNUC_MINOR__ version macros are also defined by clang, but clang doesn't support the same attributes as GCC. clang 3.5.0 does not support the __alloc_size__ attribute: https://github.com/llvm-mirror/clang/commit/c047507a9a7

[Qemu-devel] [PATCH v5 0/4] configure: clang 3.5.0 build fixes

2015-03-25 Thread John Snow
QEMU does not compile cleanly under clang 3.5.0. These patches eliminate the avalanche of warnings and make the build usable. The result is that you *should* be able to use clang 3.5.0 *with* ccache and -Werror and produce all targets. Regrettably, this is v5 because I overlooked deleting "--kee

<    1   2   3   >