Re: [Qemu-devel] [PATCH V6 for-2.3 00/26] hw/pc: implement multiple primary busses for pc machines

2015-03-20 Thread Peter Maydell
On 20 March 2015 at 17:56, Paolo Bonzini wrote: > I understand, but you have to draw a line somewhere. The easiest place > to draw the line is 2.3.0-rc0. I definitely agree -- looking at the diffstat and the scope of the patch, this is definitely not suitable for committing to master after hardf

Re: [Qemu-devel] [PATCH for-2.3] linux-user: fix emulation of splice syscall

2015-03-20 Thread Andreas Färber
Am 10.03.2015 um 17:27 schrieb Peter Maydell: > On 10 March 2015 at 16:23, Andreas Schwab wrote: >> Peter Maydell writes: >> >>> What's changed? >> >> Only the title. > > Please don't drop all the reviewed-by: you got on the first > version, then! i.e., Reviewed-by: Peter Maydell Ping for -r

Re: [Qemu-devel] [PATCH v5 12/45] Return path: Source handling of return path

2015-03-20 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Wed, Feb 25, 2015 at 04:51:35PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Open a return path, and handle messages that are received upon it. > > > > Signed-off-by: Dr. David Alan Gilbert > > ---

Re: [Qemu-devel] [PATCH v2 4/5] fw_cfg: prohibit insertion of duplicate fw_cfg file names

2015-03-20 Thread Laszlo Ersek
On 03/20/15 15:34, Gabriel L. Somlo wrote: > On Fri, Mar 20, 2015 at 07:51:06AM +0100, Laszlo Ersek wrote: >> Here's an idea I had this morning. >> >> This series gives equal rank to fw_cfg file names that originate >> internally and those that come from the user, via the command line. >> >> That m

Re: [Qemu-devel] [PATCH v2 5/5] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-03-20 Thread Gabriel L. Somlo
On Fri, Mar 20, 2015 at 02:01:25PM -0400, Gabriel L. Somlo wrote: > On Thu, Mar 19, 2015 at 06:38:53PM +0100, Laszlo Ersek wrote: > > H... that's messy, again. fw_cfg is built into the qemu binary only > > if you have CONFIG_SOFTMMU. I guess something like this should work: > > > > #ifdef CONF

Re: [Qemu-devel] [PATCH v5 13/45] ram_debug_dump_bitmap: Dump a migration bitmap as text

2015-03-20 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Wed, Feb 25, 2015 at 04:51:36PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Misses out lines that are all the expected value so the output > > can be quite compact depending on the circumstance. > >

Re: [Qemu-devel] [PATCH] hw/arm/vexpress: Fix memory leak reported by Coverity

2015-03-20 Thread Stefan Weil
Am 14.03.2015 um 12:50 schrieb Stefan Weil: As the conditional statement had to be splitted anyway, we can also add a better error report message. Signed-off-by: Stefan Weil --- hw/arm/virt.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) Superseded by new patch v2.

Re: [Qemu-devel] [PATCH] hw/arm/vexpress: Fix memory leak reported by Coverity

2015-03-20 Thread Stefan Weil
Am 15.03.2015 um 03:33 schrieb Eric Blake: On 03/14/2015 04:59 AM, Stefan Weil wrote: As the conditional statement had to be splitted anyway, we can also s/splitted/split/ (one of those weird English words that has the same spelling for both present and past tenses) Thanks. This is fixed in v

[Qemu-devel] [PATCH v2] hw/arm/vexpress: Fix memory leak reported by Coverity

2015-03-20 Thread Stefan Weil
As the conditional statement had to be split anyway, we can also add a better error report message. Signed-off-by: Stefan Weil --- v2: Fix commit message. Thank you to Eric Blake for his hint. hw/arm/vexpress.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/h

[Qemu-devel] [PATCH v2] hw/arm/virt: Fix memory leak reported by Coverity

2015-03-20 Thread Stefan Weil
As the conditional statement had to be split anyway, we can also add a better error report message. Signed-off-by: Stefan Weil --- v2: Fix commit message. hw/arm/virt.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index b652b07..7

Re: [Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name()

2015-03-20 Thread Max Reitz
On 2015-03-20 at 10:33, Alberto Garcia wrote: This function gets the device name associated with a BlockDriverState, or its node name if the device name is empty. Signed-off-by: Alberto Garcia --- block.c | 9 + block/quorum.c| 5 + include/block/block.h |

[Qemu-devel] [PATCH v4 03/20] qmp: Ensure consistent granularity type

2015-03-20 Thread John Snow
We treat this field with a variety of different types everywhere in the code. Now it's just uint32_t. Reviewed-by: Eric Blake Reviewed-by: Max Reitz Reviewed-by: Stefan Hajnoczi Signed-off-by: John Snow --- block.c | 11 ++- block/mirror.c| 4 ++-- inclu

[Qemu-devel] [PATCH v4 04/20] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove

2015-03-20 Thread John Snow
The new command pair is added to manage a user created dirty bitmap. The dirty bitmap's name is mandatory and must be unique for the same device, but different devices can have bitmaps with the same names. The granularity is an optional field. If it is not specified, we will choose a default granu

[Qemu-devel] [PATCH v4 08/20] block: Add bitmap disabled status

2015-03-20 Thread John Snow
Add a status indicating the enabled/disabled state of the bitmap. A bitmap is by default enabled, but you can lock the bitmap into a read-only state by setting disabled = true. A previous version of this patch added a QMP interface for changing the state of the bitmap, but it has since been remove

[Qemu-devel] [PATCH v4 00/20] block: transactionless incremental backup series

2015-03-20 Thread John Snow
I've run out of cheeky jokes for my cover letters. This patchset enables the in-memory part of the incremental backup feature, without transactional support. Support for transactions was separated into a separate series which is also now available on-list. Getting this portion of the series commi

[Qemu-devel] [PATCH v4 06/20] hbitmap: cache array lengths

2015-03-20 Thread John Snow
As a convenience: between incremental backups, bitmap migrations and bitmap persistence we seem to need to recalculate these a lot. Because the lengths are a little bit-twiddly, let's just solidly cache them and be done with it. Reviewed-by: Max Reitz Signed-off-by: John Snow --- util/hbitmap.

[Qemu-devel] [PATCH v4 05/20] block: Introduce bdrv_dirty_bitmap_granularity()

2015-03-20 Thread John Snow
This returns the granularity (in bytes) of dirty bitmap, which matches the QMP interface and the existing query interface. Signed-off-by: John Snow Reviewed-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block.c | 8 ++-- include/block/block.h | 1 +

[Qemu-devel] [PATCH v4 01/20] docs: incremental backup documentation

2015-03-20 Thread John Snow
Reviewed-by: Max Reitz Signed-off-by: John Snow --- docs/bitmaps.md | 311 1 file changed, 311 insertions(+) create mode 100644 docs/bitmaps.md diff --git a/docs/bitmaps.md b/docs/bitmaps.md new file mode 100644 index 000..ad8c33b --

[Qemu-devel] [PATCH v4 18/20] iotests: add QMP event waiting queue

2015-03-20 Thread John Snow
A filter is added to allow callers to request very specific events to be pulled from the event queue, while leaving undesired events still in the stream. This allows to poll for completion data for multiple asynchronous events in any arbitrary order. Signed-off-by: John Snow Reviewed-by: Max Rei

[Qemu-devel] [PATCH v4 09/20] block: Add bitmap successors

2015-03-20 Thread John Snow
A bitmap successor is an anonymous BdrvDirtyBitmap that is intended to be created just prior to a sensitive operation (e.g. Incremental Backup) that can either succeed or fail, but during the course of which we still want a bitmap tracking writes. On creating a successor, we "freeze" the parent bi

[Qemu-devel] [PATCH v4 15/20] block: Resize bitmaps on bdrv_truncate

2015-03-20 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Max Reitz --- block.c| 18 + include/qemu/hbitmap.h | 10 ++ util/hbitmap.c | 52 ++ 3 files changed, 80 insertions(+) diff --git a/block.c b/block.c index 81d17

[Qemu-devel] [PATCH v4 07/20] hbitmap: add hbitmap_merge

2015-03-20 Thread John Snow
We add a bitmap merge operation to assist in error cases where we wish to combine two bitmaps together. This is algorithmically O(bits) provided HBITMAP_LEVELS remains constant. For a full bitmap on a 64bit machine: sum(bits/64^k, k, 0, HBITMAP_LEVELS) ~= 1.01587 * bits We may be able to improve

[Qemu-devel] [PATCH v4 19/20] iotests: add simple incremental backup case

2015-03-20 Thread John Snow
Signed-off-by: John Snow --- tests/qemu-iotests/124 | 153 + tests/qemu-iotests/124.out | 4 +- 2 files changed, 155 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/124 b/tests/qemu-iotests/124 index 85675ec..ce2cda7 100644 --- a/te

[Qemu-devel] [PATCH v4 10/20] qmp: Add support of "dirty-bitmap" sync mode for drive-backup

2015-03-20 Thread John Snow
For "dirty-bitmap" sync mode, the block job will iterate through the given dirty bitmap to decide if a sector needs backup (backup all the dirty clusters and skip clean ones), just as allocation conditions of "top" sync mode. Signed-off-by: Fam Zheng Signed-off-by: John Snow Reviewed-by: Max Rei

[Qemu-devel] [PATCH v4 17/20] iotests: add invalid input incremental backup tests

2015-03-20 Thread John Snow
Signed-off-by: John Snow --- tests/qemu-iotests/124 | 104 + tests/qemu-iotests/124.out | 5 +++ tests/qemu-iotests/group | 1 + 3 files changed, 110 insertions(+) create mode 100644 tests/qemu-iotests/124 create mode 100644 tests/qemu-iotes

[Qemu-devel] [PATCH v4 02/20] qapi: Add optional field "name" to block dirty bitmap

2015-03-20 Thread John Snow
From: Fam Zheng This field will be set for user created dirty bitmap. Also pass in an error pointer to bdrv_create_dirty_bitmap, so when a name is already taken on this BDS, it can report an error message. This is not global check, two BDSes can have dirty bitmap with a common name. Implemented

[Qemu-devel] [PATCH v4 12/20] qmp: Add dirty bitmap status field in query-block

2015-03-20 Thread John Snow
Add the "frozen" status booleans, to inform clients when a bitmap is occupied doing a task. Signed-off-by: Fam Zheng Signed-off-by: John Snow Reviewed-by: Max Reitz --- block.c | 1 + qapi/block-core.json | 5 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/blo

[Qemu-devel] [PATCH v4 13/20] block: add BdrvDirtyBitmap documentation

2015-03-20 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Max Reitz --- block.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index 005b535..c2e1b27 100644 --- a/block.c +++ b/block.c @@ -60,11 +60,11 @@ * or enabled. A frozen bitmap can only abdicate() or re

[Qemu-devel] [PATCH v4 11/20] qmp: add block-dirty-bitmap-clear

2015-03-20 Thread John Snow
Add bdrv_clear_dirty_bitmap and a matching QMP command, qmp_block_dirty_bitmap_clear that enables a user to reset the bitmap attached to a drive. This allows us to reset a bitmap in the event of a full drive backup. Signed-off-by: John Snow Reviewed-by: Max Reitz --- block.c | 8

Re: [Qemu-devel] [PATCH 2/3] block: use bdrv_get_device_or_node_name() in error messages

2015-03-20 Thread Max Reitz
On 2015-03-20 at 10:33, Alberto Garcia wrote: There are several error messages that identify a BlockDriverState by its device name. However those errors can be produced in nodes that don't have a device name associated. In those cases we should use bdrv_get_device_or_node_name() to fall back to

[Qemu-devel] [PATCH v4 16/20] hbitmap: truncate tests

2015-03-20 Thread John Snow
The general approach is to set bits close to the boundaries of where we are truncating and ensure that everything appears to have gone OK. We test growing and shrinking by different amounts: - Less than the granularity - Less than the granularity, but across a boundary - Less than sizeof(unsigned

[Qemu-devel] [PATCH v4 14/20] block: Ensure consistent bitmap function prototypes

2015-03-20 Thread John Snow
We often don't need the BlockDriverState for functions that operate on bitmaps. Remove it. Signed-off-by: John Snow Reviewed-by: Max Reitz --- block.c | 13 ++--- block/backup.c| 2 +- block/mirror.c| 26 ++ blockdev.c|

[Qemu-devel] [PATCH v4 20/20] iotests: add incremental backup failure recovery test

2015-03-20 Thread John Snow
Test the failure case for incremental backups. Signed-off-by: John Snow --- blockdev.c | 1 - tests/qemu-iotests/124 | 55 ++ tests/qemu-iotests/124.out | 4 ++-- 3 files changed, 57 insertions(+), 3 deletions(-) diff --git a/blo

Re: [Qemu-devel] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED

2015-03-20 Thread Max Reitz
On 2015-03-20 at 10:33, Alberto Garcia wrote: Since this event can occur in nodes that cannot have a device name associated, include also a field with the node name. Signed-off-by: Alberto Garcia --- block/qcow2.c | 8 ++-- docs/qmp/qmp-events.txt | 16 +--- qapi/

Re: [Qemu-devel] [PATCH v4 04/20] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove

2015-03-20 Thread Max Reitz
On 2015-03-20 at 15:16, John Snow wrote: The new command pair is added to manage a user created dirty bitmap. The dirty bitmap's name is mandatory and must be unique for the same device, but different devices can have bitmaps with the same names. The granularity is an optional field. If it is no

Re: [Qemu-devel] [PATCH v4 16/20] hbitmap: truncate tests

2015-03-20 Thread Max Reitz
On 2015-03-20 at 15:16, John Snow wrote: The general approach is to set bits close to the boundaries of where we are truncating and ensure that everything appears to have gone OK. We test growing and shrinking by different amounts: - Less than the granularity - Less than the granularity, but acr

Re: [Qemu-devel] [PATCH v4 17/20] iotests: add invalid input incremental backup tests

2015-03-20 Thread Max Reitz
On 2015-03-20 at 15:17, John Snow wrote: Signed-off-by: John Snow --- tests/qemu-iotests/124 | 104 + tests/qemu-iotests/124.out | 5 +++ tests/qemu-iotests/group | 1 + 3 files changed, 110 insertions(+) create mode 100644 tests/qemu-

Re: [Qemu-devel] [PATCH v4 20/20] iotests: add incremental backup failure recovery test

2015-03-20 Thread Max Reitz
On 2015-03-20 at 15:17, John Snow wrote: Test the failure case for incremental backups. Signed-off-by: John Snow --- blockdev.c | 1 - tests/qemu-iotests/124 | 55 ++ tests/qemu-iotests/124.out | 4 ++-- 3 files changed, 57

Re: [Qemu-devel] [PATCH v4 19/20] iotests: add simple incremental backup case

2015-03-20 Thread Max Reitz
On 2015-03-20 at 15:17, John Snow wrote: Signed-off-by: John Snow --- tests/qemu-iotests/124 | 153 + tests/qemu-iotests/124.out | 4 +- 2 files changed, 155 insertions(+), 2 deletions(-) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH v4 00/20] block: transactionless incremental backup series

2015-03-20 Thread Max Reitz
On 2015-03-20 at 15:16, John Snow wrote: I've run out of cheeky jokes for my cover letters. This patchset enables the in-memory part of the incremental backup feature, without transactional support. Support for transactions was separated into a separate series which is also now available on-lis

Re: [Qemu-devel] [PATCH v4 00/20] block: transactionless incremental backup series

2015-03-20 Thread John Snow
On 03/20/2015 03:52 PM, Max Reitz wrote: On 2015-03-20 at 15:16, John Snow wrote: I've run out of cheeky jokes for my cover letters. This patchset enables the in-memory part of the incremental backup feature, without transactional support. Support for transactions was separated into a separa

Re: [Qemu-devel] Mac OS X no longer boots from cd

2015-03-20 Thread Programmingkid
On Mar 20, 2015, at 4:03 AM, Mark Cave-Ayland wrote: > On 20/03/15 02:38, Programmingkid wrote: > >> On Mar 19, 2015, at 11:29 AM, Alexander Graf wrote: >> >>> >>> >>> On 19.03.15 15:50, Programmingkid wrote: On Mar 19, 2015, at 3:18 AM, Alexander Graf wrote: > > >>

Re: [Qemu-devel] Mac OS X no longer boots from cd

2015-03-20 Thread John Snow
On 03/20/2015 04:08 PM, Programmingkid wrote: On Mar 20, 2015, at 4:03 AM, Mark Cave-Ayland wrote: On 20/03/15 02:38, Programmingkid wrote: On Mar 19, 2015, at 11:29 AM, Alexander Graf wrote: On 19.03.15 15:50, Programmingkid wrote: On Mar 19, 2015, at 3:18 AM, Alexander Graf wrote:

[Qemu-devel] [PATCH 0/6 v7] tilegx: Firstly add tilegx feature for linux-user

2015-03-20 Thread Chen Gang
After load elf64 binary, qemu tilegx can finish executing the first system call (uname) successfully in _dl_discover_osversion(), and return to __libc_start_main(). Chen Gang (6): target-tilegx: Firstly add TILE-Gx with minimized features linux-user: tilegx: Firstly add architecture related f

Re: [Qemu-devel] [PATCH 0/6 v7] tilegx: Firstly add tilegx feature for linux-user

2015-03-20 Thread Chen Gang
Sorry, I sent send the mail by my another mail address (it is incorrect). I should send them again by my xili_gchen_5...@hotmail.com. Thanks. On 3/20/15 23:18, Chen Gang wrote: > After load elf64 binary, qemu tilegx can finish executing the first > system call (uname) successfully in _dl_discov

[Qemu-devel] GSoC Proposal: ARM Virtualization Extensions

2015-03-20 Thread Merten Sach
Hi, I'm interested in participating in this years edition of Google Summer of Code. I the last years I did a lot of work on hypervisors. Currently I'm working with a hypervisor on ARM for my master degree. On previous projects using x86, the ability to do a quick debugging run using QEMU with S

Re: [Qemu-devel] PCI passthrough of 40G ethernet interface (Openstack/KVM)

2015-03-20 Thread jacob jacob
On Thu, Mar 19, 2015 at 10:18 AM, Stefan Assmann wrote: > On 19.03.2015 15:04, jacob jacob wrote: >> Hi Stefan, >> have you been able to get PCI passthrough working without any issues >> after the upgrade? > > My XL710 fails to transfer regular TCP traffic (netperf). If that works > for you then y

Re: [Qemu-devel] Mac OS X no longer boots from cd

2015-03-20 Thread Programmingkid
On Mar 20, 2015, at 4:35 PM, John Snow wrote: > > > On 03/20/2015 04:08 PM, Programmingkid wrote: >> >> On Mar 20, 2015, at 4:03 AM, Mark Cave-Ayland wrote: >> >>> On 20/03/15 02:38, Programmingkid wrote: >>> On Mar 19, 2015, at 11:29 AM, Alexander Graf wrote: > > >

Re: [Qemu-devel] Mac OS X no longer boots from cd

2015-03-20 Thread John Snow
On 03/20/2015 06:25 PM, Programmingkid wrote: On Mar 20, 2015, at 4:35 PM, John Snow wrote: If you feel like the CD rom boot failure is "new", I'd be very interested to know how recent that failure is. The macio RFC might help, but if you have the cycles to do a bisect upstream, I would a

Re: [Qemu-devel] [PATCH 1/6 v7] target-tilegx: Firstly add TILE-Gx with minimized features

2015-03-20 Thread Chen Gang
On 3/21/15 01:48, Peter Maydell wrote: > On 20 March 2015 at 15:25, Chen Gang wrote: >> It is the configure and build system support for TILE-Gx (tilegx will be >> used in configure and real sub-directory name). >> >> At present, it is linux-user only, and can finish the first system call >> (unam

Re: [Qemu-devel] [PATCH 1/6 v6] target-tilegx: Firstly add TILE-Gx with minimized features

2015-03-20 Thread Chen Gang
On 3/21/15 01:03, Richard Henderson wrote: > On 03/18/2015 07:04 PM, Chen Gang wrote: >> For me, I am not quite sure about it, the related functional description >> is: >> >> rf[Dest] = signExtend32 ((int32_t) rf[SrcA] * (int32_t) rf[SrcB]); >> >> Do you mean it is equal to: >> >> rf[Dest] = si

Re: [Qemu-devel] [PATCH 1/6 v7] target-tilegx: Firstly add TILE-Gx with minimized features

2015-03-20 Thread Peter Maydell
On 20 March 2015 at 22:52, Chen Gang wrote: > On 3/21/15 01:48, Peter Maydell wrote: >> On 20 March 2015 at 15:25, Chen Gang wrote: >>> 10 files changed, 3523 insertions(+) >> >> If you have any patch which has a diffstat like this then >> you *must* split it up into separate patches. Even >> 10

Re: [Qemu-devel] [PATCH 1/6 v7] target-tilegx: Firstly add TILE-Gx with minimized features

2015-03-20 Thread Chen Gang
On 3/21/15 01:45, Richard Henderson wrote: > On 03/20/2015 08:25 AM, Chen Gang wrote: >> +/* >> + * The related functional description for bfextu in isa document: >> + * >> + * uint64_t mask = 0; >> + * mask = (-1ULL) ^ ((-1ULL << ((BFEnd - BFStart) & 63)) << 1); >> + * uint64_t rot_src = (((uint6

Re: [Qemu-devel] [PATCH 1/6 v7] target-tilegx: Firstly add TILE-Gx with minimized features

2015-03-20 Thread Chen Gang
On 3/21/15 07:30, Peter Maydell wrote: > On 20 March 2015 at 22:52, Chen Gang wrote: >> On 3/21/15 01:48, Peter Maydell wrote: >>> On 20 March 2015 at 15:25, Chen Gang wrote: 10 files changed, 3523 insertions(+) >>> >>> If you have any patch which has a diffstat like this then >>> you *must

Re: [Qemu-devel] [PATCH] checkrom: Fix typo in error message

2015-03-20 Thread Kevin O'Connor
On Thu, Mar 19, 2015 at 05:23:19PM +0100, Andreas Färber wrote: > increate -> increase > > Signed-off-by: Andreas Färber Thanks - I added it to my queue. -Kevin

Re: [Qemu-devel] GSoC Proposal: ARM Virtualization Extensions

2015-03-20 Thread Sergey Fedorov
On 20.03.2015 20:44, Peter Maydell wrote: > On 20 March 2015 at 17:25, Merten Sach wrote: >> I'm interested in participating in this years edition of Google Summer of >> Code. >> Initially I wanted to propose the implementation of ARMv7 >> virtualization extensions. I know this is not supported a

Re: [Qemu-devel] GSoC Proposal: ARM Virtualization Extensions

2015-03-20 Thread Edgar E. Iglesias
On Sat, Mar 21, 2015 at 06:16:54AM +0300, Sergey Fedorov wrote: > On 20.03.2015 20:44, Peter Maydell wrote: > > On 20 March 2015 at 17:25, Merten Sach wrote: > >> I'm interested in participating in this years edition of Google Summer of > >> Code. > >> Initially I wanted to propose the implementa

[Qemu-devel] [PATCH] translate-all: remove superfluous #ifdef FOO || 1

2015-03-20 Thread Emilio G. Cota
It always evaluates to true. Signed-off-by: Emilio G. Cota --- translate-all.c | 4 1 file changed, 4 deletions(-) diff --git a/translate-all.c b/translate-all.c index 9f47ce7..11763c6 100644 --- a/translate-all.c +++ b/translate-all.c @@ -1334,8 +1334,6 @@ static inline void tb_alloc_page

[Qemu-devel] [PATCH] translate-all: use bitmap helpers for PageDesc's bitmap

2015-03-20 Thread Emilio G. Cota
Note that this test if (b & ((1 << len) - 1)) can be simplified to if (b & 1) , since we know that iff the first bit of a tb is set, all other bits from that tb are set too. Signed-off-by: Emilio G. Cota --- translate-all.c | 39 +-- 1 file cha

[Qemu-devel] [PATCH] tcg: pack TCGTemp to reduce size by 8 bytes

2015-03-20 Thread Emilio G. Cota
This brings down the size of the struct from 56 to 48 bytes. Signed-off-by: Emilio G. Cota --- tcg/tcg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index add7f75..3276924 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -429,8 +429,8 @@ typedef struct TCGT

<    1   2