On 3/21/15 07:30, Peter Maydell wrote: > On 20 March 2015 at 22:52, Chen Gang <xili_gchen_5...@hotmail.com> wrote: >> On 3/21/15 01:48, Peter Maydell wrote: >>> On 20 March 2015 at 15:25, Chen Gang <xili_gchen_5...@hotmail.com> wrote: >>>> 10 files changed, 3523 insertions(+) >>> >>> If you have any patch which has a diffstat like this then >>> you *must* split it up into separate patches. Even >>> 1000 lines is really too long to be easily >>> reviewable, and this patch is now over three times >>> that size! Most patches should be 250 lines or >>> less, really, unless they're very mechanical. >>> >> >> OK, thanks. I shall try to split it into 3 patches in patch v8. > > Even 3 would still leave at least one of them more than 1000 > lines. I would suggest that you should be thinking more like > turning this one into 7 or 8 patches. >
For 'opcode_tilegx.h', it comes from Linux kernel which is already more than 1000 lines. For me, I still suggest to let it within one patch. For 'translate.c', I try to split it into 3 patches: - parsing bundle and decode to the first level of pipe, - parsing 2nd level of pipe. - generate tcg code. For the left files: - 'configure', 'Makefile.obj', 'tilegx-linux-user.mak' are in a patch. - 'cpu*' are in a patch - 'help.*' are in a patch. Welcome any additional ideas, and I shall try to send it within 2 days (2015-03-22). Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed
