Re: [Qemu-devel] [PATCH] migration: flush the bdrv before stopping VM

2015-03-20 Thread Li, Liang Z
> >> > Right now, we don't have an interface to detect that cases and got > >> > back to the iterative stage. > >> > >> How about go back to the iterative stage when detect that the > >> pending_size is larger Than max_size, like this: > >> > >> +/* do flush here is aimed to shorten

Re: [Qemu-devel] [PATCH V4 06/19] virtio-ccw: using VIRTIO_NO_VECTOR instead of 0 for invalid virtqueue

2015-03-20 Thread Cornelia Huck
On Wed, 18 Mar 2015 14:08:56 +0100 "Michael S. Tsirkin" wrote: > On Wed, Mar 18, 2015 at 05:34:56PM +0800, Jason Wang wrote: > > There's no need to use vector 0 for invalid virtqueue. So this patch > > changes to use VIRTIO_NO_VECTOR instead. > > > > Cc: Michael S. Tsirkin > > Cc: Cornelia Huck

Re: [Qemu-devel] [PATCH v2 3/7] pci: Remove unused function ich9_d2pbr_init()

2015-03-20 Thread Thomas Huth
On Wed, 18 Mar 2015 14:20:41 +0100 "Michael S. Tsirkin" wrote: > On Sat, Mar 14, 2015 at 07:19:30AM +0100, Thomas Huth wrote: > > The function ich9_d2pbr_init() is completely unused and > > thus can be deleted. > > > > Signed-off-by: Thomas Huth > > Cc: Michael S. Tsirkin > > Reviewed-by: Mic

Re: [Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name()

2015-03-20 Thread Markus Armbruster
Alberto Garcia writes: > This function gets the device name associated with a BlockDriverState, > or its node name if the device name is empty. > > Signed-off-by: Alberto Garcia > --- > block.c | 5 + > block/quorum.c| 5 + > include/block/block.h | 1 + > 3 files

Re: [Qemu-devel] [PATCH V6 for-2.3 00/26] hw/pc: implement multiple primary busses for pc machines

2015-03-20 Thread Gerd Hoffmann
Hi, > - You are more than welcome to try using: >-bios Not needed any more, the seabios-1.8.1 release in master should work just fine. cheers, Gerd

Re: [Qemu-devel] [PATCH 2/3] block: use bdrv_get_device_or_node_name() in error messages

2015-03-20 Thread Markus Armbruster
Alberto Garcia writes: > There are several error messages that identify a BlockDriverState by > its device name. However those errors can be produced in nodes that > don't have a device name associated. > > In those cases we should use bdrv_get_device_or_node_name() to fall > back to the node nam

Re: [Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name()

2015-03-20 Thread Alberto Garcia
On Fri, Mar 20, 2015 at 08:40:32AM +0100, Markus Armbruster wrote: > > +const char *bdrv_get_device_or_node_name(const BlockDriverState *bs) > > +{ > > +return bs->blk ? blk_name(bs->blk) : bs->node_name; > > +} > > + > > Does this have uses beyond identifying @bs to the user? None that I ca

Re: [Qemu-devel] [PATCH v5 10/13] blockdev: Keep track of monitor-owned BDS

2015-03-20 Thread Markus Armbruster
Eric Blake writes: > On 03/03/2015 01:13 PM, Max Reitz wrote: >> Signed-off-by: Max Reitz >> --- >> block.c| 2 ++ >> blockdev.c | 18 ++ >> include/block/block_int.h | 4 >> stubs/Makefile.objs

[Qemu-devel] [PULL for-2.3 v2 00/13] usb patch queue

2015-03-20 Thread Gerd Hoffmann
:00 +) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-usb-20150320-1 for you to fetch changes up to 4e289b1b62c8e271e3400317b4c3d98909093bc4: ehci: fix segfault when hot-unplugging ehci controller (2

Re: [Qemu-devel] [PATCH] virtio: move sanity checks to ifdef DEBUG

2015-03-20 Thread Cornelia Huck
On Wed, 18 Mar 2015 12:42:46 +0100 "Michael S. Tsirkin" wrote: > All that happens when virtqueue_fill is invoked incorrectly is that we > corrupt guest memory, so this check is not a security measure. > Move the check to ifdef DEBUG to make sure we don't introduce new > crashes close to release.

Re: [Qemu-devel] [PULL 02/29] s390x/ipl: support diagnose 308 subcodes 5 and 6

2015-03-20 Thread Christian Borntraeger
Am 19.03.2015 um 10:31 schrieb Paolo Bonzini: > > > On 18/02/2015 21:21, Christian Borntraeger wrote: >> From: Fan Zhang >> >> To support dynamically updating the IPL device from inside the KVM >> guest on the s390 platform, DIAG 308 instruction is intercepted >> in QEMU to handle the request. >

Re: [Qemu-devel] [PATCH V6 for-2.3 00/26] hw/pc: implement multiple primary busses for pc machines

2015-03-20 Thread Marcel Apfelbaum
On 03/20/2015 09:44 AM, Gerd Hoffmann wrote: Hi, - You are more than welcome to try using: -bios Not needed any more, the seabios-1.8.1 release in master should work just fine. Good to know, thanks! Marcel cheers, Gerd

Re: [Qemu-devel] [PATCH V6 for-2.3 00/26] hw/pc: implement multiple primary busses for pc machines

2015-03-20 Thread Marcel Apfelbaum
On 03/19/2015 11:45 PM, Paolo Bonzini wrote: On 19/03/2015 19:52, Marcel Apfelbaum wrote: hw/pci-host/piix.c | 128 - hw/pci-host/ppce500.c | 1 + hw/pci-host/q35.c | 5 + hw/pci-host/uninorth.c | 1 + hw/pci/Mak

Re: [Qemu-devel] [PATCH] spapr_pci: Fix unsafe signed/unsigned comparisons

2015-03-20 Thread Markus Armbruster
David Gibson writes: > spapr_pci.c contains a number of expressions of the form (uval == -1) or > (uval != -1), where 'uval' is an unsigned value. > > This mostly works in practice, because as long as the width of uval is > greater or equal than that of (int), the -1 will be promoted to the > uns

Re: [Qemu-devel] [PATCH 2/2] i6300esb: Fix signed integer overflow

2015-03-20 Thread Richard W.M. Jones
On Fri, Mar 20, 2015 at 02:11:56PM +1100, David Gibson wrote: > If the guest programs a sufficiently large timeout value an integer > overflow can occur in i6300esb_restart_timer(). e.g. if the maximum > possible timer preload value of 0xf is programmed then we end up with > the calculation: >

Re: [Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name()

2015-03-20 Thread Markus Armbruster
Alberto Garcia writes: > On Fri, Mar 20, 2015 at 08:40:32AM +0100, Markus Armbruster wrote: > >> > +const char *bdrv_get_device_or_node_name(const BlockDriverState *bs) >> > +{ >> > +return bs->blk ? blk_name(bs->blk) : bs->node_name; >> > +} >> > + >> >> Does this have uses beyond identifyi

[Qemu-devel] [PATCH] vhost: logs sharing

2015-03-20 Thread Jason Wang
Currently we allocate one vhost log per vhost device. This is sub optimal when: - Guest has several device with vhost as backend - Guest has multiqueue devices In the above cases, we can avoid the memory allocation by sharing a single vhost log among all the vhost devices. This is done by introdu

Re: [Qemu-devel] [PATCH 1/2] i6300esb: Correct endiannness

2015-03-20 Thread Richard W.M. Jones
On Fri, Mar 20, 2015 at 02:11:55PM +1100, David Gibson wrote: > The IO operations for the i6300esb watchdog timer are marked as > DEVICE_NATIVE_ENDIAN. This is not correct, and - as a PCI device - should > be DEVICE_LITTLE_ENDIAN. > > This allows i6300esb to work on ppc targets (yes, using an Int

Re: [Qemu-devel] [PATCH 2/2] i6300esb: Fix signed integer overflow

2015-03-20 Thread Paolo Bonzini
On 20/03/2015 04:11, David Gibson wrote: > If the guest programs a sufficiently large timeout value an integer > overflow can occur in i6300esb_restart_timer(). e.g. if the maximum > possible timer preload value of 0xf is programmed then we end up with > the calculation: > > timeout = get_t

Re: [Qemu-devel] [PATCH 3/3] block: allow BLOCK_IMAGE_CORRUPTED to have a node name

2015-03-20 Thread Alberto Garcia
On Thu, Mar 19, 2015 at 05:14:24PM -0600, Eric Blake wrote: > So the more I think about it, the more I'd like for this event to > output both 'device' (mandatory, with an empty string if we can't > easily tie the BDS to a single device) and 'node' (where 'node' can > be optional, and omitted if th

Re: [Qemu-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 09:04 +0800, Chen, Tiejun wrote: > Refactor again, > > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c > index 8599a6a..05c8916 100644 > --- a/tools/libxl/libxl_dm.c > +++ b/tools/libxl/libxl_dm.c > @@ -409,6 +409,23 @@ static char *dm_spice_options(libxl__gc *gc

Re: [Qemu-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-20 Thread Chen, Tiejun
+case LIBXL_GFX_PASSTHRU_KIND_DEFAULT: +LOG(ERROR, "unable to detect required gfx_passthru_kind"); In this case you will now have logged twice. I'd suggest logging only here and not in the helper. +default: And this case is subtly different to LIBXL_GF

Re: [Qemu-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 18:08 +0800, Chen, Tiejun wrote: > +if (!xlu_cfg_get_string(config, "gfx_passthru_kind", &buf, 0)) { > +if (libxl_gfx_passthru_kind_from_string(buf, > + > &b_info->u.hvm.gfx_passthru_kind)) { > +fprintf(stderr, > +"E

Re: [Qemu-devel] [PATCH] object_del: Prevent removing an in-use memory backend object

2015-03-20 Thread Igor Mammedov
On Fri, 20 Mar 2015 12:14:58 +0800 Lin Ma wrote: > showing a memory device whose memdev is removed leads an assert: > > (qemu) object_add memory-backend-ram,id=ram0,size=128M > (qemu) device_add pc-dimm,id=d0,memdev=ram0 > (qemu) object_del ram0 > (qemu) info memory-devices > ** > ERROR:qom/obje

[Qemu-devel] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED

2015-03-20 Thread Alberto Garcia
Since this event can occur in nodes that cannot have a device name associated, include also a field with the node name. Signed-off-by: Alberto Garcia --- block/qcow2.c | 8 ++-- docs/qmp/qmp-events.txt | 16 +--- qapi/block-core.json| 13 - 3 files chan

Re: [Qemu-devel] [PATCH V4 09/19] virito: introduce bus specific queue limit

2015-03-20 Thread Cornelia Huck
On Wed, 18 Mar 2015 17:34:59 +0800 Jason Wang wrote: Typo in subject: s/virito/virtio/ > This patch introduces a bus specific queue limitation. It will be > useful for increasing the limit for one of the bus without disturbing > other buses. > > Cc: Michael S. Tsirkin > Cc: Alexander Graf > C

[Qemu-devel] [PATCH 2/3] block: use bdrv_get_device_or_node_name() in error messages

2015-03-20 Thread Alberto Garcia
There are several error messages that identify a BlockDriverState by its device name. However those errors can be produced in nodes that don't have a device name associated. In those cases we should use bdrv_get_device_or_node_name() to fall back to the node name and produce a more meaningful mess

[Qemu-devel] [PATCH v2 0/3] Add bdrv_get_device_or_node_name()

2015-03-20 Thread Alberto Garcia
Second version of the series. v2: - bdrv_get_device_or_node_name() includes a comment explaining its usage. - The error messages have been updated to say 'node' instead of 'device' where appropriate. - The BLOCK_IMAGE_CORRUPTED event has a new 'node-name' field. Regards, Berto Alberto Garci

[Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name()

2015-03-20 Thread Alberto Garcia
This function gets the device name associated with a BlockDriverState, or its node name if the device name is empty. Signed-off-by: Alberto Garcia --- block.c | 9 + block/quorum.c| 5 + include/block/block.h | 1 + 3 files changed, 11 insertions(+), 4 deletions

Re: [Qemu-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-20 Thread Chen, Tiejun
On 2015/3/20 18:11, Ian Campbell wrote: On Fri, 2015-03-20 at 18:08 +0800, Chen, Tiejun wrote: +if (!xlu_cfg_get_string(config, "gfx_passthru_kind", &buf, 0)) { +if (libxl_gfx_passthru_kind_from_string(buf, + &b_info->u.hvm.gfx_passthru_kind)) { +fprintf(stder

Re: [Qemu-devel] [PATCH v3 for-2.3 0/2] numa: Fix default VCPUs to node mapping

2015-03-20 Thread Igor Mammedov
On Thu, 19 Mar 2015 17:09:20 + Igor Mammedov wrote: > Changes since v2: > - fix spelling errors > - split out PC hunks itno a separate patch > > Igor Mammedov (2): > numa: introduce machine callback for VCPU to node mapping > pc: fix default VCPU to NUMA node mapping > > hw/i386/pc.c

Re: [Qemu-devel] [PULL for-2.3 v2 00/13] usb patch queue

2015-03-20 Thread Peter Maydell
gt; Merge remote-tracking branch > 'remotes/armbru/tags/pull-cov-model-2015-03-17' into staging (2015-03-17 > 11:43:00 +) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-usb-20150320-1 > > for you to fetch chang

Re: [Qemu-devel] [PATCH v4 5/5] Qemu-Xen-vTPM: QEMU machine class is initialized before tpm_init()

2015-03-20 Thread Stefan Berger
On 03/10/2015 08:14 AM, Quan Xu wrote: make sure QEMU machine class is initialized and QEMU has registered Xen stubdom vTPM driver when call tpm_init() Signed-off-by: Quan Xu --- vl.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/vl.c b/vl.c index f6b

Re: [Qemu-devel] [PATCH V4 10/19] virtio-ccw: introduce ccw specific queue limit

2015-03-20 Thread Cornelia Huck
On Wed, 18 Mar 2015 17:35:00 +0800 Jason Wang wrote: > Instead of depending on marco, using a bus specific limit. You should probably also mention the adapter routes change in your changelog: "Also make it clear that the number of gsis per I/O adapter is not directly depending on the number of

Re: [Qemu-devel] [PATCH V4 11/19] virtio-s390: switch to bus specific queue limit

2015-03-20 Thread Cornelia Huck
On Wed, 18 Mar 2015 17:35:01 +0800 Jason Wang wrote: > Instead of depending on marco, switch to use a bus specific queue > limit. > > Cc: Alexander Graf > Cc: Richard Henderson > Cc: Christian Borntraeger > Cc: Cornelia Huck > Signed-off-by: Jason Wang > --- > hw/s390x/s390-virtio-bus.c |

Re: [Qemu-devel] [PATCH] spapr_pci: Fix unsafe signed/unsigned comparisons

2015-03-20 Thread Alexander Graf
On 19.03.15 05:14, David Gibson wrote: > spapr_pci.c contains a number of expressions of the form (uval == -1) or > (uval != -1), where 'uval' is an unsigned value. > > This mostly works in practice, because as long as the width of uval is > greater or equal than that of (int), the -1 will be pr

Re: [Qemu-devel] [PATCH V4 14/19] virtio: introduce vector to virtqueues mapping

2015-03-20 Thread Cornelia Huck
On Wed, 18 Mar 2015 17:35:04 +0800 Jason Wang wrote: > Currently we will try to traverse all virtqueues to find a subset that > using a specific vector. This is sub optimal when we will support > hundreds or even thousands of virtqueues. So this patch introduces a > method which could be used by

Re: [Qemu-devel] [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for HVM virtual machine

2015-03-20 Thread Stefan Berger
On 03/19/2015 08:56 AM, Ian Campbell wrote: On Tue, 2015-03-10 at 08:16 -0400, Quan Xu wrote: @@ -151,6 +152,8 @@ device_hardware_setup(void) esp_scsi_setup(); megasas_setup(); pvscsi_setup(); +if (runningOnXen()) +vtpm4hvm_setup(); Is there anything which is actua

Re: [Qemu-devel] [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for HVM virtual machine

2015-03-20 Thread Stefan Berger
On 03/19/2015 09:35 PM, Xu, Quan wrote: -Original Message- From: Ian Campbell [mailto:ian.campb...@citrix.com] Sent: Thursday, March 19, 2015 8:57 PM To: Xu, Quan Cc: ke...@koconnor.net; stef...@linux.vnet.ibm.com; xen-de...@lists.xen.org; qemu-devel@nongnu.org; stefano.stabell...@eu.ci

Re: [Qemu-devel] [PULL 0/6] NUMA queue 2015-03-19

2015-03-20 Thread Peter Maydell
On 19 March 2015 at 19:26, Eduardo Habkost wrote: > The following changes since commit 3e5f6234b4f45a11b7c357dde2d6da36641bc6f6: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2015-03-19 17:47:08 +) > > are available in the git repository at: > > https:

Re: [Qemu-devel] [PATCH v5 20/45] Modify savevm handlers for postcopy

2015-03-20 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Fri, Mar 13, 2015 at 10:19:54AM +, Dr. David Alan Gilbert wrote: > > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > > On Wed, Feb 25, 2015 at 04:51:43PM +, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David A

Re: [Qemu-devel] [PATCH v5 10/13] blockdev: Keep track of monitor-owned BDS

2015-03-20 Thread Max Reitz
On 2015-03-20 at 04:04, Markus Armbruster wrote: Eric Blake writes: On 03/03/2015 01:13 PM, Max Reitz wrote: Signed-off-by: Max Reitz --- block.c| 2 ++ blockdev.c | 18 ++ include/block/block_int.h

Re: [Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name()

2015-03-20 Thread Max Reitz
On 2015-03-20 at 06:19, Alberto Garcia wrote: This function gets the device name associated with a BlockDriverState, or its node name if the device name is empty. Signed-off-by: Alberto Garcia --- block.c | 9 + block/quorum.c| 5 + include/block/block.h |

[Qemu-devel] [PATCH RFC for-2.3 0/1] block: New command line option --no-format-probing

2015-03-20 Thread Markus Armbruster
First of all, my apologies for being so late with this. I realized part way through the current development cycle that I couldn't do both the error work and my half of the block probing work we discussed back in November, so I punted the latter to the next cycle, missing the one little feature I q

[Qemu-devel] [PATCH RFC for-2.3 1/1] block: New command line option --no-format-probing

2015-03-20 Thread Markus Armbruster
Probing is convenient, but probing untrusted raw images is insecure (CVE-2008-2004). To avoid it, users should always specify raw format explicitly. This isn't trivial, and even sophisticated users have gotten it wrong (libvirt CVE-2010-2237, CVE-2010-2238, CVE-2010-2239, plus more recent variati

Re: [Qemu-devel] [PULL 0/2] X86 queue 2015-03-19

2015-03-20 Thread Peter Maydell
On 19 March 2015 at 19:40, Eduardo Habkost wrote: > The following changes since commit 3e5f6234b4f45a11b7c357dde2d6da36641bc6f6: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2015-03-19 17:47:08 +) > > are available in the git repository at: > > https:

Re: [Qemu-devel] [PATCH 2/3] block: use bdrv_get_device_or_node_name() in error messages

2015-03-20 Thread Max Reitz
On 2015-03-20 at 06:19, Alberto Garcia wrote: There are several error messages that identify a BlockDriverState by its device name. However those errors can be produced in nodes that don't have a device name associated. In those cases we should use bdrv_get_device_or_node_name() to fall back to

Re: [Qemu-devel] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED

2015-03-20 Thread Max Reitz
On 2015-03-20 at 06:19, Alberto Garcia wrote: Since this event can occur in nodes that cannot have a device name associated, include also a field with the node name. Signed-off-by: Alberto Garcia --- block/qcow2.c | 8 ++-- docs/qmp/qmp-events.txt | 16 +--- qapi/

[Qemu-devel] [PATCH] block: Document blockdev-add's immaturity

2015-03-20 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qapi/block-core.json | 4 qmp-commands.hx | 4 2 files changed, 8 insertions(+) diff --git a/qapi/block-core.json b/qapi/block-core.json index f525b04..7873084 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -1721,6 +1721,10 @@

[Qemu-devel] [PATCH] target-tricore: fix DVINIT_HU/BU calculating overflow before result

2015-03-20 Thread Bastian Koppelmann
dvinit_hu/bu for ISA v1.3 calculate the higher part of the result, that is needed for the overflow bits, after calculating the overflow bits. Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) d

Re: [Qemu-devel] [PATCH] block: Document blockdev-add's immaturity

2015-03-20 Thread Markus Armbruster
Forgot to stick for-2.3 into the subject.

Re: [Qemu-devel] [ipxe-devel] Emulation failure on booting/rebooting VMs

2015-03-20 Thread Robin Smidsrød
On 19.03.2015 19:31, Mohammed Gamal wrote: > > On Wed, Mar 18, 2015 at 7:09 PM, Kevin O'Connor > wrote: > > On Wed, Mar 18, 2015 at 06:36:48PM +0100, Mohammed Gamal wrote: > > Hi, > > I've been sporadically getting my KVM virtual machines crashing > wit

Re: [Qemu-devel] [PATCH RFC for-2.3 1/1] block: New command line option --no-format-probing

2015-03-20 Thread Max Reitz
On 2015-03-20 at 09:05, Markus Armbruster wrote: Probing is convenient, but probing untrusted raw images is insecure (CVE-2008-2004). To avoid it, users should always specify raw format explicitly. This isn't trivial, and even sophisticated users have gotten it wrong (libvirt CVE-2010-2237, CVE

Re: [Qemu-devel] [PATCH RFC for-2.3 1/1] block: New command line option --no-format-probing

2015-03-20 Thread Markus Armbruster
Max Reitz writes: > On 2015-03-20 at 09:05, Markus Armbruster wrote: >> Probing is convenient, but probing untrusted raw images is insecure >> (CVE-2008-2004). To avoid it, users should always specify raw format >> explicitly. This isn't trivial, and even sophisticated users have >> gotten it w

Re: [Qemu-devel] [PATCH RFC for-2.3 1/1] block: New command line option --no-format-probing

2015-03-20 Thread Max Reitz
On 2015-03-20 at 09:48, Markus Armbruster wrote: Max Reitz writes: On 2015-03-20 at 09:05, Markus Armbruster wrote: Probing is convenient, but probing untrusted raw images is insecure (CVE-2008-2004). To avoid it, users should always specify raw format explicitly. This isn't trivial, and ev

Re: [Qemu-devel] [for-2.3 PATCH] block: Document blockdev-add's immaturity

2015-03-20 Thread Eric Blake
On 03/20/2015 07:32 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > qapi/block-core.json | 4 > qmp-commands.hx | 4 > 2 files changed, 8 insertions(+) Never hurts to document things like this, even after freeze :) Reviewed-by: Eric Blake -- Eric Blake

Re: [Qemu-devel] [PATCH RFC for-2.3 1/1] block: New command line option --no-format-probing

2015-03-20 Thread Eric Blake
On 03/20/2015 07:49 AM, Max Reitz wrote: Disabling probing entirely is a (hamfisted) way to ensure you always specify the format. >> >> I'd appreciate opinions on whether this is wanted for 2.3. If it is, >> I'll post a version that actually works. > > I don't have any objections

Re: [Qemu-devel] [PATCH 2/3] block: use bdrv_get_device_or_node_name() in error messages

2015-03-20 Thread Markus Armbruster
Max Reitz writes: > On 2015-03-20 at 06:19, Alberto Garcia wrote: >> There are several error messages that identify a BlockDriverState by >> its device name. However those errors can be produced in nodes that >> don't have a device name associated. >> >> In those cases we should use bdrv_get_devi

Re: [Qemu-devel] [PATCH RFC for-2.3 0/1] block: New command line option --no-format-probing

2015-03-20 Thread Eric Blake
On 03/20/2015 07:05 AM, Markus Armbruster wrote: > First of all, my apologies for being so late with this. I realized > part way through the current development cycle that I couldn't do both > the error work and my half of the block probing work we discussed back > in November, so I punted the lat

[Qemu-devel] [PATCH v2 0/6] virtio: add input device

2015-03-20 Thread Gerd Hoffmann
Hi, This patch series adds virtio input devices. It's basically sending linux evdev events over virtio. There is support for emulated hid devices (i.e. send usual input to virtio device instead of usb or ps2 device) and for evdev device pass-through. This depends on mst's virtio-1.0 patches.

[Qemu-devel] [PATCH v2 4/6] virtio-input: core code & base class

2015-03-20 Thread Gerd Hoffmann
This patch adds virtio-input support to qemu. It brings a abstract base class providing core support, other classes can build on it to actually implement input devices. virtio-input basically sends linux input layer events (evdev) over virtio. Signed-off-by: Gerd Hoffmann --- hw/input/Makefile

[Qemu-devel] [PATCH v2 1/6] pci: add PCI_CLASS_INPUT_*

2015-03-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/hw/pci/pci_ids.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/hw/pci/pci_ids.h b/include/hw/pci/pci_ids.h index d7be386..dfccefc 100644 --- a/include/hw/pci/pci_ids.h +++ b/include/hw/pci/pci_ids.h @@ -46,6 +46,13 @@ #define PCI_CLAS

[Qemu-devel] [PATCH v2 6/6] virtio-input: evdev passthrough

2015-03-20 Thread Gerd Hoffmann
This allows to assign host input devices to the guest: qemu -device virto-input-host-pci,evdev=/dev/input/event The guest gets exclusive access to the input device, so be careful with assigning the keyboard if you have only one connected to your machine. Signed-off-by: Gerd Hoffmann --- hw/inp

[Qemu-devel] [PATCH v2 2/6] virtio-input: add virtio_input.h

2015-03-20 Thread Gerd Hoffmann
Using scripts/update-linux-headers.sh with linux-input kernel branch. Signed-off-by: Gerd Hoffmann --- include/standard-headers/linux/virtio_ids.h | 1 + include/standard-headers/linux/virtio_input.h | 75 +++ 2 files changed, 76 insertions(+) create mode 100644 inclu

[Qemu-devel] [PATCH v2 3/6] virtio-input: add linux/input.h

2015-03-20 Thread Gerd Hoffmann
Linux input layer (evdev) header file. Signed-off-by: Gerd Hoffmann --- include/standard-headers/linux/input.h | 1198 scripts/update-linux-headers.sh|4 +- 2 files changed, 1201 insertions(+), 1 deletion(-) create mode 100644 include/standard-header

[Qemu-devel] [PATCH v2 5/6] virtio-input: emulated devices

2015-03-20 Thread Gerd Hoffmann
This patch adds the virtio-input-hid base class and virtio-{keyboard,mouse,tablet} subclasses building on the base class. They are hooked up to the qemu input core and deliver input events to the guest like all other hid devices (ps/2 kbd, usb tablet, ...). Using them is as simple as adding "-devi

[Qemu-devel] [PATCH] mips_malta: use compat props to avoid loading efi-pcnet.rom

2015-03-20 Thread Leon Alrae
Currently qemu-system-mips aborts if it fails to find efi-pcnet.rom file which does not make sense. NIC on Malta board should not require x86 firmware. Reported-by: Maciej W. Rozycki Suggested-by: Gerd Hoffmann Signed-off-by: Leon Alrae --- Hi, This fixes a problem reported some time ago: http

[Qemu-devel] [RFC PATCH] qemu: enforce no format probing when possible

2015-03-20 Thread Eric Blake
qemu 2.3 added an option, with this documentation: | Probing is convenient, but probing untrusted raw images is insecure | (CVE-2008-2004). To avoid it, users should always specify raw format | explicitly. This isn't trivial, and even sophisticated users have | gotten it wrong (libvirt CVE-2010-

Re: [Qemu-devel] [PATCH RFC for-2.3 1/1] block: New command line option --no-format-probing

2015-03-20 Thread Markus Armbruster
Eric Blake writes: > On 03/20/2015 07:49 AM, Max Reitz wrote: > > Disabling probing entirely is a (hamfisted) way to ensure you always > specify the format. > > >>> >>> I'd appreciate opinions on whether this is wanted for 2.3. If it is, >>> I'll post a version that actually works. >

Re: [Qemu-devel] [PATCH RFC for-2.3 0/1] block: New command line option --no-format-probing

2015-03-20 Thread Markus Armbruster
Eric Blake writes: > On 03/20/2015 07:05 AM, Markus Armbruster wrote: >> First of all, my apologies for being so late with this. I realized >> part way through the current development cycle that I couldn't do both >> the error work and my half of the block probing work we discussed back >> in No

Re: [Qemu-devel] [PATCH RFC for-2.3 1/1] block: New command line option --no-format-probing

2015-03-20 Thread Eric Blake
On 03/20/2015 08:19 AM, Markus Armbruster wrote: >> If (a working version of) this makes it in 2.3, libvirt WILL use it in >> the next release. It will take me less than 5 minutes to write up the >> libvirt patch, as long as the new option is advertised via >> query-command-line-options (which me

[Qemu-devel] [PATCH v3 0/3] Add bdrv_get_device_or_node_name()

2015-03-20 Thread Alberto Garcia
One more try. v3: - The node-name field in BLOCK_IMAGE_CORRUPTED is now Since: 2.4 - Remove the QERR_ macros instead of updating them. The text message is adapted to each case where applicable, and 'device' is renamed to 'node' only where it makes sense. v2: - bdrv_get_device_or_node_name() i

[Qemu-devel] [PATCH 2/3] block: use bdrv_get_device_or_node_name() in error messages

2015-03-20 Thread Alberto Garcia
There are several error messages that identify a BlockDriverState by its device name. However those errors can be produced in nodes that don't have a device name associated. In those cases we should use bdrv_get_device_or_node_name() to fall back to the node name and produce a more meaningful mess

Re: [Qemu-devel] [PATCH v2 4/5] fw_cfg: prohibit insertion of duplicate fw_cfg file names

2015-03-20 Thread Gabriel L. Somlo
On Fri, Mar 20, 2015 at 07:51:06AM +0100, Laszlo Ersek wrote: > Here's an idea I had this morning. > > This series gives equal rank to fw_cfg file names that originate > internally and those that come from the user, via the command line. > > That means that whenever qemu developers want to introd

[Qemu-devel] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED

2015-03-20 Thread Alberto Garcia
Since this event can occur in nodes that cannot have a device name associated, include also a field with the node name. Signed-off-by: Alberto Garcia --- block/qcow2.c | 8 ++-- docs/qmp/qmp-events.txt | 16 +--- qapi/block-core.json| 13 - 3 files chan

[Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name()

2015-03-20 Thread Alberto Garcia
This function gets the device name associated with a BlockDriverState, or its node name if the device name is empty. Signed-off-by: Alberto Garcia --- block.c | 9 + block/quorum.c| 5 + include/block/block.h | 1 + 3 files changed, 11 insertions(+), 4 deletions

Re: [Qemu-devel] [PATCH v3 for-2.3 0/2] numa: Fix default VCPUs to node mapping

2015-03-20 Thread Eduardo Habkost
On Fri, Mar 20, 2015 at 11:24:14AM +0100, Igor Mammedov wrote: > On Thu, 19 Mar 2015 17:09:20 + > Igor Mammedov wrote: > > > Changes since v2: > > - fix spelling errors > > - split out PC hunks itno a separate patch > > > > Igor Mammedov (2): > > numa: introduce machine callback for VCPU

Re: [Qemu-devel] [PATCH v3 for-2.3 0/2] numa: Fix default VCPUs to node mapping

2015-03-20 Thread Igor Mammedov
On Fri, 20 Mar 2015 11:52:46 -0300 Eduardo Habkost wrote: > On Fri, Mar 20, 2015 at 11:24:14AM +0100, Igor Mammedov wrote: > > On Thu, 19 Mar 2015 17:09:20 + > > Igor Mammedov wrote: > > > > > Changes since v2: > > > - fix spelling errors > > > - split out PC hunks itno a separate patch >

Re: [Qemu-devel] [PATCH] e1000: work around win 8.0 boot hang

2015-03-20 Thread Wei Huang
On 02/24/2015 05:46 AM, Stefan Hajnoczi wrote: > On Tue, Feb 24, 2015 at 11:35 AM, Stefan Hajnoczi wrote: >> On Thu, Feb 19, 2015 at 08:24:19PM +0100, Radim Krčmář wrote: >>> Window 8.0 driver has a particular behavior for a small time frame after >>> it enables rx interrupts: the interrupt han

Re: [Qemu-devel] [PATCH] target-tricore: fix DVINIT_HU/BU calculating overflow before result

2015-03-20 Thread Bastian Koppelmann
On 03/20/2015 02:34 PM, Bastian Koppelmann wrote: dvinit_hu/bu for ISA v1.3 calculate the higher part of the result, that is needed for the overflow bits, after calculating the overflow bits. Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 29 +

[Qemu-devel] [PATCH 0/6 v7] tilegx: Firstly add tilegx feature for linux-user

2015-03-20 Thread Chen Gang
After load elf64 binary, qemu tilegx can finish executing the first system call (uname) successfully in _dl_discover_osversion(), and return to __libc_start_main(). Chen Gang (6): target-tilegx: Firstly add TILE-Gx with minimized features linux-user: tilegx: Firstly add architecture related f

[Qemu-devel] [PATCH 1/6 v7] target-tilegx: Firstly add TILE-Gx with minimized features

2015-03-20 Thread Chen Gang
It is the configure and build system support for TILE-Gx (tilegx will be used in configure and real sub-directory name). At present, it is linux-user only, and can finish the first system call (uname) execution in __libc_start_main(). Signed-off-by: Chen Gang --- configure

[Qemu-devel] [PATCH 2/6 v7] linux-user: tilegx: Firstly add architecture related features

2015-03-20 Thread Chen Gang
They are based on Linux kernel tilegx architecture for 64 bit binary, also based on tilegx ABI reference document. Signed-off-by: Chen Gang --- linux-user/tilegx/syscall.h| 80 linux-user/tilegx/syscall_nr.h | 278 linux-user/tilegx/term

[Qemu-devel] [PATCH 3/6 v7] linux-user: tilegx: Add target features support within qemu

2015-03-20 Thread Chen Gang
They are for target features within qemu which independent from outside. Signed-off-by: Chen Gang --- linux-user/tilegx/target_cpu.h | 35 +++ linux-user/tilegx/target_signal.h | 28 ++ linux-user/tilegx/target_structs.h | 48 +

[Qemu-devel] [PATCH 4/6 v7] linux-user: Support tilegx architecture in syscall

2015-03-20 Thread Chen Gang
Add tilegx architecture in "syscall_defs.h", all related features (ioctrl, and stat) are based on Linux kernel tilegx 64-bit implementation. Signed-off-by: Chen Gang --- linux-user/syscall_defs.h | 38 ++ 1 file changed, 34 insertions(+), 4 deletions(-) diff

[Qemu-devel] [PATCH 5/6 v7] linux-user: Support tilegx architecture in linux-user

2015-03-20 Thread Chen Gang
Add main working flow feature, system call processing feature, and elf64 tilegx binary loading feature, based on Linux kernel tilegx 64-bit implementation. Signed-off-by: Chen Gang --- include/elf.h| 2 ++ linux-user/elfload.c | 23 ++ linux-user/main.c| 86 +

[Qemu-devel] [PATCH 6/6 v7] linux-user/syscall.c: conditionalize syscalls which are not defined in tilegx

2015-03-20 Thread Chen Gang
For tilegx, several syscall macros are not supported, so switch them to avoid building break. Signed-off-by: Chen Gang --- linux-user/syscall.c | 50 +- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user

[Qemu-devel] [for-2.3 PATCH] gitignore: Ignore more .pod files.

2015-03-20 Thread Eric Blake
kvm_stat.{1,pod} started showing up as untracked files in my directory, and I nearly accidentally merged them into a commit with my usual habit of 'git add .'. Rather than naming every such generated doc file, just exclude the pattern. Signed-off-by: Eric Blake CC: qemu-triv...@nongnu.org --- .

Re: [Qemu-devel] [for-2.3 PATCH] gitignore: Ignore more .pod files.

2015-03-20 Thread Eric Blake
On 03/20/2015 10:26 AM, Eric Blake wrote: > kvm_stat.{1,pod} started showing up as untracked files in my > directory, and I nearly accidentally merged them into a commit > with my usual habit of 'git add .'. Rather than naming every > such generated doc file, just exclude the pattern. > > Signed-

[Qemu-devel] [for-2.3 PATCH v2] gitignore: Ignore more .pod files.

2015-03-20 Thread Eric Blake
kvm_stat.{1,pod} started showing up as untracked files in my directory, and I nearly accidentally merged them into a commit with my usual habit of 'git add .'. Rather than spelling out each such file, just ignore the entire pattern. Signed-off-by: Eric Blake CC: qemu-triv...@nongnu.org --- v2:

[Qemu-devel] [PATCH] Probe via #define check for FreeBSD, NetBSD and DragonFly BSD

2015-03-20 Thread Wei Liu
Signed-off-by: Wei Liu --- configure | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configure b/configure index 589798e..ceacd81 100755 --- a/configure +++ b/configure @@ -441,6 +441,12 @@ elif check_define _WIN32 ; then targetos='MINGW32' elif check_define __OpenBSD__ ; then ta

Re: [Qemu-devel] [for-2.3 PATCH v2] gitignore: Ignore more .pod files.

2015-03-20 Thread Stefan Weil
Am 20.03.2015 um 17:30 schrieb Eric Blake: kvm_stat.{1,pod} started showing up as untracked files in my directory, and I nearly accidentally merged them into a commit with my usual habit of 'git add .'. Rather than spelling out each such file, just ignore the entire pattern. Signed-off-by: Eric

Re: [Qemu-devel] [PATCH 1/6 v6] target-tilegx: Firstly add TILE-Gx with minimized features

2015-03-20 Thread Richard Henderson
On 03/18/2015 07:04 PM, Chen Gang wrote: > For me, I am not quite sure about it, the related functional description > is: > > rf[Dest] = signExtend32 ((int32_t) rf[SrcA] * (int32_t) rf[SrcB]); > > Do you mean it is equal to: > > rf[Dest] = signExtend32 (rf[SrcA] * rf[SrcB]); Yes, of course.

[Qemu-devel] [PATCH] acpi: Add missing GCC_FMT_ATTR to local function

2015-03-20 Thread Stefan Weil
This fixes these gcc warnings (not enabled in default build): hw/acpi/aml-build.c:83:5: warning: function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] hw/acpi/aml-build.c:88:5: warning: function might be possible candidate for ‘gnu_printf’ format at

Re: [Qemu-devel] [PATCH for-2.3 0/4] ahci: fix big endian PIO failures

2015-03-20 Thread Andreas Färber
Am 20.03.2015 um 01:24 schrieb John Snow: > Two issues were unearthed from ahci-test on ppc64: > > (1) The ahci_populate_sglist function had endian issues, > which is only likely to impact PIO transfers for buffers > greater than one sector, and > > (2) multiple-sector PIO which I attempt

Re: [Qemu-devel] GSoC Proposal: ARM Virtualization Extensions

2015-03-20 Thread Peter Maydell
On 20 March 2015 at 17:25, Merten Sach wrote: > I'm interested in participating in this years edition of Google Summer of > Code. > Initially I wanted to propose the implementation of ARMv7 > virtualization extensions. I know this is not supported at the moment. > Also based on the documentation

Re: [Qemu-devel] [PATCH 1/6 v7] target-tilegx: Firstly add TILE-Gx with minimized features

2015-03-20 Thread Richard Henderson
On 03/20/2015 08:25 AM, Chen Gang wrote: > +/* > + * The related functional description for bfextu in isa document: > + * > + * uint64_t mask = 0; > + * mask = (-1ULL) ^ ((-1ULL << ((BFEnd - BFStart) & 63)) << 1); > + * uint64_t rot_src = (((uint64_t) rf[SrcA]) >> BFStart) > + *

Re: [Qemu-devel] [PATCH 1/6 v7] target-tilegx: Firstly add TILE-Gx with minimized features

2015-03-20 Thread Peter Maydell
On 20 March 2015 at 15:25, Chen Gang wrote: > It is the configure and build system support for TILE-Gx (tilegx will be > used in configure and real sub-directory name). > > At present, it is linux-user only, and can finish the first system call > (uname) execution in __libc_start_main(). > > Signe

Re: [Qemu-devel] [PATCH V6 for-2.3 00/26] hw/pc: implement multiple primary busses for pc machines

2015-03-20 Thread Paolo Bonzini
On 20/03/2015 09:37, Marcel Apfelbaum wrote: >> I think this should not be committed to 2.3 after -rc0. > While I agree that looking at the above the series do not > fit for 2.3, I still think the risk is not big because: > - The biggest amount of modifications are in pci_bus/pci_host > and *is

Re: [Qemu-devel] [PATCH v2 5/5] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-03-20 Thread Gabriel L. Somlo
On Thu, Mar 19, 2015 at 06:38:53PM +0100, Laszlo Ersek wrote: > On 03/19/15 01:18, Gabriel L. Somlo wrote: > > Allow user supplied files to be inserted into the fw_cfg > > device before starting the guest. Since fw_cfg_add_file() > > already disallows duplicate fw_cfg file names, qemu will > > exit

  1   2   >