On Fri, Mar 20, 2015 at 02:11:55PM +1100, David Gibson wrote:
> The IO operations for the i6300esb watchdog timer are marked as
> DEVICE_NATIVE_ENDIAN. This is not correct, and - as a PCI device - should
> be DEVICE_LITTLE_ENDIAN.
>
> This allows i6300esb to work on ppc targets (yes, using an Intel ICH
> derived device on ppc is a bit odd, but the driver exists on the guest
> and there's no more obviously suitable watchdog device).
>
> Signed-off-by: David Gibson <da...@gibson.dropbear.id.au>
> ---
> hw/watchdog/wdt_i6300esb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c
> index b2d158f..e694fa9 100644
> --- a/hw/watchdog/wdt_i6300esb.c
> +++ b/hw/watchdog/wdt_i6300esb.c
> @@ -369,7 +369,7 @@ static const MemoryRegionOps i6300esb_ops = {
> i6300esb_mem_writel,
> },
> },
> - .endianness = DEVICE_NATIVE_ENDIAN,
> + .endianness = DEVICE_LITTLE_ENDIAN,
> };
>
> static const VMStateDescription vmstate_i6300esb = {
Reviewed-by: Richard W.M. Jones <rjo...@redhat.com>
- - -
For your amusement, the physical device only ever existed as part of
an Intel "Enterprise SouthBridge" (hence ESB). I highly doubt it was
ever connected to anything that was not an Intel x86 processor. There
is a photo of one here:
http://www.tomshardware.com/reviews/amd,889-18.html [requires javascript]
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org
