[Qemu-devel] [PATCH 0/3] Misc fixes for VNC

2015-03-16 Thread Daniel P. Berrange
This is a small series of fixes for the VNC server, the most significant of which is the last one affecting websockets + TLS integration. These prepare the way for work I'm doing to refactor TLS handling into a module that is reusable across QEMU. Daniel P. Berrange (3): ui: remove unused 'wirem

[Qemu-devel] [PATCH 3/3] ui: fix VNC websockets TLS integration

2015-03-16 Thread Daniel P. Berrange
The way the websockets TLS code was integrated into the VNC server made it insecure and essentially useless. The only time that the websockets TLS support could be used is if the primary VNC server had its existing TLS support disabled. ie QEMU had to be launched with: # qemu -vnc localhost:1,we

[Qemu-devel] [PATCH 2/3] ui: replace printf() calls with VNC_DEBUG

2015-03-16 Thread Daniel P. Berrange
Handling of VNC audio messages results in printfs to the console. This is of no use to anyone in production, so should be using the normal VNC_DEBUG macro instead. Signed-off-by: Daniel P. Berrange --- ui/vnc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ui/v

[Qemu-devel] [PATCH 1/3] ui: remove unused 'wiremode' variable in VncState struct

2015-03-16 Thread Daniel P. Berrange
Signed-off-by: Daniel P. Berrange --- ui/vnc-auth-vencrypt.c | 1 - ui/vnc-tls.c | 2 -- ui/vnc-tls.h | 7 --- ui/vnc-ws.c| 1 - 4 files changed, 11 deletions(-) diff --git a/ui/vnc-auth-vencrypt.c b/ui/vnc-auth-vencrypt.c index bc7032e..a420ccb 100644 --- a/u

[Qemu-devel] [PULL 6/7] target-arm: Ignore low bit of PC in M-profile exception return

2015-03-16 Thread Peter Maydell
For the ARM M-profile cores, exception return pops various registers including the PC from the stack. The architecture defines that if the lowest bit in the new PC value is set (ie the PC is not halfword aligned) then behaviour is UNPREDICTABLE. In practice hardware implementations seem to simply i

[Qemu-devel] [PULL 5/7] target-arm: Fix handling of STM (user) with r15 in register list

2015-03-16 Thread Peter Maydell
The A32 encoding of LDM distinguishes LDM (user) from LDM (exception return) based on whether r15 is in the register list. However for STM (user) there is no equivalent distinction. We were incorrectly treating "r15 in list" as indicating exception return for both LDM and STM, with the result that

[Qemu-devel] [PULL 0/7] target-arm queue

2015-03-16 Thread Peter Maydell
Last batch of bugfixes before hardfreeze... -- PMM The following changes since commit f421f05754ac5aabe15f12051390204116408b00: Merge remote-tracking branch 'remotes/kraxel/tags/pull-seabios-1.8.1-20150316-1' into staging (2015-03-16 10:58:11 +) are available in the git rep

[Qemu-devel] [PULL 4/7] hw/intc/arm_gic: Initialize the vgic in the realize function

2015-03-16 Thread Peter Maydell
From: Eric Auger This patch forces vgic initialization in the vgic realize function. It uses a new group/attribute that allows such operation: KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_VGIC_CTRL_INIT This earlier initialization allows, for example, to setup VFIO signaling and irqfd after vgic initia

[Qemu-devel] [PULL 1/7] target-arm: convert check_ap to ap_to_rw_prot

2015-03-16 Thread Peter Maydell
From: Andrew Jones Instead of mixing access permission checking with access permissions to page protection flags translation, just do the translation, and leave it to the caller to check the protection flags against the access type. Also rename to ap_to_rw_prot to better describe the new behavior

[Qemu-devel] [PULL 7/7] linux-user: Access correct register for get/set_tls syscalls on ARM TZ CPUs

2015-03-16 Thread Peter Maydell
From: Mikhail Ilyin When support was added for TrustZone to ARM CPU emulation, we failed to correctly update the support for the linux-user implementation of the get/set_tls syscalls. This meant that accesses to the TPIDRURO register via the syscalls were always using the non-secure copy of the r

[Qemu-devel] [PULL 2/7] target-arm: fix get_phys_addr_v6/SCTLR_AFE access check

2015-03-16 Thread Peter Maydell
From: Andrew Jones Introduce simple_ap_to_rw_prot(), which has the same behavior as ap_to_rw_prot(), but takes the 2-bit simple AP[2:1] instead of the 3-bit AP[2:0]. Use this in get_phys_addr_v6 when SCTLR_AFE is set, as that bit indicates we should be using the simple AP format. It's unlikely t

[Qemu-devel] [PULL 3/7] target-arm: get_phys_addr_lpae: more xn control

2015-03-16 Thread Peter Maydell
From: Andrew Jones This patch makes the following changes to the determination of whether an address is executable, when translating addresses using LPAE. 1. No longer assumes that PL0 can't execute when it can't read. It can in AArch64, a difference from AArch32. 2. Use va_size == 64 to dete

Re: [Qemu-devel] [PATCH v4 4/5] target-arm: kvm64 fix save/restore of SPSR regs

2015-03-16 Thread Christoffer Dall
On Mon, Mar 16, 2015 at 11:01:55AM +, Alex Bennée wrote: > From: Christoffer Dall > > The current code was negatively indexing the cpu state array and not > synchronizing banked spsr register state with the current mode's spsr > state, causing occasional failures with migration. > > Some mun

Re: [Qemu-devel] [PULL for-2.3 00/10] s390x: final updates

2015-03-16 Thread Peter Maydell
git://github.com/cohuck/qemu tags/s390x-20150316 > > for you to fetch changes up to be0b608a5463a834df0e19911356ae93660d3677: > > s390x/config: Do not include full pci.mak (2015-03-16 10:20:17 +0100) > > > Fi

Re: [Qemu-devel] [PATCH 1/3] ui: remove unused 'wiremode' variable in VncState struct

2015-03-16 Thread Alex Bennée
Daniel P. Berrange writes: > Signed-off-by: Daniel P. Berrange Reviewed-by: Alex Bennée > --- > ui/vnc-auth-vencrypt.c | 1 - > ui/vnc-tls.c | 2 -- > ui/vnc-tls.h | 7 --- > ui/vnc-ws.c| 1 - > 4 files changed, 11 deletions(-) > > diff --git a/ui/vnc-auth

Re: [Qemu-devel] [PATCH 2/3] ui: replace printf() calls with VNC_DEBUG

2015-03-16 Thread Alex Bennée
Daniel P. Berrange writes: > Handling of VNC audio messages results in printfs to the console. > This is of no use to anyone in production, so should be using the > normal VNC_DEBUG macro instead. > > Signed-off-by: Daniel P. Berrange Reviewed-by: Alex Bennée > --- > ui/vnc.c | 12 ++

Re: [Qemu-devel] [PATCH 3/3] ui: fix VNC websockets TLS integration

2015-03-16 Thread Alex Bennée
Daniel P. Berrange writes: > The way the websockets TLS code was integrated into the VNC server > made it insecure and essentially useless. The only time that the > websockets TLS support could be used is if the primary VNC server > > With this patch applied a number of things change > > - TLS

Re: [Qemu-devel] [PATCH 3/3] ui: fix VNC websockets TLS integration

2015-03-16 Thread Daniel P. Berrange
On Mon, Mar 16, 2015 at 01:17:16PM +, Alex Bennée wrote: > > Daniel P. Berrange writes: > > > The way the websockets TLS code was integrated into the VNC server > > made it insecure and essentially useless. The only time that the > > websockets TLS support could be used is if the primary VNC

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Give laptop users ability to scroll in monitor

2015-03-16 Thread Paolo Bonzini
On 16/03/2015 14:35, Programmingkid wrote: > On Mar 16, 2015, at 8:19 AM, Paolo Bonzini wrote: >> On 13/03/2015 21:43, Programmingkid wrote: How do you do that in a terminal? >>> >>> I'm not sure what exactly you're asking. I will say past Apple laptop >>> did have the ability to page up or

Re: [Qemu-devel] [PATCH v2 03/37] hw/block/fdc: Implement tray status

2015-03-16 Thread Max Reitz
On 2015-03-05 at 05:11, Kevin Wolf wrote: Am 04.03.2015 um 23:06 hat Max Reitz geschrieben: On 2015-03-04 at 09:00, Kevin Wolf wrote: Am 09.02.2015 um 18:11 hat Max Reitz geschrieben: The tray of an FDD is open iff there is no medium inserted (there are only two states for an FDD: "medium inse

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Give laptop users ability to scroll in monitor

2015-03-16 Thread Programmingkid
On Mar 16, 2015, at 9:36 AM, Paolo Bonzini wrote: > > > On 16/03/2015 14:35, Programmingkid wrote: >> On Mar 16, 2015, at 8:19 AM, Paolo Bonzini wrote: >>> On 13/03/2015 21:43, Programmingkid wrote: > How do you do that in a terminal? I'm not sure what exactly you're asking. I wi

[Qemu-devel] [PULL 01/11] Add -incoming defer

2015-03-16 Thread Juan Quintela
From: "Dr. David Alan Gilbert" -incoming defer causes qemu to wait for an incoming migration to be specified later. The monitor can be used to set migration capabilities that may affect the incoming connection process. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Signed-of

[Qemu-devel] [PULL 02/11] Add migrate_incoming

2015-03-16 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Add migrate_incoming/migrate-incoming to start an incoming migration. Once a qemu has been started with -incoming defer the migration can be started by issuing: migrate_incoming uri Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Eric Blake Signed-of

[Qemu-devel] [PULL 05/11] ram_save_page: change calling covention

2015-03-16 Thread Juan Quintela
Add a parameter to pass the number of bytes written, and make it return the number of pages written instead. Signed-off-by: Juan Quintela --- arch_init.c | 57 ++--- 1 file changed, 38 insertions(+), 19 deletions(-) diff --git a/arch_init.c b/

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Give laptop users ability to scroll in monitor

2015-03-16 Thread Programmingkid
On Mar 16, 2015, at 8:19 AM, Paolo Bonzini wrote: > > > On 13/03/2015 21:43, Programmingkid wrote: >>> How do you do that in a terminal? >> >> I'm not sure what exactly you're asking. I will say past Apple laptop >> did have the ability to page up or down by using the function key + >> the up

[Qemu-devel] [PULL 06/11] save_xbzrle_page: change calling convention

2015-03-16 Thread Juan Quintela
Add a parameter to pass the number of bytes written, and make it return the number of pages written instead. Signed-off-by: Juan Quintela --- arch_init.c | 44 +--- 1 file changed, 25 insertions(+), 19 deletions(-) diff --git a/arch_init.c b/arch_init.c i

[Qemu-devel] [PULL 09/11] migration: Read JSON VM description on incoming migration

2015-03-16 Thread Juan Quintela
From: Alexander Graf One of the really nice things about the VM description format is that it goes over the wire when live migration is happening. Unfortunately QEMU today closes any socket once it sees VM_EOF coming, so we never give the VMDESC the chance to actually land on the wire. This patc

[Qemu-devel] [PULL 10/11] migration: Allow to suppress vmdesc submission

2015-03-16 Thread Juan Quintela
From: Alexander Graf We now always send a JSON blob describing the migration file format as part of the migration stream. However, some tools built around QEMU have proven to stumble over this. This patch gives the user the chance to disable said self-describing part of the migration stream. To

[Qemu-devel] [PULL 08/11] rename save_block_hdr to save_page_header

2015-03-16 Thread Juan Quintela
It has always been a page header, not a block header. Once there, the flag argument was only passed to make a bit or with it, just do the or on the caller. Signed-off-by: Juan Quintela --- arch_init.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git

[Qemu-devel] [PULL 11/11] pc: Disable vmdesc submission for old machines

2015-03-16 Thread Juan Quintela
From: Alexander Graf Older PC machine types might by accident be backwards live migration compatible, but with the new vmdesc self-describing blob in our live migration stream we would break that compatibility. Also users wouldn't expect massive behaviorial differences when updating to a new ver

[Qemu-devel] [PULL 04/11] ram_find_and_save_block: change calling convention

2015-03-16 Thread Juan Quintela
Add a parameter to pass the number of bytes written, and make it return the number of pages written instead. Signed-off-by: Juan Quintela --- arch_init.c | 45 +++-- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/arch_init.c b/arch_init.c

[Qemu-devel] [PULL 00/11] Migration pull request

2015-03-16 Thread Juan Quintela
The following changes since commit 2dfe7d07e2f40adb18a0b0cd286f3d327692d0fc: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20150316' into staging (2015-03-16 11:44:55 +) are available in the git repository at: git://github.com/juanquintela/qemu.git tags/migratio

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Give laptop users ability to scroll in monitor

2015-03-16 Thread Daniel P. Berrange
On Fri, Mar 13, 2015 at 04:43:54PM -0400, Programmingkid wrote: > > On Mar 13, 2015, at 1:31 PM, Paolo Bonzini wrote: > > > > > > > On 13/03/2015 15:48, Programmingkid wrote: > >> > >> On Mar 13, 2015, at 5:51 AM, Peter Maydell wrote: > >> > >>> On 13 March 2015 at 04:35, Programmingkid > >

[Qemu-devel] [PULL 03/11] ram: make all save_page functions take a uint64_t parameter

2015-03-16 Thread Juan Quintela
It used to be an int, but then we can't pass directly the bytes_transferred parameter, that would happen later in the series. Signed-off-by: Juan Quintela Reviewed-by: Amit Shah --- arch_init.c | 11 --- include/migration/migration.h | 2 +- include/migration/qemu-fil

[Qemu-devel] [PULL 07/11] save_block_hdr: we can recalculate the cont parameter here

2015-03-16 Thread Juan Quintela
No need to pass it through all the callers. Once there, update last_sent_block here. Signed-off-by: Juan Quintela --- arch_init.c | 47 --- 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/arch_init.c b/arch_init.c index d30fd13..7377a0

Re: [Qemu-devel] [PATCH 05/25] nbd: Avoid generic -EINVAL

2015-03-16 Thread Max Reitz
On 2015-03-11 at 07:22, Paolo Bonzini wrote: On 25/02/2015 19:08, Max Reitz wrote: Just returning -EINVAL for everything is bad. -EIO is often better, and sometimes there is an even more fitting value. Propagating the return value from write_sync is uglier, but it is even better in terms of re

Re: [Qemu-devel] [RESEND PATCH v4 2/6] acpi, mem-hotplug: Add unplug request cb for memory device

2015-03-16 Thread Igor Mammedov
On Mon, 16 Mar 2015 16:58:14 +0800 Zhu Guihua wrote: > From: Tang Chen > > Memory hot unplug are both asynchronous procedures. > When the unplug operation happens, unplug request cb is called first. > And when guest OS finished handling unplug, unplug cb will be called > to do the real removal

Re: [Qemu-devel] [PULL] VirtFS update

2015-03-16 Thread Peter Maydell
On 16 March 2015 at 10:09, Aneesh Kumar K.V wrote: > > Hi, > > Please pull the below update for VirtFS > > The following changes since commit ee74801035b0b5f1fdfd4e31d3a53f511f91c804: > > Merge remote-tracking branch 'remotes/lalrae/tags/mips-20150311' into > staging (2015-03-11 18:22:15 +)

Re: [Qemu-devel] [RESEND PATCH v4 3/6] pc-dimm: Add memory hot unplug request support for pc-dimm

2015-03-16 Thread Igor Mammedov
On Mon, 16 Mar 2015 16:58:15 +0800 Zhu Guihua wrote: > From: Tang Chen > > Implement memory unplug request cb for pc-dimm, and call it in > pc_machine_device_unplug_request_cb(). Please, merge this patch with 2/6. > > Signed-off-by: Tang Chen > Signed-off-by: Zhu Guihua > --- > hw/i386/pc.

Re: [Qemu-devel] [PATCH 07/25] nbd: Add "failed to open export" error message

2015-03-16 Thread Max Reitz
On 2015-03-11 at 07:24, Paolo Bonzini wrote: On 25/02/2015 19:08, Max Reitz wrote: In case the connection is closed before the export length can be read, and an export name had been specified, this generally indicates that for some reason the export could not be opened (e.g. there is no export

Re: [Qemu-devel] [PATCH 11/25] qemu-nbd: Fix and improve input verification

2015-03-16 Thread Max Reitz
On 2015-03-11 at 07:30, Paolo Bonzini wrote: On 25/02/2015 19:08, Max Reitz wrote: This patch makes sure the result of strtol() does not overflow (by storing it in long integers instead of plain integers, and by checking errno), allows the user to specify "--discard on" and "--detect-zeroes unm

Re: [Qemu-devel] [PATCH 20/25] block/nbd: Comment on discard/flush silently failing

2015-03-16 Thread Max Reitz
On 2015-03-11 at 07:31, Paolo Bonzini wrote: On 25/02/2015 19:08, Max Reitz wrote: If some operation cannot be performed by a block driver, it is normally supposed to return an error. In these cases, however, it is fine to pretend the operations were carried out successfully because if the NBD

Re: [Qemu-devel] [RESEND PATCH v4 1/6] acpi, mem-hotplug: Add acpi_memory_slot_status() to get MemStatus

2015-03-16 Thread Michael S. Tsirkin
On Mon, Mar 16, 2015 at 04:58:13PM +0800, Zhu Guihua wrote: > From: Tang Chen > > Add a new API named acpi_memory_slot_status() to obtain a single memory > slot status. Doing this is because this procedure will be used by other > functions in the next coming patches. > > Signed-off-by: Tang Chen

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Give laptop users ability to scroll in monitor

2015-03-16 Thread Peter Maydell
On 16 March 2015 at 13:48, Daniel P. Berrange wrote: > The docs[1] still refer to fn+up/down as the way to achieve page up/down, > so perhaps your install has simply lost the shortcut mappings ? Works for me on a 2011 MacBook Air running Mavericks, anyway. (Terminal is not necessarily the best ap

Re: [Qemu-devel] [PATCH v5 5/7] vfio-pci: pass the aer error to guest

2015-03-16 Thread Alex Williamson
On Mon, 2015-03-16 at 15:35 +0800, Chen Fan wrote: > On 03/16/2015 11:52 AM, Alex Williamson wrote: > > On Mon, 2015-03-16 at 11:05 +0800, Chen Fan wrote: > >> On 03/14/2015 06:34 AM, Alex Williamson wrote: > >>> On Thu, 2015-03-12 at 18:23 +0800, Chen Fan wrote: > when the vfio device encount

Re: [Qemu-devel] [RESEND PATCH v4 4/6] acpi, mem-hotplug: Add unplug cb for memory device

2015-03-16 Thread Igor Mammedov
On Mon, 16 Mar 2015 16:58:16 +0800 Zhu Guihua wrote: > From: Tang Chen > > This patch adds unplug cb for memory device. It resets some memory status > in acpi_memory_unplug_cb(). 'some' is quite vague. Pls, explain what it does in commit message. [...] > diff --git a/hw/acpi/piix4.c b/hw/acpi/

[Qemu-devel] [PATCH 0/6] fw-cfg: documentation, cleanup, and proposed feature

2015-03-16 Thread Gabriel L. Somlo
Document and clean up fw_cfg; additionally, allow user-provided blobs to be inserted into fw_cfg via the qemu command line. Please consider applying 1-5; Patch 6/6 should be considered as just an RFC at this time, please let me know what you all think about it. Summary of patches in the series:

[Qemu-devel] [PATCH 4/6] fw_cfg: exit with error when dupe fw_cfg file name inserted

2015-03-16 Thread Gabriel L. Somlo
Currently, when fw_cfg_add_file_callback() is invoked with a duplicate file name, it gets to insert the data blob at the next available selector, but exit (signalling the error via a call to the trace_fw_cfg_add_file_dupe() function) before incrementing the next available selector as soon as it fin

[Qemu-devel] [PATCH 6/6] qga: RFC: guest-side retrieval of fw_cfg file

2015-03-16 Thread Gabriel L. Somlo
Add -g (--get-fwcfg) client-mode option to qemu-ga, causing the named fw_cfg file to be retrieved and written to stdout. Signed-off-by: Gabriel Somlo --- First off, I have NOT forgotten the suggestion to make this a standalone binary, and will do so when I submit it "for real". It's just more co

[Qemu-devel] [PATCH 1/6] fw_cfg: add documentation file (docs/specs/fw_cfg.txt)

2015-03-16 Thread Gabriel L. Somlo
This document covers the generic portions of fw_cfg as well as the x86/x86-64 architecture specific components. Signed-off-by: Jordan Justen Signed-off-by: Gabriel Somlo --- This is a resubmission of Jordan's patch from back when: http://lists.gnu.org/archive/html/qemu-devel/2011-04/msg00238.

[Qemu-devel] [PATCH 5/6] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-03-16 Thread Gabriel L. Somlo
Allow user supplied files to be inserted into the fw_cfg device before starting the guest. Since fw_cfg_add_file() already disallows duplicate fw_cfg file names, qemu will exit with an error message if the user supplies multiple blobs with the same fw_cfg file name, or if a blob name collides with

[Qemu-devel] [PATCH 3/6] fw_cfg: assertion to detect memory leak when adding new data blob

2015-03-16 Thread Gabriel L. Somlo
Currently, fw_cfg_add_bytes_read_callback() does not deal with the possibility that the data pointer at the requested key position has previously been set, and assumes it will be called exactly once for each key value. This patch introduces an assertion to codify this assumption, and insure the da

[Qemu-devel] [PATCH 2/6] fw_cfg: remove support for guest-side data writes

2015-03-16 Thread Gabriel L. Somlo
The fw_cfg device allowed guest-side data writes to overwrite the selected entry in place, without allowing modification to the size of the entry, and with the ability to invoke a callback each time the entry was overwritten completely. To date, we are not aware of any use case which relies on the

Re: [Qemu-devel] [RESEND PATCH v4 5/6] pc-dimm: Add memory hot unplug support for pc-dimm

2015-03-16 Thread Igor Mammedov
On Mon, 16 Mar 2015 16:58:17 +0800 Zhu Guihua wrote: > From: Tang Chen > > Implement unplug cb for pc-dimm. It calls memory unplug cb to reset > some memory status, removes the corresponding memory region, and > unregisters vmstate. > > Signed-off-by: Tang Chen > Signed-off-by: Zhu Guihua Pl

Re: [Qemu-devel] [PATCH 0/6] fw-cfg: documentation, cleanup, and proposed feature

2015-03-16 Thread Patchew Tool
This series passed Patchew automatic testing, but there are some warnings. Find the log fragments below, or open the following URL to see the full log: http://qemu.patchew.org/testing/log/<1426515305-17766-1-git-send-email-so...@cmu.edu> --8<- docker run --net=none -v /var/tmp

Re: [Qemu-devel] [PATCH RFC v1 1/2] xen/hw/passthrough: Use errno instead of ret for xc_physdev_map_* calls

2015-03-16 Thread Konrad Rzeszutek Wilk
On Mon, Mar 16, 2015 at 10:13:50AM +, Stefano Stabellini wrote: > On Fri, 13 Mar 2015, Konrad Rzeszutek Wilk wrote: > > As the libxc library follows (mostly) the return negative > > for failure and stashes the error value in errno. > > > > Signed-off-by: Konrad Rzeszutek Wilk > > Acked-by: S

Re: [Qemu-devel] [PULL 02/11] Add migrate_incoming

2015-03-16 Thread Eric Blake
On 03/16/2015 07:41 AM, Juan Quintela wrote: > From: "Dr. David Alan Gilbert" > > Add migrate_incoming/migrate-incoming to start an incoming > migration. > > Once a qemu has been started with > -incoming defer > > the migration can be started by issuing: > migrate_incoming uri > > Sign

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/3] VFIO: Clear INTx pending state on EEH reset

2015-03-16 Thread Gavin Shan
On Mon, Mar 16, 2015 at 03:05:32PM +1100, Benjamin Herrenschmidt wrote: >On Mon, 2015-03-16 at 12:04 +1100, Gavin Shan wrote: >> >> >> (2) QEMU sends IOCTL commands to host to disable MSIx and enable INTx. At >> this stage the INTx is still masked. At later point, the guest is requesting >> unmas

Re: [Qemu-devel] [PATCH] acpi: add acpi_send_gpe_event() to rise sci for hotplug

2015-03-16 Thread Michael S. Tsirkin
On Mon, Mar 16, 2015 at 05:39:44PM +0800, Zhu Guihua wrote: > Add a new API named acpi_send_gpe_event() to send hotplug SCI. > This API can be used by pci, cpu and memory hotplug. > > Signed-off-by: Zhu Guihua Good cleanup, but needs to fix up the coding style. > --- > hw/acpi/core.c

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Give laptop users ability to scroll in monitor

2015-03-16 Thread Programmingkid
On Mar 16, 2015, at 10:00 AM, Peter Maydell wrote: > On 16 March 2015 at 13:48, Daniel P. Berrange wrote: >> The docs[1] still refer to fn+up/down as the way to achieve page up/down, >> so perhaps your install has simply lost the shortcut mappings ? > > Works for me on a 2011 MacBook Air runnin

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Give laptop users ability to scroll in monitor

2015-03-16 Thread Programmingkid
On Mar 16, 2015, at 9:48 AM, Daniel P. Berrange wrote: > On Fri, Mar 13, 2015 at 04:43:54PM -0400, Programmingkid wrote: >> >> On Mar 13, 2015, at 1:31 PM, Paolo Bonzini wrote: >> >>> >>> >>> On 13/03/2015 15:48, Programmingkid wrote: On Mar 13, 2015, at 5:51 AM, Peter Maydell wrot

Re: [Qemu-devel] [PATCH 05/25] nbd: Avoid generic -EINVAL

2015-03-16 Thread Paolo Bonzini
On 16/03/2015 14:51, Max Reitz wrote: >>> >> Propagating the return value from write_sync is uglier, but it is even >> better in terms of returned value. > > We can only return -errno values, but write_sync() may do partial writes > so it may return non-negative values which still indicate an er

Re: [Qemu-devel] [PULL 0/7] target-arm queue

2015-03-16 Thread Peter Maydell
On 16 March 2015 at 12:40, Peter Maydell wrote: > Last batch of bugfixes before hardfreeze... > > -- PMM > > The following changes since commit f421f05754ac5aabe15f12051390204116408b00: > > Merge remote-tracking branch > 'remotes/kraxel/tags/pull-seabios-1.8.1-2015

Re: [Qemu-devel] [PATCH 20/25] block/nbd: Comment on discard/flush silently failing

2015-03-16 Thread Paolo Bonzini
On 16/03/2015 14:58, Max Reitz wrote: >>> >>> diff --git a/block/nbd-client.c b/block/nbd-client.c >>> index be6803d..ab13607 100644 >>> --- a/block/nbd-client.c >>> +++ b/block/nbd-client.c >>> @@ -315,6 +315,7 @@ int nbd_client_co_flush(BlockDriverState *bs) >>> ssize_t ret; >>> i

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Give laptop users ability to scroll in monitor

2015-03-16 Thread Peter Maydell
On 16 March 2015 at 14:38, Programmingkid wrote: > > On Mar 16, 2015, at 10:00 AM, Peter Maydell wrote: > >> On 16 March 2015 at 13:48, Daniel P. Berrange wrote: >>> The docs[1] still refer to fn+up/down as the way to achieve page up/down, >>> so perhaps your install has simply lost the shortcut

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-03-16 Thread Eric Blake
On 03/16/2015 04:31 AM, hw.clau...@gmail.com wrote: > From: Claudio Fontana > > usage is similar to the commands x, xp. > > Example with string: looking for "ELF" header in memory: > > (qemu) s/100cb 0x40001000 "ELF" > searching memory area [40001000-400f5240] > 4009

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Give laptop users ability to scroll in monitor

2015-03-16 Thread Programmingkid
On Mar 16, 2015, at 10:43 AM, Peter Maydell wrote: > On 16 March 2015 at 14:38, Programmingkid wrote: >> >> On Mar 16, 2015, at 10:00 AM, Peter Maydell wrote: >> >>> On 16 March 2015 at 13:48, Daniel P. Berrange wrote: The docs[1] still refer to fn+up/down as the way to achieve page up/d

Re: [Qemu-devel] [PATCH 05/25] nbd: Avoid generic -EINVAL

2015-03-16 Thread Max Reitz
On 2015-03-16 at 10:42, Paolo Bonzini wrote: On 16/03/2015 14:51, Max Reitz wrote: Propagating the return value from write_sync is uglier, but it is even better in terms of returned value. We can only return -errno values, but write_sync() may do partial writes so it may return non-negative va

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Give laptop users ability to scroll in monitor

2015-03-16 Thread Paolo Bonzini
On 16/03/2015 15:45, Programmingkid wrote: > > > Are you saying you are able to scroll up and down in QEMU's monitor > > > using your MacBook Air's keyboard? > > > > I haven't attempted to use the monitor. I'm just saying that > > on my OSX it does turn those keys into pageup/down. > > Please t

Re: [Qemu-devel] [PATCH 20/25] block/nbd: Comment on discard/flush silently failing

2015-03-16 Thread Max Reitz
On 2015-03-16 at 10:44, Paolo Bonzini wrote: On 16/03/2015 14:58, Max Reitz wrote: diff --git a/block/nbd-client.c b/block/nbd-client.c index be6803d..ab13607 100644 --- a/block/nbd-client.c +++ b/block/nbd-client.c @@ -315,6 +315,7 @@ int nbd_client_co_flush(BlockDriverState *bs) ssize_

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Give laptop users ability to scroll in monitor

2015-03-16 Thread Programmingkid
On Mar 16, 2015, at 10:47 AM, Paolo Bonzini wrote: > > > On 16/03/2015 15:45, Programmingkid wrote: Are you saying you are able to scroll up and down in QEMU's monitor using your MacBook Air's keyboard? >>> >>> I haven't attempted to use the monitor. I'm just saying that >>> on my OS

Re: [Qemu-devel] [PATCH 05/25] nbd: Avoid generic -EINVAL

2015-03-16 Thread Paolo Bonzini
On 16/03/2015 15:48, Max Reitz wrote: > On 2015-03-16 at 10:42, Paolo Bonzini wrote: >> >> On 16/03/2015 14:51, Max Reitz wrote: Propagating the return value from write_sync is uglier, but it is even better in terms of returned value. >>> We can only return -errno values, but write_sync

Re: [Qemu-devel] [PATCH 20/25] block/nbd: Comment on discard/flush silently failing

2015-03-16 Thread Paolo Bonzini
On 16/03/2015 15:49, Max Reitz wrote: >>> >> Right, but a better model than block.c should be for example >> block/raw-posix.c, which returns ENOTSUP (I checked now...). > > Maybe we should catch ENOTSUP in bdrv_co_discard() and override it? That's what it does: if (ret && ret != -ENOT

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Give laptop users ability to scroll in monitor

2015-03-16 Thread Paolo Bonzini
On 16/03/2015 15:49, Programmingkid wrote: > > On Mar 16, 2015, at 10:47 AM, Paolo Bonzini wrote: > >> >> >> On 16/03/2015 15:45, Programmingkid wrote: > Are you saying you are able to scroll up and down in QEMU's monitor > using your MacBook Air's keyboard? I haven't attempte

Re: [Qemu-devel] [PATCH 20/25] block/nbd: Comment on discard/flush silently failing

2015-03-16 Thread Max Reitz
On 2015-03-16 at 10:51, Paolo Bonzini wrote: On 16/03/2015 15:49, Max Reitz wrote: Right, but a better model than block.c should be for example block/raw-posix.c, which returns ENOTSUP (I checked now...). Maybe we should catch ENOTSUP in bdrv_co_discard() and override it? That's what it does:

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-03-16 Thread Claudio Fontana
On 16 March 2015 at 15:45, Eric Blake wrote: > On 03/16/2015 04:31 AM, hw.clau...@gmail.com wrote: >> From: Claudio Fontana >> >> usage is similar to the commands x, xp. >> >> Example with string: looking for "ELF" header in memory: >> >> (qemu) s/100cb 0x40001000 "ELF" >> searching memory ar

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Give laptop users ability to scroll in monitor

2015-03-16 Thread Peter Maydell
On 16 March 2015 at 14:52, Paolo Bonzini wrote: > > > On 16/03/2015 15:49, Programmingkid wrote: >> Sorry but the GTK interface doesn't work on Mac OS X. We are all hoping this >> will change in the future. > > What's the problem? Was the bug reported? Well known and longstanding -- the Cocoa U

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Give laptop users ability to scroll in monitor

2015-03-16 Thread Programmingkid
On Mar 16, 2015, at 10:52 AM, Paolo Bonzini wrote: > > > On 16/03/2015 15:49, Programmingkid wrote: >> >> On Mar 16, 2015, at 10:47 AM, Paolo Bonzini wrote: >> >>> >>> >>> On 16/03/2015 15:45, Programmingkid wrote: >> Are you saying you are able to scroll up and down in QEMU's monitor >

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-03-16 Thread Paolo Bonzini
On 16/03/2015 15:45, Eric Blake wrote: > On 03/16/2015 04:31 AM, hw.clau...@gmail.com wrote: >> From: Claudio Fontana >> >> usage is similar to the commands x, xp. >> >> Example with string: looking for "ELF" header in memory: >> >> (qemu) s/100cb 0x40001000 "ELF" searching memory area >>

Re: [Qemu-devel] [RESEND PATCH v4 6/6] acpi: Add hardware implementation for memory hot unplug

2015-03-16 Thread Igor Mammedov
On Mon, 16 Mar 2015 16:58:18 +0800 Zhu Guihua wrote: > This patch adds a new bit to memory hotplug IO port indicating that actually bit was added in 2/6 where is_removing had been added. > EJ0 has been evaluated by guest OS. And call pc-dimm unplug cb to do > the real removal. > > Signed-off-by

[Qemu-devel] [PULL 6/6] target-tricore: Add instructions of SYS opcode format

2015-03-16 Thread Bastian Koppelmann
This adds only the non trap instructions. Signed-off-by: Bastian Koppelmann --- target-tricore/cpu.h | 7 target-tricore/helper.h| 3 ++ target-tricore/op_helper.c | 89 ++ target-tricore/translate.c | 76 ++

[Qemu-devel] [PULL 5/6] target-tricore: Add instructions of RRRW opcode format

2015-03-16 Thread Bastian Koppelmann
Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 63 ++ 1 file changed, 63 insertions(+) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index 1cebc9b..f03cd26 100644 --- a/target-t

[Qemu-devel] [PULL 2/6] target-tricore: Add instructions of RRR1 opcode format, which have 0x63 as first opcode

2015-03-16 Thread Bastian Koppelmann
Add helpers: * msub64_q_ssov: multiply two 32 bit q-format number, sub the result from a 64 bit q-format number and saturate. * msub32_q_sub_ssov: sub two 64 bit q-format numbers and return a 32 bit result. * msubr_q_ssov: multiply two 32 bi

[Qemu-devel] [PULL 4/6] target-tricore: Add instructions of RRRR opcode format

2015-03-16 Thread Bastian Koppelmann
Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 56 ++ 1 file changed, 56 insertions(+) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index 525b236..1cebc9b 100644 --- a/target-t

[Qemu-devel] [PULL 0/6] tricore patches for 2.3

2015-03-16 Thread Bastian Koppelmann
ommit 307146cb9359ad6d4544e00af073088772d165eb: Merge remote-tracking branch 'remotes/kvaneesh/for-upstream' into staging (2015-03-16 13:04:09 +) are available in the git repository at: https://github.com/bkoppelmann/qemu-tricore-upstream.git tags/pull-tricore-20150316 for you to fetc

Re: [Qemu-devel] [PATCH] block: Fix block-set-write-threshold not to use funky error class

2015-03-16 Thread Kevin Wolf
Am 13.03.2015 um 18:51 hat Markus Armbruster geschrieben: > Error classes are a leftover from the days of "rich" error objects. > New code should always use ERROR_CLASS_GENERIC_ERROR. Commit e246211 > added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it. > > Signed-off-by: Markus Armbruster

[Qemu-devel] [PULL 3/6] target-tricore: Add instructions of RRR1 opcode format, which have 0xe3 as first opcode

2015-03-16 Thread Bastian Koppelmann
Add helpers helper_subadr_h/_ssov which subs one halfword and adds one halfword, rounds / and saturates each half word independently. Add microcode helper functions: * gen_msubad_h/ads_h: multiply two halfwords left justified and sub from the first one word and add th

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/3] VFIO: Clear INTx pending state on EEH reset

2015-03-16 Thread Alex Williamson
On Tue, 2015-03-17 at 01:34 +1100, Gavin Shan wrote: > On Mon, Mar 16, 2015 at 03:05:32PM +1100, Benjamin Herrenschmidt wrote: > >On Mon, 2015-03-16 at 12:04 +1100, Gavin Shan wrote: > >> > >> > >> (2) QEMU sends IOCTL commands to host to disable MSIx and enable INTx. At > >> this stage the INTx

[Qemu-devel] [PULL 1/6] target-tricore: Add instructions of RRR1 opcode format, which have 0xa3 as first opcode

2015-03-16 Thread Bastian Koppelmann
Add helpers: * sub64_ssov: subs two 64 bit values and saturates the result. * subr_h/_ssov: subs two halfwords from two words in q-format with rounding / and saturates each result independetly. Add microcode generator: * gen_sub64_d: adds two 64 bit values. * ge

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Give laptop users ability to scroll in monitor

2015-03-16 Thread Programmingkid
On Mar 16, 2015, at 10:59 AM, Peter Maydell wrote: > On 16 March 2015 at 14:52, Paolo Bonzini wrote: >> >> >> On 16/03/2015 15:49, Programmingkid wrote: >>> Sorry but the GTK interface doesn't work on Mac OS X. We are all hoping >>> this will change in the future. >> >> What's the problem?

Re: [Qemu-devel] [PATCH] qemu-img: Avoid qerror_report_err() outside QMP handlers, again

2015-03-16 Thread Kevin Wolf
Am 12.03.2015 um 16:08 hat Markus Armbruster geschrieben: > qerror_report_err() is a transitional interface to help with > converting existing monitor commands to QMP. It should not be used > elsewhere. Replace by error_report_err(). > > Commit 6936f29 cleaned that up in qemu-img.c, but two call

[Qemu-devel] [PATCH] qga: implement qmp_guest_network_get_interfaces for win32

2015-03-16 Thread Kirk Allan
For Windows guest greater than or equal to Vista/2008, _WIN32_WINNT may be defined via the configure option with-win32-winnt=. The use of with-win32-wint= to set _WIN32_WINNT is optional. Setting this value to at least 0x0600 e.g. with-win32-wint=0x0600, provides access to the OnLinkPrefixLength

Re: [Qemu-devel] [PATCH v3] block/null: Latency simulation by adding new option "latency-ns"

2015-03-16 Thread Kevin Wolf
Am 11.03.2015 um 06:42 hat Fam Zheng geschrieben: > Aio context switch should just work because the requests will be > drained, so the scheduled timer(s) on the old context will be freed. > > Signed-off-by: Fam Zheng > > --- > v3: latency_ns -> latency-ns; Add documentation in qapi json. [Eric]

Re: [Qemu-devel] [PATCH] block/throttle: Use host clock type

2015-03-16 Thread Kevin Wolf
Am 13.03.2015 um 13:23 hat Alberto Garcia geschrieben: > On Fri, Mar 13, 2015 at 02:35:29PM +0800, Fam Zheng wrote: > > > Throttle timers won't make any progress when VCPU is not running, > > which is prone to stall the request queue in cases like utils, > > qtest, suspending, and live migration,

Re: [Qemu-devel] [PATCH v3] Execute _start and reach to the first function call successfully

2015-03-16 Thread Richard Henderson
On 03/13/2015 11:03 PM, Chen Gang wrote: > +static void decode_rrr_1_opcode_y0(struct DisasContext *dc, > + tilegx_bundle_bits bundle) > +{ > +switch (get_RRROpcodeExtension_Y0(bundle)) { > +case UNARY_RRR_1_OPCODE_Y0: > +switch (get_UnaryOpcodeExte

Re: [Qemu-devel] [PATCH v5 for-2.3 28/28] docs: Add PXB documentation

2015-03-16 Thread Michael S. Tsirkin
On Mon, Mar 16, 2015 at 02:16:40PM +0200, Marcel Apfelbaum wrote: > On 03/10/2015 07:42 PM, Michael S. Tsirkin wrote: > >On Tue, Mar 10, 2015 at 06:21:14PM +0200, Marcel Apfelbaum wrote: > >>On 03/10/2015 05:47 PM, Michael S. Tsirkin wrote: > >>>On Tue, Mar 10, 2015 at 05:32:14PM +0200, Marcel Apfe

Re: [Qemu-devel] [PATCH v3] Execute _start and reach to the first function call successfully

2015-03-16 Thread Richard Henderson
On 03/15/2015 04:57 PM, Chen Gang wrote: > OK, thanks. And next, I shall try to send the whole tilegx patches again > (it is about 6-8 patches), within 2015-03-18. When you do so, make sure it's against the *current* master tree. Your patch set doesn't compile at all at the moment, after commit

Re: [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu.

2015-03-16 Thread Cornelia Huck
On Mon, 16 Mar 2015 06:03:24 +0100 "Michael S. Tsirkin" wrote: > On Mon, Mar 16, 2015 at 01:44:22PM +1030, Rusty Russell wrote: > > diff --git a/content.tex b/content.tex > > index 6ba079d..2c946a5 100644 > > --- a/content.tex > > +++ b/content.tex > > @@ -600,10 +600,19 @@ them: it is only writ

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/3] VFIO: Clear INTx pending state on EEH reset

2015-03-16 Thread Gavin Shan
On Mon, Mar 16, 2015 at 09:05:27AM -0600, Alex Williamson wrote: >On Tue, 2015-03-17 at 01:34 +1100, Gavin Shan wrote: >> On Mon, Mar 16, 2015 at 03:05:32PM +1100, Benjamin Herrenschmidt wrote: >> >On Mon, 2015-03-16 at 12:04 +1100, Gavin Shan wrote: >> >> >> >> (2) QEMU sends IOCTL commands to ho

Re: [Qemu-devel] [PATCH v5 for-2.3 28/28] docs: Add PXB documentation

2015-03-16 Thread Marcel Apfelbaum
On 03/16/2015 05:28 PM, Michael S. Tsirkin wrote: On Mon, Mar 16, 2015 at 02:16:40PM +0200, Marcel Apfelbaum wrote: On 03/10/2015 07:42 PM, Michael S. Tsirkin wrote: On Tue, Mar 10, 2015 at 06:21:14PM +0200, Marcel Apfelbaum wrote: On 03/10/2015 05:47 PM, Michael S. Tsirkin wrote: On Tue, Mar

<    1   2   3   4   >