Am 13.03.2015 um 13:23 hat Alberto Garcia geschrieben: > On Fri, Mar 13, 2015 at 02:35:29PM +0800, Fam Zheng wrote: > > > Throttle timers won't make any progress when VCPU is not running, > > which is prone to stall the request queue in cases like utils, > > qtest, suspending, and live migration, unless carefully handled. > > Yes, this can be easily reproduced by stopping the VM and starting a > block-commit job. If the I/O in that device is throttled then the job > will be stalled. > > Then there's also the situation that we discussed in IRC: if the > block-commit job is ongoing and then we stop the VM, then the rest of > the data will be committed bypassing the throttling settings. But > that's not related to these changes. > > > Signed-off-by: Fam Zheng <f...@redhat.com> > > --- > > block.c | 2 +- > > tests/test-throttle.c | 14 +++++++------- > > 2 files changed, 8 insertions(+), 8 deletions(-) > > Reviewed-By: Alberto Garcia <be...@igalia.com>
Thanks, applied to the block branch. Kevin
