Re: [Qemu-devel] [PATCH v5 26/45] Postcopy page-map-incoming (PMI) structure

2015-03-13 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Wed, Feb 25, 2015 at 04:51:49PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > The PMI holds the state of each page on the incoming side, > > so that we can tell if the page is missing, already receive

Re: [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu.

2015-03-13 Thread Michael S. Tsirkin
On Fri, Mar 13, 2015 at 11:47:18AM +1030, Rusty Russell wrote: > "Michael S. Tsirkin" writes: > > On Thu, Mar 12, 2015 at 11:34:35AM +1030, Rusty Russell wrote: > >> "Michael S. Tsirkin" writes: > >> > On Wed, Mar 11, 2015 at 10:06:40PM +1030, Rusty Russell wrote: > >> >> Each entry in th

Re: [Qemu-devel] [PATCH] vl: fix resource leak with monitor_fdset_add_fd

2015-03-13 Thread Eric Blake
On 03/13/2015 06:55 AM, Paolo Bonzini wrote: > monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP > command add_fd). Free it. > > Signed-off-by: Paolo Bonzini > --- > v1->v2: line length [Fam], pass &error_abort [Shannon] > --- > vl.c | 7 +-- > 1 file changed, 5 insert

Re: [Qemu-devel] [PATCH v4] hmp: add info iothreads command

2015-03-13 Thread Markus Armbruster
Fam Zheng writes: > On Fri, 03/13 02:16, Patchew Tool wrote: >> socket_accept failed: Resource temporarily unavailable >> ** >> ERROR:/var/tmp/patchew-test/git/tests/libqtest.c:192:qtest_init: >> assertion failed: (s->fd >= 0 && s->qmp_fd >= 0) >> GTester: last random seed: R02Sa6e2a5d48f79c1916f

Re: [Qemu-devel] PCI passthrough of 40G ethernet interface (Openstack/KVM)

2015-03-13 Thread jacob jacob
> So, it could be the i40e driver then ? Because IIUC, VFs use a separate > driver. Just to rule out the possibility that there might be some driver > fixes that > could help with this, it might be a good idea to try a 3.19 or later upstream > kernel. > I tried with the latest DPDK release too (d

Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset

2015-03-13 Thread Michael S. Tsirkin
On Fri, Mar 13, 2015 at 02:07:19PM +0800, Fam Zheng wrote: > On Thu, 03/12 12:15, Michael S. Tsirkin wrote: > > On Thu, Mar 12, 2015 at 11:04:33AM +, Peter Maydell wrote: > > > On 12 March 2015 at 10:57, Michael S. Tsirkin wrote: > > > > This isn't a device reset though. > > > > The function t

Re: [Qemu-devel] [PULL] Update OpenBIOS images

2015-03-13 Thread Peter Maydell
On 13 March 2015 at 11:17, Mark Cave-Ayland wrote: > Hi Peter, > > Here are the binaries for the outstanding OpenBIOS updates for 2.3. Please > pull. > > > ATB, > > Mark. > > > The following changes since commit f9f141b7475acfed1b6a28809687109702295be3: > > Merge remote-tracking branch 'remotes

Re: [Qemu-devel] [PATCH 2/2] memory: fix the eventfd data endianness according to the host

2015-03-13 Thread Michael S. Tsirkin
On Fri, Mar 13, 2015 at 12:06:06PM +0100, Paolo Bonzini wrote: > > > On 13/03/2015 09:11, Greg Kurz wrote: > > The data argument is a host entity. It is not related to the target > > endianness. Let's introduce a HOST_WORDS_BIGENDIAN based helper for > > that. > > > > This patch fixes ioeventfd

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Give laptop users ability to scroll in monitor

2015-03-13 Thread Programmingkid
On Mar 13, 2015, at 5:51 AM, Peter Maydell wrote: > On 13 March 2015 at 04:35, Programmingkid wrote: >> Laptop users usually have keyboards that are missing the page up and page >> down keys. This means they cannot scroll in the monitor. This patch gives >> laptop users the ability to scroll i

Re: [Qemu-devel] [PATCH 2/2] memory: fix the eventfd data endianness according to the host

2015-03-13 Thread Paolo Bonzini
On 13/03/2015 12:32, Greg Kurz wrote: > On Fri, 13 Mar 2015 12:06:06 +0100 > Paolo Bonzini wrote: >> >> >> On 13/03/2015 09:11, Greg Kurz wrote: >>> The data argument is a host entity. It is not related to the target >>> endianness. Let's introduce a HOST_WORDS_BIGENDIAN based helper for >>> tha

Re: [Qemu-devel] [PULL v3 0/5] sdl patch queue.

2015-03-13 Thread Peter Maydell
On 13 March 2015 at 12:58, Gerd Hoffmann wrote: > Hi, > > Misc stuff in the basket: sdl bugfixes, some preparing patches for the > upcoming opengl support in sdl2, x11 build improvement. > > v2 fixes the clang build failure. > v3 (hopefully) fixes the osx build failure too. > > please pull, >

Re: [Qemu-devel] [PATCH 2/2] memory: fix the eventfd data endianness according to the host

2015-03-13 Thread Michael S. Tsirkin
On Fri, Mar 13, 2015 at 03:52:50PM +0100, Paolo Bonzini wrote: > > > On 13/03/2015 12:32, Greg Kurz wrote: > > On Fri, 13 Mar 2015 12:06:06 +0100 > > Paolo Bonzini wrote: > >> > >> > >> On 13/03/2015 09:11, Greg Kurz wrote: > >>> The data argument is a host entity. It is not related to the targe

Re: [Qemu-devel] [PATCH] user-exec.c: fix build on NetBSD/sparc64 and NetBSD/arm

2015-03-13 Thread Peter Maydell
On 5 March 2015 at 21:37, Tobias Nygren wrote: > A couple of #ifdef changes necessary to use NetBSD's ucontext > structs on sparc64 and arm. > > Signed-off-by: Tobias Nygren > --- > user-exec.c | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) Applied to qemu master, sinc

Re: [Qemu-devel] [RFC PATCH v10 18/24] replay: replay aio requests

2015-03-13 Thread Paolo Bonzini
On 27/02/2015 14:11, Pavel Dovgalyuk wrote: > This patch adds identifier to aio requests. ID is used for creating bottom > halves and identifying them while replaying. > The patch also introduces several functions that make possible replaying > of the aio requests. Out of curiosity, why did you

[Qemu-devel] sanity checks and error management

2015-03-13 Thread Catalin Vasile
Is there any documentation on error reporting in qemu? I've seen a lot of diverse methods used to report errors in sanity checks and I don't know which one should I use and when.

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Give laptop users ability to scroll in monitor

2015-03-13 Thread Paolo Bonzini
On 13/03/2015 15:48, Programmingkid wrote: > > On Mar 13, 2015, at 5:51 AM, Peter Maydell wrote: > >> On 13 March 2015 at 04:35, Programmingkid wrote: >>> Laptop users usually have keyboards that are missing the page up and page >>> down keys. This means they cannot scroll in the monitor. Thi

[Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

2015-03-13 Thread Markus Armbruster
Error classes are a leftover from the days of "rich" error objects. New code should always use ERROR_CLASS_GENERIC_ERROR. Commit 1d0d59f added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it. --- ui/vnc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c i

Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

2015-03-13 Thread Markus Armbruster
Markus Armbruster writes: > Error classes are a leftover from the days of "rich" error objects. > New code should always use ERROR_CLASS_GENERIC_ERROR. Commit 1d0d59f > added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it. Signed-off-by: Markus Armbruster > ui/vnc.c | 2 +- > 1 file chan

[Qemu-devel] [PATCH] block: Fix block-set-write-threshold not to use funky error class

2015-03-13 Thread Markus Armbruster
Error classes are a leftover from the days of "rich" error objects. New code should always use ERROR_CLASS_GENERIC_ERROR. Commit e246211 added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it. Signed-off-by: Markus Armbruster --- block/write-threshold.c | 2 +- qapi/block-core.json| 4 ---

Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

2015-03-13 Thread Patchew Tool
This series passed Patchew automatic testing, but there are some warnings. Find the log fragments below, or open the following URL to see the full log: http://qemu.patchew.org/testing/log/<1426268589-14756-1-git-send-email-arm...@redhat.com> --8<- === Starting docker === Copy

Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

2015-03-13 Thread Peter Maydell
On 13 March 2015 at 17:50, Patchew Tool wrote: > > This series passed Patchew automatic testing, but there are some warnings. > > Find the log fragments below, or open the following URL to see the full log: > > http://qemu.patchew.org/testing/log/<1426268589-14756-1-git-send-email-arm...@redhat.co

[Qemu-devel] [2.4 PATCH v3 15/19] block: Resize bitmaps on bdrv_truncate

2015-03-13 Thread John Snow
Signed-off-by: John Snow --- block.c| 18 + include/qemu/hbitmap.h | 10 ++ util/hbitmap.c | 52 ++ 3 files changed, 80 insertions(+) diff --git a/block.c b/block.c index 1eee394..f40b014 100644 --- a

[Qemu-devel] [2.4 PATCH v3 09/19] block: Add bitmap successors

2015-03-13 Thread John Snow
A bitmap successor is an anonymous BdrvDirtyBitmap that is intended to be created just prior to a sensitive operation (e.g. Incremental Backup) that can either succeed or fail, but during the course of which we still want a bitmap tracking writes. On creating a successor, we "freeze" the parent bi

[Qemu-devel] [2.4 PATCH v3 18/19] iotests: add simple incremental backup case

2015-03-13 Thread John Snow
Reviewed-by: Max Reitz Signed-off-by: John Snow --- tests/qemu-iotests/124 | 122 + tests/qemu-iotests/124.out | 4 +- 2 files changed, 124 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/124 b/tests/qemu-iotests/124 index 7985cd1.

[Qemu-devel] [2.4 PATCH v3 17/19] iotests: add invalid input incremental backup tests

2015-03-13 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Max Reitz --- tests/qemu-iotests/124 | 89 ++ tests/qemu-iotests/124.out | 5 +++ tests/qemu-iotests/group | 1 + 3 files changed, 95 insertions(+) create mode 100644 tests/qemu-iotests/124 create mode 10

[Qemu-devel] [2.4 PATCH v3 01/19] docs: incremental backup documentation

2015-03-13 Thread John Snow
Signed-off-by: John Snow --- docs/bitmaps.md | 311 1 file changed, 311 insertions(+) create mode 100644 docs/bitmaps.md diff --git a/docs/bitmaps.md b/docs/bitmaps.md new file mode 100644 index 000..ad8c33b --- /dev/null +++ b/docs/b

[Qemu-devel] [2.4 PATCH v3 19/19] iotests: add incremental backup failure recovery test

2015-03-13 Thread John Snow
To test the failure case, we modify iotests.py to allow us to specify that we'd like to allow failures when we wait for block job events. Reviewed-by: Max Reitz Signed-off-by: John Snow --- tests/qemu-iotests/124| 57 ++- tests/qemu-iotests/124.ou

[Qemu-devel] [2.4 PATCH v3 10/19] qmp: Add support of "dirty-bitmap" sync mode for drive-backup

2015-03-13 Thread John Snow
For "dirty-bitmap" sync mode, the block job will iterate through the given dirty bitmap to decide if a sector needs backup (backup all the dirty clusters and skip clean ones), just as allocation conditions of "top" sync mode. Signed-off-by: Fam Zheng Signed-off-by: John Snow Reviewed-by: Max Rei

[Qemu-devel] [2.4 PATCH v3 04/19] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove

2015-03-13 Thread John Snow
The new command pair is added to manage a user created dirty bitmap. The dirty bitmap's name is mandatory and must be unique for the same device, but different devices can have bitmaps with the same names. The granularity is an optional field. If it is not specified, we will choose a default granu

[Qemu-devel] [2.4 PATCH v3 14/19] block: Ensure consistent bitmap function prototypes

2015-03-13 Thread John Snow
We often don't need the BlockDriverState for functions that operate on bitmaps. Remove it. Signed-off-by: John Snow Reviewed-by: Max Reitz --- block.c | 13 ++--- block/backup.c| 2 +- block/mirror.c| 26 ++ blockdev.c|

[Qemu-devel] [2.4 PATCH v3 05/19] block: Introduce bdrv_dirty_bitmap_granularity()

2015-03-13 Thread John Snow
This returns the granularity (in bytes) of dirty bitmap, which matches the QMP interface and the existing query interface. Signed-off-by: John Snow Reviewed-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block.c | 8 ++-- include/block/block.h | 1 +

[Qemu-devel] [2.4 PATCH v3 06/19] hbitmap: cache array lengths

2015-03-13 Thread John Snow
As a convenience: between incremental backups, bitmap migrations and bitmap persistence we seem to need to recalculate these a lot. Because the lengths are a little bit-twiddly, let's just solidly cache them and be done with it. Signed-off-by: John Snow --- util/hbitmap.c | 4 1 file chang

[Qemu-devel] [2.4 PATCH v3 08/19] block: Add bitmap disabled status

2015-03-13 Thread John Snow
Add a status indicating the enabled/disabled state of the bitmap. A bitmap is by default enabled, but you can lock the bitmap into a read-only state by setting disabled = true. A previous version of this patch added a QMP interface for changing the state of the bitmap, but it has since been remove

[Qemu-devel] [2.4 PATCH v3 12/19] qmp: Add dirty bitmap status field in query-block

2015-03-13 Thread John Snow
Add the "frozen" status booleans, to inform clients when a bitmap is occupied doing a task. Signed-off-by: Fam Zheng Signed-off-by: John Snow --- block.c | 1 + qapi/block-core.json | 5 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index a98

[Qemu-devel] [2.4 PATCH v3 02/19] qapi: Add optional field "name" to block dirty bitmap

2015-03-13 Thread John Snow
From: Fam Zheng This field will be set for user created dirty bitmap. Also pass in an error pointer to bdrv_create_dirty_bitmap, so when a name is already taken on this BDS, it can report an error message. This is not global check, two BDSes can have dirty bitmap with a common name. Implemented

[Qemu-devel] [2.4 PATCH v3 00/19] block: transactionless incremental backup series

2015-03-13 Thread John Snow
What will life be like after this series gets committed upstream? Where do we go from here? This patchset enables the in-memory part of the incremental backup feature, without transactional support. Support for transactions was separated into a separate series which is also now available on-list.

[Qemu-devel] [2.4 PATCH v3 11/19] qmp: add block-dirty-bitmap-clear

2015-03-13 Thread John Snow
Add bdrv_clear_dirty_bitmap and a matching QMP command, qmp_block_dirty_bitmap_clear that enables a user to reset the bitmap attached to a drive. This allows us to reset a bitmap in the event of a full drive backup. Signed-off-by: John Snow --- block.c | 8 blockdev.c

[Qemu-devel] [2.4 PATCH v3 13/19] block: add BdrvDirtyBitmap documentation

2015-03-13 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Max Reitz --- block.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index 5f73697..6b6539a 100644 --- a/block.c +++ b/block.c @@ -60,11 +60,11 @@ * or enabled. A frozen bitmap can only abdicate() or re

Re: [Qemu-devel] [PATCH v2] target-tilegx: Execute _start and reach to __libc_start_main successfully

2015-03-13 Thread Richard Henderson
On 03/12/2015 09:06 AM, Chen Gang wrote: > +#define TILEGX_GEN_SAVE_PREP(rdst) \ > +dc->tmp_regcur->idx = rdst; \ > +dc->tmp_regcur->val = tcg_temp_new_i64(); > + > +#define TILEGX_GEN_SAVE_TMP_1(func, rdst, x1) \ > +TILEGX_GEN_SAVE_PREP(rdst) \ > +func(dc->tmp_regcur->val, x1); > +

[Qemu-devel] [2.4 PATCH v3 16/19] hbitmap: truncate tests

2015-03-13 Thread John Snow
The general approach is to set bits close to the boundaries of where we are truncating and ensure that everything appears to have gone OK. We test growing and shrinking by different amounts: - Less than the granularity - Less than the granularity, but across a boundary - Less than sizeof(unsigned

[Qemu-devel] [2.4 PATCH v3 07/19] hbitmap: add hbitmap_merge

2015-03-13 Thread John Snow
We add a bitmap merge operation to assist in error cases where we wish to combine two bitmaps together. This is algorithmically O(bits) provided HBITMAP_LEVELS remains constant. For a full bitmap on a 64bit machine: sum(bits/64^k, k, 0, HBITMAP_LEVELS) ~= 1.01587 * bits We may be able to improve

[Qemu-devel] [2.4 PATCH v3 03/19] qmp: Ensure consistent granularity type

2015-03-13 Thread John Snow
We treat this field with a variety of different types everywhere in the code. Now it's just uint32_t. Reviewed-by: Eric Blake Reviewed-by: Max Reitz Reviewed-by: Stefan Hajnoczi Signed-off-by: John Snow --- block.c | 11 ++- block/mirror.c| 4 ++-- inclu

Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

2015-03-13 Thread John Snow
On 03/13/2015 01:56 PM, Peter Maydell wrote: On 13 March 2015 at 17:50, Patchew Tool wrote: This series passed Patchew automatic testing, but there are some warnings. Find the log fragments below, or open the following URL to see the full log: http://qemu.patchew.org/testing/log/<142626858

Re: [Qemu-devel] [RFC PATCH v10 02/24] replay: global variables and function stubs

2015-03-13 Thread Eric Blake
On 02/27/2015 06:09 AM, Pavel Dovgalyuk wrote: > This patch adds global variables, defines, functions declarations, s/functions/function/ > and function stubs for deterministic VM replay used by external modules. > > Reviewed-by: Paolo Bonzini > Reviewed-by: Eric Blake > > Signed-off-by: Pave

Re: [Qemu-devel] [PATCH v2] utils: Add pow2ceil()

2015-03-13 Thread Richard Henderson
On 03/12/2015 09:45 AM, Eric Blake wrote: > On 03/12/2015 09:29 AM, Richard Henderson wrote: >> On 02/25/2015 02:45 AM, Markus Armbruster wrote: >>> return 0x8000u >> (clz64(value - 1) - 1); >> >> I realize this was weeks ago, but it would certainly be preferable to shift a >> small con

[Qemu-devel] [PATCH 2/2] target-i386: Haswell-noTSX and Broadwell-noTSX

2015-03-13 Thread Eduardo Habkost
With the Intel microcode update that removed HLE and RTM, there will be different kinds of Haswell and Broadwell CPUs out there: some that still have the HLE and RTM features, and some that don't have the HLE and RTM features. On both cases people may be willing to use the pc-*-2.3 machine-types.

[Qemu-devel] [PATCH 0/2] target-i386: Haswell-noTSX and Broadwell-noTSX CPU models

2015-03-13 Thread Eduardo Habkost
With the Intel microcode update that removed HLE and RTM, there will be different kinds of Haswell and Broadwell CPUs out there: some that still have the HLE and RTM features, and some that don't have the HLE and RTM features. On both cases people may be willing to use the pc-*-2.3 machine-types.

Re: [Qemu-devel] [PATCH] block: Fix block-set-write-threshold not to use funky error class

2015-03-13 Thread Eric Blake
On 03/13/2015 11:51 AM, Markus Armbruster wrote: > Error classes are a leftover from the days of "rich" error objects. > New code should always use ERROR_CLASS_GENERIC_ERROR. More precisely, new code should use ERROR_CLASS_GENERIC_ERROR unless there is a good reason where a caller knowing a differ

[Qemu-devel] [PATCH 1/2] Revert "target-i386: Disable HLE and RTM on Haswell & Broadwell"

2015-03-13 Thread Eduardo Habkost
This reverts commit 13704e4c455770d500d6b87b117e32f0d01252c9. With the Intel microcode update that removed HLE and RTM, there will be different kinds of Haswell and Broadwell CPUs out there: some that still have the HLE and RTM features, and some that don't have the HLE and RTM features. On both c

Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

2015-03-13 Thread Eric Blake
On 03/13/2015 11:48 AM, Markus Armbruster wrote: > Markus Armbruster writes: > >> Error classes are a leftover from the days of "rich" error objects. >> New code should always use ERROR_CLASS_GENERIC_ERROR. Commit 1d0d59f >> added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it. "always" is

[Qemu-devel] [PATCH v2 2/2] qtest/ahci: test different disk sectors

2015-03-13 Thread John Snow
Test sector offset 0, 1, and the last sector(s) in LBA28 and LBA48 modes. Signed-off-by: John Snow --- tests/ahci-test.c | 68 +++-- tests/libqos/ahci.c | 10 tests/libqos/ahci.h | 4 ++-- 3 files changed, 63 insertions(+), 19 deletions

[Qemu-devel] [PATCH v2 0/2] ahci: test varying sector offsets

2015-03-13 Thread John Snow
This is a re-send of patches 7 & 8 from an earlier series, "[PATCH v2 0/8] ahci: add more IO tests" which ultimately got bounced back because I used some glib functions that were too new. v2: - Patchew caught a pathing problem with the qemu-img binary; the relative path produced by the Makefile

Re: [Qemu-devel] [PATCH 0/2] target-i386: Haswell-noTSX and Broadwell-noTSX CPU models

2015-03-13 Thread Andreas Färber
Am 13.03.2015 um 20:09 schrieb Eduardo Habkost: > With the Intel microcode update that removed HLE and RTM, there will be > different kinds of Haswell and Broadwell CPUs out there: some that still > have the HLE and RTM features, and some that don't have the HLE and RTM > features. On both cases pe

[Qemu-devel] [PATCH v2 1/2] qtest/ahci: add qcow2 support to ahci-test

2015-03-13 Thread John Snow
This will enable the testing of high offsets without wasting a lot of disk space, and does not impact the previous tests. mkimg and mkqcow2 are added to libqos for other tests. Signed-off-by: John Snow --- tests/Makefile| 1 + tests/ahci-test.c | 16 ++-- tests/libqos/l

[Qemu-devel] [PATCH] tcg/optimize: Handle or r, a, a with constant a

2015-03-13 Thread Richard Henderson
As seen with ubuntu-5.10-live-powerpc.iso. Reported-by: Mark Cave-Ayland Signed-off-by: Richard Henderson --- tcg/optimize.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 067917c..37c1110 100644 --- a/tcg/optimize.c +++ b/tcg/optim

Re: [Qemu-devel] qemu-system-ppc TCG assert with git master

2015-03-13 Thread Richard Henderson
On 03/12/2015 04:38 PM, Mark Cave-Ayland wrote: > Ah great, you're able to reproduce the same issue locally. Hopefully > this will give you both enough information to figure out what is > happening in the optimiser... Yep, just sent a simple fix. r~

[Qemu-devel] [RFC PATCH v1] Include errno values in printfs for some xc_ calls.

2015-03-13 Thread Konrad Rzeszutek Wilk
Hey, I've just posted on xen-devel patches that make these two set of xc_* function conform to the style of returning -1 for error and stashing the Exx in errno. See: http://lists.xen.org/archives/html/xen-devel/2015-03/msg01766.html and http://lists.xen.org/archives/html/xen-devel/2015-03/msg017

[Qemu-devel] [PATCH RFC v1 2/2] xen-hvm: When using xc_domain_add_to_physmap also include errno when reporting

2015-03-13 Thread Konrad Rzeszutek Wilk
.errors - as it will most likely have the proper error value. Signed-off-by: Konrad Rzeszutek Wilk --- xen-hvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen-hvm.c b/xen-hvm.c index 7548794..3d6fed3 100644 --- a/xen-hvm.c +++ b/xen-hvm.c @@ -348,7 +348,7 @@ go_phys

Re: [Qemu-devel] [RFC 01/10] target-arm: protect cpu_exclusive_*.

2015-03-13 Thread Richard Henderson
On 03/03/2015 07:47 AM, Dr. David Alan Gilbert wrote: > That works for ARM where you have to terminate a ldrex with a strex or clrex, > but not all architectures have the equivalent of a clrex; most as I remember > just let you do an ldrex equivalent, decide you don't want to do the strex > equiva

[Qemu-devel] [PATCH RFC v1 1/2] xen/hw/passthrough: Use errno instead of ret for xc_physdev_map_* calls

2015-03-13 Thread Konrad Rzeszutek Wilk
As the libxc library follows (mostly) the return negative for failure and stashes the error value in errno. Signed-off-by: Konrad Rzeszutek Wilk --- hw/xen/xen_pt.c | 4 ++-- hw/xen/xen_pt_msi.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/xen/xen_pt.c b/hw/xen

Re: [Qemu-devel] [PATCH 0/2] target-i386: Haswell-noTSX and Broadwell-noTSX CPU models

2015-03-13 Thread Eduardo Habkost
On Fri, Mar 13, 2015 at 08:25:19PM +0100, Andreas Färber wrote: > Am 13.03.2015 um 20:09 schrieb Eduardo Habkost: > > With the Intel microcode update that removed HLE and RTM, there will be > > different kinds of Haswell and Broadwell CPUs out there: some that still > > have the HLE and RTM feature

[Qemu-devel] [PATCH v3 4/7] Add error checking to vcard_emul_options.

2015-03-13 Thread Jeremy White
Also add an alias of 'nssemul' for the default card of hw=yes hw_type=cac, and an alias of 'passthru' for the new card type of hw=yes hw_type=passthru. This allows the spice-gtk client to take a more human friendly set of arguments and relay them through to this code. Signed-off-by: Jeremy White

[Qemu-devel] [PATCH v3 3/7] Add a configure check for libpcsclite, and an option to enable or disable it.

2015-03-13 Thread Jeremy White
Signed-off-by: Jeremy White --- configure | 38 ++ 1 file changed, 38 insertions(+) diff --git a/configure b/configure index b858756..f22dbae 100755 --- a/configure +++ b/configure @@ -307,6 +307,7 @@ trace_file="trace" spice="" rbd="" smartcard_nss="" +

[Qemu-devel] [PATCH v3 0/7] Add support for passthru cards to libcacard

2015-03-13 Thread Jeremy White
This is a resend of my outstanding patches, gathered together as one series. I'm hoping to agitate for this whole set to be considered. Changes since v2: * Include outstanding patches not strictly related to passthru mode * Include a fix for read binary transactions * Mitigate some performa

[Qemu-devel] [PATCH v3 1/7] Bug fix: delete the reader entry after queueing an event, not before.

2015-03-13 Thread Jeremy White
As far as I can tell, the vreader_remove_reader function is not presently in use anywhere; I have an upcoming patch set that uses it. Signed-off-by: Jeremy White --- libcacard/vreader.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libcacard/vreader.c b/libcacard/vreader

[Qemu-devel] [PATCH v3 6/7] Enable support for passthru (e.g. direct to pcsc) smart cards in the emul_options entry point in libcacard.

2015-03-13 Thread Jeremy White
Signed-off-by: Jeremy White --- libcacard/vcard.c |2 +- libcacard/vcard.h |2 +- libcacard/vcard_emul_nss.c | 29 - libcacard/vcard_emul_type.c |3 ++- 4 files changed, 32 insertions(+), 4 deletions(-) diff --git a/libcacard/vcard.

[Qemu-devel] [PATCH v3 5/7] Add a VCARD_DIRECT implemention to the libcacard smartcard support.

2015-03-13 Thread Jeremy White
This uses libpcsclite to provide direct communication with a smartcard. Signed-off-by: Jeremy White --- Makefile.objs|5 + libcacard/capcsc.c | 498 ++ libcacard/capcsc.h | 18 ++ libcacard/card_7816.c|2 +- libca

[Qemu-devel] [PATCH v3 7/7] Remove the (broken) passthru option.

2015-03-13 Thread Jeremy White
That option can be achieved using -e "use_hw=yes hw_type=passthru" Signed-off-by: Jeremy White --- libcacard/vscclient.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index fa6041d..8573f50 100644 --- a/libca

Re: [Qemu-devel] [RFC PATCH v1] Include errno values in printfs for some xc_ calls.

2015-03-13 Thread Patchew Tool
This series passed Patchew automatic testing, but there are some warnings. Find the log fragments below, or open the following URL to see the full log: http://qemu.patchew.org/testing/log/<1426275418-8411-1-git-send-email-konrad.w...@oracle.com> --8<- docker run --net=none -v

Re: [Qemu-devel] [PATCH v2 0/6] ahci: rerror/werror=stop resume tests

2015-03-13 Thread John Snow
Ping: The series this is based on has been bumped to v2, but it does not change the context for this patchset. Requires: <1426274523-22661-1-git-send-email-js...@redhat.com> On 03/10/2015 04:14 PM, John Snow wrote: This series is based on: "[Qemu-devel] [PATCH 0/2] ahci: test varying sector of

[Qemu-devel] [PATCH v3 2/7] Retrieve the correct TD byte when checking an ATR.

2015-03-13 Thread Jeremy White
A physical smartcard with an ATR of 3B 95 95 40 FF AE 01 0E 00 00 was parsed incorrectly. The '40' should have been the second TD; instead the FF is used, incorrectly. Signed-off-by: Jeremy White --- hw/usb/ccid-card-passthru.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [Qemu-devel] [RFC 01/10] target-arm: protect cpu_exclusive_*.

2015-03-13 Thread Dr. David Alan Gilbert
* Richard Henderson (r...@twiddle.net) wrote: > On 03/03/2015 07:47 AM, Dr. David Alan Gilbert wrote: > > That works for ARM where you have to terminate a ldrex with a strex or > > clrex, > > but not all architectures have the equivalent of a clrex; most as I remember > > just let you do an ldrex

Re: [Qemu-devel] [PATCH v3 0/7] Add support for passthru cards to libcacard

2015-03-13 Thread Patchew Tool
This series passed Patchew automatic testing, but there are some warnings. Find the log fragments below, or open the following URL to see the full log: http://qemu.patchew.org/testing/log/<1426275924-1904-1-git-send-email-jwh...@codeweavers.com> --8<- total: 0 errors, 0 warning

[Qemu-devel] [PATCH] block: Deprecate QCOW/QCOW2 encryption

2015-03-13 Thread Markus Armbruster
We've steered users away from QCOW/QCOW2 encryption for a while, because it's a flawed design (commit 136cd19 Describe flaws in qcow/qcow2 encryption in the docs). In addition to flawed crypto, we have comically bad usability, and plain old bugs. Let me show you. = Example images = I'm going to

Re: [Qemu-devel] [PATCH] block: Fix block-set-write-threshold not to use funky error class

2015-03-13 Thread Markus Armbruster
Eric Blake writes: > On 03/13/2015 11:51 AM, Markus Armbruster wrote: >> Error classes are a leftover from the days of "rich" error objects. >> New code should always use ERROR_CLASS_GENERIC_ERROR. > > More precisely, new code should use ERROR_CLASS_GENERIC_ERROR unless > there is a good reason w

Re: [Qemu-devel] [PATCH] block: Deprecate QCOW/QCOW2 encryption

2015-03-13 Thread Markus Armbruster
I fat-fingered Dan's e-mail address. I apologize for the inconvenience.

[Qemu-devel] [PULL 6/6] tcg: Complete handling of ALWAYS and NEVER

2015-03-13 Thread Richard Henderson
Missing from movcond, and brcondi_i32 (but not brcondi_i64). Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index 6674bb4..f7a2767 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op

[Qemu-devel] [PULL 0/6] Use tcg_malloc more; tcg_cond_always fix

2015-03-13 Thread Richard Henderson
4: user-exec.c: fix build on NetBSD/sparc64 and NetBSD/arm (2015-03-13 15:57:00 +) are available in the git repository at: git://github.com/rth7680/qemu.git tags/tcg-pull-20150313 for you to fetch changes up to 37ed3bf1ee07bb1a26adca0df8718f601f231c0b: tcg: Complete handling of ALWAYS

[Qemu-devel] [PULL 1/6] tcg: Use tcg_malloc to allocate TCGLabelQemuLdst

2015-03-13 Thread Richard Henderson
Pre-allocating 640 of them per TB is a waste. Reviewed-by: Bastian Koppelmann Signed-off-by: Richard Henderson --- tcg/tcg-be-ldst.h | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/tcg/tcg-be-ldst.h b/tcg/tcg-be-ldst.h index 429cba2..4a45102 1006

[Qemu-devel] [PULL 4/6] tcg: Change generator-side labels to a pointer

2015-03-13 Thread Richard Henderson
This is less about improved type checking than enabling a subsequent change to the representation of labels. Acked-by: Claudio Fontana Tested-by: Claudio Fontana Cc: Andrzej Zaborowski Cc: Peter Maydell Cc: Aurelien Jarno Cc: Blue Swirl Cc: Stefan Weil Reviewed-by: Bastian Koppelmann Signe

[Qemu-devel] [PULL 3/6] tcg: Change translator-side labels to a pointer

2015-03-13 Thread Richard Henderson
This is improved type checking for the translators -- it's no longer possible to accidentally swap arguments to the branch functions. Note that the code generating backends still manipulate labels as int. With notable exceptions, the scope of the change is just a few lines for each target, so it'

[Qemu-devel] [PULL 2/6] tcg-ia64: Use tcg_malloc to allocate TCGLabelQemuLdst

2015-03-13 Thread Richard Henderson
Reviewed-by: Bastian Koppelmann Signed-off-by: Richard Henderson --- tcg/ia64/tcg-target.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c index 6bc9924..1c01fd9 100644 --- a/tcg/ia64/tcg-target.c +++ b/tcg/ia

[Qemu-devel] [PULL 5/6] tcg: Use tcg_malloc to allocate TCGLabel

2015-03-13 Thread Richard Henderson
Pre-allocating 512 of them per TB is a waste. Reviewed-by: Bastian Koppelmann Signed-off-by: Richard Henderson --- tcg/tcg.c | 31 ++- tcg/tcg.h | 16 +--- 2 files changed, 23 insertions(+), 24 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 97aa51

Re: [Qemu-devel] [PATCH] block: Deprecate QCOW/QCOW2 encryption

2015-03-13 Thread Eric Blake
On 03/13/2015 02:09 PM, Markus Armbruster wrote: > We've steered users away from QCOW/QCOW2 encryption for a while, > because it's a flawed design (commit 136cd19 Describe flaws in > qcow/qcow2 encryption in the docs). > > In addition to flawed crypto, we have comically bad usability, and > plain

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Give laptop users ability to scroll in monitor

2015-03-13 Thread Programmingkid
On Mar 13, 2015, at 1:31 PM, Paolo Bonzini wrote: > > > On 13/03/2015 15:48, Programmingkid wrote: >> >> On Mar 13, 2015, at 5:51 AM, Peter Maydell wrote: >> >>> On 13 March 2015 at 04:35, Programmingkid wrote: Laptop users usually have keyboards that are missing the page up and page >

Re: [Qemu-devel] [PATCH 0/6] TriCore: add RRR1, RRRR, RRRW, SYS instructions

2015-03-13 Thread Richard Henderson
On 02/25/2015 08:14 AM, Bastian Koppelmann wrote: > Bastian Koppelmann (6): > target-tricore: Add instructions of RRR1 opcode format, which have > 0xa3 as first opcode > target-tricore: Add instructions of RRR1 opcode format, which have > 0x63 as first opcode > target-tricore: Add ins

Re: [Qemu-devel] [PULL 0/6] Use tcg_malloc more; tcg_cond_always fix

2015-03-13 Thread Patchew Tool
This series passed Patchew automatic testing, but there are some warnings. Find the log fragments below, or open the following URL to see the full log: http://qemu.patchew.org/testing/log/<1426278193-15317-1-git-send-email-...@twiddle.net> --8<- total: 0 errors, 0 warnings, 159

[Qemu-devel] Fedora Virt preview and qemu 2.2.1 update

2015-03-13 Thread Gerhard Wiesinger
Hello, Any updates for the http://fedorapeople.org/groups/virt/virt-preview/fedora-virt-preview.repo repo to qemu 2.2.1 planned? Thank you. Ciao, Gerhard

[Qemu-devel] [PATCH] kvm: fix ioeventfd endianness on bi-endian architectures

2015-03-13 Thread Greg Kurz
KVM expects host endian values. Hosts that don't use the default endianness need to negate the swap performed in adjust_endianness(). Suggested-by: Paolo Bonzini Signed-off-by: Greg Kurz --- kvm-all.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] kvm: fix ioeventfd endianness on bi-endian architectures

2015-03-13 Thread Patchew Tool
This series passed Patchew automatic testing, but there are some warnings. Find the log fragments below, or open the following URL to see the full log: http://qemu.patchew.org/testing/log/<20150313212337.31142.3991.stgit@bahia.local> --8<- === Starting docker === Copying test

Re: [Qemu-devel] [PATCH 1/3] VFIO: Clear stale MSIx table during EEH reset

2015-03-13 Thread Alex Williamson
On Wed, 2015-03-11 at 17:11 +1100, Gavin Shan wrote: > The PCI device MSIx table is cleaned out in hardware after EEH PE > reset. However, we still hold the stale MSIx entries in QEMU, which > should be cleared accordingly. Otherwise, we will run into another > (recursive) EEH error and the PCI dev

[Qemu-devel] [PATCH v2 1/2] AHCI: Do not (re)map FB/CLB buffers while not running

2015-03-13 Thread John Snow
The FIS Receive Buffer and Command List Buffer pointers should not be edited while the FIS receive engine or Command Receive engines are running. Currently, we attempt to re-map the buffers every time they are adjusted, but while the AHCI engines are off, these registers may contain stale values,

[Qemu-devel] [PATCH v2 0/2] AHCI: avoid mapping stale guest memory

2015-03-13 Thread John Snow
Currently, the AHCI device tries to re-map guest memory every time the low or high address registers are written to, whether or not the AHCI device is currently active. If the other register has stale information in it, this may lead to runtime failures. Reconfigure the AHCI device to ignore write

[Qemu-devel] [PATCH v2 2/2] AHCI: Protect cmd register

2015-03-13 Thread John Snow
Many bits in the CMD register are supposed to be strictly read-only. We should not be deleting them on every write. As a side-effect: pay explicit attention to when a guest marks off the FIS Receive or Start bits, and disable the status bits ourselves, instead of letting them implicitly fall off.

Re: [Qemu-devel] [PATCH 2/3] VFIO: Clear INTx pending state on EEH reset

2015-03-13 Thread Alex Williamson
On Wed, 2015-03-11 at 17:11 +1100, Gavin Shan wrote: > When Linux guest recovers from EEH error on the following Emulex > adapter, the MSIx interrupts are disabled and the INTx emulation > is enabled. One INTx interrupt is injected to the guest by host > because of detected pending INTx interrupts

Re: [Qemu-devel] [PULL v3 3/5] configure: opengl overhaul

2015-03-13 Thread Juan Quintela
Gerd Hoffmann wrote: > Rename config option from "glx" to "opengl", glx will not be the only > option for opengl in near future. Also switch over to pkg-config for > opengl support detection. I had before this patch enabled --enable-glx > +if test "$opengl" != "no" ; then > + opengl_pkgs="gl

Re: [Qemu-devel] [PATCH v5 2/7] aer: impove pcie_aer_init to support vfio device

2015-03-13 Thread Alex Williamson
On Thu, 2015-03-12 at 18:23 +0800, Chen Fan wrote: > pcie_aer_init was used to emulate an aer capability for pcie device, > but for vfio device, the aer config space size is mutable and is not > always equal to PCI_ERR_SIZEOF(0x48). it depends on where the TLP Prefix > register required, so here we

Re: [Qemu-devel] [PATCH v5 3/7] vfio: add aer support for vfio device

2015-03-13 Thread Alex Williamson
On Thu, 2015-03-12 at 18:23 +0800, Chen Fan wrote: > Calling pcie_aer_init to initilize aer related registers for > vfio device, then reload physical related registers to expose > device capability. > > Signed-off-by: Chen Fan > --- > hw/vfio/pci.c | 45 ++

Re: [Qemu-devel] [PATCH v5 4/7] pcie_aer: expose pcie_aer_msg() interface

2015-03-13 Thread Alex Williamson
On Thu, 2015-03-12 at 18:23 +0800, Chen Fan wrote: > For vfio device, we need to propagate the aer error to > Guest OS. we use the pcie_aer_msg() to send aer error > to guest. This also would need to go in through the QEMU PCI tree, or at least get an ack from Michael. Thanks, Alex > Signed-of

Re: [Qemu-devel] [PATCH v5 5/7] vfio-pci: pass the aer error to guest

2015-03-13 Thread Alex Williamson
On Thu, 2015-03-12 at 18:23 +0800, Chen Fan wrote: > when the vfio device encounters an uncorrectable error in host, > the vfio_pci driver will signal the eventfd registered by this > vfio device, the results in the qemu eventfd handler getting > invoked. > > this patch is to pass the error to gue

<    1   2   3   >