Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

[Markus Armbruster]

Markus Armbruster <arm...@redhat.com> writes:

> Error classes are a leftover from the days of "rich" error objects.
> New code should always use ERROR_CLASS_GENERIC_ERROR.  Commit 1d0d59f
> added a use of ERROR_CLASS_DEVICE_NOT_FOUND.  Replace it.

Signed-off-by: Markus Armbruster <arm...@redhat.com>

>  ui/vnc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 6f9b718..a950016 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -3594,7 +3594,7 @@ void vnc_display_open(const char *id, Error **errp)
>  
>          dev = qdev_find_recursive(sysbus_get_default(), device_id);
>          if (dev == NULL) {
> -            error_set(errp, QERR_DEVICE_NOT_FOUND, device_id);
> +            error_setg(errp, "Device '%s' not found", device_id);
>              goto fail;
>          }