Re: [Qemu-devel] [PATCH v3 3/4] migration: Convert 'status' of MigrationInfo to use an enum type

2015-03-06 Thread zhanghailiang
On 2015/3/6 2:34, Markus Armbruster wrote: zhanghailiang writes: The original 'status' is an open-coded 'str' type, convert it to use an enum type. This conversion is backwards compatible, better documented and more convenient for future extensibility. We also rename 'MIGRATION_STATUS_ERROR'

Re: [Qemu-devel] [PATCH v4 05/10] qom/cpu: move register_vmstate to common CPUClass.realizefn

2015-03-06 Thread Igor Mammedov
On Fri, 13 Feb 2015 18:25:28 +0800 Zhu Guihua wrote: > From: Gu Zheng > > Move cpu vmstate register from cpu_exec_init into cpu_common_realizefn, > and use cc->get_arch_id as the instance id that suggested by Igor to > fix the migration issue. > > Signed-off-by: Gu Zheng > Signed-off-by: Zhu

Re: [Qemu-devel] [PATCH] vl: Adjust the place of processing '-mon'

2015-03-06 Thread zhanghailiang
On 2015/3/5 1:02, Markus Armbruster wrote: zhanghailiang writes: From: Xiangyou Xie If VM is configured with large size of hugepage, when startup, it will consume lots of time to zero the hugepage memory in the function 'os_mem_prealloc'. Libvirtd will wait 30 seconds for qemu to establish t

[Qemu-devel] [struct TypeInfo] static class members and "class_data" member

2015-03-06 Thread catalin.vas...@freescale.com
Is there a specific practice of how static class members are stored? I see there is a member named "class data" in "struct TypeInfo". Can I use that for static class members? By static member I'm referring to the concept from OOP.

[Qemu-devel] [PATCH 0/2] libxl: try to support IGD passthrough for qemu upstream

2015-03-06 Thread Tiejun Chen
When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,igd-passthru=on". This need to bring a change on tool side. After a discussion with Campbell, we'd like to construct a table to record all IGD dev

[Qemu-devel] [PATCH 1/2] libxl: introduce libxl__is_igd_vga_passthru

2015-03-06 Thread Tiejun Chen
While working with qemu, IGD is a specific device in the case of pass through so we need to identify that to handle more later. Here we define a table to record all IGD types currently we can support. Also we need to introduce two helper functions to get vendor and device ids to lookup that table.

[Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-06 Thread Tiejun Chen
Although we already have 'gfx_passthru' in b_info, this doesn' suffice after we want to handle IGD specifically. Now we define a new field of type, gfx_passthru_kind, to indicate we're trying to pass IGD. Actually this means we can benefit this to support other specific devices just by extending gf

[Qemu-devel] [PATCH 2/2] qmp: Drop unused .user_print from command definitions

2015-03-06 Thread Markus Armbruster
.user_print isn't used with QMP commands, only with HMP commands. Copied over when QMP got its own command table in commit 82a56f0. Most of them have been dropped since, but a few stragglers remain. Drop them. Signed-off-by: Markus Armbruster --- qmp-commands.hx | 4 1 file changed, 4 delet

[Qemu-devel] [PATCH 1/2] hmp: Fix definition of command quit

2015-03-06 Thread Markus Armbruster
The command handler is a union of two function types. If cmd->user_print is set, handle_user_command() calls cmd->mhandler.cmd_new(), else cmd->mhandler.cmd(). Command definitions must therefore either set both user_print() and mhandler.cmd_new(), or only mhandler.cmd(). quit's sets user_print a

[Qemu-devel] [PATCH 0/2] monitor: Fix and clean up around .user_print

2015-03-06 Thread Markus Armbruster
A more thorough cleanup of the area is in the works, but I want to get this out quickly, so it makes 2.3. I think it can go via -trivial, if Luiz doesn't mind. Markus Armbruster (2): hmp: Fix definition of command quit qmp: Drop unused .user_print from command definitions hmp-commands.hx |

Re: [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-06 Thread Chen, Tiejun
On 2015/3/6 17:08, Tiejun Chen wrote: Although we already have 'gfx_passthru' in b_info, this doesn' suffice after we want to handle IGD specifically. Now we define a new field of type, gfx_passthru_kind, to indicate we're trying to pass IGD. Actually this means we can benefit this to support oth

[Qemu-devel] [PATCH 2/2] rcu: handle forks safely

2015-03-06 Thread Paolo Bonzini
After forking, only the calling thread is duplicated in the child process. The call_rcu thread has to be recreated in the child. Exploit the fact that only one thread exists (same as when constructors run), and just redo the entire initialization to ensure the threads are in the proper state. The

[Qemu-devel] [PATCH 0/2] rcu: support fork

2015-03-06 Thread Paolo Bonzini
Supporting fork in multithreaded programs is somewhat complicated, however in QEMU we fork in two places (daemonize and smbd) and none of them are complicated: - daemonize happens before threads and mutexes proliferate unpredictably; only the RCU state has to be reset and the call_rcu thread recre

[Qemu-devel] [PATCH 1/2] qemu-thread: do not use PTHREAD_MUTEX_ERRORCHECK

2015-03-06 Thread Paolo Bonzini
PTHREAD_MUTEX_ERRORCHECK is completely broken with respect to fork. The way to safely do fork is to bring all threads to a quiescent state by acquiring locks (either in callers---as we do for the iothread mutex---or using pthread_atfork's prepare callbacks) and then release them in the child. The

[Qemu-devel] [PATCH 2/5] 9pfs-proxy: simplify v9fs_request(), P2

2015-03-06 Thread Michael Tokarev
Move common code in all cases of the switch statement to be outside of the statement. Signed-off-by: Michael Tokarev --- hw/9pfs/virtio-9p-proxy.c | 85 +++ 1 file changed, 4 insertions(+), 81 deletions(-) diff --git a/hw/9pfs/virtio-9p-proxy.c b/hw/9

[Qemu-devel] [PATCH 3/5] 9pfs-proxy: simplify error handling

2015-03-06 Thread Michael Tokarev
All filesystem methods that call common v9fs_request() function also convert return value to errno. Move this conversion to the common function and remove redundand error handling in methods. I didn't remove local `retval' variable in simple functions to keep the code consistent. Also, proxy_tru

[Qemu-devel] [PATCH 4/5] 9pfs-proxy: rename a few local variables for consistency

2015-03-06 Thread Michael Tokarev
All functions which deal with v9fs_request() use `retval' variable to hold result of the request (except some which use this value for other purposes too), but 3 use different name (ret or err). Rename these 3 for consistency. There's no actual code changes. Signed-off-by: Michael Tokarev --- h

[Qemu-devel] [PATCH 5/5] 9pfs-proxy: tiny cleanups in proxy_pwritev and proxy_preadv

2015-03-06 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- hw/9pfs/virtio-9p-proxy.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/9pfs/virtio-9p-proxy.c b/hw/9pfs/virtio-9p-proxy.c index c7b2f16..8e7ce3f 100644 --- a/hw/9pfs/virtio-9p-proxy.c +++ b/hw/9pfs/virtio-9p-proxy.c @@ -606,7 +6

[Qemu-devel] [PATCH 0/5] 9pfs-proxy simplification/cleanup

2015-03-06 Thread Michael Tokarev
This small patch series cleans up 9pfs-proxy.c code a little bit, mostly by moving the same code repeated in all places to a single place, and tiny cleanups to make the code more consistent. Michael Tokarev (5): 9pfs-proxy: simplify v9fs_request(), P1 9pfs-proxy: simplify v9fs_request(), P2

[Qemu-devel] [PATCH 1/5] 9pfs-proxy: simplify v9fs_request(), P1

2015-03-06 Thread Michael Tokarev
This simplifies code in v9fs_request() a bit by replacing several ifs with a common variable check and rearranging error/cleanup code a bit. Signet-off-by: Michael Tokarev --- hw/9pfs/virtio-9p-proxy.c | 48 --- 1 file changed, 20 insertions(+), 28 del

Re: [Qemu-devel] [PATCH v4 01/10] cpu/apic: drop icc bus/bridge/

2015-03-06 Thread Igor Mammedov
On Fri, 13 Feb 2015 18:25:24 +0800 Zhu Guihua wrote: > From: Chen Fan > > ICC bus was invented only to provide hotplug capability to > CPU and APIC because at the time being hotplug was available only for > BUS attached devices. > > Now this patch is to drop ICC bus impl, and switch to bus-les

Re: [Qemu-devel] [PATCH v4 05/10] qom/cpu: move register_vmstate to common CPUClass.realizefn

2015-03-06 Thread Chen Fan
On 03/06/2015 04:53 PM, Igor Mammedov wrote: On Fri, 13 Feb 2015 18:25:28 +0800 Zhu Guihua wrote: From: Gu Zheng Move cpu vmstate register from cpu_exec_init into cpu_common_realizefn, and use cc->get_arch_id as the instance id that suggested by Igor to fix the migration issue. Signed-off-

Re: [Qemu-devel] [Bug] qemu_coroutine_enter abort and report error "Co-routine re-entered recursively"

2015-03-06 Thread Paolo Bonzini
On 06/03/2015 08:03, Halsey Pian wrote: > I have two threads to write two seperate qcow2 files, but after a > while, the writing would be aborted in qemu_coroutine_enter, and report > error “"Co-routine re-entered recursively” . > > Qemu should be thread safe, right? It seems that there are so

Re: [Qemu-devel] [PATCH V3 10/14] virtio: introduce virtio_queue_get_index()

2015-03-06 Thread Jason Wang
On Thu, Mar 5, 2015 at 2:12 PM, Fam Zheng wrote: On Thu, 03/05 13:48, Jason Wang wrote: This patch introduces a helper that can get the queue index of a VirtQueue. This is useful when traversing the list of VirtQueues. Cc: Anthony Liguori Cc: Michael S. Tsirkin Signed-off-by: Jason

[Qemu-devel] [Bug 1429034] [NEW] qemu abort in qemu_coroutine_enter when multi-thread writing

2015-03-06 Thread halsey
Public bug reported: qemu release version: 2.2.0 platform: x86_64 qemu would be aborted when there are two threads to write two seperate qcow2 files. call stack: #0 0x75e18989 __GI_raise(sig=sig@entry=6) (../nptl/sysdeps/unix/sysv/linux/raise.c:56) #1 0x75e1a098 __GI_abort(

Re: [Qemu-devel] [PATCH v3 for-2.3 01/24] acpi: add aml_or() term

2015-03-06 Thread Igor Mammedov
On Thu, 5 Mar 2015 16:54:59 +0200 Marcel Apfelbaum wrote: > Add encoding for ACPI DefOr Opcode. > > Signed-off-by: Marcel Apfelbaum Reviewed-by: Igor Mammedov > --- > hw/acpi/aml-build.c | 10 ++ > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 11 insertions(+) > >

Re: [Qemu-devel] [PATCH] vl: Adjust the place of processing '-mon'

2015-03-06 Thread Peter Maydell
On 5 March 2015 at 02:02, Markus Armbruster wrote: > zhanghailiang writes: > >> From: Xiangyou Xie >> >> If VM is configured with large size of hugepage, when startup, >> it will consume lots of time to zero the hugepage memory in the function >> 'os_mem_prealloc'. >> Libvirtd will wait 30 secon

Re: [Qemu-devel] [PATCH v3 for-2.3 02/24] acpi: add aml_add() term

2015-03-06 Thread Igor Mammedov
On Thu, 5 Mar 2015 16:55:00 +0200 Marcel Apfelbaum wrote: > Add encoding for ACPI DefAdd Opcode. > > Signed-off-by: Marcel Apfelbaum Reviewed-by: Igor Mammedov > --- > hw/acpi/aml-build.c | 10 ++ > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 11 insertions(+) > >

Re: [Qemu-devel] [PATCH v3 for-2.3 03/24] acpi: add aml_lless() term

2015-03-06 Thread Igor Mammedov
On Thu, 5 Mar 2015 16:55:01 +0200 Marcel Apfelbaum wrote: > Add encoding for ACPI DefLLess Opcode. > > Signed-off-by: Marcel Apfelbaum Reviewed-by: Igor Mammedov > --- > hw/acpi/aml-build.c | 9 + > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 10 insertions(+) > >

Re: [Qemu-devel] [PATCH] vl: Adjust the place of processing '-mon'

2015-03-06 Thread zhanghailiang
On 2015/3/6 17:51, Peter Maydell wrote: On 5 March 2015 at 02:02, Markus Armbruster wrote: zhanghailiang writes: From: Xiangyou Xie If VM is configured with large size of hugepage, when startup, it will consume lots of time to zero the hugepage memory in the function 'os_mem_prealloc'. Lib

Re: [Qemu-devel] [PATCH RFC 1/1] s390x/pci: Extend pci representation by new zpci device

2015-03-06 Thread Frank Blaschka
On Wed, Mar 04, 2015 at 04:58:25PM +0100, Frank Blaschka wrote: > On Wed, Mar 04, 2015 at 04:25:07PM +0100, Alexander Graf wrote: > > > > > > On 04.03.15 16:07, Frank Blaschka wrote: > > > On Wed, Mar 04, 2015 at 03:49:15PM +0100, Alexander Graf wrote: > > >> > > >> > > >> On 04.03.15 14:44, Fran

Re: [Qemu-devel] [PATCH v3 for-2.3 04/24] acpi: add aml_index() term

2015-03-06 Thread Igor Mammedov
On Thu, 5 Mar 2015 16:55:02 +0200 Marcel Apfelbaum wrote: > Add encoding for ACPI DefIndex Opcode. > > Signed-off-by: Marcel Apfelbaum > --- > hw/acpi/aml-build.c | 10 ++ > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 11 insertions(+) > > diff --git a/hw/acpi/aml-b

Re: [Qemu-devel] [PATCH v3 for-2.3 05/24] acpi: add aml_shiftleft() term

2015-03-06 Thread Igor Mammedov
On Thu, 5 Mar 2015 16:55:03 +0200 Marcel Apfelbaum wrote: > Add encoding for ACPI DefShiftLeft Opcode. > > Signed-off-by: Marcel Apfelbaum Reviewed-by: Igor Mammedov > --- > hw/acpi/aml-build.c | 10 ++ > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 11 insertions(+

Re: [Qemu-devel] [PATCH v3 for-2.3 06/24] acpi: add aml_shiftright() term

2015-03-06 Thread Igor Mammedov
On Thu, 5 Mar 2015 16:55:04 +0200 Marcel Apfelbaum wrote: > Add encoding for ACPI DefShiftRight Opcode. > > Signed-off-by: Marcel Apfelbaum Reviewed-by: Igor Mammedov > --- > hw/acpi/aml-build.c | 10 ++ > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 11 insertions(

Re: [Qemu-devel] [PATCH 10/21] userfaultfd: add new syscall to provide memory externalization

2015-03-06 Thread Michael Kerrisk (man-pages)
Hi Andrea, On 5 March 2015 at 18:17, Andrea Arcangeli wrote: > Once an userfaultfd has been created and certain region of the process > virtual address space have been registered into it, the thread > responsible for doing the memory externalization can manage the page > faults in userland by tal

Re: [Qemu-devel] [PATCH RFC 1/1] s390x/pci: Extend pci representation by new zpci device

2015-03-06 Thread Alexander Graf
On 06.03.15 11:34, Frank Blaschka wrote: > On Wed, Mar 04, 2015 at 04:58:25PM +0100, Frank Blaschka wrote: >> On Wed, Mar 04, 2015 at 04:25:07PM +0100, Alexander Graf wrote: >>> >>> >>> On 04.03.15 16:07, Frank Blaschka wrote: On Wed, Mar 04, 2015 at 03:49:15PM +0100, Alexander Graf wrote: >

Re: [Qemu-devel] [PATCH v3 for-2.3 07/24] acpi: add aml_increment() term

2015-03-06 Thread Igor Mammedov
On Thu, 5 Mar 2015 16:55:05 +0200 Marcel Apfelbaum wrote: > Add encoding for ACPI DefIncrement Opcode. > > Signed-off-by: Marcel Apfelbaum Reviewed-by: Igor Mammedov > --- > hw/acpi/aml-build.c | 8 > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 9 insertions(+) >

Re: [Qemu-devel] [PATCH v3 for-2.3 08/24] acpi: add aml_while() term

2015-03-06 Thread Igor Mammedov
On Thu, 5 Mar 2015 16:55:06 +0200 Marcel Apfelbaum wrote: > Add encoding for ACPI DefWhile Opcode. > > Signed-off-by: Marcel Apfelbaum Reviewed-by: Igor Mammedov > --- > hw/acpi/aml-build.c | 8 > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 9 insertions(+) > > di

Re: [Qemu-devel] [Bug] qemu_coroutine_enter abort and report error "Co-routine re-entered recursively"

2015-03-06 Thread Halsey Pian
> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: 2015年3月6日 17:45 > To: Halsey Pian; qemu-devel@nongnu.org > Subject: Re: [Bug] qemu_coroutine_enter abort and report error "Co-routine > re-entered recursively" > > > > On 0

Re: [Qemu-devel] [PATCH 0/6] Clean up ISA dependencies so we make ISA optional to build

2015-03-06 Thread Alexander Graf
On 06.03.15 05:18, David Gibson wrote: > At present, ISA bus support is always included in the build for all > targets. However these days there are a number of targets that have > never had ISA, and even more where many of the individual machines > don't have ISA. > > Unfortunately there are s

Re: [Qemu-devel] [PATCH V3 05/14] virtio-s390: switch to bus specific queue limit

2015-03-06 Thread Cornelia Huck
On Thu, 5 Mar 2015 13:48:42 +0800 Jason Wang wrote: > Instead of depending on marco, switch to use a bus specific queue > limit. Left is AdapterRouters->gsi[], this could be done in the future > if we want to increase s390's queue limit really. Stale comment regarding AdapterRoutes? You changed

Re: [Qemu-devel] [PATCH 1/2] libxl: introduce libxl__is_igd_vga_passthru

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 05:08:22PM +0800, Tiejun Chen wrote: > While working with qemu, IGD is a specific device in the case of pass through > so we need to identify that to handle more later. Here we define a table to > record all IGD types currently we can support. Also we need to introduce two >

Re: [Qemu-devel] [PATCH 0/2] libxl: try to support IGD passthrough for qemu upstream

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 05:08:21PM +0800, Tiejun Chen wrote: > When we're working to support IGD GFX passthrough with qemu > upstream, instead of "-gfx_passthru" we'd like to make that > a machine option, "-machine xxx,igd-passthru=on". This need > to bring a change on tool side. > > After a discu

Re: [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 05:08:23PM +0800, Tiejun Chen wrote: > Although we already have 'gfx_passthru' in b_info, this doesn' suffice > after we want to handle IGD specifically. Now we define a new field of > type, gfx_passthru_kind, to indicate we're trying to pass IGD. Actually > this means we ca

Re: [Qemu-devel] [PATCH V3 09/14] virtio: introduce vector to virtqueues mapping

2015-03-06 Thread Cornelia Huck
On Thu, 5 Mar 2015 13:48:46 +0800 Jason Wang wrote: > Currently we will try to traverse all virtqueues to find a subset that > using a specific vector. This is sub optimal when we will support > hundreds or even thousands of virtqueues. So this patch introduces a > method which could be used by

Re: [Qemu-devel] [PATCH V3 06/14] virtio-serial-bus: switch to bus specific queue limit

2015-03-06 Thread Cornelia Huck
On Thu, 5 Mar 2015 13:48:43 +0800 Jason Wang wrote: > Cc: Amit Shah > Signed-off-by: Jason Wang > --- > hw/char/virtio-serial-bus.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c > index 37a6f44..f280e95 1

Re: [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 05:18:36PM +0800, Chen, Tiejun wrote: > On 2015/3/6 17:08, Tiejun Chen wrote: > >Although we already have 'gfx_passthru' in b_info, this doesn' suffice > >after we want to handle IGD specifically. Now we define a new field of > >type, gfx_passthru_kind, to indicate we're try

Re: [Qemu-devel] [PATCH V3 08/14] virtio-pci: switch to use bus specific queue limit

2015-03-06 Thread Cornelia Huck
On Thu, 5 Mar 2015 13:48:45 +0800 Jason Wang wrote: > Instead of depending on a macro, switch to use a bus specific queue > limit. > > Cc: Anthony Liguori > Cc: Michael S. Tsirkin > Signed-off-by: Jason Wang > --- > hw/virtio/virtio-pci.c | 12 +++- > include/hw/virtio/virtio.h

Re: [Qemu-devel] [PATCH] vl: Adjust the place of processing '-mon'

2015-03-06 Thread Peter Maydell
On 6 March 2015 at 21:05, Markus Armbruster wrote: > Peter Maydell writes: > >> On 5 March 2015 at 02:02, Markus Armbruster wrote: >>> This patch initializes monitors earlier, thus makes more errors look >>> ugly. Do we care? >> >> Yeah, this doesn't seem great. Surely the actual problem here >

Re: [Qemu-devel] [PATCH V3 04/14] virtio-ccw: introduce ccw specific queue limit

2015-03-06 Thread Cornelia Huck
On Thu, 5 Mar 2015 13:48:41 +0800 Jason Wang wrote: > Instead of depending on marco, using a bus specific limit. > > Cc: Alexander Graf > Cc: Cornelia Huck > Cc: Christian Borntraeger > Cc: Richard Henderson > Signed-off-by: Jason Wang > --- > hw/s390x/s390-virtio-ccw.c | 7 +-- >

Re: [Qemu-devel] [PATCH v2 0/2] block/raw-posix: fix launching with failed disks

2015-03-06 Thread Kevin Wolf
Am 05.03.2015 um 22:38 hat Stefan Hajnoczi geschrieben: > Guests configured for multipath I/O might be started up with failed disks > attached. QEMU should not refuse starting when a disk returns I/O errors (and > in the past this behavior was implemented correctly). > > This patch series fixes a

Re: [Qemu-devel] [PATCH] vl: Adjust the place of processing '-mon'

2015-03-06 Thread Markus Armbruster
Peter Maydell writes: > On 5 March 2015 at 02:02, Markus Armbruster wrote: >> zhanghailiang writes: >> >>> From: Xiangyou Xie >>> >>> If VM is configured with large size of hugepage, when startup, >>> it will consume lots of time to zero the hugepage memory in the function >>> 'os_mem_prealloc

Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups

2015-03-06 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > Sorry about all the problems. > Same as v4, but updated generated files for non-iasl systems. > Not re-sending the patches therefore. > > The following changes since commit 11d39a131020cc5c54ff9bc86d3259f7d32bf849: > > Merge remote-tracking branch 'remotes/borntra

Re: [Qemu-devel] [PATCH] savevm: create snapshot failed when id_str already exits

2015-03-06 Thread Yi Wang
Yeah, your method is better. But there is still a little problem. For example: vda has one snapshot with name "s1" and id_str "1", vdb has two snapshots: first name "s1" and id_str "2"; second name "s2" and id_str "3". Error will occur when we want to create snapshot s1, because snapshot s1 with id

Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups

2015-03-06 Thread Peter Maydell
On 6 March 2015 at 23:27, Markus Armbruster wrote: > It looks like we now generate a bunch of files that used to be > git-controlled. The "generate" part is fine. But generating into the > source tree is asking for trouble. > > What happens when I build separate build trees in parallel? > > Why

[Qemu-devel] [Bug 1428958] [NEW] random IO errors / data corruption in VMs (created and executed via virt-manager)

2015-03-06 Thread Dmitry Sutyagin
Public bug reported: I have recurring problems with VM installation and usage - data on VM disk gets corrupted at some point and it causes all sorts of problems - sometimes I cannot even install base system, other times some .so files are corrupt after isntallation, etc - totally random. I use

Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups

2015-03-06 Thread Markus Armbruster
Peter Maydell writes: > On 6 March 2015 at 23:27, Markus Armbruster wrote: >> It looks like we now generate a bunch of files that used to be >> git-controlled. The "generate" part is fine. But generating into the >> source tree is asking for trouble. >> >> What happens when I build separate bu

Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups

2015-03-06 Thread Igor Mammedov
On Fri, 06 Mar 2015 15:27:07 +0100 Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > Sorry about all the problems. > > Same as v4, but updated generated files for non-iasl systems. > > Not re-sending the patches therefore. > > > > The following changes since commit 11d39a131020cc5c5

[Qemu-devel] [PATCH] kvm-all: put kvm_mem_flags to more work

2015-03-06 Thread Andrew Jones
Currently kvm_mem_flags just translates bools to bits, let's make it also determine the bools first. This avoids its parameter list growing each time we add a flag. Signed-off-by: Andrew Jones --- This patch comes from an experimental series that added a kvm memslot flag. That series probably won

Re: [Qemu-devel] [PATCH v4 4/5] target-i386: Move APIC ID compatibility code to pc.c

2015-03-06 Thread Eduardo Habkost
On Thu, Mar 05, 2015 at 04:47:53PM +0100, Andreas Färber wrote: > Am 05.03.2015 um 14:37 schrieb Eduardo Habkost: > > On Thu, Mar 05, 2015 at 01:32:02AM +0100, Andreas Färber wrote: > >> Am 04.03.2015 um 03:13 schrieb Eduardo Habkost: > >>> The APIC ID compatibility code is required only for PC, an

Re: [Qemu-devel] [PATCH v3 3/4] migration: Convert 'status' of MigrationInfo to use an enum type

2015-03-06 Thread Eric Blake
On 03/04/2015 07:09 AM, zhanghailiang wrote: > The original 'status' is an open-coded 'str' type, convert it to use an > enum type. > This conversion is backwards compatible, better documented and > more convenient for future extensibility. > > We also rename 'MIGRATION_STATUS_ERROR' to 'MIGRATION

Re: [Qemu-devel] [PATCH v3 2/4] hmp: Rename 'MigrationStatus' to 'HMPMigrationStatus'

2015-03-06 Thread Eric Blake
On 03/04/2015 07:09 AM, zhanghailiang wrote: > We will use the typename 'MigrationStatus' for publicly exported typename, > So here we rename the internal-only 'MigrationStatus' to > 'HMPMigrationStatus'. > > Signed-off-by: zhanghailiang > --- > hmp.c | 8 > 1 file changed, 4 insertions

Re: [Qemu-devel] [PATCH] savevm: create snapshot failed when id_str already exits

2015-03-06 Thread Stefan Hajnoczi
On Fri, Mar 06, 2015 at 10:35:41PM +0800, Yi Wang wrote: > Yeah, your method is better. But there is still a little problem. > For example: vda has one snapshot with name "s1" and id_str "1", vdb > has two snapshots: first name "s1" and id_str "2"; second name "s2" > and id_str "3". Error will occu

Re: [Qemu-devel] [PATCH v3 4/4] migration: Expose 'cancelling' status to user

2015-03-06 Thread Eric Blake
On 03/04/2015 07:09 AM, zhanghailiang wrote: > 'cancelling' status is introduced by commit 51cf4c1a, which is mainly avoid s/is introduced/was introduced/ s/which is mainly avoid/mainly to avoid a/ > possible starting a new migration process while the previous one still exist. s/starting a new/s

Re: [Qemu-devel] [PATCH 1/3] aio-posix: move pollfds to thread-local storage

2015-03-06 Thread Stefan Hajnoczi
On Fri, Feb 20, 2015 at 05:26:50PM +0100, Paolo Bonzini wrote: > By using thread-local storage, aio_poll can stop using global data during > g_poll_ns. This will make it possible to drop callbacks from rfifolock. > > Signed-off-by: Paolo Bonzini > --- > aio-posix.c | 77 > +

Re: [Qemu-devel] [PATCH v3 1/4] migration: Rename abbreviated macro MIG_STATE_* to MIGRATION_STATUS_*

2015-03-06 Thread Eric Blake
On 03/04/2015 07:09 AM, zhanghailiang wrote: > Signed-off-by: zhanghailiang > --- > migration/migration.c | 93 > +++ > 1 file changed, 50 insertions(+), 43 deletions(-) > > diff --git a/migration/migration.c b/migration/migration.c > index b3adbc

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-06 Thread Bandan Das
Andrey Korolyov writes: > On Fri, Mar 6, 2015 at 1:14 AM, Andrey Korolyov wrote: >> Hello, >> >> recently I`ve got a couple of shiny new Intel 2620v2s for future >> replacement of the E5-2620v1, but I experienced relatively many events >> with emulation errors, all traces looks simular to the on

Re: [Qemu-devel] [PATCH 02/21] userfaultfd: linux/Documentation/vm/userfaultfd.txt

2015-03-06 Thread Eric Blake
On 03/05/2015 10:17 AM, Andrea Arcangeli wrote: > Add documentation. > > Signed-off-by: Andrea Arcangeli > --- > Documentation/vm/userfaultfd.txt | 97 > > 1 file changed, 97 insertions(+) > create mode 100644 Documentation/vm/userfaultfd.txt Just a gr

[Qemu-devel] mfocrf missing on e500v2

2015-03-06 Thread Alexander Graf
Hi Richard, I've finally managed to check out why my e500v2 automated tests fail to run. Apparently they break because autotest wants to execute target code and runs into an illegal instruction while doing that: Program received signal SIGILL, Illegal instruction. 0xb57c84cc in ?? () (gdb) x /i $

Re: [Qemu-devel] [PATCH RFC v3 14/27] COLO failover: Introduce a new command to trigger a failover

2015-03-06 Thread Eric Blake
On 02/25/2015 12:04 AM, zhanghailiang wrote: >>> +++ b/qmp-commands.hx >>> @@ -753,6 +753,25 @@ Example: >>> EQMP >>> >>> { >>> +.name = "colo_lost_heartbeat", >> >> ...but documented incorrectly (this should use '-' to match the command >> name in the .json file, not '_') >>

Re: [Qemu-devel] [PATCH 1/2] qemu-thread: do not use PTHREAD_MUTEX_ERRORCHECK

2015-03-06 Thread Eric Blake
On 03/06/2015 02:22 AM, Paolo Bonzini wrote: > PTHREAD_MUTEX_ERRORCHECK is completely broken with respect to fork. > The way to safely do fork is to bring all threads to a quiescent > state by acquiring locks (either in callers---as we do for the > iothread mutex---or using pthread_atfork's prepare

Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups

2015-03-06 Thread Markus Armbruster
Igor Mammedov writes: > On Fri, 06 Mar 2015 15:27:07 +0100 > Markus Armbruster wrote: > >> "Michael S. Tsirkin" writes: >> >> > Sorry about all the problems. >> > Same as v4, but updated generated files for non-iasl systems. >> > Not re-sending the patches therefore. >> > >> > The following ch

Re: [Qemu-devel] [Xen-devel] [PATCH 0/2] libxl: try to support IGD passthrough for qemu upstream

2015-03-06 Thread Konrad Rzeszutek Wilk
On Fri, Mar 06, 2015 at 05:08:21PM +0800, Tiejun Chen wrote: > When we're working to support IGD GFX passthrough with qemu > upstream, instead of "-gfx_passthru" we'd like to make that Could you also include in the cover letter an URL link to the latest discussion on this? Thank you. > a machine

Re: [Qemu-devel] [PATCH 0/2] monitor: Fix and clean up around .user_print

2015-03-06 Thread Eric Blake
On 03/06/2015 02:09 AM, Markus Armbruster wrote: > A more thorough cleanup of the area is in the works, but I want to get > this out quickly, so it makes 2.3. > > I think it can go via -trivial, if Luiz doesn't mind. > > Markus Armbruster (2): > hmp: Fix definition of command quit > qmp: Drop

Re: [Qemu-devel] [PATCH 0/1] Get the list of arguments from a QMP command

2015-03-06 Thread Eric Blake
On 02/24/2015 06:51 AM, Alberto Garcia wrote: > Hello, > > this is a follow-up to the comments from Eric Blake about my patches > to extend the block streaming API: > >https://lists.gnu.org/archive/html/qemu-devel/2015-02/msg04231.html > > Since QEMU doesn't have an easy way to tell the argu

Re: [Qemu-devel] [PATCH v2] block/null: Latency simulation by adding new option "latency_ns"

2015-03-06 Thread Eric Blake
On 03/04/2015 06:32 PM, Fam Zheng wrote: > Aio context switch should just work because the requests will be > drained, so the scheduled timer(s) on the old context will be freed. > > Signed-off-by: Fam Zheng > > --- > v2: Check for negative value; add sleep in null-co://. [Kevin] > --- > block/

[Qemu-devel] [PATCH] MAINTAINERS: Add jcody as blockjobs, block devices maintainer

2015-03-06 Thread Jeff Cody
The block layer maintainership is being split up into smaller, more manageable pieces. I propose that I take over / assist with the following areas: * blockjobs * archipelago * curl * gluster * nfs * rbd * sheepdog * ssh * vhdx As John Snow noted in a differen

Re: [Qemu-devel] [PATCH 2/3] AioContext: acquire/release AioContext during aio_poll

2015-03-06 Thread Stefan Hajnoczi
On Fri, Feb 20, 2015 at 05:26:51PM +0100, Paolo Bonzini wrote: > This is the first step in pushing down acquire/release, and will let > rfifolock drop the contention callback feature. > > Signed-off-by: Paolo Bonzini > --- > aio-posix.c | 9 + > aio-win32.c | 8

Re: [Qemu-devel] [PATCH 3/3] iothread: release iothread around aio_poll

2015-03-06 Thread Stefan Hajnoczi
On Fri, Feb 20, 2015 at 05:26:52PM +0100, Paolo Bonzini wrote: > This is the first step towards having fine-grained critical sections in > dataplane threads, which resolves lock ordering problems between > address_space_* functions (which need the BQL when doing MMIO, even > after we complete RCU-b

Re: [Qemu-devel] RFC: Universal encryption on QEMU I/O channels

2015-03-06 Thread Daniel P. Berrange
On Wed, Feb 04, 2015 at 11:32:29AM +, Daniel P. Berrange wrote: > In QEMU there are a number of features which involve communication with an > external system over an I/O channel of some form. The features include > migration, NBD, VNC and character devices. The I/O channel in question might >

Re: [Qemu-devel] Reopen file descriptors on 'cont' command

2015-03-06 Thread Stefan Hajnoczi
On Wed, Feb 25, 2015 at 09:32:18PM -0300, Christopher Pereira wrote: > Does qemu reopen files on a 'cont' command? > > When working with images on a gluster volume, file descriptors may get into > a bad state because of network timeouts, remounting a share, etc...and > reinitializing file descript

Re: [Qemu-devel] mfocrf missing on e500v2

2015-03-06 Thread Maciej W. Rozycki
On Fri, 6 Mar 2015, Alexander Graf wrote: > I've finally managed to check out why my e500v2 automated tests fail to > run. Apparently they break because autotest wants to execute target code > and runs into an illegal instruction while doing that: > > Program received signal SIGILL, Illegal instr

Re: [Qemu-devel] qemu crash in coroutine bdrv_co_do_rw

2015-03-06 Thread Stefan Hajnoczi
On Thu, Feb 26, 2015 at 10:29:57AM +0100, Christian Borntraeger wrote: > is this some know issue? Under heavy load with lots of dataplane devices I > sometimes get a segfault in the bdrc_co_do_rw routine: > > #0 bdrv_co_do_rw (opaque=0x0) at /home/cborntra/REPOS/qemu/block.c:4791 > 4791 if

Re: [Qemu-devel] mfocrf missing on e500v2

2015-03-06 Thread Alexander Graf
> Am 06.03.2015 um 18:20 schrieb Maciej W. Rozycki : > >> On Fri, 6 Mar 2015, Alexander Graf wrote: >> >> I've finally managed to check out why my e500v2 automated tests fail to >> run. Apparently they break because autotest wants to execute target code >> and runs into an illegal instruction

Re: [Qemu-devel] mfocrf missing on e500v2

2015-03-06 Thread Maciej W. Rozycki
On Fri, 6 Mar 2015, Alexander Graf wrote: > >> And lo and behold, I really couldn't find any reference to mfocrf in the > >> e500v2 spec. > > > > Do real e500 processors trap on this operation as well? > > The illegal instruction I posted about above was when running qemu > *on* e500v2, becau

Re: [Qemu-devel] [PATCH v3 for-2.3 04/24] acpi: add aml_index() term

2015-03-06 Thread Marcel Apfelbaum
On 03/06/2015 12:40 PM, Igor Mammedov wrote: On Thu, 5 Mar 2015 16:55:02 +0200 Marcel Apfelbaum wrote: Add encoding for ACPI DefIndex Opcode. Signed-off-by: Marcel Apfelbaum --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertio

Re: [Qemu-devel] [RFC 0/1] Rolling stats on colo

2015-03-06 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > On 2015/3/5 21:31, Dr. David Alan Gilbert (git) wrote: > >From: "Dr. David Alan Gilbert" > > Hi Dave, > > > > >Hi, > > I'm getting COLO running on a couple of our machines here > >and wanted to see what was actually going on, so I merge

[Qemu-devel] the arm cache coherency cluster

2015-03-06 Thread Andrew Jones
In reply to this message I'll send two series' one for KVM and one for QEMU. The two series' are their respective component complements, and attempt to implement cache coherency for arm guests using emulated devices, where the emulator (qemu) uses cached memory for the device memory, but the guest

[Qemu-devel] [RFC PATCH 3/6] KVM: ARM: change __coherent_cache_guest_page interface

2015-03-06 Thread Andrew Jones
Remove the vcpu parameter. We can do this by doing the same query in the caller of __coherent_cache_guest_page, and then folding the result into its ipa_uncached parameter, which we rename to need_flush. A later patch will add a new caller for __coherent_cache_guest_page that does not have a vcpu

[Qemu-devel] [RFC PATCH 1/6] kvm: promote KVM_MEMSLOT_INCOHERENT to uapi

2015-03-06 Thread Andrew Jones
Signed-off-by: Andrew Jones --- arch/arm/kvm/mmu.c | 9 +++-- include/linux/kvm_host.h | 1 - include/uapi/linux/kvm.h | 1 + 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c index bcc1b3ad2adce..a806e8cecc01b 100644 --- a/arch/arm/k

[Qemu-devel] [RFC PATCH 4/6] KVM: ARM: extend __coherent_cache_guest_page

2015-03-06 Thread Andrew Jones
Also support only invalidating, rather than always invalidate+clear. Signed-off-by: Andrew Jones --- arch/arm/include/asm/kvm_mmu.h | 7 +-- arch/arm/kvm/mmu.c | 2 +- arch/arm64/include/asm/kvm_mmu.h | 7 +-- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [RFC PATCH 0/6] flush/invalidate on entry/exit

2015-03-06 Thread Andrew Jones
Userspace flags memory regions as incoherent and kvm flushes/ invalidates those regions on entry/exit from userspace. Result before patch 6/6: restores coherency, way t sloow Result with patch 6/6: fast again - well, we removed the code... Andrew Jones (6): kvm: promote KVM_MEMSLO

[Qemu-devel] [RFC PATCH 2/6] HACK: linux header update

2015-03-06 Thread Andrew Jones
Should do a proper update-linux-headers.sh update. Signed-off-by: Andrew Jones --- linux-headers/linux/kvm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index 12045a11c036b..d04e2d781c43b 100644 --- a/linux-headers/linux/kvm.h +++ b/l

[Qemu-devel] [RFC PATCH 2/6] KVM: Introduce incoherent cache maintenance API

2015-03-06 Thread Andrew Jones
Add two new memslot functions to the API kvm_flush_incoherent_memory_regions flush all KVM_MEM_INCOHERENT memslot addresses kvm_invalidate_incoherent_memory_regions invalidate all KVM_MEM_INCOHERENT memslot addresses Signed-off-by: Andrew Jones --- include/linux/kvm_host.h | 14 +++

[Qemu-devel] [RFC PATCH 6/6] KVM: ARM: no need for kvm_arch_flush_incoherent

2015-03-06 Thread Andrew Jones
kvm_arch_flush_incoherent makes things too slow, and we don't need it. Userspace can flush for us, as the necessary cache maintenance instruction is not (necessarily) privileged. Signed-off-by: Andrew Jones --- arch/arm/kvm/mmu.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm

[Qemu-devel] [RFC PATCH 5/6] KVM: ARM: implement kvm_*_incoherent_memory_regions

2015-03-06 Thread Andrew Jones
Add the kvm_*_incoherent_memory_regions calls to arm's kvm_arch_vcpu_ioctl_run and implement the corresponding arch flush/invalidate functions. Signed-off-by: Andrew Jones --- arch/arm/include/uapi/asm/kvm.h | 1 + arch/arm/kvm/arm.c| 4 +++ arch/arm/kvm/mmu.c

[Qemu-devel] [PATCH 3/6] kvm-all: put kvm_mem_flags to more work

2015-03-06 Thread Andrew Jones
Currently kvm_mem_flags just translates bools to bits, let's make it also determine the bools first. This avoids its parameter list growing each time we add a flag. Signed-off-by: Andrew Jones --- Posted this, as it makes sense without this series. http://lists.gnu.org/archive/html/qemu-devel/201

[Qemu-devel] [RFC PATCH 0/6] support KVM_MEM_INCOHERENT

2015-03-06 Thread Andrew Jones
Add support for the new KVM_MEM_INCOHERENT flag, and flag appropriate memory. (Only flags vram for now.) Patch 6/6 doesn't appear to be complete. While the VGA output is 99% corruption free, it's not perfect, so it's missing flushes somewhere... Andrew Jones (6): memory: add incoherent cache f

Re: [Qemu-devel] Reopen file descriptors on 'cont' command

2015-03-06 Thread Christopher Pereira
On 06-03-2015 14:19, Stefan Hajnoczi wrote: On Wed, Feb 25, 2015 at 09:32:18PM -0300, Christopher Pereira wrote: Does qemu reopen files on a 'cont' command? When working with images on a gluster volume, file descriptors may get into a bad state because of network timeouts, remounting a share, e

[Qemu-devel] [RFC/WIP PATCH 6/6] memory: add clear_cache_to_poc

2015-03-06 Thread Andrew Jones
Add a function that flushes the cache to PoC. We need a new function because __builtin___clear_cache only flushes to PoU. Call this function each time an address in a memory region that has been flagged as having an incoherent cache is written. For starters we only implement it for ARM. Most other

  1   2   >