Re: [Qemu-devel] [PATCH 2/2] docs: add memory-hotplug.txt

On Tue, 2015-03-03 at 11:16 -0500, Luiz Capitulino wrote: > On Tue, 03 Mar 2015 16:12:58 +0100 > Paulo Ricardo Paz Vital wrote: > > > On Tue, 2015-03-03 at 09:47 -0500, Luiz Capitulino wrote: > > > This document describes how to use memory hotplug in QEMU. > > > > > > Signed-off-by: Luiz Capitul

Re: [Qemu-devel] [PATCH] virtio-blk: Remove the stale FIXME comment

On Mon, 02/16 14:14, Stefan Hajnoczi wrote: > On Mon, Feb 16, 2015 at 12:09:40PM +0800, Fam Zheng wrote: > > By default, we have ioeventfd enabled, so the IO request processing is > > in IO thread; in the vcpu thread, guest mode is returned to as quickly > > as possible, and completion is delivered

Re: [Qemu-devel] [PULL 00/69] Block patches

Am 03.03.2015 um 18:33 schrieb Max Reitz: > On 2015-03-03 at 12:29, Christian Borntraeger wrote: >> Am 03.03.2015 um 15:52 schrieb Peter Maydell: >>> On 28 February 2015 at 03:57, Stefan Hajnoczi wrote: On Fri, Feb 27, 2015 at 6:17 PM, Stefan Hajnoczi wrote: > Ekaterina Tumanova (5

Re: [Qemu-devel] [PATCH] Introduce machine specific default memory size

Markus Armbruster writes: > Nikunj A Dadhania writes: > >> diff --git a/vl.c b/vl.c >> index eb89d62..dd56754 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -4053,6 +4053,18 @@ int main(int argc, char **argv, char **envp) >> exit(1); >> } >> >> +if (machine_class->default_ram_size

Re: [Qemu-devel] [PATCH v3 7/7] cpus: reclaim allocated vCPU objects

On Fri, Feb 13, 2015 at 4:10 PM, Zhu Guihua wrote: > From: Gu Zheng > > After ACPI get a signal to eject a vCPU, the vCPU must be > removed from CPU list，before the vCPU really removed, then > release the all related vCPU objects. > > In order to deal well with the kvm vcpus (which can not be re

Re: [Qemu-devel] [PATCH] error: Replace error_report() & error_free() with error_report_err()

On 2015/3/4 1:18, Eric Blake wrote: On 03/03/2015 02:55 AM, zhanghailiang wrote: Signed-off-by: zhanghailiang --- Might have been nice to mention this was a continuation of the work started in commit 565f65d27. OK, will send v2 with this message added, Thanks. hw/arm/virt.c | 2 +- sa

Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type

On 2015/3/4 1:21, Eric Blake wrote: On 03/03/2015 12:15 AM, zhanghailiang wrote: Yes, this is the reason ..., agreed, i don't like the abbreviate, But there is already a 'MigrationState' type defined: So, what about MigrationStatus ? ;) That would be fine with me. Bad news, this name

Re: [Qemu-devel] [PATCH] error: Replace error_report() & error_free() with error_report_err()

On 2015/3/4 15:14, Markus Armbruster wrote: Eric Blake writes: On 03/03/2015 02:55 AM, zhanghailiang wrote: Signed-off-by: zhanghailiang --- Might have been nice to mention this was a continuation of the work started in commit 565f65d27. Yes. Perhaps the -trivial maintainer can stick in

Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type

On 2015/3/4 15:48, Markus Armbruster wrote: Eric Blake writes: On 03/03/2015 12:15 AM, zhanghailiang wrote: Yes, this is the reason ..., agreed, i don't like the abbreviate, But there is already a 'MigrationState' type defined: So, what about MigrationStatus ? ;) That would be fine w

Re: [Qemu-devel] [PATCH] Introduce machine specific default memory size

On Wed, 04 Mar 2015 14:00:17 +0530 Nikunj A Dadhania wrote: > Markus Armbruster writes: > > > Nikunj A Dadhania writes: > > > >> diff --git a/vl.c b/vl.c > >> index eb89d62..dd56754 100644 > >> --- a/vl.c > >> +++ b/vl.c > >> @@ -4053,6 +4053,18 @@ int main(int argc, char **argv, char **envp)

Re: [Qemu-devel] [PATCH v3 14/16] target-s390x: Extend QMP command query-cpu-definitions

On Mon, 2 Mar 2015 16:11:00 -0300 Eduardo Habkost wrote: > On Mon, Mar 02, 2015 at 01:44:06PM +0100, Michael Mueller wrote: > > This patch implements the QMP command 'query-cpu-definitions' in the S390 > > context. The command returns a list of cpu model names in the current host > > context. A c

Re: [Qemu-devel] [PULL 1/1] xhci: generate a Transfer Event for each Transfer TRB with the IOC bit set

Hi Peter, sorry about poking you -- I'm aware you've been on vacation, but in you said you still inteded to pull stuff. So, can you please pull this? :) I'd like to enable the XHCI driver in both OVMF and AAVMF, and I'd like

[Qemu-devel] [PATCH] block/null: Latency simulation by adding new option "latency_ns"

Aio context switch should just work because the requests will be drained, so the scheduled timer(s) on the old context will be freed. Signed-off-by: Fam Zheng --- block/null.c | 34 -- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/block/null.c b/b

[Qemu-devel] [PATCH 1/1] virtio-serial: fix segfault on NULL port names

Commit d0a0bfe6729ef6044d76ea49fafa07e29fa598bd added checks for port names, but didn't add a check to ensure port->name is non-NULL. This results in a SIGSEGV. https://bugzilla.redhat.com/show_bug.cgi?id=1192775 Reported-by: vivian zhang Signed-off-by: Amit Shah --- hw/char/virtio-serial-bus

Re: [Qemu-devel] [PATCH] Introduce machine specific default memory size

Thomas Huth writes: > On Wed, 04 Mar 2015 14:00:17 +0530 > Nikunj A Dadhania wrote: > >> Markus Armbruster writes: >> >> > Nikunj A Dadhania writes: >> > >> >> diff --git a/vl.c b/vl.c >> >> index eb89d62..dd56754 100644 >> >> --- a/vl.c >> >> +++ b/vl.c >> >> @@ -4053,6 +4053,18 @@ int main(

Re: [Qemu-devel] [PATCH] Introduce machine specific default memory size

On Wed, 04 Mar 2015 14:34:27 +0530 Nikunj A Dadhania wrote: > Thomas Huth writes: > > > On Wed, 04 Mar 2015 14:00:17 +0530 > > Nikunj A Dadhania wrote: > > > >> Markus Armbruster writes: > >> > >> > Nikunj A Dadhania writes: > >> > > >> >> diff --git a/vl.c b/vl.c > >> >> index eb89d62..dd5

Re: [Qemu-devel] [PATCH] Introduce machine specific default memory size

Thomas Huth writes: > On Wed, 04 Mar 2015 14:34:27 +0530 > Nikunj A Dadhania wrote: > >> Thomas Huth writes: >> >> > On Wed, 04 Mar 2015 14:00:17 +0530 >> > Nikunj A Dadhania wrote: >> > >> >> Markus Armbruster writes: >> >> >> >> > Nikunj A Dadhania writes: >> >> > >> >> >> diff --git a/v

Re: [Qemu-devel] [PATCH] Introduce machine specific default memory size

On Wed, 04 Mar 2015 14:59:13 +0530 Nikunj A Dadhania wrote: > Thomas Huth writes: > > > On Wed, 04 Mar 2015 14:34:27 +0530 > > Nikunj A Dadhania wrote: > > > >> Thomas Huth writes: > >> > >> > On Wed, 04 Mar 2015 14:00:17 +0530 > >> > Nikunj A Dadhania wrote: > >> > > >> >> Markus Armbruste

Re: [Qemu-devel] [PATCH] virtio-blk: Remove the stale FIXME comment

Am 16.02.2015 um 05:09 hat Fam Zheng geschrieben: > By default, we have ioeventfd enabled, so the IO request processing is > in IO thread; in the vcpu thread, guest mode is returned to as quickly > as possible, and completion is delivered via irqfd. Therefore this > comment from the initial impleme

Re: [Qemu-devel] [PATCH] Introduce machine specific default memory size

Thomas Huth writes: > On Wed, 04 Mar 2015 14:59:13 +0530 > Nikunj A Dadhania wrote: > >> Thomas Huth writes: >> >> > On Wed, 04 Mar 2015 14:34:27 +0530 >> > Nikunj A Dadhania wrote: >> > >> >> Thomas Huth writes: >> >> >> >> > On Wed, 04 Mar 2015 14:00:17 +0530 >> >> > Nikunj A Dadhania wr

Re: [Qemu-devel] [PATCH] iotests: Fix 051's reference output

Am 03.03.2015 um 15:38 hat Max Reitz geschrieben: > Commit c4bacafb717de55538311b80a185ce9166b8daa2 changed (improved) > qdev_init_nofail()'s error reporting, which affects iotest 051. Fix the > reference output. > > Signed-off-by: Max Reitz Thanks, applied to the block branch. Kevin

[Qemu-devel] [PATCH] scsi-hd: fix property unset case

commit "BlockConf: Call backend functions to detect geometry and blocksizes" causes a segmentation fault on the invalid configuration of a scsi device without a drive. Lets check for conf.blk before calling blkconf_blocksizes. The error will be handled later on in scsi_realize anyway. Reported-by

Re: [Qemu-devel] [PATCH] iotests: Fix 061's reference output

Am 03.03.2015 um 20:57 hat Max Reitz geschrieben: > As of commit dc523cd348c47372faa7271c9aab2030f94c290d, passing an unkown > option name for image creation no longer results in that option's name > printed. This affects iotest 061's output, fix it. > > Signed-off-by: Max Reitz > --- > tests/qe

Re: [Qemu-devel] [PATCH 2/2] virtio-pci: switch to modern accessors for 1.0

On Wed, Mar 04, 2015 at 11:06:08AM +1030, Rusty Russell wrote: > "Michael S. Tsirkin" writes: > > virtio 1.0 config space is in LE format for all > > devices, use modern wrappers when accessed through > > the 1.0 BAR. > > Hmm, I'm not so sure about these patches. It's easy to miss the > existenc

Re: [Qemu-devel] [PATCH 2/9] throttle: Add throttle group infrastructure

On Tue, Mar 03, 2015 at 10:38:45AM -0600, Stefan Hajnoczi wrote: > > +qemu_mutex_init(&tg->lock); > > +throttle_init(&tg->ts); > > +QLIST_INIT(&tg->head); > > +tg->refcount = 1; > > + > > +/* insert new entry in the list */ > > +QTAILQ_INSERT_TAIL(&throttle_groups, tg, list

Re: [Qemu-devel] [PATCH 0/2] iotests: Make tests pass for vpc

Am 03.03.2015 um 22:22 hat Max Reitz geschrieben: > iotest 006 is simply outdated, and the vpc format has certain attributes > that make tests 004 and 104 fail. It's safe to exclude vpc from these > tests, so do that. Thanks, applied to the block branch. Kevin

[Qemu-devel] [RFC v2 0/4] Rolling statistics utilities

From: "Dr. David Alan Gilbert" Hi, This is an attempt at a generic rolling statistics utility to allow data (e.g. bandwidth usage, times etc) to be collected easily. They hold some basic values (min/max/mean/weighted mean) and the last 'n' raw values.I'd like to use this maybe with fault-t

[Qemu-devel] [RFC v2 3/4] hmp: Add a helper function for printing out a Rolling Statistics set

From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert --- hmp.c | 21 + 1 file changed, 21 insertions(+) diff --git a/hmp.c b/hmp.c index 735097c..20241d8 100644 --- a/hmp.c +++ b/hmp.c @@ -138,6 +138,27 @@ void hmp_info_mice(Monitor *mon, const QDict *qdict)

[Qemu-devel] [RFC v2 1/4] RollingStats qapi type

From: "Dr. David Alan Gilbert" This adds a QAPI type that holds the results of statistics collected by RStats. Signed-off-by: Dr. David Alan Gilbert --- qapi-schema.json | 30 ++ 1 file changed, 30 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json inde

[Qemu-devel] [RFC v2 2/4] Rolling statistics utilities

From: "Dr. David Alan Gilbert" There are various places where it's useful to hold a series of values that change over time and get summaries about them. This provides: - a count of the number of items - min/max - mean - a weighted mean (where you can set the weight to determine

[Qemu-devel] [RFC v2 4/4] Example use of rolling statistics in migration

From: "Dr. David Alan Gilbert" This is an example use of the rolling statistics to watch the 'expected downtime' in a bit more detail than the current summary figure. Example outputs from a simple run: HMP: expected downtime stats: Min/Max: 222, 1634 Mean: 983.8 (Weighted: 1005.1253) Count: 141

[Qemu-devel] [PATCH v2] error: Replace error_report() & error_free() with error_report_err()

This is a continuation of the work started in commit 565f65d27: "error: Use error_report_err() where appropriate" Signed-off-by: zhanghailiang Reviewed-by: Eric Blake --- v2: - Add Reviewd-by and commit message --- hw/arm/virt.c | 2 +- savevm.c | 3 +-- 2 files changed, 2 insertions(+), 3

Re: [Qemu-devel] [PATCH RESEND 01/17] docs: incremental backup documentation

Am 02.03.2015 um 18:49 hat Max Reitz geschrieben: > >+2. Create a destination image for the incremental backup that utilizes the > >+full backup as a backing image. > >+ > >+* Let's assume it is named 'incremental.0.img'. > >+ > >+```sh > >+# qemu-img create -f qcow2 incremental.0.img -

Re: [Qemu-devel] [PATCH 1/1] virtio-serial: fix segfault on NULL port names

Amit Shah writes: > Commit d0a0bfe6729ef6044d76ea49fafa07e29fa598bd added checks for port > names, but didn't add a check to ensure port->name is non-NULL. This > results in a SIGSEGV. > > https://bugzilla.redhat.com/show_bug.cgi?id=1192775 > > Reported-by: vivian zhang > Signed-off-by: Amit Sh

Re: [Qemu-devel] [PATCH] virtio-pci: make pci bar layout more flexible.

Hi, > > VirtIOPCIProxy subclasses which need additional pci bars, such as > > virtio-vga, just need to make sure they register the additinal bars > > before initializing virtio-pci, so the superclass can see the registered > > bars and shuffle around the virtio bars accordingly. > > I think I p

[Qemu-devel] [PATCH] vl: Adjust the place of processing '-mon'

From: Xiangyou Xie If VM is configured with large size of hugepage, when startup, it will consume lots of time to zero the hugepage memory in the function 'os_mem_prealloc'. Libvirtd will wait 30 seconds for qemu to establish the monitor, If the timeout triggers, libvirtd will send TERM signal to

Re: [Qemu-devel] [PULL 1/1] xhci: generate a Transfer Event for each Transfer TRB with the IOC bit set

On Mi, 2015-03-04 at 10:03 +0100, Laszlo Ersek wrote: > Hi Peter, > > sorry about poking you -- I'm aware you've been on vacation, but in > > you said you still inteded to pull stuff. > > So, can you please pull this? :) I'd

Re: [Qemu-devel] [PATCH v3] block/vdi: Add locking for parallel requests

Am 27.02.2015 um 20:54 hat Max Reitz geschrieben: > When allocating a new cluster, the first write to it must be the one > doing the allocation, because that one pads its write request to the > cluster size; if another write to that cluster is executed before it, > that write will be overwritten du

Re: [Qemu-devel] [PATCH] vl: Adjust the place of processing '-mon'

On 04/03/2015 11:59, zhanghailiang wrote: > From: Xiangyou Xie > > If VM is configured with large size of hugepage, when startup, > it will consume lots of time to zero the hugepage memory in the function > 'os_mem_prealloc'. > Libvirtd will wait 30 seconds for qemu to establish the monitor, >

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Introduce machine specific default memory size

Nikunj A Dadhania writes: > Markus Armbruster writes: > >> Nikunj A Dadhania writes: >> >>> diff --git a/vl.c b/vl.c >>> index eb89d62..dd56754 100644 >>> --- a/vl.c >>> +++ b/vl.c >>> @@ -4053,6 +4053,18 @@ int main(int argc, char **argv, char **envp) >>> exit(1); >>> } >>> >>>

[Qemu-devel] [PATCH v2] Introduce machine specific default memory size

QEMU default memory of 128MB is not enough to boot sPAPR guest. Introduce a member in the machine class to override the default memory size enforced by QEMU. Signed-off-by: Nikunj A Dadhania --- hw/ppc/spapr.c | 1 + include/hw/boards.h| 1 + include/hw/ppc/spapr.h | 3 +++ vl.c

Re: [Qemu-devel] [PATCH] virtio-pci: make pci bar layout more flexible.

On Mi, 2015-03-04 at 12:04 +0100, Michael S. Tsirkin wrote: > On Wed, Mar 04, 2015 at 11:55:50AM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > > VirtIOPCIProxy subclasses which need additional pci bars, such as > > > > virtio-vga, just need to make sure they register the additinal bars > > > > b

Re: [Qemu-devel] [PATCH v2 1/3] migration: Read JSON VM description on incoming migration

* Alexander Graf (ag...@suse.de) wrote: > One of the really nice things about the VM description format is that it goes > over the wire when live migration is happening. Unfortunately QEMU today > closes > any socket once it sees VM_EOF coming, so we never give the VMDESC the chance > to > actual

Re: [Qemu-devel] [PATCH] virtio-pci: make pci bar layout more flexible.

On Wed, Mar 04, 2015 at 12:46:50PM +0100, Gerd Hoffmann wrote: > On Mi, 2015-03-04 at 12:04 +0100, Michael S. Tsirkin wrote: > > On Wed, Mar 04, 2015 at 11:55:50AM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > > > VirtIOPCIProxy subclasses which need additional pci bars, such as > > > > > vi

Re: [Qemu-devel] [PATCH v2 3/3] pc: Disable vmdesc submission for old machines

* Alexander Graf (ag...@suse.de) wrote: > Older PC machine types might by accident be backwards live migration > compatible, > but with the new vmdesc self-describing blob in our live migration stream we > would break that compatibility. > > Also users wouldn't expect massive behaviorial differen

Re: [Qemu-devel] [PULL 00/69] Block patches

Am 04.03.2015 um 09:28 hat Christian Borntraeger geschrieben: > Am 03.03.2015 um 18:33 schrieb Max Reitz: > > On 2015-03-03 at 12:29, Christian Borntraeger wrote: > >> Am 03.03.2015 um 15:52 schrieb Peter Maydell: > >>> On 28 February 2015 at 03:57, Stefan Hajnoczi wrote: > On Fri, Feb 27, 20

Re: [Qemu-devel] [PATCH 2/2] docs: add memory-hotplug.txt

On Tue, 3 Mar 2015 09:47:26 -0500 Luiz Capitulino wrote: > This document describes how to use memory hotplug in QEMU. > > Signed-off-by: Luiz Capitulino Reviewed-by: Igor Mammedov > --- > docs/memory-hotplug.txt | 76 > + > 1 file changed, 7

Re: [Qemu-devel] [PATCH] virtio-pci: make pci bar layout more flexible.

On Wed, Mar 04, 2015 at 12:51:35PM +0100, Michael S. Tsirkin wrote: > On Wed, Mar 04, 2015 at 12:46:50PM +0100, Gerd Hoffmann wrote: > > On Mi, 2015-03-04 at 12:04 +0100, Michael S. Tsirkin wrote: > > > On Wed, Mar 04, 2015 at 11:55:50AM +0100, Gerd Hoffmann wrote: > > > > Hi, > > > > > > > > >

Re: [Qemu-devel] Delaying -rc0?

Hi, > Well, the support was ready in time, see: > [SeaBIOS] [PATCH V3 0/2] fw/pci: better support for multiple host bridges > http://permalink.gmane.org/gmane.comp.bios.coreboot.seabios/8681 > but the SeaBIOS maintainers preferred to see first the QEMU submission > getting accepted. Yep

Re: [Qemu-devel] [PATCH V14 2/3] pc: add a Virtual Machine Generation ID device

On Tue, Mar 03, 2015 at 09:33:51PM +0100, Igor Mammedov wrote: > On Tue, 3 Mar 2015 18:35:39 +0100 > "Michael S. Tsirkin" wrote: > > > On Tue, Mar 03, 2015 at 05:18:14PM +0100, Igor Mammedov wrote: > > > Based on Microsoft's sepecifications (paper can be dowloaded from > > > http://go.microsoft.c

Re: [Qemu-devel] Delaying -rc0?

On Mi, 2015-03-04 at 08:27 +0100, Markus Armbruster wrote: > Peter Maydell writes: > > > On 4 March 2015 at 00:07, Marcel Apfelbaum wrote: > >> In the mean time this series depends on Igor's ACPI dynamic series that > >> took > >> a lot of time to review and even Michael's PULL request with it

Re: [Qemu-devel] [PATCH v3 03/10] acpi, mem-hotplug: Add acpi_send_gpe_event() to rise sci for memory hotplug.

On Mon, Mar 02, 2015 at 10:27:29AM +0100, Igor Mammedov wrote: > On Sun, 1 Mar 2015 18:29:39 +0100 > "Michael S. Tsirkin" wrote: > > > On Thu, Feb 26, 2015 at 09:16:45AM +0800, Zhu Guihua wrote: > > > From: Tang Chen > > > > > > Add a new API named acpi_send_gpe_event() to send memory hotplug S

Re: [Qemu-devel] [PATCH] migration/rdma: clean up qemu_rdma_dest_init a bit

* Michael Tokarev (m...@tls.msk.ru) wrote: > Do not check for rdma->host being empty twice. This removes a large > "if" block, so code indentation is changed. While at it, remove an > ugly goto from the loop, replacing it with a cleaner if logic. And > finally, there's no need to initialize `ret

Re: [Qemu-devel] Delaying -rc0?

On Wed, Mar 04, 2015 at 01:13:14PM +0100, Gerd Hoffmann wrote: > On Mi, 2015-03-04 at 08:27 +0100, Markus Armbruster wrote: > > Peter Maydell writes: > > > > > On 4 March 2015 at 00:07, Marcel Apfelbaum wrote: > > >> In the mean time this series depends on Igor's ACPI dynamic series that > > >>

Re: [Qemu-devel] [PATCH 1/3] migration: Fix coding style (whitespace issues)

* Stefan Weil (s...@weilnetz.de) wrote: > * Remove trailing whitespace (fixes 9 errors from checkpatch.pl). > One comment line was longer than 80 characters, so wrap it > and fix a typo, too. > * Replace tabs by blanks (fixes 1 error). > > Signed-off-by: Stefan Weil Needs merging with Michae

Re: [Qemu-devel] [PATCH v2] Introduce machine specific default memory size

On Wed, 4 Mar 2015 16:48:05 +0530 Nikunj A Dadhania wrote: > QEMU default memory of 128MB is not enough to boot sPAPR > guest. Introduce a member in the machine class to override the default > memory size enforced by QEMU. > now we have DEFAULT_RAM_SIZE in vl.c and default_ram_size in Machine c

Re: [Qemu-devel] [PATCH] scsi-hd: fix property unset case

Am 04.03.2015 um 11:02 hat Ekaterina Tumanova geschrieben: > commit "BlockConf: Call backend functions to detect geometry and > blocksizes" causes a segmentation fault on the invalid configuration of > a scsi device without a drive. > > Lets check for conf.blk before calling blkconf_blocksizes. Th

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] Introduce machine specific default memory size

On 04.03.15 12:18, Nikunj A Dadhania wrote: > QEMU default memory of 128MB is not enough to boot sPAPR > guest. Introduce a member in the machine class to override the default > memory size enforced by QEMU. > > Signed-off-by: Nikunj A Dadhania > --- > hw/ppc/spapr.c | 1 + > include/h

Re: [Qemu-devel] [PATCH] migration/rdma: clean up qemu_rdma_dest_init a bit

04.03.2015 15:16, Dr. David Alan Gilbert wrote: > * Michael Tokarev (m...@tls.msk.ru) wrote: >> Do not check for rdma->host being empty twice. This removes a large >> "if" block, so code indentation is changed. While at it, remove an >> ugly goto from the loop, replacing it with a cleaner if logi

Re: [Qemu-devel] [PATCH v4 1/1] numa: Print warning if no node is assigned to a CPU

On Tue, Feb 24, 2015 at 03:57:23PM -0300, Eduardo Habkost wrote: > Instead of silently assigning CPU to node 0 when it is omitted from the > command-line, check if all CPUs up to max_cpus are present in the NUMA > configuration. > > I am making this a warning and not a fatal error, to allow manage

Re: [Qemu-devel] [PATCHv2] Add testcase for scsi-hd devices without drive property

Am 03.03.2015 um 15:59 hat Christian Borntraeger geschrieben: > Lets add a test for scsi devices without a drive. This was broken > by a recent block patch, thus indicating that we need a testcase. > > Suggested-by: Kevin Wolf > Signed-off-by: Christian Borntraeger Thanks, applied to the block

Re: [Qemu-devel] Delaying -rc0?

On Wed, Mar 04, 2015 at 12:14:21AM +0900, Peter Maydell wrote: > On 4 March 2015 at 00:07, Marcel Apfelbaum wrote: > > In the mean time this series depends on Igor's ACPI dynamic series that took > > a lot of time to review and even Michael's PULL request with it is not yet > > in master. > > You

Re: [Qemu-devel] [PATCH v2] Introduce machine specific default memory size

On 03/04/2015 01:18 PM, Nikunj A Dadhania wrote: QEMU default memory of 128MB is not enough to boot sPAPR guest. Introduce a member in the machine class to override the default memory size enforced by QEMU. Signed-off-by: Nikunj A Dadhania Hi, Thank you for contributing to QEMU! --- hw/ppc

Re: [Qemu-devel] [PATCH] target-ppc: Add versions to server CPU descriptions

On 04.03.15 02:31, Alexey Kardashevskiy wrote: > 5b79b1c "target-ppc: Create versionless CPU class per family if KVM" added > a dynamic CPU class registration with the name of the CPU family which > QEMU is running on. For example, this allowed specifying "-cpu POWER7" > on every version of POWER

Re: [Qemu-devel] [PATCH 0/2] target-i386: Small code cleanup

On Tue, Feb 03, 2015 at 04:08:56PM -0200, Eduardo Habkost wrote: > Just two small code cleanups in target-i386/cpu.c. > > Patch 1/2 changes behavior of "-cpu ?" to not print feature names in reverse > order anymore. Patch 2/2 doesn't introduce any behavior changes. Andreas, just to confirm: is th

Re: [Qemu-devel] [Qemu-trivial] [PATCH 6/9] 9pfs: fix memory leak

27.02.2015 10:50, arei.gong...@huawei.com wrote: > From: Gonglei > > Signed-off-by: Gonglei > --- > hw/9pfs/virtio-9p-local.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/virtio-9p-local.c > index a183eee..bcad4e0 10064

Re: [Qemu-devel] [PATCH v4 1/1] numa: Print warning if no node is assigned to a CPU

On Tue, Feb 24, 2015 at 03:57:23PM -0300, Eduardo Habkost wrote: > Instead of silently assigning CPU to node 0 when it is omitted from the > command-line, check if all CPUs up to max_cpus are present in the NUMA > configuration. Could you please describe the problematic configuration in more detai

Re: [Qemu-devel] [PATCH v2] Introduce machine specific default memory size

On 03/04/2015 02:21 PM, Igor Mammedov wrote: On Wed, 4 Mar 2015 16:48:05 +0530 Nikunj A Dadhania wrote: QEMU default memory of 128MB is not enough to boot sPAPR guest. Introduce a member in the machine class to override the default memory size enforced by QEMU. now we have DEFAULT_RAM_SIZE

Re: [Qemu-devel] [PATCH v19 0/2] EEH Support for VFIO Devices

On 20.02.15 05:58, Gavin Shan wrote: > The series of patches adds support EEH for VFIO PCI devices on sPAPR platform. > It requires corresponding host kernel support, which was merged during 3.17 > merge window. This patchset has been rebased to Alex Graf's QEMU repository: > >git://github.c

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] Introduce machine specific default memory size

On 03/04/2015 02:21 PM, Alexander Graf wrote: On 04.03.15 12:18, Nikunj A Dadhania wrote: QEMU default memory of 128MB is not enough to boot sPAPR guest. Introduce a member in the machine class to override the default memory size enforced by QEMU. Signed-off-by: Nikunj A Dadhania --- hw/pp

[Qemu-devel] [PATCH 1/2] virtio-pci: change & document virtio pci bar layout.

This patch adds variables for the pci bars (to get rid of the magic numbers in the code) and moves the modern virtio bar to region 4 so regions 2+3 are kept free. virtio-vga wants use them. Signed-off-by: Gerd Hoffmann --- hw/virtio/virtio-pci.c | 31 +-- 1 file chan

[Qemu-devel] [PATCH 2/2] virtio-pci: make modern bar 64bit + prefetchable

Signed-off-by: Gerd Hoffmann --- hw/virtio/virtio-pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index d965869..6e9f46a 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -1378,7 +1378,9 @@ static void

Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type

On 2015/3/3 16:59, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: On 2015/3/2 23:56, Eric Blake wrote: On 02/27/2015 07:54 PM, zhanghailiang wrote: On 2015/2/28 0:48, Eric Blake wrote: On 02/26/2015 11:19 PM, zhanghailiang wrote: The original 'status' i

Re: [Qemu-devel] [PATCH v5 00/13] block: Rework bdrv_close_all()

Am 03.03.2015 um 21:12 hat Max Reitz geschrieben: > Justification for patch 9: > > Adding yet another list of BlockDriverStates is ugly, I know. But we > need something to track all the block jobs, and these are the > alternatives: > > A. Have a list of all block jobs. Feasible, but this would in

Re: [Qemu-devel] [PATCH 2/3] migration: Fix some 32 bit compiler errors

* Stefan Weil (s...@weilnetz.de) wrote: > The current code won't compile on 32 bit hosts because there are lots > of type casts between pointers and 64 bit integers. > > Fix some of them. > > Signed-off-by: Stefan Weil Please route rdma stuff through migration, not -trivial; it's never trivial

Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type

* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > On 2015/3/3 16:59, Dr. David Alan Gilbert wrote: > >* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > >>On 2015/3/2 23:56, Eric Blake wrote: > >>>On 02/27/2015 07:54 PM, zhanghailiang wrote: > On 2015/2/28 0:48, Eric Blake wrote:

Re: [Qemu-devel] [PATCH v2 0/3] fix bug about balloon working incorrectly when hotplug memeory

On 2015/3/3 22:04, Luiz Capitulino wrote: On Mon, 17 Nov 2014 13:11:07 +0800 zhanghailiang wrote: Hi, Patch 1 and 2 mainly fix bug about balloon not working correctly when we do hotplug memory. It takes 'ram_size' as VM's real RAM size which is wrong after we hotplug memory. This bug exists

Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type

On 2015/3/4 20:50, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: On 2015/3/3 16:59, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: On 2015/3/2 23:56, Eric Blake wrote: On 02/27/2015 07:54 PM, zhanghailiang wrote:

Re: [Qemu-devel] [PATCH] sheepdog: Fix misleading error messages in sd_snapshot_create()

Am 12.02.2015 um 14:49 hat Markus Armbruster geschrieben: > If do_sd_create() fails, it first reports the error returned, then > reports a another one with strerror(errno). errno is meaningless at > that point. > > Report just one error combining the valid information from both > messages. > > R

Re: [Qemu-devel] [PATCH V14 2/3] pc: add a Virtual Machine Generation ID device

On Wed, 4 Mar 2015 13:11:48 +0100 "Michael S. Tsirkin" wrote: > On Tue, Mar 03, 2015 at 09:33:51PM +0100, Igor Mammedov wrote: > > On Tue, 3 Mar 2015 18:35:39 +0100 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Mar 03, 2015 at 05:18:14PM +0100, Igor Mammedov wrote: > > > > Based on Microsof

Re: [Qemu-devel] [PATCH] block/null: Latency simulation by adding new option "latency_ns"

Am 04.03.2015 um 10:04 hat Fam Zheng geschrieben: > Aio context switch should just work because the requests will be > drained, so the scheduled timer(s) on the old context will be freed. > > Signed-off-by: Fam Zheng You should probably also add co_aio_sleep_ns() calls to null_co_readv/write/flu

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/9] arm: fix memory leak

27.02.2015 10:50, arei.gong...@huawei.com wrote: [] > @@ -565,6 +565,7 @@ static void create_flash(const VirtBoardInfo *vbi) > error_report("Could not load ROM image '%s'", bios_name); > exit(1); > } > +g_free(fn); > } > > create_one_flash("vir

Re: [Qemu-devel] [PATCH 3/3] migration: Fix remaining 32 bit compiler errors

* Stefan Weil (s...@weilnetz.de) wrote: > Fix type casts between pointers and 64 bit integers. > Now 32 bit builds are possible again. > > Signed-off-by: Stefan Weil > --- > migration/rdma.c | 57 > +- > 1 file changed, 31 insertions(+), 26

Re: [Qemu-devel] [PATCH] migration/rdma: clean up qemu_rdma_dest_init a bit

* Michael Tokarev (m...@tls.msk.ru) wrote: > 04.03.2015 15:16, Dr. David Alan Gilbert wrote: > > * Michael Tokarev (m...@tls.msk.ru) wrote: > >> Do not check for rdma->host being empty twice. This removes a large > >> "if" block, so code indentation is changed. While at it, remove an > >> ugly go

Re: [Qemu-devel] [PATCH] migration/rdma: clean up qemu_rdma_dest_init a bit

04.03.2015 16:32, Dr. David Alan Gilbert wrote: > * Michael Tokarev (m...@tls.msk.ru) wrote: [] >> I think it's okay to merge it using the -trivial tree, I'm about to >> send a pull request today. > > Yes, OK, although I'd generally prefer the RDMA stuff to go > through migration unless it's reall

Re: [Qemu-devel] [PATCH v2 01/37] blockdev: Allow creation of BDS trees without BB

Am 09.02.2015 um 18:11 hat Max Reitz geschrieben: > If the "id" field is missing from the options given to blockdev-add, > just omit the BlockBackend and create the BlockDriverState tree alone. > > However, if "id" is missing, "node-name" must be specified; otherwise, > the BDS tree would no longe

Re: [Qemu-devel] [PATCH v4 1/1] numa: Print warning if no node is assigned to a CPU

On Wed, Mar 04, 2015 at 01:30:35PM +0100, Michael S. Tsirkin wrote: > On Tue, Feb 24, 2015 at 03:57:23PM -0300, Eduardo Habkost wrote: > > Instead of silently assigning CPU to node 0 when it is omitted from the > > command-line, check if all CPUs up to max_cpus are present in the NUMA > > configura

Re: [Qemu-devel] [PATCH v6 07/15] spapr_rtas: add ibm, configure-connector RTAS interface

Quoting Michael Roth (2015-03-03 23:50:34) > Quoting David Gibson (2015-03-02 23:33:39) > > On Mon, Mar 02, 2015 at 10:40:16PM -0600, Michael Roth wrote: > > > Quoting David Gibson (2015-03-02 01:02:46) > > > > On Thu, Feb 26, 2015 at 09:11:07PM -0600, Michael Roth wrote: > > > > > This interface i

Re: [Qemu-devel] [PATCH RFC 1/1] s390x/pci: Extend pci representation by new zpci device

On Tue, Mar 03, 2015 at 09:38:37PM +0100, Alexander Graf wrote: > > > On 03.03.15 14:25, Frank Blaschka wrote: > > On Tue, Mar 03, 2015 at 10:33:05AM +0100, Alexander Graf wrote: > >> > >> > >> > >>> Am 03.03.2015 um 09:06 schrieb Frank Blaschka > >>> : > >>> > On Thu, Feb 26, 2015 at 04:34

Re: [Qemu-devel] [PATCH] sdl2: Fix RGB555

On Di, 2015-03-03 at 12:25 -0500, Max Reitz wrote: > Reproducable with: > > $ x86_64-softmmu/qemu-system-x86_64 \ > -kernel $vmlinuz_of_your_choice \ > -append vga=0x313 -sdl Added to sdl patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH V14 2/3] pc: add a Virtual Machine Generation ID device

On Wed, Mar 04, 2015 at 02:12:32PM +0100, Igor Mammedov wrote: > On Wed, 4 Mar 2015 13:11:48 +0100 > "Michael S. Tsirkin" wrote: > > > On Tue, Mar 03, 2015 at 09:33:51PM +0100, Igor Mammedov wrote: > > > On Tue, 3 Mar 2015 18:35:39 +0100 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Tue, M

Re: [Qemu-devel] [PATCH v4 1/1] numa: Print warning if no node is assigned to a CPU

On Wed, Mar 04, 2015 at 10:35:51AM -0300, Eduardo Habkost wrote: > On Wed, Mar 04, 2015 at 01:30:35PM +0100, Michael S. Tsirkin wrote: > > On Tue, Feb 24, 2015 at 03:57:23PM -0300, Eduardo Habkost wrote: > > > Instead of silently assigning CPU to node 0 when it is omitted from the > > > command-lin

[Qemu-devel] [PATCH v5 0/1] NUMA: Validate CPU configuration

This adds extra checks to the NUMA code to make sure the CPU configuration is consistent. This needs to be applied on top of my numa patch queue: https://github.com/ehabkost/qemu.git numa Changes v1 -> v2: * (none, v1 was tagged by accident and never sent to qemu-devel) Changes v2 -> v3: * F

[Qemu-devel] [PATCH v5 1/1] numa: Print warning if no node is assigned to a CPU

We need all possible CPUs (including hotplug ones) to be present in the SRAT when QEMU starts. QEMU already does that correctly today, the only problem is that when a CPU is omitted from the NUMA configuration, it is silently assigned to node 0. Check if all CPUs up to max_cpus are present in the

Re: [Qemu-devel] [PATCH 7/9] throttle: Add throttle group support

On Tue, Mar 03, 2015 at 03:00:06PM -0600, Stefan Hajnoczi wrote: > > +throttle_group_lock(bs->throttle_state); > > +bdrv_throttle_group_remove(bs); > > +throttle_group_unlock(bs->throttle_state); > > + > > +throttle_group_unref(bs->throttle_state); > > +bs->throttle_state = NUL

Re: [Qemu-devel] [PATCH v2 14/17] block: Resize bitmaps on bdrv_truncate

On 2015-03-03 at 17:48, John Snow wrote: On 03/03/2015 04:27 PM, Max Reitz wrote: On 2015-03-03 at 16:24, John Snow wrote: On 03/03/2015 11:02 AM, Max Reitz wrote: On 2015-03-02 at 18:20, John Snow wrote: Signed-off-by: John Snow --- block.c| 22 i

Re: [Qemu-devel] [PATCH] scsi-hd: fix property unset case

On 2015-03-04 at 07:23, Kevin Wolf wrote: Am 04.03.2015 um 11:02 hat Ekaterina Tumanova geschrieben: commit "BlockConf: Call backend functions to detect geometry and blocksizes" causes a segmentation fault on the invalid configuration of a scsi device without a drive. Lets check for conf.blk be

Re: [Qemu-devel] [PATCH v2 03/37] hw/block/fdc: Implement tray status

Am 09.02.2015 um 18:11 hat Max Reitz geschrieben: > The tray of an FDD is open iff there is no medium inserted (there are > only two states for an FDD: "medium inserted" or "no medium inserted"). > > This results in the tray being reported as open if qemu has been started > with the default floppy

Re: [Qemu-devel] [PATCH v5 03/13] iotests: Add test for eject under NBD server

On 2015-03-04 at 01:30, Fam Zheng wrote: On Tue, 03/03 15:13, Max Reitz wrote: This patch adds a test for ejecting the BlockBackend an NBD server is connected to (the NBD server is supposed to stop). Signed-off-by: Max Reitz --- tests/qemu-iotests/096 | 90 +++

Re: [Qemu-devel] [PATCH] configure: require glib 2.22

On 4 March 2015 at 16:42, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: >> At least the g_ptr_array_new_with_free_func is easy to work around, I >> fixed that one up. If we are decided, maybe defer this until after 2.3, >> we have enough noise in 2.3 already ... > > Nah, let's go for i

  1   2   3   4   >