Re: [Qemu-devel] vmdk: improve streamOptimized vmdk support

2015-02-23 Thread Markus Armbruster
Perhaps Fam (cc'ed) can help you. Sunil Kumar writes: [...] > Hi, > > I ran into an issue where the OVA created from the VMDK file created > by qemu-img is rejected by vSphere with a message like "Not a > supported disk format (sparse VMDK too old)". I was looking through > the archives and foun

[Qemu-devel] [PATCH] vfio: Add ioctl number to error report

2015-02-23 Thread Alexey Kardashevskiy
This makes the error report more informative. Signed-off-by: Alexey Kardashevskiy --- hw/vfio/common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index cebd3b0..d6d97d1 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -931,8

[Qemu-devel] [PATCH] vfio: Make type1 listener symbols static

2015-02-23 Thread Alexey Kardashevskiy
They are not used from anywhere but common.c which is where these are defined so make them static. Signed-off-by: Alexey Kardashevskiy --- hw/vfio/common.c | 4 ++-- include/hw/vfio/vfio-common.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/vfio/common.c

[Qemu-devel] [RFC PATCH] vfio: spapr: Move SPAPR-related code to a separate file

2015-02-23 Thread Alexey Kardashevskiy
This moves SPAPR bits to a separate file to avoid pollution of x86 code. This is a mechanical patch. Signed-off-by: Alexey Kardashevskiy --- There is another patch coming with DMA memory preregistration which will add another listener on RAM (not IOMMU as in previos posted patchset which is wro

[Qemu-devel] [PATCH 04/10] spapr_vio: Introduce a liobn number generating macros

2015-02-23 Thread Alexey Kardashevskiy
This introduces a macro which makes up a LIOBN from fixed prefix and VIO device address (@reg property). This is to keep LIOBN macros rendering consistent - the same macro for PCI has been added by the previous patch. Signed-off-by: Alexey Kardashevskiy Reviewed-by: David Gibson --- hw/ppc/spa

[Qemu-devel] [PATCH 02/10] spapr_iommu: Make H_PUT_TCE_INDIRECT endian-safe

2015-02-23 Thread Alexey Kardashevskiy
PAPR is defined as big endian so TCEs need an adjustment so does this patch. This changes code to have ldq_be_phys() in one place. Signed-off-by: Alexey Kardashevskiy Reviewed-by: David Gibson --- hw/ppc/spapr_iommu.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/h

[Qemu-devel] [PATCH 00/10] spapr: Small patches to prepare for Dynamic DMA windows

2015-02-23 Thread Alexey Kardashevskiy
These I have in my DDW working tree for quite a while, while I am polishing others, there could go to some tree already. Please comment. Thanks! Alexey Kardashevskiy (10): spapr_iommu: Disable in-kernel IOMMU tables for >4GB windows spapr_iommu: Make H_PUT_TCE_INDIRECT endian-safe spapr_pc

[Qemu-devel] [PATCH 03/10] spapr_pci: Introduce a liobn number generating macros

2015-02-23 Thread Alexey Kardashevskiy
We are going to have multiple DMA windows per PHB and we want them to migrate so we need a predictable way of assigning LIOBNs. This introduces a macro which makes up a LIOBN from fixed prefix, PHB index (unique PHB id) and window number. This introduces a SPAPR_PCI_DMA_WINDOW_NUM() to know the w

[Qemu-devel] [PATCH 01/10] spapr_iommu: Disable in-kernel IOMMU tables for >4GB windows

2015-02-23 Thread Alexey Kardashevskiy
The existing KVM_CREATE_SPAPR_TCE ioctl only support 4G windows max as the window size parameter to the kernel ioctl() is 32-bit so there's no way of expressing a TCE window > 4GB. We are going to add huge DMA windows support so this will create small window and unexpectedly fail later. This disa

[Qemu-devel] [PATCH 06/10] spapr_iommu: Add separate trace points for PCI DMA operations

2015-02-23 Thread Alexey Kardashevskiy
This is to reduce VIO noise while debugging PCI DMA. Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_iommu.c | 27 --- include/hw/ppc/spapr.h | 1 + trace-events | 4 3 files changed, 25 insertions(+), 7 deletions(-) diff --git a/hw/ppc/spapr_iomm

[Qemu-devel] [PATCH 08/10] spapr_iommu: Make spapr_tce_find_by_liobn() public

2015-02-23 Thread Alexey Kardashevskiy
At the moment spapr_tce_find_by_liobn() is used by H_PUT_TCE/... handlers to find an IOMMU by LIOBN. We are going to implement Dynamic DMA windows (DDW), new code will go to a new file and we will use spapr_tce_find_by_liobn() there too so let's make it public. Signed-off-by: Alexey Kardashevskiy

[Qemu-devel] [PATCH 09/10] spapr_pci: Rework device-tree rendering

2015-02-23 Thread Alexey Kardashevskiy
This replaces object_child_foreach() and callback with existing SPAPR_PCI_LIOBN() and spapr_tce_find_by_liobn() to make the code easier to read. This is a mechanical patch so no behaviour change is expected. Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_pci.c | 30 +--

[Qemu-devel] [PATCH 05/10] spapr_pci: Define default DMA window size as a macro

2015-02-23 Thread Alexey Kardashevskiy
This gets rid of a magic constant describing the default DMA window size for an emulated PHB. Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_pci.c | 6 +++--- include/hw/pci-host/spapr.h | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw

[Qemu-devel] [PATCH 07/10] spapr_pci: Make find_phb()/find_dev() public

2015-02-23 Thread Alexey Kardashevskiy
This makes find_phb()/find_dev() public and changed its names to spapr_pci_find_phb()/spapr_pci_find_dev() as they are going to be used from other parts of QEMU such as VFIO DDW (dynamic DMA window) or VFIO PCI error injection or VFIO EEH handling - in all these cases there are RTAS calls which are

[Qemu-devel] [PATCH 10/10] spapr_iommu: Give unique QOM name to TCE table

2015-02-23 Thread Alexey Kardashevskiy
Useful for debugging. Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_iommu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c index 65ee001..4f4836c 100644 --- a/hw/ppc/spapr_iommu.c +++ b/hw/ppc/spapr_iommu.c @@ -160,6 +160

Re: [Qemu-devel] [RFC PATCH] utils: Add up_pow_of_two()

2015-02-23 Thread Peter Maydell
On 23 February 2015 at 16:49, Alexey Kardashevskiy wrote: > This adds a helper to get closest bigger power-of-two value. > > Signed-off-by: Alexey Kardashevskiy > --- > > It is a log2 of round up to power of two. Is there anything like this > in QEMU already? Any better name than up_pow_of_two()?

Re: [Qemu-devel] unable to set SATA serial with a spaces

2015-02-23 Thread Markus Armbruster
Alan Latteri writes: > The left padding is important and necessary to keep for my particular > application. This is broken in libvirt, but works fine with direct > Qemu invocation. > > Thank you for the help. Please file a bug against libvirt, so this gets fixed. https://bugzilla.redhat.com/

[Qemu-devel] [RfC PATCH 12/15] virtio-vga: add vgabios configuration

2015-02-23 Thread Gerd Hoffmann
Add seavgabios configuration for virtio-vga, hook up the new vgabios in the makefiles. Signed-off-by: Gerd Hoffmann --- Makefile | 2 +- roms/Makefile | 2 +- roms/config.vga-virtio | 6 ++ 3 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 roms/confi

[Qemu-devel] [RfC PATCH 09/15] virtio-vga: add virtio gpu device with vga compatibility

2015-02-23 Thread Gerd Hoffmann
This patch adds a virtio-vga device. It is simliar to virtio-gpu-pci, but it also adds in vga compatibility, so guests without native virtio-gpu support can drive the device in vga mode. Written by Dave Airlie and Gerd Hoffmann. Signed-off-by: Dave Airlie Signed-off-by: Gerd Hoffmann --- defa

[Qemu-devel] [RfC PATCH 03/15] virtio-pci: make pci bars configurable

2015-02-23 Thread Gerd Hoffmann
Add msix_bar and modern_mem_bar fields to VirtIOPCIProxy. They can be used to configure which pci regions are used for the virtio 1.0 memory bar and the msix bar. For legacy/transitional devices the legacy bar is region 0 and the msix bar is region 1. Only the modern bar can be configured, and i

[Qemu-devel] [RfC PATCH 14/15] virtio-gpu: add to display-vga test

2015-02-23 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/Makefile | 3 +++ tests/display-vga-test.c | 18 ++ 2 files changed, 21 insertions(+) diff --git a/tests/Makefile b/tests/Makefile index d5df168..8c169b2 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -131,6 +131,9 @@ check-q

[Qemu-devel] [RfC PATCH 00/15] virtio-gpu:

2015-02-23 Thread Gerd Hoffmann
Hi, After a lng break, here is the next version of virtio-gpu patches. It is the first batch, with the 2d bits, virgl (3d/opengl) support will follow later on. The dust of the virtio-1.0 merge has mostly settled, even though not all virtio-1.0 bits are upstream yet (main reason why this is

[Qemu-devel] [RfC PATCH 02/15] virtio-pci: make QEMU_VIRTIO_PCI_QUEUE_MEM_MULT smaller

2015-02-23 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/virtio/virtio-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 6c0c650..cd7c777 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -975,7 +975,7 @@ static void virti

[Qemu-devel] [RfC PATCH 10/15] virtio-vga: virtio-1.0 adaptions [fixup]

2015-02-23 Thread Gerd Hoffmann
[root@fedora ~]# bin/lspci -vvs2 00:02.0 VGA compatible controller: Red Hat, Inc Device 1050 (rev 01) (prog-if 00 [VGA controller]) Subsystem: Red Hat, Inc Device 1100 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx+ Stat

[Qemu-devel] [RfC PATCH 15/15] [hack] virtio-gpu: maskerade as -device VGA

2015-02-23 Thread Gerd Hoffmann
Newer libvirt versions start looking up VGA in the QOM tree. So tricking libvirt this way ... ... to test virtio-vga stopped working. Lets rename VGA to stdvga and virtio-vga to VGA to get things going again. A simple ... ... will give you virtio-vga when building qemu with t

[Qemu-devel] [RfC PATCH 11/15] virtio-vga: add '-vga virtio' support

2015-02-23 Thread Gerd Hoffmann
Some convinience fluff: Add support for '-vga virtio', also add virtio-vga to the list of vga cards so '-device virtio-vga' will turn off the default vga. Written by Dave Airlie and Gerd Hoffmann. Signed-off-by: Dave Airlie Signed-off-by: Gerd Hoffmann --- hw/pci/pci.c| 2 ++ inc

[Qemu-devel] [RfC PATCH 04/15] virtio-pci: make modern bar 64bit prefetchable

2015-02-23 Thread Gerd Hoffmann
Modern bar is made prefetchable. In case it is configured to use one of the bars 0, 2, or 4 (which by default is the case) it is also configured as 64bit region. Signed-off-by: Gerd Hoffmann --- hw/virtio/virtio-pci.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --gi

[Qemu-devel] [RfC PATCH 08/15] virtio-gpu-pci: virtio-1.0 adaptions [fixup]

2015-02-23 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/virtio-gpu-pci.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/hw/display/virtio-gpu-pci.c b/hw/display/virtio-gpu-pci.c index 77c5e06..791ee8b 100644 --- a/hw/display/virtio-gpu-pci.c +++ b/hw/display/virtio-gpu-pci.c

[Qemu-devel] [RfC PATCH 07/15] virtio-gpu-pci: add virtio pci support

2015-02-23 Thread Gerd Hoffmann
This patch adds virtio-gpu-pci, which is the pci proxy for the virtio gpu device. With this patch in place virtio-gpu is functional. You need a linux guest with a virtio-gpu driver though, and output will appear pretty late in boot, once the kernel initialized drm and fbcon. Written by Dave Airl

[Qemu-devel] [RfC PATCH 06/15] virtio-gpu/2d: add virtio gpu core code

2015-02-23 Thread Gerd Hoffmann
This patch adds the core code for virtio gpu emulation, covering 2d support. Written by Dave Airlie and Gerd Hoffmann. Signed-off-by: Dave Airlie Signed-off-by: Gerd Hoffmann --- hw/display/Makefile.objs | 2 + hw/display/virtio-gpu.c| 903 ++

[Qemu-devel] [RfC PATCH 05/15] virtio-gpu/2d: add hardware spec include file

2015-02-23 Thread Gerd Hoffmann
This patch adds the header file with structs and defines for the virtio based gpu device. Covers 2d operations only. Written by Dave Airlie and Gerd Hoffmann. Signed-off-by: Dave Airlie Signed-off-by: Gerd Hoffmann --- include/hw/virtio/virtgpu_hw.h | 203 +

[Qemu-devel] [RfC PATCH 13/15] virtio-vga: add vgabios binary

2015-02-23 Thread Gerd Hoffmann
Add prebuilt vgabios-virtio.bin binary. Signed-off-by: Gerd Hoffmann --- pc-bios/vgabios-virtio.bin | Bin 0 -> 37376 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 pc-bios/vgabios-virtio.bin diff --git a/pc-bios/vgabios-virtio.bin b/pc-bios/vgabios-virtio.bin new fil

[Qemu-devel] [RfC PATCH 01/15] virtio-pci: add flags to enable/disable legacy/modern

2015-02-23 Thread Gerd Hoffmann
Add VIRTIO_PCI_FLAG_DISABLE_LEGACY and VIRTIO_PCI_FLAG_DISABLE_MODERN for VirtIOPCIProxy->flags. Also add properties for them. They can be used to disable modern (virtio 1.0) or legacy (virtio 0.9) modes. By default both are advertized and the guest driver can choose. Signed-off-by: Gerd Hoffma

Re: [Qemu-devel] [PATCH v7 00/10] rocker: add new rocker ethernet switch device

2015-02-23 Thread Stefan Hajnoczi
On Mon, Feb 16, 2015 at 01:47:41PM -0800, sfel...@gmail.com wrote: > v7: > > - Per Stefan Hajnoczi comments: > - #ifdef CONFIG_ROCKER wrapper around qmp/hmp to fix compile when PCI is >disabled or rocker is disabled. Thanks, applied patches except the QMP patch to my net tree: https

Re: [Qemu-devel] [Bug 1423124] [NEW] QEMU crash after sending data on host serial port

2015-02-23 Thread Stefan Hajnoczi
On Wed, Feb 18, 2015 at 11:29:58AM -, Ugo wrote: > I'm using QEMU for Windows last version. > The host system is Windows 7 64bits. > I'm excuting the following statment : > > qemu-system-x86_64w.exe -hda debian.img -m 256 -net nic -net > tap,ifname=TAP32 -soundhw all -serial COM9 > > Qemu sta

Re: [Qemu-devel] [PATCH v3 0/3] -incoming defer

2015-02-23 Thread Stefan Hajnoczi
On Thu, Feb 19, 2015 at 11:40:26AM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > This patchset provides a way of setting options on an incoming > migration before the fd/process/socket has been created. > >start qemu with -incoming defer > >migrate

Re: [Qemu-devel] [PATCH] savevm: create snapshot failed when id_str already exits

2015-02-23 Thread Amit Shah
On (Mon) 12 Jan 2015 [01:12:41], Yi Wang wrote: > From b119164ba6715f53594facfc4d1022c198852e9d Mon Sep 17 00:00:00 2001 > From: Yi Wang > Date: Mon, 12 Jan 2015 00:05:40 +0800 > Subject: [PATCH] savevm: create snapshot failed when id_str already exits > > Create snapshot failed in this case: > 1

Re: [Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-02-23 Thread Stefan Hajnoczi
On Thu, Feb 19, 2015 at 05:48:03PM -, Pierre Schweitzer wrote: > Thanks Max & Stefan. > > Could you please let me know when the commit makes it to the QEMU > repository? And give me its commit ID? > > So that I can ask for a bugfix backport in Trusty. Hi Pierre, In case I forget, please foll

Re: [Qemu-devel] [PATCH] e1000: work around win 8.0 boot hang

2015-02-23 Thread Stefan Hajnoczi
On Thu, Feb 19, 2015 at 09:37:46PM +0100, Radim Krčmář wrote: > 2015-02-19 20:24+0100, Radim Krčmář: > > diff --git a/hw/net/e1000.c b/hw/net/e1000.c > > @@ -138,6 +138,10 @@ typedef struct E1000State_st { > > +#define E1000_WIN8_WORKAROUND_ICR E1000_ICR_RXT0 > > +#define E1000_WIN8_WORKAROUN

Re: [Qemu-devel] [PATCH v3 0/3] -incoming defer

2015-02-23 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@gmail.com) wrote: > On Thu, Feb 19, 2015 at 11:40:26AM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > This patchset provides a way of setting options on an incoming > > migration before the fd/process/socket has been created. > >

Re: [Qemu-devel] vmdk: improve streamOptimized vmdk support

2015-02-23 Thread Kevin Wolf
Am 23.02.2015 um 09:10 hat Markus Armbruster geschrieben: > Perhaps Fam (cc'ed) can help you. > > Sunil Kumar writes: > > [...] > > Hi, > > > > I ran into an issue where the OVA created from the VMDK file created > > by qemu-img is rejected by vSphere with a message like "Not a > > supported dis

Re: [Qemu-devel] [Xen-devel] [Block dev] : Qemu block ide_dma_read call routine

2015-02-23 Thread Kevin Wolf
Am 11.02.2015 um 04:51 hat Shailesh Kumar geschrieben: > Hi, > > I am implementing read equivalent routine in qemu. Can some one > help me understand control flow of the qemu read/write > implementation. > > I am using xen-4.2.0 and qemu-1.6.1 > > My requirement is simple: > > I have a 102

Re: [Qemu-devel] unable to set SATA serial with a spaces

2015-02-23 Thread Michal Privoznik
On 23.02.2015 11:18, Markus Armbruster wrote: > Alan Latteri writes: > >> The left padding is important and necessary to keep for my particular >> application. This is broken in libvirt, but works fine with direct >> Qemu invocation. >> >> Thank you for the help. > > Please file a bug against

Re: [Qemu-devel] [RFC PATCH] utils: Add up_pow_of_two()

2015-02-23 Thread Alexey Kardashevskiy
On 02/23/2015 07:54 PM, Peter Maydell wrote: On 23 February 2015 at 16:49, Alexey Kardashevskiy wrote: This adds a helper to get closest bigger power-of-two value. Signed-off-by: Alexey Kardashevskiy --- It is a log2 of round up to power of two. Is there anything like this in QEMU already? A

[Qemu-devel] [PATCH v3 0/2] integrator/cp: Working SD card support

2015-02-23 Thread Jan Kiszka
Addressing Peter Crosthwaite's comments on v2 (thanks!). Jan Jan Kiszka (2): integrator/cp: Model CP control registers as sysbus device integrator/cp: Implement CARDIN and WPROT signals hw/arm/integratorcp.c | 95 --- 1 file changed, 82 insert

[Qemu-devel] [PATCH v3 1/2] integrator/cp: Model CP control registers as sysbus device

2015-02-23 Thread Jan Kiszka
No new features yet, just encapsulation. Signed-off-by: Jan Kiszka --- hw/arm/integratorcp.c | 35 +++ 1 file changed, 27 insertions(+), 8 deletions(-) diff --git a/hw/arm/integratorcp.c b/hw/arm/integratorcp.c index 8c48b68..2d62275 100644 --- a/hw/arm/integrato

[Qemu-devel] [PATCH v3 2/2] integrator/cp: Implement CARDIN and WPROT signals

2015-02-23 Thread Jan Kiszka
This allows to use the SD card emulation of the board: Forward the signals from the pl181 top the CP control register emulation, report the current state via CP_INTREG, deliver CARDIN IRQ to the secondary interrupt controller and also support clearing that line via CP_INTREG. Signed-off-by: Jan Ki

Re: [Qemu-devel] [PATCH 2/3] block: Add QMP support for streaming to an intermediate layer

2015-02-23 Thread Alberto Garcia
On Fri, Feb 20, 2015 at 03:38:04PM -0700, Eric Blake wrote: > > +if (has_top) { > > +top_bs = bdrv_find_backing_image(bs, top); > > +if (top_bs == NULL) { > > +error_set(errp, QERR_TOP_NOT_FOUND, top); > > +goto out; > > +} > > If I understand c

[Qemu-devel] [PATCH v2] utils: Add pow2ceil()

2015-02-23 Thread Alexey Kardashevskiy
This adds a helper to get closest bigger power-of-two value. Signed-off-by: Alexey Kardashevskiy --- Changes: v2: * s/up_pow_of_two/pow2ceil/ --- include/qemu-common.h | 2 ++ util/cutils.c | 9 + 2 files changed, 11 insertions(+) diff --git a/include/qemu-common.h b/include/qem

[Qemu-devel] [PATCH v2 0/3] migration: Fixups for VMDESC submission

2015-02-23 Thread Alexander Graf
After the vmdesc self-describing JSON blob landed upstream, some people noticed their self-written scripts around migration to fail. This patch set aims at making the transition to the new VMDESC containing migration format as smooth as possible for everyone involved. Alexander Graf (3): migrat

[Qemu-devel] [PATCH v2 2/3] migration: Allow to suppress vmdesc submission

2015-02-23 Thread Alexander Graf
We now always send a JSON blob describing the migration file format as part of the migration stream. However, some tools built around QEMU have proven to stumble over this. This patch gives the user the chance to disable said self-describing part of the migration stream. To disable vmdesc submissi

[Qemu-devel] [PATCH v2 3/3] pc: Disable vmdesc submission for old machines

2015-02-23 Thread Alexander Graf
Older PC machine types might by accident be backwards live migration compatible, but with the new vmdesc self-describing blob in our live migration stream we would break that compatibility. Also users wouldn't expect massive behaviorial differences when updating to a new version of QEMU while reta

[Qemu-devel] [PATCH v2 1/3] migration: Read JSON VM description on incoming migration

2015-02-23 Thread Alexander Graf
One of the really nice things about the VM description format is that it goes over the wire when live migration is happening. Unfortunately QEMU today closes any socket once it sees VM_EOF coming, so we never give the VMDESC the chance to actually land on the wire. This patch makes QEMU read the d

Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models

2015-02-23 Thread Christian Borntraeger
Am 20.02.2015 um 16:22 schrieb Alexander Graf: > > > >> Am 20.02.2015 um 16:00 schrieb Michael Mueller : >> >> On Fri, 20 Feb 2015 14:54:23 +0100 >> Alexander Graf wrote: >> +/* machine related properties */ +typedef struct S390CPUMachineProps { +uint16_t class; /*

Re: [Qemu-devel] [PATCH 2/3] block: Add QMP support for streaming to an intermediate layer

2015-02-23 Thread Kevin Wolf
Am 23.02.2015 um 13:23 hat Alberto Garcia geschrieben: > On Fri, Feb 20, 2015 at 03:38:04PM -0700, Eric Blake wrote: > > > > +if (has_top) { > > > +top_bs = bdrv_find_backing_image(bs, top); > > > +if (top_bs == NULL) { > > > +error_set(errp, QERR_TOP_NOT_FOUND, top

Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models

2015-02-23 Thread Christian Borntraeger
Am 23.02.2015 um 13:56 schrieb Christian Borntraeger: > Am 20.02.2015 um 16:22 schrieb Alexander Graf: >> >> >> >>> Am 20.02.2015 um 16:00 schrieb Michael Mueller : >>> >>> On Fri, 20 Feb 2015 14:54:23 +0100 >>> Alexander Graf wrote: >>> > > +/* machine related properties */ > +typedef

Re: [Qemu-devel] [PATCH] e1000: work around win 8.0 boot hang

2015-02-23 Thread Radim Krčmář
2015-02-23 10:45+, Stefan Hajnoczi: > On Thu, Feb 19, 2015 at 09:37:46PM +0100, Radim Krčmář wrote: > > 2015-02-19 20:24+0100, Radim Krčmář: > > > diff --git a/hw/net/e1000.c b/hw/net/e1000.c > > > @@ -138,6 +138,10 @@ typedef struct E1000State_st { > > > +#define E1000_WIN8_WORKAROUND_ICR

Re: [Qemu-devel] vmdk: improve streamOptimized vmdk support

2015-02-23 Thread Milos Vyletel
On Mon, Feb 23, 2015 at 11:57 AM, Kevin Wolf wrote: > Am 23.02.2015 um 09:10 hat Markus Armbruster geschrieben: >> Perhaps Fam (cc'ed) can help you. >> >> Sunil Kumar writes: >> >> [...] >> > Hi, >> > >> > I ran into an issue where the OVA created from the VMDK file created >> > by qemu-img is re

Re: [Qemu-devel] [PATCH v2] utils: Add pow2ceil()

2015-02-23 Thread Markus Armbruster
Alexey Kardashevskiy writes: > This adds a helper to get closest bigger power-of-two value. > > Signed-off-by: Alexey Kardashevskiy > --- > Changes: > v2: > * s/up_pow_of_two/pow2ceil/ > --- > include/qemu-common.h | 2 ++ > util/cutils.c | 9 + > 2 files changed, 11 insertions(

[Qemu-devel] [PATCH] Add copyright and author after file split

2015-02-23 Thread Stefan Berger
Signed-off-by: Stefan Berger --- migration/qemu-file-buf.c | 4 1 file changed, 4 insertions(+) diff --git a/migration/qemu-file-buf.c b/migration/qemu-file-buf.c index e97e0bd..e56a8ad 100644 --- a/migration/qemu-file-buf.c +++ b/migration/qemu-file-buf.c @@ -2,6 +2,10 @@ * QEMU System

[Qemu-devel] [REPOST PATCH 1/5] tpm: Extend sts register to 32 bit

2015-02-23 Thread Stefan Berger
More recent TIS specs extend the STS register to 32 bit. While we don't store the TIS interface state, yet, we can extend it without sideeffects. Signed-off-by: Stefan Berger --- hw/tpm/tpm_tis.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/tpm/tpm_tis.h b/hw/tpm/tpm_ti

[Qemu-devel] [REPOST PATCH 4/5] tpm: Support for TIS selftest done flag

2015-02-23 Thread Stefan Berger
Extend the backend to check whether the TPM_ContinueSelfTest finished successfully and provide a flag to the TIS front-end if it successfully finished. The TIS then sets a flag in all localities in the STS register and keeps it until the next reset. Signed-off-by: Stefan Berger --- hw/tpm/tpm_in

[Qemu-devel] [REPOST PATCH 5/5] tpm: Support for capability flags of TIS 1.3

2015-02-23 Thread Stefan Berger
Provide the TIS 1.3 capability flags. The interface now looks like a TIS 1.3 interface. It's fully compatible with previous TIS 1.2 and drivers written for TIS 1.2 continue to work. Signed-off-by: Stefan Berger --- hw/tpm/tpm_tis.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) d

[Qemu-devel] [REPOST PATCH 2/5] tpm: Allow 32 & 16 bit accesses to the registers

2015-02-23 Thread Stefan Berger
Improve the access to the registers with 32 and 16 bit reads and writes. Also enable access to a non-base register address, such as reads of the 2nd byte of a register. Map the FIFO byte access to any byte within its 4 byte register (following specs). Signed-off-by: Stefan Berger --- hw/tpm/tpm_

[Qemu-devel] [PATCH 2/5] block/vpc: simplify vpc_read

2015-02-23 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/vpc.c | 116 +++ 1 file changed, 52 insertions(+), 64 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index 326c2bb..4e5ba85 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -497,40 +497,70 @@ static

[Qemu-devel] [PATCH 4/5] block/vpc: make calculate_geometry spec conform

2015-02-23 Thread Peter Lieven
The VHD spec [1] allows for total_sectors of 65535 x 16 x 255 (~127GB) represented by a CHS geometry. If total_sectors is greater than 65535 x 16 x 255 this geometry is set as a maximum. Qemu, Hyper-V, VirtualBox and disk2vhd use this special geometry as an indicator to use the image current size

[Qemu-devel] [PATCH 1/5] block/vpc: optimize vpc_co_get_block_status

2015-02-23 Thread Peter Lieven
*pnum can't be greater than s->block_size / BDRV_SECTOR_SIZE for allocated sectors since there is always a bitmap in between. Signed-off-by: Peter Lieven --- block/vpc.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index 1533b6a.

[Qemu-devel] [PATCH 0/5] block/vpc optimizations

2015-02-23 Thread Peter Lieven
This series covers VPC format changes discussed during the last weeks. Peter Kevin Wolf (1): vpc: Ignore geometry for large images Peter Lieven (4): block/vpc: optimize vpc_co_get_block_status block/vpc: simplify vpc_read block/vpc: make calculate_geometry spec conform block/vpc: renam

[Qemu-devel] [PATCH 5/5] block/vpc: rename footer->size -> footer->current_size

2015-02-23 Thread Peter Lieven
the field is named current size in the spec. Name it accordingly. Signed-off-by: Peter Lieven --- block/vpc.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index 9c5301b..a9d2b62 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -66,7 +66,7

[Qemu-devel] [PATCH 3/5] vpc: Ignore geometry for large images

2015-02-23 Thread Peter Lieven
From: Kevin Wolf The CHS calculation as done per the VHD spec imposes a maximum image size of ~127 GB. Real VHD images exist that are larger than that. Apparently there are two separate non-standard ways to achieve this: You could use more heads than the spec does - this is the option that qemu-

[Qemu-devel] [REPOST PATCH 3/5] tpm: Support for XFIFO register

2015-02-23 Thread Stefan Berger
Support for the XFIFO register (range) of the TIS 1.3 specification. We support a range of 64 bytes. Signed-off-by: Stefan Berger --- hw/tpm/tpm_tis.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c index 6170693..a37c7ce 100644 --- a/hw/tpm/tpm_tis.c

Re: [Qemu-devel] [PATCH] e1000: work around win 8.0 boot hang

2015-02-23 Thread Stefan Hajnoczi
On Mon, Feb 23, 2015 at 1:45 PM, Radim Krčmář wrote: > 2015-02-23 10:45+, Stefan Hajnoczi: >> On Thu, Feb 19, 2015 at 09:37:46PM +0100, Radim Krčmář wrote: >> > 2015-02-19 20:24+0100, Radim Krčmář: >> > > diff --git a/hw/net/e1000.c b/hw/net/e1000.c >> > > @@ -138,6 +138,10 @@ typedef struct E

[Qemu-devel] [PULL 06/11] pci: add rocker device ID

2015-02-23 Thread Stefan Hajnoczi
From: Scott Feldman Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko Message-id: 1424123271-7656-5-git-send-email-sfel...@gmail.com Signed-off-by: Stefan Hajnoczi --- docs/specs/pci-ids.txt | 1 + include/hw/pci/pci.h | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/specs/pc

[Qemu-devel] [PULL 03/11] net: add MAC address string printer

2015-02-23 Thread Stefan Hajnoczi
From: Scott Feldman We can use this in virtio-net code as well as new Rocker driver code, so up-level this. Signed-off-by: Scott Feldman Reviewed-by: Eric Blake Message-id: 1424123271-7656-2-git-send-email-sfel...@gmail.com Signed-off-by: Stefan Hajnoczi --- include/net/net.h | 1 + net/net.

[Qemu-devel] [PULL 02/11] tests: rtl8139: test timers and interrupt

2015-02-23 Thread Stefan Hajnoczi
From: Frediano Ziglio Test behaviour of timers and interrupts related to timeouts. Signed-off-by: Frediano Ziglio Reviewed-by: Paolo Bonzini Message-id: 1420742303-3030-1-git-send-email-fredd...@gmail.com Signed-off-by: Stefan Hajnoczi --- tests/Makefile | 2 +- tests/rtl8139-test.c

[Qemu-devel] [PULL 10/11] MAINTAINERS: add rocker

2015-02-23 Thread Stefan Hajnoczi
From: Scott Feldman Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko Message-id: 1424123271-7656-10-git-send-email-sfel...@gmail.com Signed-off-by: Stefan Hajnoczi --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8c06739..2ea3625

[Qemu-devel] [PULL 00/11] Net patches

2015-02-23 Thread Stefan Hajnoczi
The following changes since commit cd2d5541271f1934345d8ca42f5fafff1744eee7: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20150212' into staging (2015-02-13 11:44:50 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/net-pull-request for you t

[Qemu-devel] [PULL 09/11] rocker: add tests

2015-02-23 Thread Stefan Hajnoczi
From: Scott Feldman Add some basic test for rocker to test L2/L3/L4 functionality. Requires an external test environment, simp, located here: https://github.com/scottfeldman/simp To run tests, simp environment must be installed and a suitable VM image built and installed with a Linux 3.18 (or

[Qemu-devel] [PULL 11/11] rocker: timestamp on the debug logs helps correlate with events in the VM

2015-02-23 Thread Stefan Hajnoczi
From: David Ahern Signed-off-by: David Ahern Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko Message-id: 1424123271-7656-11-git-send-email-sfel...@gmail.com Signed-off-by: Stefan Hajnoczi --- hw/net/rocker/rocker.h | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) dif

[Qemu-devel] [PULL 01/11] net: synchronize net_host_device_remove with host_net_remove_completion

2015-02-23 Thread Stefan Hajnoczi
From: Paolo Bonzini Using net_host_check_device is unnecessary. qemu_del_net_client asserts for the non-peer case that it can only process NIC type NetClientStates, and that assertion is valid for the peered case as well, so move it and use the same check in net_host_device_remove. host_net_rem

[Qemu-devel] [PULL 04/11] virtio-net: use qemu_mac_strdup_printf

2015-02-23 Thread Stefan Hajnoczi
From: Scott Feldman Signed-off-by: Scott Feldman Reviewed-by: Eric Blake Message-id: 1424123271-7656-3-git-send-email-sfel...@gmail.com Signed-off-by: Stefan Hajnoczi --- hw/net/virtio-net.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/hw/net/virtio-net.c b

[Qemu-devel] [PULL 07/11] pci: add network device class 'other' for network switches

2015-02-23 Thread Stefan Hajnoczi
From: Scott Feldman Rocker is an ethernet switch device, so add 'other' network device class as defined by PCI to cover these types of devices. Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko Message-id: 1424123271-7656-6-git-send-email-sfel...@gmail.com Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PULL 05/11] rocker: add register programming guide

2015-02-23 Thread Stefan Hajnoczi
From: Scott Feldman This is the register programming guide for the Rocker device. It's intended for driver writers and device writers. It covers the device's PCI space, the register set, DMA interface, and interrupts. Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko Message-id: 1424123

Re: [Qemu-devel] [PATCH v3 16/17] ahci: Recompute cur_cmd on migrate post load

2015-02-23 Thread Stefan Hajnoczi
On Tue, Feb 10, 2015 at 01:19:28PM -0500, John Snow wrote: > diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c > index 56a4867..5a1973f 100644 > --- a/hw/ide/ahci.c > +++ b/hw/ide/ahci.c > @@ -1376,6 +1376,11 @@ static int ahci_state_post_load(void *opaque, int > version_id) > */ > if

[Qemu-devel] [PATCH] block/vpc: fix get_sector_offset for vpc_read

2015-02-23 Thread Peter Lieven
VHD images contain a bitmap at the beginning of each data block to indicate the allocation status of each sector in the data block. vpc_read currently checks the allocation status of the first sector in a data block it is going to read and then assumes the same allocation status for the whole rema

Re: [Qemu-devel] [RFC PATCH v1 04/13] spapr: Factor out CPU initialization code into realizefn

2015-02-23 Thread Alexander Graf
On 23.02.15 08:36, Bharata B Rao wrote: > On Fri, Jan 30, 2015 at 01:19:39PM +0530, Bharata B Rao wrote: >> On Thu, Jan 29, 2015 at 12:07:42PM +1100, David Gibson wrote: >>> On Thu, Jan 08, 2015 at 11:40:11AM +0530, Bharata B Rao wrote: Move some CPU initialization code from machine init fun

Re: [Qemu-devel] [PATCH 1/3] tcg: add TCG_TARGET_TLB_DISPLACEMENT_BITS

2015-02-23 Thread Alexander Graf
On 20.02.15 20:36, Richard Henderson wrote: > On 02/20/2015 09:57 AM, Paolo Bonzini wrote: >> diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-target.h >> index 7a9980e..8ba977a 100644 >> --- a/tcg/i386/tcg-target.h >> +++ b/tcg/i386/tcg-target.h >> @@ -25,6 +25,7 @@ >> #define TCG_TARGET_I386

Re: [Qemu-devel] [PATCH v14 10/19] qapi: Add transaction support to block-dirty-bitmap operations

2015-02-23 Thread Max Reitz
On 2015-02-20 at 18:07, John Snow wrote: This adds four qmp commands to transactions. Users can stop a dirty bitmap, start backup of it, and start another dirty bitmap atomically, so that the dirty bitmap is tracked incrementally and we don't miss any write. For starting a new incremental backu

Re: [Qemu-devel] [PATCH 1/3] tcg: add TCG_TARGET_TLB_DISPLACEMENT_BITS

2015-02-23 Thread Richard Henderson
On 02/23/2015 05:21 AM, Alexander Graf wrote: > I suppose Paolo is already off to the hospital ;). Richard, if I just > s/32/31/ in the hunk above, does that mean you ack the patch? Yep. r~

Re: [Qemu-devel] [PATCH] e1000: work around win 8.0 boot hang

2015-02-23 Thread Radim Krčmář
2015-02-23 14:39+, Stefan Hajnoczi: > Since the typo breaks compilation, it shows that the patch was not > tested. That makes me nervous. (It was based on a tested RHEL7 patch. Upstream allowed for better code, so I didn't want to push the ugly, yet working, version.) Honestly, I was hopin

Re: [Qemu-devel] [PATCH] e1000: work around win 8.0 boot hang

2015-02-23 Thread Wei Huang
On 02/23/2015 10:07 AM, Radim Krčmář wrote: > 2015-02-23 14:39+, Stefan Hajnoczi: >> Since the typo breaks compilation, it shows that the patch was not >> tested. That makes me nervous. > > (It was based on a tested RHEL7 patch. Upstream allowed for better > code, so I didn't want to push

Re: [Qemu-devel] [PATCH v3 0/3] -incoming defer

2015-02-23 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, Feb 19, 2015 at 11:40:26AM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > This patchset provides a way of setting options on an incoming > > migration before the fd/process/socket has been created. > >

Re: [Qemu-devel] [PATCH v2] utils: Add pow2ceil()

2015-02-23 Thread Eric Blake
On 02/23/2015 06:59 AM, Markus Armbruster wrote: > Alexey Kardashevskiy writes: > >> This adds a helper to get closest bigger power-of-two value. >> > > Here's how I'd do these functions: > > int64_t pow2floor(int64_t value) > { > assert(value > 0); > return 0x8000u >> clz6

[Qemu-devel] [PATCH v4 01/17] ide: start extracting ide_restart_dma out of bmdma_restart_dma

2015-02-23 Thread John Snow
From: Paolo Bonzini This patch begins refactoring the restart dma functions out of bmdma to be shared with AHCI and other future IDE HBA implementations. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/pci.c | 30 +++--- 1 file changed, 19 insertions(+

[Qemu-devel] [PATCH v4 04/17] ide: do not use BMDMA in restart callback

2015-02-23 Thread John Snow
From: Paolo Bonzini Whenever an error stops the VM, ide_handle_rw_error does "s->bus->dma->unit = s->unit". So we can just use idebus_active_if. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH v4 00/17] ide: rerror/werror migration fixes for IDE/ISA and AHCI

2015-02-23 Thread John Snow
This series fixes rerror/werror support for IDE/ISA and implements it in a migratable way for AHCI. This series also fixes AHCI migration. This series was written mostly by Paolo to unify the restart mechanics of IDE/ISA and IDE/BMDMA, moving much of the restart logic into common code. Many of th

[Qemu-devel] [PATCH v4 09/17] ide: place initial state of the current request to IDEBus

2015-02-23 Thread John Snow
From: Paolo Bonzini This moves more common restarting logic to the core IDE code. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/core.c | 6 ++ hw/ide/internal.h | 2 ++ hw/ide/pci.c | 15 ++- hw/ide/pci.h | 5 ++--- 4 files changed, 16 inser

[Qemu-devel] [PATCH v4 03/17] ide: introduce ide_register_restart_cb

2015-02-23 Thread John Snow
From: Paolo Bonzini A helper is added that registers the IDEDMAOp .restart_cb() via qemu_add_vm_change_state_handler instead of requiring each HBA to register the callback themselves. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/cmd646.c | 3 +-- hw/ide/core.c | 5 ++

[Qemu-devel] [PATCH v4 08/17] ide: replace set_unit callback with more IDEBus state

2015-02-23 Thread John Snow
From: Paolo Bonzini Start moving the initial state of the current request to IDEBus, so that AHCI can use it. The set_unit callback is not used anymore once this is done. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/ahci.c | 7 --- hw/ide/core.c | 6 --

[Qemu-devel] [PATCH v4 02/17] ide: prepare to move restart to common code

2015-02-23 Thread John Snow
From: Paolo Bonzini This patch adds the restart_dma callback and adjusts the ide_restart_dma function to utilize this callback to call the BMDMA-specific restart code instead of statically executing BMDMA-specific code. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/internal

  1   2   >